Jean Chalard
28e0b24965
Merge "Fix a bug where the cache would be out of sync"
2014-02-18 10:58:50 +00:00
Jean Chalard
fe92c174ea
Fix a bug where the cache would be out of sync
...
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.
Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
2014-02-18 19:55:54 +09:00
Jean Chalard
63be066544
Cleanup.
...
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.
Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
2014-02-18 17:07:46 +09:00
Yohei Yukawa
6d43124215
Stop using deprecated InputMethodSubtype constructor
...
The constructors of InputMethodSubtype were deprecated in API level 19.
However we cannot yet switch to a new InputMethodSubtypeBuilder style
due to our minimum support API level.
As an intermediate solution, this patch replaces the these API calls
with InputMethodSubtypeCompatUtils.newInputMethodSubtype so that
these legacy API call can be consolidated at the same place.
BUG: 13030512
Change-Id: I561a585f5dbea56c337680b645be5ef07015a0b1
2014-02-17 15:32:33 +09:00
Keisuke Kuroyanagi
95d16561e0
Remove unused code.
...
Bug: 12810574
Change-Id: I9c7fff60ae0e94d52f3bd19c3e88de5a53b917d7
2014-02-15 17:39:24 +09:00
Keisuke Kuroyanagi
0fc93fe445
Implement PatriciaTriePolicy::getNextWordAndNextToken().
...
Bug: 12810574
Change-Id: Id1d44f90de9455d9cbe7b6e0a161cae91d6d422c
2014-02-15 17:39:20 +09:00
Keisuke Kuroyanagi
85fe06e759
Merge "Remove unused argument from readDictionaryBinary."
2014-02-14 10:37:56 +00:00
Keisuke Kuroyanagi
8e3a1d0f89
Remove unused argument from readDictionaryBinary.
...
Bug: 12810574
Change-Id: Ice415ebd8d11162facca3fe8927ef8a616b11424
2014-02-14 19:02:15 +09:00
Keisuke Kuroyanagi
8fa7a09f1e
Merge "Implement PatriciaTriePolicy::getWordProperty()."
2014-02-14 09:08:09 +00:00
Tadashi G. Takaoka
e4b0add353
Fix SpacingAndPunctuationsTests due to I2219224840
...
Bug: 12640318
Change-Id: If0b0696b937c580d69cb909ddaf414d01ea2c01b
2014-02-14 17:59:53 +09:00
Keisuke Kuroyanagi
c63d183473
Implement PatriciaTriePolicy::getWordProperty().
...
Bug: 12810574
Change-Id: I7bcccfd3641ebbcf2b8d857d33bb4734c42af5eb
2014-02-14 17:56:45 +09:00
Tadashi G. Takaoka
a273319c59
Add PunctuationSuggestions class
...
This change must be checked in together with I366c477516.
Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f
2014-02-14 14:13:39 +09:00
Tadashi G. Takaoka
bd0591ce62
Merge "Make InputLogicTest more robust"
2014-02-13 10:44:44 +00:00
Tadashi G. Takaoka
da973e75dc
Make InputLogicTest more robust
...
Change-Id: I134f14971126cbeed05b472c08747f2b88ad30e6
2014-02-13 19:38:51 +09:00
Jean Chalard
5dc0d405b4
Merge "Clean-up follow-up to I3ecc8496"
2014-02-13 10:26:48 +00:00
Jean Chalard
2d68f4b392
Clean-up follow-up to I3ecc8496
...
Change-Id: I8db952a4152dab027e4f34bc5270bfca508d154d
2014-02-13 19:18:29 +09:00
Tadashi G. Takaoka
7ae6721ffa
Remove RTL aware !code and add corresponding !text
...
Change-Id: I9021c8fa1cf2d4ac07579237a939c15551509a0b
2014-02-13 17:32:09 +09:00
Tadashi G. Takaoka
36b8962a9a
Merge "Fix UserHistoryDictionaryTests"
2014-02-13 07:49:51 +00:00
Tadashi G. Takaoka
0cda0e8a9c
Fix UserHistoryDictionaryTests
...
Change-Id: I5f2f555f9c3f471545921ef80e4cf528976be837
2014-02-13 16:16:44 +09:00
Jean Chalard
e0a425681c
Merge "Fix a test."
2014-02-13 05:20:58 +00:00
Jean Chalard
cf03ff02b1
Fix a test.
...
This fixes two separate problems:
- The word finds itself with two separate suggestion spans.
This is fine for LatinIME, but it's hard to predict whether it's
fine for other interested parties (other keyboards).
- The test for the blue underline was incorrect.
Change-Id: I3ecc849676851bf25a25238d694adaa956521a26
2014-02-13 14:01:37 +09:00
Jean Chalard
bac89ecc50
Fix a failing test.
...
A replay of that old, horribly hard-to-find bug: we post a
resume message during onStartInputView, so we need
to process it before we start the test. But now the message
is posted with a delay, so we need to wait for the delay...
Change-Id: I843d70e636fa51a68aadbdbbaa73b1711ad7bddd
2014-02-12 23:32:51 +09:00
Keisuke Kuroyanagi
2ef87aee3e
Merge "Make PtNode have ProbabilityInfo instead of raw value."
2014-02-10 06:10:51 +00:00
Keisuke Kuroyanagi
8ffc631826
Make PtNode have ProbabilityInfo instead of raw value.
...
Bug: 11281877
Bug: 12810574
Change-Id: Id1cda0afc74c4e30633c735729143491b2274a7b
2014-02-10 15:05:08 +09:00
Tadashi G. Takaoka
bd9887a574
Fix possible NPE while finding device override value from resource
...
Bug: 12949735
Change-Id: Iffda08db413b3b3d338ab9bf625bb0968c2e48dd
2014-02-10 14:38:53 +09:00
Tadashi G. Takaoka
a9e1db6636
Merge "Decimal number is treated as outputText"
2014-02-07 09:26:04 +00:00
Keisuke Kuroyanagi
6422f77e94
Merge "Use native logic to read Ver4 dict."
2014-02-06 13:00:09 +00:00
Keisuke Kuroyanagi
ab6a93773b
Use native logic to read Ver4 dict.
...
Bug: 11281877
Bug: 12810574
Change-Id: Ief371d3ef61818e4e031de4659aee3c9584c7379
2014-02-06 21:55:37 +09:00
Tadashi G. Takaoka
3bbd50c36b
Use SubtypeLocaleUtils.isRtlLanguage
...
Change-Id: Ic0208412cd9c02975641cb5c448d092f28786746
2014-02-06 18:15:32 +09:00
Jean Chalard
a9e1930a6a
Merge "Conditionally store the raw suggestions."
2014-02-06 07:31:22 +00:00
Tadashi G. Takaoka
4a64ad9538
Decimal number is treated as outputText
...
Change-Id: I9d4a8ac5dd26a7c41fcfbe1842a40f347a2f2aab
2014-02-06 16:30:12 +09:00
Jean Chalard
a49f61f8a7
Conditionally store the raw suggestions.
...
Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19
2014-02-06 16:14:41 +09:00
Keisuke Kuroyanagi
337dce8074
Merge "Consolidate WordProperty and Word."
2014-02-06 07:02:07 +00:00
Keisuke Kuroyanagi
5f5feeba13
Consolidate WordProperty and Word.
...
Bug: 11281877
Bug: 12810574
Change-Id: I9dc99188f80f25a8780c1860dab46e4aa80a23e5
2014-02-06 15:13:33 +09:00
Jean Chalard
58eed6360d
Merge "Stop considering personalization dicts outputs as words"
2014-02-05 13:33:12 +00:00
Jean Chalard
5095fabdd0
Stop considering personalization dicts outputs as words
...
Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410
2014-02-05 21:57:37 +09:00
Keisuke Kuroyanagi
239f7daf4a
Merge "Make WeightedString have ProbabilityInfo."
2014-02-05 12:53:14 +00:00
Keisuke Kuroyanagi
df1d3e733e
Make WeightedString have ProbabilityInfo.
...
Bug: 11281877
Bug: 12810574
Change-Id: I265e3d8654c75766cd0e0d09d67ef62b4566298a
2014-02-05 21:44:55 +09:00
Tadashi G. Takaoka
02a534d13f
Merge "Treat a sole "|" as a special case of key label"
2014-02-05 09:32:12 +00:00
Tadashi G. Takaoka
6e5dbdd501
Merge "Add null check to KeySpecParser"
2014-02-05 09:32:04 +00:00
Jean Chalard
b162911fa4
Merge "[HD04] Make the locale mandatory."
2014-02-05 09:16:17 +00:00
Tadashi G. Takaoka
f7d8b8fcbc
Treat a sole "|" as a special case of key label
...
Change-Id: Ia72c31d15c891fa522935ba9792e88fd5d8ce7f7
2014-02-05 17:57:44 +09:00
Tadashi G. Takaoka
d9c6b33209
Add null check to KeySpecParser
...
Change-Id: Ic37db8cbf8f83f753d7381e1edba8eac1ef1ceb1
2014-02-05 17:49:26 +09:00
Jean Chalard
43cf9076b2
[HD04] Make the locale mandatory.
...
Bug: 11281748
Change-Id: I69281b0053bec404c3e3c713ade3f65a140f51b1
2014-02-05 17:35:25 +09:00
Tadashi G. Takaoka
2151216c09
Rename base test class KeySpecParserTestsBase
...
Change-Id: I41e1ccb3f0cfde4e5ae311a763e5659e5ff71d3c
2014-02-05 14:55:36 +09:00
Tadashi G. Takaoka
e158c92ae1
Merge "Add KeySpecParser unit test"
2014-02-05 03:35:17 +00:00
Keisuke Kuroyanagi
b986f78ba8
Separate header class from FormatSpec.
...
Bug: 12810574
Change-Id: Iacf1cd05a268bf690ab864b5e32a18a4b0ccc693
2014-02-04 21:36:04 +09:00
Tadashi G. Takaoka
853e8d8869
Add KeySpecParser unit test
...
Change-Id: Ie1c32daecefc2909e58056f515631cbd7de687f7
2014-02-04 19:01:45 +09:00
Keisuke Kuroyanagi
d79fd29f61
Make dumpAllWordsForDebug() use getNextWordProperty().
...
Bug: 11736680
Bug: 12810574
Change-Id: I32a388e23ee7da5d7291e88a46c90b61d2f25dee
2014-02-04 13:51:49 +09:00
Keisuke Kuroyanagi
941734695b
Implement Ver4PatriciaTriePolicy::getNextWordAndNextToken.
...
Bug: 12810574
Change-Id: Idea44f03c477964f58e65fbf2b55e3fcd77a2934
2014-02-04 12:42:14 +09:00