69c04cadc7
Race condition in cursor move.
...
The method WordComposer.moveCursorByAndReturnIfInsideComposingWord() iterates
through all the code points in the word that's currently being composed, and
it tries to adjust the cursor position by a given amount (left or right).
It copies the code points to a new array while processing. But the code point
count comes from a member variable. If the member variable changes while the
method is processing the copy of the code points, it can run over the length
of the code point array.
Bug 18876474.
Change-Id: Ib3a2d90a4e82b76d381efa774e6b3d6bca99c869
2015-02-27 10:29:47 -08:00
c83352d527
Merge "Refresh pref settings for cloud sync"
2015-02-26 22:10:02 +00:00
8ec328fb2e
Refresh pref settings for cloud sync
...
- Show the opt-in text
- Show the account picker if user presses 'enable sync'. Previously
we disabled the sync pref which was confusing.
- Remove the debug tags from some prefs; and improve messaging overall
General rules;
- sync is turned ON : user checks 'enable sync' pref AND
accepts the opt-in AND chooses an account
- sync is turned OFF: when user signs out
Demo link
https://drive.google.com/a/google.com/file/d/0B9tNQOWdRuiWSUdVVE5rVDJudlk/view?usp=sharing
Change-Id: I2e7933796b15e47005ba9970a8c1294416ef31a0
2015-02-26 11:43:42 -08:00
edd94a449e
Ignore the Emoji key when not connected.
...
When the LatinIME does not have an active InputConnection, it will not try
to toggle the Emoji keyboard.
Bug 19513415.
Change-Id: I31f928cd7db1cddd771c548cd3dc42f8af64d0e2
2015-02-26 11:10:37 -08:00
48b071249c
Merge "Share decoders among latinime components."
2015-02-26 17:54:26 +00:00
7d7f082075
Stop waking up to decay dynamic dictionaries.
...
Bug 19516048.
Change-Id: Ibc27a792b4fa80fa8c6af4721c47a617526e9584
2015-02-25 20:13:59 -08:00
e4619f029e
Merge "Don't assume that correctable words are invalid"
2015-02-26 03:44:20 +00:00
48ba1ea19f
Merge "Make DictionaryFactory.killDictionary public"
2015-02-26 03:33:08 +00:00
5551302d27
Don't assume that correctable words are invalid
...
Currently, the Delight3DictionaryFacilitator sets a boolean flag when the top
suggestion score exceeds the auto-correction threshold. This flag is used to
trigger auto-correction of the typed word. Also, the existing logic assumes
that if allowsToBeAutoCorrected then the word is invalid, which is no longer
true after we stopped using whitelists.
Bug 19518376.
Change-Id: Ifa7f6a09c07d25ac68c6cf3aec91f358bd88689f
2015-02-25 17:59:58 -08:00
20fb37afee
Make DictionaryFactory.killDictionary public
...
Change-Id: I9a0733392651714b3ba232cdb805565a5238eb93
2015-02-25 17:53:35 -08:00
b684d2d2e4
Share decoders among latinime components.
...
Change-Id: I6c8d3cf10e05e606308cea42d1e935a415ada9f8
2015-02-25 17:48:30 -08:00
487e038ff3
Use Keyboard in several interfaces.
...
Simplify interfaces by passing Keyboard instead of
KeyboardLayout and ProximityInfo directly. Also require
the Keyboard passed be non-null and change the SpellChecker
to bail out if there is no keyboard for the locale.
Change-Id: I960f15ff60171f55d3e0a96fd6469b7dc3a045e2
2015-02-25 17:20:00 -08:00
ed378c78a1
Auto-correct without whitelist in Delight3.
...
Bug 19390471.
Change-Id: Ie09b916ca80591c98f48ae1d74d4fd5b0c5d6b33
2015-02-25 11:47:43 -08:00
2b8d763c65
Pass ComposedData to the decoder instead of WordComposer.
...
Change-Id: I8bd544d03d9087a02294b08a9986cad229dae795
2015-02-24 17:59:47 -08:00
a3ac6f24cc
Merge "Don't call resetDictionaries if DictionaryFacilitatorLruCache.get() hasn't been called yet. This breaks the AOSP SpellChecker. This seems to be a bug introduced recently, when the DictionaryFacilitatorLruCache was turned into a "cache" of 1 element."
2015-02-25 00:20:32 +00:00
1a6d01b61e
Don't call resetDictionaries if DictionaryFacilitatorLruCache.get()
...
hasn't been called yet. This breaks the AOSP SpellChecker. This seems
to be a bug introduced recently, when the
DictionaryFacilitatorLruCache was turned into a "cache" of 1 element.
Change-Id: I55f6c18b274c9a33fd62cb25bcd02f64788d5ff0
2015-02-24 15:56:43 -08:00
24c282437d
Do not crash when dictioanryInfo is NULL
...
Bug: 19417599
Change-Id: I82174401c595b57b42fc74bc478b551869729ba6
2015-02-24 15:45:10 -08:00
f7058c2a89
Merge "Pass long timestamps to DictionaryFacilitator"
2015-02-24 20:57:34 +00:00
edb2d23802
Check for null TextRange in InputLogic.unlearnWordBeingDeleted
...
Change-Id: Ia0df0ab740c76185f94966f59a74a6ebdd1cffe8
2015-02-24 11:30:42 -08:00
1d5ec6136c
Use DECODER_DICT_SUFFIX on fallback to the default main dict resource.
...
Change-Id: Icec45c364732c0aa9ac713846cad23439b9e42b5
2015-02-23 17:25:08 -08:00
94b8523566
Pass long timestamps to DictionaryFacilitator
...
Change-Id: I95500f210ed409c0ff254b08b68fe3b5b59ba4f4
2015-02-23 16:50:02 -08:00
bae3c4bac5
Merge "Make checksum and header checks decoder dependent."
2015-02-23 21:47:28 +00:00
53b4bfdba0
Merge "Add StatsUtils method for handling subtype change."
2015-02-23 19:11:15 +00:00
08f3cdb3c8
Hide app icon when keyboard is a system app.
...
The objective is to show an app icon when the user installs the keyboard from
the Play Store, but not show the icon when it comes from the system image.
The latter rule applies to AOSP keyboards and to the Google Keyboard on a
Nexus device.
This change partially reverts ag/613096.
Bug 19001197.
Change-Id: Icb202deffe9f1ab2bde9b3c9d221347da6793a19
2015-02-23 10:21:20 -08:00
eeeec21bac
Make checksum and header checks decoder dependent.
...
Change-Id: I0ec4aa69d9b5f013ae926cc368e25225d9d3073b
2015-02-20 18:30:23 -08:00
1c11f3fe0e
Merge "Remove unused APIs in DIctionaryFacilitator"
2015-02-21 01:17:25 +00:00
83e9a29c33
Remove unused APIs in DIctionaryFacilitator
...
Change-Id: Iae20a0a3b7c1aa0c2f6d29cef780fb50dc9010cb
2015-02-20 11:19:27 -08:00
fe3c4ef940
Merge "Spell checker uses cache of size 1."
2015-02-20 19:06:48 +00:00
29aa3df3da
Spell checker uses cache of size 1.
...
This is a step in the direction of removing the LRU cache completely.
Change-Id: I8886f7ef74e6b1b35135e68f169cb461682964e9
2015-02-20 11:05:44 -08:00
01b023730e
Add tests for Contact* classes
...
Also add empty implementation for dictionary
facilitator iteration APIs
Change-Id: Ia847e3faa75075c819fcfda89193d1024d2d5aca
2015-02-20 09:14:27 -08:00
40b754565c
Rename in preparation of caching an instance.
...
Change-Id: I112c957e20d4573daaa71aa218b575037585385c
2015-02-19 15:41:58 -08:00
3bfc9d4692
Merge "Schedule with 0 delay is the same as execute."
2015-02-19 22:42:55 +00:00
6a000183c5
Schedule with 0 delay is the same as execute.
...
Change-Id: Ifadae8aee668edbe2b507735d3ed6e68d52ef329
2015-02-19 14:19:23 -08:00
7041313f71
Merge "If contacts observer is running, return early."
2015-02-19 22:16:33 +00:00
076f76cc12
Merge "Add more options for calling removeWordFromPersonalizedDicts."
2015-02-19 21:31:38 +00:00
edea47ff2e
Add more options for calling removeWordFromPersonalizedDicts.
...
Bug: 19441205
Change-Id: I41aff536a64271d2dc9489a20df33d64170756cc
2015-02-19 12:03:42 -08:00
705b118672
If contacts observer is running, return early.
...
Change-Id: I084a251b0f72288243c73b6166d992b427449635
2015-02-19 11:54:18 -08:00
0b03f13cab
Sanitize the usage of executors.
...
There should be 1 executor each for static and dynamic language models.
This prevents too many dynamic LM updates from running in parallel,
competing for resources.
Change-Id: I8ec439e0ea2d92fba275bc20a0b8c9193346a0c1
2015-02-19 11:40:57 -08:00
40833d2dd7
Add StatsUtils method for handling subtype change.
...
Change-Id: I0f334ab5e6f5aa41ad780641276dc3d2aa232f48
2015-02-18 16:00:59 -08:00
95711bfcee
Add Decoder specific dictionary suffix to resource lookup
...
Change-Id: Ia2c74acdc8ac6f7b605bb06a1078d23b32f388a1
2015-02-12 19:56:46 -08:00
cf84f8ce0c
Switch from script to language codes.
...
Unfortunately, our Locale objects don't always have a script code.
But we can get almost the same functionality by specifying script
codes for some languages, and defaulting the rest to Latin.
Change-Id: Id81ff67bf44c84f44707a2e167c2787c60c6ecee
2015-02-12 15:42:25 -08:00
98596e51a1
Map ISO 15924 codes to internal IME script codes.
...
This way we can support all the languages for which we define a script code.
Bug 19340741.
Change-Id: Ia80eca4cc2511b70f11058f73bd31746948ded19
2015-02-12 11:00:06 -08:00
4084fa5cae
Refactor content provider code from ContactsDict
...
Break contacts binary dictionary into two parts
- one that talks to contacts content provider and maintains
local state. Includes a manager class and a content observer
- other one that just manages the dict code.
Change-Id: Ie8f89ac9ce174c803ff3168ee0bee5cbe7721d5b
2015-02-11 16:29:14 -08:00
5254c01d4c
Fix master build.
...
For some reason, we can't import android.os package in our Constants.
Change-Id: I357ed72d13c5039a83c6e2489cdf5ef74d0ffea8
2015-02-11 13:32:13 -08:00
12d80ebead
Remove shortcut support from LatinIME.
...
Note this change does not affect the native decoder interface.
Change-Id: I73b7dc008a5acaf75a31a36a2d332b5afabd82d0
2015-02-11 13:02:41 -08:00
2979fad213
Merge "Add new class spellcheck.UserDictionaryLookup that can look up the system "Personal dictionary" in the event that the DictionaryFacilitator doesn't."
2015-02-10 23:25:50 +00:00
a7805e9870
Add a addOrIncrement term api to DicFacilitator
...
The API is used by the decoder to add term to the
dictionary.
Change-Id: I607c8c676b7650f3052b2d3ed3f7f656573fca45
2015-02-10 11:45:54 -08:00
8aa310aa5a
Add new class spellcheck.UserDictionaryLookup that can look up the
...
system "Personal dictionary" in the event that the DictionaryFacilitator
doesn't.
Change-Id: Ib4f15ec4d8f06ea43c2e063f5a13a2f699afbb8a
2015-02-10 10:56:35 -08:00
644a709a5f
Remove distracter filter from client.
...
Bug 19296201.
Change-Id: Ic834e5956347cd86a96bd14024c42ad8ee258659
2015-02-09 11:52:12 -08:00
aadfef6ffa
Merge "Move decoder specific constants to DecoderSpecificConstants.java"
2015-02-06 22:46:08 +00:00
d6a8adcb04
Cleanup in preparation of distracter change.
...
Bug 19296201.
Change-Id: If016da2b7f4b3ecb9afd6d7aed9d19fbd4938758
2015-02-06 14:25:37 -08:00
0f7d881dc7
Move decoder specific constants to DecoderSpecificConstants.java
...
Change-Id: Ie4d325b3152e1e7e424b8b436e222e194e4d9da0
2015-02-05 13:27:36 -08:00
608ef4729c
Merge "Add accessor methods for typed word info to SuggestedWords and for word and source dictionary to SuggestedWordInfo."
2015-02-05 03:16:45 +00:00
23d19626f3
Use shared constants in old+new facilitators.
...
Change-Id: I18b701df6ecbcc20ff0c664c218289179c4b2b2d
2015-02-04 18:55:39 -08:00
4e94109031
Add accessor methods for typed word info to SuggestedWords and for word
...
and source dictionary to SuggestedWordInfo.
Change-Id: Ic3bdf67a9edd5352f3b911f5cb72a25986e31e2c
2015-02-04 18:35:20 -08:00
6e0467c20e
Fix accidentally inverted if check.
...
Change-Id: I9c28f4154f69c63564a2bda357c16cef4e68dc0d
2015-02-04 18:23:38 -08:00
c0eb57124f
Don't check user dictionary, except for spelling.
...
We check different lists of dictionaries based on the use case.
Bug 19270992.
Change-Id: Ide69f2855978ebad32a58e9689b3a8d47e095994
2015-02-04 18:23:38 -08:00
c4977b5f89
Merge "Removing code from RichInputConnection."
2015-02-05 01:14:46 +00:00
a6d2cf5ec7
Removing code from RichInputConnection.
...
Followup CL that removes some more unused methods and variables.
Change-Id: I4163c7cd017f59d1fd445adb6294fc89dcaafe6e
2015-02-04 16:47:56 -08:00
7b2646dd58
Merge "Selections spans should not split surrogate pair."
2015-02-05 00:47:29 +00:00
bae6848434
Merge "AOSP changes to use KeyboardLayout to support the new DictionaryFacilitator"
2015-02-05 00:44:10 +00:00
f3c319fb8a
Selections spans should not split surrogate pair.
...
When committing a span after a revert, the offset logic was such that it
split a surrogate unicode pair used to express an emoji.
Checking the last character of the span lets us avoid this problem.
Fix for bug 19255233.
Change-Id: I07d18d9002b5075f7925319dd05962011656c311
2015-02-04 16:35:18 -08:00
b00c054125
AOSP changes to use KeyboardLayout to support the new DictionaryFacilitator
...
Change-Id: Ie0c9ce805d9ad009fc9bbaac37b715aff90cd844
2015-02-04 12:50:31 -08:00
c71e4d6534
Remnant of green [+] feature.
...
Change-Id: I059b1062e1d73b2fa439d9d4ee04ff0182795335
2015-02-04 11:57:16 -08:00
0d3f01f301
Remove last vestiges of contextual+personal dictionary.
...
Change-Id: I20746381583ee8a4d7d42b1243f5c7ba45529e5e
2015-02-04 11:38:19 -08:00
daa3ad8605
Merge "Fix delete handling in Emoji keyboard."
2015-02-04 18:15:28 +00:00
449711dd19
Import translations. DO NOT MERGE
...
Change-Id: I3e9a864efab46895ffc21f73f5d78b7937d701fc
Auto-generated-cl: translation import
2015-02-04 06:56:18 -08:00
00ae43316e
Fix delete handling in Emoji keyboard.
...
Bug 19113652.
Change-Id: I4255c248a25bb92f5c12da6a185d17cc13a9a69d
2015-02-03 18:27:17 -08:00
23574d1231
LatinIME portion of "green plus" feature.
...
Removes the feature that adds strings to the user dictionary,
aka the "green highlight with a plus sign".
Bug 19237189.
Change-Id: I2387129a3add2d69d625f2ff16ed8cab3f10a735
2015-02-03 15:12:01 -08:00
48cc0d6420
Merge "Nuke Amanatto"
2015-02-03 19:20:40 +00:00
15acbdc905
Nuke Amanatto
...
Change-Id: Ieff2cd37f869dca69abf53ac32a576c2e45cc1e3
2015-02-02 17:10:38 -08:00
53e81fdc55
Remove custom code for Emoji keyboard Delete key.
...
The code tries to implement a completely separate touch handler for the Delete
key, so it can do fancy things like suppress haptic feedback during long press.
This is not really necessary.
Change-Id: I0eae758b617e94605035c40e0df15d972ae733c1
2015-02-02 15:24:17 -08:00
cbbe8d0cdc
Import translations. DO NOT MERGE
...
Change-Id: I2785f4af2bee0b126e71b1fa22925e478611857f
Auto-generated-cl: translation import
2015-02-02 06:36:21 -08:00
a0efc133bd
Merge "Create a new KeyboardLayout class to represent the layout."
2015-01-31 01:46:12 +00:00
d543984d2e
Create a new KeyboardLayout class to represent the layout.
...
Change-Id: Ia08c8194f460271c831702675cfb687ab9f6678b
2015-01-30 17:24:09 -08:00
77e0fa1d67
LatinIME portion of multi-lang option removal.
...
Bug 19188067.
Change-Id: Ic9a3637f59dda30c699141222b9dcac3cd624b99
2015-01-29 15:57:03 -08:00
e1758feeff
Disable the Burmese keyboard.
...
We'll resurrect this effort in the new code base.
Bug 16900511.
Change-Id: Iae4cd27cb29cb8f991e97cffd88ed59c30d66628
2015-01-29 10:17:33 -08:00
ab6f3b36d0
Change DictionaryFacilitator.java to an interface, create its
...
implementation DictionaryFacilitatorImpl.java and add a java-overridable
factory DictionaryFacilitatorProvider.java used to create a
DictionaryFacilitator.
Change-Id: Id4a58ae31feaa4d12a048a772c8d76ff82fdee45
2015-01-27 21:38:32 +00:00
d523bacebc
Merge "Add a method for handling for words not found in dictionary."
2015-01-23 16:35:16 +00:00
bd254ca776
Merge "Re-enable new keyboard layouts in Fava."
2015-01-21 19:34:12 +00:00
e1867ff0e8
Import translations. DO NOT MERGE
...
Change-Id: Ifd6ac19adb46ebd6aefb94814bc2f5fba14a61e8
Auto-generated-cl: translation import
2015-01-21 07:50:09 -08:00
9ea443e8c0
Re-enable new keyboard layouts in Fava.
...
This reverts commit da27faeb87
2015-01-20 19:37:26 +00:00
7710610dc1
Merge "Import translations. DO NOT MERGE"
2015-01-19 18:09:28 +00:00
9cbd291138
Merge "Import translations. DO NOT MERGE"
2015-01-19 18:09:16 +00:00
4e4aa06bf7
Merge "Import translations. DO NOT MERGE"
2015-01-19 18:08:39 +00:00
335e34decc
Merge "Import translations. DO NOT MERGE"
2015-01-19 18:07:57 +00:00
217856d7f5
Import translations. DO NOT MERGE
...
Change-Id: Iac5b20265c265d76c26833b36321702c34d1f50b
Auto-generated-cl: translation import
2015-01-19 10:07:44 -08:00
5303675947
Import translations. DO NOT MERGE
...
Change-Id: I2add0d5e1a7056d4f6124a47bcf5a7b156458cd1
Auto-generated-cl: translation import
2015-01-19 10:05:23 -08:00
fd28eb7cf0
Import translations. DO NOT MERGE
...
Change-Id: Ifac8d34a41ff545b48f08a9afeabc3b990cdc7da
Auto-generated-cl: translation import
2015-01-19 10:00:50 -08:00
42b21c079e
Import translations. DO NOT MERGE
...
Change-Id: Ic30904288f27cb9719d2da00abd002909d5fb1bd
Auto-generated-cl: translation import
2015-01-19 09:58:34 -08:00
a67f1dd5f5
Import translations. DO NOT MERGE
...
Change-Id: I10ad0004cd6adb8de189c4e97b7513736309ad1a
Auto-generated-cl: translation import
2015-01-19 09:56:22 -08:00
fc47007674
Merge "AOSP change for showing the app icon."
2015-01-16 17:49:37 +00:00
d913617e0c
AOSP change for showing the app icon.
...
This change deletes a bunch of code that was used to conditionally show/hide
the keyboard app icon given system states and user preferences.
Bug 19001197.
Change-Id: I69a57aa21872a571af87a193b3e52b7f985e5168
2015-01-16 09:37:30 -08:00
9fe700ec4f
Merge "Fix moving the cursor inside composition in lang w/o spaces"
2015-01-16 03:22:18 +00:00
2e8d536678
Add a method for handling for words not found in dictionary.
...
This is apparently called only once for every unique word, so repeated instances
of the same word are not handled separately. Upon changing orientation of the
device, however, all invalid words in the textbox are underlined again and this
method is called for each unique instance in order.
Change-Id: Ic57e4b9e5675bd7abd723644aa318d964f7f875f
2015-01-14 16:20:42 -08:00
4e395e119f
Merge "Import translations. DO NOT MERGE"
2015-01-14 16:51:50 +00:00
858136cf81
Import translations. DO NOT MERGE
...
Change-Id: I7e4d95c35676465b2e849047a4608657516d20b2
Auto-generated-cl: translation import
2015-01-14 08:36:13 -08:00
34d823bbeb
Import translations. DO NOT MERGE
...
Change-Id: I01e1b9c8e909e4023b396a697e4a5d5ee73715b5
Auto-generated-cl: translation import
2015-01-14 08:35:09 -08:00
303a2ae5c9
Fix NPE in PunctuationSuggestions.
...
The NPE happens when the keyboard doesn't specify any punctuation suggestions.
Bug 18047927.
Change-Id: I9f8aa35df4f163b527dc6580a99afc6da45a96b8
2015-01-13 13:24:16 -08:00
da27faeb87
Revert "Enable preliminary subtypes for F-release"
...
Bug 17743363: Preliminary subtypes should be removed from F-release
This reverts commit 45c917e238
2015-01-12 16:35:54 -08:00
Dan Zivkovic
Jatin Matani
Mohammadinamul Sheik
Mario Tanev
Martin Paraskevov
Tom Ouyang
Chieu Nguyen
Geoff Mendal
Jean Chalard