Commit Graph

80 Commits (75e69753b709c19d5a23baf88ec3ac2576ee9c24)

Author SHA1 Message Date
Kurt Partridge 75e69753b7 [Rlog57b] fix logging of reverts
Change-Id: I07c817061a0cc060197e0fea45195ca07a9bf276
2013-01-10 15:00:28 -08:00
Kurt Partridge 403c423940 [Rlog56] Buffer words before pushing out LogUnit
Previously, a logbuffer only held an n-gram.  Data went in and out of it, FIFO, until privacy
conditions were met (i.e. data not collected too frequently), and then an n-gram was saved.
E.g., if n=2, and only 10% of data is collected, then 18 words went through the logbuffer before
it captured the next 2 words.

However, if a user then went back and edited the n-gram, these edits were not captured.

This change changes the logbuffer size to temporarily hold data about words that are not recorded,
so that if the user backs up over them, the edits to an n-gram that we do eventually capture are
stored.  If the example above, instead of a logbuffer holding 2 words, it holds 20.  The system
waits until all the words not needed for the n-gram have been gathered (i.e. the buffer is full),
so the user has adequate time to edit, before shifting out the n-gram.  The buffer is still flushed
when the user closes the IME.  See the comment for MainLogBuffer for an explanation.

multi-project commit with I45317bc95eeb859adc1b35b24d0478f2df1a67f3

Change-Id: I4ffd95d08c6437dcf650d866ef9e24b6af512334
2013-01-09 21:09:19 -08:00
Kurt Partridge 8bda35809b [Rlog52z] Cleanup and small bug fixes
Change-Id: Ia3fca4881370ffcdd5f2b14d2d1094c51f4330ae
2013-01-09 21:07:51 -08:00
Kurt Partridge 3b95eaf70b [Rlog50] capture bigrams properly even with deletions
multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0

Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
2013-01-09 16:02:37 -08:00
Kurt Partridge e9c6455881 [Rlog48] Better logging of MotionEvents
- Now includes all historical data stored in a motionEvent
- Simpler API, refactored to move extraction code to JsonUtils

Change-Id: I52d9756ddbeaa14d1704787da59bf1aad18f0335
2013-01-08 08:50:06 -08:00
Kurt Partridge 9bad176ebe Merge "[Rlog32] ResearchLogger segment motion data around gestures correctly" 2013-01-08 08:10:31 -08:00
Kurt Partridge b7fb16e8cc Merge "[Rlog27] Refactor LogBuffer" 2013-01-08 07:40:57 -08:00
Kurt Partridge 99f3189645 [Rlog32] ResearchLogger segment motion data around gestures correctly
multi-project commit with I684ba5fed8c653777942e6b0366113ca40dfa37c

Change-Id: Id3804e6cfa97b4cdde212b8eebc413f76fa4772c
2013-01-07 20:06:29 -08:00
Tadashi G. Takaoka f90fc105ab Simplify singleton class initialization
Change-Id: I16a27f2ed6ea66184bfdc9903180372cd7ea2fd1
2013-01-07 19:05:31 +09:00
Kurt Partridge f77dd424b0 [Rlog27] Refactor LogBuffer
Cleanup and prepare for replaying

Change-Id: Ie09e912c6e9c0d7375168c575ccf1cfd9375dd31
2013-01-03 16:36:32 -08:00
Kurt Partridge f763dc5915 [Rlog24] ResearchLogger detect word boundaries in callers above commitText
multi project commit with I5847d4aba97a7224ae170a7153811c5a11816449

Change-Id: Ie6fbf6f19f0193451fe6f3ddf9d4ef1637a35db1
2012-12-23 12:33:16 -08:00
Kurt Partridge 13b1be988d Merge "Log LatinIME.commitCurrentAutoCorrection()" 2012-12-23 11:47:47 -08:00
Kurt Partridge c1b4d14394 Merge "Differentiate LOG_EVERYTHING and LOG_FULL_TEXTVIEW_CONTENTS" 2012-12-23 11:20:34 -08:00
Kurt Partridge 5e9a5ca998 Merge "[Rlog36z] Pass LatinIME instance to logger as LatinIME class" 2012-12-23 10:37:31 -08:00
Kurt Partridge dce58fe895 Merge "[Rlog24z] Initialize statistics variables" 2012-12-23 09:51:22 -08:00
Kurt Partridge a51fbd92a5 Merge "[Rlog20] Remove duplicate logStatistics" 2012-12-23 09:05:00 -08:00
Kurt Partridge 99bd42b295 [Rlog24z] Initialize statistics variables
Change-Id: I73a6009294a4f559a93b6ea9ceb4ea2683d97486
2012-12-23 09:04:01 -08:00
Kurt Partridge f0d626ecfc Merge "[Rlog19] ResearchLog remove unnecessary logSegment{start,end}" 2012-12-23 08:28:53 -08:00
Kurt Partridge 226377e65a Log LatinIME.commitCurrentAutoCorrection()
Change-Id: Ic46c91374ae0177cafad4579d28d6980af0d8d3a
2012-12-22 17:32:12 -08:00
Kurt Partridge fc6e0cce6f [Rlog19] ResearchLog remove unnecessary logSegment{start,end}
Change-Id: I73b7765c764e5f1035f1c37df45345f26aa5acb1
2012-12-22 17:22:43 -08:00
Kurt Partridge 5dd5dd2911 [Rlog36z] Pass LatinIME instance to logger as LatinIME class
Upcoming changes require LatinIME class, not just InputMethodService

Change-Id: Ia5b3a716ac02a99749fb2ba0164ba46c8a0c559a
2012-12-22 14:20:39 -08:00
Kurt Partridge 68fc33bd92 Differentiate LOG_EVERYTHING and LOG_FULL_TEXTVIEW_CONTENTS
Previously, LOG_EVERYTHING logged both all bigrams and also the entire TextView at the end of a
session.  Now, use a separate flag, LOG_FULL_TEXTVIEW_CONTENTS to determine whether the TextView
contents are recorded.

Change-Id: I0c7a90a8ff88aa65d057f3b2d3dd5adc3893504a
2012-12-22 13:57:58 -08:00
Kurt Partridge 522d739524 [Rlog20] Remove duplicate logStatistics
Change-Id: I31c5520598269a83ab218e3a024bff0a625c2770
2012-12-22 13:38:28 -08:00
Kurt Partridge 163699e240 Merge "[Rlog12] Add comments to logging callpoints" 2012-12-22 12:59:15 -08:00
Kurt Partridge ab9f4fd359 Merge "[Rlog7] ResearchLog improve gesture tracking" 2012-12-22 11:50:46 -08:00
Kurt Partridge c322c3c3c7 [Rlog12] Add comments to logging callpoints
Change-Id: Idd786e2804dc82c1fa27ecf0fc0537491438d017
2012-12-21 12:34:39 -08:00
Kurt Partridge f1ce54891f [Rlog7] ResearchLog improve gesture tracking
- count how many times a gesture is deleted
- count num chars entered by gesture
- change name of fns to reflect capturing gesture information when setting composing text

Change-Id: I1b8ebf9cfcf304e0efd827c8b8e28a4010199728
2012-12-21 12:33:54 -08:00
Kurt Partridge a98dabf106 Merge "[Rlog10] ResearchLogger change visible indicator to just lines on the side" 2012-12-20 10:43:11 -08:00
Kurt Partridge 0214f70e0c Merge "[Rlog8] Show red border if logging everything" 2012-12-20 09:53:32 -08:00
Kurt Partridge c572c20cd8 [Rlog8] Show red border if logging everything
Change-Id: I5a3f21cef7d93128661b11b60eac7d84b8110e47
2012-12-19 18:26:07 -08:00
Kurt Partridge ff9e30f5a3 [Rlog10] ResearchLogger change visible indicator to just lines on the side
(Note: Rlog9 was abandoned).

Change-Id: I69de4116e33d3c79216e25efe2ad2bcb2780b0ff
2012-12-19 18:20:03 -08:00
Kurt Partridge c2049c3284 Merge "[Rlog6.1] Fix LOG_EVERYTHING bug." 2012-12-19 17:20:12 -08:00
Kurt Partridge 94ac7a3851 Merge "Add ProductionFlag.IS_EXPERIMENTAL_DEBUG" 2012-12-19 09:02:05 -08:00
Kurt Partridge 41fe487e3a [Rlog6.1] Fix LOG_EVERYTHING bug.
(It wasn't logging everything).

Change-Id: I8c9fd1e7c04e1a3813e26e67691e0366ff48c9ee
2012-12-18 19:47:10 -08:00
Kurt Partridge 0aafbcf879 Add ProductionFlag.IS_EXPERIMENTAL_DEBUG
The IS_EXPERIMENTAL_DEBUG flag gives a single place to turn off all debugging flags that might be
set and to also enforce privacy controls.  Currently only used in the research package.

multi-project commit with I9275a7c8e40bf56106447a02d3056655329074b3

Change-Id: If769fe3a633f33963ca49e8ddf01ab24a30b6fd2
2012-12-18 19:46:30 -08:00
Kurt Partridge 606058f777 [Rlog5] ResearchLogging change from onFinishInput to onFinishInputView
Change-Id: I7d3bcfe647249e0b8a14ac3d67460c2684f16d8c
2012-12-17 21:39:54 -08:00
Kurt Partridge 40417aed94 [Rlog6] ResearchLogger fix dictionary loading
Change-Id: I5af460bd7c7fd67f858626ae3daf71fd615a25bf
2012-12-17 21:39:54 -08:00
Kurt Partridge 1a27336837 [Rlog4] ResearchLogger add LOG_EVERYTHING flag
- broaden OUTPUT_WHOLE_BUFFER to log not just the buffer at the end, but everything along the
  way.  This should only be set when the user is aware that logging is on, e.g. in a user test.

Change-Id: I8f9874697524e533586da40d0a3e452f6a04d3e4
2012-12-17 21:39:35 -08:00
Kurt Partridge 48160f9d84 [Rlog3] improve stat recording
Change-Id: Ie3b70e6eadc2a9af5ef45ddfad6a3398cea7bfe8
2012-12-17 17:08:47 -08:00
Kurt Partridge 3370dc8237 [Rlog2] ResearchLogging fix multi-space logging
multi-space logging should look like single-space logging, missing a few minor log statements
(SuggestionUpdates, SetComposingText)

multi-project commit with I2af842348c2f2b8f7271ac5b63def245e83df24d

Change-Id: Icd3187c0d0377255f82787afffea657c14345803
2012-12-17 09:53:43 -08:00
Kurt Partridge 5e854e281a [Rlog1] Track time of log statements
Log statements are now recorded with a timestamp.  This is important for filtering out statements
not part of words that are sampled when spaces are inserted automatically.

multi-project commit with Change-Id: I68221a2528045d25632aef4bb716f92a4f4a56a4

Change-Id: I46ac9b3b1dcbb08425160d0109028cb64445139c
2012-12-13 18:44:10 -08:00
Jean Chalard 2da8866518 Remove a couple Eclipse and Android Lint warnings
Change-Id: I0c29c5d2abcbf80759b996d34b534deb083cd7d3
2012-12-06 21:30:51 +09:00
Kurt Partridge b10ec5319b Fix crashes related to setSpan(-1 ... -1) errors
Fixes b/7652661

In some circumstnaces, when hiding the window, the logger tries to capture the TextView contents
and restore the cursor position based on the values stored in LatinIME.  However, the IME may not
know the cursor position.

This fix does two things 1) doesn't try to reposition the cursor if the TextView contents are not
to be captured, and 2) if the cursor position is unknown (i.e., == -1), doesn't try to move it back.

Change-Id: I3976aaccf58c18f892c3a8530218ae52bcac9989
2012-12-03 16:39:58 -08:00
Kurt Partridge d4dbf09241 Merge "Revert "ResearchLog. Track time of log statements"" 2012-11-30 15:18:49 -08:00
Kurt Partridge 33d5da590f Revert "ResearchLog. Track time of log statements"
This reverts commit bdbe279cec

Other half of this change couldn't be committed because of a inter-project directory migration.  Reverting until things settle down.

Change-Id: I3862fc8485dfca6d507f620e905cfa583aa0e39a
2012-11-30 15:18:30 -08:00
Kurt Partridge bc8df552f0 Merge "ResearchLog. Track time of log statements" 2012-11-30 14:54:16 -08:00
Kurt Partridge fdfa03c9f1 Merge "ResearchLogger switch word segmentation" 2012-11-30 11:52:09 -08:00
Kurt Partridge 2ae580eaea Merge "ResearchLogging of segments: groups of LogUnits that are sampled together" 2012-11-30 09:28:23 -08:00
Kurt Partridge bdbe279cec ResearchLog. Track time of log statements
Log statements are now recorded with a timestamp.  This is important for filtering out statements
not part of words that are sampled when spaces are inserted automatically.

multi-project commit with Change-Id: I68221a2528045d25632aef4bb716f92a4f4a56a4

Change-Id: I9f49c36391e1e1773b6d4876d7387c893024f87b
2012-11-29 20:40:42 -08:00
Kurt Partridge 6a0720478d ResearchLogger switch word segmentation
Previously, a logunit was considered a word only if it was all letters.  This is important for
tracking bigrams correctly.

Now, a logunit must have only at least one letter.  The dictionary check is still performed,
and punctuation, etc. still comes in as separate LogUnits.  But a word can contain a space,
which helps set up for logging words where spaces are inserted automatically, and other situations
in which text is committed with an additional space tacked onto the end.

Change-Id: Ia74094a99058890d20a9cdadf2d0989841a79a41
2012-11-29 20:32:12 -08:00