adbafa1a9b
Merge "Support ICS on the user dictionary settings"
2013-04-26 06:50:42 +00:00
dcef94165b
Support ICS on the user dictionary settings
...
Bug: 8600958
Change-Id: I50e9228afc7b04147eb7c4734d3145abe8859a30
2013-04-26 15:48:08 +09:00
dca46b5015
Merge "Keep task stack when invoking settings from setup wizard"
2013-04-26 06:45:52 +00:00
57372fd3da
Remove graying animation of alt-code keys while typing
...
Bug: 8727807
Change-Id: Idcc76dade3ceba5649666d795b6e4f94a161d748
2013-04-26 14:55:46 +09:00
82e476b188
Keep task stack when invoking settings from setup wizard
...
Bug: 8336068
Change-Id: If1df32595f72285b2dad16e28b4429b7b6059839
2013-04-26 13:03:37 +09:00
1919072cfc
Merge "[ZF1] Check profanity in Java rather than in native"
2013-04-25 11:33:05 +00:00
bb61293675
[ZF2] Read settings for profanity filtering.
...
Bug: 7226877
Change-Id: Ie0c713e1eba1529c0b288a1e5011023a79bedd6b
2013-04-25 20:29:14 +09:00
99e998286d
[ZF1] Check profanity in Java rather than in native
...
Bug: 7226877
Change-Id: Ib6c32bfee9977c27dbf7e1e590b2b00d9ceb7301
2013-04-25 20:29:11 +09:00
fb34869f5a
Merge "[PB8] Add an animation upon status change."
2013-04-25 11:04:58 +00:00
b1b03cfc2b
Merge "Fix missing initialization of PreviewPlacerView"
2013-04-25 10:00:34 +00:00
43590149a5
Work around a bug in older DownloadManager versions.
...
This adds a number to the extension.
Note that for DownloadManager to keep this, the server
needs to send it a mime type it does not recognize. Right
now, it does not recognize application/json so it's okay,
but we'd do well to remove the content/type header from
the server to prevent problems.
Bug: 8467516
Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
2013-04-25 18:52:39 +09:00
4dc77dcf4c
Merge "[PB7] Export animation code out of the preference"
2013-04-25 09:49:12 +00:00
513c63e877
[PB8] Add an animation upon status change.
...
Bug: 7600384
Change-Id: If5efb9357075193d10255187008e870e2933bdb8
2013-04-25 18:37:03 +09:00
2d72590ced
[PB7] Export animation code out of the preference
...
Bug: 7600384
Change-Id: I8009b31d96646acd667db410b94e969daea91d52
2013-04-25 18:37:01 +09:00
1b6eea8903
Fix missing initialization of PreviewPlacerView
...
Bug: 8716050
Change-Id: I234f1134274b9f72c8abbd729783f9ffe8f20f64
2013-04-25 18:26:24 +09:00
a995bf4031
Put temp files within app files
...
Bug: 8715614
Change-Id: I307d83923070994525cf0d27aad403e881a89314
2013-04-25 18:14:40 +09:00
30f0f3a92a
Merge "Implement a functionality to add an entry to the user dictionary"
2013-04-25 06:04:08 +00:00
a79ba8a3d6
Implement a functionality to add an entry to the user dictionary
...
Bug: 8600958
Change-Id: Ic472500406b9d54ec4052c490ee7cef62fc4e52a
2013-04-25 14:55:07 +09:00
2cf450f482
[PB6] Encapsulate the buttons into a view
...
Handling buttons directly in the preference causes large
problems of code readability and interface. It's better to
have a class to manage the buttons and their animations
separately. This is feature-equivalent, and mostly
delegates stuff for now.
Bug: 7600384
Change-Id: Ia8da0ec68ffac84fc1d65e1760539a87a73fa776
2013-04-25 12:25:25 +09:00
e91387e281
Merge "[PB5] Store state in a more convenient manner"
2013-04-25 02:44:47 +00:00
cadea5d2fc
[PB5] Store state in a more convenient manner
...
This is more readable and will help with animations going forward.
Bug: 7600384
Change-Id: I255598d860d1e451fef106b00da63c282fe95f95
2013-04-24 22:49:50 +09:00
e91c001da9
Merge "[PB4] Make a memory non-static"
2013-04-24 11:51:10 +00:00
80790d78f6
Merge "[PB3] Simplify storage"
2013-04-24 11:49:43 +00:00
776edcfe46
Merge "[PB2] Small bugfix"
2013-04-24 11:49:33 +00:00
c017f18a59
[PB4] Make a memory non-static
...
The life span of this object is actually the life span of the interface.
It should not be static.
Also, we'll have a few other things to store in there soon.
Bug: 7600384
Change-Id: I708019e9ee53653e83a1e52c8e76326c3e39bcf3
2013-04-24 20:46:28 +09:00
43e8639e4e
[PB3] Simplify storage
...
By looping through children, there is no need to remember the
last index.
Bug: 7600384
Change-Id: I8b42b0aa38874ee494c6c4ecc09194a1d3c16922
2013-04-24 20:46:26 +09:00
d98f406dd3
[PB2] Small bugfix
...
The button would not display after it got hidden once.
Bug: 7600384
Change-Id: I57f9f1191be3b8fff55dde7a2781dbef68a2df62
2013-04-24 20:45:53 +09:00
46913aedb4
Merge "Add next axction to setup wizard"
2013-04-24 10:30:56 +00:00
b5d33059e0
Add next axction to setup wizard
...
Bug: 8159728
Change-Id: Ia37ab32b63e4eda29bf1411719d00846525c278f
2013-04-24 19:22:41 +09:00
b35aa487fd
Merge "Make aggressive threshold really aggressive"
2013-04-24 09:14:30 +00:00
70f2762e28
Make aggressive threshold really aggressive
...
Bug: 8701480
Change-Id: If8242cfe61f3e56712fd6e25e36858cff7f0d177
2013-04-24 17:49:56 +09:00
0e96003e0f
Merge "Refactor SetupStepGroup"
2013-04-24 05:53:33 +00:00
e918bf07a0
Refactor SetupStepGroup
...
Bug: 8159728
Change-Id: I1ab846d0910aacbd2f979289d72bafea8a8e0378
2013-04-24 14:15:59 +09:00
41f505dc3e
[PB1] Cleanup
...
This preference is not a DialogPreference any more, as it doesn't
ever display a Dialog.
Bug: 7600384
Change-Id: Ia5965617c83d3cb964010f9b40d833065dccef60
2013-04-23 20:41:41 +09:00
480284e28a
Merge "Add edit personal dictionary settings menu"
2013-04-23 06:01:45 +00:00
c3f4783649
Add an additional ID to the client info.
...
Bug: 8651863
Change-Id: I748f35726d72ede926d5b06ed87ff029317f1ac3
2013-04-23 14:37:15 +09:00
9b4e3db1af
Legal notice
...
Bug: 8533258
Change-Id: I00e4916f86f29dd476c51a65e8fa5a6c136fd179
2013-04-22 21:55:53 +09:00
4f2535398a
Add edit personal dictionary settings menu
...
Bug: 8600958
Change-Id: I303adfbe25a56cc9b5ee9f3b5169a5bca0ad6c4a
2013-04-22 19:59:12 +09:00
1a9bf159a4
Merge "Don't triger onPress and startLongPressTimer when gesture is canceled"
2013-04-22 10:53:39 +00:00
508ab24875
Merge "Implement IMM.switchToNextInputMethod() for ICS"
2013-04-22 10:37:11 +00:00
13d5da8b88
Don't triger onPress and startLongPressTimer when gesture is canceled
...
Bug: 8650846
Change-Id: Ice5ef07d6833422906b0b756206e097f75d1f2db
2013-04-22 19:36:08 +09:00
85629debaa
Implement IMM.switchToNextInputMethod() for ICS
...
Bug: 8633367
Change-Id: Ifc0f97b1fdf5e5cc3601c24a503058c4822478dc
2013-04-22 19:30:56 +09:00
f0e579a171
Don't kill suggestions with native score < 1
...
Change-Id: I954856b7fec0b91e19a467f2a87978d49caa639d
2013-04-22 14:21:43 +09:00
41b34cf2ae
Merge "Allow LogUnits to hold >1 word"
2013-04-19 16:04:13 +00:00
e92b5e145f
Allow LogUnits to hold >1 word
...
LogUnits have been annotated with the autocorrected words, but
until now this was assumed to be a single word without spaces.
But spaceless typing can result in spaces in the LogUnit label. With this
change, the LogUnit inspects the autocorrected text to determine how many
words were inserted, and counts them accurately.
This change corrects a privacy problem, which was that if the word sampling
algorithm chose a LogUnit that actually contained multiple words, then more
than two successive words would be included in the log.
Change-Id: I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
2013-04-19 08:55:39 -07:00
825da76c72
Redisplay a hidden button after it entered the screen again.
...
Bug: 7600384
Change-Id: I6cd18fd7584b6e98260cb432956f08ba9886580b
2013-04-19 22:50:48 +09:00
f8014eea34
Hide the correct button when pressing a new button.
...
Bug: 7600384
Change-Id: Ic5dbbbbcf19d778dde1316ebb417f1a8ede2d25d
2013-04-19 22:50:45 +09:00
68e4de1e78
Add welcome screen to setup wizard
...
This is a preliminary implementation because the welcome screen video
is just a placeholder.
Bug: 8159728
Change-Id: I6a2459a266babec2f078fc393b18c77b0b7992a8
2013-04-19 20:49:49 +09:00
fcefabf9ab
Groundwork to implement landscape and welcome screen
...
Bug: 8159728
Change-Id: I05ff6578980ec2e210ebb482ea51b1600e74a4f4
2013-04-19 20:10:59 +09:00
16ec2e1155
Merge "Add finish action to setup wizard"
2013-04-19 10:58:55 +00:00
192743a6ae
Add finish action to setup wizard
...
Bug: 8159728
Change-Id: I1578fc31875a1edbfea213fb5e1a1b464d02e941
2013-04-19 19:44:54 +09:00
ff078041e7
am f1dde6a1: am 758c74fe: Merge "Fix an NPE in recorrection" into jb-mr2-dev
...
* commit 'f1dde6a1bf659d182db5a2645515cc1efe74459c':
Fix an NPE in recorrection
2013-04-19 00:10:22 -07:00
e5cbdfe1b8
am 3629605b: am 77226ed0: Merge "Fix an NPE in recapitalize" into jb-mr2-dev
...
* commit '3629605b7c14b5eea498ef9588f4fef788ef454c':
Fix an NPE in recapitalize
2013-04-19 00:06:58 -07:00
758c74fe82
Merge "Fix an NPE in recorrection" into jb-mr2-dev
2013-04-19 07:03:19 +00:00
77226ed006
Merge "Fix an NPE in recapitalize" into jb-mr2-dev
2013-04-19 07:01:10 +00:00
ae7d1530b4
Fix an NPE in recorrection
...
Also, theoretically, we don't want to retrieve older suggestions if
there are no results for a recorrection - that would look random.
This bug addresses this too.
Bug: 8657919
Change-Id: I44f36d34a708a968ab71fa0592da57f4c97d4b7f
2013-04-19 15:53:33 +09:00
3bdf341ea0
Fix an NPE in recapitalize
...
Bug: 8657736
Change-Id: I459d1c200826c1c394f8207475ecf60a4f356793
2013-04-19 15:44:20 +09:00
1f6e06cf92
Merge "Make setup wizard step number highlighted when activated"
2013-04-19 03:21:04 +00:00
b84c0468e4
Make setup wizard step number highlighted when activated
...
Bug: 8159728
Change-Id: I62ccbebaae0a0c4a93ad7c155fc3020a7f357f3c
2013-04-19 11:14:21 +09:00
f02e269312
am 55b306c9: am 64eda4f4: Merge "Fix an infinite loop" into jb-mr2-dev
...
* commit '55b306c9e0ea29a10dfd79d5478344fcc98ca184':
Fix an infinite loop
2013-04-18 09:32:04 -07:00
3a18ae70cc
am a5d2da82: am d91268ad: Initialize dictionaries at onStartInputView
...
* commit 'a5d2da82a6a4486a4ef74e51ddd1c875f4c2d935':
Initialize dictionaries at onStartInputView
2013-04-18 09:27:35 -07:00
64eda4f4fa
Merge "Fix an infinite loop" into jb-mr2-dev
2013-04-18 16:24:01 +00:00
77e26e1c29
Fix an infinite loop
...
What do you mean "Can't happen"?
It happens all the time - the empty string is the default ID, and it
needs to be updated like everyone else.
Bug: 8651858
Change-Id: I5a2f2ebb5b2ef08b27f26be8fb2c3d2f231ebcfc
2013-04-18 23:14:13 +09:00
0b2d184a42
Merge "Update setup wizard icons"
2013-04-18 06:56:24 +00:00
d91268ad9f
Initialize dictionaries at onStartInputView
...
Bug: 8344402
Change-Id: I41b8440f0d72a66fde3f6feb0db8239c9bb10ea3
2013-04-18 14:48:42 +09:00
56f35a10cd
Merge "Fix bug in counting words between samples"
2013-04-18 04:23:29 +00:00
d794f5ae2a
Update setup wizard icons
...
Bug: 8159728
Change-Id: Ia5a14a35292b43dc1eaa2d4edd65134040355149
2013-04-18 13:15:53 +09:00
7a1721753b
Merge "Fix user recording dialog"
2013-04-18 02:07:16 +00:00
0833b3cbae
Merge "Fix alarm bug"
2013-04-18 01:01:48 +00:00
a19133011a
Merge "Avoid duplicate MotionEvents"
2013-04-17 22:57:20 +00:00
b903f10393
Merge "Label logUnits after LatinImeOnEndBatchInput"
2013-04-17 21:30:47 +00:00
a5bfac5bec
Merge "Fix NPE"
2013-04-17 20:33:26 +00:00
7da87f97b0
Merge "Clean up unnecessary log messages"
2013-04-17 20:18:19 +00:00
e9e4fe5227
Merge "Fix logic error"
2013-04-17 18:57:18 +00:00
1f99e04bba
Merge "Fix JsonWriter bug"
2013-04-17 18:20:34 +00:00
dac3ee49ae
Merge "Small dot in corner was not visible"
2013-04-17 17:18:35 +00:00
bf62dc9460
Fix bug in counting words between samples
...
Previously MainLogBuffer#shiftOutWords() assumed it wouldn't be called if
mNumWordsUntilSafeToSample was 0. This relaxes this assumption (which is in fact
false in the current code).
Change-Id: I8723248095e84a0d9d6f4639b4742cc7dda9716b
2013-04-17 08:44:06 -07:00
fdc90d4a58
Fix user recording dialog
...
Clicking the "include recording" checkbox in the user feedback dialog did nothing.
The code was relying on the state of the checkbox, rather than keeping its own state.
Fixing this addresses the bug.
Change-Id: I559d57a4e11f869f6e6f5e5de7878f765531a203
2013-04-17 08:42:20 -07:00
9d3bbc82a0
Fix alarm bug
...
The AlarmManager takes absolute times as an argument, not durations.
Change-Id: I419434ba5908c5f4070608070bbecf753088ecc8
2013-04-17 08:39:49 -07:00
dd8c87a39d
Merge "Include nanoTime in filename"
2013-04-17 15:31:20 +00:00
530fd15eff
Fix bug to update last interpolated index of GestureStroke
...
Bug: 8556775
Change-Id: Ie12e0dc9bfeae45f6883580801e07d44be1d1d33
2013-04-17 06:36:12 -07:00
464202047d
Add user feedback to setup action labels and icons
...
Bug: 8159728
Change-Id: I46c77c31973ae492c2a12291f2e0b154f64d26c9
2013-04-17 19:57:46 +09:00
47a78aeb4d
Merge "Finalize setup wizard strings and mark as translatable"
2013-04-17 10:55:41 +00:00
8712ac7945
Finalize setup wizard strings and mark as translatable
...
Bug: 8159728
Change-Id: I9f6f04b09b2cefdb7ece76a4f3c39ab56d0c8fab
2013-04-17 19:52:50 +09:00
cd831fa285
Fix JsonWriter bug
...
JsonWriter requires that data be written to it, else close() will throw
an exception.
Change-Id: I596c5363e063cc75bcda55e0a506eefb3f17bd67
2013-04-17 01:26:52 -07:00
fe0529714e
Label logUnits after LatinImeOnEndBatchInput
...
Previously only a commitText would cause a LogUnit to be
labeled with the word that the data generates. In the case
of gestured text, this information is available when
LatinIME#onEndBatchInput is called. Labeling the LogUnit
at this time means that the Log will have labeled words even
if stop() is called before commit.
Change-Id: Idb2f99a9c159a1b1aa00448a2ecddeca6c351c3e
2013-04-17 01:14:36 -07:00
1bf47582a0
Avoid duplicate MotionEvents
...
Change-Id: I9c3b352b738698f262f254e581bde34b060e258f
2013-04-17 00:30:54 -07:00
bb5deb82b5
Fix singleton/utility classes initialization in SettingsFragment
...
This is a follow up of Ide3cd3acba.
Bug: 8632344
Change-Id: Iafe51798a1a74eff5d8fcd6f0117d16b419d447d
2013-04-17 16:16:10 +09:00
888a194cf1
Fix missing AudioAndHapticFeedbackManager initialization
...
Bug: 8632344
Change-Id: Ide3cd3acba3987317cff709fa591eadaa71834e8
2013-04-17 15:32:01 +09:00
4ac28ded28
Fix NPE
...
Change-Id: I8a091fb63dab12a0d2ba69e2fe393249bc68d103
2013-04-16 20:39:47 -07:00
2edb4f22cb
Clean up unnecessary log messages
...
Change-Id: I6c3252f3b31c5874ea2f909f636f58b579c06b8d
2013-04-16 20:39:47 -07:00
cd39368c21
Fix logic error
...
Change-Id: Ia36660c66504ba2fbb7f125704926a08726df87a
2013-04-16 20:39:47 -07:00
2d9d4390fd
Small dot in corner was not visible
...
Framework change perhaps? Even if not, this makes it more visible
Change-Id: Ib6d36b5a30136c4516adac666bdff36d1cd9b337
2013-04-16 20:39:47 -07:00
125f22dc58
Include nanoTime in filename
...
System is fast enough that sometimes SystemClock.currentTimeMillis() is duplicated
when used to make a unique filename.
Change-Id: I9454fbb5e10265d36b8e17cba183a1591d52cc7b
2013-04-16 20:29:42 -07:00
edc49d38e6
Fix bug to update last interpolated index of GestureStroke
...
Bug: 8556775
Change-Id: Ie12e0dc9bfeae45f6883580801e07d44be1d1d33
2013-04-17 11:58:09 +09:00
ff766f8c4b
Merge "Don't insert automatic spaces when text looks like a URL"
2013-04-16 10:07:36 +00:00
73ec85b8ad
Don't insert automatic spaces when text looks like a URL
...
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.
So I think this is actually the right answer to the problem.
Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
2013-04-16 18:03:49 +09:00
1711f986d4
Merge "Add shadow to gesture preview trail"
2013-04-16 07:57:29 +00:00
c71dde9cb5
Add shadow to gesture preview trail
...
Bug: 7167303
Change-Id: I8f76fe0aec6cb32388e7c85d04516d1dd7d28c29
2013-04-16 16:50:59 +09:00
962c9f059a
Merge "Small cleanup"
2013-04-16 06:38:17 +00:00
30225f3897
Small cleanup
...
Change-Id: Iafdbe305712c8a571f0f5abc2032df086d7ac015
2013-04-16 15:30:48 +09:00
78d658734d
Merge "Don't recapitalize on shift while on symbol layout"
2013-04-16 05:31:43 +00:00
1f52364630
Don't recapitalize on shift while on symbol layout
...
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
2013-04-16 14:29:02 +09:00
8094bf45d7
Match the keyboard state to the recapitalize state.
...
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
2013-04-16 14:25:03 +09:00
e259b9f57d
Merge "Clean up RecapitalizeStatus"
2013-04-16 04:57:35 +00:00
fd15686ae9
Merge "Fix an NPE"
2013-04-16 04:12:18 +00:00
b794e904a3
Clean up RecapitalizeStatus
...
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
2013-04-16 13:11:18 +09:00
a024ac6b20
Merge "Fix an NPE"
2013-04-16 03:43:06 +00:00
2b42ad0eaa
Fix an NPE
...
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
2013-04-16 12:20:10 +09:00
7be3ca2ccf
Fix an NPE
...
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
2013-04-16 12:17:22 +09:00
5fca38c538
Merge "Small performance improvement / minor bugfix"
2013-04-15 14:28:16 +00:00
b76ce1251e
Merge "Remove a useless function"
2013-04-15 13:06:33 +00:00
bc501647fd
Remove a useless function
...
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
2013-04-15 22:01:37 +09:00
1e5bbe4ce8
Small performance improvement / minor bugfix
...
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.
Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
2013-04-15 21:18:50 +09:00
a5a2f3e3c7
Remove gesture suggestions with an INT_MIN score
...
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
2013-04-15 20:55:49 +09:00
033958330d
Merge "Have Latin IME re-capitalize a selected string"
2013-04-15 11:29:28 +00:00
2995abe7aa
Have Latin IME re-capitalize a selected string
...
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.
Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
2013-04-15 20:23:01 +09:00
0e9ee4d3bf
If there are no suggestion span, recompute suggestions.
...
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
2013-04-15 19:33:23 +09:00
059e084e98
Merge "Reject a previously user-refused suggestion."
2013-04-15 07:45:34 +00:00
d40f3f6bc1
Reject a previously user-refused suggestion.
...
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.
Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
2013-04-15 16:36:44 +09:00
216fb6a042
Remove unnecessary harmful finish() from SettingsActivity
...
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
2013-04-15 16:26:40 +09:00
1ec4c07a13
Merge "Ignore modifier key while sliding key input"
2013-04-15 06:19:10 +00:00
f224941c37
Merge "Suppress calling onPressKey and onReleaseKey while detecting gesture"
2013-04-15 06:18:48 +00:00
29105a725d
Add preference dependency to gesture input related options
...
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
2013-04-15 15:07:49 +09:00
8dfbb740e1
Ignore modifier key while sliding key input
...
Bug: 8284624
Change-Id: I839d7a769d98f29be647dbe511ba3f73ca44446d
2013-04-15 14:39:02 +09:00
e2af9b7eb5
Merge "Reset vertical correction when more suggestions are in modal mode"
2013-04-15 04:57:33 +00:00
51c38a441a
Reset vertical correction when more suggestions are in modal mode
...
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
2013-04-15 13:56:03 +09:00
03d1dff38d
Merge "Fix Binary dict tests"
2013-04-15 03:53:54 +00:00
c2e9c511cb
Fix Binary dict tests
...
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.
The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.
All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.
Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
a91da76683
Suppress calling onPressKey and onReleaseKey while detecting gesture
...
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
2013-04-15 10:59:54 +09:00
ededdc6a8b
Merge "Avoid NPE"
2013-04-12 18:10:49 +00:00
2cd1136b8e
Merge "Remove the dialog to insert words to the dictionary."
2013-04-12 12:33:24 +00:00
91bcf5eb5d
Merge "Restart suggestions when the cursor moves."
2013-04-12 12:27:50 +00:00
02ce3dc2d1
Fix a bug with bad application completions
...
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
6a114fa700
Restart suggestions when the cursor moves.
...
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
d24f939712
Merge "Make shortcut-only user dict entry non-words."
2013-04-12 11:02:00 +00:00
fb5869e9ff
Merge "Add a class to encapsulate getting the metadata URI"
2013-04-12 11:01:36 +00:00
6a2a4b8e4d
Make shortcut-only user dict entry non-words.
...
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
1a51833828
Remove the dialog to insert words to the dictionary.
...
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
2927223edd
Merge "Better isolate ResearchLogging data"
2013-04-11 21:56:01 +00:00
8987cccf89
Add a class to encapsulate getting the metadata URI
...
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
2013-04-11 17:52:16 +09:00
b5d5190deb
Merge "Add some utility functions."
2013-04-11 07:35:22 +00:00
1cbb0b8f2a
Add some utility functions.
...
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
2013-04-11 16:16:19 +09:00
bd8e92d843
Add debug message to detect unusual zero width condition
...
Bug: 8452013
Change-Id: I0169dc6b0d08d1b4d9e01a5fa2ad01e9db292bda
2013-04-11 15:08:36 +09:00
f67a388197
Merge "Add TypefaceUtils"
2013-04-11 05:32:58 +00:00
08ae0d5ca0
Add TypefaceUtils
...
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
2013-04-11 14:27:42 +09:00
6d0027a46a
Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>"
2013-04-11 05:06:35 +00:00
cee512b63e
Merge "More precise geometry checking for more keys keyboard"
2013-04-11 03:51:42 +00:00
3722f0877e
Merge "Fix two bugs in dicttool"
2013-04-11 03:07:30 +00:00
a4463d7a9a
More precise geometry checking for more keys keyboard
...
Bug: 8484528
Change-Id: I0dd09530a5262fee9c19bb0f11d5830b00306944
2013-04-11 10:44:54 +09:00
cdaee868a3
Merge "Preserve a class for testing"
2013-04-10 23:45:33 +00:00
3684036eed
Preserve a class for testing
...
Addresses b/8583091
Change-Id: I89605223784312d9572dfc7c8aaa7e5eba44c4f6
2013-04-10 16:40:17 -07:00
6108624a00
Better isolate ResearchLogging data
...
Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used. This is reported as a
single LogStatement. Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data. This change wraps
this LogStatement in its own LogUnit.
Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
2013-04-10 11:53:38 -07:00
dfa5628cd3
Better release build reporting
...
The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.
This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.
Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
2013-04-10 11:52:37 -07:00
ca0fdbbe2e
Fix two bugs in dicttool
...
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.
Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
2013-04-10 22:10:31 +09:00
fb3e805722
Merge "Fix a bug where a space would not be inserted before a gesture"
2013-04-10 11:19:31 +00:00
30b8004b56
Fix a bug where a space would not be inserted before a gesture
...
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
2013-04-10 20:10:28 +09:00
c7d4158979
Merge "Use private object as a lock instead of synchronized method"
2013-04-10 09:56:27 +00:00
12e77de212
Merge "Use private lock object instead of synchronized method"
2013-04-10 09:35:12 +00:00
1e256f5888
Merge "Protect simultaneously modifying gesture preview data"
2013-04-10 09:34:59 +00:00
951ea3c06d
Use private object as a lock instead of synchronized method
...
Change-Id: I0b9a935d8c97ddfb18ab7950a9d6bf542863072a
2013-04-10 18:34:01 +09:00
ce811f50d2
Use private lock object instead of synchronized method
...
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
2013-04-10 18:27:11 +09:00
ad205b2e3f
Protect simultaneously modifying gesture preview data
...
Bug: 8556775
Change-Id: I83272e3adbfc0c9cc14f9e8b479e926aabf4fa2a
2013-04-10 18:18:54 +09:00
99b93d17d5
Fix a bug where autocorrection status would be wrong.
...
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
2013-04-10 17:49:19 +09:00
262d5bd9f9
Don't override EXTRA_SHOW_FRAGMENT if exists
...
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
2013-04-10 16:24:17 +09:00
10af4b6e45
Merge "Separate StringUtils.capitalizeFirstCharacter"
2013-04-10 06:30:33 +00:00
d20c5a78e2
Separate StringUtils.capitalizeFirstCharacter
...
Bug: 8582061
Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
2013-04-10 14:55:23 +09:00
87fdde6ec4
Typing double letters via a 'circle' on the key.
...
Bug: 8550980
Change-Id: I5e432dea0e025ccea196f80e90a6bf945488e130
2013-04-10 12:43:13 +09:00
f606fd8554
Hide Setup Wizard icon for stock keyboard
...
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
2013-04-10 12:24:40 +09:00
869ea1e555
Use SparseIntArray instead of TreeMap<Integer, Integer>
...
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
2013-04-10 10:15:26 +09:00
4fdfce6dcc
Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo"
2013-04-10 01:06:36 +00:00
09ab6495a2
Merge "[FileEncap18] Clean up uploading scheduling"
2013-04-09 19:08:40 +00:00
19dcd15493
Merge "Offer to add any OOV typed word to the dictionary."
2013-04-09 10:28:47 +00:00
ddafcf82dc
Merge "Fix bugs and add tests"
2013-04-09 08:35:28 +00:00
9310f42a36
Offer to add any OOV typed word to the dictionary.
...
That includes gestures, which used not to work.
Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
2013-04-09 12:05:54 +09:00
1f70a4d681
Merge "Allow logging while replaying"
2013-04-09 02:33:09 +00:00
d117c1a116
Merge "Do not record log split time when handling separator"
2013-04-09 02:31:48 +00:00
d17c8bd929
Update comments
...
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
2013-04-08 23:05:45 +09:00
c87449497c
Fix bugs and add tests
...
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
2013-04-05 12:11:19 +09:00
7d3836d63a
Move a generic string utility to StringUtils
...
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
2013-04-05 12:09:14 +09:00
6e3f307266
Refactor SpellCheckerProximityInfo as extending ProximityInfo
...
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
2013-04-02 19:06:32 +09:00
ecb59eff90
Revert "[DO NOT MERGE] Activate hardware keyboard handling"
...
This reverts commit c741f1f83b
2013-04-02 16:08:48 +09:00
c741f1f83b
[DO NOT MERGE] Activate hardware keyboard handling
...
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
2013-04-02 15:38:13 +09:00
30772c3758
Allow logging while replaying
...
Previously logging was disabled during replay. This makes it impossible to use logged data as a
regression test, since the new log was unavailable. This change corrects this problem.
Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
2013-04-01 16:49:39 -07:00
636b8c4231
Do not record log split time when handling separator
...
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken. However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word. This change corrects this bug.
Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
2013-04-01 16:48:15 -07:00
5779bc91e6
Merge "Split LogUnits differently."
2013-04-01 23:08:21 +00:00
0c0ab2b4d9
Merge "Reorder ResearchLogger call"
2013-04-01 15:19:45 +00:00
0745fe83d4
am b8869ec1: am 0fcc4960: Deactivate hardware keyboard handling.
...
* commit 'b8869ec1e39c1751825841e790d21fc854dca9ce':
Deactivate hardware keyboard handling.
2013-04-01 05:42:42 -07:00
0fcc4960bc
Deactivate hardware keyboard handling.
...
Bug: 8000119
Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
2013-04-01 21:35:45 +09:00
75028af28c
Interpolate gesture preview trails
...
There is the boolean flag to kill interpolation.
Bug: 7167303
Change-Id: Iac7e4cb88cf437c2ee77c003c9cddb92416025c7
2013-04-01 19:15:36 +09:00
43341ba042
Merge "Ask the client to make itself known when it's not"
2013-04-01 09:00:25 +00:00
76d5f512f9
Ask the client to make itself known when it's not
...
Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.
Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
2013-04-01 17:37:22 +09:00
065f126f1d
Merge "Fix two nasty bugs with surrogate pairs."
2013-04-01 08:28:08 +00:00
a411595b16
Fix two nasty bugs with surrogate pairs.
...
The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.
Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
2013-04-01 17:06:19 +09:00
740da0d8d0
Fix an NPE
...
Also remove an unused method and make 2 private variables
final.
Bug: 8461093
Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
2013-03-29 18:41:29 +09:00
48d8d8d0ae
Fix potential NPE in MainKeyboardView.KeyTimerHandler
...
Bug: 8469652
Change-Id: Ib7a548e6a24d2e02de85ab444c0ec99d8f6b82c3
2013-03-28 17:54:36 +09:00
2188cbae63
Merge "Fix an NPE"
2013-03-28 06:56:49 +00:00
d555a0d77a
Merge "Cleanup"
2013-03-28 06:16:40 +00:00
28d5f4577f
Fix an NPE
...
The code was passing the wrong parameter.
Bug: 8492879
Change-Id: I091d62ca29601e3807eed287c7bdad38bf43a502
2013-03-28 15:08:05 +09:00
dae90cfb01
Cleanup
...
Seems there was an unclosed cursor :o
Change-Id: I7616849ace5217d8c6f54465f7b3a634e3c14116
2013-03-28 14:43:32 +09:00
Satoshi Kataoka
Tadashi G. Takaoka
Jean Chalard
Kurt Partridge
Ken Wakasa
Keisuke Kuroynagi