Commit Graph

3281 Commits (633bc88a0fd7de035415937544fff72538219133)

Author SHA1 Message Date
Jean Chalard f2f9715319 Try to compensate for a race condition.
This does not really fix the underlying bug, but it does fix
the apparent symptoms.
When the user presses space and a letter quick, the
onUpdateSelection handler may be called after the letter has been
actually committed. The keyboard then happily proceeds to clearing
the composition because it thinks space was pressed (or the user
moved the cursor, since it can't guess which happened).
This change removes this behavior when we are expecting an update
event from a keypress. This means the bug still exists if the user
presses space twice and a letter, and all events come after the
letter, but it is very very hard to reproduce this. There may be
other collateral damage when the user moves the cursor in the form
of race conditions, but likewise, they should be really hard to
reproduce.

Bug: 5100521
Change-Id: Ib05328c9b451bf6fe288ae00296fd283a9a4e863
2011-08-01 19:51:55 +09:00
Jean Chalard 20cb6e8078 Merge "Remove the systematic bias to the top." 2011-08-01 03:18:49 -07:00
Jean Chalard d8eceb1231 Remove the systematic bias to the top.
The keyboard used to introduce a systematic bias to the top.
This may have been to compensate an old driver flaw, but it
seems that it is now in the way and causes a lot of mistyped
spaces and backspaces.
This change removes the systematic bias.

Change-Id: Ib65ffba99cbd053d1085d3e6eeaf10a815289fc0
2011-08-01 19:14:14 +09:00
Tadashi G. Takaoka 49e00258b9 Remove '(' from the label of "to symbol" on phone layout
Change-Id: I9261cbba9a04fc25b67dfd5ce4188b7e32f5d8e0
2011-08-01 02:47:03 -07:00
Tadashi G. Takaoka 271e55fe53 Merge "Filter non-ascii popup charcters from password keyboard" 2011-08-01 01:32:48 -07:00
Tadashi G. Takaoka afa5e9af8f Merge "Add orientation to regression tests" 2011-08-01 00:36:36 -07:00
Tadashi G. Takaoka 2fe68b9616 Filter non-ascii popup charcters from password keyboard
Change-Id: I10885efd317770f892165b6bb059313abf241436
2011-08-01 00:35:59 -07:00
Tadashi G. Takaoka 3c70185b1b Add orientation to regression tests
Change-Id: Iaf2cb7841c4622eedeb4bf880d55988bfa61e823
2011-08-01 00:18:45 -07:00
Ken Wakasa 59eeb1cf12 Merge "Clean up revertLastWord()" 2011-08-01 00:11:18 -07:00
Ken Wakasa 9351550dc6 Clean up revertLastWord()
The "deleteChar" argument of this method is acutally always true in the current code path.
Also, in this method, textToTheLeft virtually never has a punctuation letter as its initial
character.  This change is one of preparatory changes for bug:4983945.

Change-Id: I531a32570a35634c21c1d74b2b461e40a1b7f660
2011-08-01 16:03:43 +09:00
satok db2c0919cf Remove old dictionary format code
Change-Id: Ic4b9e069c9bd5c088769519f44d0a9ea45acb833
2011-08-01 16:01:54 +09:00
satok ccec49793c Merge "Add correction state" 2011-07-31 23:46:52 -07:00
satok 2df3060883 Add correction state
Change-Id: I0d281cede1590893bd1def005cf83c9431d12750
2011-08-01 15:42:09 +09:00
Tadashi G. Takaoka 48dda9e028 Merge smiley key style into return key style for phone
Bug: 4340933
Change-Id: If2b586e5fade1610489e4a53cddafb89834bba07
2011-07-31 20:06:39 -07:00
Tadashi G. Takaoka e00d44d0c8 Show settings and tab key accordingly
Instead of showing a tab key at the position of "period" key, this
change places a tab key on the left side of the space key or on the
mini popup keyboard of the mic/comma key accordingly.

Bug: 4340933
Change-Id: If3cbc6d0b36f74fbc9320d6f433c65c66051dc09
2011-07-31 20:00:00 -07:00
Tadashi G. Takaoka 35e675b196 Rename settingsPopupStyle to f1PopupStyle
Bug: 4340933
Change-Id: Ic026089123988940dca58a0aaac07f613ad45aff
2011-07-31 19:19:32 -07:00
Tadashi G. Takaoka 3712231600 Rename key label and alternates string resource names
Bug: 4340933
Change-Id: I7c80c0b6a8a9082c52b57a858e2b6740c05366ec
2011-07-31 19:00:19 -07:00
Tadashi G. Takaoka c3afe2c244 Replace the notion of "voice" with "shortcut" as many as possible
Bug: 4340933
Change-Id: I98b4eca5167cc3767a0868fae8f6436164adbe4d
2011-07-31 18:46:44 -07:00
Tadashi G. Takaoka 6a07d7ddd9 Merge "Rename popupSettingsStyle to f2PopupStyle" 2011-07-31 18:43:28 -07:00
Tadashi G. Takaoka 83f6ca10d4 Merge "Fix exception message" 2011-07-31 18:43:22 -07:00
Tadashi G. Takaoka 2afc2adb01 Merge "Eliminate "..." from the key that has no popup mini keyboard automatically" 2011-07-31 18:43:17 -07:00
Tadashi G. Takaoka 09430720d5 Fix exception message
Bug: 4340933
Change-Id: I81e7b0c72116b5bb56b0fdcd02386288aebd73e7
2011-07-31 18:40:58 -07:00
Tadashi G. Takaoka e50733d196 Rename popupSettingsStyle to f2PopupStyle
Bug: 4340933
Change-Id: I4fbd8f7a4175e0e3fde326f40fd1b84312d81b89
2011-07-31 18:37:25 -07:00
Tadashi G. Takaoka 0c6e57f2d1 Eliminate "..." from the key that has no popup mini keyboard automatically
Bug: 4340933
Change-Id: I08bbdee71f4bc2285fd0c1233d284150be61748e
2011-07-31 18:22:29 -07:00
Tadashi G. Takaoka 73e716f202 Be aware of "nm" and "noMicrophoneKey" private IME option
Bug: 4340933
Change-Id: I787108a73d4450963d644bc7070ae1672ebb4455
2011-07-31 18:20:20 -07:00
Ken Wakasa 2ba975afb9 Turn off the Settings key by default
bug:5094401
Change-Id: Ieb42fdfa79be2afcfa6634e7404c17737ef6927d
2011-07-31 07:26:24 +09:00
Tadashi G. Takaoka 97c35650ad Dismiss key preview regardless of key preview settings
Bug: 5099213
Change-Id: Id6c5cb0ae4a07897b34153d4b350b1b45a06aa1a
2011-07-29 19:52:49 -07:00
Tadashi G. Takaoka 364f1fd1f8 Add WindowWidthCache
Bug: 4311428
Change-Id: I9f006525c0932d9d49bb8655caf58523135366d7
2011-07-29 18:43:50 -07:00
Tadashi G. Takaoka 0a054dd107 Cleanup KeyboardSwitcher internal a bit
Bug: 4311428
Change-Id: Ibe933d0351f750a3a41a08f09befd833d677961b
2011-07-29 17:00:09 -07:00
Ken Wakasa f12aa77c4b Merge "Simplifying accessibility code in keyboard's dispatchTouchEvent()" 2011-07-29 01:22:11 -07:00
Jean Chalard 4d94a99bab Match the new name of the dictionary settings activity.
Bug: 5094660
Change-Id: I13c734791265ed25eac3c9b4861dd0cffdb12c52
2011-07-29 15:57:54 +09:00
satok 4e7d0663ba Merge "Modified the test spell checker" 2011-07-28 18:09:51 -07:00
Tadashi G. Takaoka 259ce17f5d Merge "Use isFullscreenMode to determine candidate container height" 2011-07-28 17:40:18 -07:00
Tadashi G. Takaoka ecf43d4f9d Merge "Remove dead area around separators in the suggestion strip" 2011-07-28 17:39:43 -07:00
Tadashi G. Takaoka 3782f2bf1e Merge "Remove icon and negative button from dialogs" 2011-07-28 17:39:07 -07:00
Tadashi G. Takaoka 5b3c834a9c Merge "Remove enableShiftLock attribute from KeyboardId" 2011-07-28 17:38:50 -07:00
Tadashi G. Takaoka 6d9bcd5e13 Remove enableShiftLock attribute from KeyboardId
This change is a follow up of Ia72de236.

Bug: 4311428
Change-Id: I0ad0f1fb93545ceb40df8dffe377240b020c2602
2011-07-28 17:25:44 -07:00
Tadashi G. Takaoka 34400204a5 Merge "Remove unused method" 2011-07-28 15:42:53 -07:00
Tadashi G. Takaoka b9538bc447 Merge "Fix that long pressing shift on symbol keyboard registers caps lock code" 2011-07-28 15:27:40 -07:00
Tadashi G. Takaoka d4b533774d Remove unused method
Bug: 4521802
Change-Id: Iae649f8b77b3bb144ee7eedbb6545e237fa79a17
2011-07-28 15:24:46 -07:00
Tadashi G. Takaoka 4b1780fa95 Use isFullscreenMode to determine candidate container height
Bug: 5081182
Change-Id: I3783d3994e96f8bf466cbc47c9e0aecc2a6bed50
2011-07-28 15:06:15 -07:00
Tadashi G. Takaoka a1aab83a24 Remove dead area around separators in the suggestion strip
If user touches the separator, the right hand side suggestion will be
selected.

Bug: 4431485
Change-Id: Ieaa79fe2ac7b15e312829dca847ddb1b25056c09
2011-07-28 14:15:24 -07:00
Tadashi G. Takaoka e4b445f1ce Remove icon and negative button from dialogs
Bug: 5092028
Change-Id: I25b86c6e74e380e6cee4998bfe494bdafb611f36
2011-07-28 13:49:57 -07:00
Tadashi G. Takaoka 851c3267d4 Fix that long pressing shift on symbol keyboard registers caps lock code
Bug: 5088376
Change-Id: I586a9fb685f3443aa22fd877df52b36247c4f858
2011-07-28 12:04:35 -07:00
Alan Viverette 65a898d9ef Simplifying accessibility code in keyboard's dispatchTouchEvent()
Change-Id: Ie33cf93ee2d7eadad38ca170aa8ad988bb0ae9a9
2011-07-28 11:55:45 -07:00
Tadashi G. Takaoka c3d175c01f Fix wrong keyboard width when orientation has changed while IME is not shown
Bug: 5084021
Change-Id: Ie42da40b8249eaf9cf29707058906949278eff6a
2011-07-28 11:02:29 -07:00
satok a90992e562 Modified the test spell checker
Change-Id: Ib64fac8672a4107638cd05a0232d46b49fc4aa8c
2011-07-28 20:55:00 +09:00
Tadashi G. Takaoka 0a5345c7b6 Fix NPE
Bug: 5086698
Change-Id: Iaa3082649344722bd643c49c9d151df754d6e337
2011-07-27 15:37:42 -07:00
Tadashi G. Takaoka 60ccbe16ee Clean up keyboard loading and switching
Bug: 4311428
Change-Id: Ia72de23634f824d82b7b5f2267d439ce922a3b57
2011-07-27 13:34:16 -07:00
Jean Chalard a48f8b3764 Merge "Load the binary dictionary asynchronously." 2011-07-26 23:34:52 -07:00