Commit Graph

3686 Commits (61fb342901077f1220b7efb35657b38ea913af2e)

Author SHA1 Message Date
Satoshi Kataoka 1aae34873c tiny refactor
Change-Id: I776432b6c41cf8dee71fbd1565a6f3da9d762f9e
2013-08-15 13:38:05 +09:00
Yuichiro Hanada 1db93c9c04 [Refactor] Move some helper methods to BinaryDictIOUtils.
Change-Id: Ib817a975dc1f82241f732b236c44b042fda25b3c
2013-08-15 10:49:40 +09:00
Satoshi Kataoka be4d38e61f Merge "Fix test breakage" 2013-08-14 11:40:34 +00:00
Satoshi Kataoka 2b39fab829 Fix test breakage
Change-Id: I10bd8fcc68711a039e000f715d7a65ae42095965
2013-08-14 20:38:32 +09:00
Satoshi Kataoka 5654a1f21e Merge "Fix a debug functionality for the personalization prediction" 2013-08-14 10:43:31 +00:00
Ken Wakasa 8e398e2147 Merge "Move some methods in BinaryDictIOUtils to DynamicBinaryDictIOUtils." 2013-08-14 10:38:15 +00:00
Satoshi Kataoka d09ad2e368 Fix a debug functionality for the personalization prediction
Bug: 9429906

Change-Id: I10d39e1f8758dcb64c9c0111d516e3abfe81b04e
2013-08-14 19:36:20 +09:00
Yuichiro Hanada 3edb62c69b Move some methods in BinaryDictIOUtils to DynamicBinaryDictIOUtils.
Change-Id: I9ba55582c533fef0eb3e60c46bf23c8b16ee1ff4
2013-08-14 19:33:36 +09:00
Satoshi Kataoka 92038bcacd Merge "Add a method to import one bigram and string utilities" 2013-08-14 10:29:06 +00:00
Ken Wakasa f795f2b789 Merge "Add FusionDictionaryBufferFromWritableByteBufferFactory." 2013-08-14 10:26:21 +00:00
Ken Wakasa 0766f13391 Merge "Move some constants in BinaryDictInputOutput to FormatSpec." 2013-08-14 10:25:04 +00:00
Yuichiro Hanada 665592774c Move some constants in BinaryDictInputOutput to FormatSpec.
Change-Id: I6b12faf35b65238b9a64c82d4d1a6050f980e72e
2013-08-14 19:19:27 +09:00
Tadashi G. Takaoka bdef628a35 Merge "Add empty key background type" 2013-08-14 10:13:33 +00:00
Tadashi G. Takaoka ed5582ec65 Merge "Thin out audio and haptic feedback while key repeat" 2013-08-14 10:11:43 +00:00
Satoshi Kataoka 4ee953125a Add a method to import one bigram and string utilities
Bug: 9429906
Change-Id: I73bbf65985196d62470552c576bb076a7cb95008
2013-08-14 18:56:12 +09:00
Jean Chalard 5fd8b7ebd5 Merge "Add looksValidForDictionaryInsertion" 2013-08-14 09:41:49 +00:00
Jean Chalard af5fbe70ac Add looksValidForDictionaryInsertion
...and test it.

Also at the same time, add a facility to create a SettingsValues for
test, and some minor performance improvement to surrounding
methods.

Change-Id: I13b629ae14755c244af2a9406a7e9b4a4a16090f
2013-08-14 18:39:28 +09:00
Tadashi G. Takaoka ab16237e69 Thin out audio and haptic feedback while key repeat
Bug: 6522943
Change-Id: Id60f256ab0f8741578eda276116817fa48917325
2013-08-14 18:37:58 +09:00
Jean Chalard fdfc8ad2d0 Merge "Re-evaluate auto-caps earlier." 2013-08-14 09:29:48 +00:00
Tadashi G. Takaoka e18439d5c7 Add empty key background type
Change-Id: I9b07c58a9b70ae0228f87e1f066ca8cd959b4f03
2013-08-14 18:12:11 +09:00
Jean Chalard 4bc74d19ef Merge "Delete surrogate together." 2013-08-14 09:06:07 +00:00
Jean Chalard b2d954cad6 Delete surrogate together.
Stop deleting them one after the other, it makes no sense. We
can know in advance if we should delete two of them, so let's
use that.

Bug: 6526420
Change-Id: Ifa2263cbde8fedc78bb750b84d4acd3f979774ea
2013-08-14 17:53:33 +09:00
Jean Chalard b7e782d868 Re-evaluate auto-caps earlier.
We have all we know to re-evaluate auto-caps in this case.
We don't need to wait until we get the callback from TextView.

Bug: 10287972
Change-Id: I87e4e26cd193a001f91fe852ffc5a8f728db2449
2013-08-14 17:40:23 +09:00
Jean Chalard 1162c0537d Merge "Remove dead code" 2013-08-14 08:35:46 +00:00
Yuichiro Hanada bbc8a930f7 Add FusionDictionaryBufferFromWritableByteBufferFactory.
Change-Id: I23de0a178e7f11f2cf301fd433cde60c6152055b
2013-08-14 17:07:44 +09:00
Jean Chalard d81b9d0276 Remove dead code
isComposingWord() is actually defined as size > 0, so this test
can never be false.

Change-Id: If71afae6f0b16bff46178f0fae3244597354fecb
2013-08-14 16:38:37 +09:00
Jean Chalard e18fdf804a Merge "Fix a bug with surrogate pairs" 2013-08-14 07:27:54 +00:00
Jean Chalard a74ae9c451 Fix a bug with surrogate pairs
Bug: 10316781
Change-Id: I528c59c8823cda11975cb01b0ae59f12cfadef3b
2013-08-14 16:00:28 +09:00
Ken Wakasa ae59ce0262 Merge "Remove audio and haptic feedback while key repeating" 2013-08-13 21:50:20 +00:00
Yuichiro Hanada 3feacba1eb Add BinaryDictReader.
Bug: 9618601

Change-Id: Ief07fa0c3c4f7f5999a3fafcef4e47b6b6fd8143
2013-08-13 19:55:05 +09:00
Ken Wakasa 7242bf1a15 Merge "Make readHeader check the header size before using it." 2013-08-13 08:14:43 +00:00
Yuichiro Hanada b7bb9c9722 Make readHeader check the header size before using it.
Change-Id: I5dc3e2b674f7343ef57317fde6bdb7349a7fe04c
2013-08-13 17:06:25 +09:00
Tadashi G. Takaoka d1d607287d Remove audio and haptic feedback while key repeating
Bug: 6522943
Change-Id: Iad1b11172e47bfbae2b4129361a56b9d793f8f62
2013-08-13 17:03:26 +09:00
Satoshi Kataoka 310f8a0f06 Call onDictionaryReady
Bug: 9429906

Change-Id: Ifc538b38b7d37469aecccd32a7e3f95a90558be7
2013-08-13 11:41:48 +09:00
Satoshi Kataoka 1b7c1cd513 Merge "Add PersionalizationDictionaryRegister" 2013-08-12 06:23:12 +00:00
Satoshi Kataoka 8c4fcb108f Add PersionalizationDictionaryRegister
Bug: 9429906
Change-Id: Ibd4d5cedb371c0b4ee1342a3e6d221c9e34c2402
2013-08-12 14:48:45 +09:00
Ken Wakasa 66a63db2d5 Merge "Rationalize how to use AdditionalFeaturesSettingUtils" 2013-08-12 01:36:46 +00:00
Ken Wakasa 4a2f6a2216 am 25402fd5: am 724db044: Deallocate gesture trail bitmap when unneeded further
* commit '25402fd5309891884a843528d47f6b4646341a3f':
  Deallocate gesture trail bitmap when unneeded further
2013-08-09 15:53:29 -07:00
Ken Wakasa 02938c6baf Rationalize how to use AdditionalFeaturesSettingUtils
It should be called regardless of the gesture input being enabled or not

Change-Id: I223a823ef18389227fc04d000cc7bf750797ba31
2013-08-10 00:32:07 +09:00
Ken Wakasa 724db04495 Deallocate gesture trail bitmap when unneeded further
Follow up to I5bc980c4dc41bc304be3c190934c1f7c55c9d244

bug: 8967766
Change-Id: I7b916daa5269cfde359a77555e8ffadf0e4a8f92
2013-08-09 21:07:40 +09:00
Tadashi G. Takaoka 2dfcfc5013 Remove key preview backing view
This change re-origanizes view hierarchy of IME's input view.

Change-Id: I9d0a07692d0f41de3345d207366393bcd5424f7e
2013-08-09 20:25:42 +09:00
Ken Wakasa cfcf6660fc Reinstate a call to UsabilityStudyLogUtils#writeChar()
The usability study mode has been broken.

bug: 10251399
Change-Id: Iaa301241f102f412fa073f0d8b897a4c8b265a9c
2013-08-09 19:32:02 +09:00
Yuichiro Hanada 7ec9db2c34 Remove the code and comments about version 1 format.
Change-Id: I827052f234eeaa4dbcfd37da69a99866896a158b
2013-08-09 16:05:07 +09:00
Satoshi Kataoka 5c057b3241 Merge "Fix unit tests." 2013-08-08 10:14:27 +00:00
Yuichiro Hanada 7d1ae52ded Fix unit tests.
Change-Id: Ic0013089625e112aaccc888d462330640ef7cc6f
2013-08-08 19:12:35 +09:00
Tadashi G. Takaoka 96b444d429 Merge "Remove processMotionEvent from MoreKeysKeyboardView" 2013-08-08 08:23:23 +00:00
Satoshi Kataoka 1181c5acbc Merge "Fix to follow the field naming conventions." 2013-08-08 08:06:45 +00:00
Tadashi G. Takaoka 33482a9b9c Remove processMotionEvent from MoreKeysKeyboardView
Change-Id: I5373df4a7c82f964f99acf70325bba8702111a75
2013-08-08 15:30:09 +09:00
Keisuke Kuroyanagi b6d48c4c0b Make user and contacts dict use ver3 format.
Bug: 6669677
Change-Id: I6a20eed2c8afdd1c16ada5bf85067864c7cd2a7f
2013-08-08 14:57:19 +09:00
Yuichiro Hanada 71ffcc6332 Fix to follow the field naming conventions.
Change-Id: I9b41b5f34e93a3f291a352cd85c5ac257beaa9ab
2013-08-08 12:03:36 +09:00
Jean Chalard 4456d1a8c1 Merge "Have double-space-to-period cancel leave a single space" 2013-08-08 02:52:24 +00:00
Jean Chalard 522d13c302 Have double-space-to-period cancel leave a single space
Bug: 8911898
Change-Id: Ifb4bb63c14dc960d0a53f1511908830093cca012
2013-08-08 11:49:27 +09:00
Tadashi G. Takaoka 083a40b291 Merge "Move createKeyboardSetForSpellChecker to AndroidSpellCheckService" 2013-08-07 10:32:56 +00:00
Tadashi G. Takaoka 15b80c4ec2 Merge "Add ResouceUtils.getDefaultKeyboardHeight" 2013-08-07 10:32:30 +00:00
Tadashi G. Takaoka 204e7b1401 Move createKeyboardSetForSpellChecker to AndroidSpellCheckService
Change-Id: I4a9065e703e98ffed50f2a6d76ace938dfc26ddf
2013-08-07 19:24:22 +09:00
Tadashi G. Takaoka 3897a43940 Add ResouceUtils.getDefaultKeyboardHeight
Change-Id: I377f6a83ec86b0345b170e7ad995d4577220d0ad
2013-08-07 19:23:31 +09:00
Satoshi Kataoka c05b3b56cc Merge "Add a session for the personalization dictionary" 2013-08-07 08:45:19 +00:00
Satoshi Kataoka 80aa7197b4 Add a session for the personalization dictionary
Bug: 9429906
Bug: 4192129

Change-Id: I361ab380edeee5a8a8b364df3f9f4ab202b79105
2013-08-07 16:44:30 +09:00
Tadashi G. Takaoka 8ba8798290 Merge "Consolidate forwardTouchEvent with dispatchTouchEvent" 2013-08-06 06:38:33 +00:00
Tadashi G. Takaoka cc38bfb5d3 Merge "Add emoji icon and code as a groundwork" 2013-08-06 05:35:14 +00:00
Tadashi G. Takaoka b127d88285 Add emoji icon and code as a groundwork
The emoji switching key icon asset should be updated. The icons in
this change are just borrowed from Hangout.

Bug: 10179862
Bug: 6370846
Change-Id: Icea26d2cf2ac6a6df9beb4c98f646dbe309bdcd9
2013-08-06 14:16:15 +09:00
Tadashi G. Takaoka 88f840d2a2 Consolidate forwardTouchEvent with dispatchTouchEvent
Change-Id: Ib73962acff72be0a78a3565028572ad694fb8501
2013-08-06 11:04:51 +09:00
Tadashi G. Takaoka 52d220e71b Remove unnecessary suggestion strip container
Change-Id: I3710e1fe1574c0f69f7f448619e939fb45e9b8d3
2013-08-06 10:57:47 +09:00
Tadashi G. Takaoka c0a732f032 Remove CODE_RESEARCH
Instead of CODE_RESEARCH, special outputText ".research." is used to
invoke a research feedback dialog.

Change-Id: Ic95c956ab4f2b5f0c3f2205c9bbcdcfb67db5d6e
2013-08-05 19:05:07 +09:00
Tadashi G. Takaoka 28a148681e Small cleanup
Change-Id: I7dce7373b371f1ed5a985815f5d43fb6c6ee1f84
2013-08-05 18:46:35 +09:00
Satoshi Kataoka 33592d1bee Merge "Add a debug preference for using only personalization dictionary" 2013-08-02 11:30:20 +00:00
Jean Chalard ba2f4f84ca Merge "Fix a concurrency bug." 2013-08-02 11:28:45 +00:00
Jean Chalard 10d66669c7 Fix a concurrency bug.
This probably only ever happens in tests, but still, that's
the right thing to do.

Bug: 10139031
Change-Id: I259be9e7306162e19faf738a093a77762f2e7675
2013-08-02 20:26:37 +09:00
Satoshi Kataoka d7491e6e81 Add a debug preference for using only personalization dictionary
Bug: 9429906
Change-Id: I2003060c7065e736d42f3b3303fbba549358dd18
2013-08-02 20:10:57 +09:00
Satoshi Kataoka 60586b57cf Connect the personalization dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I9c9f3ed7699f74339ad92be6dcddb8a52c377545
2013-08-01 16:33:20 +09:00
Tadashi G. Takaoka 552a4b84f8 Merge "Add UsabilityStudyLogUtils.writeMotionEvent" 2013-07-31 14:21:04 +00:00
Satoshi Kataoka 567e7f05c1 Add the personalization prediction dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I0663de025405b2c92eebd528339b82baec97e2ce
2013-07-31 21:37:33 +09:00
Satoshi Kataoka 853d0fd122 Refactor the personalization dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I9f094bc5a6ce4652e310e090f1536e43f1f24ad1
2013-07-31 21:15:13 +09:00
Ken Wakasa 883bd364eb Merge "Deallocate gesture trail bitmap when unneeded" 2013-07-31 11:46:25 +00:00
Ken Wakasa c8814e20b7 Deallocate gesture trail bitmap when unneeded
This frees up 1.7MB on Nexus 4 (occam), and 900KB on occam_svelte while
LatinIME goes to background.
The keyboard bring-up speed feels acceptable on both devices.

bug: 8967766
Change-Id: I5bc980c4dc41bc304be3c190934c1f7c55c9d244
2013-07-31 20:39:32 +09:00
Satoshi Kataoka 3b1eb88658 Merge "Refactor the user history dictionary" 2013-07-31 10:37:31 +00:00
Satoshi Kataoka 1439130442 Refactor the user history dictionary
Bug: 9429906
Bug: 4192129

Change-Id: If53bc3220627802d82ab7c396d0aabdb658573fa
2013-07-31 19:22:11 +09:00
Tadashi G. Takaoka 30977a151e Add UsabilityStudyLogUtils.writeMotionEvent
Change-Id: I41ee6d1879dc937e1554fedfc603d9bb5bec40f2
2013-07-31 19:05:14 +09:00
Jean Chalard 2d7e927354 Fix inconsistencies with mSuggest.
This should fix some NPEs, but they are so unlikely that we never
see them.

Bug: 10065412
Change-Id: I2aefea1f52024405cc3fda9106fea41a02aaf4d8
2013-07-31 18:59:18 +09:00
Satoshi Kataoka 87d06afc66 Refactor on the user history dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I1a2bfe96e18119d30a72290aa48746f77a021018
2013-07-31 16:48:55 +09:00
Jean Chalard 8d46ea9156 Merge "Fix some warnings" 2013-07-31 07:38:49 +00:00
Jean Chalard 7d654d8cae Merge "Fix inconsistency with mutable settings." 2013-07-31 07:38:22 +00:00
Jean Chalard 561c447404 Merge "Fix a problem where settings were not renewed correctly." 2013-07-31 07:17:49 +00:00
Jean Chalard 93445b4821 Fix some warnings
Change-Id: I7290cd1fb675a1b85b9b6ac2d464c932b5bca1dd
2013-07-31 16:17:01 +09:00
Jean Chalard f8c1aefd90 Merge "Clarify the expected cursor position in RichInputConnection." 2013-07-31 04:56:35 +00:00
Jean Chalard aa108f1d7f Clarify the expected cursor position in RichInputConnection.
Change-Id: I4d36a23567415c3a293a588b51b46006256c148f
2013-07-31 12:22:15 +09:00
Satoshi Kataoka 323a7aae6c Merge "Fix the title of the personal dictionary settings" 2013-07-30 08:17:01 +00:00
Satoshi Kataoka 8befd36c65 Fix the title of the personal dictionary settings
Bug: 8976598
Change-Id: I9e07ff9e06449e2093b9ba8d6f28a030c69756bc
2013-07-30 15:39:41 +09:00
Jean Chalard c5c226c424 Fix inconsistency with mutable settings.
Change-Id: I0550044199273cecb6f5713aa2e43ae16319cd47
2013-07-30 14:30:24 +09:00
Jean Chalard 74bcc911ea Fix a problem where settings were not renewed correctly.
Bug: 10065412
Change-Id: Id05284f45466cd5b2697a695c3d1bdfbf3cc1f24
2013-07-30 13:22:05 +09:00
Satoshi Kataoka ab2d273133 Merge "Fix the displayed name of the personal dictionary" 2013-07-30 04:21:58 +00:00
Satoshi Kataoka 5123427532 Fix the displayed name of the personal dictionary
Bug: 8976598
Change-Id: I11dd73c8c23b05288c5f417352dc4cc99d489b95
2013-07-30 13:14:08 +09:00
Ken Wakasa b60e65a0cc Rename a variable for SettingsValues
Change-Id: Icb4155532ea8724791c9194e8dc75ce32b6e8b16
2013-07-29 18:53:23 +09:00
Jean Chalard d9f0c1e020 Merge "Fix an NPE" 2013-07-29 09:46:32 +00:00
Jean Chalard 5408fec63a Fix an NPE
Also make mSuggest private for more security.

Bug: 10045657
Change-Id: I712505e4d2a2606efff5d09ba9b4c656f9e7c7a9
2013-07-29 18:09:48 +09:00
Satoshi Kataoka fb9f448b8d Merge "Add personalization dictionary helper" 2013-07-29 05:21:14 +00:00
Satoshi Kataoka d45e4b6e5b Add personalization dictionary helper
Bug: 9429906
Bug: 4192129

Change-Id: Ic618b0b09a54ed46b20633bd4c1c570d4ac775af
2013-07-29 12:37:27 +09:00
Jean Chalard 654b0a9c16 Merge "Small optimization" 2013-07-26 11:30:50 +00:00
Jean Chalard e7903101ea Merge "Use cached data for getTextBeforeCursor." 2013-07-26 11:25:59 +00:00
Jean Chalard 0a064a5d88 Small optimization
Bug: 8864306
Change-Id: Ic8eecd64eff6a1150a90b9f5ec9ebbc5f1d2a6a9
2013-07-26 20:17:55 +09:00
Jean Chalard 8c6537edbd Use cached data for getTextBeforeCursor.
Bug: 8864306
Change-Id: Ia146f711f1de4336d7e3363208ab92eba856f5e1
2013-07-26 20:17:52 +09:00
Satoshi Kataoka 2a8c75fc43 Merge "Add a place holder of the personalization dictionary" 2013-07-26 08:44:26 +00:00
Satoshi Kataoka 5c15b8f442 Add a place holder of the personalization dictionary
Bug: 9429906
Bug: 4192129

Change-Id: Ieacd0559e0bf286c5933e9dba716289303f533d6
2013-07-26 16:03:04 +09:00
Jean Chalard 38e9802690 Merge "Revert "Very simple refactoring"" 2013-07-26 06:58:44 +00:00
Jean Chalard c6a07e16a5 Revert "Very simple refactoring"
This reverts commit f712dc9a4f.
It turns out this refactoring is not useful after all.

Change-Id: I0145c907b3cc5ac9a30a59abcd719cb546c9bd3a
2013-07-26 06:46:56 +00:00
Jean Chalard 0dd23544ff Merge "Very simple refactoring" 2013-07-26 05:30:47 +00:00
Satoshi Kataoka ffcbbaf127 Refactor on UserHistoryDictionary
Bug: 9429906
Change-Id: I576a91643bdaf5017cc826ac2e07a74a9a275d60
2013-07-26 13:00:19 +09:00
Jean Chalard f712dc9a4f Very simple refactoring
Bug: 8864306
Change-Id: I5c9b118cb6a8eb59efc52d5534b10fcab93182d6
2013-07-26 12:57:12 +09:00
Tadashi G. Takaoka c34933828e Merge "Cancel all ongoing event when onFinishInputView" 2013-07-25 11:08:08 +00:00
Tadashi G. Takaoka 5c095e59f6 Cancel all ongoing event when onFinishInputView
Bug: 9334755
Change-Id: If0c2ac49a50f4a529aefeca603569f9413367469
2013-07-25 20:05:39 +09:00
Tadashi G. Takaoka 21c6d23dcd Merge "Add MoreKeysPanel argument to Controller methods" 2013-07-25 11:00:25 +00:00
Tadashi G. Takaoka 0e08d70fe5 Add MoreKeysPanel argument to Controller methods
Bug: 9334755
Change-Id: I5a7104f4c98982f11fb4e060fa83c21bfc360558
2013-07-25 19:53:05 +09:00
Tadashi G. Takaoka 15c41a61ad Merge "Remove boolean return value of dismissing more keys panel" 2013-07-25 10:45:05 +00:00
Tadashi G. Takaoka 09e4530ca7 Remove boolean return value of dismissing more keys panel
Bug: 9334755
Change-Id: Ic29ab69cfbf9007e98fe67695f1854b4876eb976
2013-07-25 17:51:48 +09:00
Jean Chalard e408bbb5bf Merge "Fix a bug with multiple word insertion." 2013-07-25 08:34:41 +00:00
Jean Chalard 23a3fd5bfa Fix a bug with multiple word insertion.
This is a port of I5202bc52

Bug: 7903831
Change-Id: I3eb526de01a1f5b51212166e39b98de1d71e9eaf
2013-07-25 16:33:13 +09:00
Satoshi Kataoka 5563dc3ad5 Show all languages if user enables multiple subtypes
Bug: 8976598
Change-Id: I1c3c1ede1235f696eafb3a68ec5c29479768dd0f
2013-07-25 15:15:39 +09:00
Jean Chalard 289df0ecad Merge "[FD4] Separate cached address before/after update for groups" 2013-07-25 03:03:09 +00:00
Tadashi G. Takaoka cecb63c2c9 Merge "Make RunInLocale as top-level class" 2013-07-24 13:34:52 +00:00
Tadashi G. Takaoka 9ef59af7ce Merge "Move subtype related utility class to utils package" 2013-07-24 13:34:35 +00:00
Jean Chalard 25de86a6a2 [FD4] Separate cached address before/after update for groups
This should fix bug#8526576 for good.

Bug: 8526576
Change-Id: I473aad26b69d64efa09d2ec9d8e69f29f5cf4819
2013-07-24 18:40:14 +09:00
Jean Chalard 429db8d61e [FD3] Split stackNodes into two methods.
In the future we need to have a method that computes only
from the size, as we used to have, to initialize the cached
addresses, and a much simpler and faster method to copy
the cached sizes.

Bug: 8526576
Change-Id: I6a5a790303ab8f3bf957c7ca266eb12da7c1ad9e
2013-07-24 17:26:16 +09:00
Tadashi G. Takaoka 0c3a9b549c Make RunInLocale as top-level class
Change-Id: I07ed606b7aba098a5be85533e5baff300b21fb44
2013-07-24 16:00:25 +09:00
Tadashi G. Takaoka a410cb48ea Move subtype related utility class to utils package
Change-Id: I3564796531ea85f2ebafde40cd822b806b8741df
2013-07-24 15:52:43 +09:00
Jean Chalard 5526d138fe Merge "[FD2] Separate cached address before/after update for nodes." 2013-07-24 01:56:02 +00:00
Ken Wakasa b9eb32679f Cosmetic fix for the copyright header
Change-Id: I2a93ac21571d1f6255a72a1a238b03dbb95108de
2013-07-23 19:39:03 +09:00
Ken Wakasa db341afc65 Fix wrong copyright header comment
Change-Id: I75ffbc0508c00f7ac8004b764667a174b6ab0b63
2013-07-23 19:26:05 +09:00
Jean Chalard 91cbe3566d [FD2] Separate cached address before/after update for nodes.
Bug: 8526576
Change-Id: Ib9f8594a9e12dc75eba296faff2612c4bd7483d3
2013-07-23 17:52:54 +09:00
Tadashi G. Takaoka e6c5184742 Fix NPE in SubtypeLocale.getSubtypeDisplayName
This change moves the methods that create the subtype display name for
spacebar from MainKeyboardView to SubtypeLocale class, and
consolidates SpacebarTextTests with SubtypeLocaleTests.

Bug: 9962955
Change-Id: Ifa0a08ff80bc30753a213c2feb471599ca63fa66
2013-07-23 13:00:04 +09:00
Jean Chalard 1676b8387f Merge "Fix a bug when moving the pointer in a > 48 chars word" 2013-07-22 08:04:43 +00:00
Jean Chalard 5fa2202e36 Fix a bug when moving the pointer in a > 48 chars word
Bug: 9892261
Change-Id: I9db20c5b20a0764bd9f5b5e2bdc98180bbb9ec15
2013-07-22 17:02:09 +09:00
Ken Wakasa a7d2fc6bef Move settings related classes to "settings"
Change-Id: Id170dbfe2dcfc93130b7be4a84615940403ec37f
2013-07-22 16:35:44 +09:00
Ken Wakasa b03447e1af Move a couple classes to the utils package
Change-Id: Ia14a2011d79bad7cd02697b9254705f6e2099442
2013-07-19 10:46:46 +09:00
Jean Chalard 257750d988 [FD1] Move parents' address computation outside
There is no need to do it repeatedly in this loop: it's
clearer and faster to do it at the end only.

Bug: 8526576
Change-Id: I707571179c89479830891ec6d4fd06a9fffed7c1
2013-07-17 20:47:53 +09:00
Tadashi G. Takaoka 6455172a70 Distinguish key press in repeat key
Bug: 9859367
Change-Id: Iad643f9785b193e1918a8363de4fefc3b7558bdf
2013-07-16 19:21:16 +09:00
Keisuke Kuroynagi 4944827e0f Merge "Add methods for dynamic updating binary dictionary." 2013-07-16 02:45:01 +00:00
Keisuke Kuroynagi cfbb7fbd48 Fix: Read lock is wrongly used for gutSuggestions.
Bug: 9737865

Change-Id: I017f80b46c5dc48c40f2de7c4d516a042992feb4
2013-07-09 08:40:43 +00:00
Ken Wakasa 58b2a6372f Merge "Update ExpandableDictionary.BASE_CHARS[]" 2013-07-08 03:22:15 +00:00
Ken Wakasa d0ca62678d Update ExpandableDictionary.BASE_CHARS[]
This should be the same as CharUtils::BASE_CHARS[] in the native code.

Change-Id: I72ed4a43fd5c26a4439ef791b6b1cf703845c3a1
2013-07-05 20:29:21 +09:00
Tadashi G. Takaoka ccf4a31027 Move TypefaceUtils and ViewUtils to utils package
Change-Id: Iccd47c27670248c43de9a539c1951111d7733111
2013-07-05 19:24:59 +09:00
Tadashi G. Takaoka 4be6198cb7 Reorganize Utils class
Change-Id: I7294d1547def5dcfcae9d1d53b277cb3cc9f2d18
2013-07-05 19:24:40 +09:00
Tadashi G. Takaoka 72c2feb573 Use TimeUnit instead of DateUtils for readability
Bug: 9550800
Change-Id: I087205530a5dbcff4bf08f48f4aa7068aae93215
2013-07-05 17:57:01 +09:00
Jean Chalard cb13d11c0a Add a trace.
Emit a trace when a new dictionary is copied to LatinIME
successfully, not just when it fails. That will help diagnosing
some problems by being able to ensure this step succeeded
looking at the log.
This does not happen often (like, maybe 3 times at device
activation, and once every few weeks afterwards), so I think
the extra line in the log is more than acceptable.

Change-Id: I1674bc22d950a7be801076c5aa7e8bbebccab14b
2013-07-05 12:44:47 +09:00
Keisuke Kuroynagi 49910a9d77 Merge "Fix: release lock in UserHistoryDictionary." 2013-07-04 15:13:09 +00:00
Keisuke Kuroynagi 65db026265 Fix: release lock in UserHistoryDictionary.
Change-Id: I050c252910c6b5b0a79cd2d52c525679f2d6091d
2013-07-04 23:12:49 +09:00
Keisuke Kuroynagi f8d2796724 Add methods for dynamic updating binary dictionary.
Bug: 6669677
Change-Id: I7e681ceec2af712214a647630350cb20be6b0354
2013-07-04 21:17:49 +09:00
Keisuke Kuroynagi edd1992ed3 DictionaryWriter to abstract binary dictionary writing.
UserHistoryDictionary should become to use ExpandableBinaryDictionary.

Bug: 6669677

Change-Id: I6831c7dd2d84207d1a8f51ba15d52e0a72205d0c
2013-07-04 21:06:04 +09:00
Keisuke Kuroynagi 0b1c08bf5a Use ReentrantReadWriteLock in ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2acde0517d5ed5cbd7b7149709e35fc36651335d
2013-07-03 19:46:08 +09:00
Tadashi G. Takaoka f87e8f7ec1 Handling key repeat by emulating key press and code input
This change also eliminates a reference of
AudioAndHapticFeedbackManager from KeyboardSwitcher and MainKeyboard.

Bug: 6522943
Change-Id: Iac42ec8ff00c66deb76a660ffc07477923a58959
2013-07-02 19:50:34 +09:00
Jean Chalard e5a3b77664 Merge "Move Range out of RichInputConnection and rename it." 2013-07-01 07:20:51 +00:00
Keisuke Kuroynagi 109ba3ace3 Merge "Regenerate old version dictionaries using new format." 2013-07-01 07:16:15 +00:00
Jean Chalard 675bcf191c Move Range out of RichInputConnection and rename it.
Range has grown a bit too big to stay an internal class.

Change-Id: Ic3fbc48a5d10776eedd7559c4d696e5926b88288
2013-07-01 15:41:13 +09:00
Keisuke Kuroynagi a62b5b22ef Regenerate old version dictionaries using new format.
Bug: 9617181
Change-Id: I228a3eac959f81b38e4092015e8e3c429d46fa60
2013-07-01 15:25:33 +09:00
Jean Chalard f0af452ce2 Do not re-resume suggestion if it's not needed.
This is much better interface-wise. It eliminates all blinking
of the line in the practice.

Bug: 8874148
Bug: 8864306
Change-Id: I87754e44784327c2e9c8b162d598d145e20668e8
2013-07-01 14:40:12 +09:00
Jean Chalard a5e28acf63 Merge "Fix a bug where AOSP Latin IME would not fill dictionaries" 2013-06-28 13:21:31 +00:00
Jean Chalard 555c4236db Fix a bug where AOSP Latin IME would not fill dictionaries
There is no reason not to contact the dictionary provider
when we don't have internet permission or when the URL
is empty. It knows how to handle both these cases.

Bug: 9388602
Change-Id: I30c4540551ad2f5e527d3acd1842bbd749feca89
2013-06-28 12:48:41 +09:00
Jean Chalard e04794cbbe Fix some warnings
Mostly remove unused imports

Change-Id: If8ceffdfad79b78194094527759f5c334746973e
2013-06-27 21:36:52 +09:00
Satoshi Kataoka 4ded1af210 Improve the language list in the personal dictionary
Bug: 9117704
Change-Id: I26e6f8369a3c7ffa4bb651b4b5a3e6f004121983
2013-06-27 20:31:02 +09:00
Satoshi Kataoka ec69a259c6 Merge "Open an API in ExternalDictionaryGetterForDebug" 2013-06-27 10:32:05 +00:00
Satoshi Kataoka a2bfd46adf Use internal personal dictionary settings on JBMR2 or before
Bug: 9117704
Change-Id: I7e20b03daa23b59211235183cf48d933e32845e4
2013-06-27 19:20:05 +09:00
Satoshi Kataoka bd84a00fc1 Open an API in ExternalDictionaryGetterForDebug
and extend it

Change-Id: Id2ba8dd8928a6327d3b31eb35f7cc314e2d31050
2013-06-27 18:41:07 +09:00
Jean Chalard 2bbd78ab0a Merge "Ignore spans that are not the right size." 2013-06-27 03:06:47 +00:00
Jean Chalard 2f7f6257b6 Ignore spans that are not the right size.
Bug: 8839763
Bug: 8862327
Change-Id: I5d49c86edcbc0fc1b2b147856437cfbadd678377
2013-06-26 23:02:50 +09:00
Jean Chalard 6c0e412137 Merge "Resume suggestion at start input" 2013-06-26 10:18:32 +00:00
Jean Chalard a690f3bc40 Merge "Readability improvement" 2013-06-26 07:37:15 +00:00
Jean Chalard 173f74bb18 Merge "Fixing follow-up to I548d899b" 2013-06-26 07:36:44 +00:00
Jean Chalard fb72890ac6 Readability improvement
Change-Id: I2f350145f333ba1fa4eb20027b0f41107c2df02c
2013-06-26 16:03:40 +09:00
Jean Chalard 7fcf304c97 Fixing follow-up to I548d899b
I548d899b introduced a new method to fix a sync miss between
the cursor position and the cached cursor position, but did not
take into account that it should also update the cached text
before and after the cursor in this case and that there was
already a method for doing this.

Change-Id: I31bd741893207c822827304e77791b1159774e1a
2013-06-26 15:28:42 +09:00
Keisuke Kuroynagi 5bf1be7162 Add jni methods for dynamically handling a dictionary.
Bug: 6669677
Change-Id: I8a26623adbb41a78e3c023c652be635c635e3b47
2013-06-26 12:51:33 +09:00
Jean Chalard 2f69348d51 Resume suggestion at start input
Bug: 9568410
Change-Id: I65468268f8613c863fa7f3a497b64656da0a221c
2013-06-25 19:38:31 +09:00
Ken Wakasa fd0945b0da Merge "Make UserLogRingCharBuffer an external class" 2013-06-25 09:40:31 +00:00
Ken Wakasa 9419e02fd9 Make UserLogRingCharBuffer an external class
Change-Id: I9d506995337d64ec11c72939a8d739423ee46efa
2013-06-25 18:38:13 +09:00
Jean Chalard 333362adfc Merge "Fix the one-suggestion case." 2013-06-25 09:10:09 +00:00
Jean Chalard d7d5ff1f99 Fix the one-suggestion case.
When there is only one suggestion, this code does
not work. The reason for that is, it's not homogeneous
at all and takes indices of one thing into another.

Not completely related to b/8839763, but realized
working on this and needed to have it addressed.

Bug: 8839763
Change-Id: I422730cc7eebb69ff421a171025af0390ebcdf92
2013-06-25 18:00:30 +09:00
Keisuke Kuroynagi 38b542629a Merge "Add a parameter isUpdatable to the constructor of BinaryDictionary." 2013-06-25 08:44:48 +00:00
Keisuke Kuroynagi 981717da4c Add a parameter isUpdatable to the constructor of BinaryDictionary.
Bug: 6669677
Change-Id: I6bc25131afd97112e3bbde036a81ab559a9a6460
2013-06-25 17:39:06 +09:00
Ken Wakasa 12ef7d3702 Merge "Cleanup under the utils package" 2013-06-25 08:20:57 +00:00
Ken Wakasa 03118a2760 Cleanup under the utils package
Change-Id: If2f7bd1346cc5085bf57645830f0faac44d017e4
2013-06-25 17:09:12 +09:00
Keisuke Kuroynagi 8bc0b51369 Merge "Allow mmapping dictionary file in writable mode in openNative." 2013-06-25 07:09:37 +00:00
Keisuke Kuroynagi f3b62900c7 Allow mmapping dictionary file in writable mode in openNative.
Bug: 6669677
Change-Id: I447668932de118b158fa029ddc977b3f3cc06cb8
2013-06-25 16:03:33 +09:00
Jean Chalard 10585620bd Merge "Fix a bug in the cached cursor pos, and simplify selection handling" 2013-06-25 05:00:11 +00:00
Jean Chalard cdf774122d Merge "Fix a small bug" 2013-06-24 10:00:05 +00:00
Ken Wakasa bfaf349c35 Load the native lib eagerly
in the hope of avoiding UnsatisfiedLinkError. This is definitely not a
confident fix as we still don't know the root cause of the issue.

bug: 9325110
Change-Id: I1abf8031b98509f63fce6a2d069d497895ea712c
2013-06-24 18:12:04 +09:00
Ken Wakasa bc1813186d Merge "Move util classes to the latin/utils directory" 2013-06-24 08:49:06 +00:00
Jean Chalard ca52e1ca5a Fix a small bug
SpannableStrings are not the only type of Spanned, they are
only the mutable kind. SpannedString is the immutable one.
Spanned is the correct class to use there.

Bug: 8839763
Bug: 8862327
Change-Id: Ic5e6199a51f22368914f2748ac2d0d1ca6a33f78
2013-06-24 17:39:17 +09:00
Ken Wakasa e28eba5074 Move util classes to the latin/utils directory
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
Jean Chalard e8c4b99e56 Refactor text range to be able to get spans larger than the word
This changes how the Range class stores its data, but not its
functionality. It also improves encapsulation a bit.

Bug: 8839763
Bug: 8862327
Change-Id: I5bd583b3fc96a99b93a2632882d8fd587c03ab76
2013-06-24 12:31:14 +09:00
Jean Chalard b7a2fd16a1 Merge "Defer disk-intensive tasks until after the keyboard is shown" 2013-06-21 10:57:33 +00:00
Jean Chalard 673c727b7a Defer disk-intensive tasks until after the keyboard is shown
Bug: 8689779
Change-Id: Ia78d3540f44ec0028c3246a8e0163e9ecf061ecf
2013-06-21 19:41:45 +09:00
Jean Chalard e5dee0af4a Fix a bug in the cached cursor pos, and simplify selection handling
The documentation for setComposingRegion states explicitly
that it does not move the cursor. This is just a bug.
This does not have any ill effects right now, but it will have
in later changes if not fixed.

As for the selection handling, the specific test that this code
removes used to serve a purpose, but it does not any more because
the code using the value has been much sanitized. Now the variable
can just take the obvious value, and become so self-explanatory
that the comments are unnecessary.

Change-Id: I548d899b38776bd3ab5f5361aab0d89d98f12e73
2013-06-21 18:15:07 +09:00
Tadashi G. Takaoka 9b570b5e62 Fix punctuations strip
Bug: 9508186
Change-Id: I8f0fbf4e0578cf9116d4c57e7e5747d38c89387e
2013-06-21 13:22:37 +09:00
Jean Chalard 93f74bafbb Merge "Add tests to dicttool test." 2013-06-20 08:34:38 +00:00
Jean Chalard 23d4eb55ba Add tests to dicttool test.
Bug: 8526576
Change-Id: Idd6f9cd076d5915361c68f5c29afbba67dd54eba
2013-06-20 17:29:37 +09:00
Tadashi G. Takaoka c90181d6aa Use system default key press volume
Bug: 9475973
Change-Id: I6ae825b161dde69e19b52d73fb9aa782e2aa7423
2013-06-18 21:34:30 +09:00
Tadashi G. Takaoka af69a14c96 Use system default vibration pattern
Bug: 9468462
Change-Id: Ifa46a56873c10888da8eaa2782fe07ef138a141b
2013-06-18 21:33:51 +09:00
Tadashi G. Takaoka 3be8263035 Get value text from ValueProxy
As a preparation to show "system default" in the settings. LatinIME
can't know the actual system default value.

Bug: 9468462
Change-Id: I0b7898d1ca29ded7a619dd636d2ad16eb0db292e
2013-06-18 18:27:17 +09:00
Jean Chalard 2a81943d16 Fix a bug with recapitalization
This is a shameful bug :/

Bug: 9410367
Change-Id: I54ddbcd0323fa2c11fbd2aa8a1b3d2e07f6e83c8
2013-06-17 20:39:06 +09:00
Kurt Partridge 14718ab898 Merge "Log score, kind, and sourceDict for manual suggestion and gesture" 2013-06-14 17:03:03 +00:00
Jean Chalard 6233ee3633 Fix a bug with long user dict entries
Bug: 9410958
Change-Id: I966e452c6dbdcb444abbb6ffb316849a7c85a73b
2013-06-14 12:40:35 +09:00
Kurt Partridge fc98325c61 Log score, kind, and sourceDict for manual suggestion and gesture
b/9422713

Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
2013-06-13 11:03:49 -07:00
Jean Chalard 27d9c6f795 Merge "Cache subtype lists reasonably." 2013-06-13 01:49:41 +00:00
Kurt Partridge e72d1a07b6 Merge "Allow downloadable dictionaries in development builds" 2013-06-12 21:22:34 +00:00
Jean Chalard ff6445ed0e Cache subtype lists reasonably.
This will spare a lot of IPC for Latin IME at the cost of very little
retained memory.
This improves the loading by potentially a lot - between 15 and 30%
when the layout is cached (which should now be the case almost every
time), and half that if it's not. More importantly, it makes the
load time less sensitive to high device load, which is one of the
sore points.

Bug: 8689779
Change-Id: I2e07736f1a92c38eed0e203bc690761a181da8b9
2013-06-12 18:04:52 +09:00
Kurt Partridge 2a1a463e2e Adjust settings for development-only versions
Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
2013-06-12 02:01:45 -07:00
Satoshi Kataoka fe95e7b1bf Merge "Fix possible NPE" 2013-06-07 11:09:52 +00:00
Tadashi G. Takaoka 77f63c8ac6 Don't use RichInputMethodManager in setup wizard
In setup wizard, InputMethodManager may not be able to be aware that
this IME is installed, especially just after the IME is installed via
GooglePlay app and hit the open button on the app to launch the setup
wizard.

Bug: 9299618
Change-Id: I00c8544178b41074253d49ae9481996ec56593d2
2013-06-07 19:09:44 +09:00
Satoshi Kataoka 6c8136d157 Fix possible NPE
Bug: 9314901
Change-Id: Id80f59df38ae72766b097fd1c23326fedd302439
2013-06-07 19:08:58 +09:00
Tadashi G. Takaoka 254b484e75 Defer getting no language subtype
Bug: 9318351
Change-Id: I55338c001070655a3f90df3dbe1351bd4180d520
2013-06-07 18:20:31 +09:00
Jean Chalard 6910032972 Merge "Use an iterator to remove stuff from an ArrayList." 2013-06-06 08:19:41 +00:00
Jean Chalard 0dc422e0c7 Use an iterator to remove stuff from an ArrayList.
Silly me >.>

Bug: 9306154
Change-Id: Ic00e9d6a31cd1d7aacefe68b7be9c2199e297b0d
2013-06-06 17:03:16 +09:00
Kurt Partridge efd26bb319 Allow downloadable dictionaries in development builds
Bug: 9305379

Change-Id: Iab32753070a056d3861a45aa898911b7ab67dfb6
2013-06-05 22:14:54 -07:00
Satoshi Kataoka f6a1a76524 Merge "Fix a possible NPE" 2013-06-06 05:02:46 +00:00
Satoshi Kataoka 6f9c6f2c64 Fix a possible NPE
Bug: 9301208
Change-Id: Id120c99ab9ef698d16cf7b8beea30c98c95d23a1
2013-06-06 12:01:22 +09:00
Tadashi G. Takaoka cbd219a761 Move Base64Reader to utils package
Change-Id: Id46898c5cae268f05850d79938929b7707f27320
2013-06-05 19:39:36 +09:00
Tadashi G. Takaoka 9d4e251826 Merge "Add CsvUtils that conform to RFC 4180" 2013-06-05 06:28:06 +00:00
Tadashi G. Takaoka 3ceeb6bcc6 Add CsvUtils that conform to RFC 4180
Bug: 9070153
Change-Id: I66e55dd2f30fddfeb849edb97bc1cbda6b126d92
2013-06-05 12:26:22 +09:00
Tadashi G. Takaoka 0bfc2bc419 Merge "Add CODE_CAPSLOCK for long press shift key" 2013-06-05 02:19:02 +00:00
Tadashi G. Takaoka 9552badf3c Add CODE_CAPSLOCK for long press shift key
This change utilizes the no panel auto more key feature to implement
long press shift key for shift lock.

Change-Id: I3995d25dc35aea3c67b5aa29299815462eff9cad
2013-06-04 18:20:06 +09:00
Tadashi G. Takaoka cbc7acb6f5 Merge "Expand suggestion strip when center suggestion is long" 2013-06-03 14:45:05 +00:00
Tadashi G. Takaoka 9ff7354d78 Clear previous suggestions when gesture typing starts
Bug: 8651076
Change-Id: Ic65ed3e3696409edea4e35080c11e4d1869a5a7e
2013-06-03 17:59:26 +09:00
Tadashi G. Takaoka 043273b00f Expand suggestion strip when center suggestion is long
Bug: 9059710
Change-Id: I7fa2658cc6442e86f69c991f1e99db6fb1ef909c
2013-06-03 16:12:59 +09:00
Tadashi G. Takaoka 72ac390ce6 Fix ArrayIndexOutOfBoundException
Change-Id: I243fc4965365680615eed834efe9ae0240e7f2a8
2013-06-03 15:35:49 +09:00
Kurt Partridge 743302888b Merge "Uncommit separator LogUnits" 2013-06-03 03:01:23 +00:00
Kurt Partridge 3d20946272 Merge "Uncommit LogUnits when reverting textInput" 2013-06-03 02:58:20 +00:00
Kurt Partridge 4efb5c3b65 Merge "Remove uncommit on reverting batch input" 2013-06-03 02:54:33 +00:00
Kurt Partridge bdff287a0d Uncommit separator LogUnits
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.

Bug: 9088919

Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
2013-06-02 19:15:57 -07:00
Kurt Partridge 720840851d Uncommit LogUnits when reverting textInput
Bug: 9088919

Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
2013-06-01 23:42:35 -07:00
Kurt Partridge 4165ef031f Remove uncommit on reverting batch input
Currently when the user reverts a batch input, a LogUnit is uncommitted
from the LogBuffer.  It should not be, because the LogUnit containing the
batch input is never committed in the first place (it is only committed
to the LogBuffer when a key is pressed or a new batch input is entered).

Bug: 9088919

Change-Id: I323af453ce082437a663ccae977b21b775a964bc
2013-06-01 11:15:47 -07:00
Jean Chalard f61999caba Merge "Make it easy to open several dictionaries from tests" 2013-05-31 11:21:37 +00:00
Tadashi G. Takaoka a0c3e02d71 Refactor SuggestionStripLayoutHelper a bit
Bug: 9059710
Change-Id: Ief12029bad75d4dc78090ab97555aece01b873de
2013-05-31 18:14:47 +09:00
Jean Chalard 1562fc91f0 Make it easy to open several dictionaries from tests
Bug: 9127175
Change-Id: I3f1840ee73b364df26dfddb5acb10001e0f2cb61
2013-05-31 15:36:05 +09:00
Tadashi G. Takaoka 723391c945 Merge "Tidy up Utils class a bit" 2013-05-31 06:29:24 +00:00
Kurt Partridge e6125db98d Merge "Catch a permission exception" 2013-05-31 00:30:14 +00:00
Kurt Partridge d63f756013 Catch a permission exception
This change catches a SecurityException if the DictionaryProvider is
unavailable.

Change-Id: I4f2d87327c40765383d8847fd4e934b3cf799488
2013-05-30 13:40:40 -07:00
Tadashi G. Takaoka cbb99c60be Tidy up Utils class a bit
Change-Id: Idc2feb84a902a6cbb7265d1efe06c34e7d63c2c7
2013-05-31 00:32:57 +09:00
Tadashi G. Takaoka 7097aa2d3d Merge "Cleanup unreadable variable names" 2013-05-30 13:09:27 +00:00
Tadashi G. Takaoka d67db32b30 Merge "Separate SuggestionStripLayoutHelper for readablity" 2013-05-30 13:09:17 +00:00
Jean Chalard 1a50999ed9 Merge "Tell the text view we reset state on finish input" 2013-05-30 11:53:50 +00:00
Jean Chalard e90d039e0c Fix two strict mode warnings.
Bug: 9052555
Change-Id: I86e90488679a78a9f6e901b640025619293765a0
2013-05-30 20:12:05 +09:00
Tadashi G. Takaoka 500a9752b1 Cleanup unreadable variable names
Change-Id: Ic97687c58e25e4b0c6833cc25d10854f5f513081
2013-05-30 19:49:51 +09:00
Tadashi G. Takaoka 653603b725 Separate SuggestionStripLayoutHelper for readablity
Change-Id: I82c749c6837c3af7ae290f4cd92f5426ca58b5c7
2013-05-30 19:49:20 +09:00
Jean Chalard 68d9cb62e2 Tell the text view we reset state on finish input
This should be done in onFinishInput rather than onFinishInputView
but for an unknown reason onFinishInput never comes.

Bug: 9113167
Change-Id: Iafb40846a3ed8fad78bfc160d17cd431f81fe891
2013-05-29 18:44:40 +09:00
Tadashi G. Takaoka d99abf8cb1 Delete shared preference entry when user select default value
Change-Id: I3fbafd9024c26a99d87376f5d5e359e03988a30f
2013-05-28 20:44:25 +09:00
Tadashi G. Takaoka 39bd6ea0dc Merge "Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs" 2013-05-28 11:40:10 +00:00
Tadashi G. Takaoka dbed20ad8d Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs
Change-Id: I16e3f3ebc43772cfd96c824afeddfd225404b857
2013-05-28 20:23:37 +09:00
Tadashi G. Takaoka d69e4191b7 Merge "Refactor suggestion strip layout methods a bit" 2013-05-28 11:11:05 +00:00
Tadashi G. Takaoka 389d308fff Refactor suggestion strip layout methods a bit
Bug: 9059710
Change-Id: I8dc698c1d61ca51b65b232e6c586472588a4accb
2013-05-28 20:03:37 +09:00
Tadashi G. Takaoka 4c2ac9ee5f Merge "Rename commaConcatinatedText to commaSplittableText" 2013-05-28 10:58:16 +00:00
Tadashi G. Takaoka c47bc30db8 Rename commaConcatinatedText to commaSplittableText
This is a follow up of I5a32882a08.

Change-Id: I9f0cda2167811f6bba2af042fbde0a821b4cfecd
2013-05-28 19:17:15 +09:00
Tadashi G. Takaoka 68cf2cd931 Merge "Check all regexp patterns in ResourceUtils.getDeviceOverrideValue" 2013-05-28 10:13:43 +00:00