Commit graph

4306 commits

Author SHA1 Message Date
Tadashi G. Takaoka
5e58cd999c am d549d433: Merge "Remove long press settings key function"
* commit 'd549d4334f05737128061a595a0a3304b1af00b6':
  Remove long press settings key function
2011-12-15 10:08:32 -08:00
satok
6140e326d7 am c115aed9: Merge "Unbundle members in unigram_dictionary"
* commit 'c115aed98f9d1a3cc09b3c04e659bfe0f28d91d6':
  Unbundle members in unigram_dictionary
2011-12-15 10:08:31 -08:00
Tadashi G. Takaoka
4a7adcbace am 6652e458: Merge "Move Keyboard.themeName to KeyboardSwitcher and make it private"
* commit '6652e4589981a0f06692b49e86d1a6f0784a434f':
  Move Keyboard.themeName to KeyboardSwitcher and make it private
2011-12-15 10:08:30 -08:00
Tadashi G. Takaoka
c479d88196 am 90c12077: Merge "Remove EditorInfo from KeyboardId"
* commit '90c12077b2c57afe34b5d9d02fd6a9dcdd9b0cfc':
  Remove EditorInfo from KeyboardId
2011-12-15 10:08:30 -08:00
Tadashi G. Takaoka
be6d5a041c am a042150a: Merge "Just ignore settings/shortcut key while typing on tablet"
* commit 'a042150a697715ca0b65fcc1a03fcc3491c488a2':
  Just ignore settings/shortcut key while typing on tablet
2011-12-15 10:08:29 -08:00
Jean Chalard
e3297a79ff am 9750165c: Merge "Cleanup"
* commit '9750165c9a134a8981747f1ca1d279f0086829e5':
  Cleanup
2011-12-15 10:08:28 -08:00
Tadashi G. Takaoka
7bc67e14a1 am 014b755f: Merge "Cleanup KeyboardId\'s hasCode method"
* commit '014b755f8a22c9b5cfc70fa3c80355543445feed':
  Cleanup KeyboardId's hasCode method
2011-12-15 10:08:27 -08:00
Jean Chalard
d752540d41 am 64361bd6: Merge "Move some code inside a function to simplify flow"
* commit '64361bd66d2d764bd5fb6486e9b9de5a3f2fb240':
  Move some code inside a function to simplify flow
2011-12-15 10:08:27 -08:00
Jean Chalard
b60ab9752c am 676917de: Merge "Fail faster in case of a bug"
* commit '676917dea2595d7bbc1f24a44034a4254a1884fa':
  Fail faster in case of a bug
2011-12-15 10:08:26 -08:00
Tadashi G. Takaoka
6168c33aac am 2c4b21d7: Merge "Cleanup settings key related stuff"
* commit '2c4b21d7ca659e958d77eff660abab7104e03cca':
  Cleanup settings key related stuff
2011-12-15 10:08:25 -08:00
Jean Chalard
ed6522b30b am b5880034: Refactoring.
* commit 'b5880034268111a094c9e684cec9cca784386140':
  Refactoring.
2011-12-15 10:08:25 -08:00
Tadashi G. Takaoka
b9f71631da am e35e13fc: Merge "Record onStartInputView"
* commit 'e35e13fc7dc046be7f605cbfc706678f57e40491':
  Record onStartInputView
2011-12-15 10:08:23 -08:00
Tadashi G. Takaoka
b0980f0d90 am 689b9011: Merge "Utilize KeyboardSet XML definitions"
* commit '689b90115633146bcdea81bf89cdfe2f9a88c0a7':
  Utilize KeyboardSet XML definitions
2011-12-15 10:08:22 -08:00
Jean Chalard
d86696a110 am dbdb385b: Merge "Fix a long-standing race condition."
* commit 'dbdb385bb06ccd235b3b6445ceabf07ca893454b':
  Fix a long-standing race condition.
2011-12-15 10:08:21 -08:00
Jean Chalard
9b5e67a281 am 4fc97c2c: Add a note of documentation to the sample word list
* commit '4fc97c2c01646d877505295713abdf16d775d3d4':
  Add a note of documentation to the sample word list
2011-12-15 10:08:21 -08:00
Tadashi G. Takaoka
d549d4334f Merge "Remove long press settings key function" 2011-12-14 03:02:09 -08:00
satok
c115aed98f Merge "Unbundle members in unigram_dictionary" 2011-12-14 02:54:41 -08:00
Tadashi G. Takaoka
17dc10724b Remove long press settings key function
Bug: 5759092
Change-Id: I328e2043075ce5d0d0285febc4a9b7356702c250
2011-12-14 19:47:17 +09:00
satok
1147c7bac9 Unbundle members in unigram_dictionary
Change-Id: Id737d943d20e3de3db568162caf40d3e956c7fae
2011-12-14 19:45:51 +09:00
Tadashi G. Takaoka
6652e45899 Merge "Move Keyboard.themeName to KeyboardSwitcher and make it private" 2011-12-14 02:43:06 -08:00
Tadashi G. Takaoka
90c12077b2 Merge "Remove EditorInfo from KeyboardId" 2011-12-14 02:42:58 -08:00
Tadashi G. Takaoka
7a91deb685 Move Keyboard.themeName to KeyboardSwitcher and make it private
Change-Id: I101b6927d43e86b3c636c1a527e181df8af9c73e
2011-12-14 19:01:20 +09:00
Tadashi G. Takaoka
a042150a69 Merge "Just ignore settings/shortcut key while typing on tablet" 2011-12-14 01:59:46 -08:00
Tadashi G. Takaoka
2d603fff64 Remove EditorInfo from KeyboardId
Change-Id: I70919ff30622afa1d8c29ca45589fa617f2c1f0e
2011-12-14 18:58:55 +09:00
Jean Chalard
9750165c9a Merge "Cleanup" 2011-12-14 01:50:25 -08:00
Tadashi G. Takaoka
014b755f8a Merge "Cleanup KeyboardId's hasCode method" 2011-12-14 01:48:46 -08:00
Jean Chalard
f3ca6a59a7 Cleanup
Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
2011-12-14 18:42:47 +09:00
Tadashi G. Takaoka
601e411c13 Cleanup KeyboardId's hasCode method
Change-Id: I5fd8f6ac0f42152fb0e2aaaedc6092f6d82fe677
2011-12-14 18:42:20 +09:00
Jean Chalard
64361bd66d Merge "Move some code inside a function to simplify flow" 2011-12-14 01:42:17 -08:00
Jean Chalard
676917dea2 Merge "Fail faster in case of a bug" 2011-12-14 01:42:05 -08:00
Tadashi G. Takaoka
2c4b21d7ca Merge "Cleanup settings key related stuff" 2011-12-14 01:36:34 -08:00
Jean Chalard
1c6cf26c37 Move some code inside a function to simplify flow
Also rename the function to reflect better the behavior.
An upcoming change will clean up the remnants

Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
2011-12-14 17:56:57 +09:00
Jean Chalard
46798d8f1f Fail faster in case of a bug
Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
2011-12-14 17:54:18 +09:00
Tadashi G. Takaoka
623d0155b6 Just ignore settings/shortcut key while typing on tablet
Bug: 5759096
Change-Id: Ie1f1800d0f32ac0938715c79974e0f382c9c3d27
2011-12-14 17:14:44 +09:00
Jean Chalard
b588003426 Refactoring.
Small simplification of the code.

Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
2011-12-14 16:59:25 +09:00
Tadashi G. Takaoka
8b1b8aae9c Cleanup settings key related stuff
Change-Id: Ie0d1204e94fcdf9d578974256bf2ae3e87797f13
2011-12-14 16:34:35 +09:00
Tadashi G. Takaoka
e35e13fc7d Merge "Record onStartInputView" 2011-12-13 23:31:43 -08:00
Tadashi G. Takaoka
689b901156 Merge "Utilize KeyboardSet XML definitions" 2011-12-13 23:31:00 -08:00
Jean Chalard
dbdb385bb0 Merge "Fix a long-standing race condition." 2011-12-13 23:29:47 -08:00
Tadashi G. Takaoka
f86109ca56 Utilize KeyboardSet XML definitions
This change introduces KeyboardSet and SubKeyboard XML definitions to
represent a set of keyboard layouts.

Bug: 5002108
Bug: 5679585
Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
2011-12-14 16:28:31 +09:00
Jean Chalard
514beb0992 Fix a long-standing race condition.
Upon autocorrection, there is visual feedback in the text
view that quickly flashes the background of the text that
just changed. This fixes a race condition that happens
upon autocorrection when typing fast, and that results in
flashing one character too far left (typically, the flashing
area includes the whitespace before the corrected word and
not the last character of the corrected word).
This happens because the call to commitCorrection may
happen before or after the IPC sent by sendKeyChar, but the
arguments are fit only for the case where it arrives first.

Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
2011-12-14 16:24:18 +09:00
Tadashi G. Takaoka
7ef235f53f Record onStartInputView
Bug: 5722703
Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
2011-12-14 16:22:30 +09:00
Jean Chalard
4fc97c2c01 Add a note of documentation to the sample word list
Change-Id: I95f09da03457933a14b549e04575d566de97dd49
2011-12-14 15:25:31 +09:00
Jean Chalard
01bf066c68 am 8e3faff2: Merge "Decouple member logic from control flow"
* commit '8e3faff244a03aa49dfff03f2a6d982590ff605c':
  Decouple member logic from control flow
2011-12-13 06:30:56 -08:00
Jean Chalard
9d6113257c am f7d6517d: Various mini-cleanups
* commit 'f7d6517d6b1a1dd88e2142e1a15703bb839be01b':
  Various mini-cleanups
2011-12-13 06:30:55 -08:00
Jean Chalard
8e3faff244 Merge "Decouple member logic from control flow" 2011-12-13 06:28:48 -08:00
Jean Chalard
7b5bc1ff4d Decouple member logic from control flow
This place is very confusing because a member variable with
a consistent meaning is hijacked for the duration of a function
to mean something else. This is in the way of easy-to-understand
refactoring.

Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
2011-12-13 23:15:12 +09:00
Jean Chalard
f7d6517d6b Various mini-cleanups
- Stop the word composer from escaping - take a page from the law
  of Demeter and only report what is actually needed.
- Fix typos in comments.
- Add a comment for a fishy processing.
- Remove a useless local variable.

Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
2011-12-13 23:09:22 +09:00
Jean Chalard
df963957f5 am edf4995a: Merge "Remove the input connection sidework from handleCharacter"
* commit 'edf4995a3bad3b95a2b4184d47ea4ff890d0de73':
  Remove the input connection sidework from handleCharacter
2011-12-13 05:48:31 -08:00
Ken Wakasa
09762878d0 am 5a603f3f: Merge "Reorganize LatinIME native build directory structure. Now it got NDK friendly."
* commit '5a603f3fa2221a68452939dc1e6bb8f5444f04eb':
  Reorganize LatinIME native build directory structure.  Now it got NDK friendly.
2011-12-13 05:48:30 -08:00