Commit Graph

7878 Commits (5c4f642df61b8672b1aa913992b981284f07eba7)

Author SHA1 Message Date
Tadashi G. Takaoka 395009c03e Fix NPE in AppearanceSettingsFragment
Bug: 18147440
Change-Id: I7a7a47b3484e54146d34d11b5bd9c1305421d829
2014-10-28 15:02:31 +09:00
Jean Chalard 67527f847e [CS8] Add explanations
Bug: 13238601
Change-Id: I72a78be5848485f7fd77f5586573692529c7547b
2014-10-28 13:41:00 +09:00
Tadashi G. Takaoka d5455fea4a Merge "Add null analysis annotation to CollectionUtils" 2014-10-27 09:43:22 +00:00
Tadashi G. Takaoka 7a3de4dca9 Add null analysis annotation to CollectionUtils
Change-Id: I3a610b037d6d1431cced3ea193171108bd5a040d
2014-10-27 18:30:29 +09:00
Tadashi G. Takaoka f6a6371096 Refactor CoordinateUtils
Change-Id: I607b803273a4d7983e9e25a81b6941a3b59194c6
2014-10-27 18:02:33 +09:00
Tadashi G. Takaoka f7e01e866f Remove device checking of Emoji physical key
This CL also adds a settings option to enable/disable an Emoji-ALT
physical key.

Bug: 18122464
Change-Id: Iee1d97efec979a902b0492071d5e511ca1792ff0
2014-10-27 16:26:22 +09:00
Ken Wakasa 53b010384e Remove an unused import
Follow up to I2b81450f99d7b4493ba0fc5e502f4333b8db48cd

Change-Id: I3d106db076e8181b65ce6843b801d12c6ca0adb1
2014-10-24 21:36:24 +09:00
Ken Wakasa 23a357d71d Small cleanup
Change-Id: I2b81450f99d7b4493ba0fc5e502f4333b8db48cd
2014-10-24 19:47:26 +09:00
Tadashi G. Takaoka 067d8cdf56 Fix unit test breakage
Change-Id: I538288054a58eb2c81ce3cbe5c9bef900fb653a5
2014-10-24 16:48:46 +09:00
Keisuke Kuroyanagi aad188d40a Merge "Height of the keyboard for spellchecker is too large." 2014-10-24 06:29:10 +00:00
Keisuke Kuroyanagi 6cc318bd6a Height of the keyboard for spellchecker is too large.
Bug: 18109041
Change-Id: I0eb98a66290058c28e20c86f36395af4f763952e
2014-10-24 14:59:52 +09:00
Ken Wakasa 7e88eae623 Add missing header
Change-Id: I1befc2f1288674b4d871b27bdc5251b2b95e8bb7
2014-10-24 12:00:26 +09:00
Ken Wakasa 2c6aaa7c3c Merge "Move Constants.java to the latin.common package" 2014-10-24 02:50:07 +00:00
Keisuke Kuroyanagi 989699a690 Fix unit tests (InputLogicTestsDeadKeys).
Change-Id: I9a3191548aa0a4e674d736bc10845b952fc9a1e8
2014-10-23 22:09:08 +09:00
Ken Wakasa 9342484e8d Move Constants.java to the latin.common package
Our intention is to have classes of latinime-common under the common
package as much as we can.

Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
2014-10-23 20:27:37 +09:00
Jean Chalard b224594aca Merge "Fix a concurrency bug that ends up in a crash." 2014-10-23 08:02:37 +00:00
Keisuke Kuroyanagi ade5ad1dae Merge "Use trigrams for personalization dict." 2014-10-23 05:42:38 +00:00
Keisuke Kuroyanagi 16cc3992d7 Use trigrams for personalization dict.
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
2014-10-23 14:32:45 +09:00
Ken Wakasa b11fc7d423 Move annotations classes to latiime-common
Move Constants.java too.

Change-Id: I55e8cf06f61c0a37746a7328834a52a5306cf0f2
2014-10-23 13:00:46 +09:00
Jean Chalard 4097a20b36 Fix a concurrency bug that ends up in a crash.
Bug: 18085768
Change-Id: I016bec997787839526ddfc521ebb99d0c7b05189
2014-10-23 12:36:42 +09:00
Tadashi G. Takaoka d3a4c51324 Fix Javadoc and null analysis related warnings
This CL also adds @SuppressWarning("unused" to java-overridable package.

Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
2014-10-23 09:58:42 +09:00
Keisuke Kuroyanagi b5ef884fbb Support dumping ngram entries.
Bug: 14425059
Change-Id: Ib03a0c3d166ed6f1e60c67127b28006d55143b6b
2014-10-22 18:15:53 +09:00
Yohei Yukawa baecaa5411 Merge "Remove BuildCompatUtils.VERSION_CODES_LXX" 2014-10-22 02:01:32 +00:00
Yohei Yukawa 66d30a4b22 Remove BuildCompatUtils.VERSION_CODES_LXX
Finally it is turned out to be a XXL-size Lollipop.

Change-Id: Icbd22506be9de514eba287cdd8d97fbfd070ac09
2014-10-22 01:29:58 +09:00
Yohei Yukawa 63cbdf49b9 Add @Override for a method that is overriding a new L API
Now all the downstream builds have switched to API Level 21.
Hence putting @Override to new APIs no longer makes javac unhappy.

Change-Id: Ib3324a5d06b17d298beacab8c8802bb14e5be968
2014-10-22 01:28:10 +09:00
Tadashi G. Takaoka 46a007261f Merge "Fix some compiler warnings" 2014-10-21 15:06:55 +00:00
Tadashi G. Takaoka 5f00fe09e9 Fix some compiler warnings
This CL fixes the following compiler warnings.

- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations

Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
2014-10-21 19:28:37 +09:00
Tadashi G. Takaoka 2105aa3ea6 Merge "FIx potential NPE" 2014-10-21 08:14:46 +00:00
Tadashi G. Takaoka 097bcdcde8 FIx potential NPE
Bug: 18052047
Change-Id: I9097d0a504b8a1d875cf66e44bb65eb6ecc8908e
2014-10-21 14:13:27 +09:00
Adrian Velicu 05172bf1a5 Renaming "blacklist" flag to "possibly offensive"
No behaviour changes.
Unified the overloaded FusionDictionary::add method to always take an
isPossiblyOffensive argument.

Bug: 11031090
Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
2014-10-21 11:51:47 +09:00
Tadashi G. Takaoka b0ccf3a0a2 Refactor CustomInputStyleSettingsFragment
Bug: 18003991
Change-Id: Ib005dd394faf546e4faed89ff2018ce49858a06e
2014-10-20 17:12:33 +09:00
Keisuke Kuroyanagi 1085fef8d0 Change entry count limit.
Unigram 10K, Bigram 30K, Trigram 30K.

Change-Id: Ibd19c6a2b618499df1c70000bad7b47498187f0a
2014-10-20 15:01:49 +09:00
Nick Kralevich 01acdac11e fix build
Change-Id: Iedbf01e1c6191350aed8d31c2638b2430e67a36f
2014-10-18 07:37:46 -07:00
Nick Kralevich 237f6ca799 fix build
Change-Id: I58a94fc0be01f272b6ad12524946f073c9f49894
2014-10-18 06:50:03 -07:00
Jean Chalard ea32e8fb04 Merge "Enforce a length limit to auto-correction for some languages" 2014-10-17 13:11:39 +00:00
Jean Chalard 8fc872762f Enforce a length limit to auto-correction for some languages
Bug: 15379262
Change-Id: I27fad12f468b5bc6ad1a0876aac72e5f5ca5760a
2014-10-17 22:05:05 +09:00
Tadashi G. Takaoka ad2f695083 Bring back long press timeout settings
Bug: 18025209
Change-Id: Id8dbb051e04270f6892cae12a443103bd0d32dcb
2014-10-17 18:20:43 +09:00
Jean Chalard bd4693cd3f Merge "[ML27.1] Allow adding additional features to other settings" 2014-10-16 11:08:37 +00:00
Jean Chalard bdf70af177 [ML27.1] Allow adding additional features to other settings
We may want to add additional features from some of the
other screens.

Bug: 11230254
Bug: 17966252
Change-Id: I1bb877e5cbdd74f2ffa8010b5bc6af35fe77279a
2014-10-16 19:32:00 +09:00
Jean Chalard eaa7efd136 [ML29] Reinitialize the subtype at input start
Bug: 11230254
Bug: 17994347
Change-Id: I3476909c4b371d6e94a0d4c35d91e109d639b8d5
2014-10-16 18:43:14 +09:00
Jean Chalard f13487dfbf [ML25] Add an hasDict method.
We used to have separate methods for existence of dicts
according to whether it's a file or a resource. This unifies both.

Bug: 11230254
Bug: 17979623
Change-Id: I728773461f3465f756d06297c3f3bee34390c3e6
2014-10-16 17:09:27 +09:00
Jean Chalard 17100ad8ea am 8435acd7: am f7f786d8: am d9c04a6b: am 6456af0e: am ecea8551: Fix a bug with no suggestions flag
* commit '8435acd789bd4f9c1322a73b9e0567c2dee7b336':
  Fix a bug with no suggestions flag
2014-10-15 07:52:58 +00:00
Jean Chalard ecea8551c3 Fix a bug with no suggestions flag
We should reset the composition state when moving the cursor inside
the word after a gesture when the text field specifies no suggestions.

Bug: 17959921
Change-Id: I977fea775f7b7e145e343636f0fb94266a40953a
2014-10-15 06:15:02 +00:00
Sandeep Siddhartha b17a3bc4e8 Move sync policy related code out of account settings
Bug: 17981687
Bug: 17464069
Change-Id: I0ae3400564fd346cc84af74dfef65f01cc1ce6a8
2014-10-14 13:39:28 -07:00
Tadashi G. Takaoka 296b11503e Merge "Add JSR305 annotation to LeakGuardHandlerWrapper" 2014-10-14 12:30:12 +00:00
Jean Chalard 10ac940312 Merge "[ML24] Add facilities to read the script of a subtype" 2014-10-14 11:26:07 +00:00
Jean Chalard b256bb5791 [ML24] Add facilities to read the script of a subtype
...or more exactly, the script of the keyboard layout set associated
with a given subtype.

Bug: 11230254
Change-Id: I82f5fc81ecffc561781816008c853be6ff9438dd
2014-10-14 20:19:15 +09:00
Keisuke Kuroyanagi d1471ee053 Merge "Remove shouldBlockAutoCorrectionBySafetyNet" 2014-10-14 10:52:32 +00:00
Tadashi G. Takaoka c4ffa235e5 Add JSR305 annotation to LeakGuardHandlerWrapper
Change-Id: I7456200af739db4510c5549b7bc894fb48749455
2014-10-14 18:19:22 +09:00
Ken Wakasa 95f100ba40 Merge "Performance fix for multiple language subtypes" 2014-10-14 06:42:14 +00:00
Jean Chalard d15f6e8c98 Performance fix for multiple language subtypes
The code would iterate all enabled subtypes each time
getCurrentSubtype() is called, which is really quite frequent.

Bug: 11230254
Change-Id: I91feb36de6eca84967e848fc585aae04b350be89
2014-10-14 15:13:35 +09:00
Jean Chalard 9959140f15 Merge "Fix an NPE." 2014-10-14 02:51:16 +00:00
Jean Chalard 7d74594123 Fix an NPE.
Bug: 17958289
Change-Id: I5c9ea668ff75b38c7ddebd767c36a950835c0c9f
2014-10-14 11:42:43 +09:00
Sandeep Siddhartha cbd59e02a9 Merge "Don't restore debug preferences" 2014-10-14 02:28:50 +00:00
Keisuke Kuroyanagi 29b4f7aa67 Remove shouldBlockAutoCorrectionBySafetyNet
Bug: 13756409

[Category diff]
+1      27
-1       0
+2       0
-2       0
+3       0
-3       1
+4      11
-4       0
+5      51
-5       0
+6       0
-6      38
+7       0
-7      50

[Weighted category diff]
+1      28
-1       0
+2       0
-2       0
+3       0
-3       1
+4      11
-4       0
+5      51
-5       0
+6       0
-6      39
+7       0
-7      50

show diff for ./en_user_log_phones_2011_08.csv
+1       4
+4       5
+5       7
-6       9
-7       7

The increase of false positives comes from the spaceless
typing test cases that are synthetic data.

Change-Id: I4ea77aa56ebfaa5518c71107169e1d2332de6327
2014-10-14 11:20:33 +09:00
Sandeep Siddhartha 06a438d3a5 Don't restore debug preferences
Bug: 17942814
Change-Id: I0bbef716dff47ed8eb880209d448629ad853b904
2014-10-13 18:59:48 -07:00
Tadashi G. Takaoka ae3ad8ebdd (DO NOT MERGE) Fix checking a11y status just before calling an a11y method
Cherry picked from Master, commit 04cd8794e0

Bug: 17035860
Change-Id: I9627d525a570ced085281b4db93fe6896081e818
2014-10-14 01:40:27 +00:00
Sandeep Siddhartha 19084d076a Cleanup LoginAccountUtils
Bug: 17464068
Change-Id: Icf994a7582491afebc5db522c127a30d079ce05c
2014-10-13 12:23:22 -07:00
Sandeep Siddhartha d9015233f5 Set up a sync preference and policy for syncing [2]
- Adds a preference for enabling sync, which controls the sync behavior
- Make the ProductionFlags depend on appropriate flags to guarantee that
  we don't mess things when flipping some flags
- Preferences now control the "syncable" property of the provider
  thereby controlling the policy and when this entry shows up in
  system settings.

Bug: 17464069
Change-Id: I1d58351188518c1ae9f1f9e147b5ea15d32a3427
2014-10-10 16:03:54 -07:00
Sandeep Siddhartha 1e10d29bc8 Don't restore device specific preferences
There are two categories of preferences:
1. That are part of the default shared preference
   They were all getting backed up and restored.
   Added a blacklist to not restore some of these.
   e.g. current account

2. That are in a non-default shared preference file.
   These are not getting backed up currently, but added a specific
   local preference file for all such preferences.

Bug: 17288591
Change-Id: I2f748be971a2337543e5014434aa39313fd1e1d8
2014-10-10 10:49:32 -07:00
Tadashi G. Takaoka 6e565332df Merge "Fixing keyboard theme selection" 2014-10-10 09:28:24 +00:00
Jean Chalard 7d5e1cb265 [ML23] Introduce a different accuracy/performance tradeoff
Bug: 11230254
Change-Id: Ic09518c818ae7b68942b1c63160dd462e5922cb5
2014-10-10 18:02:52 +09:00
Tadashi G. Takaoka 4f17f3df46 Fixing keyboard theme selection
Bug: 17937287
Change-Id: I476045980843c5897820cd544daea06fa991acb5
2014-10-10 17:42:03 +09:00
Jean Chalard 5d2d852eb0 [ML22] Improve the language on spacebar for SLS
Bug: 11230254
Change-Id: Ib54be1a2a77b6e80cdff1af89a7b4203ea859716
2014-10-10 16:19:48 +09:00
Jatin Matani 701b14ffa6 Merge "Make SuggestionWordInfo non-final for testabilty" 2014-10-10 05:18:55 +00:00
Sandeep Siddhartha 80f0e89aaf Remove UsedForTesting tags from BlockingHttpClient
Bug: 17464069
Change-Id: I45aa6da0e339ffb56de613c2a0a43fe37fb2defd
2014-10-09 14:30:45 -07:00
Jatin Matani eaf517ffea Merge "Changes related Sync Engine library that communicates to cloud server" 2014-10-09 18:06:32 +00:00
Jean Chalard bc18005948 Always show the typed word in recorrections.
Bug: 11330140
Bug: 17875601
Bug: 17623275
Change-Id: Ie4620f36f312c54c7b01b5f6cbdb0bc9171b6179
2014-10-09 17:54:58 +09:00
Keisuke Kuroyanagi 41302021d6 Merge "Rename updateCounter to updateEntriesForWordWithNgramContext." 2014-10-09 08:51:18 +00:00
Keisuke Kuroyanagi ab4437f468 Rename updateCounter to updateEntriesForWordWithNgramContext.
Bug: 14425059
Change-Id: Id9b0dd7e32c711ed4292981517c3febd5fe9e897
2014-10-09 17:34:29 +09:00
Keisuke Kuroyanagi fca049a4b0 Merge "Extend jni method to dump ngram entries." 2014-10-09 08:28:13 +00:00
Yohei Yukawa 6547311865 Merge "Simplify CursorAnchorInfoCompatWrapper" 2014-10-09 08:13:50 +00:00
Jean Chalard 437fcbaa9f [ML20.1] Move getRichInputMethodSubtype to additional features
Bug: 11230254
Change-Id: I9bc19db5f101eeb6841394fe3637f271c93cbfa7
2014-10-09 16:35:15 +09:00
Jatin Matani db1b736446 Changes related Sync Engine library that communicates to cloud server
This change updates some of the code that the library uses
to communicate with the cloud server
Specifically :
- Update BlockingHttpClient to use template ResponseProcessor
- Update HttpUrlConnectionBuilder to setAuthToken for HttpUrlConnection

Bug: 17464069
Bug: 17464805

Change-Id: I7d7b58dff594b920162f799d102e8582ff9fe6a4
2014-10-09 00:01:32 -07:00
Yohei Yukawa dac49f9f6d Simplify CursorAnchorInfoCompatWrapper
With this CL, we will use CursorAnchorInfoCompatWrapper just to
avoid unexpected NoClassDefFoundError due to the direct
dependency CursorAnchorInfo class, which is available only on
API level 21 and later.

Change-Id: I254ff83f1ca41daa21d0666b5824af22ba529022
2014-10-09 15:54:34 +09:00
Keisuke Kuroyanagi d7a51c242b Extend jni method to dump ngram entries.
Bug: 14425059
Change-Id: Ib03b58525fae12f254b45630bee31ecbdde227b1
2014-10-09 15:26:10 +09:00
Jean Chalard 176e6e22cf Merge "[ML19] Actually switch the language when appropriate" 2014-10-09 05:12:01 +00:00
Jean Chalard 81a5a10476 [ML19] Actually switch the language when appropriate
That is, when auto-correcting or when manually picking.
This is not great, but it's a good starting point.

Bug: 11230254
Change-Id: I07627f48e2de1c28053d6572c7c72625808ec79c
2014-10-09 13:13:25 +09:00
Tadashi G. Takaoka 15480481be Add keyboard shadow
This CL sets 8dp elevation ot input view in order to cast a shadow
onto underlying application.

Bug: 16210054
Change-Id: I7779c63612fc88e24dde65de3e4e7a45b9d1762f
2014-10-09 12:39:15 +09:00
Jatin Matani 3c6ac75c48 Merge "Fix messaging for sync now feature, when no account is selected" 2014-10-08 23:40:27 +00:00
Jatin Matani f66a6a3bb0 Fix messaging for sync now feature, when no account is selected
Change-Id: I5e81b7a1eed9c2177ad3ddfa6c96c2b85c433766
2014-10-08 15:26:39 -07:00
Tadashi G. Takaoka 9bda19891c Merge "Stop dimming main keyboard while showing more keys keyboard" 2014-10-08 13:13:26 +00:00
Jean Chalard 15335d7526 Merge "[ML18] Make WordComposer#getAutoCorrection a word info" 2014-10-08 13:04:25 +00:00
Jean Chalard 176ad53c6f [ML18] Make WordComposer#getAutoCorrection a word info
Bug: 11230254
Change-Id: I6ad2e7f89862fbfe7af5502961643320c782347f
2014-10-08 21:46:13 +09:00
Ken Wakasa 5b39af37c0 Fix unit test failure
Change-Id: I5a28c6775385ba3b0b7d86c85064fd28f3cbb353
2014-10-08 17:27:28 +09:00
Tadashi G. Takaoka 6085839627 Stop dimming main keyboard while showing more keys keyboard
Bug: 17910364
Change-Id: Ibe76ee86a43c5939f48e45506c985b3f289eac7a
2014-10-08 16:59:21 +09:00
Jatin Matani 847735fdfa Merge "Skeleton code for user dictionary sync" 2014-10-08 02:09:50 +00:00
Jatin Matani 3fbe459fa7 Make SuggestionWordInfo non-final for testabilty
Needed for ag/563043
Bug:17731683
Change-Id: I4d19e512a311547204f7e8d7885fc886757a18b7
2014-10-07 18:43:13 -07:00
Jatin Matani 734733d8ad Skeleton code for user dictionary sync
Bug:17464069
Change-Id: If683b80e882c07fba576959346ae74cd445dd83e
2014-10-07 12:30:12 -07:00
Yohei Yukawa 89d7965e76 Merge "Fix NoClassDefFoundError due to CursorAnchorInfo in K" 2014-10-07 10:30:36 +00:00
Yohei Yukawa 883bfd2c0b Fix NoClassDefFoundError due to CursorAnchorInfo in K
Check API level before touching CursorAnchorInfo that is only
available in L and later.

BUG: 17891202
Change-Id: I6e8d2e3f071bd78bed8c1d24ba2b97207dea3044
2014-10-07 19:19:20 +09:00
Jean Chalard be4e1539cb [ML17] Add a method to switch the most probable language
Also directly hold a ref to it. It's simpler for now, though
we may want to remove it completely later to have a flat,
purely weight-based system with no preference.
Also split weights between gesturing and typing.

Bug: 11230254
Change-Id: Ica15964a193ae6e7f14c85a9a3ed806130fa7efb
2014-10-07 19:09:49 +09:00
Jean Chalard 38ec825ef8 [ML16] Remove DictionaryFacilitator.getLocale()
Bug: 11230254
Change-Id: Ife99df42bc145fbd2d5c3128330bc0f88b104de9
2014-10-07 16:44:26 +09:00
Jean Chalard ea07734956 [ML15] First step in removing DictionaryFacilitator.getLocale
Bug: 11230254
Change-Id: Ied010ec6f1024080e8a499f682d2fc1780e82ef7
2014-10-07 16:06:35 +09:00
Keisuke Kuroyanagi 3ead4d7f8a Merge "Quit having obsolete options for ime-simulator." 2014-10-07 02:03:59 +00:00
Adrian Velicu 639837f85d Merge "Postponing memory deallocation after onFinishInputView" 2014-10-06 23:45:40 +00:00
Tadashi G. Takaoka 6fb586a527 Fix missing prediction words on contextual strip
Bug: 17874801
Change-Id: Iaba935a6b2548376f10a0ecd80f07ea7ada6c60a
2014-10-07 00:06:53 +09:00
Yohei Yukawa db6c32778e Merge "Add a utility method to SuggestionSpanUtils" 2014-10-06 15:03:20 +00:00
Adrian Velicu 7b8f317050 Postponing memory deallocation after onFinishInputView
Bug: 17559789
Change-Id: I1d4b1524028164d27ec4eadd3960b567148f2b84
2014-10-06 23:14:48 +09:00
Jean Chalard fcc4cbf6f1 Merge "[ML14] Forward the locale list to relevant places, again" 2014-10-06 13:32:32 +00:00