Commit Graph

30734 Commits (56e4848eadfa217651906ab5b88ed21602a520bc)

Author SHA1 Message Date
Baligh Uddin 584e9c9c22 am 5d33c766: (-s ours) am 0f591c64: (-s ours) am beaa8a47: (-s ours) am 5df8b427: (-s ours) am aa8f178b: (-s ours) am cd2a75b5: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit '5d33c7663eada923d164947c269bef339b6caa14':
  Import translations. DO NOT MERGE
2014-02-21 17:18:01 +00:00
Baligh Uddin 9bfa64945f am a9ab2a62: (-s ours) am b4b0e65e: (-s ours) am b76ca05f: (-s ours) am fb52c953: (-s ours) am 4b9936d3: (-s ours) am 801517fe: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'a9ab2a62dfad586b4ea307321b6330bdc468497b':
  Import translations. DO NOT MERGE
2014-02-21 17:17:59 +00:00
Baligh Uddin 269ab5e557 am 17069e39: (-s ours) am 40193c9e: (-s ours) am 5c2e47ab: (-s ours) am 786190c2: (-s ours) am e1c66c8d: (-s ours) am 80dc4248: (-s ours) Import translations. DO NOT MERGE
* commit '17069e39904d3d5f9cb2210a7c023416fdcdfeb0':
  Import translations. DO NOT MERGE
2014-02-21 17:17:57 +00:00
Baligh Uddin 5d33c7663e am 0f591c64: (-s ours) am beaa8a47: (-s ours) am 5df8b427: (-s ours) am aa8f178b: (-s ours) am cd2a75b5: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit '0f591c64ff895363f5b02521cd02648463d1062a':
  Import translations. DO NOT MERGE
2014-02-21 17:05:59 +00:00
Baligh Uddin a9ab2a62df am b4b0e65e: (-s ours) am b76ca05f: (-s ours) am fb52c953: (-s ours) am 4b9936d3: (-s ours) am 801517fe: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'b4b0e65ed8d4bfcf88a14e66b21973e447669c4d':
  Import translations. DO NOT MERGE
2014-02-21 17:05:58 +00:00
Baligh Uddin 17069e3990 am 40193c9e: (-s ours) am 5c2e47ab: (-s ours) am 786190c2: (-s ours) am e1c66c8d: (-s ours) am 80dc4248: (-s ours) Import translations. DO NOT MERGE
* commit '40193c9ee568bb52c30a1ebd96db77bd84a86292':
  Import translations. DO NOT MERGE
2014-02-21 17:05:57 +00:00
Baligh Uddin 0f591c64ff am beaa8a47: (-s ours) am 5df8b427: (-s ours) am aa8f178b: (-s ours) am cd2a75b5: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'beaa8a473ff0f9f2f2d93d25a34e880007062f53':
  Import translations. DO NOT MERGE
2014-02-21 17:03:23 +00:00
Baligh Uddin b4b0e65ed8 am b76ca05f: (-s ours) am fb52c953: (-s ours) am 4b9936d3: (-s ours) am 801517fe: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'b76ca05fef52f48db02de46c4ef15348e554fff4':
  Import translations. DO NOT MERGE
2014-02-21 17:03:22 +00:00
Baligh Uddin 40193c9ee5 am 5c2e47ab: (-s ours) am 786190c2: (-s ours) am e1c66c8d: (-s ours) am 80dc4248: (-s ours) Import translations. DO NOT MERGE
* commit '5c2e47abc014a6f20f2074b970c0288f404b8ef4':
  Import translations. DO NOT MERGE
2014-02-21 17:03:21 +00:00
Baligh Uddin beaa8a473f am 5df8b427: (-s ours) am aa8f178b: (-s ours) am cd2a75b5: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit '5df8b42709662b0e599019e4fd17c4e153ff6b47':
  Import translations. DO NOT MERGE
2014-02-21 16:58:00 +00:00
Baligh Uddin b76ca05fef am fb52c953: (-s ours) am 4b9936d3: (-s ours) am 801517fe: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'fb52c953ac98cd7751a6d49cedf99eefcf86e70f':
  Import translations. DO NOT MERGE
2014-02-21 16:57:59 +00:00
Baligh Uddin 5c2e47abc0 am 786190c2: (-s ours) am e1c66c8d: (-s ours) am 80dc4248: (-s ours) Import translations. DO NOT MERGE
* commit '786190c2237a38ca997ef0966cabeb8c271455d2':
  Import translations. DO NOT MERGE
2014-02-21 16:57:57 +00:00
Baligh Uddin 5df8b42709 am aa8f178b: (-s ours) am cd2a75b5: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'aa8f178b4a8c557d553a7bfd27a22439b0465756':
  Import translations. DO NOT MERGE
2014-02-21 16:52:51 +00:00
Baligh Uddin fb52c953ac am 4b9936d3: (-s ours) am 801517fe: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit '4b9936d302679369d6ec912bfd248366afafbe85':
  Import translations. DO NOT MERGE
2014-02-21 16:52:50 +00:00
Baligh Uddin 786190c223 am e1c66c8d: (-s ours) am 80dc4248: (-s ours) Import translations. DO NOT MERGE
* commit 'e1c66c8ddb26ffe5361949b9e6b82f802bb6a671':
  Import translations. DO NOT MERGE
2014-02-21 16:52:49 +00:00
Baligh Uddin aa8f178b4a am cd2a75b5: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit 'cd2a75b5c47a71f665e8f2020ead8b98dd418373':
  Import translations. DO NOT MERGE
2014-02-21 16:46:34 +00:00
Baligh Uddin 4b9936d302 am 801517fe: (-s ours) Merge "Import translations. DO NOT MERGE" into klp-dev
* commit '801517fe752f5352023bf4da8f3bb22727529963':
  Import translations. DO NOT MERGE
2014-02-21 16:46:32 +00:00
Baligh Uddin e1c66c8ddb am 80dc4248: (-s ours) Import translations. DO NOT MERGE
* commit '80dc4248546755f6a117ba28e14eeab05d7e1596':
  Import translations. DO NOT MERGE
2014-02-21 16:46:30 +00:00
Baligh Uddin dd1d4ba95f Merge "Import translations. DO NOT MERGE" 2014-02-21 16:42:13 +00:00
Baligh Uddin cd2a75b5c4 Merge "Import translations. DO NOT MERGE" into klp-dev 2014-02-21 16:42:07 +00:00
Baligh Uddin 801517fe75 Merge "Import translations. DO NOT MERGE" into klp-dev 2014-02-21 16:42:00 +00:00
Baligh Uddin a761bb3208 Merge "Import translations. DO NOT MERGE" 2014-02-21 16:41:50 +00:00
Jean Chalard 296adf5710 Merge "Change a heuristic and add a log." 2014-02-21 11:58:16 +00:00
Tadashi G. Takaoka 1269ae3144 Merge "Change make-keyboard-text -java option to point LatinIME/java directory" 2014-02-21 11:54:39 +00:00
Tadashi G. Takaoka 8e2951f299 Merge "Fix punctuation test for tablet" 2014-02-21 11:54:28 +00:00
Keisuke Kuroyanagi bb6b978a19 Merge "Fix: file descriptor leaking." 2014-02-21 11:37:09 +00:00
Jean Chalard bf075b21a1 Merge "Don't trim newer inputpointers with old data" 2014-02-21 11:19:04 +00:00
Tadashi G. Takaoka 5eb6ea9f27 Change make-keyboard-text -java option to point LatinIME/java directory
Change-Id: I812713da5918049c0e504e48bd0693df2f7bf46d
2014-02-21 19:24:24 +09:00
Baligh Uddin 522d1575da Import translations. DO NOT MERGE
Change-Id: If26d287c68a6fed1d5a8ecf6566ccd5cdfb99104
Auto-generated-cl: translation import
2014-02-21 02:20:21 -08:00
Baligh Uddin 80dc424854 Import translations. DO NOT MERGE
Change-Id: I2e9650644e214864cf8b6126d635fbf6790a7652
Auto-generated-cl: translation import
2014-02-21 02:19:13 -08:00
Baligh Uddin 6b76a61223 Import translations. DO NOT MERGE
Change-Id: I70333e4c46801d5ff8fdbeaabb5b09642146b60e
Auto-generated-cl: translation import
2014-02-21 02:16:01 -08:00
Baligh Uddin 89a82404da Import translations. DO NOT MERGE
Change-Id: I36ae3ddd02a99ec044e1fd0fdf88d8e7726bdd17
Auto-generated-cl: translation import
2014-02-21 02:14:33 -08:00
Baligh Uddin 6ddefc567e Import translations. DO NOT MERGE
Change-Id: Id288919148957318b18962b09e61ebe76a10c2b7
Auto-generated-cl: translation import
2014-02-21 02:13:34 -08:00
Keisuke Kuroyanagi ad508d029f Merge "Remove corrupted ver4 dictionaries." 2014-02-21 09:03:19 +00:00
Keisuke Kuroyanagi 9cfa8417da Merge "Add boundary check for ver2 dict reading." 2014-02-21 09:03:12 +00:00
Tadashi G. Takaoka d28a58c25d Fix punctuation test for tablet
It seems that some test devices are tablet and some are phone. The
unit test should aware of which device the test is running.

Change-Id: I8651a540993de29aa1cd9f40919dffe7a8df9512
2014-02-21 17:50:07 +09:00
Keisuke Kuroyanagi d24a99cff6 Fix: file descriptor leaking.
File descriptors will be closed in
BinaryDictionary.finalize(); but, this leads to unit test fails.

Bug: 13066902
Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
2014-02-21 17:25:34 +09:00
Keisuke Kuroyanagi 239256b156 Merge "Add an auto-correction by user history test." 2014-02-21 07:59:05 +00:00
Jean Chalard 2a5ec00301 Don't trim newer inputpointers with old data
We already have a mechanism to avoid this crash, but it wasn't
used every time it needed to. It's possible that ending a batch
input and starting a batch input happen while suggestions
are being pulled out, which would result in pointers that have
been reset being passed for trimming.
Just increasing the sequence number should get rid of the
problem.

Bug: 12178124
Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
2014-02-21 16:43:11 +09:00
Tadashi G. Takaoka d73044a249 Add ImportantNoticeDialog
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
2014-02-21 16:36:15 +09:00
Keisuke Kuroyanagi d934fb43ad Remove corrupted ver4 dictionaries.
Bug: 12916055
Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
2014-02-21 15:09:37 +09:00
Keisuke Kuroyanagi be81b75dec Add boundary check for ver2 dict reading.
Bug: 12916055
Change-Id: I78ad1f98a5401f920dcfc3379aa431eb2311ae02
2014-02-21 13:26:01 +09:00
Keisuke Kuroyanagi 4cc582f3ba Add an auto-correction by user history test.
Bug: 11122480
Change-Id: I830bb3399f9839a80c6d86fbf582299bce424871
2014-02-21 13:12:26 +09:00
Tadashi G. Takaoka fe39d576dc Support versioned important notice
This change must be checked in together with If38a754d00.

Bug: 10587358
Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
2014-02-21 09:54:08 +09:00
Jean Chalard 3b4c1d3056 Change a heuristic and add a log.
The heuristic in RichInputConnection makes little sense
when textLength > mExpectedSelStart but we have
more than 1024 characters of text. If there are that many,
it's about 100% sure that 1024 is not the correct cursor
position. With no good guess, we'll just continue trusting
the app, even though we know it's lying : at least it will
make the problem visible to the app author.

Also, there have been a lot of confusion about initialSelStart
and initialSelEnd. The keyboard should log them so that
it helps us and editor authors debug more easily these
common problems.

Issue #65170 in AOSP and
Bug: 12772035
Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
2014-02-20 23:49:20 +09:00
Jean Chalard 1b3a142cac Merge "Fix a bug where suggestions would not be updated." 2014-02-20 14:46:35 +00:00
Jean Chalard 6f50c95887 Fix a bug where suggestions would not be updated.
Also fix a small cosmetic bug where the suggestion strip
would flash.

Bug: 12951777
Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
2014-02-20 23:32:04 +09:00
Jean Chalard a118d19f6c Merge "Don't distrust the cursor pos so much as to bug on IPC delay" 2014-02-20 14:22:48 +00:00
Jean Chalard 3c84eb8822 Don't distrust the cursor pos so much as to bug on IPC delay
When the cursor is moved by the user, the RichInputConnection
is told about it. However, to work around a framework bug, it
also looks at how many characters are in the buffer before the
cursor, and if that's more than the value it's been passed, it
deduces that's a framework bug and there are at least as many
characters as seen before the cursor, so it puts the expected
cursor position there.

When you move the cursor, TextView calls onUpdateSelection,
and when you move it fast, you'll get rapid-fire calls to
onUpdateSelection. This is fine, the RIC is equipped to
deal with that.

However, these calls take some time to make it to the IME. In
this instance, when the first call gets through and the IME
calls TextView (synchronously) for text before the cursor, the
cursor has already moved in the app, and TextView returns more
characters than the cursor position was declared to be in this
instance, so the RIC sets that as the expected cursor position.
Sure enough, a split second later, the second call to
onUpdateSelection arrives, with the new cursor position set
where the RIC had found it too early. The RIC takes that as an
"expected" cursor move, and the input does not get reset.

Luckily, we have a way out. As far as we know, the framework bug
only manifests itself upon rotation, which means we should only
have to adjust for it in onStartInputView. Doing it in
onUpdateSelection is too zealous (and probably too distrustful of
the app to send the correct cursor positions).

So we should just take care of the rotation case (by calling
tryFixLyingCursorPosition in onStartInputView) and remove the
compensating code in resetCachesUponCursorMoves.

Bug: 12982502
Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
2014-02-20 23:13:14 +09:00
Keisuke Kuroyanagi e03e4257f1 Merge "Add test only methods to test personalized dicts." 2014-02-20 13:25:59 +00:00