nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30857 commits 1 branch 0 tags 363 MiB
Commit graph

30857 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jean Chalard
d05ea8bd82 Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." 2013-12-27 08:06:48 +00:00
Jean Chalard
e099325f99 am af26a441: Merge "[IL47] Inline getSuggestedWordsGestureLocked" 
* commit 'af26a44102c004844546cb8d049aa43b629f3598':
  [IL47] Inline getSuggestedWordsGestureLocked
 2013-12-27 00:06:03 -08:00
Jean Chalard
af26a44102 Merge "[IL47] Inline getSuggestedWordsGestureLocked" 2013-12-27 08:04:51 +00:00
Jean Chalard
ab14bb51c8 am 51e79fb4: Merge "[IL46] Remove a useless message passing." 
* commit '51e79fb4b2025985f7cc29f43357d60c6889e3ff':
  [IL46] Remove a useless message passing.
 2013-12-26 23:59:26 -08:00
Jean Chalard
d2c0bed052 am 2fc1cc09: Merge "[IL45] Remove lingering messages" 
* commit '2fc1cc099f27442c9a3f93f8a49dd333c83a2abe':
  [IL45] Remove lingering messages
 2013-12-26 23:59:24 -08:00
Jean Chalard
51e79fb4b2 Merge "[IL46] Remove a useless message passing." 2013-12-27 07:56:56 +00:00
Jean Chalard
2fc1cc099f Merge "[IL45] Remove lingering messages" 2013-12-27 07:56:44 +00:00
Jean Chalard
c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic. 
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
 2013-12-27 16:50:08 +09:00
Jean Chalard
4a144b9b4d [IL47] Inline getSuggestedWordsGestureLocked 
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.

Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
 2013-12-27 16:50:08 +09:00
Jean Chalard
71a3e96382 [IL46] Remove a useless message passing. 
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords

The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.

Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
 2013-12-27 16:50:06 +09:00
Jean Chalard
3735857dc9 am 0d212235: Merge "[IL44] Some factorization" 
* commit '0d212235211e5860242baf4c77a25ae2166b5498':
  [IL44] Some factorization
 2013-12-26 23:00:39 -08:00
Jean Chalard
0d21223521 Merge "[IL44] Some factorization" 2013-12-27 06:58:12 +00:00
Jean Chalard
31ff2a4335 [IL45] Remove lingering messages 
Bug: 8636060
And possibly bug: 12085864

Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
 2013-12-27 15:34:30 +09:00
Jean Chalard
69e7a0d24d [IL44] Some factorization 
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
 2013-12-27 15:34:26 +09:00
Keisuke Kuroyanagi
5d5537b2de am c197b9ed: Merge "Make setAdditionalDictionaries private." 
* commit 'c197b9ed902f6ea8f14764bbe04c9f1541bfb8f5':
  Make setAdditionalDictionaries private.
 2013-12-26 22:24:45 -08:00
Keisuke Kuroyanagi
c197b9ed90 Merge "Make setAdditionalDictionaries private." 2013-12-27 06:22:18 +00:00
Keisuke Kuroyanagi
913173131e am 86da47e8: Fix possible NPE in FileUtils. 
* commit '86da47e8d72f275b7f6e111930dfe205cb34423f':
  Fix possible NPE in FileUtils.
 2013-12-26 22:07:20 -08:00
Keisuke Kuroyanagi
86da47e8d7 Fix possible NPE in FileUtils. 
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
 2013-12-27 14:58:38 +09:00
Keisuke Kuroyanagi
abc3d0eb56 Make setAdditionalDictionaries private. 
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
 2013-12-27 14:49:32 +09:00
Jean Chalard
99dfe3f273 am 6bca9ac4: Fix a bug where predictions would not pop upon manual pick 
* commit '6bca9ac43d0db9a83b02577783cc609ecf13e3f4':
  Fix a bug where predictions would not pop upon manual pick
 2013-12-26 06:39:28 -08:00
Jean Chalard
6bca9ac43d Fix a bug where predictions would not pop upon manual pick 
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
 2013-12-26 23:19:29 +09:00
Jean Chalard
b9c96ca75a am 33b2aaaf: Merge "Fix a code path that looks ridiculous" 
* commit '33b2aaafc25acbfae1a670435ceb7cd7fe624a1c':
  Fix a code path that looks ridiculous
 2013-12-26 05:43:23 -08:00
Jean Chalard
33b2aaafc2 Merge "Fix a code path that looks ridiculous" 2013-12-26 13:39:21 +00:00
Jean Chalard
f294ed3308 Fix a code path that looks ridiculous 
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
 2013-12-26 22:28:16 +09:00
Jean Chalard
06b7e9e8f5 am f441047f: [IL43] Small cleanup 
* commit 'f441047fadd6bc60b05274ca4a7195e4ff4b680d':
  [IL43] Small cleanup
 2013-12-26 05:17:52 -08:00
Jean Chalard
654fe9724d am c28f0288: [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync 
* commit 'c28f02880c307c1bf7c11a755765ea6354150bd4':
  [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
 2013-12-26 05:17:48 -08:00
Jean Chalard
f441047fad [IL43] Small cleanup 
All calls are already passing this

Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
 2013-12-26 22:12:24 +09:00
Jean Chalard
c28f02880c [IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync 
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
 2013-12-26 22:12:22 +09:00
Jean Chalard
c3f4239ed7 am 70433efc: [IL41] Remove a useless call and trampoline. 
* commit '70433efc41970b4dc475b7e446388430aaf801b9':
  [IL41] Remove a useless call and trampoline.
 2013-12-26 05:11:23 -08:00
Jean Chalard
70433efc41 [IL41] Remove a useless call and trampoline. 
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.

Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
 2013-12-26 21:58:41 +09:00
Keisuke Kuroyanagi
9a25b2374d am be147f1f: Remove DictionaryFacilitatorForSuggest.getMainDictionary(). 
* commit 'be147f1fdcfb5d192f64eb97e508b43da1fd9509':
  Remove DictionaryFacilitatorForSuggest.getMainDictionary().
 2013-12-26 03:59:06 -08:00
Keisuke Kuroyanagi
ce3fbd8486 am a3744827: Extract dict operations from Suggest to a new class. 
* commit 'a374482719ef9f38395e7e39884433cc72e9cdb7':
  Extract dict operations from Suggest to a new class.
 2013-12-26 03:55:47 -08:00
Keisuke Kuroyanagi
be147f1fdc Remove DictionaryFacilitatorForSuggest.getMainDictionary(). 
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
 2013-12-26 20:48:19 +09:00
Keisuke Kuroyanagi
a374482719 Extract dict operations from Suggest to a new class. 
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
 2013-12-26 20:48:19 +09:00
Jean Chalard
1212122d92 am 5c45ff12: [IL39] Change a test. 
* commit '5c45ff12140c801448d0bef1991d803edc674fb8':
  [IL39] Change a test.
 2013-12-26 03:48:16 -08:00
Jean Chalard
94982318e9 am 98140faa: [IL38] Fix a wrong double call 
* commit '98140faac34ad2250c38c5f651788308adbedb2d':
  [IL38] Fix a wrong double call
 2013-12-26 03:00:05 -08:00
Jean Chalard
5c45ff1214 [IL39] Change a test. 
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.

Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
 2013-12-26 18:44:17 +09:00
Jean Chalard
98140faac3 [IL38] Fix a wrong double call 
This only gives bad results if a gesture results in only one suggestion.

Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
 2013-12-26 18:43:47 +09:00
Keisuke Kuroyanagi
361cbcfc99 am d77ad190: Fix NPE in a unit test. 
* commit 'd77ad1902be50def82596d9c6c84c5fc988444aa':
  Fix NPE in a unit test.
 2013-12-26 00:09:59 -08:00
Keisuke Kuroyanagi
d77ad1902b Fix NPE in a unit test. 
Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
 2013-12-26 17:01:48 +09:00
Keisuke Kuroyanagi
1aacc4d60a am 65e3ae6f: Merge "Remove useless method call for spell checker." 
* commit '65e3ae6f153a136902eaaf4da217496802c1daa1':
  Remove useless method call for spell checker.
 2013-12-25 22:45:22 -08:00
Keisuke Kuroyanagi
65e3ae6f15 Merge "Remove useless method call for spell checker." 2013-12-26 06:42:51 +00:00
Tadashi G. Takaoka
a53fdb6aa9 am 3fbcf485: Merge "Add BatchInputArbiter" 
* commit '3fbcf48591e2803dfe5e8540bed2f992c3c43925':
  Add BatchInputArbiter
 2013-12-25 21:51:12 -08:00
Keisuke Kuroyanagi
7987afbea4 Remove useless method call for spell checker. 
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
 2013-12-26 14:51:05 +09:00
Tadashi G. Takaoka
3fbcf48591 Merge "Add BatchInputArbiter" 2013-12-26 05:50:07 +00:00
Jean Chalard
69d8055bb6 am 30a72da4: [IL37] Small simplification 
* commit '30a72da42c479adb4cedff5d7a40846a3103ac9b':
  [IL37] Small simplification
 2013-12-25 21:22:52 -08:00
Jean Chalard
e86dc236f5 am c08119e5: [IL36] Inline setAutoCorrection 
* commit 'c08119e5c1f302cbc35b2c97d948e691ad8e8a59':
  [IL36] Inline setAutoCorrection
 2013-12-25 21:19:33 -08:00
Tadashi G. Takaoka
4a4b6d42a7 Add BatchInputArbiter 
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.

This change must be checked in together with Ia7db8f4fb7.

Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
 2013-12-26 14:09:57 +09:00
Jean Chalard
30a72da42c [IL37] Small simplification 
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
 2013-12-26 13:51:09 +09:00
Jean Chalard
c08119e5c1 [IL36] Inline setAutoCorrection 
There are far too many one-use methods.

Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
 2013-12-26 13:18:36 +09:00