Commit Graph

1256 Commits (4d355989bd972ba792ba546a55c67e5b6fc2527a)

Author SHA1 Message Date
Tadashi G. Takaoka 697bf585f8 Update suggestions strip text color
Bug: 5287964
Change-Id: Ic40bb656873f41bb6d65427f02399464e831aab2
2011-09-13 12:54:59 +09:00
Jean Chalard f5ef30dfc6 Have the spell checker honor case
Bug: 5281103
Change-Id: I415c84dbb55f1eeb5deb9f248b4056881982ee13
2011-09-12 12:25:25 +09:00
satok 53bbf4da5a Merge "Remove the exception in SubtypeSwitcher" 2011-09-09 02:49:18 -07:00
satok 1ecf0fb5d7 Remove the exception in SubtypeSwitcher
Bug: 5261455

Change-Id: Idb070702418caeb6cb975849d71b39952ac4afab
2011-09-09 18:44:48 +09:00
Jean Chalard a40aba0022 Merge "Fix an NPE" 2011-09-09 02:18:11 -07:00
Jean Chalard 5955cfdaea Fix an NPE
I think only the monkey can realistically stumble on this one,
but still.

Bug: 5276917
Change-Id: I0d9f76e4786973d3695fcd46127f0bed46621c33
2011-09-09 18:08:53 +09:00
Tadashi G. Takaoka f01ba10c8f Merge "Cancel more suggestions when its outside is touched" 2011-09-09 00:49:15 -07:00
Tadashi G. Takaoka 530b4176c2 Merge "Fix potential ArrayIndexOutOfBoundsException" 2011-09-08 23:24:20 -07:00
Tadashi G. Takaoka 4a9be115f2 Cancel more suggestions when its outside is touched
Bug: 5241105
Change-Id: Ic28afaf998dabd3c5529286a3e60400d733d3d82
2011-09-09 14:21:43 +09:00
Tadashi G. Takaoka 8332fd0b81 Fix potential ArrayIndexOutOfBoundsException
Change-Id: I5dad81fb274cbbcf2c4f106825eecf8e4903461c
2011-09-09 09:42:22 +09:00
Tadashi G. Takaoka 2cb36637f4 Back button to dismiss the more suggestions
Bug: 5275063
Change-Id: If31e9a25d827f44c8d4ff455a780ec2a6d2d9bef
2011-09-09 09:33:35 +09:00
Tadashi G. Takaoka a08a7e99b4 Merge "Add visual dividers to more suggestions panel" 2011-09-08 07:25:17 -07:00
Tadashi G. Takaoka 30bd8cb2da Add visual dividers to more suggestions panel
Bug: 5275003
Change-Id: I9464db71388a40ea768984b4cf06c8da05bfa26c
2011-09-08 23:05:55 +09:00
Jean Chalard af3b56c887 Fix a bug where the wrong suggestion score would matter.
Also introduce a few debug prints.

Bug: 5240463
Change-Id: Iea2fffa3be9d7bd69da751ece9e67e94e9819ee1
2011-09-08 21:17:24 +09:00
Ken Wakasa 293db0873f Get rid of the double quote from the suggestion strip
bug: 5271209
Change-Id: I1823eaac07e184092bdf2a5d607fa08ff680fca5
2011-09-08 11:46:09 +09:00
Tadashi G. Takaoka 2be872555c Use full screen mode on landscape/phone device
Bug: 5262767
Change-Id: I721c18522c972ced9f359f2e5208572d54a4b7a1
2011-09-08 11:02:55 +09:00
Tadashi G. Takaoka ed3758e33c Merge "Tune the threshold of fullscreen mode from 2.5in to 500dip" 2011-09-07 01:08:51 -07:00
Tadashi G. Takaoka f80b6a0699 Tune the threshold of fullscreen mode from 2.5in to 500dip
Bug: 5262767
Change-Id: Ie418ab766951a568d0f40822d8e8d719582749ba
2011-09-07 16:37:50 +09:00
satok 6d468c513f Fix NPE in settings
Bug: 5246032
Change-Id: I452dab9bf863fb8cba142467f338088ee8b30283
2011-09-07 12:36:07 +09:00
Tadashi G. Takaoka 50e1073e11 More suggestions view can be modal
Bug: 5241105
Change-Id: Ib430ee129b9f3cad0bdb1ae083b1068c51a5f2ea
2011-09-06 19:18:40 +09:00
Tadashi G. Takaoka 4269a7cebd Add gap between suggestions strip and more suggestions
Bug: 5260292
Change-Id: Iba792ebe0767f5117f259bcb73ac0bff778b166e
2011-09-06 18:33:01 +09:00
Tadashi G. Takaoka 8ac6d505b7 More processTouchEvent from LatinKeyboardView to PointerTracker
Bug: 5241105
Change-Id: I8a5d15f43e2c9f294e78127eda68b0f85da5ad15
2011-09-06 15:57:15 +09:00
Tadashi G. Takaoka 9676038b6e Introduce maxMoreSuggestionsRow and minMoreSuggetionsWidth attributes to SuggestionsView
Bug: 5257594
Change-Id: Id52c841b72e38eb9034a1a7f26bcf3d4d81ad216
2011-09-05 18:59:37 +09:00
Tadashi G. Takaoka 1d8ec1cb9f Merge "Rename suggestionsPaneViewStyle to moreSuggestionsViewStyle" 2011-09-05 01:39:33 -07:00
Tadashi G. Takaoka 0e7bd388d2 Merge "Get rid of LinearLayoutCompatUtils" 2011-09-05 01:22:15 -07:00
Tadashi G. Takaoka 0e2fa66144 Rename suggestionsPaneViewStyle to moreSuggestionsViewStyle
Change-Id: I30873ad870c728e28a044baf9946b4461ab03575
2011-09-05 16:48:56 +09:00
Tadashi G. Takaoka c412309b7a Get rid of LinearLayoutCompatUtils
Change-Id: If0f63eaeb4539c0e03ef20190d2f9211a176babc
2011-09-05 16:15:28 +09:00
Jean Chalard 59b501a050 Only set LOOKS_LIKE_TYPO if the max score meets a threshold
Bug: 5240463
Change-Id: I51e85edae57789d638aa1e12b82e6a75c49d33c7
2011-09-05 12:31:43 +09:00
Tadashi G. Takaoka 787bac0603 Merge "Use separate View for key preview backing" 2011-09-02 12:59:31 -07:00
Tadashi G. Takaoka abb0c77af1 Use separate View for key preview backing
Bug: 5246982
Change-Id: Icec4281cb01771909fcece36647ee42ba179118c
2011-09-03 01:36:26 +09:00
satok e197542a57 Merge "Add logs" 2011-09-02 04:21:07 -07:00
satok 8e5d12af9f Add logs
Change-Id: I640186c8be8013841b542e8cefa5f033eb7afc32
2011-09-02 19:55:09 +09:00
Tadashi G. Takaoka 9734ecbf46 Squash MiniKeyboardKeyDetector and SuggestionsPaneKeyDetector into one
Bug: 5241105
Change-Id: I4c310373fb8b2426fb46205fa17a49a8346f8244
2011-09-02 17:58:39 +09:00
Tadashi G. Takaoka d3e50a2acf Squash SuggestionsStripParams into SuggestionsViewParams
Bug: 5246982
Change-Id: Idc2563cb0175aabc4282f9fd45eefaa129ed4961
2011-09-02 16:53:38 +09:00
Jean Chalard 5bb7a64fe2 Merge "Fix an NPE in settings" 2011-09-01 23:42:43 -07:00
Jean Chalard ad56a9ac51 Fix an NPE in settings
Change-Id: I264c001a9cc28f864ad024fcf51fb42e9c203d3f
2011-09-02 15:35:23 +09:00
Jean Chalard 66a5884ad8 Merge "Add an option to prevent insertion of suggestion spans" 2011-09-01 22:57:39 -07:00
Jean Chalard 1531528bfe Add an option to prevent insertion of suggestion spans
This is to help debug of
Bug: 5250788

Change-Id: I961321aff3776c4912eaf7a1fa4de0c01d715f24
2011-09-02 14:43:13 +09:00
Tadashi G. Takaoka 1b087064c0 Dim keyboard when more suggestions are shown
Bug: 5241009
Change-Id: Ia42bcfc34dddf93d35f9cea8a4f0efead6ce3a6a
2011-09-01 18:48:19 +09:00
Tadashi G. Takaoka 913e2aeef2 Rename CandidateView to SuggestionsView
Change-Id: I6480cdf025f065130e1969899b259a243e7a11be
2011-09-01 15:41:34 +09:00
Jean Chalard b17300e2f0 Merge "Fix a bug where autotext would occasionally not work" 2011-08-31 22:42:11 -07:00
Tadashi G. Takaoka 537e3d3696 Merge "Remove unused suggestions pane code" 2011-08-31 22:35:12 -07:00
Tadashi G. Takaoka 3a566c48b0 Remove unused suggestions pane code
This is a followup for Ie1d69131.

Bug: 5023981
Change-Id: I42ec596af40cb7dcdd84b96ba5bff9ef1fb5dc92
2011-09-01 14:28:59 +09:00
Tadashi G. Takaoka d81479a340 Implement KeyboardLocale InputMethodSubtype extra key
The locale is specified by KeyboardLocale extra key in method.xml,
LatinIME will use the specified locale for keyboard layout.

Bug: 5238658
Change-Id: I8e6cb66c73a7ac1bf611d9910b42fa9cff38eba0
2011-09-01 14:05:01 +09:00
Jean Chalard 358e1327d8 Fix a bug where autotext would occasionally not work
Autotext correction would check whether the first suggestion
so far was the same as what Autotext would return, and if it
was indeed the same, would not send its result as
autocorrect. However, the first suggestion is not guaranteed
to have a high enough score to trigger autocorrection, and
there would be cases where a word in autotext would not get
autocorrected because the word came out of bigram
suggestions. These occurrences would be extremely rare, as
they would require concomitant insert between autotext for
one char and bigram suggestion. It is, in fact, probably
limited to the capitalization of "I".

This did not happen in gingerbread because gingerbread would
not register 1-letter words as valid bigrams.

This fix works by just always sending the result of autotext
regardless of whether it is already the first suggestion or
not. This is okay because duplicates are removed afterwards
anyway - and this processing is absolutely necessary because
the autotext'd word may actually be somewhere else in the
suggestion, so it made really no sense checking for only the
first one.

Please note that there is also a race condition that can
result in "i" not being converted to "I": at the moment,
Latin IME relies on having the suggestions evaluated
at the time autocorrection is performed, but when typing
very, very fast, those messages may have been canceled.
This is not limited to the autocorrection of "i", but
affects all autocorrections. It requires a nearly
inhumane typing speed to trigger, but hitting "i" and
space in turn as fast as one can it's possible to
reproduce occasionally.

Bug: 5135113
Change-Id: I530ea6212487300001a2c0fc5b25a5c7716bdf63
2011-09-01 12:59:17 +09:00
Tadashi G. Takaoka fdec5c1a78 Merge "Implement popup suggestions pane" 2011-08-31 05:23:54 -07:00
Tadashi G. Takaoka 29e7b7ed6e Implement popup suggestions pane
Bug: 5023981
Change-Id: Ie1d69131dbf884a3f6a2beb3ac3427e5437c1486
2011-08-31 21:21:22 +09:00
Jean Chalard a770d650b5 Fix a possible NPE
Change-Id: I5c57752772414b4f9475d0ad43d7fc52b97c3f33
2011-08-31 19:04:34 +09:00
Jean Chalard 18ccd552a8 Clean up bigram settings
Move bigram suggestion option to the advanced settings screen,
remove bigram prediction option for ICS release and remove the
now-empty bigram option category.

Bug: 5240082
Change-Id: Ib1fc608ad33d5598410f7b0cb4a1639bffef28c7
2011-08-31 15:41:13 +09:00
Jean Chalard fcee70ea92 Merge "Check the magic number of a decoded file" 2011-08-30 22:58:29 -07:00
Jean Chalard 7a408431fe Check the magic number of a decoded file
Checking the magic number of a file upon decoding is necessary,
because if the file is corrupt and we don't check it, we will
fall back to a simple copy of the corrupted file. Latin IME
would realize this and would not crash, but would not use the
corrupted dictionary. If this happened to be a main dictionary,
then the user would lose the ability to use the correct
built-in dictionary.

Not the same, but kinda similar to
Bug: 5223031

Change-Id: Ic2783dc9dd5f3dcf2865623d9452765fe3778db7
2011-08-31 14:37:11 +09:00
Tadashi G. Takaoka b8dc674663 Get rid of MeasureSpec.UNSPECIFIED
Bug: 5023981
Change-Id: I14ded3c3d554ac72b66f190110652f54d91df954
2011-08-31 14:15:20 +09:00
Tadashi G. Takaoka 392276d73d Add Key constructor for suggestions pane
Bug: 5023981
Change-Id: I737bacb1a6bb40f70be65d6eff85614afe6c79ed
2011-08-30 19:14:52 +09:00
Jean Chalard f019d505d7 Fix a bug with synchronicity of spell checking/user dict
This fixes a race condition that would end up with the spell
checker not finding some words in the user dictionary when it
just booted.

Bug: 5194627
Change-Id: I1ba911cc53e6ae3b111d54a6f91d1d5feef3f5de
2011-08-29 18:33:20 +09:00
Jean Chalard 940514989a Merge "Move locale-related utility methods to LocaleUtils." 2011-08-28 20:34:02 -07:00
Jean Chalard ef35cb631c Move locale-related utility methods to LocaleUtils.
Change-Id: I7e9e6e5bc4486d8618d0213b112308c3d305c15e
2011-08-29 12:29:35 +09:00
Tadashi G. Takaoka 85b4752270 Merge "Move debug information back to suggestions strip" 2011-08-26 04:07:00 -07:00
Tadashi G. Takaoka 013ba3e3e7 Move debug information back to suggestions strip
Change-Id: I8cfad5f780a481a251cc4f752bff3cda5ae3ffbe
2011-08-26 20:05:19 +09:00
satok add3e05379 Do not put the suggestion span for obsolete suggestions.
Bug: 5219037

Change-Id: I0300fbc7e1cc97f0f8ba4d21e0e699d9fe66ed76
2011-08-26 19:12:18 +09:00
Tadashi G. Takaoka c04bbc1ae9 Fix "touch to save" colors
Bug: 5218662
Change-Id: I094b2ceb7438148eb5bdf620b188f598e8442a07
2011-08-26 18:55:36 +09:00
Jean Chalard de4e8dedcc Allow sharing dictionaries between similar locales.
Bug: 5058488
Change-Id: Ib12013f58afad957a8205b439f87480cc12ea06f
2011-08-25 19:42:06 +09:00
Jean Chalard a16621ada4 Add a debug variable
...that was missing

Change-Id: Ia3b17909f295e0a93dee633c8d67c0e03840023e
2011-08-24 21:36:18 +09:00
Jean Chalard 20973de72b Avoid unnecessary output to the system log.
The message this removes gets printed under normal conditions.
Normally dictionary files are compressed then crypted, but not
compressed a second time; however LatinIME tries to open a
compressed-crypted-compressed file first, because it could not
do it afterwards and we want to support this case. So under
normal operations, the first method LatinIME tries is actually
expected to fail.
Also, if we decide to stop compressing or/and encrypting dicts
LatinIME supports it as a valid use case. It should not print
errors to the log.

If the file cannot be open at all, then it is an unexpected
case, and Latin IME still reports to the log.

Change-Id: Ic5228c51365a101af1d03e2c893484d3050b5a1c
2011-08-24 20:27:04 +09:00
Tadashi G. Takaoka 1d59e0dbdf Merge "Fix suggestions strip press state to align vertically" 2011-08-24 03:35:57 -07:00
Tadashi G. Takaoka 580e1d7ac0 Fix suggestions strip press state to align vertically
This change also tweaks more_suggestions_hint drawables to eliminate
unnecessarily padding at the bottom.

Bug: 5204563
Change-Id: If5ec731c9a490da0116a020e8fd405c7d025d707
2011-08-24 18:15:19 +09:00
Jean Chalard 38d512c0b2 Call the decrypt/unzip routines upon copying a dictionary.
Bug: 5095140
Change-Id: I7000f752bc9b7fd6a7af4839b2f225c085300128
2011-08-24 17:12:12 +09:00
Jean Chalard 8b21eb2507 Merge "Refactoring: cut out a method for caching a word list" 2011-08-23 23:17:31 -07:00
Jean Chalard 7b1f74bb9d Refactoring: cut out a method for caching a word list
This is preparation to have the decrypting/unzipping code
moved over to LatinIME.

Bug: 5095140
Change-Id: Ic3fdcc3de673b46cef2eb9ebe6a52cbdd614e50a
2011-08-24 15:09:57 +09:00
Tadashi G. Takaoka fd47b5d09c Merge "Move some static methods from SubtypeSwitcher to Utils" 2011-08-23 22:39:51 -07:00
Tadashi G. Takaoka af52c0ea04 Implement "forceAscii" private IME option
This change also introduces "AsciiCapable" extra value for subtype
that indicates the subtype can input any ASCII code point from its
keyboard layout.

Only if the input field has "forceAscii" private IME option and the
current subtype doesn't have "AsciiCapable" extra value, the en_US
keyboard layout will be used for the input field.

Bug: 3384942
Change-Id: I25e2553e37ecb5002df1164e45f6273845fe463b
2011-08-24 13:19:56 +09:00
Tadashi G. Takaoka 57f05f4412 Move some static methods from SubtypeSwitcher to Utils
Change-Id: I3ea8ffcdefcefaa82ae76a31bb65977009d8a040
2011-08-24 12:54:53 +09:00
Jean Chalard 1616e2e96e Merge "Fix an excessive fallback problem." 2011-08-23 02:12:17 -07:00
Tadashi G. Takaoka c84bc3460d Rename LatinKeyboardBaseView to LatinKeyboardView
Bug: 5182291
Change-Id: I5089a14902b9f4ff1ab4f34e3f7a42aca5040d3e
2011-08-23 17:57:02 +09:00
Jean Chalard 0ee3b69483 Fix an excessive fallback problem.
LatinIME has several fallbacks to ensure a dictionary is used.
However, it should now be possible to deactivate the main dictionary
through the dictionary pack settings. In this case, Latin IME should
not fallback to the built-in dictionary.

Change-Id: Ibd992ad89793169f04a968b40781fce819b87b6f
2011-08-23 17:55:46 +09:00
Tadashi G. Takaoka 2d306a225c Merge "Extract sudden jumping touch event hack into separate class" 2011-08-23 01:49:38 -07:00
Tadashi G. Takaoka c403a46f6d Extract sudden jumping touch event hack into separate class
Bug: 5182291
Change-Id: I6a88ed4df3ec98e31ea4966d82da56f7fca342ac
2011-08-23 17:44:41 +09:00
Tadashi G. Takaoka 0940093c30 Merge "Remove screen orientation confirmation hack" 2011-08-23 00:39:19 -07:00
Tadashi G. Takaoka f94df382fb Remove screen orientation confirmation hack
Bug: 4311428
Change-Id: Ie7e094ded9c7c1fe811b7eb97bc33ffecb29a73c
2011-08-23 14:58:45 +09:00
Jean Chalard a6e912cf98 Fix a bug with the string pool.
This also adds some optional debug code to detect more easily possible
future occurrences of the same problem.

Bug: 5195017
Change-Id: I2558b468e46f7090de868f1ec2dc9e24895d670f
2011-08-23 14:55:34 +09:00
Tadashi G. Takaoka 9f31575045 Merge "Fix suggestions strip text colors" 2011-08-22 03:32:05 -07:00
Tadashi G. Takaoka d47a955610 Fix suggestions strip text colors
This change also shows the valid typed word in bold face.

Bug: 5161713
Change-Id: I15355a11888fc8ef90ecc8b64a52eb08c1a2b367
2011-08-22 18:56:54 +09:00
Jean Chalard 70a92a33f8 Merge "Remove duplicates from the spell checker suggestions." 2011-08-22 02:49:33 -07:00
Jean Chalard 6b166a1933 Remove duplicates from the spell checker suggestions.
Bug: 5175740
Change-Id: I592401b3b8c3074d70e06dc3a9919cc3cb47ba49
2011-08-22 18:44:04 +09:00
Tadashi G. Takaoka b39f612d97 Remove hacks related to determine window width
Bug: 4311428
Change-Id: Ic93f264101d13963503fcd447a69bbffd06e69f3
2011-08-22 17:17:42 +09:00
Jean Chalard 5d4c5692f1 Fix case sensitivity for the spell checker.
The new behavior is as follows:
- If the word in the dictionary is not fully lower case, then the
exact case is required to match.
- If the word in the dictionary is fully lower case, then any of
the following patterns match:
  - fully lower case
  - only the first char capitalized
  - all caps
Any other capitalization is rejected.

This is probably what people want. If you type a name in all lower
case, it should be marked as a typo, but if you type a word with a
capital for emphasis or just because it's the start of the sentence,
it should match a lower case word in the dictionary. If you have
a spurious capital letter in the middle of a word because of a typo,
it should be marked as such.

Accents are not affected, and should not be. An accented letter
is a different letter and a missing accent should be reported.
We should maybe consider again for some common transpositions
like the "ue" digraph for German, which is now considered a typo,
but will suggest the correct diacritics as the first suggestion.

Bug: 5145751
Change-Id: I651e24f13c90fb94700a1674ad380e95336e7dca
2011-08-22 14:02:57 +09:00
Ken Wakasa cee174b8cc Settings key visibility should always follow the system default value,
by ignoring its preference value, when the "show settings key option" in
the settings is disabled.

Change-Id: I934be2d9eb0bf6bf731e03f5d9b752de4a7a1c7c
2011-08-22 12:21:25 +09:00
Jean Chalard 6da8b74582 Move the dupes-removing method to the Utils class
This is preparation for bug: 5175740

Change-Id: I18b2042317f740cb1e021d3dfbf90ecfbb1a1d37
2011-08-19 19:49:59 +09:00
Jean Chalard 150bad6fd4 Have the spell checker use the User dictionary.
Bug: 5175868
Change-Id: I165eee4c865caa5ee1daf3e0b1acde8788b996ef
2011-08-19 17:19:49 +09:00
Jean Chalard ee7daefd97 Check the main dict id to be able to fallback.
Bug: 5095140
Change-Id: I02032923ca2a65bd8fbabc0abbe6a476f7542187
2011-08-18 20:09:35 +09:00
Jean Chalard 89fdb82753 Merge "Move the settings test to a more appropriate place." 2011-08-18 03:39:08 -07:00
Jean Chalard 83207fb482 Move the settings test to a more appropriate place.
This change refactors the dictionary selection code so that the
cached dictionary files list and the settings tests are more
cleanly separated.
This will also help with future refactorings that will test for
the presence of the main dictionary and insert the fall back if
it's not supplied by the dictionary pack.

Bug: 5095140
Change-Id: I8d7caad7c054031df71fe78b043801a774d50f65
2011-08-18 19:35:52 +09:00
Jean Chalard 4e01afc520 Make the string builder pool in Suggest a singleton.
This is internal refactoring, done as preliminary work to fix
Bug: 5175740

Change-Id: I21bd4c001c27e7b925ddb87a152105b4dcab320a
2011-08-18 18:41:57 +09:00
Jean Chalard 5ba5ff9b80 Merge "Exception refactoring" 2011-08-18 02:36:42 -07:00
Jean Chalard 03c3b64ee5 Merge "Refactor string removal to make it static" 2011-08-18 02:36:32 -07:00
Jean Chalard 3016863f86 Refactor string removal to make it static
The next step is to move this over to the Utils class.
The ultimate goal is to make use of the duplicate removal code
also in the spell checker as per
Bug: 5175740

Change-Id: Ica36691b843b0713b832c56ffc65e5b2ec427c4a
2011-08-18 15:16:59 +09:00
Jean Chalard 80e0bf0429 Exception refactoring
Now that the dictionary pack can return several files, it's better
to handle IO exceptions for each file rather than globally. This
also will help with next implementation steps.

Bug: 5095140
Change-Id: I5ed135ad2ad4f55f61f9b3f92c48a35d5c24bdb2
2011-08-18 15:11:19 +09:00
Jean Chalard 091bbf85d8 Merge "Factor dict pack settings reading into a static inner class" 2011-08-17 19:34:31 -07:00
Jean Chalard c11c4fd61b Factor dict pack settings reading into a static inner class
This is essentially refactoring to help next steps

Bug: 5095140
Change-Id: Ic97044d2ed354027bac4f84e6ce69d20ef6da092
2011-08-17 11:25:21 +09:00
Tadashi G. Takaoka 961453c3b3 Merge "Get rid of auto correction flash animation in the suggestion strip" 2011-08-16 18:49:36 -07:00
Tadashi G. Takaoka bea6b72106 Get rid of auto correction flash animation in the suggestion strip
This change also reverts I1350ad3d.

Bug: 5156762
Change-Id: I047e75699e8eea02204ad95e12dcc0aefe49ac34
2011-08-16 17:47:23 -07:00
Tadashi G. Takaoka 5cb10f78ed Fix possible NPE
Bug: 5171442
Change-Id: I280f6a0ef5fb06f1e03e17c0065d078604e4747a
2011-08-16 17:36:13 -07:00
Jean Chalard c160373b6a Close dictionary pools when they are not used any more.
Bug: 5156851
Change-Id: Icaba54734eb790b40dc2012aac25df5b2af71dbb
2011-08-16 20:04:57 +09:00
Jean Chalard a562767a14 Have a pool of dictionaries to check spelling.
The dictionaries and proximities are not thread-safe. In order to
be able to check spelling in parallel, make a dictionary pool to
call upon when a spelling check is necessary.

Bug: 5156851
Change-Id: Ie3796164187dd7b7abf5ccd5d014073d43d74408
2011-08-16 18:13:12 +09:00
Jean Chalard 70b9c5d991 Make the spell checker re-entrant.
Until the dictionary itself is re-entrant, unfortunately we have
to synchronize accesses to it.

Bug: 5156851
Change-Id: I1629a160d707e6fa1ad80cba828798abb24b68b1
2011-08-16 13:58:37 +09:00
Ken Wakasa bb5504c47d Merge "Get rid of auto correction flash animation in the suggestion strip" 2011-08-12 07:19:50 -07:00
Ken Wakasa 59f5cc8572 Get rid of auto correction flash animation in the suggestion strip
bug: 5156762
Change-Id: I1350ad3d7125f8ecdfc699233ed05e253cc3f010
2011-08-12 23:14:34 +09:00
Jean Chalard b6b7d81f5d Merge "Add a settings activity for the spell checker." 2011-08-12 03:11:33 -07:00
Jean Chalard 31fd54c53f Add a settings activity for the spell checker.
Bug: 5156940
Change-Id: I762de1296f861abce2d0413404bca54571e0ea0a
2011-08-12 19:07:51 +09:00
Jean Chalard 86e517fe4a Read shared prefs from the dictionary pack.
Bug: 5095140
Change-Id: I227fbd95d8a0330b6dede6de99fde3a5a715fe2d
2011-08-12 17:31:24 +09:00
Ken Wakasa 7fca6a5357 Merge "Key click sound volume fix" 2011-08-11 10:06:49 -07:00
Ken Wakasa bf7dd47329 Key click sound volume fix
bug: 5145886
Change-Id: Ic599373ee17423ef9c61b3dd5177c3763aa31015
2011-08-12 02:02:03 +09:00
Jean Chalard 08868624ed Use the dictionaries cached LatinIME-side
Dictionaries are now copied over from the dictionary pack to Latin IME.
This change enables Latin IME to use all dictionaries that have been
cached until now.

Bug: 5095140
Change-Id: Id9a2bacf9dc1c693189b0ac8aa3f75756dc1e3e6
2011-08-11 18:15:39 +09:00
Jean Chalard 2896673461 Rename a function and update a comment
Bug: 5095140
Change-Id: Idf66a04c6a1a05015f94187a8dbce3d443bbf38b
2011-08-11 17:07:28 +09:00
Jean Chalard f102f6a3ac Merge "Give the orders to delete the source files to the dict pack" 2011-08-10 21:54:27 -07:00
Jean Chalard 5774908bb3 Give the orders to delete the source files to the dict pack
Bug: 5095140
Change-Id: I64552861768ca30073ffe0d631b2e0c44dad4aa9
2011-08-10 21:55:15 +09:00
Luca Zanolin c359d75ca7 Merge "Execute the switching to a different IME in a POOL_EXECUTOR." 2011-08-10 04:17:53 -07:00
Luca Zanolin 613073d01b Execute the switching to a different IME in a POOL_EXECUTOR.
Using only a single thread may slow down the application, if there is already another thread running.

Bug: 5142142
Change-Id: I314480a58af20ea09458ff82e586304fc3c7c070
2011-08-10 10:29:06 +01:00
Jean Chalard d4c08d9be3 Make sure the directory where to put files actually exists
Bug: 5095140
Change-Id: I764471e54ce0bf6aefe5d604cee97639d5ad0af9
2011-08-10 17:14:34 +09:00
Ken Wakasa 11b7febc0b Ellipsis for "Space" key for triggering the IME switcher
bug:5136497
Change-Id: Iab7c68135500e9fed212521484090b52943550ca
2011-08-10 00:31:23 +09:00
Jean Chalard f098fbbef3 Add proximity info for the spell checker.
Bug: 5119987
Change-Id: I35700fd8b0ffa6bced428cc6d46b3f64eb251281
2011-08-09 17:24:28 +09:00
Jean Chalard 3a22708e65 Have Latin IME copy files from the dictionary pack.
Also some minor cleanup: remove unused methods, minor refactoring into methods.

Bug: 5095140
Change-Id: I035537b37a31adfc8db3b933fb0cefcf703d6c7c
2011-08-09 16:02:14 +09:00
Jean Chalard 14051e2b53 Stop reloading contacts when not appropriate.
A recent change had the contacts reloaded every time a new field
is touched. This change not only fixes the problem, but also removes
reloading contacts when changing language, which should make language
switch within LatinIME lighter.

Bug: 5125034
Change-Id: Ia61c4f75a8617113cdce88a2e2c6fdf073146a2d
2011-08-09 12:49:19 +09:00
Ken Wakasa 44beeab4a4 Merge "Fix issues with long-press access to more suggestions" 2011-08-08 04:37:09 -07:00
Ken Wakasa bbf25cf251 Fix issues with long-press access to more suggestions
Change-Id: If5a45dcae7f7e7881d305104e35a04c341719aec
2011-08-08 20:33:44 +09:00
Ken Wakasa ad7ddca397 Merge "Correction mode should not rely on the existence of the main dic" 2011-08-08 04:24:05 -07:00
Ken Wakasa c769ef4dd1 Correction mode should not rely on the existence of the main dic
bug: 5114094
Change-Id: I2088918ec2c9ad6f8db13b55e58d3e73e180aef8
2011-08-08 19:42:24 +09:00
Tadashi G. Takaoka ae5c736e37 Remove suggestion pane controller from strip
This change also removes speacebar LED to represent auto correction.

Bug: 5023981
Change-Id: Idedaabd147ed608df35cb51769388578a05174a1
2011-08-08 00:15:49 -07:00
Ken Wakasa 20c4aec827 Partially revert I531a3257 as it mistakenly broke some logic -- textToTheLeft was required.
Change-Id: I24f55cec05fea68836d6b3413b69f1e1b9c68ba2
2011-08-06 22:37:45 +09:00
Ken Wakasa cadb2128f5 Fix issues with long-pressing the spacebar
bug: 5114433
Change-Id: I18f2147724a08965147bafe93e11fc86c7c59d33
2011-08-06 16:49:32 +09:00
Tadashi G. Takaoka 60a004f78e Fixed count suggestions strip
Bug: 5023981
Change-Id: I434d23bdfb653989866d3822c978cd929a2b553c
2011-08-05 19:25:36 -07:00
satok 5bcf8ee66c Update the spell checker according to API cleanup
Change-Id: Ia95a63963c16265bc9bc7e1fcecf120e17bf8636
2011-08-05 19:57:47 +09:00
Tadashi G. Takaoka fd047f61e4 Merge "Move suggestions layout code into parameter class" 2011-08-04 23:57:31 -07:00
Tadashi G. Takaoka 16713e5630 Move suggestions layout code into parameter class
Bug: 5023981
Change-Id: I30f45191524c38bfe550845b003e8972abd2ee49
2011-08-04 09:26:37 -07:00
Jean Chalard 3234123fba Implement the spell checker.
Bug: 4176026
Change-Id: I297c47202e96ce0db74d703f30709777f26b93ac
2011-08-04 21:27:14 +09:00
Jean Chalard ac21e0a349 Merge "Create a way to pass the proximity info to the dictionary" 2011-08-04 04:17:33 -07:00
Jean Chalard 043f784198 Create a way to pass the proximity info to the dictionary
This is a preparative change for inserting the spell checker.

Change-Id: Ie441879cac4f67078ec27a95f1fcbbf3ef373df7
2011-08-04 19:46:21 +09:00
Tadashi G. Takaoka 80ba224fff Merge "Cleanup CandidateView class" 2011-08-04 01:19:55 -07:00
Tadashi G. Takaoka d95a6365be Cleanup CandidateView class
Bug: 5023981
Change-Id: Id79e31c60dfb41be546f5c5a3680e8651457151d
2011-08-04 01:14:55 -07:00
Ken Wakasa 3aacd1d7d8 Merge "Additional hack for bug:4311428, a follow up for Ieade33d7." 2011-08-03 23:34:12 -07:00
Ken Wakasa de30f9f2d6 Additional hack for bug:4311428, a follow up for Ieade33d7.
Change-Id: If1799a6fa3b2f45c98c9f3aeb88845f1fb08f09b
2011-08-04 15:31:33 +09:00
Jean Chalard 8289dede0a Merge "Remove newly unused code" 2011-08-03 22:47:27 -07:00
Jean Chalard 09e91ee072 Remove newly unused code
Bug: 5095140
Change-Id: Ie4322815f029f063dda2925697d6d8f63bfaf6d6
2011-08-04 13:53:24 +09:00
Ken Wakasa 3889462439 Handle non word separators correctly even for the initial letter of a word
bug: 5101114
Change-Id: I0d804c9a500ff000dc06cadad46a2c6c6b8088b2
2011-08-04 12:24:45 +09:00
Tadashi G. Takaoka bb12dc455b Merge "Fix saving keyboard state while rotating" 2011-08-03 15:15:59 -07:00
Tadashi G. Takaoka 38b5605fee Fix saving keyboard state while rotating
This change also uses longer timeout for restoring keyboard state.

Bug: 4311428
Change-Id: Ieade33d7c69f1dee727b2b8c26f0112eca44b336
2011-08-03 09:41:04 -07:00
satok e486290013 Merge "Temporary don't use "looks type" for comming rename cl." 2011-08-03 03:24:48 -07:00
satok 55d1c5efab Temporary don't use "looks type" for comming rename cl.
Change-Id: If016a61f9e303b615c59c0035724256535aec817
2011-08-03 18:42:56 +09:00
Tadashi G. Takaoka eedfef0308 Merge "Retain keyboard layout while orientation change" 2011-08-03 02:37:00 -07:00
Tadashi G. Takaoka 055054eef3 Retain keyboard layout while orientation change
This change also changes the timimng that the window width is
registered.

Bug: 4311428
Change-Id: Ied6b1b43bfa16a85f0e05cd308ce919d5d65677e
2011-08-03 02:20:27 -07:00
Ken Wakasa 21fa416c43 Revive the missing Settings key on tablets
This is a follow up change to Ieb42fdfa.

bug: 5094401
Change-Id: If78c966ed02fbc9b8c6da726e00424a927349142
2011-08-03 17:00:14 +09:00
Jean Chalard fae8d60ee9 Change the dictionary file passing schema to a list of ids
The dictionary filename used to be passed directly to Latin IME.
This change implements, on the part of Latin IME, the passing of
them as an id that should then be passed through
openAssetFileDescriptor.

Bug: 5095140
Change-Id: I7d1e9d57c19f0645045368f68681680f238189fc
2011-08-02 19:16:39 +09:00
Tadashi G. Takaoka 8da9a13760 Make Keyboard object immutable except shift state
This is the first step to implement suggestions pane as mini keyboard.

Bug: 5023981
Change-Id: I90ffbde0fda19b4be68add449310997b56bf6904
2011-08-01 22:04:48 -07:00
Jean Chalard cb1cc0d0de Merge "Try to compensate for a race condition." 2011-08-01 04:17:22 -07:00
Jean Chalard f2f9715319 Try to compensate for a race condition.
This does not really fix the underlying bug, but it does fix
the apparent symptoms.
When the user presses space and a letter quick, the
onUpdateSelection handler may be called after the letter has been
actually committed. The keyboard then happily proceeds to clearing
the composition because it thinks space was pressed (or the user
moved the cursor, since it can't guess which happened).
This change removes this behavior when we are expecting an update
event from a keypress. This means the bug still exists if the user
presses space twice and a letter, and all events come after the
letter, but it is very very hard to reproduce this. There may be
other collateral damage when the user moves the cursor in the form
of race conditions, but likewise, they should be really hard to
reproduce.

Bug: 5100521
Change-Id: Ib05328c9b451bf6fe288ae00296fd283a9a4e863
2011-08-01 19:51:55 +09:00
Ken Wakasa 9351550dc6 Clean up revertLastWord()
The "deleteChar" argument of this method is acutally always true in the current code path.
Also, in this method, textToTheLeft virtually never has a punctuation letter as its initial
character.  This change is one of preparatory changes for bug:4983945.

Change-Id: I531a32570a35634c21c1d74b2b461e40a1b7f660
2011-08-01 16:03:43 +09:00
Ken Wakasa 2ba975afb9 Turn off the Settings key by default
bug:5094401
Change-Id: Ieb42fdfa79be2afcfa6634e7404c17737ef6927d
2011-07-31 07:26:24 +09:00
satok 4e7d0663ba Merge "Modified the test spell checker" 2011-07-28 18:09:51 -07:00
Tadashi G. Takaoka 259ce17f5d Merge "Use isFullscreenMode to determine candidate container height" 2011-07-28 17:40:18 -07:00
Tadashi G. Takaoka ecf43d4f9d Merge "Remove dead area around separators in the suggestion strip" 2011-07-28 17:39:43 -07:00
Tadashi G. Takaoka 3782f2bf1e Merge "Remove icon and negative button from dialogs" 2011-07-28 17:39:07 -07:00
Tadashi G. Takaoka 4b1780fa95 Use isFullscreenMode to determine candidate container height
Bug: 5081182
Change-Id: I3783d3994e96f8bf466cbc47c9e0aecc2a6bed50
2011-07-28 15:06:15 -07:00
Tadashi G. Takaoka a1aab83a24 Remove dead area around separators in the suggestion strip
If user touches the separator, the right hand side suggestion will be
selected.

Bug: 4431485
Change-Id: Ieaa79fe2ac7b15e312829dca847ddb1b25056c09
2011-07-28 14:15:24 -07:00
Tadashi G. Takaoka e4b445f1ce Remove icon and negative button from dialogs
Bug: 5092028
Change-Id: I25b86c6e74e380e6cee4998bfe494bdafb611f36
2011-07-28 13:49:57 -07:00
Tadashi G. Takaoka c3d175c01f Fix wrong keyboard width when orientation has changed while IME is not shown
Bug: 5084021
Change-Id: Ie42da40b8249eaf9cf29707058906949278eff6a
2011-07-28 11:02:29 -07:00
satok a90992e562 Modified the test spell checker
Change-Id: Ib64fac8672a4107638cd05a0232d46b49fc4aa8c
2011-07-28 20:55:00 +09:00
Tadashi G. Takaoka 60ccbe16ee Clean up keyboard loading and switching
Bug: 4311428
Change-Id: Ia72de23634f824d82b7b5f2267d439ce922a3b57
2011-07-27 13:34:16 -07:00
Jean Chalard a48f8b3764 Merge "Load the binary dictionary asynchronously." 2011-07-26 23:34:52 -07:00
Jean Chalard 3af9f05f29 Load the binary dictionary asynchronously.
This should help with LatinIME opening performance.
It should not be merged before Ia9e4741f (if it is, there is a
race condition where the wrong dictionary is opened).

Bug: 5023141
Change-Id: I39c52de70a449929a622dddfdd92b38425ad9416
2011-07-27 15:18:49 +09:00
Jean Chalard e576a0d537 Fix a NPE when sent buggy data by an application
Bug: 5072247
Change-Id: I7369877072f6bb94dff5b1bcf52c9f8dde4854b7
2011-07-27 13:27:37 +09:00
Jean Chalard d3da6e6311 Close a multiprocess file handle.
Bug: 5034192
Change-Id: I9c3d757cfae313e9b7510e167de797a74c74a351
2011-07-26 22:13:34 +09:00
Jean Chalard f50aa19337 Purge quick fixes option.
This change removes everything related to the quick fixes
Latin IME option item.
Note that Autotext is still used if the current subtype language
is the same as the system language.

Bug: 4985058
Change-Id: I51728a2190543ffb9e004470674ef6257b14f6c2
2011-07-26 16:25:57 +09:00
Ken Wakasa 83ffff2a49 Take care of bidi-mirrored characters in suggestion strip as well
Follow up to I1b884848

bug: 5047217
Change-Id: I18b9962c4943363bae88009354fcc75ab60ad2ba
2011-07-26 07:55:12 +09:00
Tadashi G. Takaoka 5800eb48d0 Merge "Fix voice key mode default back to "on main keyboard"" 2011-07-25 14:52:10 -07:00
Tadashi G. Takaoka f92bd4de20 Fix voice key mode default back to "on main keyboard"
Bug: 5074042
Change-Id: I0c4a09b286c7680306741d47a48d5d9783e4a890
2011-07-25 14:44:47 -07:00
satok 2c18ffb97f Merge "[step3] Add spell checker service." 2011-07-25 13:48:47 -07:00
satok 022c1cc203 [step3] Add spell checker service.
Change-Id: Ib13b3a524e0f0b90de40a3e255040b3158d49258
2011-07-25 11:05:24 +09:00
Tadashi G. Takaoka cce61aa045 Merge "Refactor Keyboard and KeyboardView resizing and drawing code" 2011-07-22 18:41:23 -07:00
Tadashi G. Takaoka 38f55b36c3 Refactor Keyboard and KeyboardView resizing and drawing code
Bug: 4311428
Change-Id: Ice4050f92c8f3cec1bec2074fe6a913d04f50524
2011-07-22 16:50:53 -07:00
Tadashi G. Takaoka f3e7688361 Merge "Disable VoiceInputLogger inside LatinIME" 2011-07-22 02:41:31 -07:00
Tadashi G. Takaoka 255486a5d0 Disable VoiceInputLogger inside LatinIME
Bug: 4985273
Change-Id: I6c70e50a58be0973f78c6a1abc1fb4eac5449c0b
2011-07-22 02:37:56 -07:00
Tadashi G. Takaoka 60c8eba634 Merge "Check user dictionary is enabled before showing touch-to-save" 2011-07-22 02:35:16 -07:00
Tadashi G. Takaoka ada26bb383 Check user dictionary is enabled before showing touch-to-save
Bug: 5024127
Change-Id: If4d691a4a59c43579d1f977e9a0545495f30bafb
2011-07-22 01:32:53 -07:00
Jean Chalard f6f0e63d79 Do not register null pointers as dictionaries
Bug: 5062425
Change-Id: I025991424de40c2b31b90238f99ef160e7efd92e
2011-07-22 14:46:43 +09:00
Jean Chalard a3dd3887c9 Merge "Set the locale for opening an asset" 2011-07-21 03:18:23 -07:00
Jean Chalard e150ef9856 Set the locale for opening an asset
This is necessary because we don't know any more whether the
locale of the process is the expected one when the dictionary
is loaded asynchronously.

Bug: 5023141
Change-Id: Ia9e4741f3b4a04a9f085f5b65ec122471b0c2dff
2011-07-21 19:14:16 +09:00
Tadashi G. Takaoka 3be0039164 Fix potential NPE
Change-Id: I3679d24b6c89e081d24d59c91b136c139dcb3d5c
2011-07-21 02:27:27 -07:00
Tadashi G. Takaoka 055265684b Revert "Guard unused voice functions"
This reverts commit 795a712ecf.
Bug: 4985273
2011-07-21 02:18:35 -07:00
satok 60cb1cc7b3 Merge "Guard unused voice functions" 2011-07-21 00:10:30 -07:00
satok 795a712ecf Guard unused voice functions
Bug: 4985273
Change-Id: I9491b4af24e636cba6362cdde44568d14f7b2b85
2011-07-21 16:07:00 +09:00
Jean Chalard 728ab86f8c Merge "Fallback to the included dict if the passed one is invalid" 2011-07-20 19:50:54 -07:00
Jean Chalard 7e19a64c86 Fallback to the included dict if the passed one is invalid
If all dictionaries returned by the dictionary pack are invalid,
then fallback to the dictionary included in the resources for this
locale.

Bug: 5052486
Change-Id: Id875194ca56a74b2ed6f5b0b4fdd55475f6842c8
2011-07-20 19:53:47 +09:00
Tadashi G. Takaoka ef5dfc480c Remove sliding spacebar language switcher
Bug: 4971680
Change-Id: Ia3485ddcf8051bf7b7ba7f7a37fa75c3bc8a4798
2011-07-19 23:24:49 -07:00
Tadashi G. Takaoka 1dc80048d7 Merge "Support select input method dialog on pre-HC platform" 2011-07-19 23:22:37 -07:00
Tadashi G. Takaoka bf9d8348d8 Support select input method dialog on pre-HC platform
Bug: 4971680
Change-Id: I641b336da54813e13409bd7874aa22e51f790729
2011-07-19 22:22:47 -07:00
Tadashi G. Takaoka 5ab5807d91 Remove long-press-to-save feature from CandidateView
Bug: 5027059
Change-Id: I884a84e50e810c0c4a8255217b39ea24937c756b
2011-07-19 17:22:02 -07:00
Jean Chalard 40f7efc172 Fix an NPE related to absent InputConnection
Bug: 5035577
Change-Id: I1a11fc475d4a0f692636000d0b0f40bc35427867
2011-07-19 19:25:48 +09:00
Jean Chalard 44861474fb Add a number of NULL pointer guards.
None of these are expected to actually be null, but those are
included for peace of mind and foolproofing against future
code changes.

Bug: 4580040
Change-Id: Ib112b3e5db5f177aaf61767164b7e78d711f90a0
2011-07-19 18:19:23 +09:00
Jean Chalard 494ab16396 Merge "Deactivate the user unigram dictionary." 2011-07-19 01:50:57 -07:00
Jean Chalard 52f20d6a43 Deactivate the user unigram dictionary.
Bug: 3459274
Change-Id: I41b7617623b5b2e48c2e460dc7f2d5ff410c8a4c
2011-07-19 17:30:52 +09:00
Jean Chalard 2b4eabed2b Allow double-space-period after relevant punctuation signs.
This allows the user to enter a period via double-space after quotes,
currency symbols, brackets and other non-sentence-finishing
punctuation marks.

Bug: 3430389
Change-Id: Ibe40b3902861207eb918e7be6113e8be12216f53
2011-07-19 16:12:24 +09:00
Tadashi G. Takaoka 2811841ab4 Honor EditorType's IME_FLAG_NO_EXTRACT_UI and IME_FLAG_NO_FULLSCREEN flags
Bug: 5030408
Change-Id: I1c5649725780cd063db7a437b8559b7f2573469c
2011-07-15 16:21:16 -07:00
Jean Chalard f422345211 Rename AutoDictionary to UserUnigramDictionary.
...and adjust internal functions, variables and constant names.

Bug: 3459274
Change-Id: I1b11c6adfee360ac0fc22d627955688b3dbdcffc
2011-07-15 12:14:47 +09:00
Tadashi G. Takaoka 41c1f48028 Fix IndexOutOfBound exception
Bug: 5011243
Change-Id: Iaaafa50b42e5155e3682132217d3e079a170ed89
2011-07-13 18:45:10 -07:00
Tadashi G. Takaoka 5cbdb23621 Fix IOOB Exception
Bug: 5021745
Change-Id: I58815ca3f3c8b1bead895e8a94e2f89dbcc67436
2011-07-13 12:26:40 -07:00
Jean Chalard 092826c8cd Fix crash on adding a word in the user dictionary.
When the User dictionary service is off, LatinIME still allows to add
words to it and it crashed if the user tries to do so. This change
fixes the crash; it does not however fix the interface.

Bug: 5004408
Change-Id: I5bd2684ab3010963c1f737fc764e70e79aadbe8d
2011-07-13 17:52:34 +09:00
Ken Wakasa 4f365403c5 Fix build breakage
Change-Id: Id2c2d152f54d00842ef9e200ccdce1e13cc128cb
2011-07-13 13:49:13 +09:00
Ken Wakasa 84cb23a789 Small code cleanup
Change-Id: I7075d85f745c3b186e6d06086b9fcd54e7459feb
2011-07-13 12:15:22 +09:00
Ken Wakasa 8558cfb42a Code cleanup
Change-Id: Ie43181721ba18e0c04048eaa9e3016dcea9f5a49
2011-07-12 16:47:08 +09:00
Ken Wakasa 9318d33b6e Change variable names for readability
Change-Id: I9face4e90af4bcd6040eb7e303b596af7d643934
2011-07-12 12:08:58 +09:00
satok 4a0c343dbd Use InputMethodSettingsActivity
Bug: 4979539
Change-Id: Ib721814bfe80822ded7b0d801f6bc0c854588da4
2011-07-11 10:15:03 +09:00
satok 1a3bb54bb4 Use InputMethodSettingsFragment
Bug: 4979539

Change-Id: I4f2010f785eb29ccd42b488c402ef9957633e0c2
2011-07-09 11:25:54 +09:00
satok 68d419d1f5 Merge "Internal cleanup before using InputMethodSettingsFragment" 2011-07-08 17:40:32 -07:00
satok 4598d12064 Internal cleanup before using InputMethodSettingsFragment
Change-Id: I7e3211feadf7b87b789040f6dcd6dda84a9d454a
2011-07-09 09:22:03 +09:00
satok 41f1509334 Remove override which will be invalid.
Change-Id: I8b548e0167791c1f5e46971901d13ee1aadc45da
2011-07-09 08:15:36 +09:00
Tadashi G. Takaoka c71854a661 Remove swipe gesture
Bug: 4971680
Change-Id: Ifff27f3bd3dd26417bfcb7072aaba074025b1bb7
2011-07-08 00:00:14 -07:00
Ken Wakasa 1bd62a5621 Fix missing suggestions after "Touch again to save"
This is an amendment to If848320c

bug: 5000317
Change-Id: I7eed5759c6adc0538c51f540c84a597919e792fa
2011-07-07 17:59:19 +09:00
Tadashi G. Takaoka c810b0d63a Merge "Make sure that each view has its own dedicated background drawable" 2011-07-06 19:12:39 -07:00
Tadashi G. Takaoka 88110d1799 Clear CandidateView in onStartInputView
Before starting input on new TextView, we must clear the CandidateView
because it may hold the suggestion of previous TextView or even worse
the suggestions pane has been expanded and keyboard has been hidden.

Bug: 4995414
Change-Id: If848320c1a510e7018d36ed8ac61291be2fc6ce5
2011-07-06 17:57:24 -07:00
Tadashi G. Takaoka 7c57e3bda1 Make sure that each view has its own dedicated background drawable
Bug: 4998490
Change-Id: I3527fc41f0f03bbb32e3d1880665c6995354aa57
2011-07-06 17:42:03 -07:00
Ken Wakasa 273e5d60f4 Use the new settings activity class name
Follow up to I96230f05

Change-Id: I0ee7ccb5461764490ae9c977658883b10fe3ed3d
2011-07-06 12:38:34 +09:00
Tadashi G. Takaoka f60d09ac30 Narrower KeyboardView reference
This change also rename static inner class to more readable name and
get rid of unnecessary object reference from PointerTracker.

Bug: 4768084
Change-Id: Ie4e2b940d66b47d41efcae7eeac853cdae2e4d38
2011-07-04 22:42:48 +09:00
satok e55996373f Removed unused import
Change-Id: I87344f071e982dfc37b17553c5a7054e26009cc7
2011-07-04 22:26:05 +09:00
Tadashi G. Takaoka 5f6816fa8b Move keyboard event handling code to separate LatinKeyboardBaseView class
To sort out the issue, main keyboard and mini keyboard have to share
the pointer trackers.

In order to prepare for that, KeyboardView needs to be refactored as
two separate classes. KeyboardView is responsible for drawing keyboard
visual. And LatinKeyboardBaseView is responsible for handling key
event and mini keyboard as well.

Bug: 4768084

Change-Id: I5643e333b9bdfde0c939a0693cea76bd22f38897
2011-07-04 18:53:50 +09:00
Tadashi G. Takaoka 386899a8b0 Merge "Disable auto-correction when application auto completion has set" 2011-07-04 02:20:05 -07:00
satok 67b5180e85 Merge "Add SettingsActivity" 2011-07-04 02:11:38 -07:00
satok 29387a8922 Merge "Fixed a visibility of a shortcut button" 2011-07-04 02:10:44 -07:00
satok 1be5028dcf Add SettingsActivity
Change-Id: I26d9f90fe18bd7723f1c3c0c9fafbb659cb2f020
2011-07-04 18:08:26 +09:00
satok 1cda6eb176 Fixed a visibility of a shortcut button
Change-Id: I65e57f6742186b3434d6582ce7f2a1d5d91ce588
2011-07-04 17:49:30 +09:00
Tadashi G. Takaoka 5238df54ad Disable auto-correction when application auto completion has set
Change-Id: I3f4ecfe7f2d96613dd37d41d9195d94864f82b48
2011-07-04 16:21:32 +09:00
Tadashi G. Takaoka e583371b13 Use Key background for suggestions strip control
Change-Id: I5e43c0919e89972283fd18eb29d69f96f1bd0290
2011-07-04 15:42:20 +09:00
Tadashi G. Takaoka 5a931efe1e Set candidates pane control visibility gone when touch-to-save is activated
Bug: 4985540
Change-Id: I9ca9e9bd990d9cdae0da22625be88bbfa4c7ee62
2011-07-02 01:59:49 +09:00
Tadashi G. Takaoka 7f3e5979d7 Merge "Calculate text width more conservatively" 2011-07-01 06:35:10 -07:00
Tadashi G. Takaoka fe9b65afa8 Calculate text width more conservatively
Change-Id: If937ca0d05d50def115f6d275ed4b727c71e7bf4
2011-07-01 22:26:24 +09:00
Tadashi G. Takaoka 4edc7d074b Disable candidate pane controller just after suggestions are set
Change-Id: I62e24bc39e80e2b51d1a29d093a96a8480254da2
2011-07-01 21:19:31 +09:00
Tadashi G. Takaoka f008ae9ece Merge "Tweak ICS theme a bit" 2011-07-01 05:12:43 -07:00
Tadashi G. Takaoka 3118277dd4 Tweak ICS theme a bit
Change-Id: Ib8f1a712a1fc3fd6f08b336617b4b6a17af11376
2011-07-01 21:11:34 +09:00
satok dec7703d9b Refactor settings
Change-Id: I2e0108ba429b477a07cfd53dcc664c0e43ff16a7
2011-07-01 19:43:09 +09:00
Tadashi G. Takaoka 7e7244873a Merge "Adaptive suggestions strip" 2011-06-30 08:52:04 -07:00
Tadashi G. Takaoka 74b6897a12 Adaptive suggestions strip
Bug: 4903845
Change-Id: I9e2e17a9eee72df5c92414dcd4796ed7fe1655e1
2011-07-01 00:46:34 +09:00
Ken Wakasa 9ae24750f4 Some clean up and fixes around auto-correction cancellation logic
Change-Id: I07f4c3cd98d14d9f0da2de54bfa76a3867389f6f
2011-06-30 18:35:17 +09:00
satok 284c32900b Merge "Show subtype settings preference for new design" 2011-06-28 22:10:20 -07:00
satok b9e56cde8b Show subtype settings preference for new design
Change-Id: I6164ab6ae3d97e2095778a4a6fd9f36c508af7b0
2011-06-28 21:33:17 +09:00
Tadashi G. Takaoka 670e1c6b71 Add visual debug mode
Change-Id: Ife131a398c0753b5b0e6e8969fe7bbc2a3bdab96
2011-06-28 19:13:52 +09:00
Tadashi G. Takaoka 660d42fb36 Remove mInForeground flag from KeyboardView
Instead of that, added cancelAllMessages() and call it from
onFinishInputView().

Change-Id: I58f6f0931ed8d73441d80d9616ba3afbbbe38e05
2011-06-28 01:00:59 +09:00
Tadashi G. Takaoka 55303bc634 Re-create input view after voice IME finished
Change-Id: Ia389eb43ac7ffec229bfd8b0fe56ce8271cb1d39
2011-06-27 23:46:15 +09:00
Tadashi G. Takaoka 7e9615f218 Fix NPE
Change-Id: Ia2c7d9e9298330ae991956fca64b225adaeff898
2011-06-27 22:54:18 +09:00
Tadashi G. Takaoka 281e180c33 Fix NPE
Change-Id: Ie4b8b657fc6cc5a819d4ea3a0ca4536e6fdf6825
2011-06-27 20:30:40 +09:00
Tadashi G. Takaoka b47319867e Show long suggestion in condensed and ellipsized text
Bug: 4903845
Change-Id: I75d58fb55f81594ebb2628ea21d00c2eb59fa70e
2011-06-27 20:17:08 +09:00
Tadashi G. Takaoka 717a8f50ae Use dedicated layout for "touch to save word" feature
Change-Id: Ie8c948476740a645d8b2d9a9d821236941d27adf
2011-06-27 18:04:22 +09:00
Tadashi G. Takaoka 7fb04fe007 Fix ragged suggestion strip baseline
Change-Id: I5fa9e2ad0993602e24f436e1d8ad0999209e5180
2011-06-26 02:07:07 +09:00
Ken Wakasa 4f0d290c5d Avoid memory leak by by non-static Handler inner classes
bug: 4901934
Change-Id: I870ab2e621ef3640a84468f09c074cdd726dc963
2011-06-26 00:14:40 +09:00
Jean Chalard 4f3d5d3733 Add a link from Latin IME to the dictionary pack.
The link only shows up if the dictionary pack is installed.

Bug: 1752028
Change-Id: I4af0a0a63324c155609710064a25df0deeb82b4d
2011-06-24 20:17:38 +09:00
Tadashi G. Takaoka 2442e77985 Display suggested word info in debug mode
Bug: 4686782
Change-Id: I0e5bef33aa39c3d6f75edda7818524965aa40b79
2011-06-24 14:19:59 +09:00
Alan Viverette 5ac4638f99 Added support for touch exploration to Latin IME.
Bug: 4379983
Change-Id: I97f22e54827c6229054b514801401ffa5b4ed3b8
2011-06-22 10:54:06 -07:00
Tadashi G. Takaoka a7eed902f1 Make CandidateView backward compatible
Up to version 10 (Gingerbread) of the API, FrameLayout doesn't handle
margin properly.  This change inserts RelativeLayout to FrameLayout as
placer to set margin and place children views absolutely.

Change-Id: Iee785bc2da77677738caf456bcd2bbf57b89f007
2011-06-22 20:16:21 +09:00
Tadashi G. Takaoka 0150be2a9b Merge "Use 2 arguments LinearLayout constructor" 2011-06-21 07:39:55 -07:00
Tadashi G. Takaoka f921129f9b Use 2 arguments LinearLayout constructor
To maintain backward compatibility back to Froyo, we can't call
3-argument constructor of LinearLayout.

Change-Id: I35310704f92812d2748d32f35820a5058fa2bf31
2011-06-21 22:09:19 +09:00
Tadashi G. Takaoka 839fb35f2b Merge "Support Turkish keyboard" 2011-06-21 02:40:42 -07:00
Tadashi G. Takaoka 35f20916e5 Support Turkish keyboard
I left TODOs in Suggest.java because we must pay attention to locale
when changing character's case. Filed another Bug: 4769095 to track
that.

Bug: 4768050
Change-Id: I1ae2c4ffd2208403a8c2a25dd3a56b71dcefc826
2011-06-21 17:50:17 +09:00
Tadashi G. Takaoka acd1a1c7a8 Add ArraysCompatUtils.binarySearch
Until API version 9, java.util.Arrays.binarySearch(int[], int, int,
int) doesn't exist.

Change-Id: Ife0ed4fbac642eda069e7b6f6b8dd30e0cd5fdee
2011-06-21 17:02:38 +09:00
Tadashi G. Takaoka 2951aa7e93 Fix NPE
NPE has occured while getting containerHeight in
LatinIME.onComputeInsets().

Change-Id: Ib906c20791a1f80a5c484a75eead9d2816a9da1b
2011-06-20 22:34:24 +09:00
Tadashi G. Takaoka 905a6cdcba Merge "Close dictionary appropriately" 2011-06-20 04:08:04 -07:00
Tadashi G. Takaoka 3439c72639 Close dictionary appropriately
The dictionary that extends ExpandableDictionary must be closed when
it becomes unused.

Bug: 4725930
Change-Id: Ib5d2c39771fb7010d303a26d1ea1c8e237c0101f
2011-06-20 20:06:54 +09:00
Tadashi G. Takaoka 5a2d063047 Remove unnecessary onRefreshKeyboard call.
When using the sliding spacebar language switch on ICS, both
LatinIME.toggleLanguage() and
InputMethodService.onCurrentInputMethodSubtypeChanged() invoke
LatinIME.onRefreshKeyboard().  This change eliminates the first one if
it isn't necessary.

This change also cleans up the followings.
  * reuse theme Context when the keyboard theme hasn't been changed.
  * clear the Keyboard cache when theme has been switched.
  * eliminates unnecessary Context reference from LatinKeyboard and
    SlidingLocaleDrawable.
  * recycle Bitmap and reuse Canvas in KeyboardView.

Bug: 4725930
Change-Id: I87366e9304879d94d12b7345adea768d86d43519
2011-06-20 19:21:31 +09:00
Tadashi G. Takaoka 5e4e05afd2 Fix NPE
Bug: 4686479
Change-Id: I0b8a32d0f9bcebe55eebecd38dc5e69198e94378
2011-06-18 23:43:58 +09:00
Tadashi G. Takaoka 8f5a3842e6 Merge "Disable showing TAB key when navigate flags are specified" 2011-06-17 05:27:35 -07:00
Tadashi G. Takaoka f0f726464d Disable showing TAB key when navigate flags are specified
Bug: 3094312
Change-Id: Ibbd36020c1e40daab220b588e6c190979afe7149
2011-06-17 21:13:35 +09:00
Tadashi G. Takaoka c78278bfb4 Temporarily disable displaying debug information
Should come up with the way to display the debug info again soon.

Change-Id: I20a01d1f03330cee05d4e52fd1ab622e315c87e9
2011-06-17 21:11:23 +09:00
Jean Chalard f844094e83 Merge "Small performance fix." 2011-06-16 04:29:21 -07:00
Tadashi G. Takaoka a61967330e Make LatinKeyboard aware of theme
Bug: 4436327
Change-Id: Idecdd470cbb0720b96958039eb11f6978d39629e
2011-06-16 20:10:49 +09:00
Jean Chalard 516f18f97e Small performance fix.
This improves performance by not allocating an iterator.

Change-Id: I5511fd8b8d3aa826917620c0af994dbaf1562bb1
2011-06-16 20:05:46 +09:00
Tadashi G. Takaoka 08a6f2aea7 Make CandidateView aware of theme
This change is needed to introduce new theme easily.

Bug: 4436327
Change-Id: Idc368b66d892d9c888ba7a26bfa3527c21678292
2011-06-15 20:02:45 +09:00
Tadashi G. Takaoka 862e05a8f0 Fix NPE in CandidateView.offsetMargin
Bug: 4609124
Change-Id: I14913afba80732e6beb8458b404001798a221a79
2011-06-15 10:48:53 +09:00
Tadashi G. Takaoka 86e815a142 Implement expandable candidates pane
This change removes horizontal scroll from candidates strip. Instead
of that this change introduces "fixed 3 items candidates strip" and
"expandable candidates pane".

Bug: 4175031

Change-Id: Ia367d9074436fdea76d3b653d81798ce2749170e
2011-06-14 20:40:56 +09:00
Jean Chalard 90cb2e6296 Merge "Add an option to use or not the contacts dictionary." 2011-06-13 01:48:00 -07:00
Jean Chalard 699094f9b6 Add an option to use or not the contacts dictionary.
Bug: 4586840
Change-Id: If62cd57e5ab661e6a51a5442d09bf0af8f08f263
2011-06-13 17:33:04 +09:00
Tadashi G. Takaoka 070760dc5a Clean up candidate strip view hierarchy
Bug: 4175031
Change-Id: I8073739ac7624d2c0a111c5ef7043d8766162a83
2011-06-13 15:12:23 +09:00
Tadashi G. Takaoka 8d828fc449 am bdbefac0: am 263749f2: am 37deb112: Fix IndexOutOfBoundsException
* commit 'bdbefac0b471e8a70c5d4958b8d1a345777d6bdb':
  Fix IndexOutOfBoundsException
2011-06-10 15:11:13 -07:00
Jean Chalard 35daf4007c Merge "Stop using raw e-mail addresses as names in contacts dict." 2011-06-10 02:34:05 -07:00
Jean Chalard 1ea78d92e6 Stop using raw e-mail addresses as names in contacts dict.
Bug: 4590281
Change-Id: I37016dd066efa1463077c67e05218148cbb67df4
2011-06-10 18:18:05 +09:00
Jean Chalard dc05c6650e Demote contacts frequency.
Bug: 4586840
Change-Id: I6dbef2d973174fc49c3955547dde923d6fa48ae1
2011-06-10 17:36:12 +09:00
Tadashi G. Takaoka 37deb112c7 Fix IndexOutOfBoundsException
Bug: 4586181
Change-Id: I10a2d1486c9a0d11aa42cf7c6a33ecd70b6918d7
2011-06-10 09:57:32 +09:00
Jean Chalard cb6d82da44 Merge "Enable reverting the auto-conversion of double space." 2011-06-08 22:39:49 -07:00
Tadashi G. Takaoka 91b9a6808c Merge "Introduce CandidateView.Listener" 2011-06-08 22:38:47 -07:00
Jean Chalard 4733609947 Enable reverting the auto-conversion of double space.
Bug: 3376923
Change-Id: If3fcfd208ad4a2b8a1452a21b07694d8d512c6ae
2011-06-09 14:27:40 +09:00
Tadashi G. Takaoka c97810693d Introduce CandidateView.Listener
Bug: 4175031
Change-Id: Ie84d1c86ff099350b786c71e7081d9ea9ee0d81f
2011-06-09 14:22:37 +09:00
Tadashi G. Takaoka e6d376298a Fix duplicate action next
Change-Id: I986528131a1dbe5926b8b6b2a6ffa75f48c5151a
2011-06-09 14:18:53 +09:00
Tadashi G. Takaoka 0143e11f11 Merge "Separate debug information display from candidate view" 2011-06-08 01:02:19 -07:00
Tadashi G. Takaoka 1e273fa6d1 Separate debug information display from candidate view
This change is one of the preparations for suggestion strip redesign.

Bug: 4175031
Change-Id: I82675936773ed6cf132a52486909ff21af828256
2011-06-08 16:59:37 +09:00
Ken Wakasa a88a5eddbc Revise hasMultipleEnabledIMEsOrSubtypes()
bug: 4559308

Change-Id: If831c0827dbf030eaf1d241ebfa60d4e5029ae63
2011-06-07 22:22:15 +09:00
Tadashi G. Takaoka f20eb55d4f Fix NPE introduced by Ia0dc487c
Bug: 4553273
Change-Id: Iaf7a969b2c96750070a296791108d67887d613e4
2011-06-07 12:30:28 +09:00
Tadashi G. Takaoka ddb61ea461 Separate candidate divider from candidate view
This change is one of the preparations for suggestion strip redesign.

Bug: 4175031
Change-Id: Ia0dc487c11c3005ef19b87ec0efcc18e48411f76
2011-06-06 18:21:08 +09:00
Jean Chalard 8fd75b3147 Add spell checking core methods.
Bug: 4176026
Change-Id: Ic6ea3e084b3ebacfc5fd998d2c7b0130f7b0ec48
2011-06-03 17:11:16 +09:00
Jean Chalard e93b1f2209 Allow reading a binary dictionary even without proximity info.
This prepares the way for spell checking, which is to be done
without context so without proximity info.

Bug: 4176026
Change-Id: I1b4bfaefe2611e1b484acdf3c33598cb80f81ff4
2011-06-02 12:10:13 +09:00
Jean Chalard 57c38bf4b0 Merge "Enable choosing a bigram prediction several times in a row." 2011-05-30 19:35:15 -07:00
Jean Chalard 41ec3ec2f3 Enable choosing a bigram prediction several times in a row.
This change fixes a bug that prevented to choose a prediction
several times in a row because the predictions would be replaced
right away by punctuations.
Please note several things about this change:
- Recorrection is pretty much in the middle of being refactored.
  This change has no effect on recorrection itself, but may make
  existing strange behavior more obvious when moving the cursor
  for example.
- The part of this change in Recorrection.java is not used in
  master at the moment because ongoing changes on recorrection
  result in the control never landing there, but would have been
  needed in the past and may be needed in the future.
- This change may have adverse effects on performance which need
  to be evaluated. A comment in the code has also been written
  to this effect.
- This does not fix bug 4466199, only addresses a pinpoint case
  of it to help evaluating the bigram predictions feature.

Bug: 4466199
Change-Id: I7219e5aeb74dff9251d12b2a72f94448dbb3e63f
2011-05-30 16:03:39 +09:00
Tadashi G. Takaoka a8fd3af67a Merge "Remove web mode and add webInput boolean" 2011-05-27 09:09:30 -07:00
Tadashi G. Takaoka 9e2d810dc5 Remove web mode and add webInput boolean
Bug: 4490948
Change-Id: I6fe23c9ab4918eab6806cc621c4d6821c2e1baf9
Cherry-Pick: I4cd1af0b
2011-05-27 21:47:14 +09:00
Jean Chalard f4a05624ee Merge "Stop promoting auto dictionary words to the user dict." 2011-05-27 03:26:30 -07:00
Tadashi G. Takaoka 38515ae577 Remove web mode and add webInput boolean (DO NOT MERGE)
Bug: 4490948
Change-Id: I4cd1af0b48d7ebcf8f4bd939e0e363e34dbfe8b7
2011-05-27 15:20:08 +09:00