nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
30,881 Commits
1 Branch
0 Tags
363 MiB
Commit Graph

30881 Commits (4aa83faea0a748d227be2c10bfadeac09d0a6e88)

Author SHA1 Message Date
Jean Chalard b8ff8ca9d9 Straighten out database cursors behavior. 
Some were never closed, other closed twice. This change
makes all Cursor instances behave, having the #close()
call in a finally{} clause, and puts the burden of closing
the cursor squarely on the creator rather than in the
called methods.
There is however one exception that is beyond the scope
of this change: UserDictionarySettings have a Cursor
member, it's never closed, and fixing the problem is not
obvious. This change adds a TODO for now.

It's not very clear if this change actually helps with
bug#12670151, but it may be related and it's a good
think to do anyway.

Bug: 12670151
Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
 2014-02-18 19:58:23 +09:00
Jean Chalard fe92c174ea Fix a bug where the cache would be out of sync 
During recorrection, the cursor position when calling
commitText is not necessarily at the end of the
composing text.
Besides, RichInputConnection assumes the cursor is
always after any composing text. This is not correct,
but in the practice, it seems all code paths work.
We should fix this in the future.

Bug: 13060691
Change-Id: I15f71fff62d36e80cf6e4a022c5e78af634b199d
 2014-02-18 19:55:54 +09:00
Jean Chalard db10e81973 am 783dabb8: Merge "Cleanup." 
* commit '783dabb812d983a7c56dbb1071145c5e58da9ff1':
  Cleanup.
 2014-02-18 01:56:57 -08:00
Jean Chalard 783dabb812 Merge "Cleanup." 2014-02-18 09:54:33 +00:00
Jean Chalard 63be066544 Cleanup. 
Less code, less chance of stuff escaping, and a bit of a clarification.
Yay.

Change-Id: I3193fd8ad7ac28195260cbc231c4e498a63a460c
 2014-02-18 17:07:46 +09:00
Ken Wakasa f2131ad92d am 266c8c5b: Merge "Some cosmetic fixes in LatinIME.java" 
* commit '266c8c5b1dbccbc4252fb79f042a4a5660c62763':
  Some cosmetic fixes in LatinIME.java
 2014-02-17 22:10:57 -08:00
Ken Wakasa 266c8c5b1d Merge "Some cosmetic fixes in LatinIME.java" 2014-02-18 06:08:34 +00:00
Ken Wakasa 12ff7da19d Some cosmetic fixes in LatinIME.java 
Change-Id: Ia2d04ab992f5a0cc736150b2691b2f8ae8f0955d
 2014-02-18 14:56:50 +09:00
Jean Chalard e0db1262b0 am db21fad1: Merge "Avoid crashing when the Content URL is not found." 
* commit 'db21fad18f70eb4abaf60a8c0ae7f285682acf20':
  Avoid crashing when the Content URL is not found.
 2014-02-17 21:37:51 -08:00
Jean Chalard db21fad18f Merge "Avoid crashing when the Content URL is not found." 2014-02-18 05:35:54 +00:00
Jean Chalard 9967f0a1d0 Avoid crashing when the Content URL is not found. 
I'm not sure when this can happen, but it seems it does
at least on older versions of the platform. Let's avoid
crashing.

Bug: 11618402
Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
 2014-02-18 14:27:58 +09:00
Baligh Uddin f923a3a7c1 am 0f8134dc: (-s ours) Merge "Import translations. DO NOT MERGE" 
* commit '0f8134dc40253d1e91d6d088cfd19c461cc1f53d':
  Import translations. DO NOT MERGE
 2014-02-17 21:01:16 -08:00
Baligh Uddin 0f8134dc40 Merge "Import translations. DO NOT MERGE" 2014-02-18 04:58:14 +00:00
Baligh Uddin 51ffdd3733 Merge "Import translations. DO NOT MERGE" into jb-ub-latinimegoogle 2014-02-18 04:58:08 +00:00
Ken Wakasa 7db82a711a am 0d32643e: Merge "Cosmetic fixes" 
* commit '0d32643e69dd75ba55ccca3c08d1478afb395125':
  Cosmetic fixes
 2014-02-17 19:30:19 -08:00
Ken Wakasa 0d32643e69 Merge "Cosmetic fixes" 2014-02-18 03:28:04 +00:00
Ken Wakasa 2312c1954f Cosmetic fixes 
Change-Id: I6c755565ba7689357d02d26cc0e92a93031953e8
 2014-02-18 12:17:24 +09:00
Tadashi G. Takaoka f6fb3e979f am cc05f468: Merge "Refactor InputAttributes a bit" 
* commit 'cc05f468ca2599e6efd7517f5f946152ed2ad3b7':
  Refactor InputAttributes a bit
 2014-02-17 18:27:20 -08:00
Tadashi G. Takaoka cc05f468ca Merge "Refactor InputAttributes a bit" 2014-02-18 02:25:46 +00:00
Baligh Uddin 3a73aa4182 Import translations. DO NOT MERGE 
Change-Id: I2025fbb4b811c98f520ec048e4df4973da651709
Auto-generated-cl: translation import
 2014-02-17 18:19:28 -08:00
Baligh Uddin 0f68ca6f03 Import translations. DO NOT MERGE 
Change-Id: I7d2af0a3e69dd9f20369163141e9c71c8c6505e9
Auto-generated-cl: translation import
 2014-02-17 18:18:34 -08:00
Baligh Uddin af78cea362 Import translations. DO NOT MERGE 
Change-Id: I2dc0e76dc4c696c1a7e9748b55e1badd273aea09
Auto-generated-cl: translation import
 2014-02-17 18:17:03 -08:00
Baligh Uddin 74aa40e0a2 Import translations. DO NOT MERGE 
Change-Id: Icd3f92273190c481f98e176097d933c2078dad9d
Auto-generated-cl: translation import
 2014-02-17 18:16:25 -08:00
Tadashi G. Takaoka b512946c90 am affdd364: Set neutral suggestions should be called after load settings 
* commit 'affdd364232549d2062fc180f924f5b6496c26fd':
  Set neutral suggestions should be called after load settings
 2014-02-17 18:12:12 -08:00
Tadashi G. Takaoka 06fbfc4951 Refactor InputAttributes a bit 
Change-Id: I43d65be6de64ba86f83e8528a138e20c4fa1e3ed
 2014-02-18 11:11:36 +09:00
Tadashi G. Takaoka affdd36423 Set neutral suggestions should be called after load settings 
Bug: 13058751
Change-Id: Iba49e86b90d595473d91753827d499e551dad45c
 2014-02-18 11:04:00 +09:00
Tadashi G. Takaoka 4d46767585 am f0f4e9fc: Update important notice version even when user select Settings 
* commit 'f0f4e9fc16f669f4499fb9de42362d8d52862ae2':
  Update important notice version even when user select Settings
 2014-02-17 07:30:37 -08:00
Tadashi G. Takaoka f0f4e9fc16 Update important notice version even when user select Settings 
Bug: 13060852
Change-Id: I463fdf3d51cacf99693fcde2998ea751046d1cc5
 2014-02-18 00:14:30 +09:00
Jean Chalard 5828d1f3fa am 782c9fee: Merge "Don\'t resume suggestion on links." 
* commit '782c9fee6bcb32d67c8ee9faa7e5c9dfb091afd3':
  Don't resume suggestion on links.
 2014-02-17 03:48:50 -08:00
Jean Chalard 782c9fee6b Merge "Don't resume suggestion on links." 2014-02-17 11:46:54 +00:00
Jean Chalard 7a7aeffcdc Don't resume suggestion on links. 
Bug: 11447084
Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
 2014-02-17 20:36:16 +09:00
Jean Chalard daf28b45a4 am d91cd991: Merge "Catch exceptions we can\'t do anything about." 
* commit 'd91cd9919e309e72f912f5cb135792351d7081ac':
  Catch exceptions we can't do anything about.
 2014-02-17 03:35:58 -08:00
Jean Chalard d91cd9919e Merge "Catch exceptions we can't do anything about." 2014-02-17 11:33:39 +00:00
Tadashi G. Takaoka 8a045cd6c3 am da0edf86: Merge "Stop overriding InputView.dispatchTouchEvent" 
* commit 'da0edf86c412194483ac84b9a0961573f8377583':
  Stop overriding InputView.dispatchTouchEvent
 2014-02-17 02:57:00 -08:00
Tadashi G. Takaoka da0edf86c4 Merge "Stop overriding InputView.dispatchTouchEvent" 2014-02-17 10:55:11 +00:00
Tadashi G. Takaoka 5cd732f8c5 Stop overriding InputView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: I950f13ec4084da7fd9c1c25fd7abed1e5d31ed4c
 2014-02-17 19:51:47 +09:00
Jean Chalard a149731a67 Catch exceptions we can't do anything about. 
This also abstracts away the "package deactivated" case for
simpler and safer code.

Bug: 11072561
Change-Id: Idaaf2ae8d8d5b2c4a15de641bbf2f8c5c7cc9410
 2014-02-17 18:49:31 +09:00
Jean Chalard 0eb6486d73 am 1e9897b0: Merge "Consider non-breaking spaces separators." 
* commit '1e9897b0c77b858ae479d531732b6795aaf0b2de':
  Consider non-breaking spaces separators.
 2014-02-17 01:46:40 -08:00
Jean Chalard d4cdbfe2bf am 2046bd6b: Merge "Make dotted i the base character of dotless i." 
* commit '2046bd6b850b35adc9c9d351ce134fdb560c8368':
  Make dotted i the base character of dotless i.
 2014-02-17 01:46:37 -08:00
Jean Chalard 1e9897b0c7 Merge "Consider non-breaking spaces separators." 2014-02-17 09:45:41 +00:00
Jean Chalard 2046bd6b85 Merge "Make dotted i the base character of dotless i." 2014-02-17 09:44:17 +00:00
Tadashi G. Takaoka fa00cf6536 am 891e4860: Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 
* commit '891e4860f838d3dbe139542d4a1172b3de7a5225':
  Stop overriding SuggestionStripView.dispatchTouchEvent
 2014-02-17 01:38:03 -08:00
Jean Chalard 220dc2d7a8 Make dotted i the base character of dotless i. 
This is already the case for the capital version, and natives
Turkish speakers seem to think it should be the case. An
important reason to make it so is that the Turkish keyboard
has only the dotless i as a "more keys" key, so it's really
hard to type words with a dotless i without this, especially
those with several of them.

Bug: 11519119
Change-Id: I4df2a289783e4eb3c1291b8ad0a2ba5947bf7671
 2014-02-17 18:24:28 +09:00
Tadashi G. Takaoka 891e4860f8 Merge "Stop overriding SuggestionStripView.dispatchTouchEvent" 2014-02-17 09:20:54 +00:00
Jean Chalard c051ee7025 Consider non-breaking spaces separators. 
Bug: 13056209
Change-Id: I6100b3ee21cf143140398757d9f7e7445067877a
 2014-02-17 18:20:46 +09:00
Tadashi G. Takaoka e32548f32d Stop overriding SuggestionStripView.dispatchTouchEvent 
Bug: 11721001
Bug: 11976254
Change-Id: Idfdeafe45abb16ca54be529b4f4b2c38c22a7fac
 2014-02-17 18:11:10 +09:00
Tadashi G. Takaoka bf723b081a am 1751615f: Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 
* commit '1751615f7d6702c6f3438a402e0ce179aafd15cf':
  Remove unnecessary override of MainKeyboardView.dispatchTouchEvent
 2014-02-17 00:29:04 -08:00
Tadashi G. Takaoka 93441101ac am 3dd6bdf9: Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 
* commit '3dd6bdf9312007ed43827975d121e972b98ab5e3':
  Add InputMethodSubtypeCompatUtils.isAsciiCapable()
 2014-02-17 00:29:01 -08:00
Tadashi G. Takaoka 1751615f7d Merge "Remove unnecessary override of MainKeyboardView.dispatchTouchEvent" 2014-02-17 08:26:38 +00:00
Tadashi G. Takaoka 3dd6bdf931 Merge "Add InputMethodSubtypeCompatUtils.isAsciiCapable()" 2014-02-17 08:25:57 +00:00