nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
3584 commits 1 branch 0 tags 363 MiB
Commit graph

1498 commits

Author SHA1 Message Date
Tadashi G. Takaoka
b58925ea0d Calculate x coordinate with floating point 
This change also fixes some keyboard layouts a bit.

Bug: 5245837
Change-Id: I5929e656763b150e71afe89238386904da214e21
 2011-09-02 17:05:24 +09:00
Tadashi G. Takaoka
3e0511e304 Merge "Move current x coordinate value into Row class" 2011-09-02 00:58:15 -07:00
Tadashi G. Takaoka
d3e50a2acf Squash SuggestionsStripParams into SuggestionsViewParams 
Bug: 5246982
Change-Id: Idc2563cb0175aabc4282f9fd45eefaa129ed4961
 2011-09-02 16:53:38 +09:00
Tadashi G. Takaoka
e84274ede1 Move current x coordinate value into Row class 
This is a preparation to address the issue.

Bug: 5245837
Change-Id: If5d463304c1689a840c8b761fedb0a8e2193734b
 2011-09-02 16:24:36 +09:00
Jean Chalard
5bb7a64fe2 Merge "Fix an NPE in settings" 2011-09-01 23:42:43 -07:00
Jean Chalard
ad56a9ac51 Fix an NPE in settings 
Change-Id: I264c001a9cc28f864ad024fcf51fb42e9c203d3f
 2011-09-02 15:35:23 +09:00
Jean Chalard
66a5884ad8 Merge "Add an option to prevent insertion of suggestion spans" 2011-09-01 22:57:39 -07:00
Jean Chalard
1531528bfe Add an option to prevent insertion of suggestion spans 
This is to help debug of
Bug: 5250788

Change-Id: I961321aff3776c4912eaf7a1fa4de0c01d715f24
 2011-09-02 14:43:13 +09:00
Tadashi G. Takaoka
1b087064c0 Dim keyboard when more suggestions are shown 
Bug: 5241009
Change-Id: Ia42bcfc34dddf93d35f9cea8a4f0efead6ce3a6a
 2011-09-01 18:48:19 +09:00
Tadashi G. Takaoka
913e2aeef2 Rename CandidateView to SuggestionsView 
Change-Id: I6480cdf025f065130e1969899b259a243e7a11be
 2011-09-01 15:41:34 +09:00
Jean Chalard
b17300e2f0 Merge "Fix a bug where autotext would occasionally not work" 2011-08-31 22:42:11 -07:00
Tadashi G. Takaoka
537e3d3696 Merge "Remove unused suggestions pane code" 2011-08-31 22:35:12 -07:00
Tadashi G. Takaoka
3a566c48b0 Remove unused suggestions pane code 
This is a followup for Ie1d69131.

Bug: 5023981
Change-Id: I42ec596af40cb7dcdd84b96ba5bff9ef1fb5dc92
 2011-09-01 14:28:59 +09:00
Tadashi G. Takaoka
d81479a340 Implement KeyboardLocale InputMethodSubtype extra key 
The locale is specified by KeyboardLocale extra key in method.xml,
LatinIME will use the specified locale for keyboard layout.

Bug: 5238658
Change-Id: I8e6cb66c73a7ac1bf611d9910b42fa9cff38eba0
 2011-09-01 14:05:01 +09:00
Jean Chalard
358e1327d8 Fix a bug where autotext would occasionally not work 
Autotext correction would check whether the first suggestion
so far was the same as what Autotext would return, and if it
was indeed the same, would not send its result as
autocorrect. However, the first suggestion is not guaranteed
to have a high enough score to trigger autocorrection, and
there would be cases where a word in autotext would not get
autocorrected because the word came out of bigram
suggestions. These occurrences would be extremely rare, as
they would require concomitant insert between autotext for
one char and bigram suggestion. It is, in fact, probably
limited to the capitalization of "I".

This did not happen in gingerbread because gingerbread would
not register 1-letter words as valid bigrams.

This fix works by just always sending the result of autotext
regardless of whether it is already the first suggestion or
not. This is okay because duplicates are removed afterwards
anyway - and this processing is absolutely necessary because
the autotext'd word may actually be somewhere else in the
suggestion, so it made really no sense checking for only the
first one.

Please note that there is also a race condition that can
result in "i" not being converted to "I": at the moment,
Latin IME relies on having the suggestions evaluated
at the time autocorrection is performed, but when typing
very, very fast, those messages may have been canceled.
This is not limited to the autocorrection of "i", but
affects all autocorrections. It requires a nearly
inhumane typing speed to trigger, but hitting "i" and
space in turn as fast as one can it's possible to
reproduce occasionally.

Bug: 5135113
Change-Id: I530ea6212487300001a2c0fc5b25a5c7716bdf63
 2011-09-01 12:59:17 +09:00
Tadashi G. Takaoka
fdec5c1a78 Merge "Implement popup suggestions pane" 2011-08-31 05:23:54 -07:00
Tadashi G. Takaoka
29e7b7ed6e Implement popup suggestions pane 
Bug: 5023981
Change-Id: Ie1d69131dbf884a3f6a2beb3ac3427e5437c1486
 2011-08-31 21:21:22 +09:00
Jean Chalard
0fd2135219 Merge "Fix a possible NPE" 2011-08-31 03:06:37 -07:00
Jean Chalard
a770d650b5 Fix a possible NPE 
Change-Id: I5c57752772414b4f9475d0ad43d7fc52b97c3f33
 2011-08-31 19:04:34 +09:00
Tadashi G. Takaoka
dcb1c7b802 Merge "Rename PopupCharactersParser to MoreKeySpecParser" 2011-08-31 02:39:03 -07:00
Tadashi G. Takaoka
9d5601e901 Rename PopupCharactersParser to MoreKeySpecParser 
Also renames PopupPanel to MoreKeysPanel

Change-Id: I37209a5a8fe7dbba1eef03e3be88ba5253653926
 2011-08-31 18:34:35 +09:00
Tadashi G. Takaoka
2fe9a43ab7 Merge "Remove unused XML attribute" 2011-08-31 00:14:55 -07:00
Tadashi G. Takaoka
79dc056d22 Remove unused XML attribute 
This is a followup for Ic83cd120.

Change-Id: Iecdcf28e2e07e1110c1b2974a9cb994ab2c0a769
 2011-08-31 16:08:25 +09:00
Jean Chalard
b29b225847 Merge "Clean up bigram settings" 2011-08-31 00:03:41 -07:00
Jean Chalard
18ccd552a8 Clean up bigram settings 
Move bigram suggestion option to the advanced settings screen,
remove bigram prediction option for ICS release and remove the
now-empty bigram option category.

Bug: 5240082
Change-Id: Ib1fc608ad33d5598410f7b0cb4a1639bffef28c7
 2011-08-31 15:41:13 +09:00
Tadashi G. Takaoka
0e7ee45f54 Merge "Rename PopupMiniKeyboardView to MiniKeyboardView" 2011-08-30 23:39:14 -07:00
Tadashi G. Takaoka
9237a72634 Rename PopupMiniKeyboardView to MiniKeyboardView 
Change-Id: Ic83cd1200cfb8f8c0b0cfbcad449031b8e8a29e0
 2011-08-31 15:30:54 +09:00
Jean Chalard
fcee70ea92 Merge "Check the magic number of a decoded file" 2011-08-30 22:58:29 -07:00
Jean Chalard
7a408431fe Check the magic number of a decoded file 
Checking the magic number of a file upon decoding is necessary,
because if the file is corrupt and we don't check it, we will
fall back to a simple copy of the corrupted file. Latin IME
would realize this and would not crash, but would not use the
corrupted dictionary. If this happened to be a main dictionary,
then the user would lose the ability to use the correct
built-in dictionary.

Not the same, but kinda similar to
Bug: 5223031

Change-Id: Ic2783dc9dd5f3dcf2865623d9452765fe3778db7
 2011-08-31 14:37:11 +09:00
Tadashi G. Takaoka
b8dc674663 Get rid of MeasureSpec.UNSPECIFIED 
Bug: 5023981
Change-Id: I14ded3c3d554ac72b66f190110652f54d91df954
 2011-08-31 14:15:20 +09:00
Tadashi G. Takaoka
241f1cfdf6 Add outputText and icon to the Key constructor 
This is a follow up change for I737bacb1.

Bug: 5023981
Change-Id: I980e3e993c81afe4fbdb95c9c263d7aa52aff66c
 2011-08-30 21:47:12 +09:00
Tadashi G. Takaoka
39cc806605 Merge "Cleanup keyboard related code a bit" 2011-08-30 03:40:37 -07:00
Tadashi G. Takaoka
c06d0ef01d Cleanup keyboard related code a bit 
Change-Id: I04f1014ab3b115bd457e25a267d2e46d306c8a0e
 2011-08-30 19:16:46 +09:00
Tadashi G. Takaoka
392276d73d Add Key constructor for suggestions pane 
Bug: 5023981
Change-Id: I737bacb1a6bb40f70be65d6eff85614afe6c79ed
 2011-08-30 19:14:52 +09:00
Tadashi G. Takaoka
84b1284d01 Revert "Add hintLabel to Key constructor" 
This reverts commit be34d97334.

Bug: 5023981
Change-Id: I34f75cde035f04a9a82c9259442ed0e255cb7118
 2011-08-30 18:40:21 +09:00
Tadashi G. Takaoka
be34d97334 Add hintLabel to Key constructor 
This change also partialy reverts I5832421c, because of incorrect
popup mini key width calculation.

Bug: 5023981
Change-Id: I1acde090c01d3d861fcc5559cad81e638de2c2bb
 2011-08-30 16:48:38 +09:00
Tadashi G. Takaoka
619f707c95 Fix another mismatched attribute in KeyboardView 
This is a followup of Iea7f8f34.

Bug: 5023981
Change-Id: I1135383ff0f0a2b8a5940d0d5c407fd01706a7f7
 2011-08-30 15:19:42 +09:00
Tadashi G. Takaoka
3e63fbe400 Fix mismatched attribute in KeyboardView 
This is a followup of Iea7f8f34.

Bug: 5023981
Change-Id: Ice6d949581aea7ca68799be2b91ff28234dd88d6
 2011-08-30 14:55:56 +09:00
Tadashi G. Takaoka
3b71e5fae6 Merge "Add keyLetterSize and keyLabelSize as KeyboardView attribute" 2011-08-29 08:13:29 -07:00
Tadashi G. Takaoka
83da6c18fb Add keyLetterSize and keyLabelSize as KeyboardView attribute 
Bug: 5023981
Change-Id: Iea7f8f340775cbb093c50d6e741b2f1476e9ac39
 2011-08-29 23:45:05 +09:00
Tadashi G. Takaoka
2315bfc7c8 Clean up some MiniKeyboard.Builder code 
Change-Id: I5832421cab3d496d4bb8a5e9902d0b5f4929fd0b
 2011-08-29 21:15:05 +09:00
Tadashi G. Takaoka
a9311741b8 Merge "Add KeyboardActionListener.Adapter" 2011-08-29 03:19:04 -07:00
Tadashi G. Takaoka
e3be3bcebc Add KeyboardActionListener.Adapter 
Change-Id: If13df42efffc7cef746c09d5abfe7a8619452a0b
 2011-08-29 19:09:56 +09:00
Jean Chalard
5406d63d34 Merge "Fix a bug with synchronicity of spell checking/user dict" 2011-08-29 02:55:46 -07:00
Tadashi G. Takaoka
46286874f3 Add guard to prevent possible IllegalStateException 
Bug: 5227682
Change-Id: Iff93b425f52981b5e2c65e309b07bcfe4485eeb1
 2011-08-29 18:38:04 +09:00
Jean Chalard
f019d505d7 Fix a bug with synchronicity of spell checking/user dict 
This fixes a race condition that would end up with the spell
checker not finding some words in the user dictionary when it
just booted.

Bug: 5194627
Change-Id: I1ba911cc53e6ae3b111d54a6f91d1d5feef3f5de
 2011-08-29 18:33:20 +09:00
Tadashi G. Takaoka
ed23cc7f0b Merge "Make PopupPanel decoupled with LatinKeyboardView and Keyboard" 2011-08-29 01:27:07 -07:00
Tadashi G. Takaoka
f44a01b408 Make PopupPanel decoupled with LatinKeyboardView and Keyboard 
Bug: 5023981
Change-Id: Ib4fd55d52718aa244178ca2313f5e8487378324f
 2011-08-29 17:07:48 +09:00
Jean Chalard
940514989a Merge "Move locale-related utility methods to LocaleUtils." 2011-08-28 20:34:02 -07:00
Jean Chalard
ef35cb631c Move locale-related utility methods to LocaleUtils. 
Change-Id: I7e9e6e5bc4486d8618d0213b112308c3d305c15e
 2011-08-29 12:29:35 +09:00
Tadashi G. Takaoka
85b4752270 Merge "Move debug information back to suggestions strip" 2011-08-26 04:07:00 -07:00
Tadashi G. Takaoka
013ba3e3e7 Move debug information back to suggestions strip 
Change-Id: I8cfad5f780a481a251cc4f752bff3cda5ae3ffbe
 2011-08-26 20:05:19 +09:00
satok
add3e05379 Do not put the suggestion span for obsolete suggestions. 
Bug: 5219037

Change-Id: I0300fbc7e1cc97f0f8ba4d21e0e699d9fe66ed76
 2011-08-26 19:12:18 +09:00
Tadashi G. Takaoka
7fe084a856 Merge "Fix "touch to save" colors" 2011-08-26 03:06:40 -07:00
Tadashi G. Takaoka
c04bbc1ae9 Fix "touch to save" colors 
Bug: 5218662
Change-Id: I094b2ceb7438148eb5bdf620b188f598e8442a07
 2011-08-26 18:55:36 +09:00
Tadashi G. Takaoka
f3f3189adb Wrap up popup mini keyboard 
Bug: 5218641
Change-Id: I88b3e7efa1f7c009c8a8e4f5453a5c4df2f91cfc
 2011-08-26 15:45:05 +09:00
Jean Chalard
de4e8dedcc Allow sharing dictionaries between similar locales. 
Bug: 5058488
Change-Id: Ib12013f58afad957a8205b439f87480cc12ea06f
 2011-08-25 19:42:06 +09:00
Jean Chalard
a16621ada4 Add a debug variable 
...that was missing

Change-Id: Ia3b17909f295e0a93dee633c8d67c0e03840023e
 2011-08-24 21:36:18 +09:00
Jean Chalard
20973de72b Avoid unnecessary output to the system log. 
The message this removes gets printed under normal conditions.
Normally dictionary files are compressed then crypted, but not
compressed a second time; however LatinIME tries to open a
compressed-crypted-compressed file first, because it could not
do it afterwards and we want to support this case. So under
normal operations, the first method LatinIME tries is actually
expected to fail.
Also, if we decide to stop compressing or/and encrypting dicts
LatinIME supports it as a valid use case. It should not print
errors to the log.

If the file cannot be open at all, then it is an unexpected
case, and Latin IME still reports to the log.

Change-Id: Ic5228c51365a101af1d03e2c893484d3050b5a1c
 2011-08-24 20:27:04 +09:00
Tadashi G. Takaoka
1d59e0dbdf Merge "Fix suggestions strip press state to align vertically" 2011-08-24 03:35:57 -07:00
Tadashi G. Takaoka
580e1d7ac0 Fix suggestions strip press state to align vertically 
This change also tweaks more_suggestions_hint drawables to eliminate
unnecessarily padding at the bottom.

Bug: 5204563
Change-Id: If5ec731c9a490da0116a020e8fd405c7d025d707
 2011-08-24 18:15:19 +09:00
Jean Chalard
38d512c0b2 Call the decrypt/unzip routines upon copying a dictionary. 
Bug: 5095140
Change-Id: I7000f752bc9b7fd6a7af4839b2f225c085300128
 2011-08-24 17:12:12 +09:00
Jean Chalard
8b21eb2507 Merge "Refactoring: cut out a method for caching a word list" 2011-08-23 23:17:31 -07:00
Jean Chalard
7b1f74bb9d Refactoring: cut out a method for caching a word list 
This is preparation to have the decrypting/unzipping code
moved over to LatinIME.

Bug: 5095140
Change-Id: Ic3fdcc3de673b46cef2eb9ebe6a52cbdd614e50a
 2011-08-24 15:09:57 +09:00
Tadashi G. Takaoka
fd47b5d09c Merge "Move some static methods from SubtypeSwitcher to Utils" 2011-08-23 22:39:51 -07:00
Tadashi G. Takaoka
af52c0ea04 Implement "forceAscii" private IME option 
This change also introduces "AsciiCapable" extra value for subtype
that indicates the subtype can input any ASCII code point from its
keyboard layout.

Only if the input field has "forceAscii" private IME option and the
current subtype doesn't have "AsciiCapable" extra value, the en_US
keyboard layout will be used for the input field.

Bug: 3384942
Change-Id: I25e2553e37ecb5002df1164e45f6273845fe463b
 2011-08-24 13:19:56 +09:00
Tadashi G. Takaoka
57f05f4412 Move some static methods from SubtypeSwitcher to Utils 
Change-Id: I3ea8ffcdefcefaa82ae76a31bb65977009d8a040
 2011-08-24 12:54:53 +09:00
Jean Chalard
1616e2e96e Merge "Fix an excessive fallback problem." 2011-08-23 02:12:17 -07:00
Tadashi G. Takaoka
c84bc3460d Rename LatinKeyboardBaseView to LatinKeyboardView 
Bug: 5182291
Change-Id: I5089a14902b9f4ff1ab4f34e3f7a42aca5040d3e
 2011-08-23 17:57:02 +09:00
Jean Chalard
0ee3b69483 Fix an excessive fallback problem. 
LatinIME has several fallbacks to ensure a dictionary is used.
However, it should now be possible to deactivate the main dictionary
through the dictionary pack settings. In this case, Latin IME should
not fallback to the built-in dictionary.

Change-Id: Ibd992ad89793169f04a968b40781fce819b87b6f
 2011-08-23 17:55:46 +09:00
Tadashi G. Takaoka
32572948d7 Refactor and rename popup mini keyoard related classes 
Change-Id: Ia92ec4612090b03829db9a87ce68d701db6e15bc
 2011-08-23 17:51:57 +09:00
Tadashi G. Takaoka
2d306a225c Merge "Extract sudden jumping touch event hack into separate class" 2011-08-23 01:49:38 -07:00
Tadashi G. Takaoka
c403a46f6d Extract sudden jumping touch event hack into separate class 
Bug: 5182291
Change-Id: I6a88ed4df3ec98e31ea4966d82da56f7fca342ac
 2011-08-23 17:44:41 +09:00
Tadashi G. Takaoka
2b27f3e698 Merge "Remove password field special handling" 2011-08-23 01:29:11 -07:00
Tadashi G. Takaoka
f9da4c548f Remove password field special handling 
Change-Id: Iaf1b4bbb54be7a4cade856d1ba363e976774f442
 2011-08-23 16:49:35 +09:00
Tadashi G. Takaoka
0940093c30 Merge "Remove screen orientation confirmation hack" 2011-08-23 00:39:19 -07:00
Jean Chalard
d6834c8125 Merge "Fix a bug with the string pool." 2011-08-22 23:05:51 -07:00
Tadashi G. Takaoka
f94df382fb Remove screen orientation confirmation hack 
Bug: 4311428
Change-Id: Ie7e094ded9c7c1fe811b7eb97bc33ffecb29a73c
 2011-08-23 14:58:45 +09:00
Jean Chalard
a6e912cf98 Fix a bug with the string pool. 
This also adds some optional debug code to detect more easily possible
future occurrences of the same problem.

Bug: 5195017
Change-Id: I2558b468e46f7090de868f1ec2dc9e24895d670f
 2011-08-23 14:55:34 +09:00
Tadashi G. Takaoka
6dde878d51 Move some methods from LatinKeyboardView up into LatinKeyboardBaseView 
Bug: 5182291
Change-Id: I699ecef6fb8ea492d96fca1939f51faf0aac7fa6
 2011-08-23 12:22:24 +09:00
Tadashi G. Takaoka
9f31575045 Merge "Fix suggestions strip text colors" 2011-08-22 03:32:05 -07:00
Tadashi G. Takaoka
d47a955610 Fix suggestions strip text colors 
This change also shows the valid typed word in bold face.

Bug: 5161713
Change-Id: I15355a11888fc8ef90ecc8b64a52eb08c1a2b367
 2011-08-22 18:56:54 +09:00
Jean Chalard
70a92a33f8 Merge "Remove duplicates from the spell checker suggestions." 2011-08-22 02:49:33 -07:00
Jean Chalard
6b166a1933 Remove duplicates from the spell checker suggestions. 
Bug: 5175740
Change-Id: I592401b3b8c3074d70e06dc3a9919cc3cb47ba49
 2011-08-22 18:44:04 +09:00
Tadashi G. Takaoka
b39f612d97 Remove hacks related to determine window width 
Bug: 4311428
Change-Id: Ic93f264101d13963503fcd447a69bbffd06e69f3
 2011-08-22 17:17:42 +09:00
Jean Chalard
5d4c5692f1 Fix case sensitivity for the spell checker. 
The new behavior is as follows:
- If the word in the dictionary is not fully lower case, then the
exact case is required to match.
- If the word in the dictionary is fully lower case, then any of
the following patterns match:
  - fully lower case
  - only the first char capitalized
  - all caps
Any other capitalization is rejected.

This is probably what people want. If you type a name in all lower
case, it should be marked as a typo, but if you type a word with a
capital for emphasis or just because it's the start of the sentence,
it should match a lower case word in the dictionary. If you have
a spurious capital letter in the middle of a word because of a typo,
it should be marked as such.

Accents are not affected, and should not be. An accented letter
is a different letter and a missing accent should be reported.
We should maybe consider again for some common transpositions
like the "ue" digraph for German, which is now considered a typo,
but will suggest the correct diacritics as the first suggestion.

Bug: 5145751
Change-Id: I651e24f13c90fb94700a1674ad380e95336e7dca
 2011-08-22 14:02:57 +09:00
Ken Wakasa
cee174b8cc Settings key visibility should always follow the system default value, 
by ignoring its preference value, when the "show settings key option" in
the settings is disabled.

Change-Id: I934be2d9eb0bf6bf731e03f5d9b752de4a7a1c7c
 2011-08-22 12:21:25 +09:00
Jean Chalard
6da8b74582 Move the dupes-removing method to the Utils class 
This is preparation for bug: 5175740

Change-Id: I18b2042317f740cb1e021d3dfbf90ecfbb1a1d37
 2011-08-19 19:49:59 +09:00
Jean Chalard
150bad6fd4 Have the spell checker use the User dictionary. 
Bug: 5175868
Change-Id: I165eee4c865caa5ee1daf3e0b1acde8788b996ef
 2011-08-19 17:19:49 +09:00
Jean Chalard
1e841de2ce Merge "Check the main dict id to be able to fallback." 2011-08-18 19:55:16 -07:00
Ken Wakasa
e56e88beff A follow up to I830de4d1 
bug: 5130446
Change-Id: Ib1a4603590387c30be7555b8386f5e0607ea7249
 2011-08-18 21:51:04 +09:00
Jean Chalard
ee7daefd97 Check the main dict id to be able to fallback. 
Bug: 5095140
Change-Id: I02032923ca2a65bd8fbabc0abbe6a476f7542187
 2011-08-18 20:09:35 +09:00
Jean Chalard
89fdb82753 Merge "Move the settings test to a more appropriate place." 2011-08-18 03:39:08 -07:00
Jean Chalard
83207fb482 Move the settings test to a more appropriate place. 
This change refactors the dictionary selection code so that the
cached dictionary files list and the settings tests are more
cleanly separated.
This will also help with future refactorings that will test for
the presence of the main dictionary and insert the fall back if
it's not supplied by the dictionary pack.

Bug: 5095140
Change-Id: I8d7caad7c054031df71fe78b043801a774d50f65
 2011-08-18 19:35:52 +09:00
Jean Chalard
4e01afc520 Make the string builder pool in Suggest a singleton. 
This is internal refactoring, done as preliminary work to fix
Bug: 5175740

Change-Id: I21bd4c001c27e7b925ddb87a152105b4dcab320a
 2011-08-18 18:41:57 +09:00
Jean Chalard
5ba5ff9b80 Merge "Exception refactoring" 2011-08-18 02:36:42 -07:00
Jean Chalard
03c3b64ee5 Merge "Refactor string removal to make it static" 2011-08-18 02:36:32 -07:00
Jean Chalard
3016863f86 Refactor string removal to make it static 
The next step is to move this over to the Utils class.
The ultimate goal is to make use of the duplicate removal code
also in the spell checker as per
Bug: 5175740

Change-Id: Ica36691b843b0713b832c56ffc65e5b2ec427c4a
 2011-08-18 15:16:59 +09:00
Jean Chalard
80e0bf0429 Exception refactoring 
Now that the dictionary pack can return several files, it's better
to handle IO exceptions for each file rather than globally. This
also will help with next implementation steps.

Bug: 5095140
Change-Id: I5ed135ad2ad4f55f61f9b3f92c48a35d5c24bdb2
 2011-08-18 15:11:19 +09:00
Jean Chalard
091bbf85d8 Merge "Factor dict pack settings reading into a static inner class" 2011-08-17 19:34:31 -07:00
Jean Chalard
c11c4fd61b Factor dict pack settings reading into a static inner class 
This is essentially refactoring to help next steps

Bug: 5095140
Change-Id: Ic97044d2ed354027bac4f84e6ce69d20ef6da092
 2011-08-17 11:25:21 +09:00
Tadashi G. Takaoka
961453c3b3 Merge "Get rid of auto correction flash animation in the suggestion strip" 2011-08-16 18:49:36 -07:00
Ken Wakasa
e486175987 Merge "Fixed speaking keys when editing password fields" 2011-08-16 18:45:26 -07:00
Tadashi G. Takaoka
bea6b72106 Get rid of auto correction flash animation in the suggestion strip 
This change also reverts I1350ad3d.

Bug: 5156762
Change-Id: I047e75699e8eea02204ad95e12dcc0aefe49ac34
 2011-08-16 17:47:23 -07:00
Tadashi G. Takaoka
5cb10f78ed Fix possible NPE 
Bug: 5171442
Change-Id: I280f6a0ef5fb06f1e03e17c0065d078604e4747a
 2011-08-16 17:36:13 -07:00
Jean Chalard
c160373b6a Close dictionary pools when they are not used any more. 
Bug: 5156851
Change-Id: Icaba54734eb790b40dc2012aac25df5b2af71dbb
 2011-08-16 20:04:57 +09:00
Jean Chalard
29ea7b79c7 Merge "Have a pool of dictionaries to check spelling." 2011-08-16 03:05:50 -07:00
Yusuke Nojima
dbf4f2a552 Merge "Pass the touch event in the top padding of keyboard." 2011-08-16 03:04:30 -07:00
Yusuke Nojima
5ec13092a5 Pass the touch event in the top padding of keyboard. 
Bug: 5139932
Change-Id: Id176f92f69160f76ae7e0d46cb3d639080779497
 2011-08-16 18:33:40 +09:00
Jean Chalard
a562767a14 Have a pool of dictionaries to check spelling. 
The dictionaries and proximities are not thread-safe. In order to
be able to check spelling in parallel, make a dictionary pool to
call upon when a spelling check is necessary.

Bug: 5156851
Change-Id: Ie3796164187dd7b7abf5ccd5d014073d43d74408
 2011-08-16 18:13:12 +09:00
Ken Wakasa
f18bda60aa Code cleanup 
Change-Id: I7df8c813038adec750eda260740bcc8a4da41acf
 2011-08-16 17:32:37 +09:00
Jean Chalard
70b9c5d991 Make the spell checker re-entrant. 
Until the dictionary itself is re-entrant, unfortunately we have
to synchronize accesses to it.

Bug: 5156851
Change-Id: I1629a160d707e6fa1ad80cba828798abb24b68b1
 2011-08-16 13:58:37 +09:00
Yusuke Nojima
8f7f406c5b Merge "Add a margin between "123" and the mic icon." 2011-08-15 18:17:48 -07:00
Yusuke Nojima
35775197aa Add a margin between "123" and the mic icon. 
Bug: 5161711
Change-Id: I04c777c24b9aac4d82eb3adff8e077640a866f61
 2011-08-16 10:07:34 +09:00
Ken Wakasa
e8bbc54e74 Merge "Update shift state in onSizeChanged()" 2011-08-15 04:12:24 -07:00
Ken Wakasa
286a5bf1c6 Update shift state in onSizeChanged() 
bug: 5130446
Change-Id: I830de4d184dffa2b263206c3f078de054e227b9e
 2011-08-15 20:10:28 +09:00
Jean Chalard
7674f869dc Remove the "Touch to correct words" option. 
Bug: 5113009
Change-Id: Idc4a464e499a2530f517bf7fa449326779129371
 2011-08-15 16:38:00 +09:00
Jean Chalard
ab791d0bbc Revert "Remove the "Touch to correct words" option." 
This reverts commit 8e69dd80d8

...since it breaks the build
 2011-08-14 23:49:01 -07:00
Jean Chalard
8e69dd80d8 Remove the "Touch to correct words" option. 
Bug: 5113009
Change-Id: Iae8a64e22cf618f4533f966feaf0b5a76725d551
 2011-08-15 15:02:51 +09:00
Ken Wakasa
bb5504c47d Merge "Get rid of auto correction flash animation in the suggestion strip" 2011-08-12 07:19:50 -07:00
Ken Wakasa
59f5cc8572 Get rid of auto correction flash animation in the suggestion strip 
bug: 5156762
Change-Id: I1350ad3d7125f8ecdfc699233ed05e253cc3f010
 2011-08-12 23:14:34 +09:00
Jean Chalard
b6b7d81f5d Merge "Add a settings activity for the spell checker." 2011-08-12 03:11:33 -07:00
Jean Chalard
31fd54c53f Add a settings activity for the spell checker. 
Bug: 5156940
Change-Id: I762de1296f861abce2d0413404bca54571e0ea0a
 2011-08-12 19:07:51 +09:00
Jean Chalard
86e517fe4a Read shared prefs from the dictionary pack. 
Bug: 5095140
Change-Id: I227fbd95d8a0330b6dede6de99fde3a5a715fe2d
 2011-08-12 17:31:24 +09:00
Ken Wakasa
7fca6a5357 Merge "Key click sound volume fix" 2011-08-11 10:06:49 -07:00
Ken Wakasa
bf7dd47329 Key click sound volume fix 
bug: 5145886
Change-Id: Ic599373ee17423ef9c61b3dd5177c3763aa31015
 2011-08-12 02:02:03 +09:00
Jean Chalard
08868624ed Use the dictionaries cached LatinIME-side 
Dictionaries are now copied over from the dictionary pack to Latin IME.
This change enables Latin IME to use all dictionaries that have been
cached until now.

Bug: 5095140
Change-Id: Id9a2bacf9dc1c693189b0ac8aa3f75756dc1e3e6
 2011-08-11 18:15:39 +09:00
Jean Chalard
2896673461 Rename a function and update a comment 
Bug: 5095140
Change-Id: Idf66a04c6a1a05015f94187a8dbce3d443bbf38b
 2011-08-11 17:07:28 +09:00
Jean Chalard
f102f6a3ac Merge "Give the orders to delete the source files to the dict pack" 2011-08-10 21:54:27 -07:00
Jean Chalard
5774908bb3 Give the orders to delete the source files to the dict pack 
Bug: 5095140
Change-Id: I64552861768ca30073ffe0d631b2e0c44dad4aa9
 2011-08-10 21:55:15 +09:00
Luca Zanolin
c359d75ca7 Merge "Execute the switching to a different IME in a POOL_EXECUTOR." 2011-08-10 04:17:53 -07:00
Luca Zanolin
613073d01b Execute the switching to a different IME in a POOL_EXECUTOR. 
Using only a single thread may slow down the application, if there is already another thread running.

Bug: 5142142
Change-Id: I314480a58af20ea09458ff82e586304fc3c7c070
 2011-08-10 10:29:06 +01:00
Jean Chalard
d4c08d9be3 Make sure the directory where to put files actually exists 
Bug: 5095140
Change-Id: I764471e54ce0bf6aefe5d604cee97639d5ad0af9
 2011-08-10 17:14:34 +09:00
Ken Wakasa
11b7febc0b Ellipsis for "Space" key for triggering the IME switcher 
bug:5136497
Change-Id: Iab7c68135500e9fed212521484090b52943550ca
 2011-08-10 00:31:23 +09:00
Jean Chalard
f098fbbef3 Add proximity info for the spell checker. 
Bug: 5119987
Change-Id: I35700fd8b0ffa6bced428cc6d46b3f64eb251281
 2011-08-09 17:24:28 +09:00
Jean Chalard
3a22708e65 Have Latin IME copy files from the dictionary pack. 
Also some minor cleanup: remove unused methods, minor refactoring into methods.

Bug: 5095140
Change-Id: I035537b37a31adfc8db3b933fb0cefcf703d6c7c
 2011-08-09 16:02:14 +09:00
Jean Chalard
14051e2b53 Stop reloading contacts when not appropriate. 
A recent change had the contacts reloaded every time a new field
is touched. This change not only fixes the problem, but also removes
reloading contacts when changing language, which should make language
switch within LatinIME lighter.

Bug: 5125034
Change-Id: Ia61c4f75a8617113cdce88a2e2c6fdf073146a2d
 2011-08-09 12:49:19 +09:00
Alan Viverette
58e3f1065e Fixed speaking keys when editing password fields 
Bug: 5042681
Change-Id: Ic4523ec38b0faa2b6a91d476ea7af7e69404861c
 2011-08-08 11:05:04 -07:00
Ken Wakasa
44beeab4a4 Merge "Fix issues with long-press access to more suggestions" 2011-08-08 04:37:09 -07:00
Ken Wakasa
bbf25cf251 Fix issues with long-press access to more suggestions 
Change-Id: If5a45dcae7f7e7881d305104e35a04c341719aec
 2011-08-08 20:33:44 +09:00
Ken Wakasa
ad7ddca397 Merge "Correction mode should not rely on the existence of the main dic" 2011-08-08 04:24:05 -07:00
Ken Wakasa
c769ef4dd1 Correction mode should not rely on the existence of the main dic 
bug: 5114094
Change-Id: I2088918ec2c9ad6f8db13b55e58d3e73e180aef8
 2011-08-08 19:42:24 +09:00
Tadashi G. Takaoka
ae5c736e37 Remove suggestion pane controller from strip 
This change also removes speacebar LED to represent auto correction.

Bug: 5023981
Change-Id: Idedaabd147ed608df35cb51769388578a05174a1
 2011-08-08 00:15:49 -07:00
Ken Wakasa
20c4aec827 Partially revert I531a3257 as it mistakenly broke some logic -- textToTheLeft was required. 
Change-Id: I24f55cec05fea68836d6b3413b69f1e1b9c68ba2
 2011-08-06 22:37:45 +09:00
Tadashi G. Takaoka
6983cf4a19 Merge "Remove all key preview from placer when window gets hide" 2011-08-06 00:59:03 -07:00
Ken Wakasa
cadb2128f5 Fix issues with long-pressing the spacebar 
bug: 5114433
Change-Id: I18f2147724a08965147bafe93e11fc86c7c59d33
 2011-08-06 16:49:32 +09:00
Tadashi G. Takaoka
1149abd876 Remove all key preview from placer when window gets hide 
Bug: 5130302
Change-Id: I70e3737c33bfbac99366ab36d3437b0801f5140a
 2011-08-05 23:33:51 -07:00
Tadashi G. Takaoka
60a004f78e Fixed count suggestions strip 
Bug: 5023981
Change-Id: I434d23bdfb653989866d3822c978cd929a2b553c
 2011-08-05 19:25:36 -07:00
satok
5bcf8ee66c Update the spell checker according to API cleanup 
Change-Id: Ia95a63963c16265bc9bc7e1fcecf120e17bf8636
 2011-08-05 19:57:47 +09:00
Tadashi G. Takaoka
fd047f61e4 Merge "Move suggestions layout code into parameter class" 2011-08-04 23:57:31 -07:00
Tadashi G. Takaoka
94ac3d760b Fix NPE 
Bug: 5120674
Change-Id: Iedfd7af33a96b68d83d9a844f61ac40b9523ecdb
 2011-08-04 09:40:25 -07:00
Tadashi G. Takaoka
16713e5630 Move suggestions layout code into parameter class 
Bug: 5023981
Change-Id: I30f45191524c38bfe550845b003e8972abd2ee49
 2011-08-04 09:26:37 -07:00
Jean Chalard
3234123fba Implement the spell checker. 
Bug: 4176026
Change-Id: I297c47202e96ce0db74d703f30709777f26b93ac
 2011-08-04 21:27:14 +09:00
Jean Chalard
ac21e0a349 Merge "Create a way to pass the proximity info to the dictionary" 2011-08-04 04:17:33 -07:00
Jean Chalard
043f784198 Create a way to pass the proximity info to the dictionary 
This is a preparative change for inserting the spell checker.

Change-Id: Ie441879cac4f67078ec27a95f1fcbbf3ef373df7
 2011-08-04 19:46:21 +09:00
Tadashi G. Takaoka
80ba224fff Merge "Cleanup CandidateView class" 2011-08-04 01:19:55 -07:00
Tadashi G. Takaoka
d95a6365be Cleanup CandidateView class 
Bug: 5023981
Change-Id: Id79e31c60dfb41be546f5c5a3680e8651457151d
 2011-08-04 01:14:55 -07:00
Ken Wakasa
3aacd1d7d8 Merge "Additional hack for bug:4311428, a follow up for Ieade33d7." 2011-08-03 23:34:12 -07:00
Ken Wakasa
de30f9f2d6 Additional hack for bug:4311428, a follow up for Ieade33d7. 
Change-Id: If1799a6fa3b2f45c98c9f3aeb88845f1fb08f09b
 2011-08-04 15:31:33 +09:00
Jean Chalard
8289dede0a Merge "Remove newly unused code" 2011-08-03 22:47:27 -07:00
Jean Chalard
09e91ee072 Remove newly unused code 
Bug: 5095140
Change-Id: Ie4322815f029f063dda2925697d6d8f63bfaf6d6
 2011-08-04 13:53:24 +09:00
Ken Wakasa
3889462439 Handle non word separators correctly even for the initial letter of a word 
bug: 5101114
Change-Id: I0d804c9a500ff000dc06cadad46a2c6c6b8088b2
 2011-08-04 12:24:45 +09:00
Tadashi G. Takaoka
bb12dc455b Merge "Fix saving keyboard state while rotating" 2011-08-03 15:15:59 -07:00
Tadashi G. Takaoka
99debd7519 Merge "Reset keyboard shift lock state when new keyboard is ready" 2011-08-03 15:08:28 -07:00
Tadashi G. Takaoka
38b5605fee Fix saving keyboard state while rotating 
This change also uses longer timeout for restoring keyboard state.

Bug: 4311428
Change-Id: Ieade33d7c69f1dee727b2b8c26f0112eca44b336
 2011-08-03 09:41:04 -07:00
Tadashi G. Takaoka
73c02390d3 Reset keyboard shift lock state when new keyboard is ready 
Bug: 5099761
Change-Id: I00ad796ea43a07ae13e71224b7a081ee2f160f1a
 2011-08-03 09:24:13 -07:00
satok
e486290013 Merge "Temporary don't use "looks type" for comming rename cl." 2011-08-03 03:24:48 -07:00
satok
55d1c5efab Temporary don't use "looks type" for comming rename cl. 
Change-Id: If016a61f9e303b615c59c0035724256535aec817
 2011-08-03 18:42:56 +09:00
Tadashi G. Takaoka
eedfef0308 Merge "Retain keyboard layout while orientation change" 2011-08-03 02:37:00 -07:00
Tadashi G. Takaoka
055054eef3 Retain keyboard layout while orientation change 
This change also changes the timimng that the window width is
registered.

Bug: 4311428
Change-Id: Ied6b1b43bfa16a85f0e05cd308ce919d5d65677e
 2011-08-03 02:20:27 -07:00
Tadashi G. Takaoka
a0ac590c8d Merge "Support label with icon key" 2011-08-03 01:56:24 -07:00
Tadashi G. Takaoka
62d4a96497 Support label with icon key 
Bug: 5108339
Change-Id: I7cd4258a95a7e25b8b1114b43ffcca5b77c5c1e3
 2011-08-03 01:53:30 -07:00
Ken Wakasa
21fa416c43 Revive the missing Settings key on tablets 
This is a follow up change to Ieb42fdfa.

bug: 5094401
Change-Id: If78c966ed02fbc9b8c6da726e00424a927349142
 2011-08-03 17:00:14 +09:00
Jean Chalard
81f227de5a Merge "Change the dictionary file passing schema to a list of ids" 2011-08-02 21:02:11 -07:00
Tadashi G. Takaoka
1be29abab2 Cleanup Keyboard related code and rename some classes 
This is	a follow up change of I90ffbde0

Bug: 5023981
Change-Id: I3a6b862d05f5f907dee954cd6d6fee983b20ab5e
 2011-08-02 17:12:02 -07:00
Jean Chalard
fae8d60ee9 Change the dictionary file passing schema to a list of ids 
The dictionary filename used to be passed directly to Latin IME.
This change implements, on the part of Latin IME, the passing of
them as an id that should then be passed through
openAssetFileDescriptor.

Bug: 5095140
Change-Id: I7d1e9d57c19f0645045368f68681680f238189fc
 2011-08-02 19:16:39 +09:00
Tadashi G. Takaoka
8da9a13760 Make Keyboard object immutable except shift state 
This is the first step to implement suggestions pane as mini keyboard.

Bug: 5023981
Change-Id: I90ffbde0fda19b4be68add449310997b56bf6904
 2011-08-01 22:04:48 -07:00
Tadashi G. Takaoka
8d7782bf3c Merge "Use generic interface for filed type of Keyboard" 2011-08-01 18:12:58 -07:00
Tadashi G. Takaoka
04bc5a369c Merge "Add KeyboardParams class" 2011-08-01 18:08:17 -07:00
Tadashi G. Takaoka
167e77f170 Use generic interface for filed type of Keyboard 
This change also re-orders and renames some fields.

Bug: 5023981
Change-Id: I28c1ca7384bb70e3584398cd19ce2276ddfe8541
 2011-08-01 17:58:02 -07:00
Tadashi G. Takaoka
4d8eb2e888 Make horigontalGap and verticalGap attributes of Row obsolete 
Bug: 5023981
Change-Id: Ifb07b54a68cfdd32ff2ea79812188fb6158bd073
 2011-08-01 17:45:16 -07:00
Tadashi G. Takaoka
1516d055df Add KeyboardParams class 
This object will hold all keyboard parameter while parsing XML file
and act like a Keyboard. After finishing reading XML file, this will be
passed as an argument for the Keyboard class constructor.

Bug: 5023981
Change-Id: I2737b30036b6e4d204e8ed9984a1272e195209be
 2011-08-01 17:41:30 -07:00
Tadashi G. Takaoka
723dd753e9 Remove Keyboard reference from Key object 
Bug: 5023981
Change-Id: Ib0b9debf2018a0a9e9efe9323738e85174589e71
 2011-08-01 17:07:45 -07:00
Tadashi G. Takaoka
30479de9e5 Merge "Cleanup key label case adjustment" 2011-08-01 17:04:09 -07:00
Tadashi G. Takaoka
c499866948 Cleanup key label case adjustment 
Bug: 5023981
Change-Id: Ida06fc6a588c4eb8543455d932e71ac2797d27e5
 2011-08-01 16:43:14 -07:00
Tadashi G. Takaoka
b118d4cb58 Cleanup icon drawable related code 
Bug: 5023981
Change-Id: I729354f32797eef354ec9af8e05f17839f0a361c
 2011-08-01 16:37:13 -07:00
Jean Chalard
cb1cc0d0de Merge "Try to compensate for a race condition." 2011-08-01 04:17:22 -07:00
Jean Chalard
f2f9715319 Try to compensate for a race condition. 
This does not really fix the underlying bug, but it does fix
the apparent symptoms.
When the user presses space and a letter quick, the
onUpdateSelection handler may be called after the letter has been
actually committed. The keyboard then happily proceeds to clearing
the composition because it thinks space was pressed (or the user
moved the cursor, since it can't guess which happened).
This change removes this behavior when we are expecting an update
event from a keypress. This means the bug still exists if the user
presses space twice and a letter, and all events come after the
letter, but it is very very hard to reproduce this. There may be
other collateral damage when the user moves the cursor in the form
of race conditions, but likewise, they should be really hard to
reproduce.

Bug: 5100521
Change-Id: Ib05328c9b451bf6fe288ae00296fd283a9a4e863
 2011-08-01 19:51:55 +09:00
Tadashi G. Takaoka
271e55fe53 Merge "Filter non-ascii popup charcters from password keyboard" 2011-08-01 01:32:48 -07:00
Tadashi G. Takaoka
2fe68b9616 Filter non-ascii popup charcters from password keyboard 
Change-Id: I10885efd317770f892165b6bb059313abf241436
 2011-08-01 00:35:59 -07:00
Ken Wakasa
9351550dc6 Clean up revertLastWord() 
The "deleteChar" argument of this method is acutally always true in the current code path.
Also, in this method, textToTheLeft virtually never has a punctuation letter as its initial
character.  This change is one of preparatory changes for bug:4983945.

Change-Id: I531a32570a35634c21c1d74b2b461e40a1b7f660
 2011-08-01 16:03:43 +09:00
Tadashi G. Takaoka
c3afe2c244 Replace the notion of "voice" with "shortcut" as many as possible 
Bug: 4340933
Change-Id: I98b4eca5167cc3767a0868fae8f6436164adbe4d
 2011-07-31 18:46:44 -07:00
Tadashi G. Takaoka
83f6ca10d4 Merge "Fix exception message" 2011-07-31 18:43:22 -07:00
Tadashi G. Takaoka
2afc2adb01 Merge "Eliminate "..." from the key that has no popup mini keyboard automatically" 2011-07-31 18:43:17 -07:00
Tadashi G. Takaoka
09430720d5 Fix exception message 
Bug: 4340933
Change-Id: I81e7b0c72116b5bb56b0fdcd02386288aebd73e7
 2011-07-31 18:40:58 -07:00
Tadashi G. Takaoka
0c6e57f2d1 Eliminate "..." from the key that has no popup mini keyboard automatically 
Bug: 4340933
Change-Id: I08bbdee71f4bc2285fd0c1233d284150be61748e
 2011-07-31 18:22:29 -07:00
Tadashi G. Takaoka
73e716f202 Be aware of "nm" and "noMicrophoneKey" private IME option 
Bug: 4340933
Change-Id: I787108a73d4450963d644bc7070ae1672ebb4455
 2011-07-31 18:20:20 -07:00
Ken Wakasa
2ba975afb9 Turn off the Settings key by default 
bug:5094401
Change-Id: Ieb42fdfa79be2afcfa6634e7404c17737ef6927d
 2011-07-31 07:26:24 +09:00
Tadashi G. Takaoka
97c35650ad Dismiss key preview regardless of key preview settings 
Bug: 5099213
Change-Id: Id6c5cb0ae4a07897b34153d4b350b1b45a06aa1a
 2011-07-29 19:52:49 -07:00
Tadashi G. Takaoka
364f1fd1f8 Add WindowWidthCache 
Bug: 4311428
Change-Id: I9f006525c0932d9d49bb8655caf58523135366d7
 2011-07-29 18:43:50 -07:00