Commit graph

4528 commits

Author SHA1 Message Date
Keisuke Kuroyanagi
3c801be5e5 Merge "Fix unit tests by adding @UsedForTesting." 2014-03-28 06:08:37 +00:00
Keisuke Kuroyanagi
aa7abb2d89 Fix unit tests by adding @UsedForTesting.
Change-Id: I8497d6cf446297bc8c15e9d9818078b1026a8c51
2014-03-28 15:02:00 +09:00
Tadashi G. Takaoka
f173b12b03 Merge "Stop displaying locale string on short space bar" 2014-03-28 04:49:17 +00:00
Tadashi G. Takaoka
2202d47386 Stop displaying locale string on short space bar
Bug: 12070355
Change-Id: I2d6fa20431bc56d5139caeac33e396b73906d075
2014-03-28 13:05:13 +09:00
Keisuke Kuroyanagi
30cd0cd2a0 Fix: NPE after onDestroy().
Bug: 13671513
Change-Id: I06aa14870ff5422ad514356ee406600b247858c5
2014-03-28 12:17:44 +09:00
Jean Chalard
080e0253ae Merge "Revert "[CB15] Remove a redundant variable."" 2014-03-27 09:44:31 +00:00
Jean Chalard
f459ccf4f6 Merge "Revert "[CB16] Remove unused stuff"" 2014-03-27 09:44:24 +00:00
Jean Chalard
75715f7d9f Revert "[CB15] Remove a redundant variable."
This reverts commit 0de7a6d1a2.

Change-Id: I327679b76a14cf9c3aec4b00b013b921408c32f9
2014-03-27 09:43:45 +00:00
Jean Chalard
26baa759d8 Revert "[CB16] Remove unused stuff"
This reverts commit 05c46f59fd.

Change-Id: Ica0feea10fff1b2a9ef42bc55cb7c1892b3a3f58
2014-03-27 09:43:21 +00:00
Jean Chalard
5154c47cbe Merge "[CB16] Remove unused stuff" 2014-03-27 08:52:11 +00:00
Jean Chalard
5feda45a6f Merge "[CB15] Remove a redundant variable." 2014-03-27 08:05:23 +00:00
Jean Chalard
05c46f59fd [CB16] Remove unused stuff
Bug: 13406701
Change-Id: Ib863c5181e1f5d74cfa4458060afc49d1ee8109e
2014-03-27 16:47:30 +09:00
Jean Chalard
0de7a6d1a2 [CB15] Remove a redundant variable.
This is a tiny bit slower, but probably unnoticeable.
Still, it gains some performance in other places,
saves memory, and more importantly makes for simpler
code, so it's certainly better.

Change-Id: Id1ab4f73f71acd73f5920bc729817abd22cf0d07
2014-03-27 16:47:27 +09:00
Keisuke Kuroyanagi
6008898b99 Merge "Move code only used for dicttool and tests under tests." 2014-03-27 06:37:10 +00:00
Keisuke Kuroyanagi
93cda5bb39 Move code only used for dicttool and tests under tests.
Bug: 13035567
Change-Id: I13c6df013ef2b67c9bf67455d9c32d283bf9ea2e
2014-03-27 15:30:32 +09:00
Keisuke Kuroyanagi
3c38e1f269 Merge "Fix: NPE in isValidWord after dictionaries are closed." 2014-03-27 03:12:07 +00:00
Keisuke Kuroyanagi
7b516d496d Fix: NPE in isValidWord after dictionaries are closed.
Bug: 13650542
Change-Id: I1bdc838fca48d6ef12db5e70d40273d1236128d1
2014-03-27 12:03:58 +09:00
Jean Chalard
071b9c1a05 Merge "[CB14] Implement backspace in the combiner chain" 2014-03-25 10:46:32 +00:00
Jean Chalard
1079665c3c [CB14] Implement backspace in the combiner chain
Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc
2014-03-25 17:57:03 +09:00
Keisuke Kuroyanagi
adfb262797 Remove logic related to dictionary loading from LatinIME.
Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.

Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
2014-03-25 15:35:20 +09:00
Yohei Yukawa
f1f5ed542d Check null before passing to Integer.parseInt
Just after user data is cleared, user preference associated with
PREF_KEYBOARD_LAYOUT is always empty. In such case, we might
want to return the default value immediately, rather than
calling Integer.parseInt(null) and catching NumberFormatException
unnecessarily.

BUG: 13472379
Change-Id: I8dca9a22780d057013c032bd1f56e730dcada3ce
2014-03-24 20:54:03 +09:00
Jean Chalard
d36cbc44e4 [CB13] Remove an unused method.
Change-Id: If4d2fa9c6499ce9b2427cea424abd497ec4a966b
2014-03-24 17:44:36 +09:00
Jean Chalard
cbed462d19 [CB12] Reset the combining state when resetting the composer
Bug: 13406701
Change-Id: I490574b7ca4b953f67dd2c0ef97401297fade0a4
2014-03-24 17:44:31 +09:00
Jean Chalard
7f0e5fa66c Merge "[CB11] Get the result of the combination" 2014-03-24 05:33:34 +00:00
Jean Chalard
1dda9107ca Merge "Rework the logic that tells if the cursor touches words" 2014-03-20 14:35:19 +00:00
Jean Chalard
835965a75e [CB11] Get the result of the combination
Change-Id: I165ec4a24f5b1334d55c14948e4d942ec40eb33b
2014-03-20 23:33:12 +09:00
Jean Chalard
72b67f6541 Rework the logic that tells if the cursor touches words
Bug: 13312942
Change-Id: I6be6a558bbc6c88508150f9c25cadbd0240ff88e
2014-03-20 23:16:53 +09:00
Jean Chalard
4df6bc0853 Merge "[CB10] Add an event for string input" 2014-03-20 11:34:16 +00:00
Jean Chalard
058a38988b [CB10] Add an event for string input
Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
2014-03-20 19:47:01 +09:00
Keisuke Kuroyanagi
7c20f140e0 Merge "Remove unused partial commit." 2014-03-20 09:54:15 +00:00
Keisuke Kuroyanagi
5a0381f7d0 Remove unused partial commit.
Change-Id: Ia9341a5cb24947d93056810890d94c1f66481d8c
2014-03-20 18:47:45 +09:00
Jean Chalard
437dbbcfee Merge "[IL127] Move the double space countdown to InputLogic" 2014-03-20 09:07:49 +00:00
Tadashi G. Takaoka
aacfa31c8e Merge "Remove reference of KeyboardTextsSet from SpacingAndPunctuations" 2014-03-20 08:46:11 +00:00
Tadashi G. Takaoka
44f144ab3a Remove reference of KeyboardTextsSet from SpacingAndPunctuations
Change-Id: I76a8fcbd2466bcaf9cd85501af270db5aa913999
2014-03-20 17:14:43 +09:00
Jean Chalard
f2bb15b0ab [CB09] Pass events through the combiner chain
Bug: 13406701
Change-Id: I4696f145478afdd132314b7d3c148c3a9ca11c9c
2014-03-20 16:59:29 +09:00
Jean Chalard
7ede642df4 [CB08] Create a combiner chain in the word composer.
Bug: 13406701
Change-Id: I3b9f75de9283f76366d1bef7e14a8f22f2186669
2014-03-20 14:27:55 +09:00
Tadashi G. Takaoka
f96bffa69e Suppress important notice when its title message is empty
Bug: 13422608
Change-Id: Ied16e87381e82d8539269ddd90d737f80c2a94c0
2014-03-20 11:48:28 +09:00
Tadashi G. Takaoka
14e908c348 Remove unused argument in SuggestionStripLayoutHelper
Bug: 13461039
Change-Id: I3f6227bd56fb81021aaacf0e901eab8a9e91d4a1
2014-03-20 11:06:55 +09:00
Jean Chalard
350d73932d [IL127] Move the double space countdown to InputLogic
Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
2014-03-19 17:47:03 +09:00
Jean Chalard
554346e94c [IL126] Move a setting value to SettingsValues
Bug: 8636060
Change-Id: I7cb082df13a10cf5a3aa5786e6a9599376652dee
2014-03-19 17:47:03 +09:00
Jean Chalard
46e17983c6 [IL125] Remove arg to onPickSuggestionManually
Bug: 8636060

Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
2014-03-19 17:47:03 +09:00
Tadashi G. Takaoka
1325ddbae3 Merge "Guard possible NumberFormatException" 2014-03-18 07:26:18 +00:00
Tadashi G. Takaoka
d2c6151d4d Guard possible NumberFormatException
Bug: 13472379
Change-Id: Ib7640b3d8816d8d7fb4747d2288eedd94bc49b06
2014-03-18 15:40:43 +09:00
Jean Chalard
1110adad11 [CB07] Small refactoring
Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
2014-03-17 21:26:36 +09:00
Jean Chalard
5eac728b4a [CB06] Fix a design error.
The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.

For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.

Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
2014-03-17 20:49:29 +09:00
Jean Chalard
5a1e351751 Merge "[CB04] Add an event array to WordComposer." 2014-03-14 04:29:59 +00:00
Jean Chalard
f8accd8839 [CB04] Add an event array to WordComposer.
Bug: 13406701
Change-Id: I9ecd2709c8f1c678a85b0cfaf7c5ed4f78459821
2014-03-14 12:44:49 +09:00
Tadashi G. Takaoka
a9c1a3da63 Fix clipped important notice message on tablet
Bug: 13461039
Change-Id: I710bf10c9cbc202c7f6ee39ab4c8b9d699741a81
2014-03-14 12:32:38 +09:00
Jean Chalard
750cd48981 [CB03] Pass whole events to the various input logic handlers.
Bug: 13406701
Change-Id: I0a0e4e0b3357f116e1b915c548dee4575e300c92
2014-03-13 19:35:54 +09:00
Jean Chalard
a79a3265db [CB02] Pass an Event to onCodeInput.
Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
2014-03-13 18:41:02 +09:00