Jean Chalard
05ea7c5d02
am 167ba345
: am 89fe1f50
: Add a method to work around apps broken by recorrection
...
* commit '167ba3459b0ce02b9add12ade9388bd2b1e6eb62':
Add a method to work around apps broken by recorrection
2013-05-20 21:10:07 -07:00
Satoshi Kataoka
10e8b93977
Fix a crash on a secondary user
...
Bug: 9054063
Change-Id: I092ab6e0077578d0aca57d2e41dfbc00b46e1ba4
2013-05-21 12:27:16 +09:00
Keisuke Kuroyanagi
adf82a97a9
Fix running on device regression test and profile.
...
Change-Id: Ie16d9514092d6d6f42881b975420e5d1431b776c
2013-05-20 20:14:13 -07:00
Tadashi G. Takaoka
a66396369b
Merge "Remove unnecessary @UsedForTesting annotation"
2013-05-21 03:07:59 +00:00
Jean Chalard
0013f97ddd
am 5906b05b
: am 7058b02a
: Extract a new class for app-specific workarounds.
...
* commit '5906b05bb50c0a67bd4f03fcfae41db3daefe0bc':
Extract a new class for app-specific workarounds.
2013-05-20 19:50:46 -07:00
Tadashi G. Takaoka
2532f72b94
Remove unnecessary @UsedForTesting annotation
...
Change-Id: I843fd6bc20da95e61d1a05b5b34d6e4c9db59dab
2013-05-21 10:45:59 +09:00
Jean Chalard
89fe1f5088
Add a method to work around apps broken by recorrection
...
Bug: 8944307
Change-Id: I8986622554f30aaf4f595099c4ab5652b75c972c
2013-05-21 07:53:31 +09:00
Jean Chalard
7058b02a9c
Extract a new class for app-specific workarounds.
...
Bug: 8944307
Change-Id: Iaff9dd03d3d856a6bdaa2b16c4e71e95cd2b6349
2013-05-21 07:53:28 +09:00
Kurt Partridge
500dea6ad4
Fix punctuation logging
...
Punctuation is currently put into the same LogUnit as the
following word. This is counter-intuitive and makes
post-processing more complicated.
This change causes punctuation to be put into its own
LogUnit.
A tricky case is the phantom space. A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.
Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
2013-05-17 09:47:40 -07:00
Kurt Partridge
17b63ba588
Merge "Remove unnecessary commit/uncommit"
2013-05-15 23:52:43 +00:00
Kurt Partridge
7af5300c7d
Merge "Add claifying comment"
2013-05-15 23:31:31 +00:00
Jean Chalard
b1e37e4a47
am f1dcf725
: Merge "Don\'t process recorrection or resets when not shown"
...
* commit 'f1dcf725061b3e61e40540566a5385cf4934f424':
Don't process recorrection or resets when not shown
2013-05-15 07:58:27 -07:00
Tadashi G. Takaoka
25f0c8089e
am 96a9f357
: Merge "Fix unintentional setup step advance in orientation change"
...
* commit '96a9f357c7e2a059687926cd7cd52ac5d06bc65e':
Fix unintentional setup step advance in orientation change
2013-05-15 07:58:18 -07:00
Tadashi G. Takaoka
7fe675440e
am 769427cf
: Adjust aspect ratio of setup image
...
* commit '769427cff24944958f5f1f6179090a86444f3eab':
Adjust aspect ratio of setup image
2013-05-15 07:57:38 -07:00
Jean Chalard
f1dcf72506
Merge "Don't process recorrection or resets when not shown"
2013-05-15 11:25:25 +00:00
Jean Chalard
c9aaba1253
Don't process recorrection or resets when not shown
...
Bug: 8954116
Change-Id: Ica27dbfc570643bb81e6cdf34cc7c796ea080d71
2013-05-15 20:20:20 +09:00
Tadashi G. Takaoka
9b4a883e09
Fix unintentional setup step advance in orientation change
...
Bug: 8159728
Change-Id: I53e7d7c8fb5cc231ea94474b091e550f77ae8dab
2013-05-15 19:50:35 +09:00
Tadashi G. Takaoka
769427cff2
Adjust aspect ratio of setup image
...
Bug: 8159728
Change-Id: I578014912fa63c4c9b4c2c89aeae7ffec836b06c
2013-05-15 14:48:27 +09:00
Kurt Partridge
993acbaaa2
Remove unnecessary commit/uncommit
...
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word. Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.
But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command. This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now. Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.
Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
2013-05-14 12:20:27 -07:00
Kurt Partridge
7b0a148951
Merge "Rename a var to match semantics"
2013-05-14 16:11:07 +00:00
Kurt Partridge
3e8df13cd7
Add claifying comment
...
This is a follow-up to I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
Change-Id: I9e3f8968c4bbf9525d5dfe101f71373c42f88361
2013-05-14 09:10:22 -07:00
Kurt Partridge
b2d53be740
Merge "Remove FeedbackLog instance variables."
2013-05-14 13:09:33 +00:00
Tadashi G. Takaoka
8b56ad7814
Merge "Revise welcome screen video and still image"
2013-05-14 12:01:47 +00:00
Tadashi G. Takaoka
7348d9fb72
Revise welcome screen video and still image
...
Bug: 8159728
Change-Id: Ief8d7197879d24ccef529e975c23d6f11c7aa458
2013-05-14 20:56:09 +09:00
Ken Wakasa
d6d70e7325
Merge "Revert "Fix isSuggestionsStripVisible when keyboard hidden""
2013-05-14 11:46:04 +00:00
Ken Wakasa
3efa36f6aa
Revert "Fix isSuggestionsStripVisible when keyboard hidden"
...
This reverts commit cb0d1c4c58
Change-Id: Ie2c8e01c25bd051b6157e8f32ab84392a0c7252a
bug: 8954116
2013-05-14 11:44:22 +00:00
Tadashi G. Takaoka
41016acacf
Back to previous keyboard layout by canceling sliding input
...
Bug: 8915171
Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
2013-05-14 20:28:03 +09:00
Tadashi G. Takaoka
c9398a3b39
Merge "Fix PointerTrackerQueue.releaseAllPointerOlderThan"
2013-05-14 06:53:15 +00:00
Tadashi G. Takaoka
979fb7415b
Fix PointerTrackerQueue.releaseAllPointerOlderThan
...
Change-Id: If353869720895ee5355079c15c724132762dd70c
2013-05-14 15:32:21 +09:00
Jean Chalard
cb0d1c4c58
Fix isSuggestionsStripVisible when keyboard hidden
...
When the keyboard is hidden, the suggestion strip is
never visible.
Bug: 8954116
Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
2013-05-14 15:19:19 +09:00
Kurt Partridge
6fefc142cf
Remove FeedbackLog instance variables.
...
For a while, the ResearchLogger supported comprehensive recording of the
last few words in case the user wished to upload this data to give
developers feedback. However, this mechanism was not implemented well
(keeping a separate copy of the data), did not make the collected data
clear to the user, and was not working properly in the latest build (NPEs).
The mechanism in fact was deprecated in favor of the "userRecording"
mechanism in which the user explicitly turned on comprehensive recording,
demonstrated the issue they were experiencing, and then turned it off.
This change removes the vestiges of the FeedbackLogging mechanism.
A feedback log is still used to hold the user's message, but it is created
in a local variable as-needed, and not persisted in ResearchLogger.
Change-Id: I6a09d0ed36e1eddb6e57895e7428d22107f75f49
2013-05-13 20:37:15 -07:00
Kurt Partridge
b5c39f4531
Rename a var to match semantics
...
The IS_INHIBITING_AUTO_UPLOAD flag is tested in isPossibleToUpload, so it inhibits all uploads, not
just automatic ones. Renaming to IS_INHIBITING_UPLOAD.
Change-Id: Iceed79260d4b062147f40c09f0c5bb06b2519b1b
2013-05-13 17:01:39 -07:00
Tadashi G. Takaoka
b121538e0c
Tune maximum keypress duration to 100 milliseconds
...
Bug: 8556975
Change-Id: If7839c5764f7a269243a9570c0b7782b6f7ee73b
2013-05-13 20:04:59 +09:00
Tadashi G. Takaoka
5f857a359a
Merge "Disable functional key while in sliding input mode"
2013-05-13 10:50:32 +00:00
Tadashi G. Takaoka
e3b1bdc4f1
Disable functional key while in sliding input mode
...
This change registers the functional key when sliding input mode is
end at the functional key itself.
Bug: 8915171
Change-Id: I2031e2aa4ebf33684221fc44d4a808112489724f
2013-05-13 19:39:57 +09:00
Tadashi G. Takaoka
b5f67e7faf
Add device specific keypress vibration duration database
...
Bug: 8556975
Change-Id: I11260a64dc13c102bac7a9742dc66f2b05fd32de
2013-05-13 18:34:48 +09:00
Tadashi G. Takaoka
6b0bcfba9b
Merge "Disable long press timer while sliding input mode"
2013-05-13 08:57:56 +00:00
Tadashi G. Takaoka
43ad100d8b
Disable long press timer while sliding input mode
...
Bug: 8915171
Change-Id: Id8685f90766c7de55b56476de83abf97150a186d
2013-05-13 17:40:26 +09:00
Tadashi G. Takaoka
ad662adeef
Disable delete key repeating while in slide input mode
...
Bug: 8915171
Change-Id: I04f84c29f10abc0207072d2165c75dd20f053f92
2013-05-13 17:23:08 +09:00
Tadashi G. Takaoka
18184eacb1
Support regular expression for condition pattern
...
Bug: 8556975
Change-Id: Iffc53d6a40dd77860434c5f7f4f59af5cd1ba92b
2013-05-13 16:25:03 +09:00
Tadashi G. Takaoka
ec83457d72
Merge "Support multiple condition for getDeviceOverrideValue"
2013-05-13 06:13:20 +00:00
Tadashi G. Takaoka
d69fa0a09a
Support multiple condition for getDeviceOverrideValue
...
Bug: 8556975
Change-Id: I29d3a305b6ac3d8e3620c6d8592d85047d62bf48
2013-05-13 14:38:21 +09:00
Ken Wakasa
cb3bba3c4e
Rename GesturePreviewTrail.java -> GestureTrail.java
...
Try reducing some confusions between GesturePreviewTrail.java and GestureTrailsPreview.java
Change-Id: I5fe2ee740cf1b32210530188153f6f6937e34b68
2013-05-13 13:42:22 +09:00
Kurt Partridge
7d72ca0b20
Avoid JsonWriter multi-write error
...
JsonWriter requires that its clients pass it only a single top-level object.
The existing implementation tries to make code cleaner by having mJsonWriter
never be null, and instead use a global static "NULL_JSON_WRITER" that just
discards data. But because JsonWriter complains if more than one top-level
object is passed, making this a global object does not work. This change
instead copes with mJsonWriter being null.
Change-Id: Ia37ccfc8646e91f11a64713dd92d2846eb86ac54
2013-05-10 18:21:08 -07:00
Kurt Partridge
260df84197
Merge "Remove unused code"
2013-05-10 22:12:11 +00:00
Kurt Partridge
bb17034f64
Merge "Remove ref to LatinImeLogger preference."
2013-05-10 20:41:52 +00:00
Kurt Partridge
4135c2db7b
Merge "Avoid NPE by fixing ResearchLogger initialization"
2013-05-10 15:48:04 +00:00
Tadashi G. Takaoka
565ced4546
Merge "Refactor StringUtils.findPrefixedString to findValueOfKey"
2013-05-10 09:49:07 +00:00
Tadashi G. Takaoka
6d3d2ae064
Refactor StringUtils.findPrefixedString to findValueOfKey
...
Bug: 8556975
Change-Id: I275c99db8a0d10594a5a8c0c27ebc1a87495c307
2013-05-10 18:44:04 +09:00
Tadashi G. Takaoka
4705c0fa7c
Fix screen flash when launching settings activity
...
Bug: 8336068
Change-Id: I90a0f259129a3f3319b158b060154cc43960c234
2013-05-10 15:36:24 +09:00
Tadashi G. Takaoka
2b5c9726f4
Introduce another activity to launch setup wizard
...
Bug: 8336068
Change-Id: I35b94dd87c5b01d3e927da8f918a5398dd565d33
2013-05-10 15:30:53 +09:00
Tadashi G. Takaoka
5ffa5bf3ba
Merge "Keep SetupActivity alive to check re-launching from launcher"
2013-05-10 06:24:52 +00:00
Tadashi G. Takaoka
9ed322b40f
Keep SetupActivity alive to check re-launching from launcher
...
Bug: 8336068
Change-Id: I183b8e3fd1b3898d5f8dbbb13a0c93c64341fc38
2013-05-10 15:15:53 +09:00
Jean Chalard
2564bd0937
Merge "Reuse old preferences if possible."
2013-05-10 05:56:32 +00:00
Jean Chalard
a2ec5e8338
Reuse old preferences if possible.
...
This is an optimization. It also happens to work around what
seems to be a framework bug in JB MR1 / MR1.1.
Bug: 8771179
Change-Id: I62cc7acdc8656d75f8a50c068c4e9d8c6ceb74a0
2013-05-10 14:41:36 +09:00
Tadashi G. Takaoka
2ad7023c54
Fix detecting out of keyboard area
...
Bug: 8885165
Change-Id: I85c78b23955169972fb0f5395463b6fe47f12c9c
2013-05-10 12:16:44 +09:00
Kurt Partridge
a68cace7d1
Avoid NPE by fixing ResearchLogger initialization
...
Previously, mMainResearchLog and mMainLogBuffer were set up
when the user moved to a new TextView, and set to null when
the user left the TextView. This change causes
mMainResearchLog, mMainLogBuffer, mFeedbackLog, and
mFeedbackLogBuffer to be non-null forever after init() is
called. start() no longer sets up these fields; instead
they are cleared and reset every time stop() is called.
Checks for null values are now removed.
The earlier code just didn't initialize these variables if
the user disabled logging, but since the new version
invariantly keeps these variables valid, we add a check for
whether the user has enabled logging in publishLogUnits().
Change-Id: Ifde3517f1cf924cfa33cda95fec24529b52b3c08
2013-05-09 18:38:32 -07:00
Kurt Partridge
011634163c
Remove unused code
...
Change-Id: I192c67e9e8de44f073abc70ec85ebcdb36356c2e
2013-05-09 14:36:40 -07:00
Kurt Partridge
ef5d760ca4
Remove ref to LatinImeLogger preference.
...
This is a bug; the ResearchLogger uses ResearchSettings.readResearchLoggerEnabledFlag() instead,
which the user cannot change. (We assume they will just switch to a different keyboard.)
Change-Id: Ib5731c9eeb2bc29d9cf8608033326674f5eb6f7b
2013-05-09 14:36:40 -07:00
Satoshi Kataoka
341f1b237b
Tweak gesture debug
...
Change-Id: Iea11a095adb15fbf4be38f34542119f8bc7bcbff
2013-05-09 20:08:50 +09:00
Satoshi Kataoka
52cb409ac2
Don't resize debug array if production
...
Bug: 8556775
Change-Id: I46a10f8dc938cab493933f0f2b4e1f7779b24f6f
2013-05-09 19:22:24 +09:00
Satoshi Kataoka
b2c4c73064
Add debug facilities for gesture
...
Bug: 8556775
Change-Id: I9069b2b44356bbae9fa4aaf0b99c3d723a8c9c58
2013-05-09 19:19:11 +09:00
Satoshi Kataoka
b902109000
Fix usages of getEnabledInputMethodSubtypeList
...
Bug: 8450279
Change-Id: Ib8433442ae6ca6c28da2652bff687cdeaf7c196e
2013-05-09 17:07:19 +09:00
Jean Chalard
71d52474fd
Merge "Optimizations and safeguards."
2013-05-08 10:11:49 +00:00
Satoshi Kataoka
eab27c1ef6
Merge "Add account e-mail addresses to the user dictionary"
2013-05-08 09:53:54 +00:00
Jean Chalard
9f9cc03277
Optimizations and safeguards.
...
- Don't call finishComposingText when useless.
- Add safeguards against calling setComposingRegion when the
data returned by the editor is inconsistent.
- Cancel pending recorrection messages when new messages arrive.
Bug: 8842941
Bug: 8845001
Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
2013-05-08 18:47:10 +09:00
Tadashi G. Takaoka
5b8b76baa3
Merge "Move gesture preview trail parameters to resource"
2013-05-08 09:02:52 +00:00
Satoshi Kataoka
5648054667
Add account e-mail addresses to the user dictionary
...
Bug: 8683365
Change-Id: Id72540c515e61c3dd854892599645dd6d22b496d
2013-05-08 17:58:21 +09:00
Tadashi G. Takaoka
05124d0193
Move gesture preview trail parameters to resource
...
Bug: 7167303
Change-Id: I22b56588dc5a1c9d5eaec3a39b5f32c9e5a8a5b4
2013-05-08 17:51:45 +09:00
Satoshi Kataoka
faa94a2d0a
Merge "Add owner's info to the dictionary"
2013-05-08 08:31:45 +00:00
Satoshi Kataoka
fc6d4a5412
Add owner's info to the dictionary
...
Bug: 8683365
Change-Id: I1c30eac128b4172526423ebeeb45bc6cee7fb67b
2013-05-08 17:29:04 +09:00
Satoshi Kataoka
6435c80087
Merge "Fix an issue on the transition between the setup and the settings"
2013-05-08 08:23:49 +00:00
Tadashi G. Takaoka
331d256f21
Fix an issue on the transition between the setup and the settings
...
Bug: 8853220
Change-Id: I99b6c46d900e9391f77986d1ae6e3edeaeff01e5
2013-05-08 15:18:45 +09:00
Satoshi Kataoka
f59c4f6840
Fix labels in the personal dictionary settings
...
Bug: 8855738
Bug: 8853764
Change-Id: I03383bb5d6d72645f511cc6175dec747eb13a840
2013-05-08 14:58:43 +09:00
Satoshi Kataoka
244a24e368
Consolidate dummy proximity info to the spell checker info
...
Bug: 8783170
Change-Id: I067486e5ec1ae7cdef8e2121392464ba71ee8add
2013-05-08 11:49:12 +09:00
Kurt Partridge
8064c669fe
Fix looping logic bugs.
...
shiftOut() is getting called once too often through these for loops.
Change-Id: I9a68b49e6cc1469bcddd673ab1567e238cf192b8
2013-05-07 08:33:31 -07:00
Tadashi G. Takaoka
104bb70c65
Merge "Avoid drawing too long gesture preview trails"
2013-05-07 11:58:09 +00:00
Jean Chalard
2afe88b8d7
Merge "Unify space-adding on gestures."
2013-05-07 11:51:01 +00:00
Tadashi G. Takaoka
80e396d83c
Avoid drawing too long gesture preview trails
...
Bug: 7167303
Change-Id: I63c2e8fb60f76e80346b67fd44399fa91930f2f0
2013-05-07 20:48:46 +09:00
Jean Chalard
e8b9b35471
Unify space-adding on gestures.
...
This is much simpler, and more correct.
Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
2013-05-07 20:38:09 +09:00
Satoshi Kataoka
a9dd74cf3f
refactor spell checker
...
Change-Id: Ie7bea23f2ac54f03572e77c31ba7cb3d5e8f8d2f
2013-05-07 20:21:11 +09:00
Tadashi G. Takaoka
9d71a6c968
Remove unused device form factor values
...
Change-Id: I1ed88b842a3d45e5460dd387bfad4276c844096a
2013-05-07 18:52:22 +09:00
Tadashi G. Takaoka
84ac8f31fb
Move empty listner to KeyboardActionListener.Adapter
...
Change-Id: Ic7bad73c089de015746c667bbfb2c09bd429a9fc
2013-05-07 16:40:15 +09:00
Tadashi G. Takaoka
61b6fc7d7b
Clean up unused static variable
...
Change-Id: I51c5903b7716d3927d2ff09a5054725215a626b5
2013-05-07 16:36:32 +09:00
Tadashi G. Takaoka
ce67b41661
Record down point as gesture preview trail for sure
...
Change-Id: Ic712a6af8229a9a1aa4a5419d779927f1ef8be67
2013-05-07 15:51:23 +09:00
Tadashi G. Takaoka
4ddf1e47a7
Remove unused gesture preview trail code
...
Change-Id: I2aa77675628a4b1655b30852c950f5daae6f0a92
2013-05-07 14:27:34 +09:00
Tadashi G. Takaoka
a5be033d4a
Preserve setup wizard step while orientation change
...
Bug: 8159728
Change-Id: I596f59749443b8878b5613285f0fe793d449cdbd
2013-05-02 18:42:10 +09:00
Tadashi G. Takaoka
7d19ab5c9d
Using int instead of booleans to save keyboard shift state
...
This is a follow up of Ib2bc262aac.
Bug: 8734294
Change-Id: I0b56797ffc4f16e18da72352777fe0f000d173aa
2013-05-02 16:21:39 +09:00
Tadashi G. Takaoka
7f8dd50b8f
Save automatic shift state while orientation changing
...
Bug: 8734294
Change-Id: Ib2bc262aacedf786a318c2fe1bd4420a21e7d847
2013-05-02 15:48:56 +09:00
Jean Chalard
83757d439e
Merge "Pass blockOffensiveWords as a parameter"
2013-05-01 11:57:36 +00:00
Jean Chalard
2dbb5957e3
Pass blockOffensiveWords as a parameter
...
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
Ken Wakasa
1490b53416
Cleanup -- follow up to Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
...
Change-Id: Icb89c5119a67edaa019d5f7645b734cfcfc29041
2013-05-01 20:19:05 +09:00
Satoshi Kataoka
1641a4a457
Merge "Fix Google spell checker tests"
2013-05-01 09:31:52 +00:00
Satoshi Kataoka
d5781eef62
Fix Google spell checker tests
...
Bug: 8613307
Change-Id: Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
2013-05-01 18:21:56 +09:00
Tadashi G. Takaoka
6f7905ae75
Introduce MoreSuggestionsListener class
...
Bug: 8694255
Change-Id: I9420a7cb1983c6211f58d13b3b11db4347c3f99b
2013-05-01 18:03:37 +09:00
Tadashi G. Takaoka
47a66b12ec
Override View.drawableStateChanged to detect state_pressed
...
Unlike on JB, View.setPressed(boolean) is never called when the view
is pressed on ICS. To detect a pressed state of the view, we need to
override View.drawableStateChanged() and check the drawable state
contains state_pressed.
Bug: 8159728
Change-Id: I481051364d6f3d1370742723c3ce19d898ea5463
2013-05-01 14:02:18 +09:00
Tadashi G. Takaoka
7b2114a428
Display still image when device can't play welcome video
...
Note that the still image in this change is a placeholder and must be
replaced by final asset.
Bug: 8159728
Change-Id: I4f5a28e0af711edacbc87c2ee64508f34f67f0da
2013-05-01 12:24:36 +09:00
Jean Chalard
019c38060d
am ace3f3c5
: am 25c90e6d
: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev
...
* commit 'ace3f3c5d56f5b4a58e8dc400fec1bb8c7b17a63':
Don't do recorrection when suggestions are off.
2013-04-30 19:22:13 -07:00
Jean Chalard
aa3a96f3a1
Don't do recorrection when suggestions are off.
...
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
2013-05-01 10:17:28 +09:00
Ken Wakasa
a0b62ece83
Merge "Cleanup an unused return value"
2013-04-30 11:16:28 +00:00
Tadashi G. Takaoka
1187ef9a97
Merge "Catch error while playing welcome video"
2013-04-30 09:31:20 +00:00
Jean Chalard
37bbaea8a1
Merge "[PB14] Cosmetic fixes to the progress bar"
2013-04-30 09:20:41 +00:00
Tadashi G. Takaoka
ad46c9e0e0
Catch error while playing welcome video
...
Bug: 8159728
Change-Id: Ic8eea7993f12395d6eca6db8d5529803251a9fee
2013-04-30 18:18:32 +09:00
Jean Chalard
7eff677c29
[PB14] Cosmetic fixes to the progress bar
...
Bug: 7600384
Change-Id: I33ea155c0c97c7ead07686c4d2a9e0d98be9929c
2013-04-30 17:54:09 +09:00
Ken Wakasa
0d6c87d113
Cleanup an unused return value
...
Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
2013-04-30 16:53:18 +09:00
Satoshi Kataoka
71c1e50fdb
Merge "Fix the title of the fragment of the personal dictionary"
2013-04-30 07:11:13 +00:00
Jean Chalard
01170ffebe
[PB13] Actually update the progress bar
...
Bug: 7600384
Change-Id: Iaa8f3a59243a15d2a01aaf6017ed85c52b6482a6
2013-04-30 15:48:26 +09:00
Satoshi Kataoka
5aa14c2636
Fix the title of the fragment of the personal dictionary
...
This change is corresponding to I9b8bab21b144385bc2386e7fcb
Bug: 8600958
Change-Id: I0a0cf37d0a11c14a51dc63b2e4371facb34514d0
2013-04-30 15:01:51 +09:00
Jean Chalard
d282ebfb71
[PB12] Implement the progress bar update lifecycle
...
This ensures the thread does not run uselessly (it is even terminated when
the progress bar exits the screen).
Bug: 7600384
Change-Id: I09117a6f763b574b9b3266f36ba3da4720dc9224
2013-04-30 14:55:10 +09:00
Jeff Sharkey
c5ebc792d6
Avoid leaking AssetFileDescriptor.
...
Change-Id: Iac388c8aefc684980cb4c7131fb47319f6073eb3
2013-04-29 12:26:44 -07:00
Jean Chalard
fc26033c37
[PB11] Add a skeleton class for a self-updating progress bar
...
Bug: 7600384
Change-Id: I55b51152dd9968a359af091bf309f0d406f63ec4
2013-04-26 20:51:42 +09:00
Jean Chalard
ab0c66b9d1
[PB10] Add a progress bar to display file download progress
...
The progress bar is showing but doesn't show progress yet.
Bug: 7600384
Change-Id: I80debd3f4368e82e4184a6c638bdcc8e48ed2305
2013-04-26 20:34:56 +09:00
Jean Chalard
739406bf46
Merge "[PB9] Make buttons that animate-out unclickable"
2013-04-26 10:29:43 +00:00
Jean Chalard
d4fc13d261
[PB9] Make buttons that animate-out unclickable
...
Clicking on a button that is animating-out is only done by
mistake. Better make them unclickable.
Also, interrupt an out-in animation if it has been preempted.
Bug: 7600384
Change-Id: Ic4700cda46a894ea580bc67ee7bef885ecf1d3bc
2013-04-26 19:06:29 +09:00
Tadashi G. Takaoka
be06bce18b
Merge "Get rid of janky black box before the movie starts"
2013-04-26 09:38:54 +00:00
Tadashi G. Takaoka
d477755287
Merge "Fix graying animation of alt-code keys when space/enter is typed"
2013-04-26 09:33:07 +00:00
Tadashi G. Takaoka
732c93815a
Get rid of janky black box before the movie starts
...
Bug: 8159728
Change-Id: I1d0a01a05b3b694d21fdfdc246d1329ab829908d
2013-04-26 18:26:12 +09:00
Jean Chalard
e8ed5d8876
Delete obsolete dictionaries
...
Bug: 7980985
Change-Id: I4c9165e6102cb12fa1249074297e94013439ea3b
2013-04-26 17:31:55 +09:00
Jean Chalard
c03aaa1bde
Merge "[ZF2] Read settings for profanity filtering."
2013-04-26 08:23:56 +00:00
Tadashi G. Takaoka
5141f04ef3
Fix graying animation of alt-code keys when space/enter is typed
...
Change-Id: Iac508f37afa916ca52c62c2369cb7ff91bde0a64
2013-04-26 16:14:18 +09:00
Satoshi Kataoka
adbafa1a9b
Merge "Support ICS on the user dictionary settings"
2013-04-26 06:50:42 +00:00
Satoshi Kataoka
dcef94165b
Support ICS on the user dictionary settings
...
Bug: 8600958
Change-Id: I50e9228afc7b04147eb7c4734d3145abe8859a30
2013-04-26 15:48:08 +09:00
Tadashi G. Takaoka
dca46b5015
Merge "Keep task stack when invoking settings from setup wizard"
2013-04-26 06:45:52 +00:00
Tadashi G. Takaoka
57372fd3da
Remove graying animation of alt-code keys while typing
...
Bug: 8727807
Change-Id: Idcc76dade3ceba5649666d795b6e4f94a161d748
2013-04-26 14:55:46 +09:00
Tadashi G. Takaoka
82e476b188
Keep task stack when invoking settings from setup wizard
...
Bug: 8336068
Change-Id: If1df32595f72285b2dad16e28b4429b7b6059839
2013-04-26 13:03:37 +09:00
Jean Chalard
1919072cfc
Merge "[ZF1] Check profanity in Java rather than in native"
2013-04-25 11:33:05 +00:00
Jean Chalard
bb61293675
[ZF2] Read settings for profanity filtering.
...
Bug: 7226877
Change-Id: Ie0c713e1eba1529c0b288a1e5011023a79bedd6b
2013-04-25 20:29:14 +09:00
Jean Chalard
99e998286d
[ZF1] Check profanity in Java rather than in native
...
Bug: 7226877
Change-Id: Ib6c32bfee9977c27dbf7e1e590b2b00d9ceb7301
2013-04-25 20:29:11 +09:00
Jean Chalard
fb34869f5a
Merge "[PB8] Add an animation upon status change."
2013-04-25 11:04:58 +00:00
Tadashi G. Takaoka
b1b03cfc2b
Merge "Fix missing initialization of PreviewPlacerView"
2013-04-25 10:00:34 +00:00
Jean Chalard
43590149a5
Work around a bug in older DownloadManager versions.
...
This adds a number to the extension.
Note that for DownloadManager to keep this, the server
needs to send it a mime type it does not recognize. Right
now, it does not recognize application/json so it's okay,
but we'd do well to remove the content/type header from
the server to prevent problems.
Bug: 8467516
Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
2013-04-25 18:52:39 +09:00
Jean Chalard
4dc77dcf4c
Merge "[PB7] Export animation code out of the preference"
2013-04-25 09:49:12 +00:00
Jean Chalard
513c63e877
[PB8] Add an animation upon status change.
...
Bug: 7600384
Change-Id: If5efb9357075193d10255187008e870e2933bdb8
2013-04-25 18:37:03 +09:00
Jean Chalard
2d72590ced
[PB7] Export animation code out of the preference
...
Bug: 7600384
Change-Id: I8009b31d96646acd667db410b94e969daea91d52
2013-04-25 18:37:01 +09:00
Tadashi G. Takaoka
1b6eea8903
Fix missing initialization of PreviewPlacerView
...
Bug: 8716050
Change-Id: I234f1134274b9f72c8abbd729783f9ffe8f20f64
2013-04-25 18:26:24 +09:00
Jean Chalard
a995bf4031
Put temp files within app files
...
Bug: 8715614
Change-Id: I307d83923070994525cf0d27aad403e881a89314
2013-04-25 18:14:40 +09:00
Satoshi Kataoka
30f0f3a92a
Merge "Implement a functionality to add an entry to the user dictionary"
2013-04-25 06:04:08 +00:00
Satoshi Kataoka
a79ba8a3d6
Implement a functionality to add an entry to the user dictionary
...
Bug: 8600958
Change-Id: Ic472500406b9d54ec4052c490ee7cef62fc4e52a
2013-04-25 14:55:07 +09:00
Jean Chalard
2cf450f482
[PB6] Encapsulate the buttons into a view
...
Handling buttons directly in the preference causes large
problems of code readability and interface. It's better to
have a class to manage the buttons and their animations
separately. This is feature-equivalent, and mostly
delegates stuff for now.
Bug: 7600384
Change-Id: Ia8da0ec68ffac84fc1d65e1760539a87a73fa776
2013-04-25 12:25:25 +09:00
Jean Chalard
e91387e281
Merge "[PB5] Store state in a more convenient manner"
2013-04-25 02:44:47 +00:00
Jean Chalard
cadea5d2fc
[PB5] Store state in a more convenient manner
...
This is more readable and will help with animations going forward.
Bug: 7600384
Change-Id: I255598d860d1e451fef106b00da63c282fe95f95
2013-04-24 22:49:50 +09:00
Jean Chalard
e91c001da9
Merge "[PB4] Make a memory non-static"
2013-04-24 11:51:10 +00:00
Jean Chalard
80790d78f6
Merge "[PB3] Simplify storage"
2013-04-24 11:49:43 +00:00
Jean Chalard
776edcfe46
Merge "[PB2] Small bugfix"
2013-04-24 11:49:33 +00:00
Jean Chalard
c017f18a59
[PB4] Make a memory non-static
...
The life span of this object is actually the life span of the interface.
It should not be static.
Also, we'll have a few other things to store in there soon.
Bug: 7600384
Change-Id: I708019e9ee53653e83a1e52c8e76326c3e39bcf3
2013-04-24 20:46:28 +09:00
Jean Chalard
43e8639e4e
[PB3] Simplify storage
...
By looping through children, there is no need to remember the
last index.
Bug: 7600384
Change-Id: I8b42b0aa38874ee494c6c4ecc09194a1d3c16922
2013-04-24 20:46:26 +09:00
Jean Chalard
d98f406dd3
[PB2] Small bugfix
...
The button would not display after it got hidden once.
Bug: 7600384
Change-Id: I57f9f1191be3b8fff55dde7a2781dbef68a2df62
2013-04-24 20:45:53 +09:00
Tadashi G. Takaoka
46913aedb4
Merge "Add next axction to setup wizard"
2013-04-24 10:30:56 +00:00
Tadashi G. Takaoka
b5d33059e0
Add next axction to setup wizard
...
Bug: 8159728
Change-Id: Ia37ab32b63e4eda29bf1411719d00846525c278f
2013-04-24 19:22:41 +09:00
Satoshi Kataoka
b35aa487fd
Merge "Make aggressive threshold really aggressive"
2013-04-24 09:14:30 +00:00
Satoshi Kataoka
70f2762e28
Make aggressive threshold really aggressive
...
Bug: 8701480
Change-Id: If8242cfe61f3e56712fd6e25e36858cff7f0d177
2013-04-24 17:49:56 +09:00
Tadashi G. Takaoka
0e96003e0f
Merge "Refactor SetupStepGroup"
2013-04-24 05:53:33 +00:00
Tadashi G. Takaoka
e918bf07a0
Refactor SetupStepGroup
...
Bug: 8159728
Change-Id: I1ab846d0910aacbd2f979289d72bafea8a8e0378
2013-04-24 14:15:59 +09:00
Jean Chalard
41f505dc3e
[PB1] Cleanup
...
This preference is not a DialogPreference any more, as it doesn't
ever display a Dialog.
Bug: 7600384
Change-Id: Ia5965617c83d3cb964010f9b40d833065dccef60
2013-04-23 20:41:41 +09:00
Tadashi G. Takaoka
480284e28a
Merge "Add edit personal dictionary settings menu"
2013-04-23 06:01:45 +00:00
Jean Chalard
c3f4783649
Add an additional ID to the client info.
...
Bug: 8651863
Change-Id: I748f35726d72ede926d5b06ed87ff029317f1ac3
2013-04-23 14:37:15 +09:00
Satoshi Kataoka
9b4e3db1af
Legal notice
...
Bug: 8533258
Change-Id: I00e4916f86f29dd476c51a65e8fa5a6c136fd179
2013-04-22 21:55:53 +09:00
Tadashi G. Takaoka
4f2535398a
Add edit personal dictionary settings menu
...
Bug: 8600958
Change-Id: I303adfbe25a56cc9b5ee9f3b5169a5bca0ad6c4a
2013-04-22 19:59:12 +09:00
Tadashi G. Takaoka
1a9bf159a4
Merge "Don't triger onPress and startLongPressTimer when gesture is canceled"
2013-04-22 10:53:39 +00:00
Tadashi G. Takaoka
508ab24875
Merge "Implement IMM.switchToNextInputMethod() for ICS"
2013-04-22 10:37:11 +00:00
Tadashi G. Takaoka
13d5da8b88
Don't triger onPress and startLongPressTimer when gesture is canceled
...
Bug: 8650846
Change-Id: Ice5ef07d6833422906b0b756206e097f75d1f2db
2013-04-22 19:36:08 +09:00
Tadashi G. Takaoka
85629debaa
Implement IMM.switchToNextInputMethod() for ICS
...
Bug: 8633367
Change-Id: Ifc0f97b1fdf5e5cc3601c24a503058c4822478dc
2013-04-22 19:30:56 +09:00
Jean Chalard
f0e579a171
Don't kill suggestions with native score < 1
...
Change-Id: I954856b7fec0b91e19a467f2a87978d49caa639d
2013-04-22 14:21:43 +09:00
Kurt Partridge
41b34cf2ae
Merge "Allow LogUnits to hold >1 word"
2013-04-19 16:04:13 +00:00
Kurt Partridge
e92b5e145f
Allow LogUnits to hold >1 word
...
LogUnits have been annotated with the autocorrected words, but
until now this was assumed to be a single word without spaces.
But spaceless typing can result in spaces in the LogUnit label. With this
change, the LogUnit inspects the autocorrected text to determine how many
words were inserted, and counts them accurately.
This change corrects a privacy problem, which was that if the word sampling
algorithm chose a LogUnit that actually contained multiple words, then more
than two successive words would be included in the log.
Change-Id: I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
2013-04-19 08:55:39 -07:00
Jean Chalard
825da76c72
Redisplay a hidden button after it entered the screen again.
...
Bug: 7600384
Change-Id: I6cd18fd7584b6e98260cb432956f08ba9886580b
2013-04-19 22:50:48 +09:00
Jean Chalard
f8014eea34
Hide the correct button when pressing a new button.
...
Bug: 7600384
Change-Id: Ic5dbbbbcf19d778dde1316ebb417f1a8ede2d25d
2013-04-19 22:50:45 +09:00
Tadashi G. Takaoka
68e4de1e78
Add welcome screen to setup wizard
...
This is a preliminary implementation because the welcome screen video
is just a placeholder.
Bug: 8159728
Change-Id: I6a2459a266babec2f078fc393b18c77b0b7992a8
2013-04-19 20:49:49 +09:00
Tadashi G. Takaoka
fcefabf9ab
Groundwork to implement landscape and welcome screen
...
Bug: 8159728
Change-Id: I05ff6578980ec2e210ebb482ea51b1600e74a4f4
2013-04-19 20:10:59 +09:00
Tadashi G. Takaoka
16ec2e1155
Merge "Add finish action to setup wizard"
2013-04-19 10:58:55 +00:00
Tadashi G. Takaoka
192743a6ae
Add finish action to setup wizard
...
Bug: 8159728
Change-Id: I1578fc31875a1edbfea213fb5e1a1b464d02e941
2013-04-19 19:44:54 +09:00
Jean Chalard
ff078041e7
am f1dde6a1
: am 758c74fe
: Merge "Fix an NPE in recorrection" into jb-mr2-dev
...
* commit 'f1dde6a1bf659d182db5a2645515cc1efe74459c':
Fix an NPE in recorrection
2013-04-19 00:10:22 -07:00
Jean Chalard
e5cbdfe1b8
am 3629605b
: am 77226ed0
: Merge "Fix an NPE in recapitalize" into jb-mr2-dev
...
* commit '3629605b7c14b5eea498ef9588f4fef788ef454c':
Fix an NPE in recapitalize
2013-04-19 00:06:58 -07:00
Jean Chalard
758c74fe82
Merge "Fix an NPE in recorrection" into jb-mr2-dev
2013-04-19 07:03:19 +00:00
Jean Chalard
77226ed006
Merge "Fix an NPE in recapitalize" into jb-mr2-dev
2013-04-19 07:01:10 +00:00
Jean Chalard
ae7d1530b4
Fix an NPE in recorrection
...
Also, theoretically, we don't want to retrieve older suggestions if
there are no results for a recorrection - that would look random.
This bug addresses this too.
Bug: 8657919
Change-Id: I44f36d34a708a968ab71fa0592da57f4c97d4b7f
2013-04-19 15:53:33 +09:00
Jean Chalard
3bdf341ea0
Fix an NPE in recapitalize
...
Bug: 8657736
Change-Id: I459d1c200826c1c394f8207475ecf60a4f356793
2013-04-19 15:44:20 +09:00
Tadashi G. Takaoka
1f6e06cf92
Merge "Make setup wizard step number highlighted when activated"
2013-04-19 03:21:04 +00:00
Tadashi G. Takaoka
b84c0468e4
Make setup wizard step number highlighted when activated
...
Bug: 8159728
Change-Id: I62ccbebaae0a0c4a93ad7c155fc3020a7f357f3c
2013-04-19 11:14:21 +09:00
Ken Wakasa
f02e269312
am 55b306c9
: am 64eda4f4
: Merge "Fix an infinite loop" into jb-mr2-dev
...
* commit '55b306c9e0ea29a10dfd79d5478344fcc98ca184':
Fix an infinite loop
2013-04-18 09:32:04 -07:00
Jean Chalard
3a18ae70cc
am a5d2da82
: am d91268ad
: Initialize dictionaries at onStartInputView
...
* commit 'a5d2da82a6a4486a4ef74e51ddd1c875f4c2d935':
Initialize dictionaries at onStartInputView
2013-04-18 09:27:35 -07:00
Ken Wakasa
64eda4f4fa
Merge "Fix an infinite loop" into jb-mr2-dev
2013-04-18 16:24:01 +00:00
Jean Chalard
77e26e1c29
Fix an infinite loop
...
What do you mean "Can't happen"?
It happens all the time - the empty string is the default ID, and it
needs to be updated like everyone else.
Bug: 8651858
Change-Id: I5a2f2ebb5b2ef08b27f26be8fb2c3d2f231ebcfc
2013-04-18 23:14:13 +09:00
Tadashi G. Takaoka
0b2d184a42
Merge "Update setup wizard icons"
2013-04-18 06:56:24 +00:00
Jean Chalard
d91268ad9f
Initialize dictionaries at onStartInputView
...
Bug: 8344402
Change-Id: I41b8440f0d72a66fde3f6feb0db8239c9bb10ea3
2013-04-18 14:48:42 +09:00
Kurt Partridge
56f35a10cd
Merge "Fix bug in counting words between samples"
2013-04-18 04:23:29 +00:00
Tadashi G. Takaoka
d794f5ae2a
Update setup wizard icons
...
Bug: 8159728
Change-Id: Ia5a14a35292b43dc1eaa2d4edd65134040355149
2013-04-18 13:15:53 +09:00
Kurt Partridge
7a1721753b
Merge "Fix user recording dialog"
2013-04-18 02:07:16 +00:00
Kurt Partridge
0833b3cbae
Merge "Fix alarm bug"
2013-04-18 01:01:48 +00:00
Kurt Partridge
a19133011a
Merge "Avoid duplicate MotionEvents"
2013-04-17 22:57:20 +00:00
Kurt Partridge
b903f10393
Merge "Label logUnits after LatinImeOnEndBatchInput"
2013-04-17 21:30:47 +00:00
Kurt Partridge
a5bfac5bec
Merge "Fix NPE"
2013-04-17 20:33:26 +00:00
Kurt Partridge
7da87f97b0
Merge "Clean up unnecessary log messages"
2013-04-17 20:18:19 +00:00
Kurt Partridge
e9e4fe5227
Merge "Fix logic error"
2013-04-17 18:57:18 +00:00
Kurt Partridge
1f99e04bba
Merge "Fix JsonWriter bug"
2013-04-17 18:20:34 +00:00
Kurt Partridge
dac3ee49ae
Merge "Small dot in corner was not visible"
2013-04-17 17:18:35 +00:00
Kurt Partridge
bf62dc9460
Fix bug in counting words between samples
...
Previously MainLogBuffer#shiftOutWords() assumed it wouldn't be called if
mNumWordsUntilSafeToSample was 0. This relaxes this assumption (which is in fact
false in the current code).
Change-Id: I8723248095e84a0d9d6f4639b4742cc7dda9716b
2013-04-17 08:44:06 -07:00
Kurt Partridge
fdc90d4a58
Fix user recording dialog
...
Clicking the "include recording" checkbox in the user feedback dialog did nothing.
The code was relying on the state of the checkbox, rather than keeping its own state.
Fixing this addresses the bug.
Change-Id: I559d57a4e11f869f6e6f5e5de7878f765531a203
2013-04-17 08:42:20 -07:00
Kurt Partridge
9d3bbc82a0
Fix alarm bug
...
The AlarmManager takes absolute times as an argument, not durations.
Change-Id: I419434ba5908c5f4070608070bbecf753088ecc8
2013-04-17 08:39:49 -07:00
Kurt Partridge
dd8c87a39d
Merge "Include nanoTime in filename"
2013-04-17 15:31:20 +00:00
Tadashi G. Takaoka
530fd15eff
Fix bug to update last interpolated index of GestureStroke
...
Bug: 8556775
Change-Id: Ie12e0dc9bfeae45f6883580801e07d44be1d1d33
2013-04-17 06:36:12 -07:00
Tadashi G. Takaoka
464202047d
Add user feedback to setup action labels and icons
...
Bug: 8159728
Change-Id: I46c77c31973ae492c2a12291f2e0b154f64d26c9
2013-04-17 19:57:46 +09:00
Tadashi G. Takaoka
47a78aeb4d
Merge "Finalize setup wizard strings and mark as translatable"
2013-04-17 10:55:41 +00:00
Tadashi G. Takaoka
8712ac7945
Finalize setup wizard strings and mark as translatable
...
Bug: 8159728
Change-Id: I9f6f04b09b2cefdb7ece76a4f3c39ab56d0c8fab
2013-04-17 19:52:50 +09:00
Kurt Partridge
cd831fa285
Fix JsonWriter bug
...
JsonWriter requires that data be written to it, else close() will throw
an exception.
Change-Id: I596c5363e063cc75bcda55e0a506eefb3f17bd67
2013-04-17 01:26:52 -07:00
Kurt Partridge
fe0529714e
Label logUnits after LatinImeOnEndBatchInput
...
Previously only a commitText would cause a LogUnit to be
labeled with the word that the data generates. In the case
of gestured text, this information is available when
LatinIME#onEndBatchInput is called. Labeling the LogUnit
at this time means that the Log will have labeled words even
if stop() is called before commit.
Change-Id: Idb2f99a9c159a1b1aa00448a2ecddeca6c351c3e
2013-04-17 01:14:36 -07:00
Kurt Partridge
1bf47582a0
Avoid duplicate MotionEvents
...
Change-Id: I9c3b352b738698f262f254e581bde34b060e258f
2013-04-17 00:30:54 -07:00
Tadashi G. Takaoka
bb5deb82b5
Fix singleton/utility classes initialization in SettingsFragment
...
This is a follow up of Ide3cd3acba.
Bug: 8632344
Change-Id: Iafe51798a1a74eff5d8fcd6f0117d16b419d447d
2013-04-17 16:16:10 +09:00
Tadashi G. Takaoka
888a194cf1
Fix missing AudioAndHapticFeedbackManager initialization
...
Bug: 8632344
Change-Id: Ide3cd3acba3987317cff709fa591eadaa71834e8
2013-04-17 15:32:01 +09:00
Kurt Partridge
4ac28ded28
Fix NPE
...
Change-Id: I8a091fb63dab12a0d2ba69e2fe393249bc68d103
2013-04-16 20:39:47 -07:00
Kurt Partridge
2edb4f22cb
Clean up unnecessary log messages
...
Change-Id: I6c3252f3b31c5874ea2f909f636f58b579c06b8d
2013-04-16 20:39:47 -07:00
Kurt Partridge
cd39368c21
Fix logic error
...
Change-Id: Ia36660c66504ba2fbb7f125704926a08726df87a
2013-04-16 20:39:47 -07:00
Kurt Partridge
2d9d4390fd
Small dot in corner was not visible
...
Framework change perhaps? Even if not, this makes it more visible
Change-Id: Ib6d36b5a30136c4516adac666bdff36d1cd9b337
2013-04-16 20:39:47 -07:00
Kurt Partridge
125f22dc58
Include nanoTime in filename
...
System is fast enough that sometimes SystemClock.currentTimeMillis() is duplicated
when used to make a unique filename.
Change-Id: I9454fbb5e10265d36b8e17cba183a1591d52cc7b
2013-04-16 20:29:42 -07:00
Tadashi G. Takaoka
edc49d38e6
Fix bug to update last interpolated index of GestureStroke
...
Bug: 8556775
Change-Id: Ie12e0dc9bfeae45f6883580801e07d44be1d1d33
2013-04-17 11:58:09 +09:00
Jean Chalard
ff766f8c4b
Merge "Don't insert automatic spaces when text looks like a URL"
2013-04-16 10:07:36 +00:00
Jean Chalard
73ec85b8ad
Don't insert automatic spaces when text looks like a URL
...
This is about as ad-hoc as it gets, but then again, what we want
is probably as ad-hoc as it gets.
All URL boxes I know of double as search bars, and not adding
automatic spaces there sucks (e.g. in Chrome URL bar).
And in other boxes actually you don't want to add a space if
it looks like a URL. QSB isn't even a search box, and it behaves
like this.
So I think this is actually the right answer to the problem.
Bug: 7062925
Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
2013-04-16 18:03:49 +09:00
Tadashi G. Takaoka
1711f986d4
Merge "Add shadow to gesture preview trail"
2013-04-16 07:57:29 +00:00
Tadashi G. Takaoka
c71dde9cb5
Add shadow to gesture preview trail
...
Bug: 7167303
Change-Id: I8f76fe0aec6cb32388e7c85d04516d1dd7d28c29
2013-04-16 16:50:59 +09:00
Jean Chalard
962c9f059a
Merge "Small cleanup"
2013-04-16 06:38:17 +00:00
Jean Chalard
30225f3897
Small cleanup
...
Change-Id: Iafdbe305712c8a571f0f5abc2032df086d7ac015
2013-04-16 15:30:48 +09:00
Jean Chalard
78d658734d
Merge "Don't recapitalize on shift while on symbol layout"
2013-04-16 05:31:43 +00:00
Jean Chalard
1f52364630
Don't recapitalize on shift while on symbol layout
...
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
2013-04-16 14:29:02 +09:00
Jean Chalard
8094bf45d7
Match the keyboard state to the recapitalize state.
...
Bug: 7657025
Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
2013-04-16 14:25:03 +09:00
Jean Chalard
e259b9f57d
Merge "Clean up RecapitalizeStatus"
2013-04-16 04:57:35 +00:00
Jean Chalard
fd15686ae9
Merge "Fix an NPE"
2013-04-16 04:12:18 +00:00
Jean Chalard
b794e904a3
Clean up RecapitalizeStatus
...
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
2013-04-16 13:11:18 +09:00
Jean Chalard
a024ac6b20
Merge "Fix an NPE"
2013-04-16 03:43:06 +00:00
Jean Chalard
2b42ad0eaa
Fix an NPE
...
Bug: 8620678
Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
2013-04-16 12:20:10 +09:00
Jean Chalard
7be3ca2ccf
Fix an NPE
...
Bug: 8620758
Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
2013-04-16 12:17:22 +09:00
Jean Chalard
5fca38c538
Merge "Small performance improvement / minor bugfix"
2013-04-15 14:28:16 +00:00
Jean Chalard
b76ce1251e
Merge "Remove a useless function"
2013-04-15 13:06:33 +00:00
Jean Chalard
bc501647fd
Remove a useless function
...
Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
2013-04-15 22:01:37 +09:00
Jean Chalard
1e5bbe4ce8
Small performance improvement / minor bugfix
...
The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.
Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
2013-04-15 21:18:50 +09:00
Jean Chalard
a5a2f3e3c7
Remove gesture suggestions with an INT_MIN score
...
Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
2013-04-15 20:55:49 +09:00
Jean Chalard
033958330d
Merge "Have Latin IME re-capitalize a selected string"
2013-04-15 11:29:28 +00:00
Jean Chalard
2995abe7aa
Have Latin IME re-capitalize a selected string
...
Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.
Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
2013-04-15 20:23:01 +09:00
Jean Chalard
0e9ee4d3bf
If there are no suggestion span, recompute suggestions.
...
Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
2013-04-15 19:33:23 +09:00
Jean Chalard
059e084e98
Merge "Reject a previously user-refused suggestion."
2013-04-15 07:45:34 +00:00
Jean Chalard
d40f3f6bc1
Reject a previously user-refused suggestion.
...
If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.
Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
2013-04-15 16:36:44 +09:00
Tadashi G. Takaoka
216fb6a042
Remove unnecessary harmful finish() from SettingsActivity
...
Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
2013-04-15 16:26:40 +09:00
Tadashi G. Takaoka
1ec4c07a13
Merge "Ignore modifier key while sliding key input"
2013-04-15 06:19:10 +00:00
Tadashi G. Takaoka
f224941c37
Merge "Suppress calling onPressKey and onReleaseKey while detecting gesture"
2013-04-15 06:18:48 +00:00
Tadashi G. Takaoka
29105a725d
Add preference dependency to gesture input related options
...
Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
2013-04-15 15:07:49 +09:00
Tadashi G. Takaoka
8dfbb740e1
Ignore modifier key while sliding key input
...
Bug: 8284624
Change-Id: I839d7a769d98f29be647dbe511ba3f73ca44446d
2013-04-15 14:39:02 +09:00
Tadashi G. Takaoka
e2af9b7eb5
Merge "Reset vertical correction when more suggestions are in modal mode"
2013-04-15 04:57:33 +00:00
Tadashi G. Takaoka
51c38a441a
Reset vertical correction when more suggestions are in modal mode
...
Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
2013-04-15 13:56:03 +09:00
Jean Chalard
03d1dff38d
Merge "Fix Binary dict tests"
2013-04-15 03:53:54 +00:00
Jean Chalard
c2e9c511cb
Fix Binary dict tests
...
There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.
The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.
All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.
Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
2013-04-15 12:48:16 +09:00
Tadashi G. Takaoka
a91da76683
Suppress calling onPressKey and onReleaseKey while detecting gesture
...
Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
2013-04-15 10:59:54 +09:00
Kurt Partridge
ededdc6a8b
Merge "Avoid NPE"
2013-04-12 18:10:49 +00:00
Jean Chalard
2cd1136b8e
Merge "Remove the dialog to insert words to the dictionary."
2013-04-12 12:33:24 +00:00
Jean Chalard
91bcf5eb5d
Merge "Restart suggestions when the cursor moves."
2013-04-12 12:27:50 +00:00
Jean Chalard
02ce3dc2d1
Fix a bug with bad application completions
...
Bug: 8561056
Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
2013-04-12 20:53:06 +09:00
Jean Chalard
6a114fa700
Restart suggestions when the cursor moves.
...
This uses the old suggestions. It does not try to recompute
new suggestions if there are no old suggestions yet: this is
coming in a later change.
If there are no suggestions, this shows the word itself
as a suggestion.
Bug: 8084810
Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
2013-04-12 20:49:03 +09:00
Jean Chalard
d24f939712
Merge "Make shortcut-only user dict entry non-words."
2013-04-12 11:02:00 +00:00
Jean Chalard
fb5869e9ff
Merge "Add a class to encapsulate getting the metadata URI"
2013-04-12 11:01:36 +00:00
Jean Chalard
6a2a4b8e4d
Make shortcut-only user dict entry non-words.
...
Bug: 7369456
Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
2013-04-12 16:17:09 +09:00
Jean Chalard
1a51833828
Remove the dialog to insert words to the dictionary.
...
Bug: 8562529
Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
2013-04-12 15:58:50 +09:00
Kurt Partridge
2927223edd
Merge "Better isolate ResearchLogging data"
2013-04-11 21:56:01 +00:00
Jean Chalard
8987cccf89
Add a class to encapsulate getting the metadata URI
...
Bug: 8376173
Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
2013-04-11 17:52:16 +09:00
Jean Chalard
b5d5190deb
Merge "Add some utility functions."
2013-04-11 07:35:22 +00:00
Jean Chalard
1cbb0b8f2a
Add some utility functions.
...
Bug: 7657025
Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
2013-04-11 16:16:19 +09:00
Tadashi G. Takaoka
bd8e92d843
Add debug message to detect unusual zero width condition
...
Bug: 8452013
Change-Id: I0169dc6b0d08d1b4d9e01a5fa2ad01e9db292bda
2013-04-11 15:08:36 +09:00
Tadashi G. Takaoka
f67a388197
Merge "Add TypefaceUtils"
2013-04-11 05:32:58 +00:00
Tadashi G. Takaoka
08ae0d5ca0
Add TypefaceUtils
...
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
2013-04-11 14:27:42 +09:00
Tadashi G. Takaoka
6d0027a46a
Merge "Use SparseIntArray instead of TreeMap<Integer, Integer>"
2013-04-11 05:06:35 +00:00
Tadashi G. Takaoka
cee512b63e
Merge "More precise geometry checking for more keys keyboard"
2013-04-11 03:51:42 +00:00
Jean Chalard
3722f0877e
Merge "Fix two bugs in dicttool"
2013-04-11 03:07:30 +00:00
Tadashi G. Takaoka
a4463d7a9a
More precise geometry checking for more keys keyboard
...
Bug: 8484528
Change-Id: I0dd09530a5262fee9c19bb0f11d5830b00306944
2013-04-11 10:44:54 +09:00
Kurt Partridge
cdaee868a3
Merge "Preserve a class for testing"
2013-04-10 23:45:33 +00:00
Kurt Partridge
3684036eed
Preserve a class for testing
...
Addresses b/8583091
Change-Id: I89605223784312d9572dfc7c8aaa7e5eba44c4f6
2013-04-10 16:40:17 -07:00
Kurt Partridge
6108624a00
Better isolate ResearchLogging data
...
Calls to LatinIME#onStartInputViewInternal log important information
about the context in which an IME is used. This is reported as a
single LogStatement. Previously, this was not placed into a separate
LogUnit, and was mixed in with general word data. This change wraps
this LogStatement in its own LogUnit.
Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
2013-04-10 11:53:38 -07:00
Kurt Partridge
dfa5628cd3
Better release build reporting
...
The ResearchLogger reports whether a build is a release build or not
to avoid polluting data with IME debugging work by developers.
Previously this was done by checking a constant flag, which was also
serving the dual purpose of masking out debug code in release builds.
This change introduces a heuristic to determine whether a build was
created by a developer (using the package versionName), and annotating
the data sent to the server appropriately.
Change-Id: Icbad17c66b703cabf6d23d05e2c7c41bcceaae45
2013-04-10 11:52:37 -07:00
Jean Chalard
ca0fdbbe2e
Fix two bugs in dicttool
...
Both bugs only affect debug mode. One has the wrong object tested
with equals, the other has the iteration failing in some cases.
Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
2013-04-10 22:10:31 +09:00
Jean Chalard
fb3e805722
Merge "Fix a bug where a space would not be inserted before a gesture"
2013-04-10 11:19:31 +00:00
Jean Chalard
30b8004b56
Fix a bug where a space would not be inserted before a gesture
...
Bug: 8583675
Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
2013-04-10 20:10:28 +09:00
Tadashi G. Takaoka
c7d4158979
Merge "Use private object as a lock instead of synchronized method"
2013-04-10 09:56:27 +00:00
Tadashi G. Takaoka
12e77de212
Merge "Use private lock object instead of synchronized method"
2013-04-10 09:35:12 +00:00
Tadashi G. Takaoka
1e256f5888
Merge "Protect simultaneously modifying gesture preview data"
2013-04-10 09:34:59 +00:00
Tadashi G. Takaoka
951ea3c06d
Use private object as a lock instead of synchronized method
...
Change-Id: I0b9a935d8c97ddfb18ab7950a9d6bf542863072a
2013-04-10 18:34:01 +09:00
Tadashi G. Takaoka
ce811f50d2
Use private lock object instead of synchronized method
...
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
2013-04-10 18:27:11 +09:00
Tadashi G. Takaoka
ad205b2e3f
Protect simultaneously modifying gesture preview data
...
Bug: 8556775
Change-Id: I83272e3adbfc0c9cc14f9e8b479e926aabf4fa2a
2013-04-10 18:18:54 +09:00
Jean Chalard
99b93d17d5
Fix a bug where autocorrection status would be wrong.
...
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
2013-04-10 17:49:19 +09:00
Tadashi G. Takaoka
262d5bd9f9
Don't override EXTRA_SHOW_FRAGMENT if exists
...
Bug: 8541190
Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
2013-04-10 16:24:17 +09:00
Tadashi G. Takaoka
10af4b6e45
Merge "Separate StringUtils.capitalizeFirstCharacter"
2013-04-10 06:30:33 +00:00
Tadashi G. Takaoka
d20c5a78e2
Separate StringUtils.capitalizeFirstCharacter
...
Bug: 8582061
Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
2013-04-10 14:55:23 +09:00
Keisuke Kuroynagi
87fdde6ec4
Typing double letters via a 'circle' on the key.
...
Bug: 8550980
Change-Id: I5e432dea0e025ccea196f80e90a6bf945488e130
2013-04-10 12:43:13 +09:00
Tadashi G. Takaoka
f606fd8554
Hide Setup Wizard icon for stock keyboard
...
Bug: 8581647
Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
2013-04-10 12:24:40 +09:00
Tadashi G. Takaoka
869ea1e555
Use SparseIntArray instead of TreeMap<Integer, Integer>
...
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
2013-04-10 10:15:26 +09:00
Tadashi G. Takaoka
4fdfce6dcc
Merge "Refactor SpellCheckerProximityInfo as extending ProximityInfo"
2013-04-10 01:06:36 +00:00
Kurt Partridge
09ab6495a2
Merge "[FileEncap18] Clean up uploading scheduling"
2013-04-09 19:08:40 +00:00
Jean Chalard
19dcd15493
Merge "Offer to add any OOV typed word to the dictionary."
2013-04-09 10:28:47 +00:00
Jean Chalard
ddafcf82dc
Merge "Fix bugs and add tests"
2013-04-09 08:35:28 +00:00
Jean Chalard
9310f42a36
Offer to add any OOV typed word to the dictionary.
...
That includes gestures, which used not to work.
Bug: 8532637
Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
2013-04-09 12:05:54 +09:00
Kurt Partridge
1f70a4d681
Merge "Allow logging while replaying"
2013-04-09 02:33:09 +00:00
Kurt Partridge
d117c1a116
Merge "Do not record log split time when handling separator"
2013-04-09 02:31:48 +00:00
Ken Wakasa
d17c8bd929
Update comments
...
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
2013-04-08 23:05:45 +09:00
Jean Chalard
c87449497c
Fix bugs and add tests
...
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
2013-04-05 12:11:19 +09:00
Jean Chalard
7d3836d63a
Move a generic string utility to StringUtils
...
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
2013-04-05 12:09:14 +09:00
Tadashi G. Takaoka
6e3f307266
Refactor SpellCheckerProximityInfo as extending ProximityInfo
...
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
2013-04-02 19:06:32 +09:00
Jean Chalard
ecb59eff90
Revert "[DO NOT MERGE] Activate hardware keyboard handling"
...
This reverts commit c741f1f83b
DO NOT MERGE is ignored and this is merged anyway :(
Change-Id: Ie044cdfc6021933379ec97ad7346c5c8591f70bf
2013-04-02 16:08:48 +09:00
Jean Chalard
c741f1f83b
[DO NOT MERGE] Activate hardware keyboard handling
...
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
2013-04-02 15:38:13 +09:00
Kurt Partridge
30772c3758
Allow logging while replaying
...
Previously logging was disabled during replay. This makes it impossible to use logged data as a
regression test, since the new log was unavailable. This change corrects this problem.
Change-Id: I19dc31def2f2f87fd219dc561c739d18e4ab9c9c
2013-04-01 16:49:39 -07:00
Kurt Partridge
636b8c4231
Do not record log split time when handling separator
...
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be
broken. However, this causes the motion data associated with a separator to be associated with the
LogUnit of the previous word. This change corrects this bug.
Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
2013-04-01 16:48:15 -07:00
Kurt Partridge
5779bc91e6
Merge "Split LogUnits differently."
2013-04-01 23:08:21 +00:00
Kurt Partridge
0c0ab2b4d9
Merge "Reorder ResearchLogger call"
2013-04-01 15:19:45 +00:00
Jean Chalard
0745fe83d4
am b8869ec1
: am 0fcc4960
: Deactivate hardware keyboard handling.
...
* commit 'b8869ec1e39c1751825841e790d21fc854dca9ce':
Deactivate hardware keyboard handling.
2013-04-01 05:42:42 -07:00
Jean Chalard
0fcc4960bc
Deactivate hardware keyboard handling.
...
Bug: 8000119
Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
2013-04-01 21:35:45 +09:00
Tadashi G. Takaoka
75028af28c
Interpolate gesture preview trails
...
There is the boolean flag to kill interpolation.
Bug: 7167303
Change-Id: Iac7e4cb88cf437c2ee77c003c9cddb92416025c7
2013-04-01 19:15:36 +09:00
Jean Chalard
43341ba042
Merge "Ask the client to make itself known when it's not"
2013-04-01 09:00:25 +00:00
Jean Chalard
76d5f512f9
Ask the client to make itself known when it's not
...
Upon invoking the settings of the dictionary pack with an unknown
client, we now launch an intent to ask the client to make itself known.
This change also includes the code that receives this intent and
acts upon it.
Bug: 8492879
Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
2013-04-01 17:37:22 +09:00
Jean Chalard
065f126f1d
Merge "Fix two nasty bugs with surrogate pairs."
2013-04-01 08:28:08 +00:00
Jean Chalard
a411595b16
Fix two nasty bugs with surrogate pairs.
...
The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.
Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
2013-04-01 17:06:19 +09:00
Jean Chalard
740da0d8d0
Fix an NPE
...
Also remove an unused method and make 2 private variables
final.
Bug: 8461093
Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
2013-03-29 18:41:29 +09:00
Tadashi G. Takaoka
48d8d8d0ae
Fix potential NPE in MainKeyboardView.KeyTimerHandler
...
Bug: 8469652
Change-Id: Ib7a548e6a24d2e02de85ab444c0ec99d8f6b82c3
2013-03-28 17:54:36 +09:00
Jean Chalard
2188cbae63
Merge "Fix an NPE"
2013-03-28 06:56:49 +00:00
Jean Chalard
d555a0d77a
Merge "Cleanup"
2013-03-28 06:16:40 +00:00
Jean Chalard
28d5f4577f
Fix an NPE
...
The code was passing the wrong parameter.
Bug: 8492879
Change-Id: I091d62ca29601e3807eed287c7bdad38bf43a502
2013-03-28 15:08:05 +09:00
Jean Chalard
dae90cfb01
Cleanup
...
Seems there was an unclosed cursor :o
Change-Id: I7616849ace5217d8c6f54465f7b3a634e3c14116
2013-03-28 14:43:32 +09:00
Satoshi Kataoka
f463b45d8e
Merge "Fix Possible NPE"
2013-03-27 04:51:48 +00:00
Satoshi Kataoka
2cdf5351aa
Merge "Fix possible SIOOBE"
2013-03-27 03:28:49 +00:00
Satoshi Kataoka
33306acfa4
Fix possible SIOOBE
...
Bug: 8461021
Change-Id: I8b0385610b80b5a672ec380935c485a0e01ae984
2013-03-27 12:25:02 +09:00
Kurt Partridge
39cb0334d9
Avoid NPE
...
Initialize FeedbackLog earlier to avoid NPE
Change-Id: I646944c68a7d092345def16060b2a4edd8c7dbef
2013-03-26 16:46:43 -07:00
Kurt Partridge
189be5196a
Split LogUnits differently.
...
Previously an autocorrection caused a new LogUnit to be started,
splitting off the previous LogUnit right at the autocorrection method
time. This change causes the split to happen before the MotionEvents
that led to the autocorrection being called.
Change-Id: I2504df8eb47ee77e5f46bac34a8450636c03fd9f
2013-03-26 16:46:43 -07:00
Kurt Partridge
cb25e1fe37
Reorder ResearchLogger call
...
Previously, ResearchLogger#onWordFinished() was called with an outdated parameter value for
isBatchMode, causing it to report false even for gestures. This changes fixes this problem.
Change-Id: Ifcabee236ba5fe20376ad882155d3f3142cd7613
2013-03-26 14:37:57 -07:00
Kurt Partridge
ef103e1f2e
Merge "Close ResearchLogger upon onFinishInputView"
2013-03-26 19:23:00 +00:00
Tadashi G. Takaoka
73d00e68d8
Merge "Use XmlPullParser.getEventType()"
2013-03-26 05:38:18 +00:00
Satoshi Kataoka
435cccb2c5
Fix Possible NPE
...
Bug: 8448448
Change-Id: Ibe89c9abd24c4debb33a69c372eadf2afb09ea1c
2013-03-26 13:02:23 +09:00
Satoshi Kataoka
0b3271010f
Merge "Fix possible NPE"
2013-03-26 03:49:06 +00:00
Tadashi G. Takaoka
52f4b04768
Use XmlPullParser.getEventType()
...
Change-Id: Ie423d3416639f81409cc920658c8088b7519b045
2013-03-26 12:13:56 +09:00
Tadashi G. Takaoka
d17b69ec00
Clean up XmlParserUtils
...
Change-Id: I636e8f359d47f39e61a7f77e3e686f2721779b6f
2013-03-26 12:03:07 +09:00
Kurt Partridge
6d71d238e2
[FileEncap18] Clean up uploading scheduling
...
- Move scheduling logic from ResearchLogger.java to
UploaderService.java
- Switch to a one-shot timer. Previously the uploader was scheduled
on an inexact repeating schedule. It's better to reschedule the
next upload after the current one is finished to reduce the chances
of multiple uploads happening at the same time.
- Avoid double-execution
- Previously a scheduled upload might run right after an explicit
one if they occured at the same time. This change reduces the
chances of this.
- Some method extraction and naming
Change-Id: I9efda11be77d334c7f61bd40a36d65f0421ebde4
2013-03-25 17:50:26 -07:00
Kurt Partridge
87bc3a4a62
Close ResearchLogger upon onFinishInputView
...
Previously, ResearchLogger#stop() was called both in
LatinIME#onFinishInputView() and in LatinIME#onWindowHidden(). This
resulted in multiple logs being written.
Since onFinishInputView is the more reliable of the two (it is called
in InputMethodService#onDestroy; onWindowHidden is not), the code now
uses onFinishInputView as a stopping signal.
Change-Id: Iae4b8c3bdab226027624eeab19b3737367e4a108
2013-03-25 17:31:25 -07:00
Satoshi Kataoka
a17dccbfc6
Fix possible NPE
...
Bug: 8457109
Change-Id: I321fbef53e20a7c36ef4bd9f544b50abe6a52be9
2013-03-25 19:00:38 +09:00
Tadashi G. Takaoka
fb658d6c53
Fix possible ArrayIndexOutOfBoundsException
...
Bug: 8461864
Change-Id: Icd8f4f51ec064461c08d00c1c58bedf5fbae2553
2013-03-25 12:37:04 +09:00
Alan Viverette
a7b4398c35
Don't announce changes for A11y within the same keyboard mode.
...
Bug: 8439108
Change-Id: If9f14bb65625468dcd399df47ad0d2123be30be7
2013-03-22 11:53:12 -07:00
Satoshi Kataoka
19a7008728
Merge "Fix appname"
2013-03-22 07:23:08 +00:00
Satoshi Kataoka
3c8117c88f
Fix appname
...
Bug: 6789579
Change-Id: Ic4694e36e0846af95fa8dcdef919be251983b528
2013-03-22 16:19:44 +09:00
Tadashi G. Takaoka
3a8a63c399
Remove unused import
...
This is a follow up of I062c076f.
Change-Id: Ic3a83d95aed1f86121ed552a6f20f0d24f9d6d83
2013-03-22 15:23:06 +09:00
Tadashi G. Takaoka
c6452f2569
Merge "Remove reference to string.english_ime_name"
2013-03-22 05:11:50 +00:00
Satoshi Kataoka
f4352c2ce3
Merge "Use correct appname resource"
2013-03-22 05:11:26 +00:00
Satoshi Kataoka
242c066dde
Use correct appname resource
...
Bug: 6789579
Change-Id: Id11435a28d6c5b6c72867814e23f5e62429080f8
2013-03-22 14:08:38 +09:00
Tadashi G. Takaoka
9f3774c194
Remove reference to string.english_ime_name
...
Bug: 6789579
Change-Id: I062c076f0ca16cc39274e20955aa83d667b7380d
2013-03-22 14:08:23 +09:00
Tadashi G. Takaoka
ee91bde16c
Clean up InflateException reference from KeyboardBuilder
...
Change-Id: If9daa00b6d829ce2069a027e4bfec310ec108615
2013-03-21 12:27:33 +09:00
Alan Viverette
9da7fa0f50
am 559616fb
: Prevent keyboard A11y proxy from referencing a null keyboard view.
...
* commit '559616fb0c39e2f0bacdf294b84ba16ad1e8f371':
Prevent keyboard A11y proxy from referencing a null keyboard view.
2013-03-19 23:59:56 +00:00
Alan Viverette
559616fb0c
Prevent keyboard A11y proxy from referencing a null keyboard view.
...
Bug: 8402674
Change-Id: I507cdabccdabb3fd7aebc071c93eb6d4dcb9635d
2013-03-19 13:17:42 -07:00
Satoshi Kataoka
a462cd80ae
Support feedback
...
Bug: 8143554
Change-Id: If0a6bafc94da040f97f27c6d046fb58bed9fd615
2013-03-19 17:25:55 +09:00
Jean Chalard
8e005f2989
am 1061bfdb
: Break dependencies to allow offdevice tests to build
...
* commit '1061bfdb34bbcb63bf0046eec42313d264ac33fa':
Break dependencies to allow offdevice tests to build
2013-03-19 08:12:50 +00:00
Jean Chalard
6d90a10a34
am 0cc0544a
: Merge the dictionary pack in Latin IME.
...
* commit '0cc0544a2995c7eb54a830ae54db60af89d4073d':
Merge the dictionary pack in Latin IME.
2013-03-19 08:12:49 +00:00
Jean Chalard
1061bfdb34
Break dependencies to allow offdevice tests to build
...
Change-Id: Ia9a2e8f0672b3f72943f26fb15de1d3c7c5ce7f1
2013-03-19 16:45:25 +09:00
Jean Chalard
0cc0544a29
Merge the dictionary pack in Latin IME.
...
Bug: 8161354
Change-Id: I17c23f56dd3bc2f27726556bf2c5a9d5520bd172
2013-03-19 15:40:14 +09:00
Tadashi G. Takaoka
841c295f3c
resolved conflicts for merge of 5b048292
to master
...
Change-Id: I67ebab46954cd7b8e3e79e7fed523bafb15f8835
2013-03-19 10:48:10 +09:00
Ken Wakasa
9c3860ce46
Rename ProductionFlag.IS_EXPERIMENTAL to USES_DEVELOPMENT_ONLY_DIAGNOSTICS
...
bug: 8393568
Change-Id: Ie5edf44a3627aca9416145aff56bf05bbf2a05f3
2013-03-18 23:15:47 +09:00
Jean Chalard
f8325ec4bb
am 5cb0560b
: Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev
...
* commit '5cb0560b000f37b3fb3937f01b6d3e928afef57a':
Access the dictionary pack only if have INTERNET permission
2013-03-18 11:08:52 +00:00
Jean Chalard
5cb0560b00
Merge "Access the dictionary pack only if have INTERNET permission" into jb-mr2-dev
2013-03-18 11:04:53 +00:00
Jean Chalard
ce487bcf33
Access the dictionary pack only if have INTERNET permission
...
Bug: 8161354
Change-Id: I68ee3acb2955a017d25666cc2dad791798f9064a
2013-03-18 18:40:33 +09:00
Satoshi Kataoka
62ed594c37
am e0e67373
: Refactor parameters by naming convention
...
* commit 'e0e67373735918c78eaeaf24f127e1d28816aa29':
Refactor parameters by naming convention
2013-03-18 06:47:10 +00:00
Satoshi Kataoka
e0e6737373
Refactor parameters by naming convention
...
Change-Id: I8bda8075b33f656ecbec08320afcd864b620fe77
2013-03-18 15:42:15 +09:00
Tadashi G. Takaoka
3268a44e1c
am a5067333
: Disable the header list of DebugSettingsActivity
...
* commit 'a50673330e012f6cca02b83eca1c047b8da319e0':
Disable the header list of DebugSettingsActivity
2013-03-15 07:10:00 +00:00
Tadashi G. Takaoka
a50673330e
Disable the header list of DebugSettingsActivity
...
This change addresses the issue that the debug settings on 10-inch
tablet doesn't show up.
Change-Id: I60540cf21276869a3ca81b7b0154056ce7d93ff1
2013-03-15 15:33:27 +09:00
Kurt Partridge
f33f1cab2f
[FileEncap9] Extract ResearchLogDirectory class
...
Previously used a monotonically increasing int. Now uses uuid and nanoseconds.
squashed in:
[FileEncap11] Read preference from ResearchSettings
Change-Id: Ic779e0a69db6b16e92c6f4b63dbe7b7add566ab6
[FileEncap12] Simplify directory cleanup invocation
Change-Id: I688047409c0343d32b11447fb625dfb726c731ec
[FileEncap14] Change log filename syntax
Change-Id: I9243b20b2eb392f81ab8c5c3d19315211240e0bc
Change-Id: I5c9d70e0cb7b0965158e17dd71dfab796bd9a440
2013-03-14 06:37:56 -07:00
Kurt Partridge
7faa2caa80
Merge "[Lazy4] Remove useless debug code"
2013-03-14 13:13:57 +00:00
Tadashi G. Takaoka
fb606c6277
am f0864b1d
: Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev
...
* commit 'f0864b1d95411ce9886a5ade13f42cb17f578828':
Clean up StaticInnerHandlerWrapper a bit
2013-03-14 03:44:00 +00:00
Tadashi G. Takaoka
f0864b1d95
Merge "Clean up StaticInnerHandlerWrapper a bit" into jb-mr2-dev
2013-03-14 03:41:01 +00:00
Tadashi G. Takaoka
1ab33383f9
am 0d5f214a
: Fix NPE found in monkey test
...
* commit '0d5f214aa774ab0ab7c17521984caae11c9f4c2b':
Fix NPE found in monkey test
2013-03-14 03:39:38 +00:00
Tadashi G. Takaoka
41e60bf6dd
Clean up StaticInnerHandlerWrapper a bit
...
Change-Id: Ib07efe6da1eb2f0fd9ef68ca71502c98f7e19f4b
2013-03-14 12:35:47 +09:00
Tadashi G. Takaoka
0d5f214aa7
Fix NPE found in monkey test
...
Bug: 8383127
Change-Id: Ifd70acabe118b477f103937c7f1e99e38e210833
2013-03-14 12:19:10 +09:00
Tadashi G. Takaoka
f5caf5be99
am 601a8582
: Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev
...
* commit '601a8582d0f761a85b6eb16e7a6b78402f6f2599':
Move checking non-persistent checkbox to onResume
2013-03-14 02:33:28 +00:00
Satoshi Kataoka
0b2512017e
am 0ab44b21
: Merge "Make isInternal mutable" into jb-mr2-dev
...
* commit '0ab44b21bd6ef5e9fde329b25dfd84f6ca5c0825':
Make isInternal mutable
2013-03-13 17:24:49 +00:00
Kurt Partridge
64b9596544
Merge "[Lazy2] Pass a runnable to abort"
2013-03-13 13:20:55 +00:00
Jean Chalard
8067b769f1
Merge "[DO NOT MERGE] Deactivate H/W keyboard handling" into jb-mr2-dev
2013-03-13 10:55:04 +00:00
Tadashi G. Takaoka
601a8582d0
Merge "Move checking non-persistent checkbox to onResume" into jb-mr2-dev
2013-03-13 07:52:35 +00:00
Satoshi Kataoka
0ab44b21bd
Merge "Make isInternal mutable" into jb-mr2-dev
2013-03-13 07:41:11 +00:00
Satoshi Kataoka
756791e6bf
Make isInternal mutable
...
Change-Id: Ib81ceba801be0ac7ef65c4eadd1ec8599e80dacc
2013-03-13 16:28:50 +09:00
Tadashi G. Takaoka
24cea7f1fb
Move checking non-persistent checkbox to onResume
...
Bug: 8336068
Change-Id: I07e67a6aee24a239a21e6fc69eb2ec741b9a5b2b
2013-03-13 15:54:33 +09:00
Jean Chalard
13a82d9530
[Lazy2] Pass a runnable to abort
...
Change-Id: I721afbf426099753aa876a55323eb806b08c24d6
2013-03-12 18:56:57 -07:00
Kurt Partridge
5e75e15a95
Merge "[Lazy1] Switch to blocking log closures"
2013-03-13 00:18:02 +00:00
Jean Chalard
7423005b96
[Lazy1] Switch to blocking log closures
...
Change-Id: I4daec20b7b47b0d71c5aab6e17cd660015e19e71
2013-03-12 17:09:08 -07:00
Tadashi G. Takaoka
dbfd2825c8
am 2bbd3065
: Language dependent single/doule quotation more keys
...
* commit '2bbd3065d3bd9785ad1638c65f8c73f11bf21922':
Language dependent single/doule quotation more keys
2013-03-12 05:57:30 +00:00
Tadashi G. Takaoka
2bbd3065d3
Language dependent single/doule quotation more keys
...
The natural way of marking quoted text vary from language to
language. This change introduces the following variations.
* LEFT and RIGHT quotations (English etc.)
* LOW-9 and LEFT quotations (German etc.)
* LOW-9 and RIGHT quotations (Dutch etc.)
* RIGHT and RIGHT quotations (Swedish etc.)
* LEFT ANGLE and RIGHT ANGLE quotations (French etc.)
* RIGHT ANGLE and LEFT ANGLE quotations
Bug: 8356419
Change-Id: I75726ab7ed783d02f189b46236c9d5079737bcff
2013-03-12 14:43:34 +09:00
Jean Chalard
92eaa6fc7c
[DO NOT MERGE] Deactivate H/W keyboard handling
...
For MR2, LatinIME should not be handling hardware keyboard
events. The feature is still work in progress.
Change-Id: I56ff18bff84ba6b5a6bc3f8829b42eaf33b72554
2013-03-12 14:22:06 +09:00
Jean Chalard
220b271dfa
[Lazy4] Remove useless debug code
...
This code is cluttering readability and getting in the way
of future updates.
Future updates will make it much easier to debug and to
test this code, so this needs to disappear.
Change-Id: I32e28ec608587b6b7c07250a2692b13e8fc98465
2013-03-08 17:46:00 -08:00
Svetoslav Ganov
2d9b7f60dd
am af37cbb4
: Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev
...
* commit 'af37cbb44ef40fcd15fa02456c9abda8021847ce':
Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
2013-03-08 19:24:25 +00:00
Svetoslav Ganov
af37cbb44e
Merge "Announce keyboard mode changes as a WINDOW_STATE_CHANGED event." into jb-mr2-dev
2013-03-08 19:20:00 +00:00
Tadashi G. Takaoka
60906d4d08
am 914d054e
: Move logic of selecting key preview attribute to Key class
...
* commit '914d054ea26d18a1ba6a60f8c5e749136477bbf2':
Move logic of selecting key preview attribute to Key class
2013-03-08 11:24:13 +00:00
Tadashi G. Takaoka
914d054ea2
Move logic of selecting key preview attribute to Key class
...
This change also fixes the size of a key preview letter to follow a
keyLabelFlags specification.
Change-Id: Ie13790788a16c5a053c1a2cbcac3d38314b14b7f
2013-03-08 19:44:22 +09:00
Kurt Partridge
bba39b9b67
[FileEncap8] Remove useless "success" variable
...
Change-Id: Icf76bc0b795b6a9221d9a6d61c38df31af54ab7b
2013-03-07 17:43:35 -08:00
Kurt Partridge
ee3261ff55
[FileEncap7] Extract uploadContents method
...
Change-Id: I018b2726533042dbcb25713ea039aec41c148db2
2013-03-07 17:43:28 -08:00
Kurt Partridge
4436446e9b
[FileEncap6] Extract Uploader class
...
Gerrit was stuck on original change I9ef4eb7450
Change-Id: I6d4ee686944074779aca5b09b018782c7033874d
2013-03-07 16:19:44 -08:00
Alan Viverette
c2ee72a214
Announce keyboard mode changes as a WINDOW_STATE_CHANGED event.
...
Bug: 8165295
Change-Id: Ie416f6cdb68377f3e06f30e9b6363c38ba2a602d
2013-03-07 10:39:55 -08:00
Kurt Partridge
41c471d93d
Merge "[FileEncap5] Move conditional logic to caller"
2013-03-06 20:59:04 +00:00
Kurt Partridge
1bc20700d5
Merge "[FileEncap4] Simplify logic"
2013-03-06 20:05:47 +00:00
Kurt Partridge
719bb3aa39
Merge "[FileEncap3] Extract isUploadingUnconditionally method"
2013-03-06 19:14:52 +00:00
Kurt Partridge
5e5b6b7870
Merge "[FileEncap2] Remove mCanUpload instance variable"
2013-03-06 18:39:07 +00:00
Kurt Partridge
b000e94eea
Merge "[FileEncap1] Extract hasUploadingPermisssions method"
2013-03-06 18:02:26 +00:00
Kurt Partridge
9283644c41
[FileEncap5] Move conditional logic to caller
...
Change-Id: I6599539059f86dc8902210d325439c08035b2e2a
2013-03-06 07:19:41 -08:00
Kurt Partridge
88f466678c
[FileEncap4] Simplify logic
...
Change-Id: Ibb8660d12812b867856259d3e5c04a31e281027d
2013-03-06 07:19:41 -08:00
Kurt Partridge
7f7850d23a
[FileEncap3] Extract isUploadingUnconditionally method
...
- remove isUploadingUnconditionally local variable
Change-Id: I69be8708c1f306568cbb9c5cbefc9e42a87df497
2013-03-06 07:19:41 -08:00
Kurt Partridge
466e665b3c
[FileEncap2] Remove mCanUpload instance variable
...
Change-Id: I62a100c4d73bb64a14a7994f7dd9af7b6946d064
2013-03-06 07:19:41 -08:00
Kurt Partridge
347b2ebebf
[FileEncap1] Extract hasUploadingPermisssions method
...
Change-Id: Ica1dabcf066cde6580035f12fa35a404cb32fb3f
2013-03-06 07:19:41 -08:00
Kurt Partridge
68b3e4e7d3
Merge changes I2ded3d0a,I27ad9dfb
...
* changes:
Little cleanups
Clean up initialization ordering
2013-03-06 15:08:08 +00:00
Kurt Partridge
dc89d76f6b
Merge "Make some methods visible for testing"
2013-03-06 03:43:55 +00:00
Kurt Partridge
25343124dd
Make some methods visible for testing
...
bug: 8302967
multi-project commit with Icf915abb57ef00840ee93b67a25db42ba51f1c38
Change-Id: I105bda5bdff871508140fb99487dddbf17992790
2013-03-05 19:28:31 -08:00
Kurt Partridge
84bc16af3e
Little cleanups
...
Change-Id: I2ded3d0a29610941fac27c9b26168dd6c06ceccc
2013-03-05 18:37:44 -08:00
Kurt Partridge
4eeb90cd72
Clean up initialization ordering
...
This change is based on an earlier one that got stuck in Gerrit: Iab77504b
Change-Id: I27ad9dfb1bbb2300bd1e61d881a6ea0e116db066
2013-03-05 18:37:00 -08:00
Kurt Partridge
60f51684f1
Merge "Clean up logic in onUserLoggingConsent"
2013-03-05 16:43:08 +00:00
Tadashi G. Takaoka
249c887008
am 84fa8043
: Merge "Add show setup wizard icon preference settings" into jb-mr2-dev
...
* commit '84fa8043e6bef47378b3fc32c277e33034d5c174':
Add show setup wizard icon preference settings
2013-03-05 06:30:33 +00:00
Tadashi G. Takaoka
2e1b55f796
Add show setup wizard icon preference settings
...
Bug: 8239067
Change-Id: If6106a3632d3abad3e22ce29f1351525a5152ec7
2013-03-05 14:56:41 +09:00
Kurt Partridge
157c00145b
Clean up logic in onUserLoggingConsent
...
- Make ResearchSetting for whether the user has seen the splash screen
- Inline #setLoggingAllowed, which is short and is now only called by
onUserLoggingConsent
Change-Id: Icdf4592777b80643807b6ccf1d3896459c503e02
2013-03-04 12:05:03 -08:00
Kurt Partridge
75e6fb68e9
Clean up PREF_USABILITY_STUDY_MODE
...
- Refer to a common default value in DebugSettings
- Make PREF_USABILITY_STUDY_MODE independent of the ResearchLogger
- ResearchLogger uses its own preference through ResearchSettings
multi-project commit with Ie0df836c9d779eba484b522666ec357f4e234823
Change-Id: I88547a2f619db6e7364abbbec12f9f76855dd11a
2013-03-04 12:05:03 -08:00
Kurt Partridge
788dc55662
Merge "Remove MainLogBuffer#setSuggest()"
2013-03-04 15:10:31 +00:00
Ken Wakasa
31a5386794
am a8d3d509
: Small cleanup in CompatUtils
...
* commit 'a8d3d50970cecf961940efc0e908fbb2f9b35472':
Small cleanup in CompatUtils
2013-03-04 03:56:05 +00:00
Ken Wakasa
a8d3d50970
Small cleanup in CompatUtils
...
Change-Id: I9b4a8d7eae744ba6252a6475b75240248c70a3c0
2013-03-02 17:18:18 +09:00
Kurt Partridge
a8e668c81e
Merge "Move UUID preference reading to ResearchSettings.java"
2013-03-02 01:50:03 +00:00
Kurt Partridge
b094372bd6
Remove MainLogBuffer#setSuggest()
...
multi-project commit with Ia98b1406fc2ee11a96893c77ea58d800fece7624
Change-Id: I8bc3d07b83dbe7d8fc56a618de07dade7f510b13
2013-03-01 13:32:11 -08:00
Tadashi G. Takaoka
578e71e28b
am 99b0dc6f
: Merge "Add setup wizard launcher icon" into jb-mr2-dev
...
* commit '99b0dc6f0d18f5fdd8634e8fa533bf1b3f81a538':
Add setup wizard launcher icon
2013-03-01 16:13:45 +00:00
Tadashi G. Takaoka
99b0dc6f0d
Merge "Add setup wizard launcher icon" into jb-mr2-dev
2013-03-01 16:08:09 +00:00
Kurt Partridge
bc2588708a
Merge "[TestPrep22] Make variable package-private for testing"
2013-03-01 14:48:43 +00:00
Tadashi G. Takaoka
1ffdaafd83
Add setup wizard launcher icon
...
The setup wizard icon will be hidden if the Android Keyboard is in
system image.
Bug: 8239067
Change-Id: Ib0c0c9e3a0954512c3e03e42a661cdf86eff0dca
2013-03-01 22:28:00 +09:00
Jean Chalard
31747ba787
am abaf5827
: Separate suggestions from SuggestionView
...
* commit 'abaf5827e7a7f5f6c5d8d98e03e6b9528b0c9351':
Separate suggestions from SuggestionView
2013-03-01 05:17:52 +00:00
Jean Chalard
abaf5827e7
Separate suggestions from SuggestionView
...
This is a cleanup change, but it's also necessary for
Bug: 8152758
Change-Id: Id6ba06243f573fdb856f87d1df03277c9f2e5e71
2013-02-28 21:03:18 -08:00
Kurt Partridge
00ed4704f9
Move UUID preference reading to ResearchSettings.java
...
Change-Id: I8157249259cf8c3218c5c82a5729f4cbc1fb4eeb
2013-02-28 19:54:21 -08:00
Kurt Partridge
9ba7ad8d4f
Merge "[TestPrep20] Clean up import statement"
2013-03-01 01:32:35 +00:00
Tadashi G. Takaoka
040b442f3c
am 18e21d58
: Remove closing method from KeyboardView
...
* commit '18e21d58f7c0b5c5c001835c093221c573a841c4':
Remove closing method from KeyboardView
2013-02-28 22:38:11 +00:00
Kurt Partridge
59912837b3
[TestPrep22] Make variable package-private for testing
...
Change-Id: I902a6a40df1c672c611672f34d2f3237b0d1821b
2013-02-28 06:45:35 -08:00
Kurt Partridge
5cd50faaca
[TestPrep20] Clean up import statement
...
Change-Id: Ifcfec09b669d8b2012b1c960bd4b1471c7946870
2013-02-28 06:45:34 -08:00
Kurt Partridge
abaa88fd4e
Merge "[TestPrep18] Make class public for testing"
2013-02-28 01:00:46 +00:00
Kurt Partridge
a04fbce412
Merge "[TestPrep17] Allow fake dictionary for testing"
2013-02-27 23:59:01 +00:00
Tadashi G. Takaoka
2ed1ec411d
am 016046eb
: Keep Keyboard object while closing KeyboardView
...
* commit '016046eb4e3ea28745b9a29c41c126801f177f58':
Keep Keyboard object while closing KeyboardView
2013-02-27 23:22:32 +00:00
Tadashi G. Takaoka
18e21d58f7
Remove closing method from KeyboardView
...
This is a follow up of Ie00ba827. After the change, the
KeyboardView.closing() method does nothing important.
Change-Id: I9659ea56ce82a95f8798a4136bf93f164b67fae7
2013-02-27 17:35:20 +09:00
Tadashi G. Takaoka
016046eb4e
Keep Keyboard object while closing KeyboardView
...
Bug: 8217626
Change-Id: Ie00ba827bc391aa152427965c57488b66308a75c
2013-02-27 17:30:16 +09:00
Kurt Partridge
424a976e58
Merge "Ensure Preference listener is unregistered"
2013-02-27 03:49:40 +00:00
Kurt Partridge
96d019f183
[TestPrep18] Make class public for testing
...
Change-Id: I4b457f44dd6a5a595c61a62061ea02c251fa9ab1
2013-02-26 19:22:56 -08:00
Kurt Partridge
5ee261a990
[TestPrep17] Allow fake dictionary for testing
...
Currently ResearchLog requires a full dictionary to perform privacy-related checks.
This makes testing difficult. This change allows a fake dictionary to be used instead.
Change-Id: Ifca5bd8647475a6b84e4324117e0faa0a35479ee
2013-02-26 19:22:55 -08:00
Kurt Partridge
7e2c1e69bf
Ensure Preference listener is unregistered
...
Change-Id: I1a4d1e7bc45fc30cb1b63ea6020f0eee6e804333
2013-02-26 18:40:34 -08:00
Kurt Partridge
64c34122f2
Merge "[TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call"
2013-02-27 00:41:12 +00:00
Kurt Partridge
62abc40d7d
Merge "[TestPrep10] Add some comments"
2013-02-26 23:09:48 +00:00
Kurt Partridge
f170f145af
[TestPrep11] Only use mHasWrittenData to control JsonWriter#endArray() call
...
Change-Id: If2107e38575b009a4c372194ecd827e27bdbb2b4
2013-02-26 15:02:52 -08:00
Kurt Partridge
a5e564bea0
[TestPrep10] Add some comments
...
Change-Id: Ia8e0bd72b0dc09bfc256ec5d1996637554376b5f
2013-02-26 15:02:52 -08:00
Tadashi G. Takaoka
183fe80031
Small cleanup of RunInLocale
...
Change-Id: Ib588e67da2c88345fc4eb51587b07ebfa434e0bb
2013-02-26 19:11:49 +09:00
Jean Chalard
0f3c05cd6b
Merge "Send the dictionaries descriptions to the dict pack"
2013-02-23 10:18:03 +00:00
Jean Chalard
c6799ffeab
Send the dictionaries descriptions to the dict pack
...
Bug: 8255795
Change-Id: I12a5922f50c2d2e3aa639457abcc1483e6a48721
2013-02-23 01:46:39 -08:00
Jean Chalard
76ead0ead0
Fix a possible crash
...
If the dictionary ID, as indicated in the metadata, is
less than three chars long, it crashes LatinIME.
Of course we don't have such dictionary IDs in the current
metadata, but it's still better to be able to handle
the case gracefully ^^;
Change-Id: I60cdf6f8ecce9f4d44b42ddd5d157aebff9a4163
2013-02-23 01:41:44 -08:00
Jean Chalard
aefaec3c5f
Remove a cluttering log
...
Bug: 8175067
Change-Id: I9a104a32ba2b3b52a5dfa250f8c642abd6169cc0
2013-02-23 00:48:10 -08:00
Jean Chalard
8b4023c4d6
Merge "Tiny cleanup"
2013-02-23 08:07:27 +00:00
Jean Chalard
2521edec09
Fix a bug with the passed dictionary id
...
We used to make the dictionary that we passed to the
dictionary pack as an initial value based on the locale.
This is wrong - it should be read from the dictionary.
This change fixes that.
Bug: 7005813
Change-Id: Ib08ed31dd9c216f6f7b9c6c3174ca514bf96e06f
2013-02-22 20:49:48 -08:00
Jean Chalard
da0d771fe9
Tiny cleanup
...
Change-Id: I5d7150a4abb3a498e790f41af569093217cb8b43
2013-02-22 19:42:45 -08:00
Jean Chalard
8f794c72db
Merge "Fix how the Enter action is decided"
2013-02-23 00:13:27 +00:00
Jean Chalard
4e4f88127b
Fix how the Enter action is decided
...
This unifies the software and hardware keyboard code
under a single decision process that works.
Bug: 8129303
Bug: 8152758
Change-Id: I7574c563d5f957d57bfe62fe5e3eec59a519d335
2013-02-22 16:01:37 -08:00