nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30085 commits 1 branch 0 tags 363 MiB
Commit graph

30085 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jean Chalard
0a0a3cdad8 Merge "Revert "Revert "Fix a race condition.""" 2014-01-08 08:35:19 +00:00
Jean Chalard
dd3d697a6e Fix a race condition, take 2. 
Don't use absolute cursor positions when making edits,
this leads to race conditions.
This is a bit ugly and will need to be fixed soon. Plans are
underway to clean this up.

Bug: 12390573
Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
 2014-01-08 17:19:29 +09:00
Jean Chalard
f628629f69 Revert "Revert "Fix a race condition."" 
This reverts commit 3840127244.

Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
 2014-01-08 16:44:43 +09:00
Tadashi G. Takaoka
ad78058a93 Rename InputPointers.addPointer and ResizableIntArray.add 
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
e13cc9d7e5 Fix ResizableIntArrayTests readability 
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
 2014-01-08 14:30:21 +09:00
Tadashi G. Takaoka
9b351f7594 Merge "Fix InputPointersTests" 2014-01-08 05:29:32 +00:00
Tadashi G. Takaoka
e7dc5302af Fix InputPointersTests 
InputPointers.getTime(int) has a validity check of time values. And
the check is enabled when LatinImeLogger.sDBG is on. Such situation
may occur while unit testing. This change ensure that time values are
monotonic while unit testing.

Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
 2014-01-08 14:14:42 +09:00
Keisuke Kuroyanagi
b3c51630a6 Fix: NPE in LatinIME.loadSettnigs(). 
Change-Id: Icae6c74401a7a8f4da6015737f09f557640c0cca
 2014-01-08 12:43:58 +09:00
Tadashi G. Takaoka
385031557b Merge "Separate spacing and punctuation related settings values" 2014-01-08 02:41:51 +00:00
Keisuke Kuroyanagi
f86b830986 Merge "Prepare using dictionaryFacilitator for amanatto updates." 2014-01-08 02:09:47 +00:00
Tadashi G. Takaoka
0b593ce858 Separate spacing and punctuation related settings values 
Bug: 12179576
Change-Id: Ibafd824a0ea2251843b388e95dcbd8f9bca92d5c
 2014-01-08 10:02:37 +09:00
Ken Wakasa
8bd658555d Merge "Revert "Fix a race condition."" 2014-01-07 23:57:07 +00:00
Victoria Lease
3840127244 Revert "Fix a race condition." 
This reverts commit 42e83c7f06.

Bug: 12434783
Change-Id: Id01b6d14906430b13e64f5fc4d7fb01572d0a960
 2014-01-07 23:26:54 +00:00
Baligh Uddin
917bd25925 am dd003a71: (-s ours) am 489fc1c5: (-s ours) am 17b06650: (-s ours) am bbba6d79: (-s ours) am 184e4d14: (-s ours) Import translations. DO NOT MERGE 
* commit 'dd003a71a710202279aa5d93b399f1e1d3a10898':
  Import translations. DO NOT MERGE
 2014-01-07 19:23:06 +00:00
Baligh Uddin
dd003a71a7 am 489fc1c5: (-s ours) am 17b06650: (-s ours) am bbba6d79: (-s ours) am 184e4d14: (-s ours) Import translations. DO NOT MERGE 
* commit '489fc1c58a696247b8d7525cd0869be9224e5412':
  Import translations. DO NOT MERGE
 2014-01-07 18:24:56 +00:00
Baligh Uddin
489fc1c58a am 17b06650: (-s ours) am bbba6d79: (-s ours) am 184e4d14: (-s ours) Import translations. DO NOT MERGE 
* commit '17b06650f17f674bb039e8937737a76cafa32e61':
  Import translations. DO NOT MERGE
 2014-01-07 18:21:50 +00:00
Baligh Uddin
17b06650f1 am bbba6d79: (-s ours) am 184e4d14: (-s ours) Import translations. DO NOT MERGE 
* commit 'bbba6d79b6eda0dc1ad05c679fc9e7f9df313bf6':
  Import translations. DO NOT MERGE
 2014-01-07 10:18:50 -08:00
Baligh Uddin
bbba6d79b6 am 184e4d14: (-s ours) Import translations. DO NOT MERGE 
* commit '184e4d14643e802e49ebbf6f533047d7cf27f2d5':
  Import translations. DO NOT MERGE
 2014-01-07 10:15:45 -08:00
Baligh Uddin
f2f0640800 Merge "Import translations. DO NOT MERGE" 2014-01-07 18:11:29 +00:00
Baligh Uddin
f75017de55 Import translations. DO NOT MERGE 
Change-Id: Ia0ef830a5bb3ed6fee1a5d113b2baec60bb51a97
Auto-generated-cl: translation import
 2014-01-07 07:27:26 -08:00
Baligh Uddin
184e4d1464 Import translations. DO NOT MERGE 
Change-Id: I3e0560396e087669ff484b6c15d0f0eb03c02de5
Auto-generated-cl: translation import
 2014-01-07 07:26:33 -08:00
Keisuke Kuroyanagi
8a2537e0ae Merge "Update personalized dict only when single subtype is used." 2014-01-07 09:19:29 +00:00
Keisuke Kuroyanagi
c09fd175c3 Prepare using dictionaryFacilitator for amanatto updates. 
Bug: 11736529
Change-Id: I0d9d9b1c1108b11064163df7c2089f53e92cd7ad
 2014-01-07 18:11:23 +09:00
Keisuke Kuroyanagi
55713e3695 Update personalized dict only when single subtype is used. 
Bug: 12424891
Change-Id: If041d1ab45988dbf9b878ae3367fee0fbc8a8988
 2014-01-07 18:10:27 +09:00
Jean Chalard
42e83c7f06 Fix a race condition. 
Don't use absolute cursor positions, this leads to race
conditions.

Bug: 12390573
Change-Id: I6f04f07a46babbc3d51cb94c7eaee21bed242396
 2014-01-07 15:33:04 +09:00
Keisuke Kuroyanagi
6d5f9fd3d1 Merge "Fix possible NPE." 2014-01-06 09:53:15 +00:00
Keisuke Kuroyanagi
8214a8c2cf Fix possible NPE. 
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
 2014-01-06 17:56:49 +09:00
Tadashi G. Takaoka
74b5291b84 Merge "Remove language switch key from symbols and symbols shift keyboard" 2014-01-06 06:19:27 +00:00
Tadashi G. Takaoka
d561228f95 Remove language switch key from symbols and symbols shift keyboard 
This change also fixes the background color of the left keys of the space key.

Bug: 12407208
Change-Id: Id869605146e9f72835f892c3c7ae14f118177394
 2014-01-06 15:02:50 +09:00
Tadashi G. Takaoka
3f8c6b8c54 Merge "Add description of disabled voice input key option" 2014-01-06 03:25:15 +00:00
Tadashi G. Takaoka
12ba821bfb Add description of disabled voice input key option 
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
 2014-01-06 12:11:55 +09:00
Tadashi G. Takaoka
e91559a119 Merge "Update shortcut IME info before checking availability of it" 2014-01-06 03:07:23 +00:00
Tadashi G. Takaoka
e9584a1612 Merge "Add DictionaryFacilitatorForSuggest constructor for testing" 2014-01-06 02:58:12 +00:00
Tadashi G. Takaoka
b7c531b751 Update shortcut IME info before checking availability of it 
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
 2014-01-06 11:54:46 +09:00
Tadashi G. Takaoka
49b5fadae1 Add DictionaryFacilitatorForSuggest constructor for testing 
This change must be checked in together with I00b6e79d6b.

Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
 2014-01-06 11:00:51 +09:00
Jean Chalard
1e50c681af [IL52] Remove a useless method. 
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.

Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.

Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
 2013-12-27 22:40:19 +09:00
Jean Chalard
8ce921dd6b [IL51] Make private what can be made private 
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
 2013-12-27 21:09:47 +09:00
Jean Chalard
53c320e275 [IL50] Move the InputUpdater out of LatinIME. 
...at last

Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
 2013-12-27 21:09:41 +09:00
Jean Chalard
81e0ca5fd3 [IL49] Move InputLogic-related init code to InputLogic. 
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
 2013-12-27 20:06:39 +09:00
Jean Chalard
4970eda286 Fix a failing test 
How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
 2013-12-27 20:04:41 +09:00
Jean Chalard
d05ea8bd82 Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic." 2013-12-27 08:06:48 +00:00
Jean Chalard
af26a44102 Merge "[IL47] Inline getSuggestedWordsGestureLocked" 2013-12-27 08:04:51 +00:00
Jean Chalard
51e79fb4b2 Merge "[IL46] Remove a useless message passing." 2013-12-27 07:56:56 +00:00
Jean Chalard
2fc1cc099f Merge "[IL45] Remove lingering messages" 2013-12-27 07:56:44 +00:00
Jean Chalard
c654fe57b1 [IL48] Move onEndBatchInputAsyncInternal to InputLogic. 
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
 2013-12-27 16:50:08 +09:00
Jean Chalard
4a144b9b4d [IL47] Inline getSuggestedWordsGestureLocked 
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.

Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
 2013-12-27 16:50:08 +09:00
Jean Chalard
71a3e96382 [IL46] Remove a useless message passing. 
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords

The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.

Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
 2013-12-27 16:50:06 +09:00
Jean Chalard
0d21223521 Merge "[IL44] Some factorization" 2013-12-27 06:58:12 +00:00
Jean Chalard
31ff2a4335 [IL45] Remove lingering messages 
Bug: 8636060
And possibly bug: 12085864

Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
 2013-12-27 15:34:30 +09:00
Jean Chalard
69e7a0d24d [IL44] Some factorization 
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.

Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
 2013-12-27 15:34:26 +09:00