25270ec540
Merge "Check probability before adding to the user history dict."
2014-01-28 07:35:31 +00:00
36fda2bae3
Merge "[IL96] Inline a method"
2014-01-28 07:31:48 +00:00
90ac041c9f
Check probability before adding to the user history dict.
...
Bug: 12764888
Change-Id: I5da3ef21d9d82b7034e7dc9b7d0fdca0d48a49f4
2014-01-28 16:31:37 +09:00
7593f93565
Merge "[IL95] Inline a method that's always called in sequence"
2014-01-28 07:31:31 +00:00
bcd30bf3e7
Suggestion strip honors RTL layout
...
Bug: 9126496
Change-Id: Ia4a1c52bd2a80ea7fe6b9529f2767fee5f9e8aeb
2014-01-28 15:47:54 +09:00
86210c7dc7
[IL96] Inline a method
...
Bug: 8636060
Change-Id: I517591c484dce74788398cf4a4db9a074d91a6c0
2014-01-28 15:47:04 +09:00
90916143b6
[IL95] Inline a method that's always called in sequence
...
Bug: 8636060
Change-Id: I514cf14596b3fa46eccadcf536342e4bb805708d
2014-01-28 15:47:01 +09:00
02b087090e
Merge "Fix test fails caused by I8bede13c87"
2014-01-28 05:19:53 +00:00
0272553578
Merge "Fix inconsistent behavior with the spacebar on the Emoji pallete."
2014-01-28 05:06:07 +00:00
0e04c24a05
Fix inconsistent behavior with the spacebar on the Emoji pallete.
...
On the Emoji palette, unlike other layouts, a user could not
cancel events by moving the finger away from the spacebar.
With this patch, the actual handler of the spacebar will be
registered as onClick event, which will not occur when the user
cancel the event.
Bug: 12464067
Change-Id: I7e7e11ae5f17073e5d92116adca0702579d3ae9c
2014-01-28 13:44:31 +09:00
ca1c1ddd4e
Merge "[IL94] Remove a function and some reordering"
2014-01-28 03:46:28 +00:00
9909d6aa49
Merge "[IL93] Refactor a method inside another"
2014-01-28 03:32:52 +00:00
cbf54dea49
Merge "[IL92] Straighten out showSuggestionStripWithTypedWord"
2014-01-28 03:32:17 +00:00
5a1f837356
Merge "[IL91] Call reorder"
2014-01-28 03:26:23 +00:00
9ac6c9064d
Fix test fails caused by I8bede13c87
...
Change-Id: I1e816bf7ea5fd46b39c2482bbcbfcdc16d5acc21
2014-01-28 11:17:47 +09:00
c2e2b3949b
Merge "Add SubtypeLocaleUtils.isRtlLanguage method"
2014-01-28 01:28:47 +00:00
5b5e877efe
[IL94] Remove a function and some reordering
...
Bug: 8636060
Change-Id: I4baa237c9c7b58a8eb4158c34b9d3f3dfb95c69c
2014-01-27 20:38:45 +09:00
37e1cc931f
[IL93] Refactor a method inside another
...
The calls to setAutoCorrectionIndicator with a constant are
always the exact same as mWillAutoCorrect.
Bug: 8636060
Change-Id: I8106919819b978b0a9655af2ef444664fad4c1ad
2014-01-27 20:38:45 +09:00
4c6029e530
[IL92] Straighten out showSuggestionStripWithTypedWord
...
Bug: 8636060
Change-Id: I066ff29c76349f0ab61441ea5f7bc9085d24bdbc
2014-01-27 20:38:45 +09:00
c6367ee64d
[IL91] Call reorder
...
Bug: 8636060
Change-Id: I3d0ce6dcb3b51cabc424d00a397d243c32360e92
2014-01-27 20:38:43 +09:00
01893b25dd
Merge "[IL90] Small refactoring"
2014-01-27 11:18:52 +00:00
3f226af439
Merge "[IL89] Inline a function"
2014-01-27 11:18:19 +00:00
5b9e54c135
Merge "[IL88] Simple refactoring"
2014-01-27 11:17:54 +00:00
8f3e37a631
Merge "[IL87] Remove a call to clearSuggestionStrip"
2014-01-27 11:17:45 +00:00
521a83a3f1
Merge "[IL86] Simplification and correctness fix."
2014-01-27 11:17:31 +00:00
7aa7e36611
Merge "[IL85] Maybe show punctuations when app completions are null"
2014-01-27 11:17:18 +00:00
264f4e380d
Merge "[IL84] Remove a useless call and rename a method"
2014-01-27 11:17:05 +00:00
7ac542d490
Merge "[IL83] Inline a call"
2014-01-27 11:16:30 +00:00
47ff423121
Merge "[IL82] Fix a wrong comment"
2014-01-27 10:11:42 +00:00
75ec579e07
Merge "[IL81] Remove a useless test."
2014-01-27 10:11:14 +00:00
c0c74d22a0
Add SubtypeLocaleUtils.isRtlLanguage method
...
Change-Id: I2e399ae9ca111638b583c5681de08b0e6db86e3a
2014-01-27 19:05:16 +09:00
6d1c8b2c3f
Merge "Try to figure out whether d.quotes open or close."
2014-01-27 10:01:17 +00:00
b084da2ae6
Merge changes I5092942a,I931c553f
...
* changes:
[IL80] Reverse a test for clarity.
[IL79] Some refactoring
2014-01-27 10:00:37 +00:00
a3a85e8c2b
Merge "[IL78] Move most of onUpdateSelection to InputLogic."
2014-01-27 09:55:08 +00:00
d38b0468b0
[IL90] Small refactoring
...
Bug: 8636060
Change-Id: I37844ab1c5c61ea940897e7d72bb79c7b329f743
2014-01-27 18:42:33 +09:00
33ff321d6c
[IL89] Inline a function
...
We will then refactor the contents of showSuggestionStripWithTypedWord
Bug: 8636060
Change-Id: I8a2a0d50b79fcc7ad21b01a0060b9fa7e4c1bdd6
2014-01-27 18:42:33 +09:00
ca819178a1
[IL88] Simple refactoring
...
With this, the value passed to suggestedWords is never null.
Bug: 8636060
Change-Id: I433dd7e7290125e217e05cc20bee7a4b58fe083f
2014-01-27 18:42:33 +09:00
d90bdd2187
[IL87] Remove a call to clearSuggestionStrip
...
The goal is to remove the function completely.
Bug: 8636060
Change-Id: I50b8f0368c8f6506209398ff931881e2235c3d2d
2014-01-27 18:42:33 +09:00
3b939ed77f
[IL86] Simplification and correctness fix.
...
This should be what was intended.
Bug: 8636060
Change-Id: I20a1cc4f0b1fb9444fb6f9a20ef727e3d1a3a880
2014-01-27 18:42:33 +09:00
07eddf3c43
[IL85] Maybe show punctuations when app completions are null
...
When the app goes to the trouble of supplying completions,
but supplies null, then we should show punctuations if
settings allow.
Bug: 8636060
Change-Id: I33c32566039c80df61fcca3fab346fd336d96a12
2014-01-27 18:42:32 +09:00
b2c0388a69
[IL84] Remove a useless call and rename a method
...
Bug: 8636060
Change-Id: I5cac787953a3c71b6402520c2f5c70619d4a40a8
2014-01-27 18:42:32 +09:00
eb190ab32f
[IL83] Inline a call
...
The coming string of changes is very complicated, so
I'm going to do things really slowly.
Bug: 8636060
Change-Id: Id8a07a154ac514e9b3307ead22d47c3ae6fa732b
2014-01-27 18:42:32 +09:00
17f1528f9e
[IL82] Fix a wrong comment
...
Change-Id: I6e16b4e05010a08f4d1da34145f819c32b3bc79e
2014-01-27 18:42:32 +09:00
abbd755689
[IL81] Remove a useless test.
...
It seems the comments were right all along. This seems to really
be useless.
Bug: 8636060
Change-Id: Ie030e9cb73007334380d023abeaa4ce52a863a34
2014-01-27 18:42:32 +09:00
f1e5b9b4d1
[IL80] Reverse a test for clarity.
...
Bug: 8636060
Change-Id: I5092942ab4fd6aaf37023083040cadbc18583fd1
2014-01-27 18:42:32 +09:00
f59487379e
[IL79] Some refactoring
...
Bug: 8636060
Change-Id: I931c553f68a1f15d22711a661dbffd4e5d421979
2014-01-27 18:42:29 +09:00
10460441db
[IL78] Move most of onUpdateSelection to InputLogic.
...
Bug: 8636060
Change-Id: I7290250637e37bf6964bab71d2141e19f20a5459
2014-01-27 18:42:04 +09:00
1e4b1300e6
Merge "Refactor SuggestionsStripLayoutHelper class"
2014-01-27 09:36:52 +00:00
68d7291a6b
Merge "[IL77] Remove refs to Settings from InputLogic"
2014-01-27 09:29:50 +00:00
148dedbc5d
Refactor SuggestionsStripLayoutHelper class
...
Bug: 9126496
Change-Id: I8bede13c8745fbcad68099d882681ca4f2326d14
2014-01-27 18:25:25 +09:00
7bee84095e
Merge "[IL75] Move the SubtypeSwitcher out of InputLogic."
2014-01-27 09:24:10 +00:00
829ad708db
Merge "Revert "Use ViewCompat support library""
2014-01-27 09:20:19 +00:00
48df380f78
[IL77] Remove refs to Settings from InputLogic
...
Bug: 8636060
Change-Id: I4ce5c9b62181ce8593a453ce222ae7d1fdc08f07
2014-01-27 18:18:54 +09:00
969c06072d
[IL75] Move the SubtypeSwitcher out of InputLogic.
...
Bug: 8636060
Change-Id: I2a5da27e73cf378e55bd80ab2054c1ba8b13f6ec
2014-01-27 18:18:27 +09:00
c7ef305bbc
Try to figure out whether d.quotes open or close.
...
Bug: 8911672
Change-Id: I5d5635949530a67f95e5208986907251b7bce903
2014-01-27 18:17:33 +09:00
e4692c0050
Revert "Use ViewCompat support library"
...
This reverts commit e7ee4fa862
2014-01-27 18:14:40 +09:00
5cf70a1d44
Merge "[IL74] Remove unused/unwanted arguments to a method."
2014-01-27 08:57:12 +00:00
0b58617951
Merge "Fix inconsistent behavior with backspace in the Emoji pallete."
2014-01-27 08:11:51 +00:00
0fd556ceca
[IL74] Remove unused/unwanted arguments to a method.
...
Bug: 8636060
Change-Id: I3c5213cc57b5b5febd25f14d40c197d2da43dfb8
2014-01-27 16:48:17 +09:00
ea8c1c811c
Fix inconsistent behavior with backspace in the Emoji pallete.
...
In some ways, the delete key on the Emoji palette was
inconsistent with that in other keyboard layouts.
- It deletes a character in down events, not up events.
- A user cannot cancel the event by moving the finger away from
the key.
This patch fixes these inconsistencies by revisin
EmojiPalettesView.DeleteKeyOnTouchListener. Notable changes are:
- An explicit state machine is introduced because there are
different event sequences to be considered.
- Background thread is replaced with CountDownTimer so tha
key-repeat events can be naturally generated in the UI thread.
- MotionEvent.ACTION_MOVE is now handled to cancel the
subsequent delete key events when the finger is moved away
from the key area.
Bug: 12464067
Change-Id: Ibc360a1394afef368a8d9af7b4c0e99e8ce1d83c
2014-01-27 16:24:51 +09:00
f3ca92dd33
Merge "Use ViewCompat support library"
2014-01-27 07:21:41 +00:00
e7ee4fa862
Use ViewCompat support library
...
Change-Id: I4ba261752750f5087cba810045669512b430b5e0
2014-01-27 16:11:03 +09:00
03283b636c
Follow up to Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
...
some cleanups as well
Change-Id: I92252eb7b13cb70283a79f50429ed77405ea9575
2014-01-27 16:08:27 +09:00
95043145df
Merge "Check length of words for personalization dict."
2014-01-25 00:44:58 +00:00
b7197b705b
Check length of words for personalization dict.
...
Bug: 12602903
Change-Id: I1ea4e558b6d2fde425ce28226647ad60095e3488
2014-01-24 16:32:28 -08:00
0acd121083
Fix wrong indents.
...
Removed an unused method too.
Change-Id: Id364009fd4e94ec65862fc3651a181e862909a42
2014-01-24 23:55:33 +09:00
b6e128cc05
Merge "[IL69.1] Move a static method to a utility class."
2014-01-24 03:04:12 +00:00
1d6e647ac3
[IL69.1] Move a static method to a utility class.
...
This is a followup to IL69.
Change-Id: Iba154517aa7f75b9f16aa1b808c0da8d84be837f
2014-01-24 11:59:23 +09:00
0c72529088
Merge "[IL73] Remove all refs to Key and Keyboard in WordComposer"
2014-01-24 01:55:57 +00:00
3aa2043a66
Merge "[IL76] Remove a SuggestionStripView dependency"
2014-01-23 10:06:42 +00:00
f16a2a36d2
[IL71.1] Add some javadoc.
...
Change-Id: I382abd3104d535a1e868935d8cfb4e34ad8ebaed
2014-01-23 17:11:47 +09:00
a1ed211c4e
[IL76] Remove a SuggestionStripView dependency
...
This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.
Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
2014-01-23 16:25:48 +09:00
4173610bc5
[IL66.1] Add a comment
...
Followup to IL66
Change-Id: I067e72c36f483cc3e3b24736c01843531298b507
2014-01-23 16:00:49 +09:00
be846fc352
[IL73] Remove all refs to Key and Keyboard in WordComposer
...
Please hold my gun while I have this nice cup of tea.
Yes !!
Bug: 8636060
Change-Id: I33c8ffe51bb2106b17f7941235ad1e427e3a81f7
2014-01-23 15:52:29 +09:00
df8310c6e2
Merge "[IL71] Add indices to toCodePointArray."
2014-01-23 06:50:19 +00:00
1284e556f4
[IL70] Remove unused arguments
...
Bug: 8636060
Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
2014-01-23 15:33:14 +09:00
d1f463eacf
[IL69] Oust Keyboard from WordComposer#setComposingWord
...
Bug: 8636060
Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
2014-01-23 15:32:59 +09:00
9da4b49ef6
[IL68] Start refactoring setComposingWord
...
Bug: 8636060
Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
2014-01-23 15:15:49 +09:00
18638d30c0
[IL71] Add indices to toCodePointArray.
...
This is necessary for tests
Bug: 8636060
Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
2014-01-23 13:11:40 +09:00
eb6d41a525
[IL67] Externalize a call to the keyboard switcher
...
Bug: 8636060
Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
2014-01-23 13:10:02 +09:00
ab80b41a0d
[IL66] Remove two accesses to KeyboardSwitcher.
...
Bug: 8636060
Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
2014-01-23 13:09:58 +09:00
a91dfff5e5
[IL65] Pull up X,Y processing, step 4
...
This works because getKey{X,Y} is a no-op on
Constants.NOT_A_COORDINATE.
Bug: 8636060
Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
2014-01-22 14:44:27 +09:00
352286a43b
[IL64] Pull up X,Y processing, step 3
...
Bug: 8636060
Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
2014-01-22 14:44:25 +09:00
b8216a4e7e
[IL63] Pull up X,Y processing, step 2
...
This also fixes the coordinates passed to logOnDelete and
log onSeparator.
Bug: 8636060
Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
2014-01-22 14:42:52 +09:00
2b38b5e8e6
[IL62] Pull up X,Y processing, step 1
...
This is fine because getKey{X,Y} is idempotent for any
non-keyboard coordinate value.
However this makes a net change : the x,y values passed to
LatinImeLoggerUtils.onNonSeparator are now different.
The point is however that they used to be wrong. The logged
values used not to account for the keyboard padding that
is present on tablets, and in the simulating tools we don't
know about that padding so we couldn't use the coordinates.
The catch here is that other calls like LoggerUtils.onSeparator
should follow suit, but this is too big a change to do it at once.
Follow-up changes will fix them too.
Bug: 8636060
Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
2014-01-22 14:41:45 +09:00
591580ee8a
Merge "[IL61] Remove an internal use of key coordinates"
2014-01-22 05:19:45 +00:00
c93cf1c398
Use sorted int[] to represent word separators
...
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
2014-01-20 19:40:02 +09:00
5b6ebdbe9e
Merge "Refactor logic to retrieve relevant suggestions a bit"
2014-01-20 09:57:43 +00:00
837cdd738b
Add SpacingAndPunctuationsTests
...
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
2014-01-20 18:33:45 +09:00
3033cc51b8
Refactor logic to retrieve relevant suggestions a bit
...
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
2014-01-20 12:08:25 +09:00
3f3b0af5b7
Merge "Fix unit tests by adding @UsedForTesting"
2014-01-19 22:47:03 +00:00
fde4c5f128
Fix unit tests by adding @UsedForTesting
...
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
2014-01-19 13:37:23 -08:00
b1814c9633
Merge "Make contacts dict and user dict version 4."
2014-01-17 20:05:17 +00:00
ed95d79cc4
Make contacts dict and user dict version 4.
...
Bug: 12515251
Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
2014-01-17 10:30:16 -08:00
6a18af634e
Refactor RichInputConnection a bit
...
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
2014-01-17 13:14:29 +09:00
2334bf6d8c
Merge "Fix a bug specific to German capitalization."
2014-01-17 01:49:14 +00:00
e4f584de73
Merge "[IL60] Make InputLogicHandler package private"
2014-01-16 18:15:15 +00:00
87f87d9ac5
Merge "[IL59] Rename a method"
2014-01-16 18:13:39 +00:00
9c9c43c0b7
Merge "[IL58] Simplification"
2014-01-16 17:45:59 +00:00
f4bf620502
Merge "Add a dedicated method to control time in native code."
2014-01-16 17:25:29 +00:00
Keisuke Kuroyanagi
Jean Chalard
Tadashi G. Takaoka
Yohei Yukawa
Ken Wakasa