Commit graph

4394 commits

Author SHA1 Message Date
Jean Chalard
578e9b91c1 Merge "Remove useless code." 2013-10-17 06:56:12 +00:00
Jean Chalard
8447409c77 Merge "Remove mIsExpectingUpdateSelection." 2013-10-17 06:55:54 +00:00
Yuichiro Hanada
ad5b9bcec2 Add readVer4PtNodeInfo to Ver4DictDecoder.
Change-Id: Ibffaf64a9bda1fb0779a9b53558ca56ed31660d3
2013-10-17 14:37:04 +09:00
Yuichiro Hanada
36dd126ab4 Add ShortcutContentReader.
Change-Id: I7c2d0d86d85775065a9bcb2b4a8463bb4969579e
2013-10-17 11:11:29 +09:00
Jean Chalard
548716d6d9 Remove useless code.
The only use of mDeleteCount is to implement delete
acceleration. It's reset at each non-delete code point, and
is guarded by a timer.
Plus, ultimately we want to remove this completely :
acceleration should be implemented by actually deleting
stuff faster, not by deleting several code points at a time.

Change-Id: Ia3144860b3aa2499034f2a2a7c81f32087af9598
2013-10-16 18:43:15 +09:00
Jean Chalard
5731b86b88 Merge "Remove unneeded code." 2013-10-16 09:41:44 +00:00
Jean Chalard
1194b2b204 Remove mIsExpectingUpdateSelection.
Bug: 11226045
Change-Id: I043f90ba92989bd8307c978eb32630439f63a0b9
2013-10-16 18:39:20 +09:00
Jean Chalard
497976e09b Remove unneeded code.
We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
we have any plans to support it again in the future.

This also is a prelude to removing mIsExpectingUpdateSelection.

Bug: 11226045
Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
2013-10-16 18:36:16 +09:00
Yuichiro Hanada
098639d99f Add SparseContentTableReader.
Change-Id: I976afc5d320bc65835d659bae1d10d2cdc68262b
2013-10-16 17:24:59 +09:00
Yuichiro Hanada
7b5f2b71f5 Fix Ver4DictDecoder.readAndFollowForwardLink().
Change-Id: Ib527a376b693be21aebd4920ac804ee9b161eb96
2013-10-16 17:16:26 +09:00
Ken Wakasa
008d84ffa5 Merge "Fix readAndFollowForwardLink." 2013-10-16 07:48:30 +00:00
Ken Wakasa
6b7037fa68 Merge "Extract SparseTableContentWriter." 2013-10-16 07:34:03 +00:00
Yuichiro Hanada
ed831f38db Extract SparseTableContentWriter.
Change-Id: I9a58e53317654f8a09fbe79044214de3e9c59eb7
2013-10-16 09:53:30 +09:00
Yuichiro Hanada
1557de7aa4 Consolidate CharEncoding.writeString and BinaryDictIOUtils.writeString.
Change-Id: I6f990fd84e7f08fd1149198c33d8bbf1cac8e078
2013-10-16 00:30:45 +09:00
Yuichiro Hanada
522dc0d8ac Fix readAndFollowForwardLink.
Change-Id: Ifda44e6139a4a1bd065468a7f74cd9483b343644
2013-10-16 00:16:39 +09:00
Ken Wakasa
b067be0e5f Merge "Revert "Revert "Add Swiss French and German keyboard layouts.""" 2013-10-15 14:12:29 +00:00
Ken Wakasa
b044047227 mExpectingUpdateSelection was out of sync when nothing to delete.
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
Ken Wakasa
cf5dfd2464 am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint()
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
  Fix wrong commitText parameter in sendKeyCodePoint()
2013-10-14 10:52:40 -07:00
Ken Wakasa
c8383eda8b Fix wrong commitText parameter in sendKeyCodePoint()
Small optimization on generating a String instance from a single code
point too.

bug: 11181913

Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
2013-10-13 10:56:10 +09:00
Ken Wakasa
fe97ff4083 am 60fb5865: am 06e1bdaa: am 3e35e072: Merge "Make emoji separators" into klp-dev
* commit '60fb58654e33448651fea191ba22cfdc87e37466':
  Make emoji separators
2013-10-11 05:10:21 -07:00
Satoshi Kataoka
eb7fa4dc6d am 40506273: am ac6d0c65: am 6d915037: Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev
* commit '405062733cfe066c4b9af719bfc36a9a516c9dd3':
  Fix a bug where emojis would remove the suggestion strip.
2013-10-11 05:10:19 -07:00
Ken Wakasa
3e35e0727c Merge "Make emoji separators" into klp-dev 2013-10-11 11:57:07 +00:00
Satoshi Kataoka
6d91503727 Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev 2013-10-11 11:53:07 +00:00
Jean Chalard
6fc15b9fc4 Fix a bug where emojis would remove the suggestion strip.
Bug: 11163495
Change-Id: I23d12c430125cc2a66a6e00715a4c609bb9e2bb1
2013-10-11 20:51:13 +09:00
Jean Chalard
401fb908f0 Make emoji separators
Bug: 11163495
Change-Id: I3247b8d1bbd3406b29a30a25aebd932c63431943
2013-10-11 20:00:38 +09:00
Ken Wakasa
7abdab1c6f Merge "Add a time stamp for unigrams." 2013-10-11 10:17:01 +00:00
Jean Chalard
3def959e4d am 3f1c95db: am 331c84d7: am 5fe9ab1c: Merge "Fix the suggestion size." into klp-dev
* commit '3f1c95dbdc18453dc0cd6f847b33e01db1f1d75b':
  Fix the suggestion size.
2013-10-11 01:49:51 -07:00
Jean Chalard
5fe9ab1cc6 Merge "Fix the suggestion size." into klp-dev 2013-10-11 08:38:31 +00:00
Ken Wakasa
be22a01df3 Merge "Add resolveBigramPositions." 2013-10-11 07:45:20 +00:00
Jean Chalard
c0bd0a244d Fix the suggestion size.
The available space was not computed correctly. This makes the
decision to ellipsize/expand the middle suggestion correct.

Also, the scale was not applied correctly in some cases.

Finally, for some reason ellipsize does not work as we expect.
I'm not sure how to get it to work like we want it to, but
this works around the problem in a simple manner.

Bug: 11158757
Change-Id: I083e7ac56e157f100923733e67b92a6368a526c9
2013-10-11 16:42:46 +09:00
Satoshi Kataoka
7d3f53a1cb Do not merge. Save / restore the last used emoji category
Bug: 11029983
Change-Id: I5547910c7b5dd7974292fc075af33568940f4e81
2013-10-11 16:05:38 +09:00
Satoshi Kataoka
6026a95816 Merge "Save / restore the last used emoji category" 2013-10-11 07:04:42 +00:00
Satoshi Kataoka
6dc99dc200 Save / restore the last used emoji category
Bug: 11029983
Change-Id: I1bec2c3c6b547de68562a818a8d6c9fef83787b7
2013-10-11 16:00:33 +09:00
Yuichiro Hanada
c32962b8f1 Add a time stamp for unigrams.
Bug: 10920255
Change-Id: I26d2cce3c322a4ff39a614f8615f43fb7bd3baed
2013-10-11 15:08:09 +09:00
Yuichiro Hanada
9514ed5c2a Add the new format of bigram entries.
In new format, each bigram entry has flags (1 byte), a terminal id (3 byte),
a time-stamp (4 byte), a counter (1 byte) and a level (1 byte).

Bug: 10920255
Bug: 10920165
Change-Id: I0f7fc125a6178e6d25a07e8462afc41a7f57e3e1
2013-10-11 14:50:41 +09:00
Jean Chalard
7e6ac9d727 Allow double-space-to-period after percent
Bug: 11158604
Change-Id: If8c94ef91ed58bb5028f51be7c8d9beb677436a4
2013-10-10 21:26:08 +09:00
Ken Wakasa
856b06a3ac Revert "Revert "Add Swiss French and German keyboard layouts.""
This reverts commit 56402cf10a.

I'll submit this on 10/16 after the final cut for Bayo.

Change-Id: I0fe4ab64fd8dfa1e63e29adf00388743fca6a1ed
bug: 11144401
2013-10-10 02:07:04 +00:00
Ken Wakasa
56402cf10a Revert "Add Swiss French and German keyboard layouts."
This reverts commit 220ce8f269.

Sorry, but we are now in the week before the final cut for the next launch. We shouldn't be taking new features like this at this point. Let me revert this change for now. I'll re-revert this after the cut next week.

Change-Id: Ia8b00680c992ec526e6a858945f2380cbcdfdd55
2013-10-10 02:05:50 +00:00
Fredrik Roubert
220ce8f269 Add Swiss French and German keyboard layouts.
There used to be two "Swiss" keyboard layouts, labelled fr_CH and de_QY,
available in LatinIME. They were, however, not actually Swiss layouts
but instead work-arounds to be able to get French or German with qwertz
or qwerty (instead of azerty and qwertz) layouts, respectively. These
were thus removed by commit f6972561fc
replacing them with the generic fr-qwertz and de-qwerty layouts instead.

Here, now, is a proper Swiss keyboard layout, following Swiss standards
for people accustomed to typing on Swiss keyboards, with the expected
tailorings for French and German.

Change-Id: I9feed752053ecc694c84db713284f69bc1daf155
2013-10-09 17:42:17 +02:00
Satoshi Kataoka
a6a6abc816 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 02:59:32 -07:00
Satoshi Kataoka
6862b8192d Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 02:59:26 -07:00
Yuichiro Hanada
67c758f160 Add resolveBigramPositions.
Bug: 11073222
Change-Id: I680e4304c6ab701e9aa132e1e140d789097a53ae
2013-10-09 17:39:22 +09:00
Satoshi Kataoka
83994ad66b Merge "Fix the security related API change for PreferenceActivity" 2013-10-09 05:46:15 +00:00
Satoshi Kataoka
64f64bdf58 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 14:34:06 +09:00
Jean Chalard
dfaec34502 Merge "Always call finishComposingText before recapitalization" 2013-10-09 05:18:01 +00:00
Jean Chalard
e306d292eb Merge "Remove a useless IPC call." 2013-10-09 05:17:51 +00:00
Satoshi Kataoka
50f9ca4acd Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 12:50:50 +09:00
Jean Chalard
f178685c11 Always call finishComposingText before recapitalization
Workaround for framework bug:
Bug: 10792236

Change-Id: I3706b9eed5223889791840e30660f8d17625cb70
2013-10-09 12:15:21 +09:00
Jean Chalard
27d78643e8 Remove a useless IPC call.
This is not useful because we're going to call setSelection again
with different values on the connection right away.

Also a preliminary change for
Bug: 10792236

Change-Id: I46c6ef1fbb3624086099bf81afddb0ef5ae85661
2013-10-09 12:11:28 +09:00
Satoshi Kataoka
a701501cb6 Merge "Reduce memory of emoji palette" 2013-10-08 11:22:21 +00:00
Satoshi Kataoka
0e01df9baf Reduce memory of emoji palette
Bug: 10902556
Change-Id: I3c8da35a601de2bfb248292c7b59235fc1120988
2013-10-08 20:11:35 +09:00
Jean Chalard
482aa129e4 Show the keyboard earlier when rotating.
Bug: 11107229
Change-Id: I0b36341d60b634a860eb13fafd0dc69fe734bdeb
2013-10-08 16:33:27 +09:00
Jean Chalard
10581e68af Make the sentence separator a resource.
This will help handing correctly the armenian full stop.

Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
Jean Chalard
7712baa59b Merge "Fix a possible IOOB" 2013-10-07 14:21:00 +00:00
Jean Chalard
ca9c3c0613 Fix a possible IOOB
We want to use StringUtils here, but it's full of references to
stuff not accessible host-side like JsonReader and TextUtils
and SettingsValues :/

Bug: 11061476
Change-Id: I3c0194979833ede283b4f9190335dba5376fe6fc
2013-10-07 23:16:57 +09:00
Jean Chalard
3c4e8cb693 Call loadKeyboard later if it can't be called right away
Since loadKeyboard relies on the input connection being
available to give it the auto-caps state, but also can't
be called twice in a row because it needs to save and
restore its state and invalidates it after the restore,
we need to wait until we know we have a valid input
connection to call it.

Bug: 11107229
Change-Id: I1c7baf3215682df6f6ceb357bd37254f9e7418c7
2013-10-07 22:57:59 +09:00
Satoshi Kataoka
291ef1c9c3 Merge "Clear the cache of subtypes in onStartInputViewInternal" 2013-10-07 11:19:47 +00:00
Satoshi Kataoka
4be5f221e6 Clear the cache of subtypes in onStartInputViewInternal
Bug: 11077905
Change-Id: I9495f13a20edca0e6153cd1a7a0ac6891f707c59
2013-10-07 20:10:58 +09:00
Jean Chalard
86f7711407 Merge "Don't auto-correct to non-whitelist shortcuts" 2013-10-07 10:04:18 +00:00
Jean Chalard
f309f2288b Don't auto-correct to non-whitelist shortcuts
Bug: 11076722
Change-Id: I0de10ab24d33ec31f45664fe92d80d5a7bec9c20
2013-10-07 19:01:57 +09:00
Jean Chalard
a6047aae94 Merge "Set the shortcut frequency correctly." 2013-10-07 10:00:34 +00:00
Jean Chalard
f3204eebb1 Set the shortcut frequency correctly.
14 is the right value.

Bug: 11076722
Change-Id: I95d404b540f7fbe4932d1f8498cde23f1df0314f
2013-10-07 18:55:42 +09:00
Keisuke Kuroyanagi
be4d85feb0 Merge "Fix bug and Add large test for decaying dictionary." 2013-10-07 09:32:56 +00:00
Keisuke Kuroyanagi
cfb018ba6d Fix bug and Add large test for decaying dictionary.
- GC gets failure when the dictionary become empty.
- Useless unigrams are sometimes not removed.

Bug: 10197478
Change-Id: I8d1479c01efba61a81f03bc077da6bcb4797a940
2013-10-07 17:31:01 +09:00
Jean Chalard
df33982fce Remove suggestions when string contains a period
This is not the right way to do it, but it's simple and will kill the
regression. We should investigate why the return values are
wrong in this case.

Bug: 10780091
Change-Id: I808727242c9cb1598df00a7426358dc3a658add4
2013-10-07 17:27:27 +09:00
Jean Chalard
423921ca13 Merge "Fallback on empty locales." 2013-10-04 13:44:44 +00:00
Jean Chalard
5db7eabafb Merge "Accept double-space-period after emoji." 2013-10-04 13:05:43 +00:00
Jean Chalard
43a8a0c527 Fallback on empty locales.
This is a very rare corner case.

Bug: 11072132
Change-Id: Iad2aa69511f7dc99105284a049c63f2f997b8ef0
2013-10-04 22:04:59 +09:00
Jean Chalard
8142fd83a6 Accept double-space-period after emoji.
This also includes a fix that allows this code to read surrogate
pairs in this processing.

Bug: 11070482
Change-Id: If5ef8d6863938252f09128b7e99ea07ece6e7019
2013-10-04 22:01:36 +09:00
Ken Wakasa
c01707db03 Merge "Suppress exceptions that have always been happening." 2013-10-04 10:13:53 +00:00
Ken Wakasa
fba1bd0ec4 Suppress exceptions that have always been happening.
Change-Id: I5f85a7a0f94ea9ecbe0c4a8caebcf551fa9c9669
2013-10-04 19:10:26 +09:00
Yuichiro Hanada
e4e0add9fb Add Ver4DictUpdater.
Change-Id: I986ab26faf535fc4bc98443053f534eced9d048f
2013-10-04 17:33:29 +09:00
Yuichiro Hanada
75d60e821c Refactor BinaryDictIOUtilsTests.
Change-Id: I2208378b33038771b460abb33f9a690872e998e2
2013-10-04 14:19:13 +09:00
Yuichiro Hanada
14d31d4640 Add AbstractDictDecoder.
Change-Id: Ie69d84e090f69dc3ea1f5de73ad8c954ecd2c6a7
2013-10-04 14:16:59 +09:00
Yuichiro Hanada
73b9d3b879 Separate shortcut targets from the trie file.
Bug: 10920165
Change-Id: I340759eadbde7fb64cb3b9a3c619ee3a768cedf8
2013-10-04 11:16:10 +09:00
Keisuke Kuroyanagi
864ee881bd Merge "Fix UserHistoryDictionaryTests." 2013-10-03 12:02:34 +00:00
Keisuke Kuroyanagi
11f7cae094 Fix UserHistoryDictionaryTests.
Bug: 6669677
Bug: 10667710

Change-Id: I6cdc6a6c9cacc7f276fda3a26ec31e3eb928471c
2013-10-03 20:55:34 +09:00
Yuichiro Hanada
3dd77a6d66 Add SparseTableContentWriter to Ver4DictEncoder.
Bug: 10920165
Change-Id: I6372492e97297baad4c5aeeb3fb36dcccd7a944b
2013-10-03 20:31:01 +09:00
Yuichiro Hanada
d6e307a4b7 Add DictUpdater.
Change-Id: Ic586e46e5a9f59de53d53e59886d635345940974
2013-10-03 20:16:34 +09:00
Satoshi Kataoka
9ecdb831db Fix the subtype id of the additional subtypes
Bug: 11032428
Change-Id: I5d422f1c15a582015770ef9a652348ca6eb8ab85
2013-10-03 16:41:13 +09:00
Keisuke Kuroyanagi
d25cd26f1a Merge "Try decaying user history at hourly intervals." 2013-10-02 09:44:03 +00:00
Yuichiro Hanada
3aa8977cb2 Remove some unused variables.
Change-Id: Iaf1556fec194d17cb4318f2bdcc837f8d79449ef
2013-10-02 18:26:03 +09:00
Keisuke Kuroyanagi
f36a97ab3a Try decaying user history at hourly intervals.
Bug: 6669677

Change-Id: Ib465fa7e1a7f289a07843535ba89d0dd5259e803
2013-10-02 18:06:08 +09:00
Ken Wakasa
2dcb63375d Merge "Make SparseTable have multiple content tables." 2013-10-02 08:32:55 +00:00
Jean Chalard
cd7422f4df Merge "Fix a pernicious bug with caps." 2013-10-02 07:59:08 +00:00
Jean Chalard
f735117d36 Fix a pernicious bug with caps.
What's happening here is, setAlphabetKeyboard sets the
keyboard to AUTOMATIC_SHIFTED and updates the keyboard, then
restoring the keyboard old state sets it back to UNSHIFTED without
updating it. When we finally know what the correct value is,
we try to set it to UNSHIFTED, but since that's already the currently
recorded state, it skips updating the keyboard forever.

The solution is to avoid setting the shift state without updating the
keyboard.

Bug: 10948582
Change-Id: Ic8670401e378f8284e851281f91a9ad93eac8e90
2013-10-02 16:57:36 +09:00
Satoshi Kataoka
c5182c9a4a Correspond to the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: Ia7d1c6c526dae849f447c26387e96a4fb4d6042f
2013-10-02 16:25:07 +09:00
Yuichiro Hanada
4284e9aae7 Make SparseTable have multiple content tables.
Bug: 10920165
Change-Id: Ie9008452ee292fb0b1fec66e2ffed228c4af6c3e
2013-10-02 15:36:13 +09:00
Jean Chalard
fa946d4a0f Fix a test and crash with a better error message when reading
When there are too many bigrams, we stop reading the file,
so the file pointer is in an inconsistent place. This means we
have no idea what's going to happen next. It's better to crash
right away.

Change-Id: Id3b7b78cbe4fda3493b3c9c46758763e1ab5f6a3
2013-10-02 11:48:47 +09:00
Jean Chalard
459cd6f8ef Implement the heuristic for auto-commit.
Bug: 9059617
Change-Id: I066abf018df5aaeabf415425dd822ebe233e6008
2013-10-01 21:00:40 +09:00
Ken Wakasa
cc81a93b01 Merge "Add skipPtNode to DictDecoders." 2013-10-01 09:06:39 +00:00
Yuichiro Hanada
bc4926235d Add skipPtNode to DictDecoders.
Change-Id: I042ff041b68572182c87dc87db6a6aa2bbbefc6c
2013-10-01 17:21:21 +09:00
Keisuke Kuroyanagi
126d758c1e Merge "Quit blocking getSuggestion during GC." 2013-10-01 07:08:11 +00:00
Jean Chalard
bb57090f1d Create the wiring for auto-commit confidence computation.
Bug: 9059617
Change-Id: I7e4e05ffa8c68cfebbe362a977fd176555cad12a
2013-10-01 15:04:15 +09:00
Keisuke Kuroyanagi
03cb8f751a Quit blocking getSuggestion during GC.
Bug: 10831272

Change-Id: I995c619dc18a9120a47f547d31045cb73a9353ec
2013-10-01 12:04:06 +09:00
Alan Viverette
458fb52b98 Merge "Speak auto-corrections for accessibility" 2013-09-30 18:14:13 +00:00
Keisuke Kuroyanagi
65330d2820 Merge "Implement simple dictionary decay." 2013-09-30 11:56:15 +00:00
Keisuke Kuroyanagi
fd02b2d6ee Implement simple dictionary decay.
Groundwork and implement simple decay.
Increment probability when typed and decrement probability
at GC.

Bug: 6669677

Change-Id: Ib12caead0cbeef4ce7808fe8ac0b00ee331523fe
2013-09-30 20:53:35 +09:00
Keisuke Kuroyanagi
ef084229f6 Merge "Use reentrant lock for main dictionaries." 2013-09-30 09:25:54 +00:00
Keisuke Kuroyanagi
3e6275634b Use reentrant lock for main dictionaries.
Bug: 10964805
Change-Id: Iaa9b79fc770d8ae2ec9d7c362c90c28bc9f65ea8
2013-09-30 18:16:29 +09:00
Ken Wakasa
25f4782853 Merge "Separate bigram entries from the trie file." 2013-09-30 08:00:01 +00:00
Yuichiro Hanada
fd46e87da2 Separate bigram entries from the trie file.
Bug: 10920165
Change-Id: I42eb7f228994a56c2f31a1c83904c8c360b6d088
2013-09-30 16:42:42 +09:00
Ken Wakasa
d40a931a4d Merge "Change scopes of some methods in DynamicBinaryDictIOUtils." 2013-09-30 07:17:38 +00:00
Keisuke Kuroyanagi
c18510049a Prepare dictionary decay.
Bug: 6669677
Change-Id: I8fbae190dd44a6bdbee7e9b6d3a16208322727f7
2013-09-30 13:57:54 +09:00
Yuichiro Hanada
dc4f357f6b Change scopes of some methods in DynamicBinaryDictIOUtils.
Change-Id: I1371d41760b38834d1d5ff40e682ac0a6fc9f2e9
2013-09-30 11:32:07 +09:00
Keisuke Kuroyanagi
1cf4789ba6 Merge "Set header attributes for ExpandableBinaryDictionary." 2013-09-29 05:14:22 +00:00
Keisuke Kuroyanagi
5ed30a7660 Set header attributes for ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2462777eaa07600f1c774226adfc4f351882f523
2013-09-28 12:50:09 +09:00
Alan Viverette
67319f92f3 Speak auto-corrections for accessibility
BUG: 8669376
Change-Id: Id71b2c2835daa7a8c9d6c92c57a7e302551c289d
2013-09-27 14:15:53 -07:00
Keisuke Kuroyanagi
8b580819a5 Merge "Add unigram/bigram counting." 2013-09-27 14:14:49 +00:00
Keisuke Kuroyanagi
31097a57cc Add unigram/bigram counting.
Bug: 6669677
Change-Id: I05ea2201d822dddf062b08c8467daa336760e16c
2013-09-27 23:12:12 +09:00
Keisuke Kuroyanagi
e74d4a184b Stop reading dictionary while regenerating.
Bug: 10831272

Change-Id: Iead7268a9371b48d729a5f65074ccbc05f3185db
2013-09-27 21:44:26 +09:00
Jean Chalard
b7dfacd31e Merge "Send backspace as an event when TYPE_NULL." 2013-09-27 08:00:43 +00:00
Jean Chalard
de814ec0ec Send backspace as an event when TYPE_NULL.
This is not enough to really fix behavior with TYPE_NULL,
but it does make things a bit better.

Bug: 10949594
Change-Id: Ia359f781cdd76a2e2c5a4c9f166025d81b931174
2013-09-27 16:55:12 +09:00
Yuichiro Hanada
a328f538c3 Fix PrioritizedSerialExecutor.
It was possible that fetchNextTasks() would be called by multiple
threads concurrently.
If it happens, some tasks in the task queues might be ignored.

Change-Id: Idc81c43c45e382da3850cc55b9a42c281548d2a8
2013-09-27 16:46:34 +09:00
Yuichiro Hanada
781feb748c Remove unused methods.
Change-Id: I542db0c717c0bc05c8baa08f1e9db0a05946a99b
2013-09-27 12:34:38 +09:00
Keisuke Kuroyanagi
e3e10317b0 Merge "Create empty dictionary file in native code." 2013-09-26 08:03:38 +00:00
Yuichiro Hanada
d188af7022 Add SparseTable.
Bug: 10920165
Change-Id: I749dd0269e788799e30b10beb2671813d40ce15f
2013-09-26 16:16:30 +09:00
Keisuke Kuroyanagi
5ef6209656 Create empty dictionary file in native code.
Bug: 6669677
Change-Id: I46d23deee1fd091678f4593561cb8687eb815212
2013-09-26 12:59:02 +09:00
Ken Wakasa
4350a93aa5 Merge "Fix the offdevice regression test build" 2013-09-25 10:30:18 +00:00
Ken Wakasa
f56b82f809 Fix the offdevice regression test build
Followup to If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57

bug: 10622489
Change-Id: If98b2c75725f8692f0c2b41c33e448086404479b
2013-09-25 19:13:47 +09:00
Keisuke Kuroyanagi
5fa9654045 Merge "Clear traverse sessions when closing." 2013-09-25 10:06:33 +00:00
Keisuke Kuroyanagi
6142068a33 Clear traverse sessions when closing.
Bug: 6669677
Change-Id: I859be934f0c60485e04cdc4cab288a18242fa04e
2013-09-25 18:32:40 +09:00
Yuichiro Hanada
22c5c450fe Make Ver4DictEncoder write an address table of terminal nodes.
Bug: 10920165
Change-Id: I86017456ea9fa5d6e12b57172c34f5ed4f88ef94
2013-09-25 17:03:54 +09:00
Keisuke Kuroyanagi
2e58670da9 Quit using ExpandableDictionary.
Bug: 6669677
Change-Id: Ie90417fa9b726454fe729a665fcd549efabb9e94
2013-09-24 22:57:15 +09:00
Satoshi Kataoka
f068c6e656 Merge "Low memory mode in UserHistory" 2013-09-24 11:37:39 +00:00
Satoshi Kataoka
97485273d7 Low memory mode in UserHistory
Bug: 8967766
Change-Id: Id40f54f4d9f43d1f796377983a5fc0ca3417e133
2013-09-24 20:36:31 +09:00
Jean Chalard
f600923376 Merge "Tweak for armenian periods and commas." 2013-09-24 11:20:04 +00:00
Jean Chalard
933cc808d9 Tweak for armenian periods and commas.
Bug: 7963631
Change-Id: I2eb110949f3d3b7817dbd9448654954fdee39ac2
2013-09-24 19:48:17 +09:00
Jean Chalard
3d68b06662 Copy only the spans we are interested in.
The PARAGRAPH type of span is dangerous, as concatenating
CharSequences that contain it may crash. We also don't use
other spans than SuggestionSpans, so we don't copy them.

Bug: 10622489
Change-Id: If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57
2013-09-24 19:04:51 +09:00
Jean Chalard
8f23c6f78b Merge "Detect cases where rotation messes with initialization" 2013-09-24 05:38:44 +00:00
Jean Chalard
f1d8aa46f9 Detect cases where rotation messes with initialization
...and do a best effort to fix it.

Bug: 10323080
Bug: 10252066
Change-Id: Icb3c9fe85005406bdfce0b7bb143ba0a910a0ddb
2013-09-20 22:21:28 +09:00
Jean Chalard
262b867200 Merge "Catch SQLiteException from remote processes" 2013-09-20 10:59:13 +00:00
Jean Chalard
d0cf6b7623 Catch SQLiteException from remote processes
...to avoid catching fire when the Contacts or User dictionary
providers crash and burn.

Bug: 10200036
Change-Id: I73e9d126ce6d34ebc7e6ac03d94af1c12dde7eda
2013-09-20 19:55:31 +09:00
Jean Chalard
be3be424a3 Fix a bug that happens upon a race condition
Bug: 10848621
Change-Id: If5ff7f001e69af005a5ff9ab3e9f630b88a0a858
2013-09-20 18:21:10 +09:00
Ken Wakasa
280990bcb1 Merge "Address a couple more issues in Khmer layout" 2013-09-20 07:32:48 +00:00
Ken Wakasa
814acafaea Address a couple more issues in Khmer layout
bug: 6910993
Change-Id: If866629268040cf7696d9667dbca66fac6a60374
2013-09-20 16:27:30 +09:00
Jean Chalard
1d1a3d52b8 Merge "Fix a bug where null would be converted to "null"" 2013-09-20 07:19:59 +00:00
Jean Chalard
8f02f1a118 Fix a bug where null would be converted to "null"
It's unclear what the concrete effects of this are, but they are not
very strong. This only happens in corner cases, when the input
connection is not active - while rotating, for example.

Change-Id: I1d22459a6e94a8ecccb53cfcbc2d301b1d502204
2013-09-20 15:45:51 +09:00
Satoshi Kataoka
baa3121704 Update resources
Change-Id: Ia66f7181514ee1471e181e16d15622174cf72e79
2013-09-20 14:49:54 +09:00
Yuichiro Hanada
a469743e33 Add showSuggestionStripWithTypedWord.
Bug: 10814472
Change-Id: I3a150124baf7a9b7889b033089a859ff9c11e206
2013-09-19 20:52:28 +09:00
Yuichiro Hanada
14087ba52c Add Ver4DictDecoder.
Bug: 9618601
Change-Id: I43c5840505c6a847aaf4893a400392ccd45903c0
2013-09-19 16:11:23 +09:00
Keisuke Kuroyanagi
40f66795a2 Quit skipping user history dictionary for gesture.
Bug: 6669677
Change-Id: Id4344f2a30e9827f210055d6c65ee7776d3a63e3
2013-09-19 13:12:11 +09:00
Jean Chalard
8678062853 Merge "Fix an NPE." 2013-09-18 12:42:16 +00:00
Jean Chalard
08bc97f86f Merge "Allow double-space-to-period after a plus char" 2013-09-18 12:40:29 +00:00
Jean Chalard
673275cbc6 Fix an NPE.
Apparently, it is possible that File#getPath() returns null.
In this case, we'll have a null AssetFileAddress and an NPE
later down the road.

Bug: 9944824
Change-Id: Id6ceac1cb55439660f9811cf0fe3b574200d5a20
2013-09-18 21:39:30 +09:00
Jean Chalard
ba99d8cd0b Allow double-space-to-period after a plus char
Bug: 10704936
Change-Id: I30fdaea648605ef7e7fea6c093581ed5c6de03f3
2013-09-18 21:04:25 +09:00
Satoshi Kataoka
957a2337ee Merge "Set EmojiCapable" 2013-09-18 08:48:35 +00:00
Satoshi Kataoka
8837deab73 Merge "Fix Emoji recents" 2013-09-18 08:46:25 +00:00
Satoshi Kataoka
ea7bfa5cd5 Fix Emoji recents
Bug: 10538430

Change-Id: Ia2e423eb1843195b3c3218afc79a5820b8cd729b
2013-09-18 17:44:16 +09:00
Ken Wakasa
256937b475 Merge "Fix getChildrenPosition." 2013-09-18 08:36:48 +00:00
Satoshi Kataoka
51f275d8be Set EmojiCapable
Bug: 10240645
Change-Id: I891309c2a82f8d10f8fdb0872403a7a235e27b5f
2013-09-18 17:29:23 +09:00
Jean Chalard
59418672a1 Merge "Don't resume suggestion on digits." 2013-09-18 07:05:01 +00:00
Keisuke Kuroyanagi
4ad4b9d976 Merge "Fix contacts/user dictionary writing." 2013-09-18 07:00:58 +00:00
Yuichiro Hanada
d0c87576ff Fix getChildrenPosition.
Change-Id: Ic39592dbf0d4e6d2e4879cdb1a95b65d46a57e92
2013-09-18 15:50:10 +09:00
Keisuke Kuroyanagi
0011ab4bf3 Fix contacts/user dictionary writing.
Bug: 10743878
Change-Id: I5d61b7955ef69a635f994f01cc575fb23fdf942b
2013-09-18 15:31:06 +09:00
Keisuke Kuroyanagi
9465819cf6 Merge "Add BinaryDictionary.getBigramProbabilityNative()." 2013-09-18 04:10:38 +00:00
Jean Chalard
f71e1db2da Don't resume suggestion on digits.
Bug: 10780016
Change-Id: I94fad06e4c71eddc96bdda1765925f98bed160f3
2013-09-18 11:37:19 +09:00
Keisuke Kuroyanagi
4d02a2d44d Add BinaryDictionary.getBigramProbabilityNative().
Bug: 10197478
Change-Id: Id16e3ee22a17679c46cc7a0199a9e28065177aa3
2013-09-18 11:18:28 +09:00
Jean Chalard
e8f717943f Improve trailing quotes processing
Bug: 10445496
Change-Id: Ib7bd05aea59ae6c9b8ce31299ef2235521b0e350
2013-09-17 22:17:22 +09:00
Jean Chalard
060917ed9a [AC9] Resize an array
It's not easy for native code to only output the first
result, so let's supply enough room for it to output all.

Bug: 9059617
Change-Id: Ie93b7e54284c8c5d01fdc15846cf52d3442287b6
2013-09-17 19:05:30 +09:00
Jean Chalard
5cab0eb75b Merge "[AC8] Restrict the suggestion strip to the correct part" 2013-09-17 09:48:02 +00:00
Jean Chalard
b1e98c2f4f [AC8] Restrict the suggestion strip to the correct part
...for phrase gesture.

Bug: 9059617
Change-Id: Ic5c0616f28af4ba45ca72a5721d1926029adc1c5
2013-09-17 18:43:12 +09:00
Keisuke Kuroyanagi
d0246277fd Prepare dictionary saving in native code.
Bug: 6669677

Change-Id: I0787f66409e2b183c6328fa05805945520e1e93a
2013-09-17 18:07:16 +09:00
Keisuke Kuroyanagi
e8754aba1c [AC7] Actually auto-commit.
Bug: 9059617
Change-Id: I7e5d89a9037b9181a0a6456c12043b4bfda8fe4b
2013-09-17 16:44:50 +09:00
Jean Chalard
73d607fb70 Merge "[AC5] Introduce the setting for phrase gesture." 2013-09-17 03:42:38 +00:00
Satoshi Kataoka
f3f00006cb Save & restore emoji keyboard state
Bug: 10538430
Change-Id: I7982f53f5dfa44071e74da63826acffcdc2547e6
2013-09-16 19:39:20 +09:00
Jean Chalard
a37bee2805 [AC5] Introduce the setting for phrase gesture.
Bug: 9059617
Change-Id: I6fa0f675f4edac10bd19228cd2f0c8fca97cebd6
2013-09-13 20:44:37 +09:00
Jean Chalard
41aaff6cdf Merge "[AC4] Add native methods necessary for auto-commit" 2013-09-13 11:41:55 +00:00
Jean Chalard
24aad5a4d5 [AC4] Add native methods necessary for auto-commit
Bug: 9059617
Change-Id: I7a47b0675446fc4f39628c60d16de9aea90d1b4d
2013-09-13 20:15:15 +09:00
Ken Wakasa
fbc7e61a3e Merge "Add Ver4DictEncoder." 2013-09-13 08:51:58 +00:00
Yuichiro Hanada
a099a3e341 Add shutdown and isTerminated to PrioritizedSerialExecutor.
Change-Id: Id185224d135c8571a39efe8a41a66ce769142903
2013-09-13 17:46:50 +09:00
Yuichiro Hanada
a141d8ef7d Add Ver4DictEncoder.
Bug: 9618601
Change-Id: I161d2845906f07c1251deb8005fdffe49c5b7940
2013-09-13 17:33:51 +09:00
Satoshi Kataoka
898dbe3c29 Fix emoji keyboard insets
Bug: 10541453
Change-Id: I16dd72c8c55cb5d21ad61a3307c0f3c5f16f460c
2013-09-13 14:21:40 +09:00
Jean Chalard
40666017c9 Merge "Avoid recorrection in ex-password fields." 2013-09-12 12:29:33 +00:00
Jean Chalard
ce96d0d12f Avoid recorrection in ex-password fields.
Bug: 10115839
Change-Id: I1f1025c9f28adfb6f5a63d5ba86e359f30c0963e
2013-09-12 21:20:07 +09:00
Ken Wakasa
a6dc3056ff Merge "Add getDictDecoder." 2013-09-12 11:17:03 +00:00
Yuichiro Hanada
0e40cd0c40 Add getDictDecoder.
Bug: 9618601
Change-Id: I173100ac704c03f7d5d0d53477e83cab5d1110d4
2013-09-12 20:14:09 +09:00
Keisuke Kuroyanagi
4c2767857a Change cache capacity depending on the dictionary size.
Bug: 10699291

Change-Id: I7042d4c1307da2d991d4dd10d637f18026acb996
2013-09-12 18:47:56 +09:00
Yuichiro Hanada
be470f06e4 Hide DictBuffer from BinaryDictDecoderUtils.
Bug: 9618601
Change-Id: I87515bc1555bdfe09426a056ceda74d8e63eba82
2013-09-12 16:49:54 +09:00
Jean Chalard
87472f0038 Remove changing a word when added to the dictionary
This code is now useless.
I thought it affected 9902905, but it seems it actually does not.
Still, it's dead code.

Bug: 9902905
Change-Id: Id9c90fbf88f015af47b2368b90d173c481647093
2013-09-12 15:10:10 +09:00
Keisuke Kuroyanagi
76e431b315 Merge "Use same session id for typing and gesture." 2013-09-12 03:16:43 +00:00
Keisuke Kuroyanagi
f1233b58c2 Use same session id for typing and gesture.
Bug: 10699291
Change-Id: I7c8a3a57e8d189b72a17e4b9c6831becee6ec146
2013-09-12 12:08:22 +09:00
Yuichiro Hanada
7547a7042c Add writePtNode to DictEncoder.
Bug: 9618601
Change-Id: Ie4529444780edee8d0f0d5f23c5619c1a3344286
2013-09-11 18:27:06 +09:00
Yuichiro Hanada
95bc256f41 Add a flag to readDictioanryBinary in DictDecoder.
Change-Id: I356adb72047ebc43c924fbff1ff45e7460508a31
2013-09-11 18:20:56 +09:00
Yuichiro Hanada
e193c5255d Revert Ida230ca42 and I6adf7d08f.
Change-Id: I2ddb250d5a473ea955a5171656974de7288a13f7
2013-09-10 19:08:43 +09:00
Yuichiro Hanada
ef073f4024 Use PrioritizedSerialExecutor instead of ReentrantReadWriteLock.
Change-Id: I003b769e408ebd692085a7e17fed6d9396876202
2013-09-10 19:05:41 +09:00
Ken Wakasa
40e91e4582 Merge "Check the version of format options before writing." 2013-09-10 10:01:12 +00:00
Yuichiro Hanada
8a06b26cb4 Check the version of format options before writing.
Change-Id: I3951e4395a2da225e240e856c23339b679e6155e
2013-09-10 18:59:31 +09:00
Keisuke Kuroyanagi
e531c2241e Move a flag about switching dynamic update to java.
Bug: 6669677

Change-Id: I6aa99cae4a227f9202179c2873d13473a773e024
2013-09-10 18:45:53 +09:00
Yuichiro Hanada
acdabb25f4 Add AsyncResultHolder.
Change-Id: Icfa685bcda2f5c74f5649f09098d00b4bd321c5a
2013-09-10 15:48:06 +09:00
Satoshi Kataoka
be96361156 Merge "Check contents in user history dictionary tests" 2013-09-09 06:46:45 +00:00
Satoshi Kataoka
e5a35711b8 Check contents in user history dictionary tests
Bug: 10667710

Change-Id: I45ebb08cb4ef9a9f6d2da31e2c50e740f88209c2
2013-09-09 15:28:50 +09:00
Yuichiro Hanada
70e81af726 Hide physical structure of the dictionary from BinaryDictEncoderUtils.
Bug: 9618601
Change-Id: I01b8da42058d7c05bf7f4e6d43718032c2ad12c5
2013-09-09 14:55:33 +09:00
Yuichiro Hanada
cc2751ba03 Make commitCurrentAutoCorrection asynchronous.
Change-Id: Ida230ca4243347fb3ab9fda7de3a9a18f886cd1c
2013-09-09 14:47:26 +09:00
Keisuke Kuroyanagi
37e0fd2ff0 Revise TODO comment for I823912e3979829a.
Change-Id: I839d8cb4d45d7d17b7940d710a2fef5aeacc11ab
2013-09-09 12:26:40 +09:00
Keisuke Kuroyanagi
773f227242 Fix: wrong locking order.
Change-Id: I823912e3979829ad1e825cf91dc5e18f7f0f9cc3
2013-09-09 12:13:21 +09:00
Keisuke Kuroyanagi
e7ac900340 Merge "Write forgetting curve flag." 2013-09-09 01:46:59 +00:00
Yuichiro Hanada
563bcb5117 Rename write(|Signed)VariableAddress and to write(|Signed)ChildrenPosition.
Change-Id: Ib018bde346744b470a4fb13b0c57e3a633b8bb20
2013-09-06 23:53:58 +09:00
Yuichiro Hanada
6156892b7e Add computeChildrenPosition and simplify writePlacedNode.
Change-Id: Idcf0e056bf61e29844d4d0e91c482cd78c41704c
2013-09-06 23:52:10 +09:00
Keisuke Kuroyanagi
859b9eeaf0 Write forgetting curve flag.
Bug: 6669677
Change-Id: Ic19aa3b69fb45d9638f9dcc8c3dd8a34aad41965
2013-09-06 21:03:09 +09:00
Satoshi Kataoka
b690c03927 Merge "Optimize layout" 2013-09-05 13:31:53 +00:00
Satoshi Kataoka
d6217a323c Optimize layout
Bug: 9059539

Change-Id: Iabfd44daae1ef6da99a864859488a4f644240925
2013-09-05 22:27:26 +09:00
Yuichiro Hanada
b1af47c8fe Add a callback to the arguments of commitCurrentAutoCorrection.
Change-Id: I6adf7d08fdc4382233a63304743207368db8058a
2013-09-05 20:00:40 +09:00
Satoshi Kataoka
80fe84b3a4 Merge "Consolidate voice input key options no.1" 2013-09-05 07:33:59 +00:00
Satoshi Kataoka
21a89c1137 Consolidate voice input key options no.1
Change-Id: I2f928522a0795f57b4133072f270d8fd2498cae9
2013-09-05 16:25:41 +09:00
Yuichiro Hanada
55f5f7a005 [Refactor] Add writeDictionaryHeader.
Change-Id: I69026c47ce1d23f5c39c99ace76fa6b96cd1ce1b
2013-09-05 16:19:26 +09:00
Yuichiro Hanada
663f5375d1 Add comments about how to calculate parent and children addresses.
Change-Id: Idf37d9a08a7b464a14c8755bedb755005e49ba33
2013-09-05 15:10:28 +09:00
Yuichiro Hanada
648088aa9e Change GET_SUGGESTED_WORDS_TIMEOUT to 200.
Change-Id: Ia5aa0b7af16d7ad45c98d0c5a7dcabba76d19b67
2013-09-03 18:52:53 +09:00
Yuichiro Hanada
d6c947ef7b Change GET_SUGGESTED_WORDS_TIMEOUT to 50.
Change-Id: I4d495a782ed1dea1c377837c6579ce5ff74086b5
2013-09-03 17:39:47 +09:00
Yuichiro Hanada
908fc4f1c3 Call getSuggestedWords asynchronously.
Change-Id: Ia8a21b53f4d12b759d9ef5a5181ed04875e4d198
2013-09-03 15:12:49 +09:00
Yuichiro Hanada
8616e4c03d Remove typedWord from the arguments of showSuggestionStrip.
Change-Id: Iddf33227982e65705b49c6a527286d8695878c90
2013-09-02 22:31:43 +09:00
Yuichiro Hanada
9666a22815 Revert "Revert "Add onGetSuggestedWordsCallback.""
This reverts commit 78f707a142.
Change-Id: I5dd4f2d40314002736226886477563f29a25079c
2013-09-02 14:09:53 +09:00
Ken Wakasa
acc886eeb4 Merge "Revert "Add onGetSuggestedWordsCallback."" 2013-08-30 14:07:18 +00:00
Ken Wakasa
78f707a142 Revert "Add onGetSuggestedWordsCallback."
This reverts commit 820c290a61.

Change-Id: I5c50731ff9f330c05c5841b8c65f16e28e67422c
2013-08-30 14:06:19 +00:00
Ken Wakasa
56e1b7e4f1 Fix emoji view insets calculation
bug: 10541453
Change-Id: I605e657c94686c4974d162657a5e820798d20e8f
2013-08-30 21:18:36 +09:00
Satoshi Kataoka
5169937dd4 Revert "Revert "Support Emoji keyboard""
Window resizing junkiness is addressed in I605e657c9468

This reverts commit aabc972338.

Change-Id: I0bc0f1ad9a90799e643fe9ec35f5b4bbe94eee0d
2013-08-30 19:46:10 +09:00
Ken Wakasa
9f79cf6de4 Merge "Add onGetSuggestedWordsCallback." 2013-08-30 07:52:57 +00:00
Ken Wakasa
2f95baaaf0 Merge "Revert "Remove key preview backing view"" 2013-08-30 07:51:29 +00:00
Ken Wakasa
c160a3932f Revert "Remove key preview backing view"
This reverts commit 2dfcfc5013.

Change-Id: I96c691b2e9c92be456420196cd7361d03ea4f3e9
bug: 10541453
2013-08-30 07:50:37 +00:00
Ken Wakasa
aabc972338 Revert "Support Emoji keyboard"
This reverts commit d7791a93b0.

Change-Id: I5ca4c0227f97540e8a22b487b5056dfa3611082b
2013-08-30 07:23:42 +00:00
Yuichiro Hanada
820c290a61 Add onGetSuggestedWordsCallback.
Change-Id: Ib527d31f9c2dd6dc385cb2f767cd90d9d28a1b1b
2013-08-30 16:08:13 +09:00
Tadashi G. Takaoka
d7791a93b0 Support Emoji keyboard
Bug: 6370846
Change-Id: I33ce8f952799c89929996a226ac17731a953ec2a
2013-08-29 19:48:34 +09:00
Keisuke Kuroyanagi
fe87f5f417 Pass additionalFeaturesOptions for getSuggestions().
This fixes null pointer exceptions that are caused when
getSuggestion() is called from spell checker.

Change-Id: Ifc9e7abb900e1a4646e33c91022effde439673e4
2013-08-28 19:24:28 +09:00
Tadashi G. Takaoka
c0f81463cb Merge "Add dummy Emoji subtype" 2013-08-28 07:42:29 +00:00
Tadashi G. Takaoka
34cbcc1aed Add dummy Emoji subtype
Bug: 6370846
Change-Id: I4fa3a6832fa316d0c6312d434be3c3ff02b52402
2013-08-28 16:26:00 +09:00
Keisuke Kuroyanagi
f0c4575cf4 Fix: Wrong file name for dynamic prediction dictionary.
Bug: 6669677
Change-Id: Id6f06a7423600d3f0604fab43d855826c20d0545
2013-08-28 14:41:32 +09:00
Tadashi G. Takaoka
16ed1868a1 Fix build
Change-Id: I60a6ee4dff8203cd9a2ed8045df6a2d75e50c89d
2013-08-27 17:32:37 +09:00
Tadashi G. Takaoka
08323cd597 Add _gb to Gingerbread resources
Bug: 10415342
Change-Id: Id8caf5a972fe72b577dbf50dcd2cf739b2d35a32
2013-08-27 17:05:22 +09:00
Keisuke Kuroyanagi
78ab1bb661 Merge "Make DynamicPred...Base extend ExpandableBinaryDictionary." 2013-08-26 09:56:47 +00:00
Keisuke Kuroyanagi
6e04d65932 Make DynamicPred...Base extend ExpandableBinaryDictionary.
Bug: 6669677
Change-Id: I06afad35d3eb73510c34d10cd4116f5bcf934f7c
2013-08-26 18:50:22 +09:00
Yuichiro Hanada
d5a3c593db Remove a broken dictionary file when fail to read a dictionary file.
Bug: 10434720
Change-Id: Ibdf05a39113538546b8fcf9d59af7dddf7ca27fc
2013-08-26 18:08:21 +09:00
Yuichiro Hanada
b50a7a4bc7 Simplify computeActualNodeArraySize.
Change-Id: I128d02866c2cc70c42263496927327b8a2130139
2013-08-26 08:30:23 +00:00
Yuichiro Hanada
2232a70806 Clean up unused imports.
Change-Id: I7147ca237b99399e79210852aa5bf5a01101d779
2013-08-26 08:29:16 +00:00
Yuichiro Hanada
752a33640c [Refactor] Add DictDecoder.readUnigramsAndBigramsBinary.
Change-Id: I259db91d837c67cbcb3b6dc504b21dca23a6a5be
2013-08-26 17:24:38 +09:00
Yuichiro Hanada
bb5b84a826 [Refactor] Add DictDecoder.getTerminalPosition.
Change-Id: I9d04f64a58f5481cbb64cf1c09b5c485dd4176b4
2013-08-26 16:14:59 +09:00
Ken Wakasa
800225e0b1 Merge "Rename CharGroup to PtNode." 2013-08-26 07:11:12 +00:00
Yuichiro Hanada
576f625ee1 Rename CharGroup to PtNode.
Bug: 10233675
Change-Id: I7b0eb07d195cd386cd0d9e97cd59bf48fcf24107
2013-08-26 15:58:30 +09:00
Keisuke Kuroyanagi
958f84320d Merge "Introduce DynamicDictionaryWriter for dynamic dictionary." 2013-08-26 02:29:01 +00:00
Yuichiro Hanada
8f4d5d5f23 Fix getDictionaryFileHeader.
Change-Id: I5186f41b0f38eb08f4154f7b3de7ffc2119fc44b
2013-08-23 22:39:36 +09:00
Keisuke Kuroyanagi
87a72f50c2 Introduce DynamicDictionaryWriter for dynamic dictionary.
Bug: 6669677
Change-Id: Ifcbeb88b908f2301ac062b411a95c8b38d24b90e
2013-08-23 22:04:27 +09:00
Yuichiro Hanada
e9a10ff0f0 Add DictDecoder.readDictionaryBinary.
Bug: 10434720
Change-Id: I14690a6e0f922ed1bab3a4b6c9a457ae84d4c1a4
2013-08-23 20:29:25 +09:00
Satoshi Kataoka
d4528b88e1 Refactor personalization dictionary
Bug: 9429906
Change-Id: I1fa4b045b21687e96de101a97e9593b0884d626f
2013-08-23 18:40:28 +09:00
Yuichiro Hanada
1b50a42b7c Fix addWord.
Change-Id: Ib71dbd5954f44ca80733fa4b1048c829e1df138a
2013-08-23 16:56:48 +09:00
Ken Wakasa
4929f8516c Merge "Fix writePlacedNode." 2013-08-22 14:03:53 +00:00
Yuichiro Hanada
aa4168ee09 Fix writePlacedNode.
Change-Id: I1d6b086f1d9f0dbd8d74f964e29ae62c533af978
2013-08-22 23:02:08 +09:00
Satoshi Kataoka
366c0c5198 Register personalization dictionary
Bug: 9429906
Change-Id: Ic754dd8da67446dfb1ebf44aa3d5ab0804298ca0
2013-08-22 18:06:59 +09:00
Yuichiro Hanada
e301085a70 Move findWordByBinaryDictReader to BinaryDictIOUtilsTests.
Change-Id: I443238fd816dea9650dcbbeb3ea757f9674fa52f
2013-08-22 14:49:49 +09:00
Ken Wakasa
fef693ea98 Merge "Add DictEncoder." 2013-08-22 05:38:09 +00:00
Yuichiro Hanada
c922c8a504 Add DictEncoder.
Change-Id: I41049b9118b58838e5dedf8e5618d939ca70c5ef
2013-08-22 11:53:41 +09:00
Kurt Partridge
a09e43ef6e Merge "Fix cursor state bug" 2013-08-22 01:24:15 +00:00
Kurt Partridge
6c94a18a28 Fix cursor state bug
InputConnection#finishComposingText() should not change the position of the cursor,
so neither should it change its internal expectation of the cursor's position.

Change-Id: Ib3d39a5743cd1e8e356f438b04a5c30279430b2a
2013-08-21 17:55:35 -07:00
Ken Wakasa
f9233e0b98 Merge "Make readPtNode be called with the address from the beginning of the file." 2013-08-21 11:27:20 +00:00
Yuichiro Hanada
558e34c7bd Make readPtNode be called with the address from the beginning of the file.
Change-Id: I8939fdfb4f79e55bcd7393633784effb30df3f8f
2013-08-21 20:02:18 +09:00
Satoshi Kataoka
17cc396972 Merge "Fix build" 2013-08-21 10:56:18 +00:00
Satoshi Kataoka
b1552723ee Fix build
Change-Id: I0c0be463552a37cecfb9a403e0723b1799fb8120
2013-08-21 19:55:07 +09:00
Satoshi Kataoka
f739807a3f Merge "Add onDestroy to PersonalizationDictionarySessionRegister" 2013-08-21 10:54:08 +00:00
Yuichiro Hanada
a306e08753 Rename BinaryDictEncoder to BinaryDictEncoderUtils.
Change-Id: I4dabf17da7003b1d8204a83dbd10e5be6e8fd805
2013-08-21 18:54:34 +09:00
Yuichiro Hanada
107a5f6fb8 Add PtNodeReader.
Change-Id: Ic918822fc1b3a8a7c39ffbcf7defde2c5bf888db
2013-08-21 18:43:18 +09:00
Satoshi Kataoka
3c8f22880f Add onDestroy to PersonalizationDictionarySessionRegister
Bug: 9429906
Change-Id: Ibf8efd7302da2c27ac59e62b0393f1eec03dc136
2013-08-21 17:24:12 +09:00
Jean Chalard
77827e7b3b Merge "Don't start composing on dash." 2013-08-21 08:06:13 +00:00
Tadashi G. Takaoka
1f39d36458 Remove unnecessary alpha attributes of SuggestionStripView
Change-Id: I78701403d7bd21928c4b459bb336a565f386ebcc
2013-08-21 12:44:30 +09:00
Jean Chalard
2448159ad4 Don't start composing on dash.
Bug: 10403176
Change-Id: I9f969ab9b772dc5ba2015c494b4f98a8864277c4
2013-08-21 11:59:21 +09:00
Jean Chalard
2c7a3e0405 Merge "[AC3] Start calling the methods for auto-commit." 2013-08-20 11:05:23 +00:00
Jean Chalard
c10d76f28c Merge "[AC2] Reference a dict rather than a string in suggestion infos" 2013-08-20 11:05:12 +00:00
Jean Chalard
3f15c41d88 Merge "[AC1] Add a memory of where to cut the first word." 2013-08-20 11:05:09 +00:00
Jean Chalard
66a870cb53 [AC3] Start calling the methods for auto-commit.
Bug: 9059617
Change-Id: I190a4baf2fa831b70e00e129b5dfaa8c9c32b3a0
2013-08-20 19:26:11 +09:00
Jean Chalard
e8ef095670 [AC2] Reference a dict rather than a string in suggestion infos
Bug: 9059617
Change-Id: Ic17bc0fd5d812268fd37d7fd35b4e9ebfb95fa5e
2013-08-20 19:18:09 +09:00
Jean Chalard
ef1e363016 [AC1] Add a memory of where to cut the first word.
Bug: 9059617
Change-Id: I931b6d1eb49f9f7dd7d5b18956e35751d1b2b631
2013-08-20 18:43:19 +09:00
Satoshi Kataoka
33f5f0df8b Merge "Add a functionality to boost scores of personalization dictionary" 2013-08-20 09:08:41 +00:00
Satoshi Kataoka
d6ddb96ee8 Add a functionality to boost scores of personalization dictionary
Bug: 9429906
Change-Id: I1518c5cbc7d41188e7dc6a35d226da277ed5913f
2013-08-20 17:50:48 +09:00
Yuichiro Hanada
065aad9501 Add DictDecoder.
Change-Id: Ia1c32f21fe07081ce04d093660e18146b93275a4
2013-08-20 17:43:13 +09:00
Yuichiro Hanada
112257e40f Rename BinaryDictDecoder to Ver3DictDecoder.
Change-Id: Ibf9b95b658df6e2c2218bdb62e2380f326a03832
2013-08-20 17:11:51 +09:00
Yuichiro Hanada
66004ce2de Remove populateOptions.
Change-Id: I1a1830aaa8ea586b68fc34ff3a27ae52b810e8af
2013-08-20 16:06:52 +09:00
Satoshi Kataoka
22f01a42fc Add a functionality to clear and flush prediction dictionary
Bug: 9429906
Change-Id: I84ec444e9d46a0080dc3450b8ab32bfb99407cfe
2013-08-20 12:28:05 +09:00
Yuichiro Hanada
77bce05e6f [Refactor] Rename BinaryDictReader and BinaryDictDecoder.
BinaryDictReader -> BinaryDictDecoder.
BinaryDictDecoder -> BianryDictDecoderUtils.

Change-Id: Iadf2153b379b760538ecda488dda4f17225e5f37
2013-08-19 19:36:31 +09:00
Tadashi G. Takaoka
c8fb03e6a8 Merge "Save and restore Row attributes using stack" 2013-08-19 10:03:09 +00:00
Tadashi G. Takaoka
bcd173dfa1 Save and restore Row attributes using stack
Change-Id: I5cb402060946a711384ee53fa1caaeac86aa10cc
2013-08-19 18:36:49 +09:00
Satoshi Kataoka
6484a4f886 Consolidate onDictionaryClosed
Bug: 9429906
Change-Id: I51eef4c321cc268eac1c8dfd6561ab6e716a1fb0
2013-08-19 17:45:20 +09:00
Satoshi Kataoka
0e6fcf2bf6 Rename Personalization dictionary register functions
Bug: 9429906
Change-Id: Ibdce8db61ab6cc5922765e7ed8b7f2c718759de8
2013-08-19 16:53:21 +09:00
Keisuke Kuroyanagi
c8ac8da4e4 Merge "Prepare ExpandableBinaryDictionary to make it updatable" 2013-08-19 07:20:16 +00:00
Satoshi Kataoka
979f9f9939 Merge "Consolidate hex string utils" 2013-08-19 05:33:07 +00:00
Satoshi Kataoka
3894a5599b Consolidate hex string utils
Change-Id: Id4f4a287e3a2790b22bff7ad4a4617bf2ee82884
2013-08-19 12:09:59 +09:00
Ken Wakasa
a83e25642f Merge "Add HeaderReaderInterface." 2013-08-19 02:34:23 +00:00
Yuichiro Hanada
d794b42f98 Add HeaderReaderInterface.
Change-Id: I298f86b70d18cd08b240509b6f757c72e1a59ffe
2013-08-19 11:15:03 +09:00
Yuichiro Hanada
8aaae56cf6 Fix unit test.
Change-Id: Ib104d5de71c2ab1a07921b407c74c21b0409d9af
2013-08-19 11:10:28 +09:00
Ken Wakasa
606a056b53 Merge "Make BinaryDictIOUtils and DynamicBinaryIOUtils use BinaryDictReader." 2013-08-16 12:46:07 +00:00
Yuichiro Hanada
3a73b37b30 Make BinaryDictIOUtils and DynamicBinaryIOUtils use BinaryDictReader.
Change-Id: I191dfe0e05ff3c2c5af99e8beebbb73b097748a3
2013-08-16 21:06:23 +09:00
Jean Chalard
e32475611c Merge "Support languages that don't use spaces." 2013-08-16 12:05:16 +00:00
Jean Chalard
c239a34262 Support languages that don't use spaces.
Thai is an example.

Bug: 10138062
Change-Id: Ib9a8264c77ed42b4256432d7c8a60d08575dcdc7
2013-08-16 21:01:08 +09:00
Ken Wakasa
c2f2d0d211 Merge "Limit the number of waiting UpdateBinaryTask to at most 1." 2013-08-16 11:58:57 +00:00
Yuichiro Hanada
e72c4e5fc7 Remove a static buffer for thread safety.
Change-Id: I335c35eb182ff63abb8a5b04c053a98d44b7c6ce
2013-08-16 20:22:46 +09:00
Keisuke Kuroyanagi
c8db6f21e9 Prepare ExpandableBinaryDictionary to make it updatable
Bug: 6669677

Change-Id: Iaa6100f58de78d104e19c7a3c41d67e7826264f9
2013-08-16 20:16:31 +09:00
Yuichiro Hanada
0d70bcc821 Limit the number of waiting UpdateBinaryTask to at most 1.
Change-Id: Ia588d8f29ab58983ea5321ff8c63ad273c33eab3
2013-08-16 19:44:47 +09:00
Ken Wakasa
47bac6ebf2 Merge "Remove unnecessary caching." 2013-08-16 08:28:19 +00:00
Yuichiro Hanada
6e26cc3f5d Remove unnecessary caching.
Change-Id: Ic4ccab9d344b30b72fca1503827eec1c628fa4ac
2013-08-16 17:10:45 +09:00
Jean Chalard
21dddb1462 Merge "Rename Node to PtNodeArray" 2013-08-16 08:00:55 +00:00
Jean Chalard
af30cbf0ee Rename Node to PtNodeArray
Bug: 10247660
Change-Id: I1a0ac19f58f96adb5efac5fd35c6404831618c99
2013-08-16 16:24:54 +09:00
Satoshi Kataoka
283cf9cfc9 Add hex string utils
Bug: 9429906
Change-Id: I3267d1d86122ab471c3e63008c73e9f9b758fc8e
2013-08-16 16:17:48 +09:00
Ken Wakasa
33fce975c9 Merge "[Refactor] Divide BinaryDictInputOutput into BinaryDictEncoder and BinaryDictDecoder." 2013-08-15 11:26:06 +00:00
Yuichiro Hanada
94460eba11 [Refactor] Divide BinaryDictInputOutput into BinaryDictEncoder and BinaryDictDecoder.
Change-Id: I7c3269d77e3e3b567e459dcaa1bc029903941744
2013-08-15 20:23:07 +09:00
Tadashi G. Takaoka
840e42d7f3 Merge "Add getters and copy constructor to Key class" 2013-08-15 11:15:42 +00:00
Tadashi G. Takaoka
7dc60f9db7 Add getters and copy constructor to Key class
Change-Id: I78eb96dcc26378926dc63acbfeb4828cbd44435d
2013-08-15 20:12:46 +09:00
Jean Chalard
e7870a2c0d Add an initial JNI interface to dicttool.
Bug: 10100269
Change-Id: I883992c2033e7d9e7c754c0bf653767728b221b6
2013-08-15 17:58:55 +09:00
Ken Wakasa
dc83fe37ba Merge "Revert "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils."" 2013-08-15 08:56:28 +00:00
Ken Wakasa
117f18e844 Revert "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils."
This reverts commit 4c63d0614e.

Change-Id: I1fa277d720bab4d895259df7d6d82eebfa5eb6c5
2013-08-15 08:54:29 +00:00
Ken Wakasa
f74ddfbb06 Merge "[Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils." 2013-08-15 06:53:23 +00:00
Yuichiro Hanada
4c63d0614e [Refactor] Divide BinaryDictInputOutput into BinaryDictInputUtils and BinaryDictOutputUtils.
Change-Id: I0d476abe763c11ba9005152f928e8dccf15ac9de
2013-08-15 15:46:58 +09:00
Satoshi Kataoka
a38a15ddc0 Merge "tiny refactor" 2013-08-15 06:38:49 +00:00
Satoshi Kataoka
1aae34873c tiny refactor
Change-Id: I776432b6c41cf8dee71fbd1565a6f3da9d762f9e
2013-08-15 13:38:05 +09:00
Yuichiro Hanada
1db93c9c04 [Refactor] Move some helper methods to BinaryDictIOUtils.
Change-Id: Ib817a975dc1f82241f732b236c44b042fda25b3c
2013-08-15 10:49:40 +09:00
Satoshi Kataoka
be4d38e61f Merge "Fix test breakage" 2013-08-14 11:40:34 +00:00
Satoshi Kataoka
2b39fab829 Fix test breakage
Change-Id: I10bd8fcc68711a039e000f715d7a65ae42095965
2013-08-14 20:38:32 +09:00
Satoshi Kataoka
5654a1f21e Merge "Fix a debug functionality for the personalization prediction" 2013-08-14 10:43:31 +00:00
Ken Wakasa
8e398e2147 Merge "Move some methods in BinaryDictIOUtils to DynamicBinaryDictIOUtils." 2013-08-14 10:38:15 +00:00
Satoshi Kataoka
d09ad2e368 Fix a debug functionality for the personalization prediction
Bug: 9429906

Change-Id: I10d39e1f8758dcb64c9c0111d516e3abfe81b04e
2013-08-14 19:36:20 +09:00
Yuichiro Hanada
3edb62c69b Move some methods in BinaryDictIOUtils to DynamicBinaryDictIOUtils.
Change-Id: I9ba55582c533fef0eb3e60c46bf23c8b16ee1ff4
2013-08-14 19:33:36 +09:00
Satoshi Kataoka
92038bcacd Merge "Add a method to import one bigram and string utilities" 2013-08-14 10:29:06 +00:00
Ken Wakasa
f795f2b789 Merge "Add FusionDictionaryBufferFromWritableByteBufferFactory." 2013-08-14 10:26:21 +00:00
Ken Wakasa
0766f13391 Merge "Move some constants in BinaryDictInputOutput to FormatSpec." 2013-08-14 10:25:04 +00:00
Yuichiro Hanada
665592774c Move some constants in BinaryDictInputOutput to FormatSpec.
Change-Id: I6b12faf35b65238b9a64c82d4d1a6050f980e72e
2013-08-14 19:19:27 +09:00
Tadashi G. Takaoka
bdef628a35 Merge "Add empty key background type" 2013-08-14 10:13:33 +00:00
Tadashi G. Takaoka
ed5582ec65 Merge "Thin out audio and haptic feedback while key repeat" 2013-08-14 10:11:43 +00:00
Satoshi Kataoka
4ee953125a Add a method to import one bigram and string utilities
Bug: 9429906
Change-Id: I73bbf65985196d62470552c576bb076a7cb95008
2013-08-14 18:56:12 +09:00
Jean Chalard
5fd8b7ebd5 Merge "Add looksValidForDictionaryInsertion" 2013-08-14 09:41:49 +00:00
Jean Chalard
af5fbe70ac Add looksValidForDictionaryInsertion
...and test it.

Also at the same time, add a facility to create a SettingsValues for
test, and some minor performance improvement to surrounding
methods.

Change-Id: I13b629ae14755c244af2a9406a7e9b4a4a16090f
2013-08-14 18:39:28 +09:00
Tadashi G. Takaoka
ab16237e69 Thin out audio and haptic feedback while key repeat
Bug: 6522943
Change-Id: Id60f256ab0f8741578eda276116817fa48917325
2013-08-14 18:37:58 +09:00
Jean Chalard
fdfc8ad2d0 Merge "Re-evaluate auto-caps earlier." 2013-08-14 09:29:48 +00:00
Tadashi G. Takaoka
e18439d5c7 Add empty key background type
Change-Id: I9b07c58a9b70ae0228f87e1f066ca8cd959b4f03
2013-08-14 18:12:11 +09:00
Jean Chalard
4bc74d19ef Merge "Delete surrogate together." 2013-08-14 09:06:07 +00:00
Jean Chalard
b2d954cad6 Delete surrogate together.
Stop deleting them one after the other, it makes no sense. We
can know in advance if we should delete two of them, so let's
use that.

Bug: 6526420
Change-Id: Ifa2263cbde8fedc78bb750b84d4acd3f979774ea
2013-08-14 17:53:33 +09:00
Jean Chalard
b7e782d868 Re-evaluate auto-caps earlier.
We have all we know to re-evaluate auto-caps in this case.
We don't need to wait until we get the callback from TextView.

Bug: 10287972
Change-Id: I87e4e26cd193a001f91fe852ffc5a8f728db2449
2013-08-14 17:40:23 +09:00
Jean Chalard
1162c0537d Merge "Remove dead code" 2013-08-14 08:35:46 +00:00
Yuichiro Hanada
bbc8a930f7 Add FusionDictionaryBufferFromWritableByteBufferFactory.
Change-Id: I23de0a178e7f11f2cf301fd433cde60c6152055b
2013-08-14 17:07:44 +09:00
Jean Chalard
d81b9d0276 Remove dead code
isComposingWord() is actually defined as size > 0, so this test
can never be false.

Change-Id: If71afae6f0b16bff46178f0fae3244597354fecb
2013-08-14 16:38:37 +09:00
Jean Chalard
e18fdf804a Merge "Fix a bug with surrogate pairs" 2013-08-14 07:27:54 +00:00
Jean Chalard
a74ae9c451 Fix a bug with surrogate pairs
Bug: 10316781
Change-Id: I528c59c8823cda11975cb01b0ae59f12cfadef3b
2013-08-14 16:00:28 +09:00
Ken Wakasa
ae59ce0262 Merge "Remove audio and haptic feedback while key repeating" 2013-08-13 21:50:20 +00:00
Yuichiro Hanada
3feacba1eb Add BinaryDictReader.
Bug: 9618601

Change-Id: Ief07fa0c3c4f7f5999a3fafcef4e47b6b6fd8143
2013-08-13 19:55:05 +09:00
Ken Wakasa
7242bf1a15 Merge "Make readHeader check the header size before using it." 2013-08-13 08:14:43 +00:00
Yuichiro Hanada
b7bb9c9722 Make readHeader check the header size before using it.
Change-Id: I5dc3e2b674f7343ef57317fde6bdb7349a7fe04c
2013-08-13 17:06:25 +09:00
Tadashi G. Takaoka
d1d607287d Remove audio and haptic feedback while key repeating
Bug: 6522943
Change-Id: Iad1b11172e47bfbae2b4129361a56b9d793f8f62
2013-08-13 17:03:26 +09:00
Satoshi Kataoka
310f8a0f06 Call onDictionaryReady
Bug: 9429906

Change-Id: Ifc538b38b7d37469aecccd32a7e3f95a90558be7
2013-08-13 11:41:48 +09:00
Satoshi Kataoka
1b7c1cd513 Merge "Add PersionalizationDictionaryRegister" 2013-08-12 06:23:12 +00:00
Satoshi Kataoka
8c4fcb108f Add PersionalizationDictionaryRegister
Bug: 9429906
Change-Id: Ibd4d5cedb371c0b4ee1342a3e6d221c9e34c2402
2013-08-12 14:48:45 +09:00
Ken Wakasa
66a63db2d5 Merge "Rationalize how to use AdditionalFeaturesSettingUtils" 2013-08-12 01:36:46 +00:00
Ken Wakasa
4a2f6a2216 am 25402fd5: am 724db044: Deallocate gesture trail bitmap when unneeded further
* commit '25402fd5309891884a843528d47f6b4646341a3f':
  Deallocate gesture trail bitmap when unneeded further
2013-08-09 15:53:29 -07:00
Ken Wakasa
02938c6baf Rationalize how to use AdditionalFeaturesSettingUtils
It should be called regardless of the gesture input being enabled or not

Change-Id: I223a823ef18389227fc04d000cc7bf750797ba31
2013-08-10 00:32:07 +09:00
Ken Wakasa
724db04495 Deallocate gesture trail bitmap when unneeded further
Follow up to I5bc980c4dc41bc304be3c190934c1f7c55c9d244

bug: 8967766
Change-Id: I7b916daa5269cfde359a77555e8ffadf0e4a8f92
2013-08-09 21:07:40 +09:00
Tadashi G. Takaoka
2dfcfc5013 Remove key preview backing view
This change re-origanizes view hierarchy of IME's input view.

Change-Id: I9d0a07692d0f41de3345d207366393bcd5424f7e
2013-08-09 20:25:42 +09:00
Ken Wakasa
cfcf6660fc Reinstate a call to UsabilityStudyLogUtils#writeChar()
The usability study mode has been broken.

bug: 10251399
Change-Id: Iaa301241f102f412fa073f0d8b897a4c8b265a9c
2013-08-09 19:32:02 +09:00
Yuichiro Hanada
7ec9db2c34 Remove the code and comments about version 1 format.
Change-Id: I827052f234eeaa4dbcfd37da69a99866896a158b
2013-08-09 16:05:07 +09:00
Satoshi Kataoka
5c057b3241 Merge "Fix unit tests." 2013-08-08 10:14:27 +00:00
Yuichiro Hanada
7d1ae52ded Fix unit tests.
Change-Id: Ic0013089625e112aaccc888d462330640ef7cc6f
2013-08-08 19:12:35 +09:00
Tadashi G. Takaoka
96b444d429 Merge "Remove processMotionEvent from MoreKeysKeyboardView" 2013-08-08 08:23:23 +00:00
Satoshi Kataoka
1181c5acbc Merge "Fix to follow the field naming conventions." 2013-08-08 08:06:45 +00:00
Tadashi G. Takaoka
33482a9b9c Remove processMotionEvent from MoreKeysKeyboardView
Change-Id: I5373df4a7c82f964f99acf70325bba8702111a75
2013-08-08 15:30:09 +09:00
Keisuke Kuroyanagi
b6d48c4c0b Make user and contacts dict use ver3 format.
Bug: 6669677
Change-Id: I6a20eed2c8afdd1c16ada5bf85067864c7cd2a7f
2013-08-08 14:57:19 +09:00
Yuichiro Hanada
71ffcc6332 Fix to follow the field naming conventions.
Change-Id: I9b41b5f34e93a3f291a352cd85c5ac257beaa9ab
2013-08-08 12:03:36 +09:00
Jean Chalard
4456d1a8c1 Merge "Have double-space-to-period cancel leave a single space" 2013-08-08 02:52:24 +00:00
Jean Chalard
522d13c302 Have double-space-to-period cancel leave a single space
Bug: 8911898
Change-Id: Ifb4bb63c14dc960d0a53f1511908830093cca012
2013-08-08 11:49:27 +09:00
Tadashi G. Takaoka
083a40b291 Merge "Move createKeyboardSetForSpellChecker to AndroidSpellCheckService" 2013-08-07 10:32:56 +00:00
Tadashi G. Takaoka
15b80c4ec2 Merge "Add ResouceUtils.getDefaultKeyboardHeight" 2013-08-07 10:32:30 +00:00
Tadashi G. Takaoka
204e7b1401 Move createKeyboardSetForSpellChecker to AndroidSpellCheckService
Change-Id: I4a9065e703e98ffed50f2a6d76ace938dfc26ddf
2013-08-07 19:24:22 +09:00
Tadashi G. Takaoka
3897a43940 Add ResouceUtils.getDefaultKeyboardHeight
Change-Id: I377f6a83ec86b0345b170e7ad995d4577220d0ad
2013-08-07 19:23:31 +09:00
Satoshi Kataoka
c05b3b56cc Merge "Add a session for the personalization dictionary" 2013-08-07 08:45:19 +00:00
Satoshi Kataoka
80aa7197b4 Add a session for the personalization dictionary
Bug: 9429906
Bug: 4192129

Change-Id: I361ab380edeee5a8a8b364df3f9f4ab202b79105
2013-08-07 16:44:30 +09:00
Tadashi G. Takaoka
8ba8798290 Merge "Consolidate forwardTouchEvent with dispatchTouchEvent" 2013-08-06 06:38:33 +00:00
Tadashi G. Takaoka
cc38bfb5d3 Merge "Add emoji icon and code as a groundwork" 2013-08-06 05:35:14 +00:00
Tadashi G. Takaoka
b127d88285 Add emoji icon and code as a groundwork
The emoji switching key icon asset should be updated. The icons in
this change are just borrowed from Hangout.

Bug: 10179862
Bug: 6370846
Change-Id: Icea26d2cf2ac6a6df9beb4c98f646dbe309bdcd9
2013-08-06 14:16:15 +09:00
Tadashi G. Takaoka
88f840d2a2 Consolidate forwardTouchEvent with dispatchTouchEvent
Change-Id: Ib73962acff72be0a78a3565028572ad694fb8501
2013-08-06 11:04:51 +09:00
Tadashi G. Takaoka
52d220e71b Remove unnecessary suggestion strip container
Change-Id: I3710e1fe1574c0f69f7f448619e939fb45e9b8d3
2013-08-06 10:57:47 +09:00
Tadashi G. Takaoka
c0a732f032 Remove CODE_RESEARCH
Instead of CODE_RESEARCH, special outputText ".research." is used to
invoke a research feedback dialog.

Change-Id: Ic95c956ab4f2b5f0c3f2205c9bbcdcfb67db5d6e
2013-08-05 19:05:07 +09:00
Tadashi G. Takaoka
28a148681e Small cleanup
Change-Id: I7dce7373b371f1ed5a985815f5d43fb6c6ee1f84
2013-08-05 18:46:35 +09:00
Satoshi Kataoka
33592d1bee Merge "Add a debug preference for using only personalization dictionary" 2013-08-02 11:30:20 +00:00
Jean Chalard
ba2f4f84ca Merge "Fix a concurrency bug." 2013-08-02 11:28:45 +00:00
Jean Chalard
10d66669c7 Fix a concurrency bug.
This probably only ever happens in tests, but still, that's
the right thing to do.

Bug: 10139031
Change-Id: I259be9e7306162e19faf738a093a77762f2e7675
2013-08-02 20:26:37 +09:00
Satoshi Kataoka
d7491e6e81 Add a debug preference for using only personalization dictionary
Bug: 9429906
Change-Id: I2003060c7065e736d42f3b3303fbba549358dd18
2013-08-02 20:10:57 +09:00
Satoshi Kataoka
60586b57cf Connect the personalization dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I9c9f3ed7699f74339ad92be6dcddb8a52c377545
2013-08-01 16:33:20 +09:00
Tadashi G. Takaoka
552a4b84f8 Merge "Add UsabilityStudyLogUtils.writeMotionEvent" 2013-07-31 14:21:04 +00:00
Satoshi Kataoka
567e7f05c1 Add the personalization prediction dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I0663de025405b2c92eebd528339b82baec97e2ce
2013-07-31 21:37:33 +09:00
Satoshi Kataoka
853d0fd122 Refactor the personalization dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I9f094bc5a6ce4652e310e090f1536e43f1f24ad1
2013-07-31 21:15:13 +09:00
Ken Wakasa
883bd364eb Merge "Deallocate gesture trail bitmap when unneeded" 2013-07-31 11:46:25 +00:00
Ken Wakasa
c8814e20b7 Deallocate gesture trail bitmap when unneeded
This frees up 1.7MB on Nexus 4 (occam), and 900KB on occam_svelte while
LatinIME goes to background.
The keyboard bring-up speed feels acceptable on both devices.

bug: 8967766
Change-Id: I5bc980c4dc41bc304be3c190934c1f7c55c9d244
2013-07-31 20:39:32 +09:00
Satoshi Kataoka
3b1eb88658 Merge "Refactor the user history dictionary" 2013-07-31 10:37:31 +00:00
Satoshi Kataoka
1439130442 Refactor the user history dictionary
Bug: 9429906
Bug: 4192129

Change-Id: If53bc3220627802d82ab7c396d0aabdb658573fa
2013-07-31 19:22:11 +09:00
Tadashi G. Takaoka
30977a151e Add UsabilityStudyLogUtils.writeMotionEvent
Change-Id: I41ee6d1879dc937e1554fedfc603d9bb5bec40f2
2013-07-31 19:05:14 +09:00
Jean Chalard
2d7e927354 Fix inconsistencies with mSuggest.
This should fix some NPEs, but they are so unlikely that we never
see them.

Bug: 10065412
Change-Id: I2aefea1f52024405cc3fda9106fea41a02aaf4d8
2013-07-31 18:59:18 +09:00
Satoshi Kataoka
87d06afc66 Refactor on the user history dictionary
Bug: 9429906
Bug: 4192129
Change-Id: I1a2bfe96e18119d30a72290aa48746f77a021018
2013-07-31 16:48:55 +09:00
Jean Chalard
8d46ea9156 Merge "Fix some warnings" 2013-07-31 07:38:49 +00:00
Jean Chalard
7d654d8cae Merge "Fix inconsistency with mutable settings." 2013-07-31 07:38:22 +00:00
Jean Chalard
561c447404 Merge "Fix a problem where settings were not renewed correctly." 2013-07-31 07:17:49 +00:00
Jean Chalard
93445b4821 Fix some warnings
Change-Id: I7290cd1fb675a1b85b9b6ac2d464c932b5bca1dd
2013-07-31 16:17:01 +09:00
Jean Chalard
f8c1aefd90 Merge "Clarify the expected cursor position in RichInputConnection." 2013-07-31 04:56:35 +00:00
Jean Chalard
aa108f1d7f Clarify the expected cursor position in RichInputConnection.
Change-Id: I4d36a23567415c3a293a588b51b46006256c148f
2013-07-31 12:22:15 +09:00
Satoshi Kataoka
323a7aae6c Merge "Fix the title of the personal dictionary settings" 2013-07-30 08:17:01 +00:00
Satoshi Kataoka
8befd36c65 Fix the title of the personal dictionary settings
Bug: 8976598
Change-Id: I9e07ff9e06449e2093b9ba8d6f28a030c69756bc
2013-07-30 15:39:41 +09:00
Jean Chalard
c5c226c424 Fix inconsistency with mutable settings.
Change-Id: I0550044199273cecb6f5713aa2e43ae16319cd47
2013-07-30 14:30:24 +09:00
Jean Chalard
74bcc911ea Fix a problem where settings were not renewed correctly.
Bug: 10065412
Change-Id: Id05284f45466cd5b2697a695c3d1bdfbf3cc1f24
2013-07-30 13:22:05 +09:00
Satoshi Kataoka
ab2d273133 Merge "Fix the displayed name of the personal dictionary" 2013-07-30 04:21:58 +00:00
Satoshi Kataoka
5123427532 Fix the displayed name of the personal dictionary
Bug: 8976598
Change-Id: I11dd73c8c23b05288c5f417352dc4cc99d489b95
2013-07-30 13:14:08 +09:00
Ken Wakasa
b60e65a0cc Rename a variable for SettingsValues
Change-Id: Icb4155532ea8724791c9194e8dc75ce32b6e8b16
2013-07-29 18:53:23 +09:00
Jean Chalard
d9f0c1e020 Merge "Fix an NPE" 2013-07-29 09:46:32 +00:00
Jean Chalard
5408fec63a Fix an NPE
Also make mSuggest private for more security.

Bug: 10045657
Change-Id: I712505e4d2a2606efff5d09ba9b4c656f9e7c7a9
2013-07-29 18:09:48 +09:00
Satoshi Kataoka
fb9f448b8d Merge "Add personalization dictionary helper" 2013-07-29 05:21:14 +00:00
Satoshi Kataoka
d45e4b6e5b Add personalization dictionary helper
Bug: 9429906
Bug: 4192129

Change-Id: Ic618b0b09a54ed46b20633bd4c1c570d4ac775af
2013-07-29 12:37:27 +09:00
Jean Chalard
654b0a9c16 Merge "Small optimization" 2013-07-26 11:30:50 +00:00
Jean Chalard
e7903101ea Merge "Use cached data for getTextBeforeCursor." 2013-07-26 11:25:59 +00:00
Jean Chalard
0a064a5d88 Small optimization
Bug: 8864306
Change-Id: Ic8eecd64eff6a1150a90b9f5ec9ebbc5f1d2a6a9
2013-07-26 20:17:55 +09:00
Jean Chalard
8c6537edbd Use cached data for getTextBeforeCursor.
Bug: 8864306
Change-Id: Ia146f711f1de4336d7e3363208ab92eba856f5e1
2013-07-26 20:17:52 +09:00
Satoshi Kataoka
2a8c75fc43 Merge "Add a place holder of the personalization dictionary" 2013-07-26 08:44:26 +00:00
Satoshi Kataoka
5c15b8f442 Add a place holder of the personalization dictionary
Bug: 9429906
Bug: 4192129

Change-Id: Ieacd0559e0bf286c5933e9dba716289303f533d6
2013-07-26 16:03:04 +09:00
Jean Chalard
38e9802690 Merge "Revert "Very simple refactoring"" 2013-07-26 06:58:44 +00:00
Jean Chalard
c6a07e16a5 Revert "Very simple refactoring"
This reverts commit f712dc9a4f.
It turns out this refactoring is not useful after all.

Change-Id: I0145c907b3cc5ac9a30a59abcd719cb546c9bd3a
2013-07-26 06:46:56 +00:00
Jean Chalard
0dd23544ff Merge "Very simple refactoring" 2013-07-26 05:30:47 +00:00
Satoshi Kataoka
ffcbbaf127 Refactor on UserHistoryDictionary
Bug: 9429906
Change-Id: I576a91643bdaf5017cc826ac2e07a74a9a275d60
2013-07-26 13:00:19 +09:00
Jean Chalard
f712dc9a4f Very simple refactoring
Bug: 8864306
Change-Id: I5c9b118cb6a8eb59efc52d5534b10fcab93182d6
2013-07-26 12:57:12 +09:00
Tadashi G. Takaoka
c34933828e Merge "Cancel all ongoing event when onFinishInputView" 2013-07-25 11:08:08 +00:00
Tadashi G. Takaoka
5c095e59f6 Cancel all ongoing event when onFinishInputView
Bug: 9334755
Change-Id: If0c2ac49a50f4a529aefeca603569f9413367469
2013-07-25 20:05:39 +09:00
Tadashi G. Takaoka
21c6d23dcd Merge "Add MoreKeysPanel argument to Controller methods" 2013-07-25 11:00:25 +00:00
Tadashi G. Takaoka
0e08d70fe5 Add MoreKeysPanel argument to Controller methods
Bug: 9334755
Change-Id: I5a7104f4c98982f11fb4e060fa83c21bfc360558
2013-07-25 19:53:05 +09:00
Tadashi G. Takaoka
15c41a61ad Merge "Remove boolean return value of dismissing more keys panel" 2013-07-25 10:45:05 +00:00
Tadashi G. Takaoka
09e4530ca7 Remove boolean return value of dismissing more keys panel
Bug: 9334755
Change-Id: Ic29ab69cfbf9007e98fe67695f1854b4876eb976
2013-07-25 17:51:48 +09:00
Jean Chalard
e408bbb5bf Merge "Fix a bug with multiple word insertion." 2013-07-25 08:34:41 +00:00
Jean Chalard
23a3fd5bfa Fix a bug with multiple word insertion.
This is a port of I5202bc52

Bug: 7903831
Change-Id: I3eb526de01a1f5b51212166e39b98de1d71e9eaf
2013-07-25 16:33:13 +09:00
Satoshi Kataoka
5563dc3ad5 Show all languages if user enables multiple subtypes
Bug: 8976598
Change-Id: I1c3c1ede1235f696eafb3a68ec5c29479768dd0f
2013-07-25 15:15:39 +09:00
Jean Chalard
289df0ecad Merge "[FD4] Separate cached address before/after update for groups" 2013-07-25 03:03:09 +00:00
Tadashi G. Takaoka
cecb63c2c9 Merge "Make RunInLocale as top-level class" 2013-07-24 13:34:52 +00:00
Tadashi G. Takaoka
9ef59af7ce Merge "Move subtype related utility class to utils package" 2013-07-24 13:34:35 +00:00
Jean Chalard
25de86a6a2 [FD4] Separate cached address before/after update for groups
This should fix bug#8526576 for good.

Bug: 8526576
Change-Id: I473aad26b69d64efa09d2ec9d8e69f29f5cf4819
2013-07-24 18:40:14 +09:00
Jean Chalard
429db8d61e [FD3] Split stackNodes into two methods.
In the future we need to have a method that computes only
from the size, as we used to have, to initialize the cached
addresses, and a much simpler and faster method to copy
the cached sizes.

Bug: 8526576
Change-Id: I6a5a790303ab8f3bf957c7ca266eb12da7c1ad9e
2013-07-24 17:26:16 +09:00
Tadashi G. Takaoka
0c3a9b549c Make RunInLocale as top-level class
Change-Id: I07ed606b7aba098a5be85533e5baff300b21fb44
2013-07-24 16:00:25 +09:00
Tadashi G. Takaoka
a410cb48ea Move subtype related utility class to utils package
Change-Id: I3564796531ea85f2ebafde40cd822b806b8741df
2013-07-24 15:52:43 +09:00
Jean Chalard
5526d138fe Merge "[FD2] Separate cached address before/after update for nodes." 2013-07-24 01:56:02 +00:00
Ken Wakasa
b9eb32679f Cosmetic fix for the copyright header
Change-Id: I2a93ac21571d1f6255a72a1a238b03dbb95108de
2013-07-23 19:39:03 +09:00
Ken Wakasa
db341afc65 Fix wrong copyright header comment
Change-Id: I75ffbc0508c00f7ac8004b764667a174b6ab0b63
2013-07-23 19:26:05 +09:00
Jean Chalard
91cbe3566d [FD2] Separate cached address before/after update for nodes.
Bug: 8526576
Change-Id: Ib9f8594a9e12dc75eba296faff2612c4bd7483d3
2013-07-23 17:52:54 +09:00
Tadashi G. Takaoka
e6c5184742 Fix NPE in SubtypeLocale.getSubtypeDisplayName
This change moves the methods that create the subtype display name for
spacebar from MainKeyboardView to SubtypeLocale class, and
consolidates SpacebarTextTests with SubtypeLocaleTests.

Bug: 9962955
Change-Id: Ifa0a08ff80bc30753a213c2feb471599ca63fa66
2013-07-23 13:00:04 +09:00
Jean Chalard
1676b8387f Merge "Fix a bug when moving the pointer in a > 48 chars word" 2013-07-22 08:04:43 +00:00
Jean Chalard
5fa2202e36 Fix a bug when moving the pointer in a > 48 chars word
Bug: 9892261
Change-Id: I9db20c5b20a0764bd9f5b5e2bdc98180bbb9ec15
2013-07-22 17:02:09 +09:00
Ken Wakasa
a7d2fc6bef Move settings related classes to "settings"
Change-Id: Id170dbfe2dcfc93130b7be4a84615940403ec37f
2013-07-22 16:35:44 +09:00
Ken Wakasa
b03447e1af Move a couple classes to the utils package
Change-Id: Ia14a2011d79bad7cd02697b9254705f6e2099442
2013-07-19 10:46:46 +09:00
Jean Chalard
257750d988 [FD1] Move parents' address computation outside
There is no need to do it repeatedly in this loop: it's
clearer and faster to do it at the end only.

Bug: 8526576
Change-Id: I707571179c89479830891ec6d4fd06a9fffed7c1
2013-07-17 20:47:53 +09:00
Tadashi G. Takaoka
6455172a70 Distinguish key press in repeat key
Bug: 9859367
Change-Id: Iad643f9785b193e1918a8363de4fefc3b7558bdf
2013-07-16 19:21:16 +09:00
Keisuke Kuroynagi
4944827e0f Merge "Add methods for dynamic updating binary dictionary." 2013-07-16 02:45:01 +00:00
Keisuke Kuroynagi
cfbb7fbd48 Fix: Read lock is wrongly used for gutSuggestions.
Bug: 9737865

Change-Id: I017f80b46c5dc48c40f2de7c4d516a042992feb4
2013-07-09 08:40:43 +00:00
Ken Wakasa
58b2a6372f Merge "Update ExpandableDictionary.BASE_CHARS[]" 2013-07-08 03:22:15 +00:00
Ken Wakasa
d0ca62678d Update ExpandableDictionary.BASE_CHARS[]
This should be the same as CharUtils::BASE_CHARS[] in the native code.

Change-Id: I72ed4a43fd5c26a4439ef791b6b1cf703845c3a1
2013-07-05 20:29:21 +09:00
Tadashi G. Takaoka
ccf4a31027 Move TypefaceUtils and ViewUtils to utils package
Change-Id: Iccd47c27670248c43de9a539c1951111d7733111
2013-07-05 19:24:59 +09:00
Tadashi G. Takaoka
4be6198cb7 Reorganize Utils class
Change-Id: I7294d1547def5dcfcae9d1d53b277cb3cc9f2d18
2013-07-05 19:24:40 +09:00
Tadashi G. Takaoka
72c2feb573 Use TimeUnit instead of DateUtils for readability
Bug: 9550800
Change-Id: I087205530a5dbcff4bf08f48f4aa7068aae93215
2013-07-05 17:57:01 +09:00
Jean Chalard
cb13d11c0a Add a trace.
Emit a trace when a new dictionary is copied to LatinIME
successfully, not just when it fails. That will help diagnosing
some problems by being able to ensure this step succeeded
looking at the log.
This does not happen often (like, maybe 3 times at device
activation, and once every few weeks afterwards), so I think
the extra line in the log is more than acceptable.

Change-Id: I1674bc22d950a7be801076c5aa7e8bbebccab14b
2013-07-05 12:44:47 +09:00
Keisuke Kuroynagi
49910a9d77 Merge "Fix: release lock in UserHistoryDictionary." 2013-07-04 15:13:09 +00:00
Keisuke Kuroynagi
65db026265 Fix: release lock in UserHistoryDictionary.
Change-Id: I050c252910c6b5b0a79cd2d52c525679f2d6091d
2013-07-04 23:12:49 +09:00
Keisuke Kuroynagi
f8d2796724 Add methods for dynamic updating binary dictionary.
Bug: 6669677
Change-Id: I7e681ceec2af712214a647630350cb20be6b0354
2013-07-04 21:17:49 +09:00
Keisuke Kuroynagi
edd1992ed3 DictionaryWriter to abstract binary dictionary writing.
UserHistoryDictionary should become to use ExpandableBinaryDictionary.

Bug: 6669677

Change-Id: I6831c7dd2d84207d1a8f51ba15d52e0a72205d0c
2013-07-04 21:06:04 +09:00
Keisuke Kuroynagi
0b1c08bf5a Use ReentrantReadWriteLock in ExpandableBinaryDictionary.
Bug: 6669677

Change-Id: I2acde0517d5ed5cbd7b7149709e35fc36651335d
2013-07-03 19:46:08 +09:00
Tadashi G. Takaoka
f87e8f7ec1 Handling key repeat by emulating key press and code input
This change also eliminates a reference of
AudioAndHapticFeedbackManager from KeyboardSwitcher and MainKeyboard.

Bug: 6522943
Change-Id: Iac42ec8ff00c66deb76a660ffc07477923a58959
2013-07-02 19:50:34 +09:00
Jean Chalard
e5a3b77664 Merge "Move Range out of RichInputConnection and rename it." 2013-07-01 07:20:51 +00:00
Keisuke Kuroynagi
109ba3ace3 Merge "Regenerate old version dictionaries using new format." 2013-07-01 07:16:15 +00:00
Jean Chalard
675bcf191c Move Range out of RichInputConnection and rename it.
Range has grown a bit too big to stay an internal class.

Change-Id: Ic3fbc48a5d10776eedd7559c4d696e5926b88288
2013-07-01 15:41:13 +09:00
Keisuke Kuroynagi
a62b5b22ef Regenerate old version dictionaries using new format.
Bug: 9617181
Change-Id: I228a3eac959f81b38e4092015e8e3c429d46fa60
2013-07-01 15:25:33 +09:00
Jean Chalard
f0af452ce2 Do not re-resume suggestion if it's not needed.
This is much better interface-wise. It eliminates all blinking
of the line in the practice.

Bug: 8874148
Bug: 8864306
Change-Id: I87754e44784327c2e9c8b162d598d145e20668e8
2013-07-01 14:40:12 +09:00
Jean Chalard
a5e28acf63 Merge "Fix a bug where AOSP Latin IME would not fill dictionaries" 2013-06-28 13:21:31 +00:00
Jean Chalard
555c4236db Fix a bug where AOSP Latin IME would not fill dictionaries
There is no reason not to contact the dictionary provider
when we don't have internet permission or when the URL
is empty. It knows how to handle both these cases.

Bug: 9388602
Change-Id: I30c4540551ad2f5e527d3acd1842bbd749feca89
2013-06-28 12:48:41 +09:00
Jean Chalard
e04794cbbe Fix some warnings
Mostly remove unused imports

Change-Id: If8ceffdfad79b78194094527759f5c334746973e
2013-06-27 21:36:52 +09:00
Satoshi Kataoka
4ded1af210 Improve the language list in the personal dictionary
Bug: 9117704
Change-Id: I26e6f8369a3c7ffa4bb651b4b5a3e6f004121983
2013-06-27 20:31:02 +09:00
Satoshi Kataoka
ec69a259c6 Merge "Open an API in ExternalDictionaryGetterForDebug" 2013-06-27 10:32:05 +00:00
Satoshi Kataoka
a2bfd46adf Use internal personal dictionary settings on JBMR2 or before
Bug: 9117704
Change-Id: I7e20b03daa23b59211235183cf48d933e32845e4
2013-06-27 19:20:05 +09:00
Satoshi Kataoka
bd84a00fc1 Open an API in ExternalDictionaryGetterForDebug
and extend it

Change-Id: Id2ba8dd8928a6327d3b31eb35f7cc314e2d31050
2013-06-27 18:41:07 +09:00
Jean Chalard
2bbd78ab0a Merge "Ignore spans that are not the right size." 2013-06-27 03:06:47 +00:00
Jean Chalard
2f7f6257b6 Ignore spans that are not the right size.
Bug: 8839763
Bug: 8862327
Change-Id: I5d49c86edcbc0fc1b2b147856437cfbadd678377
2013-06-26 23:02:50 +09:00
Jean Chalard
6c0e412137 Merge "Resume suggestion at start input" 2013-06-26 10:18:32 +00:00
Jean Chalard
a690f3bc40 Merge "Readability improvement" 2013-06-26 07:37:15 +00:00
Jean Chalard
173f74bb18 Merge "Fixing follow-up to I548d899b" 2013-06-26 07:36:44 +00:00
Jean Chalard
fb72890ac6 Readability improvement
Change-Id: I2f350145f333ba1fa4eb20027b0f41107c2df02c
2013-06-26 16:03:40 +09:00
Jean Chalard
7fcf304c97 Fixing follow-up to I548d899b
I548d899b introduced a new method to fix a sync miss between
the cursor position and the cached cursor position, but did not
take into account that it should also update the cached text
before and after the cursor in this case and that there was
already a method for doing this.

Change-Id: I31bd741893207c822827304e77791b1159774e1a
2013-06-26 15:28:42 +09:00
Keisuke Kuroynagi
5bf1be7162 Add jni methods for dynamically handling a dictionary.
Bug: 6669677
Change-Id: I8a26623adbb41a78e3c023c652be635c635e3b47
2013-06-26 12:51:33 +09:00
Jean Chalard
2f69348d51 Resume suggestion at start input
Bug: 9568410
Change-Id: I65468268f8613c863fa7f3a497b64656da0a221c
2013-06-25 19:38:31 +09:00
Ken Wakasa
fd0945b0da Merge "Make UserLogRingCharBuffer an external class" 2013-06-25 09:40:31 +00:00
Ken Wakasa
9419e02fd9 Make UserLogRingCharBuffer an external class
Change-Id: I9d506995337d64ec11c72939a8d739423ee46efa
2013-06-25 18:38:13 +09:00
Jean Chalard
333362adfc Merge "Fix the one-suggestion case." 2013-06-25 09:10:09 +00:00
Jean Chalard
d7d5ff1f99 Fix the one-suggestion case.
When there is only one suggestion, this code does
not work. The reason for that is, it's not homogeneous
at all and takes indices of one thing into another.

Not completely related to b/8839763, but realized
working on this and needed to have it addressed.

Bug: 8839763
Change-Id: I422730cc7eebb69ff421a171025af0390ebcdf92
2013-06-25 18:00:30 +09:00
Keisuke Kuroynagi
38b542629a Merge "Add a parameter isUpdatable to the constructor of BinaryDictionary." 2013-06-25 08:44:48 +00:00
Keisuke Kuroynagi
981717da4c Add a parameter isUpdatable to the constructor of BinaryDictionary.
Bug: 6669677
Change-Id: I6bc25131afd97112e3bbde036a81ab559a9a6460
2013-06-25 17:39:06 +09:00
Ken Wakasa
12ef7d3702 Merge "Cleanup under the utils package" 2013-06-25 08:20:57 +00:00
Ken Wakasa
03118a2760 Cleanup under the utils package
Change-Id: If2f7bd1346cc5085bf57645830f0faac44d017e4
2013-06-25 17:09:12 +09:00
Keisuke Kuroynagi
8bc0b51369 Merge "Allow mmapping dictionary file in writable mode in openNative." 2013-06-25 07:09:37 +00:00
Keisuke Kuroynagi
f3b62900c7 Allow mmapping dictionary file in writable mode in openNative.
Bug: 6669677
Change-Id: I447668932de118b158fa029ddc977b3f3cc06cb8
2013-06-25 16:03:33 +09:00
Jean Chalard
10585620bd Merge "Fix a bug in the cached cursor pos, and simplify selection handling" 2013-06-25 05:00:11 +00:00
Jean Chalard
cdf774122d Merge "Fix a small bug" 2013-06-24 10:00:05 +00:00
Ken Wakasa
bfaf349c35 Load the native lib eagerly
in the hope of avoiding UnsatisfiedLinkError. This is definitely not a
confident fix as we still don't know the root cause of the issue.

bug: 9325110
Change-Id: I1abf8031b98509f63fce6a2d069d497895ea712c
2013-06-24 18:12:04 +09:00
Ken Wakasa
bc1813186d Merge "Move util classes to the latin/utils directory" 2013-06-24 08:49:06 +00:00
Jean Chalard
ca52e1ca5a Fix a small bug
SpannableStrings are not the only type of Spanned, they are
only the mutable kind. SpannedString is the immutable one.
Spanned is the correct class to use there.

Bug: 8839763
Bug: 8862327
Change-Id: Ic5e6199a51f22368914f2748ac2d0d1ca6a33f78
2013-06-24 17:39:17 +09:00
Ken Wakasa
e28eba5074 Move util classes to the latin/utils directory
Change-Id: I1c5b27c8edf231680edb8d96f63b9d04cfc6a6fa
2013-06-24 17:04:40 +09:00
Jean Chalard
e8c4b99e56 Refactor text range to be able to get spans larger than the word
This changes how the Range class stores its data, but not its
functionality. It also improves encapsulation a bit.

Bug: 8839763
Bug: 8862327
Change-Id: I5bd583b3fc96a99b93a2632882d8fd587c03ab76
2013-06-24 12:31:14 +09:00
Jean Chalard
b7a2fd16a1 Merge "Defer disk-intensive tasks until after the keyboard is shown" 2013-06-21 10:57:33 +00:00
Jean Chalard
673c727b7a Defer disk-intensive tasks until after the keyboard is shown
Bug: 8689779
Change-Id: Ia78d3540f44ec0028c3246a8e0163e9ecf061ecf
2013-06-21 19:41:45 +09:00
Jean Chalard
e5dee0af4a Fix a bug in the cached cursor pos, and simplify selection handling
The documentation for setComposingRegion states explicitly
that it does not move the cursor. This is just a bug.
This does not have any ill effects right now, but it will have
in later changes if not fixed.

As for the selection handling, the specific test that this code
removes used to serve a purpose, but it does not any more because
the code using the value has been much sanitized. Now the variable
can just take the obvious value, and become so self-explanatory
that the comments are unnecessary.

Change-Id: I548d899b38776bd3ab5f5361aab0d89d98f12e73
2013-06-21 18:15:07 +09:00
Tadashi G. Takaoka
9b570b5e62 Fix punctuations strip
Bug: 9508186
Change-Id: I8f0fbf4e0578cf9116d4c57e7e5747d38c89387e
2013-06-21 13:22:37 +09:00
Jean Chalard
93f74bafbb Merge "Add tests to dicttool test." 2013-06-20 08:34:38 +00:00
Jean Chalard
23d4eb55ba Add tests to dicttool test.
Bug: 8526576
Change-Id: Idd6f9cd076d5915361c68f5c29afbba67dd54eba
2013-06-20 17:29:37 +09:00
Tadashi G. Takaoka
c90181d6aa Use system default key press volume
Bug: 9475973
Change-Id: I6ae825b161dde69e19b52d73fb9aa782e2aa7423
2013-06-18 21:34:30 +09:00
Tadashi G. Takaoka
af69a14c96 Use system default vibration pattern
Bug: 9468462
Change-Id: Ifa46a56873c10888da8eaa2782fe07ef138a141b
2013-06-18 21:33:51 +09:00
Tadashi G. Takaoka
3be8263035 Get value text from ValueProxy
As a preparation to show "system default" in the settings. LatinIME
can't know the actual system default value.

Bug: 9468462
Change-Id: I0b7898d1ca29ded7a619dd636d2ad16eb0db292e
2013-06-18 18:27:17 +09:00
Jean Chalard
2a81943d16 Fix a bug with recapitalization
This is a shameful bug :/

Bug: 9410367
Change-Id: I54ddbcd0323fa2c11fbd2aa8a1b3d2e07f6e83c8
2013-06-17 20:39:06 +09:00
Kurt Partridge
14718ab898 Merge "Log score, kind, and sourceDict for manual suggestion and gesture" 2013-06-14 17:03:03 +00:00
Jean Chalard
6233ee3633 Fix a bug with long user dict entries
Bug: 9410958
Change-Id: I966e452c6dbdcb444abbb6ffb316849a7c85a73b
2013-06-14 12:40:35 +09:00
Kurt Partridge
fc98325c61 Log score, kind, and sourceDict for manual suggestion and gesture
b/9422713

Change-Id: I4880fad6a5b10d09ca11b63311f14862bee724e5
2013-06-13 11:03:49 -07:00
Jean Chalard
27d9c6f795 Merge "Cache subtype lists reasonably." 2013-06-13 01:49:41 +00:00
Kurt Partridge
e72d1a07b6 Merge "Allow downloadable dictionaries in development builds" 2013-06-12 21:22:34 +00:00
Jean Chalard
ff6445ed0e Cache subtype lists reasonably.
This will spare a lot of IPC for Latin IME at the cost of very little
retained memory.
This improves the loading by potentially a lot - between 15 and 30%
when the layout is cached (which should now be the case almost every
time), and half that if it's not. More importantly, it makes the
load time less sensitive to high device load, which is one of the
sore points.

Bug: 8689779
Change-Id: I2e07736f1a92c38eed0e203bc690761a181da8b9
2013-06-12 18:04:52 +09:00
Kurt Partridge
2a1a463e2e Adjust settings for development-only versions
Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
2013-06-12 02:01:45 -07:00
Satoshi Kataoka
fe95e7b1bf Merge "Fix possible NPE" 2013-06-07 11:09:52 +00:00
Tadashi G. Takaoka
77f63c8ac6 Don't use RichInputMethodManager in setup wizard
In setup wizard, InputMethodManager may not be able to be aware that
this IME is installed, especially just after the IME is installed via
GooglePlay app and hit the open button on the app to launch the setup
wizard.

Bug: 9299618
Change-Id: I00c8544178b41074253d49ae9481996ec56593d2
2013-06-07 19:09:44 +09:00
Satoshi Kataoka
6c8136d157 Fix possible NPE
Bug: 9314901
Change-Id: Id80f59df38ae72766b097fd1c23326fedd302439
2013-06-07 19:08:58 +09:00
Tadashi G. Takaoka
254b484e75 Defer getting no language subtype
Bug: 9318351
Change-Id: I55338c001070655a3f90df3dbe1351bd4180d520
2013-06-07 18:20:31 +09:00
Jean Chalard
6910032972 Merge "Use an iterator to remove stuff from an ArrayList." 2013-06-06 08:19:41 +00:00
Jean Chalard
0dc422e0c7 Use an iterator to remove stuff from an ArrayList.
Silly me >.>

Bug: 9306154
Change-Id: Ic00e9d6a31cd1d7aacefe68b7be9c2199e297b0d
2013-06-06 17:03:16 +09:00
Kurt Partridge
efd26bb319 Allow downloadable dictionaries in development builds
Bug: 9305379

Change-Id: Iab32753070a056d3861a45aa898911b7ab67dfb6
2013-06-05 22:14:54 -07:00
Satoshi Kataoka
f6a1a76524 Merge "Fix a possible NPE" 2013-06-06 05:02:46 +00:00
Satoshi Kataoka
6f9c6f2c64 Fix a possible NPE
Bug: 9301208
Change-Id: Id120c99ab9ef698d16cf7b8beea30c98c95d23a1
2013-06-06 12:01:22 +09:00
Tadashi G. Takaoka
cbd219a761 Move Base64Reader to utils package
Change-Id: Id46898c5cae268f05850d79938929b7707f27320
2013-06-05 19:39:36 +09:00
Tadashi G. Takaoka
9d4e251826 Merge "Add CsvUtils that conform to RFC 4180" 2013-06-05 06:28:06 +00:00
Tadashi G. Takaoka
3ceeb6bcc6 Add CsvUtils that conform to RFC 4180
Bug: 9070153
Change-Id: I66e55dd2f30fddfeb849edb97bc1cbda6b126d92
2013-06-05 12:26:22 +09:00
Tadashi G. Takaoka
0bfc2bc419 Merge "Add CODE_CAPSLOCK for long press shift key" 2013-06-05 02:19:02 +00:00
Tadashi G. Takaoka
9552badf3c Add CODE_CAPSLOCK for long press shift key
This change utilizes the no panel auto more key feature to implement
long press shift key for shift lock.

Change-Id: I3995d25dc35aea3c67b5aa29299815462eff9cad
2013-06-04 18:20:06 +09:00
Tadashi G. Takaoka
cbc7acb6f5 Merge "Expand suggestion strip when center suggestion is long" 2013-06-03 14:45:05 +00:00
Tadashi G. Takaoka
9ff7354d78 Clear previous suggestions when gesture typing starts
Bug: 8651076
Change-Id: Ic65ed3e3696409edea4e35080c11e4d1869a5a7e
2013-06-03 17:59:26 +09:00
Tadashi G. Takaoka
043273b00f Expand suggestion strip when center suggestion is long
Bug: 9059710
Change-Id: I7fa2658cc6442e86f69c991f1e99db6fb1ef909c
2013-06-03 16:12:59 +09:00
Tadashi G. Takaoka
72ac390ce6 Fix ArrayIndexOutOfBoundException
Change-Id: I243fc4965365680615eed834efe9ae0240e7f2a8
2013-06-03 15:35:49 +09:00
Kurt Partridge
743302888b Merge "Uncommit separator LogUnits" 2013-06-03 03:01:23 +00:00
Kurt Partridge
3d20946272 Merge "Uncommit LogUnits when reverting textInput" 2013-06-03 02:58:20 +00:00
Kurt Partridge
4efb5c3b65 Merge "Remove uncommit on reverting batch input" 2013-06-03 02:54:33 +00:00
Kurt Partridge
bdff287a0d Uncommit separator LogUnits
Now that separators have their own LogUnits, they must be uncommitted
from the LogBuffer when backspacing over them.

Bug: 9088919

Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
2013-06-02 19:15:57 -07:00
Kurt Partridge
720840851d Uncommit LogUnits when reverting textInput
Bug: 9088919

Change-Id: I17187aa0afc1c3e9d32269c65f66cfb3a08663cb
2013-06-01 23:42:35 -07:00
Kurt Partridge
4165ef031f Remove uncommit on reverting batch input
Currently when the user reverts a batch input, a LogUnit is uncommitted
from the LogBuffer.  It should not be, because the LogUnit containing the
batch input is never committed in the first place (it is only committed
to the LogBuffer when a key is pressed or a new batch input is entered).

Bug: 9088919

Change-Id: I323af453ce082437a663ccae977b21b775a964bc
2013-06-01 11:15:47 -07:00
Jean Chalard
f61999caba Merge "Make it easy to open several dictionaries from tests" 2013-05-31 11:21:37 +00:00
Tadashi G. Takaoka
a0c3e02d71 Refactor SuggestionStripLayoutHelper a bit
Bug: 9059710
Change-Id: Ief12029bad75d4dc78090ab97555aece01b873de
2013-05-31 18:14:47 +09:00
Jean Chalard
1562fc91f0 Make it easy to open several dictionaries from tests
Bug: 9127175
Change-Id: I3f1840ee73b364df26dfddb5acb10001e0f2cb61
2013-05-31 15:36:05 +09:00
Tadashi G. Takaoka
723391c945 Merge "Tidy up Utils class a bit" 2013-05-31 06:29:24 +00:00
Kurt Partridge
e6125db98d Merge "Catch a permission exception" 2013-05-31 00:30:14 +00:00
Kurt Partridge
d63f756013 Catch a permission exception
This change catches a SecurityException if the DictionaryProvider is
unavailable.

Change-Id: I4f2d87327c40765383d8847fd4e934b3cf799488
2013-05-30 13:40:40 -07:00
Tadashi G. Takaoka
cbb99c60be Tidy up Utils class a bit
Change-Id: Idc2feb84a902a6cbb7265d1efe06c34e7d63c2c7
2013-05-31 00:32:57 +09:00
Tadashi G. Takaoka
7097aa2d3d Merge "Cleanup unreadable variable names" 2013-05-30 13:09:27 +00:00
Tadashi G. Takaoka
d67db32b30 Merge "Separate SuggestionStripLayoutHelper for readablity" 2013-05-30 13:09:17 +00:00
Jean Chalard
1a50999ed9 Merge "Tell the text view we reset state on finish input" 2013-05-30 11:53:50 +00:00
Jean Chalard
e90d039e0c Fix two strict mode warnings.
Bug: 9052555
Change-Id: I86e90488679a78a9f6e901b640025619293765a0
2013-05-30 20:12:05 +09:00
Tadashi G. Takaoka
500a9752b1 Cleanup unreadable variable names
Change-Id: Ic97687c58e25e4b0c6833cc25d10854f5f513081
2013-05-30 19:49:51 +09:00
Tadashi G. Takaoka
653603b725 Separate SuggestionStripLayoutHelper for readablity
Change-Id: I82c749c6837c3af7ae290f4cd92f5426ca58b5c7
2013-05-30 19:49:20 +09:00
Jean Chalard
68d9cb62e2 Tell the text view we reset state on finish input
This should be done in onFinishInput rather than onFinishInputView
but for an unknown reason onFinishInput never comes.

Bug: 9113167
Change-Id: Iafb40846a3ed8fad78bfc160d17cd431f81fe891
2013-05-29 18:44:40 +09:00
Tadashi G. Takaoka
d99abf8cb1 Delete shared preference entry when user select default value
Change-Id: I3fbafd9024c26a99d87376f5d5e359e03988a30f
2013-05-28 20:44:25 +09:00
Tadashi G. Takaoka
39bd6ea0dc Merge "Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs" 2013-05-28 11:40:10 +00:00
Tadashi G. Takaoka
dbed20ad8d Rename StringUtils.parseCsvString to KeySpecParser.splitKeySpecs
Change-Id: I16e3f3ebc43772cfd96c824afeddfd225404b857
2013-05-28 20:23:37 +09:00
Tadashi G. Takaoka
d69e4191b7 Merge "Refactor suggestion strip layout methods a bit" 2013-05-28 11:11:05 +00:00
Tadashi G. Takaoka
389d308fff Refactor suggestion strip layout methods a bit
Bug: 9059710
Change-Id: I8dc698c1d61ca51b65b232e6c586472588a4accb
2013-05-28 20:03:37 +09:00
Tadashi G. Takaoka
4c2ac9ee5f Merge "Rename commaConcatinatedText to commaSplittableText" 2013-05-28 10:58:16 +00:00
Tadashi G. Takaoka
c47bc30db8 Rename commaConcatinatedText to commaSplittableText
This is a follow up of I5a32882a08.

Change-Id: I9f0cda2167811f6bba2af042fbde0a821b4cfecd
2013-05-28 19:17:15 +09:00
Tadashi G. Takaoka
68cf2cd931 Merge "Check all regexp patterns in ResourceUtils.getDeviceOverrideValue" 2013-05-28 10:13:43 +00:00
Keisuke Kuroyanagi
e168a3c2a5 Merge "Adding additional feature settings." 2013-05-28 10:11:29 +00:00
Tadashi G. Takaoka
4c75ea858a Check all regexp patterns in ResourceUtils.getDeviceOverrideValue
This change also fixes a regexp error of Galaxy S III.

Change-Id: I42a4780bbfd2b083f4e27e61ec513aa875907344
2013-05-28 19:05:40 +09:00
Satoshi Kataoka
07e56e76a7 Merge "Implement KIND_OOV_CORRECTION" 2013-05-28 07:27:53 +00:00
Keisuke Kuroyanagi
1b100610b3 Adding additional feature settings.
Change-Id: I9fec0c03b7da9ce0305b494193f4cfe3fca144f3
2013-05-28 00:27:48 -07:00
Tadashi G. Takaoka
1b46738796 Rename "csv" in StringUtils to "commaConcatenatedText"
Change-Id: I5a32882a088e4ff5bfe973a86465d6ff839113d9
2013-05-28 16:13:36 +09:00
Satoshi Kataoka
3d97b95b90 Implement KIND_OOV_CORRECTION
Bug: 9127749
Change-Id: I96db15a3138e6b522c4c6ad16cc7faad577d3772
2013-05-27 18:53:43 -07:00
Keisuke Kuroyanagi
28b6262b54 Merge "Passing options to native suggestion method." 2013-05-24 22:27:19 +00:00
Tadashi G. Takaoka
740d829092 Merge "Use localized toLowerString in AutoCorrection.isValidWord" 2013-05-24 20:00:38 +00:00
Tadashi G. Takaoka
94027c7201 Use Locale.ROOT for locale neutral operations
Bug: 9112465
Change-Id: I6cd63007287b5a1a57cfbabff35d53f66fc5620e
2013-05-24 12:07:30 -07:00
Tadashi G. Takaoka
618407ab7e Use localized toLowerString in AutoCorrection.isValidWord
Bug: 9112465
Change-Id: I63eb4115f393444560e80220d4c90f0f7101b934
2013-05-24 11:47:36 -07:00
Tadashi G. Takaoka
ebe0544fc8 Remove redundant method AutoCorrection.isInTheDictionary
Change-Id: I0737fb0b68f411f4db06014f2d94804935808922
2013-05-24 11:40:03 -07:00
Keisuke Kuroyanagi
50db5f0fff Passing options to native suggestion method.
Change-Id: I6da180cfa1b9e5aa39600e78e3bc41209a40f583
Signed-off-by: Keisuke Kuroyanagi <ksk@google.com>
2013-05-24 10:21:04 -07:00
Tadashi G. Takaoka
6f9105383a Remove unnecessary methods of KeyboardSwitcher
Change-Id: Idd3647bb1a1d40df8bb89eda715d45427a58d0cd
2013-05-22 10:49:53 -07:00
Tadashi G. Takaoka
db7d4da3e5 Clean up IntentCompatUtils a bit
Change-Id: I803aa6c2160bfa1ffe992b28e7eb6e8a320c9762
2013-05-21 15:13:23 -07:00
Jean Chalard
d96f63d2ed am e2bee5b1: am ede3db51: Merge "Fix a crash on a secondary user" into jb-mr2-dev
* commit 'e2bee5b134aaefc69a680be8ea65e2d7640b3ead':
  Fix a crash on a secondary user
2013-05-20 21:32:21 -07:00
Jean Chalard
ede3db51f0 Merge "Fix a crash on a secondary user" into jb-mr2-dev 2013-05-21 04:27:34 +00:00
Jean Chalard
05ea7c5d02 am 167ba345: am 89fe1f50: Add a method to work around apps broken by recorrection
* commit '167ba3459b0ce02b9add12ade9388bd2b1e6eb62':
  Add a method to work around apps broken by recorrection
2013-05-20 21:10:07 -07:00
Satoshi Kataoka
10e8b93977 Fix a crash on a secondary user
Bug: 9054063
Change-Id: I092ab6e0077578d0aca57d2e41dfbc00b46e1ba4
2013-05-21 12:27:16 +09:00
Jean Chalard
0013f97ddd am 5906b05b: am 7058b02a: Extract a new class for app-specific workarounds.
* commit '5906b05bb50c0a67bd4f03fcfae41db3daefe0bc':
  Extract a new class for app-specific workarounds.
2013-05-20 19:50:46 -07:00
Jean Chalard
89fe1f5088 Add a method to work around apps broken by recorrection
Bug: 8944307
Change-Id: I8986622554f30aaf4f595099c4ab5652b75c972c
2013-05-21 07:53:31 +09:00
Jean Chalard
7058b02a9c Extract a new class for app-specific workarounds.
Bug: 8944307
Change-Id: Iaff9dd03d3d856a6bdaa2b16c4e71e95cd2b6349
2013-05-21 07:53:28 +09:00
Kurt Partridge
500dea6ad4 Fix punctuation logging
Punctuation is currently put into the same LogUnit as the
following word.  This is counter-intuitive and makes
post-processing more complicated.

This change causes punctuation to be put into its own
LogUnit.

A tricky case is the phantom space.  A phantom space is
inserted right before other text, whose MotionEvents have
already been collected and inserted into mCurrentLogBuffer.
Phantom spaces are handled by creating their own LogUnit and
inserting it into the LogBuffer right before
mCurrentLogBuffer is shifted in.

Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
2013-05-17 09:47:40 -07:00
Kurt Partridge
17b63ba588 Merge "Remove unnecessary commit/uncommit" 2013-05-15 23:52:43 +00:00
Jean Chalard
b1e37e4a47 am f1dcf725: Merge "Don\'t process recorrection or resets when not shown"
* commit 'f1dcf725061b3e61e40540566a5385cf4934f424':
  Don't process recorrection or resets when not shown
2013-05-15 07:58:27 -07:00
Tadashi G. Takaoka
25f0c8089e am 96a9f357: Merge "Fix unintentional setup step advance in orientation change"
* commit '96a9f357c7e2a059687926cd7cd52ac5d06bc65e':
  Fix unintentional setup step advance in orientation change
2013-05-15 07:58:18 -07:00
Tadashi G. Takaoka
7fe675440e am 769427cf: Adjust aspect ratio of setup image
* commit '769427cff24944958f5f1f6179090a86444f3eab':
  Adjust aspect ratio of setup image
2013-05-15 07:57:38 -07:00
Jean Chalard
f1dcf72506 Merge "Don't process recorrection or resets when not shown" 2013-05-15 11:25:25 +00:00
Jean Chalard
c9aaba1253 Don't process recorrection or resets when not shown
Bug: 8954116
Change-Id: Ica27dbfc570643bb81e6cdf34cc7c796ea080d71
2013-05-15 20:20:20 +09:00
Tadashi G. Takaoka
9b4a883e09 Fix unintentional setup step advance in orientation change
Bug: 8159728
Change-Id: I53e7d7c8fb5cc231ea94474b091e550f77ae8dab
2013-05-15 19:50:35 +09:00
Tadashi G. Takaoka
769427cff2 Adjust aspect ratio of setup image
Bug: 8159728
Change-Id: I578014912fa63c4c9b4c2c89aeae7ffec836b06c
2013-05-15 14:48:27 +09:00
Kurt Partridge
993acbaaa2 Remove unnecessary commit/uncommit
When the user reverts a commit, this causes the committed
word to be changed. The user usually then goes back to edit
that word.  Going back to edit causes an uncommit, so that
the editing actions are added onto the LogUnit containing
the operations used to construct the word.

But currently, reverting also involves its own
commit/uncommit pair, with the caller performing the
uncommit, and the commit happening inside the revert
command.  This may have been necessary in the past, when
revert was called in different situations, but is
unnecessary now.  Furthermore, the guarding conditions are
currently such that the uncommit doesn't always undo the
effects of the commit, corrupting the log output.

Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
2013-05-14 12:20:27 -07:00
Tadashi G. Takaoka
8b56ad7814 Merge "Revise welcome screen video and still image" 2013-05-14 12:01:47 +00:00
Tadashi G. Takaoka
7348d9fb72 Revise welcome screen video and still image
Bug: 8159728
Change-Id: Ief8d7197879d24ccef529e975c23d6f11c7aa458
2013-05-14 20:56:09 +09:00
Ken Wakasa
d6d70e7325 Merge "Revert "Fix isSuggestionsStripVisible when keyboard hidden"" 2013-05-14 11:46:04 +00:00
Ken Wakasa
3efa36f6aa Revert "Fix isSuggestionsStripVisible when keyboard hidden"
This reverts commit cb0d1c4c58

Change-Id: Ie2c8e01c25bd051b6157e8f32ab84392a0c7252a
bug: 8954116
2013-05-14 11:44:22 +00:00
Tadashi G. Takaoka
41016acacf Back to previous keyboard layout by canceling sliding input
Bug: 8915171
Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
2013-05-14 20:28:03 +09:00
Jean Chalard
cb0d1c4c58 Fix isSuggestionsStripVisible when keyboard hidden
When the keyboard is hidden, the suggestion strip is
never visible.

Bug: 8954116
Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
2013-05-14 15:19:19 +09:00
Tadashi G. Takaoka
b121538e0c Tune maximum keypress duration to 100 milliseconds
Bug: 8556975
Change-Id: If7839c5764f7a269243a9570c0b7782b6f7ee73b
2013-05-13 20:04:59 +09:00
Tadashi G. Takaoka
b5f67e7faf Add device specific keypress vibration duration database
Bug: 8556975
Change-Id: I11260a64dc13c102bac7a9742dc66f2b05fd32de
2013-05-13 18:34:48 +09:00
Tadashi G. Takaoka
18184eacb1 Support regular expression for condition pattern
Bug: 8556975
Change-Id: Iffc53d6a40dd77860434c5f7f4f59af5cd1ba92b
2013-05-13 16:25:03 +09:00
Tadashi G. Takaoka
d69fa0a09a Support multiple condition for getDeviceOverrideValue
Bug: 8556975
Change-Id: I29d3a305b6ac3d8e3620c6d8592d85047d62bf48
2013-05-13 14:38:21 +09:00
Tadashi G. Takaoka
565ced4546 Merge "Refactor StringUtils.findPrefixedString to findValueOfKey" 2013-05-10 09:49:07 +00:00
Tadashi G. Takaoka
6d3d2ae064 Refactor StringUtils.findPrefixedString to findValueOfKey
Bug: 8556975
Change-Id: I275c99db8a0d10594a5a8c0c27ebc1a87495c307
2013-05-10 18:44:04 +09:00
Tadashi G. Takaoka
4705c0fa7c Fix screen flash when launching settings activity
Bug: 8336068
Change-Id: I90a0f259129a3f3319b158b060154cc43960c234
2013-05-10 15:36:24 +09:00
Tadashi G. Takaoka
2b5c9726f4 Introduce another activity to launch setup wizard
Bug: 8336068
Change-Id: I35b94dd87c5b01d3e927da8f918a5398dd565d33
2013-05-10 15:30:53 +09:00
Tadashi G. Takaoka
9ed322b40f Keep SetupActivity alive to check re-launching from launcher
Bug: 8336068
Change-Id: I183b8e3fd1b3898d5f8dbbb13a0c93c64341fc38
2013-05-10 15:15:53 +09:00
Satoshi Kataoka
b902109000 Fix usages of getEnabledInputMethodSubtypeList
Bug: 8450279
Change-Id: Ib8433442ae6ca6c28da2652bff687cdeaf7c196e
2013-05-09 17:07:19 +09:00
Jean Chalard
71d52474fd Merge "Optimizations and safeguards." 2013-05-08 10:11:49 +00:00
Jean Chalard
9f9cc03277 Optimizations and safeguards.
- Don't call finishComposingText when useless.
- Add safeguards against calling setComposingRegion when the
  data returned by the editor is inconsistent.
- Cancel pending recorrection messages when new messages arrive.

Bug: 8842941
Bug: 8845001
Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
2013-05-08 18:47:10 +09:00
Satoshi Kataoka
5648054667 Add account e-mail addresses to the user dictionary
Bug: 8683365
Change-Id: Id72540c515e61c3dd854892599645dd6d22b496d
2013-05-08 17:58:21 +09:00
Satoshi Kataoka
faa94a2d0a Merge "Add owner's info to the dictionary" 2013-05-08 08:31:45 +00:00
Satoshi Kataoka
fc6d4a5412 Add owner's info to the dictionary
Bug: 8683365
Change-Id: I1c30eac128b4172526423ebeeb45bc6cee7fb67b
2013-05-08 17:29:04 +09:00
Satoshi Kataoka
6435c80087 Merge "Fix an issue on the transition between the setup and the settings" 2013-05-08 08:23:49 +00:00
Tadashi G. Takaoka
331d256f21 Fix an issue on the transition between the setup and the settings
Bug: 8853220

Change-Id: I99b6c46d900e9391f77986d1ae6e3edeaeff01e5
2013-05-08 15:18:45 +09:00
Satoshi Kataoka
f59c4f6840 Fix labels in the personal dictionary settings
Bug: 8855738
Bug: 8853764
Change-Id: I03383bb5d6d72645f511cc6175dec747eb13a840
2013-05-08 14:58:43 +09:00
Satoshi Kataoka
244a24e368 Consolidate dummy proximity info to the spell checker info
Bug: 8783170

Change-Id: I067486e5ec1ae7cdef8e2121392464ba71ee8add
2013-05-08 11:49:12 +09:00
Jean Chalard
2afe88b8d7 Merge "Unify space-adding on gestures." 2013-05-07 11:51:01 +00:00
Jean Chalard
e8b9b35471 Unify space-adding on gestures.
This is much simpler, and more correct.

Bug: 8808497
Change-Id: I7a56bf9d6d9fb481f898b7a9f5898a86c11b34c0
2013-05-07 20:38:09 +09:00
Satoshi Kataoka
a9dd74cf3f refactor spell checker
Change-Id: Ie7bea23f2ac54f03572e77c31ba7cb3d5e8f8d2f
2013-05-07 20:21:11 +09:00
Tadashi G. Takaoka
a5be033d4a Preserve setup wizard step while orientation change
Bug: 8159728
Change-Id: I596f59749443b8878b5613285f0fe793d449cdbd
2013-05-02 18:42:10 +09:00
Jean Chalard
83757d439e Merge "Pass blockOffensiveWords as a parameter" 2013-05-01 11:57:36 +00:00
Jean Chalard
2dbb5957e3 Pass blockOffensiveWords as a parameter
Bug: 8773353
Change-Id: Ic1019742ce7ff6e4f7fff4d2729f8ab52d841488
2013-05-01 20:47:35 +09:00
Ken Wakasa
1490b53416 Cleanup -- follow up to Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
Change-Id: Icb89c5119a67edaa019d5f7645b734cfcfc29041
2013-05-01 20:19:05 +09:00
Satoshi Kataoka
1641a4a457 Merge "Fix Google spell checker tests" 2013-05-01 09:31:52 +00:00
Satoshi Kataoka
d5781eef62 Fix Google spell checker tests
Bug: 8613307

Change-Id: Ief04a4abb6dc1f79660a2e419c9c5e271802b5a1
2013-05-01 18:21:56 +09:00
Tadashi G. Takaoka
6f7905ae75 Introduce MoreSuggestionsListener class
Bug: 8694255
Change-Id: I9420a7cb1983c6211f58d13b3b11db4347c3f99b
2013-05-01 18:03:37 +09:00
Tadashi G. Takaoka
47a66b12ec Override View.drawableStateChanged to detect state_pressed
Unlike on JB, View.setPressed(boolean) is never called when the view
is pressed on ICS. To detect a pressed state of the view, we need to
override View.drawableStateChanged() and check the drawable state
contains state_pressed.

Bug: 8159728
Change-Id: I481051364d6f3d1370742723c3ce19d898ea5463
2013-05-01 14:02:18 +09:00
Tadashi G. Takaoka
7b2114a428 Display still image when device can't play welcome video
Note that the still image in this change is a placeholder and must be
replaced by final asset.

Bug: 8159728
Change-Id: I4f5a28e0af711edacbc87c2ee64508f34f67f0da
2013-05-01 12:24:36 +09:00
Jean Chalard
019c38060d am ace3f3c5: am 25c90e6d: Merge "Don\'t do recorrection when suggestions are off." into jb-mr2-dev
* commit 'ace3f3c5d56f5b4a58e8dc400fec1bb8c7b17a63':
  Don't do recorrection when suggestions are off.
2013-04-30 19:22:13 -07:00
Jean Chalard
aa3a96f3a1 Don't do recorrection when suggestions are off.
Bug: 8767981
Change-Id: If5c775e488b91ae03ecce2673c99918ac8134928
2013-05-01 10:17:28 +09:00
Ken Wakasa
a0b62ece83 Merge "Cleanup an unused return value" 2013-04-30 11:16:28 +00:00
Tadashi G. Takaoka
ad46c9e0e0 Catch error while playing welcome video
Bug: 8159728
Change-Id: Ic8eea7993f12395d6eca6db8d5529803251a9fee
2013-04-30 18:18:32 +09:00
Ken Wakasa
0d6c87d113 Cleanup an unused return value
Change-Id: I974964aa3cc24b5480e57bd38c197fe7a49acaa4
2013-04-30 16:53:18 +09:00
Satoshi Kataoka
5aa14c2636 Fix the title of the fragment of the personal dictionary
This change is corresponding to I9b8bab21b144385bc2386e7fcb

Bug: 8600958
Change-Id: I0a0cf37d0a11c14a51dc63b2e4371facb34514d0
2013-04-30 15:01:51 +09:00
Jeff Sharkey
c5ebc792d6 Avoid leaking AssetFileDescriptor.
Change-Id: Iac388c8aefc684980cb4c7131fb47319f6073eb3
2013-04-29 12:26:44 -07:00
Tadashi G. Takaoka
be06bce18b Merge "Get rid of janky black box before the movie starts" 2013-04-26 09:38:54 +00:00
Tadashi G. Takaoka
732c93815a Get rid of janky black box before the movie starts
Bug: 8159728
Change-Id: I1d0a01a05b3b694d21fdfdc246d1329ab829908d
2013-04-26 18:26:12 +09:00
Jean Chalard
c03aaa1bde Merge "[ZF2] Read settings for profanity filtering." 2013-04-26 08:23:56 +00:00
Satoshi Kataoka
adbafa1a9b Merge "Support ICS on the user dictionary settings" 2013-04-26 06:50:42 +00:00
Satoshi Kataoka
dcef94165b Support ICS on the user dictionary settings
Bug: 8600958
Change-Id: I50e9228afc7b04147eb7c4734d3145abe8859a30
2013-04-26 15:48:08 +09:00
Tadashi G. Takaoka
82e476b188 Keep task stack when invoking settings from setup wizard
Bug: 8336068
Change-Id: If1df32595f72285b2dad16e28b4429b7b6059839
2013-04-26 13:03:37 +09:00
Jean Chalard
bb61293675 [ZF2] Read settings for profanity filtering.
Bug: 7226877
Change-Id: Ie0c713e1eba1529c0b288a1e5011023a79bedd6b
2013-04-25 20:29:14 +09:00
Jean Chalard
99e998286d [ZF1] Check profanity in Java rather than in native
Bug: 7226877
Change-Id: Ib6c32bfee9977c27dbf7e1e590b2b00d9ceb7301
2013-04-25 20:29:11 +09:00
Jean Chalard
43590149a5 Work around a bug in older DownloadManager versions.
This adds a number to the extension.

Note that for DownloadManager to keep this, the server
needs to send it a mime type it does not recognize. Right
now, it does not recognize application/json so it's okay,
but we'd do well to remove the content/type header from
the server to prevent problems.

Bug: 8467516
Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
2013-04-25 18:52:39 +09:00
Jean Chalard
a995bf4031 Put temp files within app files
Bug: 8715614
Change-Id: I307d83923070994525cf0d27aad403e881a89314
2013-04-25 18:14:40 +09:00
Satoshi Kataoka
30f0f3a92a Merge "Implement a functionality to add an entry to the user dictionary" 2013-04-25 06:04:08 +00:00
Satoshi Kataoka
a79ba8a3d6 Implement a functionality to add an entry to the user dictionary
Bug: 8600958

Change-Id: Ic472500406b9d54ec4052c490ee7cef62fc4e52a
2013-04-25 14:55:07 +09:00
Tadashi G. Takaoka
46913aedb4 Merge "Add next axction to setup wizard" 2013-04-24 10:30:56 +00:00
Tadashi G. Takaoka
b5d33059e0 Add next axction to setup wizard
Bug: 8159728
Change-Id: Ia37ab32b63e4eda29bf1411719d00846525c278f
2013-04-24 19:22:41 +09:00
Satoshi Kataoka
b35aa487fd Merge "Make aggressive threshold really aggressive" 2013-04-24 09:14:30 +00:00
Satoshi Kataoka
70f2762e28 Make aggressive threshold really aggressive
Bug: 8701480
Change-Id: If8242cfe61f3e56712fd6e25e36858cff7f0d177
2013-04-24 17:49:56 +09:00
Tadashi G. Takaoka
e918bf07a0 Refactor SetupStepGroup
Bug: 8159728
Change-Id: I1ab846d0910aacbd2f979289d72bafea8a8e0378
2013-04-24 14:15:59 +09:00