Jean Chalard
2549b4978e
Cleanup (A114)
...
Change-Id: I7e24e0aeae7c004cae310ae9f46cf90dac2d4d14
2012-07-12 15:09:57 +09:00
Jean Chalard
02f1c1534c
Cleanup (A113)
...
If not composing a word, then consideredWord is always the empty
string.
Hence, it's never whitelisted, but it's also always "NotAWord",
so isWhitelistedOrNotAWord returns always true, so
allowsToBeAutoCorrected is always true. Which means that
isPrediction implies allowsToBeAutoCorrected == true.
Thus, !isPrediction && !allowsToBeAutoCorrected is strictly
equivalent to !allowsToBeAutocorrected.
Change-Id: I4ad7a7c3447851c539646d97cf55ff065e6ee115
2012-07-12 15:09:48 +09:00
Jean Chalard
ae13061245
Simplification (A112)
...
If we are not composing a word, that isFirstCharCapitalized
and isAllUpperCase are guaranteed to return false.
Change-Id: Ic4a0be9574acf4653c729a9594f963f5bcf0c757
2012-07-12 14:30:33 +09:00
Jean Chalard
d8afa2fbe1
Remove the ultimate code duplication (A111)
...
Change-Id: I7c76613df8f148feb02765f187db3ca6dc577977
2012-07-12 14:30:33 +09:00
Jean Chalard
3b57631b60
Resolve a TODO: bury some implementation detail in native (A110)
...
The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.
Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1
2012-07-12 14:30:30 +09:00
Jean Chalard
18d76afa91
Remove an unused method (A109)
...
Change-Id: Ib785b7e8c554d030395e2c0ca92edb44eb2b245f
2012-07-12 14:30:03 +09:00
Jean Chalard
251f302985
Stop using a redundant method (A108)
...
Change-Id: Iffc0bae0a273419e7c50d69526c0c8e402c6461c
2012-07-12 14:30:00 +09:00
Jean Chalard
6a5d17cd2f
Remove a useless parameter (A106)
...
Change-Id: Ic0ecea22212fd1a098a3a168da460374e446f4a3
2012-07-12 11:28:16 +09:00
Jean Chalard
b7d7c5a369
Make a constant really constant (A104)
...
Change-Id: Ied1f9f96a574b1e6a8ee0a71bfb1604d9c962e1c
2012-07-12 11:16:30 +09:00
Ying Wang
8f7f04fead
Import translations. DO NOT MERGE
...
Change-Id: I056d8d8d630a2b3576462f7900bc39a7f19f5aa0
Auto-generated-cl: translation import
2012-07-11 15:33:02 -07:00
Jean Chalard
e4e7e5fc82
Cleanup (A103)
...
Change-Id: Ib5ebddfdb87ef71a2f8d859fb45d3ac78040e97a
2012-07-11 16:14:58 +09:00
Tadashi Takaoka
5e21ea1a35
Revert "Workaround to avoid a bug in the batch input bigram dictionary lookup"
...
This reverts commit 1250cdeab2
2012-07-11 00:07:08 -07:00
Tadashi G. Takaoka
1250cdeab2
Workaround to avoid a bug in the batch input bigram dictionary lookup
...
Change-Id: I8a5641c88c45918d6bed81a0b03efdcff0b380c5
2012-07-11 15:38:13 +09:00
Jean Chalard
9c09fd02eb
Inline a method to be able to factorize code (A102)
...
Change-Id: I121071f80c8af3c1053968dc76aaeca3352ca9a8
2012-07-11 14:57:51 +09:00
Jean Chalard
d6c610400e
Inline a wrapper method (A101)
...
Change-Id: I6ce856ff49a8f8c696851b2487590704010fc758
2012-07-11 14:57:51 +09:00
Tadashi G. Takaoka
eb1443883f
Support batch input
...
Change-Id: Ibe63212fe71cdebb5b897bc5018ae75b2a87555a
2012-07-11 14:53:20 +09:00
Jean Chalard
21e5759e8e
Merge "Small readability improvement (A100)"
2012-07-10 22:49:25 -07:00
Jean Chalard
27207eaa04
Merge "Pull up some common code again (A99)"
2012-07-10 22:49:06 -07:00
Jean Chalard
722b00275d
Merge "Pull up some identical code (A98)"
2012-07-10 22:48:58 -07:00
Jean Chalard
8b166465b0
Merge "Inline a method to avoid confusion (A97)"
2012-07-10 22:48:52 -07:00
Jean Chalard
fd9b485111
Merge "Remove parameters for easier inlining (A96)"
2012-07-10 22:48:44 -07:00
Jean Chalard
0b329fd0d1
Merge "Pull up some more common code (A95)"
2012-07-10 22:48:38 -07:00
Jean Chalard
a5acd68caa
Merge "Pull up common code in the caller (A94)"
2012-07-10 22:48:33 -07:00
Kurt Partridge
0d54692ce4
Merge "intentional logging"
2012-07-10 21:20:47 -07:00
Jean Chalard
82d5ed6fcd
Small readability improvement (A100)
...
Change-Id: I6340748654a95d203ed43ceb9a7e6468b5b8ab1c
2012-07-11 11:19:50 +09:00
Jean Chalard
860a9f85ff
Pull up some common code again (A99)
...
Change-Id: I9e9f5664bb12bb25d74c8a076a6ee1024c708145
2012-07-11 11:19:50 +09:00
Jean Chalard
8eaeb60e7f
Pull up some identical code (A98)
...
Change-Id: I6c265956394cf49e74b0256dfa5af06fe6b30467
2012-07-11 11:19:33 +09:00
Jean Chalard
e77f2996ea
Inline a method to avoid confusion (A97)
...
Change-Id: I3c3ffcd3d40493f4bfa0f6596f923b3430e605aa
2012-07-11 11:19:18 +09:00
Jean Chalard
cfae32c610
Remove parameters for easier inlining (A96)
...
Change-Id: Ied2e291393609300173681e26e82b7dd36b41bd0
2012-07-11 11:16:22 +09:00
Jean Chalard
ea98e026f1
Pull up some more common code (A95)
...
Change-Id: I3ac7ee823471a6d1da8031e064bce38b0e5a8f5c
2012-07-11 11:15:18 +09:00
Jean Chalard
b4b93dbf3e
Pull up common code in the caller (A94)
...
Change-Id: I84b97886280eca75d5f2b7546f20f8b1bced55bc
2012-07-11 11:13:56 +09:00
Kurt Partridge
223d671ffc
intentional logging
...
- separate ResearchLog from ResearchLogger
- fix abort menu to explicitly indicate re-enabling of logging
- auto flush entries every 5s
- conform to new suggestedWords class
multi-project change with I9fe1f8fe59d5891daa4ca84af157f36fb1bb17dc
Bug: 6188932
Change-Id: I7e99390f934481c6ed9cea2b259944583edda5bb
2012-07-10 18:44:18 -07:00
Ying Wang
60baf00b3a
Import translations. DO NOT MERGE
...
Change-Id: I0376c38451de66ff8c40b488ed3a8599326755ad
Auto-generated-cl: translation import
2012-07-10 14:20:17 -07:00
Jean Chalard
ff730dbd14
Merge "Remove useless member variables (A93)"
2012-07-10 04:33:32 -07:00
Tadashi G. Takaoka
20823b4623
Merge "Register the key when the finger slides off it in multitouch"
2012-07-10 04:19:40 -07:00
Jean Chalard
6f233f7ba1
Remove useless member variables (A93)
...
Change-Id: Iff0a0e8835f4d630b51a15c0d91881437094e785
2012-07-10 20:18:10 +09:00
Tadashi G. Takaoka
5e06b8534f
Register the key when the finger slides off it in multitouch
...
Moved from jb-dev branch (I807fd6f4).
Bug: 6722867
Change-Id: I9764ac72f726396caaac819675d440372c882981
2012-07-10 20:14:29 +09:00
Jean Chalard
2ae75ed56b
Start converging two identical methods (A92)
...
Change-Id: I3c85a80610fde664a328f5606d0724f00d445ebe
2012-07-10 20:13:54 +09:00
Tadashi G. Takaoka
d82dcdc924
Add batch input dictionary lookup
...
Change-Id: I4da3c976838e8eb56c9ec80aafaaf54d759b7981
2012-07-10 20:01:28 +09:00
Jean Chalard
5e573a1f0a
Remove a useless parameter (A91A)
...
Change-Id: I1d1758048649ef337875a5141d825569af7ad38c
2012-07-10 19:31:36 +09:00
Jean Chalard
f5943153ad
Cleanup old methods (A90)
...
Change-Id: I5435cef8ac6be523934ffa394952cb120c8e89d6
2012-07-10 19:30:46 +09:00
Jean Chalard
b30d2185f2
Implement the common Dictionary interface (A89)
...
This will de-duplicate a lot of existing code.
Change-Id: Idaffb2fde23b9741f057bcb2ecb3dde9d12ea5c5
2012-07-10 19:30:42 +09:00
Jean Chalard
a69f12a246
Reduce method visibility (A88)
...
Change-Id: I29d6afbcba0998558c9b19287a460d9f0e410994
2012-07-10 19:19:47 +09:00
Jean Chalard
0f57bdc0e5
Factorize code (A87)
...
Why was this copy-pasted :(
Change-Id: I6a537c56425ad039d7301a5fe1e0485784f07914
2012-07-10 19:19:43 +09:00
Jean Chalard
4e42e378fa
Move stuff around for readability (A86)
...
Change-Id: I5f4a18e43f3012acf96978d625325bf7c69c9c80
2012-07-10 18:57:57 +09:00
Jean Chalard
82009901ea
Add a consolidated method to the Dictionary interface (A85)
...
Change-Id: I5d79021e69cc738e3013e31764ab0a59e15decdf
2012-07-10 18:57:12 +09:00
Jean Chalard
2a37fb9d30
Refresh the cached single quotes count on commit
...
Change-Id: I9df5cf95c14da2e11ac709ca5e32dc7db3b02c37
2012-07-10 18:43:42 +09:00
Jean Chalard
a9632d8173
Merge "Enhance behavior consistency (A84)"
2012-07-10 02:31:40 -07:00
Jean Chalard
184c552917
Merge "Refactoring for whitelist (A83)"
2012-07-10 02:24:58 -07:00
Jean Chalard
b53e96813c
Merge "Refactoring (A82)"
2012-07-10 02:24:47 -07:00