Commit graph

12513 commits

Author SHA1 Message Date
Tom Ouyang
edcf5853d1 Merge "Start-of-sentence should include newlines and non-period terminators." 2015-03-17 22:25:00 +00:00
Tom Ouyang
5aeb092130 Start-of-sentence should include newlines and non-period terminators.
Bug: 19795382
Change-Id: Id6cc4a494a06de03d351aa6257632bd3b82e2ec4
2015-03-17 15:18:42 -07:00
Mohammadinamul Sheik
4024984c1e Pass DictionaryFacilitator for autocorrection and suggestion stats
Bug: 19715579
Change-Id: Ic48de74bde0f9f5d5e68e8289948cc5e92cbfa1e
2015-03-17 15:18:21 -07:00
Mohammadinamul Sheik
ea727b6b71 Carry over the mMaxPreWordCount when creating the new NgramContext
Change-Id: Iaba2e4b356486b60d550f10121695ef46e5e75da
2015-03-17 12:31:18 -07:00
Mohammadinamul Sheik
f468609223 Use BinaryDicitonary.MAX_PREV_WORD_COUNT_FOR_NGRAM for D2 dictioanries.
Fixes the UserHistoryDictionaryTests

Change-Id: I49776f53298ced3cd7e771cfe77a940b80b01f20
2015-03-17 11:43:16 -07:00
Dan Zivkovic
a10808d7d6 Merge "Remove rejected suggestion in LatinIME." 2015-03-17 18:14:36 +00:00
Mario Tanev
320cef5fe7 Merge "Bump up the current metadata database version to 14." 2015-03-17 01:45:14 +00:00
Dan Zivkovic
8844c35e7e Remove rejected suggestion in LatinIME.
Bug 19744396.

Change-Id: I64e59b3fb1ab627c70bf27a12a78d8d927da7e97
2015-03-16 18:26:37 -07:00
Tom Ouyang
263dd9fe03 Merge "Deprecate SuggestedWords.mSourceDict" 2015-03-17 01:25:21 +00:00
Mario Tanev
323d48d748 Bump up the current metadata database version to 14.
Change-Id: I49057f117666291c2e9e7ba3c3627f75ffc3cca5
2015-03-16 18:01:23 -07:00
Chieu Nguyen
56e7673917 Merge "Add cloud sync setting to SettingsValues." 2015-03-17 00:22:14 +00:00
Chieu Nguyen
93205b17ff Add cloud sync setting to SettingsValues.
Bug: 19573092
Change-Id: I41174188743c8a78facebff547e378a2b467a8c7
2015-03-16 17:11:52 -07:00
Dan Zivkovic
bff393ce13 Fix NPE in AccountSettingsFragment.
Bug 19773815.

Change-Id: Ib5eb27cdf385c81d1a3822836f424fa29c0bbaa8
2015-03-16 17:08:35 -07:00
Dan Zivkovic
52dafe8c32 Don't test format version 403 twice.
BinaryDictionaryTests runs all tests 3 times for 3 format verisons.
Cut that number down by 33% to speed things up.

Change-Id: I8a2f78017fa30f46b5873dcf6a5f478f57af2ebd
2015-03-16 14:38:44 -07:00
Dan Zivkovic
f508209f6a Remove unused imports.
Change-Id: Ic537cc7080a0ca98fc855a6f24a415d63f747891
2015-03-16 14:17:51 -07:00
Dan Zivkovic
4e1f0f1bb0 Redundant code matches multiple languages.
InputLogic should not have code that tweaks suggestion ranking based on the
language of the source dictionary.

Bug 19744396.

Change-Id: I8c0849555e74cec1302e78da04148dedd1cddabe
2015-03-16 14:11:59 -07:00
Dan Zivkovic
2321c41b5b Check boxes are replaced by switches in KitKat.
Make the code work for both widgets by using the TwoStatePreference interface.

Bug 19596067.

Change-Id: I8352361dcf74b54136b6177de9aac3eb2942a4c0
2015-03-16 12:03:04 -07:00
Dan Zivkovic
5455179b54 Revert "Next-word suggestion bit in keyboard settings."
This reverts commit 1ae16dc3db.

Bug 19596067.

Change-Id: Ie7286acbb70b215d7bd08e271bcf14526b68576f
2015-03-16 11:23:22 -07:00
Geoff Mendal
180a1e363f Merge "Import translations. DO NOT MERGE" 2015-03-16 13:05:07 +00:00
Geoff Mendal
1f7c2e61e2 Import translations. DO NOT MERGE
Change-Id: Ibc8572551a250720cc2bdaca75432e71f571eb02
Auto-generated-cl: translation import
2015-03-16 05:51:40 -07:00
Geoff Mendal
940b30695f Import translations. DO NOT MERGE
Change-Id: Ia4c53921b3a076533158579128023ab1ae56b28e
Auto-generated-cl: translation import
2015-03-16 05:49:05 -07:00
Mohammadinamul Sheik
900502f1ec Merge "Make RichInputMethodSubtype non-final for easy mocking" 2015-03-14 03:04:02 +00:00
Mohammadinamul Sheik
29500ef4ba Fix the BinaryDictionaryTests
Change-Id: I09378d74705e6943946ea4f76b15664086a387ed
2015-03-13 18:21:22 -07:00
Mohammadinamul Sheik
f04e2ed83a Make RichInputMethodSubtype non-final for easy mocking
Change-Id: I167bc56b5224eb389ec853aeb539d7fcf79b81e1
2015-03-13 17:05:11 -07:00
Mohammadinamul Sheik
93d2ab3857 Add StatsUtils.onSettingsActivity to collect the settings page stats.
Bug:19214944
Change-Id: I113f47c49d638790d770fe2781afe7cd1565619d
2015-03-13 16:12:14 -07:00
Tom Ouyang
89e2d93634 Deprecate SuggestedWords.mSourceDict
Change-Id: I29d9bec427660a7a501054fe9b1ea71be2d5ee3f
2015-03-13 14:30:18 -07:00
Chieu Nguyen
116e58c437 Remove autocorrection aggressiveness settings.
Replace multiple settings with binary switch for autocorrection.

Bug: 19589766
Change-Id: Ic8a0362dd36d18930493a55699851161e9cb23e8
2015-03-13 12:21:26 -07:00
Mohammadinamul Sheik
80f9034955 Log.i on dictionary download start
Change-Id: I8b501fb5512d4d3bbca75e4c4be7c7eb95f32020
2015-03-13 11:53:33 -07:00
Mario Tanev
b9a16b88bf Bump up the current metadata database version.
Change-Id: Id2814a2224b90ba124f1c9801760a2c86f2dc2e2
2015-03-13 10:39:05 -07:00
Dan Zivkovic
eaa710d4aa Separate executor for the Spelling decoder.
Bug 19710676.

Change-Id: I6e66eddd507c11e424105869833fe6841b90275d
2015-03-12 17:10:38 -07:00
Jatin Matani
44d4a1c524 Fix some i18n messaging
Bug:19538786
Bug:19542029
Change-Id: Ifc06064308f899527283378dda0c44223df7e9e9
2015-03-12 12:44:20 -07:00
Dan Zivkovic
26fb83c481 Avoid creating empty String[].
Minor cleanup on the way to fixing spelling for downloaded language.

Bug 19710676.

Change-Id: I7be25fa82248f0317d894d44802bede9dbc4fe2a
2015-03-12 10:49:29 -07:00
Dan Zivkovic
7e1dfaae3d Merge "Remove ALS from LatinIME." 2015-03-12 17:17:59 +00:00
Dan Zivkovic
107fb4c476 Remove ALS from LatinIME.
This fixes unit tests and brings us closer to a green build.

Change-Id: Iffcc392eda4a7671a238b79cc7367320ca648725
2015-03-11 17:29:12 -07:00
Chieu Nguyen
74c37f4089 Merge "Remove setting switch for phrase gesture." 2015-03-12 00:28:12 +00:00
Chieu Nguyen
4e0af43673 Remove unused phrase gesture code.
Bug: 19687841
Change-Id: I0862aa3127bf7f1564a4845efdf99ebf5ae4d5ac
2015-03-11 17:09:44 -07:00
Dan Zivkovic
9a289da4e6 Remove deprecated distractor filtering methods.
Change-Id: I10ccf75d9c00d66b4e85de6c3c019242f2e90b0e
2015-03-11 14:39:48 -07:00
Dan Zivkovic
7472cc8245 Mark method @UsedForTesting
This prevents it from being optimized away.

Change-Id: Iecd317568e23e86e4c0ece8134a4926a7a56d65b
2015-03-11 14:00:30 -07:00
Dan Zivkovic
820317f7aa Make inner classes visible for testing.
We need this to assert the correct behavior in the facilitator.

Bug 19695605.

Change-Id: I3923d00791c99208bc72f7c4210ae1ea0a34bd0e
2015-03-11 13:40:20 -07:00
Chieu Nguyen
e787b3b761 Remove setting switch for phrase gesture.
Bug: 19687841
Change-Id: I74ed9acfd5330d7461233d4146395aefb9d2d9c4
2015-03-11 12:06:22 -07:00
Dan Zivkovic
4621365b21 Merge "Delete user history files." 2015-03-11 18:53:23 +00:00
Dan Zivkovic
bdd6c995ce Delete user history files.
Bug 19669016.

Change-Id: I8069fe561347851bf3c27423dbd8ba99d38c049e
2015-03-11 11:46:15 -07:00
Geoff Mendal
74fa851030 Import translations. DO NOT MERGE
Change-Id: I58400f537f28e89f19faf95547d2f3ecb67368fa
Auto-generated-cl: translation import
2015-03-11 05:33:56 -07:00
Dan Zivkovic
77fd5dbf3e Remove dead code, including tests.
Change-Id: Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c
2015-03-10 17:22:41 -07:00
Dan Zivkovic
70c096d9a1 Restart background executor.
Bug 19671650.

Change-Id: I1a28a53e94bdb79aeb173f6905c1035022495acc
2015-03-10 10:03:17 -07:00
Chieu Nguyen
21a28abc6a Handle empty previous ngram context correctly.
Fixes bug where empty previous ngram context not at the
beginning of a sentence incorrectly returned the
beginning-of-sentence marker.

Bug: 19612336
Change-Id: I5ddf3408e20dcedf70487b85c983cd3fc12550e7
2015-03-09 19:02:43 -07:00
Dan Zivkovic
375035905d Kill+restart tasks before/after decoder init.
Bug 19625976.

Change-Id: I6d8b0d2b0a77ccda1bfc914501cf568b92862980
2015-03-09 18:54:48 -07:00
Dan Zivkovic
bd1bc4067f ExecutorUtils lets use schedule a runnable chain.
Bug 19625976.

Change-Id: Iebbef7fed57a381498301dcf26fefa27d06802f7
2015-03-09 14:58:16 -07:00
Dan Zivkovic
f9e2d271ca Use a single background executor.
Bug 19625976.

Change-Id: Ia03f440a31b059b5af42d162e1145330bf7b5ddf
2015-03-09 13:22:56 -07:00
Geoff Mendal
2151095bb2 Merge "Import translations. DO NOT MERGE" 2015-03-09 13:52:01 +00:00
Geoff Mendal
a2adee6510 Import translations. DO NOT MERGE
Change-Id: Ic46a661195724215df0687cf4395c599a1e84e31
Auto-generated-cl: translation import
2015-03-09 06:37:59 -07:00
Geoff Mendal
e617919b1b Import translations. DO NOT MERGE
Change-Id: I251a51c5a8adf9579dcfce60773634fab4f6b87a
Auto-generated-cl: translation import
2015-03-09 06:37:15 -07:00
Dan Zivkovic
491ca900a7 Merge "Handle null InputMethodSubtype." 2015-03-06 22:51:35 +00:00
Dan Zivkovic
2fcb7c5de5 Merge "Log from LatinIME." 2015-03-06 22:45:17 +00:00
Dan Zivkovic
edaa83bb32 Log from LatinIME.
When the DEBUG setting is on, log from this critical class.
This will make it easier to diagnose issues.

Bug 19632709.

Change-Id: I5e14b3705f50cd021ad3d64af106ad28dc8b9321
2015-03-06 14:42:57 -08:00
Dan Zivkovic
b86ca76cea Handle null InputMethodSubtype.
Bug 19627494.

Change-Id: I50dc77c59ced0f2e7c07a49ae0cb040197c2ab35
2015-03-06 14:34:57 -08:00
Chieu Nguyen
e3ac02e796 Merge "Sync setting disabled if no account." 2015-03-06 17:40:47 +00:00
Tom Ouyang
8eb2fad570 Merge "Restart suggestions when backspacing into a reverted word." 2015-03-06 02:29:35 +00:00
Chieu Nguyen
b717f91ffa Sync setting disabled if no account.
Bug: 19361223

Change-Id: Id5e8d34920f5bf3bffb6d6d287557e85d7b72c79
2015-03-05 18:25:56 -08:00
Chieu Nguyen
c4f6a8dcd4 Make privacy policy link clickable in sync settings.
Bug: 19361223
Change-Id: I83128d771bf5214a446afd6a3d5244a184d0a4a8
2015-03-05 17:48:02 -08:00
Tom Ouyang
222f647137 Restart suggestions when backspacing into a reverted word.
This is required for the final corrected word to be learned,
as learning only occurs when suggestions are active.

Note: This is already happening when backspacing into a non-reverted
word

Bug: 19619907
Bug: 18465402
Change-Id: I99a1d4f0ca0d62a2cdfa24cc0833ce89391715d9
2015-03-05 17:42:35 -08:00
Dan Zivkovic
38b9bffa3f Handle words longer tha 256 characters.
Bug 19612315.

Change-Id: I75e84df88b4da5cfc6a39b956613972841342c4b
2015-03-05 10:56:14 -08:00
Dan Zivkovic
1ae16dc3db Next-word suggestion bit in keyboard settings.
This feature works in supported languages.
We don't need a user setting.

Bug 19596067.

Change-Id: Icdded772745f9816da47f8a5e3b87b733083b121
2015-03-04 15:02:53 -08:00
Dan Zivkovic
83e95e6018 Remove SHORTCUT column in FROM clause.
The column is no longer used, and is not available on pre-Jellybean devices.

Bug 19595958.

Change-Id: Ief54c7210698d6668b1b7815900a394cc7f27299
2015-03-04 10:16:28 -08:00
Geoff Mendal
9de4a2e4e5 Merge "Import translations. DO NOT MERGE" 2015-03-04 14:00:30 +00:00
Geoff Mendal
00c5719414 Import translations. DO NOT MERGE
Change-Id: I934e85a5a7cef5a490e62033a37e4c8969c36d43
Auto-generated-cl: translation import
2015-03-04 05:55:42 -08:00
Geoff Mendal
d878a8101d Import translations. DO NOT MERGE
Change-Id: I3b6d9386687e987a6ca84a194a26b90a669c2562
Auto-generated-cl: translation import
2015-03-04 05:54:58 -08:00
Mohammadinamul Sheik
6e29d261cb Introduce DictionaryHeaderUtils to get dictionary header values
Change-Id: I86cef6c7f2f68a75428bb2b9c4d5a1dc1876b541
2015-03-03 16:17:27 -08:00
Chieu Nguyen
2281ba7666 Merge "Add DictionaryFacilitator dump()." 2015-03-03 23:16:49 +00:00
Chieu Nguyen
c809dc26a1 Add DictionaryFacilitator dump().
Change-Id: I8b75aded3fc2b9b33128b6ba5a3e8d943dfca352
2015-03-03 14:36:47 -08:00
Jatin Matani
148aab1228 Merge "Add util method in ngramcontext for context array" 2015-03-03 21:59:52 +00:00
Jatin Matani
a568e0acb4 Add util method in ngramcontext for context array
Change-Id: I2e3e2ac7706be50ed2055b0c69b30e25a516a879
2015-03-03 13:20:53 -08:00
Dan Zivkovic
63a0bdb41b Forgot to remove reference to deleted class.
Change-Id: Ic662a536e468390a3f7266daf9c56e4fc5a70ac6
2015-03-03 12:11:00 -08:00
Dan Zivkovic
15cccfcb0d Merge "Remove no-op broadcast receiver from LatinIME." 2015-03-03 19:55:25 +00:00
Dan Zivkovic
fbfc62209a Remove no-op broadcast receiver from LatinIME.
Bug 19583388.

Change-Id: Ia1ca481e2eae0c9791932f7f28a9072cc3dbbe7c
2015-03-03 11:03:11 -08:00
Geoff Mendal
e3abfc4e05 Merge "Import translations. DO NOT MERGE" 2015-03-03 08:45:00 +00:00
Chieu Nguyen
ddee491450 Merge "Move dictionary facilitator handling." 2015-03-02 23:30:42 +00:00
Chieu Nguyen
0103d75aaf Move dictionary facilitator handling.
Change-Id: Ibd42982996a36ac52b4c916035491b835f8d14f9
2015-03-02 15:24:51 -08:00
Jatin Matani
55d9651929 Merge "Turn off cloud sync if we have managed profiles" 2015-03-02 20:21:29 +00:00
Jatin Matani
854edce6dd Turn off cloud sync if we have managed profiles
UserManager#getUserProfiles > 1 implies managed
profile.

Workflow:
- Disable sync prefs
- Execute an async task to check for managed profile; if
  managed profile is found, remove the sync prefs. If not, enable
  the preference;
- Move the logging pref from Advanced to Account & Privacy.

Bug:19230544
Change-Id: I4dbd1fe8433b3263ccc74c35dc0ee0bb371122b3
2015-03-02 12:03:57 -08:00
Geoff Mendal
740f8d7224 Import translations. DO NOT MERGE
Change-Id: I95888bc0f4841f69b8c5cba881f92311c607347f
Auto-generated-cl: translation import
2015-03-02 10:03:04 -08:00
Jatin Matani
8b2908066d Fix build breakage due to changed resource Id
Change-Id: I09ba038930416d1261ef095ec503f1ac68cd92ea
2015-03-02 09:44:19 -08:00
Geoff Mendal
1312b216a8 Merge "Revert "Import translations. DO NOT MERGE"" 2015-03-02 15:30:38 +00:00
Geoff Mendal
dd09e82f64 Revert "Import translations. DO NOT MERGE"
This reverts commit 7989b88833.

Change-Id: Ie0fb3fef89938938da661c030808b1d8110816c9
2015-03-02 15:30:10 +00:00
Geoff Mendal
3d82160002 Merge "Import translations. DO NOT MERGE" 2015-03-02 15:10:59 +00:00
Geoff Mendal
7989b88833 Import translations. DO NOT MERGE
Change-Id: I891a5bfa2cfebb4852ba0a1277cf7ae1aec912ae
Auto-generated-cl: translation import
2015-03-02 06:42:15 -08:00
Geoff Mendal
a9de6f589f Import translations. DO NOT MERGE
Change-Id: I4cab7c63e46cfef30b344658d8af54e9e0247752
Auto-generated-cl: translation import
2015-03-02 06:41:33 -08:00
Dan Zivkovic
9770336a9b Merge "Label empty suggestions." 2015-02-27 21:33:02 +00:00
Chieu Nguyen
98886775cf Merge "Handle double space inserting a period." 2015-02-27 21:24:36 +00:00
Chieu Nguyen
fdf3cc41ee Handle double space inserting a period.
Change-Id: I109f0e9cf3e972bf60aa3fbbe817337aef70ea3c
2015-02-27 13:19:21 -08:00
Mohammadinamul Sheik
62cbaba715 Merge "Update the MAX supported file version for downloaded static Dictionaries." 2015-02-27 21:09:04 +00:00
Dan Zivkovic
24c275ccb9 Label empty suggestions.
When talkback is enabled, empty strings will have a content description.

Bug 19479836.

Change-Id: I25679a2bdeff238a5330ba406d5bc7e6e2868ba1
2015-02-27 12:44:28 -08:00
Mohammadinamul Sheik
377ba98b75 Update the MAX supported file version for downloaded static Dictionaries.
Change-Id: I72d37cc21585b18f4a41ff32627024502f10e993
2015-02-27 10:30:23 -08:00
Dan Zivkovic
69c04cadc7 Race condition in cursor move.
The method WordComposer.moveCursorByAndReturnIfInsideComposingWord() iterates
through all the code points in the word that's currently being composed, and
it tries to adjust the cursor position by a given amount (left or right).
It copies the code points to a new array while processing. But the code point
count comes from a member variable. If the member variable changes while the
method is processing the copy of the code points, it can run over the length
of the code point array.

Bug 18876474.

Change-Id: Ib3a2d90a4e82b76d381efa774e6b3d6bca99c869
2015-02-27 10:29:47 -08:00
Jatin Matani
c83352d527 Merge "Refresh pref settings for cloud sync" 2015-02-26 22:10:02 +00:00
Jatin Matani
8ec328fb2e Refresh pref settings for cloud sync
- Show the opt-in text
- Show the account picker if user presses 'enable sync'. Previously
  we disabled the sync pref which was confusing.
- Remove the debug tags from some prefs; and improve messaging overall

General rules;
- sync is turned ON : user checks 'enable sync' pref AND
  accepts the opt-in AND chooses an account
- sync is turned OFF: when user signs out

Demo link
https://drive.google.com/a/google.com/file/d/0B9tNQOWdRuiWSUdVVE5rVDJudlk/view?usp=sharing

Change-Id: I2e7933796b15e47005ba9970a8c1294416ef31a0
2015-02-26 11:43:42 -08:00
Dan Zivkovic
edd94a449e Ignore the Emoji key when not connected.
When the LatinIME does not have an active InputConnection, it will not try
to toggle the Emoji keyboard.

Bug 19513415.

Change-Id: I31f928cd7db1cddd771c548cd3dc42f8af64d0e2
2015-02-26 11:10:37 -08:00
Jatin Matani
48b071249c Merge "Share decoders among latinime components." 2015-02-26 17:54:26 +00:00
Dan Zivkovic
7d7f082075 Stop waking up to decay dynamic dictionaries.
Bug 19516048.

Change-Id: Ibc27a792b4fa80fa8c6af4721c47a617526e9584
2015-02-25 20:13:59 -08:00
Dan Zivkovic
e4619f029e Merge "Don't assume that correctable words are invalid" 2015-02-26 03:44:20 +00:00