Commit graph

4874 commits

Author SHA1 Message Date
Yohei Yukawa
5a3a7e3d8a Merge "Add a preference item for metrics logging" 2014-06-04 05:07:03 +00:00
Yohei Yukawa
28c7b262aa Add a preference item for metrics logging
BUG: 14324207
Change-Id: Idc8582655bc73cb24e416e8ba78470209b2ff702
2014-06-04 13:02:42 +09:00
Tadashi G. Takaoka
a32803cefe More concise Key.toString()
Change-Id: I0ef983f54e828193e9c7e4a10c888f72702d499c
2014-06-03 13:32:42 +09:00
Jean Chalard
d660f3bec9 Fix an IOOB exception
Bug: 14602663
Change-Id: Ie2060931df911b44230d5a5ba268f687cbdd0dc8
2014-06-02 18:21:50 +09:00
Keisuke Kuroyanagi
8f71fab2ed Make prevWord = null if the next word starts from a connector.
This fixes PunctuationTests#
testAutoCorrectionWithSingleQuotesAround.

Bug: 14119293
Bug: 15334309

Change-Id: I604c21a21e89a5fc431fd56ab7b6ad03f4736b01
2014-05-30 20:30:17 +09:00
Jean Chalard
fa0e76dde6 Limit recapitalization for reasonable performance.
At 100k text, it's reasonably fast (less than 1s on latest hardware).

Bug: 12913404
Change-Id: I426b918b2610af24364934a1c37a7314f1142ad0
2014-05-30 18:04:39 +09:00
Tadashi G. Takaoka
aaf2bbf9c3 Merge "Remove LatinImeLogger and UsabilityStudyLogUtils" 2014-05-29 09:33:25 +00:00
Tadashi G. Takaoka
51ee5a47b8 Remove LatinImeLogger and UsabilityStudyLogUtils
This CL must be checked in together with Ie52007dc5c.

Bug: 15318007
Change-Id: Ie665f296e43b5485ae8ba7e949aa262794ee0dcc
2014-05-29 18:03:03 +09:00
Keisuke Kuroyanagi
c4a3b9f0d6 Merge "Remove PrioritizedSerialExecutor." 2014-05-29 08:52:23 +00:00
Jean Chalard
944923f266 Fix: too many calls to getSuggestedWordsForTypingInput
This reverts commit d941ea18 and builds on it to fix the behavior
of the broken cases.
It also fixes a small, related bug that probably has existed for
a very long time: predictions not displayed when cancelling
double-space-to-period.

Bug: 15148015
Change-Id: I1f9358f8b6f5804f831643611576be347e83999d
2014-05-29 17:36:46 +09:00
Keisuke Kuroyanagi
94f88b4881 Remove PrioritizedSerialExecutor.
Bug: 15320560
Change-Id: Icb88a96ebd685da1d2cba7b07889a2751c603a2e
2014-05-29 17:36:32 +09:00
Tadashi G. Takaoka
262b1e7518 Merge "Remove researcher logger" 2014-05-29 07:30:16 +00:00
Tadashi G. Takaoka
bbf556e8e1 Remove researcher logger
This CL must be checked in together with I5cc76807e3.

Bug: 15318007
Change-Id: I61423c3377ddc299fb332e742d6626c2e47145bb
2014-05-29 15:10:28 +09:00
Keisuke Kuroyanagi
7d57fc248b Clean up for Iba6eeb7981634e7ddb.
Bug: 15298959
Change-Id: I6921db77b7d231ad3aad99d4c380ae2ed6bbf540
2014-05-29 13:16:24 +09:00
Keisuke Kuroyanagi
4bffac6db9 Stop directly checking SuggestedWordInfo.mKind
Bug: 15298959

Change-Id: Iba6eeb7981634e7ddb896404978b30f6efd6e72f
2014-05-28 20:35:45 +09:00
Tadashi G. Takaoka
14ea11fcde Add TODO comment about SuggestedWordInfo's kind and flags
This CL must be checked in together with I6fd87e1eec.

Change-Id: I4b24157f3e3ce6327579d37122a34d7a30069885
2014-05-28 11:51:05 +09:00
Keisuke Kuroyanagi
dfca51726e Return whether the dynamic dict operation was success.
Bug: 12184250
Change-Id: Iee7e00c1e84c95551a077f4dd023c0a9b9ac9466
2014-05-27 17:30:00 +09:00
Keisuke Kuroyanagi
26628eeb4b Merge "Add thread name for PrioritizedSerialExecutor." 2014-05-27 07:24:26 +00:00
Keisuke Kuroyanagi
6a546147eb Merge "Stop filtering out when perfect freq > top non-perfect freq." 2014-05-27 07:14:16 +00:00
Keisuke Kuroyanagi
00da83ed75 Stop filtering out when perfect freq > top non-perfect freq.
Bug: 13142176
Change-Id: I0290df918a5bd5018bf55231dc462d5e797155c6
2014-05-27 16:09:59 +09:00
Keisuke Kuroyanagi
733a9c09a9 Add thread name for PrioritizedSerialExecutor.
Bug: 15270123
Change-Id: I655ba97f0543476980d0e8461bc1c8a56c9f954b
2014-05-27 16:06:08 +09:00
Tadashi G. Takaoka
01748cde4e Move MoreSuggestionsListener to MoreSuggestionsView
Change-Id: I3b5bc630bf73a357ed0beeec0b555149ef248313
2014-05-27 14:49:25 +09:00
Keisuke Kuroyanagi
71c795d00b Merge "Apply distracter filter for UserHistoryDictionary." 2014-05-26 16:28:23 +00:00
Keisuke Kuroyanagi
17bd4eb0c9 Apply distracter filter for UserHistoryDictionary.
Bug: 13142176
Change-Id: I67d63a5c789d7c587bcd7abacd26b2e76da11978
2014-05-27 01:10:04 +09:00
Keisuke Kuroyanagi
f85b478cd8 Merge "Apply distracter filter for in-vocabulary words." 2014-05-26 14:25:17 +00:00
Keisuke Kuroyanagi
ba33831d76 Apply distracter filter for in-vocabulary words.
Bug: 13142176
Change-Id: I4db763783a2f8b9a0df0df951db3223f70748870
2014-05-26 23:11:24 +09:00
Keisuke Kuroyanagi
0088d1f668 Merge "Use whether it's exact match to detect distracters." 2014-05-26 13:53:19 +00:00
Keisuke Kuroyanagi
a6278eb9c1 Use whether it's exact match to detect distracters.
Bug: 13142176
Change-Id: Id5b7286d28897931f7bfe571be45d46ffeef4adf
2014-05-26 21:56:20 +09:00
Tadashi G. Takaoka
9df51d10fa Keep showing important notice when "show correction suggestions" is off
When
 1. The important notice message is shown on the suggestions strip.
 2. And the "Show correction suggestions" settings is off.
we will keep showing the important notice message on the suggestion
strip.

Bug: 13741460
Change-Id: I411007ab1e5e6959b6cdba7a6601a84635259313
2014-05-26 14:11:41 +09:00
Tadashi G. Takaoka
630a24141e Use ViewCompat support library and delete ViewCompatUtils
Change-Id: I57d60cacd86e83894294c3f64402aba8c1829872
2014-05-24 12:26:30 +09:00
Tadashi G. Takaoka
790934158d Revert "Use ViewCompat support library and delete ViewCompatUtils"
This reverts commit db21267b78.
The reverting change breaks build in unbundled jb-ub-latinimegoole branch.

Change-Id: Ia61424f5321eb97f981d22c4b08e9ea8d348f6c1
2014-05-23 18:31:43 +00:00
Tadashi G. Takaoka
db21267b78 Use ViewCompat support library and delete ViewCompatUtils
Change-Id: Ifee496ff7ecaf361898444ff4127f16748d96422
2014-05-24 02:13:52 +09:00
Tadashi G. Takaoka
7a76350b7b Merge "Enable "show language switch key" settings on K and before" 2014-05-23 16:43:37 +00:00
Tadashi G. Takaoka
a91561aa58 Use Java 7 diamond operator
Change-Id: If16ef50ae73147594615d0f49d6a22621eaf1aef
2014-05-24 01:05:42 +09:00
Tadashi G. Takaoka
7ed40a13cc Enable "show language switch key" settings on K and before
"Show language switch key" and "Switch to other IME" settings are
enabled on KitKat and before. On L and later, its preference settings
UI gets hide and the settings values are forcibly set to true.

Bug: 14854377
Change-Id: I10456408452280a1b7688fd1f168933937666c9f
2014-05-24 00:58:24 +09:00
Keisuke Kuroyanagi
9f9988e996 Merge "Introduce EMPTY_PREV_WORDS_INFO and BEGINNING_OF_SENTENCE." 2014-05-23 14:53:13 +00:00
Ken Wakasa
991c9026b9 Merge "Revert "Fix: too many calls to getSuggestedWordsForTypingInput"" 2014-05-23 14:34:36 +00:00
Ken Wakasa
d941ea1826 Revert "Fix: too many calls to getSuggestedWordsForTypingInput"
This reverts commit 7aa895e2e3.

Bug: 15148015
Change-Id: If39c4f8b897f247d4eb935923d55d81def4c8fb4
2014-05-23 14:34:06 +00:00
Keisuke Kuroyanagi
a790c5b683 Introduce EMPTY_PREV_WORDS_INFO and BEGINNING_OF_SENTENCE.
Bug: 14119293
Change-Id: I5020e5f0aa64bc3e97b3a3c2c07a60c8b765ed64
2014-05-23 23:19:33 +09:00
Keisuke Kuroyanagi
a37f374ad1 Version up dynamic dict format from 401 to 402.
Change-Id: Ibea36af905ade773ae3db3a5456f7b5a0ad7d220
2014-05-23 20:20:56 +09:00
Keisuke Kuroyanagi
1adca93381 Extend jni methods and enable Beginning-of-Sentence.
Bug: 14119293
Change-Id: I78fc877367dd0d6240eeacb750b6d2d0b93cba83
2014-05-23 19:58:58 +09:00
Keisuke Kuroyanagi
85befc0873 Merge "Make DistracterFilter interface." 2014-05-23 10:11:57 +00:00
Jean Chalard
cfdb1b8d26 Fix some auto-caps problems:
- (mainly for Spanish) auto-caps after inverted bang and what
- (German only) don't auto-cap after digits-period-space

Bug: 15177663
Bug: 12206753
Change-Id: Ia214bc067319469d9debbbfbdcb1dcff980847f0
2014-05-23 18:17:09 +09:00
Keisuke Kuroyanagi
f498e53933 Make DistracterFilter interface.
Bug: 13142176
Bug: 15094186
Change-Id: If94b0a155b5ea2ff6b839e7da9d12a9cc6553931
2014-05-23 18:12:37 +09:00
Keisuke Kuroyanagi
1fa3e9044f Move distracter filter to dictionary facilitator.
Bug: 13142176
Bug: 15094186
Change-Id: Ib9e42f8e25538009f3ba62cf1e034cae3f6823c7
2014-05-23 16:10:36 +09:00
Keisuke Kuroyanagi
a1035be6d8 Have DictionaryFacilitator in LatinIME.
Bug: 13142176
Bug: 15094186
Change-Id: I9da67352ff2abcd289fa5885389895ced878a413
2014-05-23 09:30:55 +09:00
Keisuke Kuroyanagi
a2ce9a49ac Fix NPE happening in unit tests.
Change-Id: I2fc0dba53e18883755ff77351c152a9d3534c92b
2014-05-22 21:57:07 +09:00
Yohei Yukawa
7c6f57d147 Merge "Add a new production flag for metrics logging" 2014-05-22 08:30:20 +00:00
Yohei Yukawa
17eeecdf49 Add a new production flag for metrics logging
BUG:14909963
Change-Id: I2d48c5b7d959d9bb95afe2cd3cbd16b27092a054
2014-05-22 16:57:52 +09:00
Jean Chalard
9b3d55fd1a Merge "Check the md5 checksum of the copied file." 2014-05-22 07:38:08 +00:00
Keisuke Kuroyanagi
9218c51129 Fix: NPE in DistracterFilter
Change-Id: I19a92d79cf547aae8f15e7e5fd5309812ae4f2d5
2014-05-22 16:33:45 +09:00
Jean Chalard
9087d19fc0 Check the md5 checksum of the copied file.
If it doesn't match, mark it broken. It means the dictionary pack
will try to install it again next time it updates. We may want to
rethink this.

Bug: 13125743
Change-Id: I0eb547aa7066bed8cb00c009debbafe9181c37ad
2014-05-22 14:19:46 +09:00
Keisuke Kuroyanagi
5e2c4c0297 Merge "Use enabled subtypes for Keyboard in DistracterFilter." 2014-05-22 04:50:47 +00:00
Jean Chalard
68f46d9c2f Merge "Don't upcase suggestions when resuming on an uppercase word" 2014-05-22 03:57:38 +00:00
Jean Chalard
814cf03470 Merge "Arrange to send the rawChecksum to LatinIME." 2014-05-22 03:18:52 +00:00
Jean Chalard
2df6374ffa Merge "Fix: too many calls to getSuggestedWordsForTypingInput" 2014-05-22 03:14:01 +00:00
Jean Chalard
7aa895e2e3 Fix: too many calls to getSuggestedWordsForTypingInput
Bug: 15148015
Change-Id: Idcb729734bd62b537fb81acf8bdb5cae4470404c
2014-05-22 12:08:12 +09:00
Jean Chalard
dfc38358fc Don't upcase suggestions when resuming on an uppercase word
Bug: 13917781
Change-Id: I7458d120898a7c8c0bc2db2f6db3578fd1dd1681
2014-05-22 11:37:08 +09:00
Jean Chalard
267e528253 Arrange to send the rawChecksum to LatinIME.
Bug: 13125743
Change-Id: I5d111336e6a0f5ab4e93ff333654a7a1f8f46480
2014-05-22 11:01:04 +09:00
Keisuke Kuroyanagi
17f326b745 Add beginning of sentence information in PrevWordsInfo.
Bug: 14119293
Bug: 14425059
Change-Id: I65320920e840082b0b697bb621676716d0933e0c
2014-05-21 15:40:08 +09:00
Keisuke Kuroyanagi
17ae0eb7e7 Use enabled subtypes for Keyboard in DistracterFilter.
Bug: 13142176
Bug: 15094186
Change-Id: I142eeaa11f838080a4fc5a342155e5d470eab3d4
2014-05-21 14:08:39 +09:00
Tadashi G. Takaoka
73788ea154 Merge "Refactor MoreKeysKeyboardView to use Key class" 2014-05-21 03:06:43 +00:00
Tadashi G. Takaoka
5fc1510bc1 Refactor MoreKeysKeyboardView to use Key class
This can make MoreSuggestionsView to use extended Key class to hold
a index of a suggested word.

Change-Id: I54d03d2447b04e3caf3e19e7cadcd391cbf58dd5
2014-05-21 11:19:01 +09:00
Keisuke Kuroyanagi
e507d92aa3 Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
Bug: 14119293
Bug: 14425059
Bug: 15102610
Change-Id: Ib482390f8d15b37d44a1a54e8c243a9eaec3f815
2014-05-21 11:15:38 +09:00
Ken Wakasa
06dd0ef877 Merge "Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."" 2014-05-20 14:01:34 +00:00
Ken Wakasa
4e21d3711f Revert "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry."
This reverts commit ff50b39176.

Bug: 14119293
Bug: 14425059
Bug: 15102610

Change-Id: If278b4ab236e38d20d8cdc0761b0438911bd4ff9
2014-05-20 14:01:06 +00:00
Keisuke Kuroyanagi
1afaf6770b Merge "Use PrevWordsInfo for get/add/remove n-gram(bigram) entry." 2014-05-20 05:36:10 +00:00
Keisuke Kuroyanagi
ff50b39176 Use PrevWordsInfo for get/add/remove n-gram(bigram) entry.
Bug: 14119293
Bug: 14425059

Change-Id: I12e9ba977c153b514c6591ab52940712fd0874e3
2014-05-20 13:37:04 +09:00
Tadashi G. Takaoka
9fb2797714 Fix number password field handling
Bug: 15088419
Change-Id: Ie88375c8c8203c318d9b410692c527443cb0a2d5
2014-05-20 10:26:26 +09:00
Keisuke Kuroyanagi
83c40a2301 Use PrevWordsInfo instead of String in Java side.
Bug: 14119293
Bug: 14425059

Change-Id: I3d5da84881a49a04550180dd9aac2c37da2ed762
2014-05-19 13:55:40 +09:00
Keisuke Kuroyanagi
23246ed18d Use dedicated DictionaryFacilitator for DistracterFilter
Bug: 15002249
Change-Id: Ic77eaa7d627d406daad7dcd15cb4884d9f647312
2014-05-17 01:18:08 +09:00
Keisuke Kuroyanagi
96013c9605 Merge "Revert "Use dedicated DictionaryFacilitator for DistracterFilter"" 2014-05-16 11:17:45 +00:00
Keisuke Kuroyanagi
f9377c8920 Revert "Use dedicated DictionaryFacilitator for DistracterFilter"
This reverts commit 7122fe76e3.

Change-Id: I341089864a2b58de6e0f35844a12fb632bd1eabb
2014-05-16 11:16:54 +00:00
Keisuke Kuroyanagi
0dac17f5fb Merge "Use dedicated DictionaryFacilitator for DistracterFilter" 2014-05-16 10:49:02 +00:00
Keisuke Kuroyanagi
7122fe76e3 Use dedicated DictionaryFacilitator for DistracterFilter
Bug: 15002249
Change-Id: I2ebf1941fb0453ea4b97c0e539f8b36e5e0262c1
2014-05-16 18:39:31 +09:00
Keisuke Kuroyanagi
d1f9ce00db Merge "Make session id mandatory for getSuggestions." 2014-05-16 09:33:28 +00:00
Keisuke Kuroyanagi
09c72207c6 Make session id mandatory for getSuggestions.
Bug: 15008504
Change-Id: Ic4a17a4b7242118ae74fd89c695da2bb52204fb2
2014-05-16 17:57:03 +09:00
Keisuke Kuroyanagi
f1b3518d71 Merge "Fix: StringIndexOutOfBoundsException." 2014-05-16 07:47:52 +00:00
Keisuke Kuroyanagi
34873a66f0 Fix: StringIndexOutOfBoundsException.
Bug: 14985751
Change-Id: I9df2f737555ab02e24e0fbd231a97c1eec26bc57
2014-05-16 15:32:12 +09:00
Keisuke Kuroyanagi
a545e8dd23 Fix: NPE when context.getFilesDir() returns null.
Bug: 14517587
Change-Id: Ib99bea14eab3a25ddb5042527b757133734a6ba6
2014-05-15 20:20:13 +09:00
Tadashi G. Takaoka
2ddaf9543d Remove unused auto correction led for spacebar feature
Change-Id: Ie1544bd0d28684d9b7887fddff37b224ed4f8201
2014-05-15 17:53:43 +09:00
Keisuke Kuroyanagi
e810a266fd Merge "Quit use bigram probability diff for ver4 dict." 2014-05-15 07:07:25 +00:00
Keisuke Kuroyanagi
64341927d2 Quit use bigram probability diff for ver4 dict.
Change-Id: I2cfcfbcf351877d1dff466a24974dbb05908f14e
2014-05-15 16:02:58 +09:00
Yohei Yukawa
f0fc320b4e Merge "Simplify StatsUtils" 2014-05-15 06:35:42 +00:00
Xiaojun Bi
3686bdfcc1 Fix off-device build
This CL fixed the breakage caused by DistracterFilter.
It should be checked in together with I8f53e9481c0f

Bug: 14911612
Bug: 13142176
Change-Id: I33c3526165cea58926d10404552f1fadc385c2e5
2014-05-14 17:39:02 -07:00
Yohei Yukawa
9aa7f66a15 Simplify StatsUtils
With this CL, the implementation of StatsUtils no longer
needs to know how to read settings from the system.

Insted, the LatinIME class is now responsible for notifying
StatsUtils whenever the settings is changed.

BUG: 14324207
Change-Id: Ic3d26ec31c8d2c082d3e7487b578b323aad2f960
2014-05-15 00:11:13 +09:00
Keisuke Kuroyanagi
aa7329de15 Merge "Add VERSION4_DEV(402) in Java side and use it for tests." 2014-05-14 13:42:24 +00:00
Keisuke Kuroyanagi
04536f14b0 Add VERSION4_DEV(402) in Java side and use it for tests.
Bug: 13406708
Change-Id: I7c9c53bf34d12dced7331a359a83f6444490783a
2014-05-14 22:37:07 +09:00
Keisuke Kuroyanagi
ee59975420 Merge "Fix a NPE in DistracterFilter.isDistracterToWordsInDictionaries()" 2014-05-14 12:20:10 +00:00
Jean Chalard
5ce39dfa78 Fix a bug where changing languages kills the composition.
Bug: 14926896
Change-Id: Id2a06c68a51f833db4d8bbc858a232c2696afb6e
2014-05-14 20:34:32 +09:00
Jean Chalard
08476dc107 Merge "Don't send empty composing texts." 2014-05-14 09:50:25 +00:00
Keisuke Kuroyanagi
0a04f8be93 Merge "Output dictionary format version for dump." 2014-05-14 09:07:56 +00:00
Jean Chalard
309ab664a8 Don't send empty composing texts.
Bug: 13160467
Change-Id: I5e3204ac8aaa18fe9219cc6b564b832ab6cf94fc
2014-05-14 16:55:32 +09:00
Xiaojun Bi
eb4f8506d6 Fix a NPE in DistracterFilter.isDistracterToWordsInDictionaries()
Bug: 14904706
Change-Id: I3b52bb01b9c59cbba2eba0bd1d91dffb4419c019
2014-05-13 21:00:28 -07:00
Keisuke Kuroyanagi
935150795b Output dictionary format version for dump.
Change-Id: I13873727dbb25550a5087c883968a77094d2115d
2014-05-14 11:39:28 +09:00
Tadashi G. Takaoka
08103a0e07 Show voice key even when important notice is showing
Bug: 14822080
Change-Id: I2a55bb630cf544b6dc31a5e0e6b932c6af268c71
2014-05-14 09:11:35 +09:00
Xiaojun Bi
25ec32f635 Merge "Implement the distracter filter" 2014-05-13 23:08:40 +00:00
Xiaojun Bi
ac20253806 Implement the distracter filter
Bug: 13142176

Change-Id: I85a048cdcbbad3d6020a25f900250d8d7a0fe3da
2014-05-13 15:52:14 -07:00
Tadashi G. Takaoka
06d1cdd5dc Add content description to the voice key
Bug: 14849593
Change-Id: I1664b6a4ef54b78a09df65adbffff7861b54c4a9
2014-05-13 16:33:31 +09:00
Keisuke Kuroyanagi
0f645381ee Merge "Fix typo wordPreperty -> wordProperty." 2014-05-13 02:58:05 +00:00