Commit Graph

3075 Commits (1b71ff00a23ede8d527266a31d44de018f8a7616)

Author SHA1 Message Date
Jean Chalard 7cbd0478cf Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev 2012-06-14 14:37:13 -07:00
Jean Chalard 002e43ead0 Merge "Remove irrelevant options." into jb-dev 2012-06-14 14:36:26 -07:00
Jean Chalard d5b765b3bb Do not display punctuation suggestions when bigrams are on.
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
2012-06-15 06:01:09 +09:00
Jean Chalard 78573f2e8a Fix an NPE
This code is temporary until we get rid of this member.

Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
2012-06-15 05:47:35 +09:00
Jean Chalard 15121cff37 Remove irrelevant options.
Bug: 6667355
Change-Id: I39b6db17fb52e80f510cf6462f41d9cb1f8e0341
2012-06-15 05:04:14 +09:00
Tadashi G. Takaoka 32f4ceb243 Dismiss more suggestions panel when suggestions strip is closed
This change fixes possible NPE as well.

Bug: 6658028
Change-Id: I8706808d1002b7b0b95930fd9b08568f08645da6
2012-06-14 11:57:43 -07:00
Satoshi Kataoka d2f210dbe2 am d9c702d2: am 5caaf1b9: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
  Do not add profanity to user history bigram dicitonary
2012-06-14 10:33:47 -07:00
Tadashi G. Takaoka c380959f48 am bbf18807: am 1db4f951: Fix the order of Persian diacritics
* commit 'bbf188075d5e14626c0609f4c3ee6031f6c6d5a6':
  Fix the order of Persian diacritics
2012-06-14 10:33:46 -07:00
Satoshi Kataoka 5caaf1b9e9 Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 2012-06-14 00:31:55 -07:00
Tadashi G. Takaoka 1db4f95105 Fix the order of Persian diacritics
The java source file KeyboardTextsSet.java has rather big change, but
this file is auto generated by "maketext" tool. The crucial part of
this change is in 5 XML resource files.

Bug: 6661783
Change-Id: I1d827ab0ebe6caa5ab73531682d6c32540b0d7aa
2012-06-14 15:18:25 +09:00
Satoshi Kataoka 68c650fb2a Do not add profanity to user history bigram dicitonary
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
2012-06-14 15:15:08 +09:00
Jean Chalard bbd7434229 Merge "Fix an occurrence of nested batch edits." 2012-06-13 10:37:12 -07:00
Tadashi G. Takaoka 8fa20d6a36 Merge "Remove useless copy constructor of ProximityInfo" 2012-06-12 16:24:39 -07:00
Tadashi G. Takaoka 9f42140ae2 Remove useless copy constructor of ProximityInfo
Change-Id: I56b4a99f670ad38708ad83d76b93a631295e3333
2012-06-12 15:13:07 -07:00
Jean Chalard 9d71748ba4 Fix an occurrence of nested batch edits.
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.

Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
2012-06-13 07:02:07 +09:00
Jean Chalard c7564a787e Optimization
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.

Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
2012-06-13 07:02:07 +09:00
Jean Chalard 72b358aa90 Small optimization.
This will avoid some two-way IPC calls.

Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
2012-06-13 07:02:07 +09:00
Satoshi Kataoka 84bb18f4c9 resolved conflicts for merge of ee78e780 to master
Change-Id: I88a4996bdd17c5378a67781d8075eff311670c3b
2012-06-13 06:45:38 +09:00
Jean Chalard 58d9e46ce0 Merge "Consolidate a test." 2012-06-12 11:50:36 -07:00
Kurt Partridge 5e50eec570 Merge "Check inputs to ResearchLogger" 2012-06-12 11:39:11 -07:00
Jean Chalard e86054e5c2 Consolidate a test.
Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
2012-06-13 03:34:58 +09:00
Kurt Partridge 65fc909e13 Check inputs to ResearchLogger
to avoid NPEs.

Bug: 6188932
Change-Id: I377ceaac867df879dc7984dae44e96b369858cca
2012-06-12 10:56:03 -07:00
Jean Chalard 140adf204b Consolidate auto-correction settings.
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).

Also perform a very small refactoring

Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
2012-06-12 10:29:55 +09:00
Jean Chalard 2010aad741 Move two methods in a more appropriate place
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
2012-06-12 10:29:55 +09:00
Jean Chalard a32eb27213 Move an editing method to the RichInputConnection
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
2012-06-12 10:29:55 +09:00
Jean Chalard 243e370fcb Move a member call out of the way
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
2012-06-12 10:29:55 +09:00
Jean Chalard 747cf0435a Move two editing utility methods to RichInputConnection
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
2012-06-12 10:29:55 +09:00
Jean Chalard 70a046f8ca Merge "Rename mSettingsValues to mCurrentSettings" 2012-06-11 18:24:45 -07:00
Jean Chalard 64913d72bc Merge "Move suggestion strip visibility to SettingsValues" 2012-06-11 18:18:50 -07:00
Jean Chalard 15c0090e88 Merge "Accept a null input attributes for reading settings." 2012-06-11 18:18:43 -07:00
Jean Chalard f4bc441256 Merge "Move the correction mode to SettingsValue and make it final" 2012-06-11 18:18:03 -07:00
satok 6a71f0610c Fix UserHistoryBigram data contention in UserHistoryDictionary
Bug: 6637614
Change-Id: I34d26563e59d3b09bf35b8173dac5645ccb6a39f
2012-06-12 08:00:14 +09:00
Jean Chalard 411a98afb9 Merge "Consolidate updateCorrectionMode() calls" 2012-06-11 14:02:15 -07:00
Jean Chalard 297e6d590b Rename mSettingsValues to mCurrentSettings
...for readability. After all, it makes sense that "current settings"
is a "SettingsValues", while it's harder to understand why we'd
manipulate an object named "SettingsValues".

Change-Id: Ide9a17b970a6cc00b80b9a217f986268c739c662
2012-06-08 21:34:07 +09:00
Jean Chalard d273697259 Move suggestion strip visibility to SettingsValues
Change-Id: If34112c69acd5122d87554043d87d8f4dbdf5d15
2012-06-08 21:26:25 +09:00
Jean Chalard 01e3b014bb Accept a null input attributes for reading settings.
Change-Id: I11a8e1aca3541c35d2b39b27716687fcd8ff3dc6
2012-06-08 21:15:33 +09:00
Jean Chalard 4b9e6ee6fb Move the correction mode to SettingsValue and make it final
At last this guy is final, at last

Change-Id: I76911f8d47493f8a1719f75fc7e949be5d7da1a2
2012-06-08 21:10:35 +09:00
Jean Chalard 3791183076 Consolidate updateCorrectionMode() calls
Change-Id: I43c0505e9a1652bfc568f23b787fc68a5c5e9220
2012-06-08 21:02:19 +09:00
Ken Wakasa e7b34b9f86 Add NativeUtils.powf()
Change-Id: I0339f39d49bc6390d098017f32d92c776974e03e
2012-06-08 20:46:19 +09:00
Jean Chalard bbbdab12be Move some editing methods to RichInputConnection.
Change-Id: I8527776a4bd8236a85bb77f9791f9b76977ad181
2012-06-08 20:23:13 +09:00
Jean Chalard e091982868 Straighten batch edits, pass 1
Change-Id: I73acfee9098a87b9cde8aca720586ec748b2a82f
2012-06-08 20:09:41 +09:00
Jean Chalard 02308bec63 Merge RichInputConnection with EditingUtils
Change-Id: I9982ff325bef56694402caef28a77683c52ccd71
2012-06-08 20:04:09 +09:00
Jean Chalard 5475b38328 Make a wrapper for the input connection.
The goal is to simplify the code in LatinIME.java as well as having
a handy place to put debug calls to see interaction with TextView.

Change-Id: I255227e7e7343e0c2f3dcd1f185e5020d6186732
2012-06-08 19:50:12 +09:00
Jean Chalard c33a5428be Merge "Small performance tweak" 2012-06-08 01:22:31 -07:00
Jean Chalard 67fd0c240d Remove deprecated classes.
Should we maybe rename back *BinaryDict* to *Dict* in another
change for simplicity?

Change-Id: I8f7dcb78b9bdf1a13ce403a997fbb8619f2b453b
2012-06-08 17:12:15 +09:00
Jean Chalard d10c473347 Small performance tweak
Change-Id: Icd540742073d49d12e70b2d8bd99aaf7ccb5802d
2012-06-08 17:09:40 +09:00
Jean Chalard e91f32d8c1 Merge "Remove a slew of Eclipse warnings." 2012-06-08 00:35:05 -07:00
Jean Chalard 7214617622 Remove a slew of Eclipse warnings.
Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
2012-06-08 16:23:18 +09:00
Satoshi Kataoka eed2cf287d Merge "Separate state from proximity_info step1" 2012-06-07 22:18:11 -07:00
Ken Wakasa d418580a71 Fix typo
Change-Id: I264f829c1584a37995dbc5ee4ba6b6783d5d4834
2012-06-08 03:42:02 +09:00
Tadashi G. Takaoka 6b8a70105f am e4da18e2: am 6348c54f: Merge "Initializing member variable before it is referenced" into jb-dev
* commit 'e4da18e27916f770fcd704032d30534d287d67c6':
  Initializing member variable before it is referenced
2012-06-07 11:32:50 -07:00
satok 1e96cc1f51 am 674c51a0: am ec2981a4: Fix a bug on upgrading user history scheme
* commit '674c51a01117b73dd25473195f92fb0c0158da26':
  Fix a bug on upgrading user history scheme
2012-06-07 11:28:41 -07:00
Tadashi G. Takaoka 6348c54ffd Merge "Initializing member variable before it is referenced" into jb-dev 2012-06-07 11:27:32 -07:00
Tadashi G. Takaoka 40582ab438 Initializing member variable before it is referenced
Bug: 6584882
Change-Id: I1f76388fa8cc16171bc3fc60c935ddcf0a7c4e92
2012-06-07 11:17:59 -07:00
satok ec2981a487 Fix a bug on upgrading user history scheme
Bug: 6626700
Change-Id: I3190d7404e45e704be79ee2031e79b18475feb8c
2012-06-08 02:55:23 +09:00
Tom Ouyang 11dc22d964 Merge "Contacts binary dictionary updates with change in keyboard locale." 2012-06-07 01:19:44 -07:00
Tom Ouyang 2e8aa06002 Contacts binary dictionary updates with change in keyboard locale.
Bug: 6616436
Change-Id: I8d66a37f295134c5b9875b2a305a9be7442bd75d
2012-06-07 00:25:41 -07:00
Jean Chalard c8a120f970 am eead5492: am 769cecf7: Close spell-checking dictionaries in a background thread
* commit 'eead5492615f0b05ef85ca1f88d3a41ce3f8d496':
  Close spell-checking dictionaries in a background thread
2012-06-06 21:52:46 -07:00
Satoshi Kataoka 3e8c58f68d Separate state from proximity_info step1
Bug: 6548943

Change-Id: I7b4fbe20615a28151a74875be43b9f4a20e0dce9
2012-06-07 13:35:34 +09:00
Jean Chalard 769cecf7e7 Close spell-checking dictionaries in a background thread
Bug: 6584677
Change-Id: Ifd9b0f995f4e0cf4d35a7ecde767826ab976f0b8
2012-06-07 12:56:45 +09:00
Kurt Partridge 9b300f0caa Merge "add research log ui control" 2012-06-06 20:47:53 -07:00
Kurt Partridge 724bc479f7 add research log ui control
- lets users flag a particular time in the research log
- lets users delete the log for this session

also makes the UsabilityLog setting control whether the ResearchLog logs or not.

multi-project commit with I89067e7d3b8daca7179333f1dbe82224c26920fe

Bug: 6188932
Change-Id: I89864ef3ab53b0efe1ea8d75247be08712f0c399
2012-06-06 20:42:01 -07:00
Satoshi Kataoka 91c8c4f3a7 am e08cfda1: am 5a8d2fd1: Merge "Cache UserHistoryDictionary for each language" into jb-dev
* commit 'e08cfda1ebea693c56681816076c419f23c51076':
  Cache UserHistoryDictionary for each language
2012-06-06 10:48:46 -07:00
Satoshi Kataoka 5a8d2fd1d3 Merge "Cache UserHistoryDictionary for each language" into jb-dev 2012-06-06 10:43:50 -07:00
Tadashi G. Takaoka 562239bf51 am 59dae7e1: am 907ba593: Can specify Key.backgroundType in <Row> and <include> attribute
* commit '59dae7e141b6d6a8bea287f6699e34137390c5f9':
  Can specify Key.backgroundType in <Row> and <include> attribute
2012-06-06 10:42:38 -07:00
Tadashi G. Takaoka 2bf014d2a8 Fix xml tag in comment
Bug: 6620122
Change-Id: I2852f77d78b242c1a96c53cdd1e4c0e299f8ea4f
2012-06-06 10:36:30 -07:00
Tadashi G. Takaoka 907ba59397 Can specify Key.backgroundType in <Row> and <include> attribute
Bug: 6568834
Change-Id: I138464b5445e13eaf062ce84a1ba332dfd1afafa
2012-06-06 10:15:51 -07:00
Satoshi Kataoka a836808f8b Cache UserHistoryDictionary for each language
Bug: 6603257
Change-Id: I73b65e921cff8337a00594525f67f6aec2178881
2012-06-06 20:02:00 +09:00
Satoshi Kataoka 21b782cf22 Merge "Cache bigram results in Android SpellChecker" 2012-06-06 01:01:47 -07:00
Satoshi Kataoka 547bc0cf04 Cache bigram results in Android SpellChecker
Bug: 6610579
Change-Id: I255c068f64f99ee80abda49153ed8ea009ca8ad3
2012-06-06 16:58:24 +09:00
Kurt Partridge 6b3b37da97 Merge "Change constants in ResearchLogger" 2012-06-05 20:17:14 -07:00
Tadashi G. Takaoka 876711930d am 2eb5eb4d: am be2fef4d: Merge "Fix backing view height calculation in landscape orientation" into jb-dev
* commit '2eb5eb4d447cb326b4c10cff2cae64df4e431ffd':
  Fix backing view height calculation in landscape orientation
2012-06-05 17:58:59 -07:00
Tadashi G. Takaoka be2fef4d5e Merge "Fix backing view height calculation in landscape orientation" into jb-dev 2012-06-05 17:54:42 -07:00
Tadashi G. Takaoka b94f4cc71c Fix backing view height calculation in landscape orientation
This logic has been dropped by Ib814c07f.

Bug: 6610497
Change-Id: Id89ad3280b73a31d8c9c6826e9ee297791624db1
2012-06-05 17:41:01 -07:00
Charles Chen 7b250c25f7 am 6b0d0fa3: am f8233ec3: Merge "Refresh Accessibility key mapping when KeyboardView changes Keyboards." into jb-dev
* commit '6b0d0fa3501247ccf3190c938dec580102fe0473':
  Refresh Accessibility key mapping when KeyboardView changes Keyboards.
2012-06-05 15:02:27 -07:00
Charles Chen f8233ec32d Merge "Refresh Accessibility key mapping when KeyboardView changes Keyboards." into jb-dev 2012-06-05 14:55:59 -07:00
alanv f147794fd4 Refresh Accessibility key mapping when KeyboardView changes Keyboards.
Bug: 6609626
Change-Id: I93d764b46e96fe70b61c91a7dcb46945ac8853dd
2012-06-05 11:02:54 -07:00
Jean Chalard 5235e0cd91 am c750f9eb: am a6166d37: Fix a bug where Latin IME crashes on spell checker request
* commit 'c750f9eb5398a30b207891e6858863f493875199':
  Fix a bug where Latin IME crashes on spell checker request
2012-06-05 09:54:58 -07:00
Tom Ouyang f93551f77b am 18c4137c: am 7f7739fe: Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev
* commit '18c4137c878c18de24a406b861ddb2a735e02f7d':
  Fix a bug where the spellcheck is using the old non-binary contacts dictionary
2012-06-05 09:54:55 -07:00
Satoshi Kataoka 037cf8c8a5 am 7394fc43: am 0e134e6b: Merge "Avoid redundant access to DB" into jb-dev
* commit '7394fc43028ef6e28579921c30915bd8a9c9c990':
  Avoid redundant access to DB
2012-06-05 09:22:17 -07:00
Jean Chalard c1cbcf949d am 9252fc1b: am dd487247: Merge "Read the script correctly" into jb-dev
* commit '9252fc1b88df0c8bd3870546d1c8ca7681e435d3':
  Read the script correctly
2012-06-05 09:22:15 -07:00
Kurt Partridge f739119f3f Change constants in ResearchLogger
Bug: 6188932
Change-Id: I3c6a3fb3e8fb139e16322e544f12bc3294cdaf1c
2012-06-05 07:13:06 -07:00
Jean Chalard a6166d3776 Fix a bug where Latin IME crashes on spell checker request
Bug: 6611183
Change-Id: I8a879feb598e1ac55d73f9cb27e54aa533d3a010
2012-06-05 16:33:21 +09:00
Tom Ouyang 7f7739fee8 Merge "Fix a bug where the spellcheck is using the old non-binary contacts dictionary" into jb-dev 2012-06-04 23:10:03 -07:00
Satoshi Kataoka 0e134e6be8 Merge "Avoid redundant access to DB" into jb-dev 2012-06-04 20:08:02 -07:00
Jean Chalard dd4872474a Merge "Read the script correctly" into jb-dev 2012-06-04 19:55:47 -07:00
Tom Ouyang faf0059f35 Fix a bug where the spellcheck is using the old non-binary contacts dictionary
Bug: 6607023
Change-Id: I6dc120dea23052a0841e281c20706bfb21fd9876
2012-06-04 14:07:47 -07:00
Satoshi Kataoka a8c13e7942 Avoid redundant access to DB
Bug: 6603257
Change-Id: I2e8017f9e2e222aeab0a80faa239ce83d3b212ad
2012-06-04 23:41:50 +09:00
Jean Chalard b1f3c24c63 Read the script correctly
The script of a language presumably does not depend on the
country variant. This was how it was made but it was later
forgotten and the full locale was registered.

Bug: 6542210
Change-Id: Iebc90c546f9c8caf89f8aa6c6a7c4733e5bcba48
2012-06-04 18:39:16 +09:00
Tadashi G. Takaoka 236c2c3987 am a6c88f10: am fe824948: Dismiss key preview immediately when Keyboard is closing
* commit 'a6c88f106a16fec2e81f87f170e97194c8fa7a3a':
  Dismiss key preview immediately when Keyboard is closing
2012-06-04 00:07:17 -07:00
Tadashi G. Takaoka fe824948bb Dismiss key preview immediately when Keyboard is closing
Bug: 6595594
Change-Id: I52311369929862b17879cd15fdee3598179eedbb
2012-06-04 15:47:32 +09:00
Tadashi G. Takaoka 9895b815a8 am e2832daf: am 8cf3654a: Merge "Use calculated backing view height instead of the view\'s height" into jb-dev
* commit 'e2832daf4c289f94d68c546c485fc06bbf6aefd6':
  Use calculated backing view height instead of the view's height
2012-06-03 21:55:26 -07:00
Tadashi G. Takaoka bc5b89cdff Use calculated backing view height instead of the view's height
This change removes the work around that was introduced by If4f24500.

Bug: 6596131
Change-Id: Ib814c07fdac7d0aa0d7fbc2764fda1af42b82ad5
2012-06-04 12:49:27 +09:00
Ken Wakasa 4a9e5d2c95 am a8b7451b: am 027448e0: Remove an unnecessary thread.
* commit 'a8b7451b31872d217cd61b7d0e6fbbf7221781c8':
  Remove an unnecessary thread.
2012-06-02 09:07:51 -07:00
Ken Wakasa 027448e08a Remove an unnecessary thread.
bug: 6584677

While looking at bug 6584677, we found that LatinIME always spawns an unnecessary thread
for Usability Study Mode.  We don't assume this change will address the root cause of the
bug, but we'd like to remove any suspicious noises in bugreports.

Change-Id: Ie47d104f6cd77ec2ad164f13b4212cb4a70bcf1d
2012-06-03 00:27:07 +09:00
satok 083fb024d7 am e6560252: am 72cd8466: Merge "Fix NPE in user history bigram dictionary" into jb-dev
* commit 'e656025282c0da28ed80b2604949092dbc5fb72e':
  Fix NPE in user history bigram dictionary
2012-05-31 20:29:43 -07:00
satok 72cd84665c Merge "Fix NPE in user history bigram dictionary" into jb-dev 2012-05-31 20:24:20 -07:00
satok 4f96bb4520 Fix NPE in user history bigram dictionary
Bug: 6584882
Change-Id: Id0162bffc4f0f36239cdc68383f8a47d7a957397
2012-06-01 12:19:22 +09:00
Charles Chen 6fd153e554 am d30cfee5: am 40e5f403: Merge "Add special case for speaking ACTION_ENTER keys." into jb-dev
* commit 'd30cfee577228873902a16791cd8c3ad3fad4a4c':
  Add special case for speaking ACTION_ENTER keys.
2012-05-31 18:06:03 -07:00
Charles Chen 40e5f403af Merge "Add special case for speaking ACTION_ENTER keys." into jb-dev 2012-05-31 17:24:50 -07:00