Commit graph

7506 commits

Author SHA1 Message Date
Jean Chalard
146cb98e54 [ML2] Small refactoring
Change-Id: I1283d666b8904ff4e6c012332bdbc9c0c13df415
2014-09-01 20:09:24 +09:00
Tadashi G. Takaoka
f5960b4f62 am 034a4a5a: am c4710124: Merge "Fix the order of keys on more keys keyboard" into lmp-dev
* commit '034a4a5a19ba37dba8999b3763ae756fe748deaf':
  Fix the order of keys on more keys keyboard
2014-08-29 19:07:06 +00:00
Tadashi G. Takaoka
2d713c87c6 am 2fabd50d: am f507d1fe: Support RTL layout in custom input style settings
* commit '2fabd50df49f894afde15ac5f4ebd2ff5372a9c4':
  Support RTL layout in custom input style settings
2014-08-29 19:07:04 +00:00
Jean Chalard
78bb2dd945 am 3bd8eee3: am 4e28a6a8: Fix an IOOB exception
* commit '3bd8eee3e8c3e89539578a4231661819de65c804':
  Fix an IOOB exception
2014-08-29 19:07:03 +00:00
Tadashi G. Takaoka
f9af39e53e am 727cd740: am f2eadbb4: Clear keyboard cache when system locale is changed
* commit '727cd74072d97af334fe8c0d18fa6a1e23629ccb':
  Clear keyboard cache when system locale is changed
2014-08-29 19:07:02 +00:00
Keisuke Kuroyanagi
9eec97d5b0 Merge "Use DictionaryFacilitatorLruCache for personalization." 2014-08-29 10:10:40 +00:00
Tadashi G. Takaoka
c471012483 Merge "Fix the order of keys on more keys keyboard" into lmp-dev 2014-08-29 09:58:28 +00:00
Tadashi G. Takaoka
f507d1febb Support RTL layout in custom input style settings
Bug: 17322353
Change-Id: I3b211ab8729121271563a8a243558a58ee7847c2
2014-08-29 18:28:53 +09:00
Jean Chalard
4e28a6a844 Fix an IOOB exception
Bug: 17316001
Change-Id: Iaa2cfd30ebbe0d49e10a5c3a30336e06817d0a8b
2014-08-29 06:56:34 +00:00
Keisuke Kuroyanagi
e59f3e4fbf Use DictionaryFacilitatorLruCache for personalization.
Bug: 16547557

Change-Id: I5faba5e26d072b49c0fffcaeaf5062f9e0c2dcc0
2014-08-29 12:57:50 +09:00
Tadashi G. Takaoka
a9fc8622fe Fix the order of keys on more keys keyboard
This CL fixes the behavior of !autoColumnOrder!<n> flag in a more keys
specification. Formerly the <n> value specifies the maximum number of
column of more keys. With this CL, the <n> value specifies the exact
number of column of more keys.

Bug: 16603887
Change-Id: I2120620fa512ee30043bb146ad675a942a375129
2014-08-29 11:06:20 +09:00
Jatin Matani
aabb351279 Refactor StatsUtils into two components:StatsUtils & StatsUtilsManager
Bug:16522256
Change-Id: I9cb8129c552159cf17ea5c2656e0988bf0f999f5
2014-08-28 17:28:23 -07:00
Tadashi G. Takaoka
f2eadbb497 Clear keyboard cache when system locale is changed
Bug: 17310080
Change-Id: I2b388772f269f1e7610a5bd32de80793da2df16e
2014-08-28 22:50:07 +09:00
Jean Chalard
98e56c6905 am 3ef26ac1: am 6bd267f4: Merge "Add new attributes to our notification" into lmp-dev
* commit '3ef26ac13b677bc8d7adeed378ce6d6cbad171ee':
  Add new attributes to our notification
2014-08-28 09:52:03 +00:00
Jean Chalard
a2928484f6 Add new attributes to our notification
Bug: 17167221
Bug: 17128331
Change-Id: I6a045fd2398f40dbdc10c9d20993f7513e1f2cff
2014-08-28 07:47:07 +00:00
Jean Chalard
f95770354c Straighten the dead char implementation, take 3.
Change-Id: I4f70f6eebe076c7d2b780d25e3a2c1d3faa2edfa
2014-08-28 16:03:45 +09:00
Keisuke Kuroyanagi
b85349e981 Merge "Create DictionaryFacilitatorLruCache." 2014-08-28 03:09:28 +00:00
Yohei Yukawa
af5c2b24e7 am 8d0d2363: am acce1aa5: Make sure to obtain the IC before requesting CursorAnchorInfo
* commit '8d0d236394548be4e2302a03960ce4ee363a5483':
  Make sure to obtain the IC before requesting CursorAnchorInfo
2014-08-27 23:41:33 +00:00
Yohei Yukawa
acce1aa59e Make sure to obtain the IC before requesting CursorAnchorInfo
RichInputConnection#requestUpdateCursorAnchorInfo must make
sure to obtain the input connection before calling methods
of it.

BUG: 17299587
Change-Id: I8e0cd473a4cc32583cd47634c227d702f7c69c6c
2014-08-27 15:59:52 -07:00
Ken Wakasa
95c4d26994 Merge "Revert "Straighten the dead char implementation."" 2014-08-27 15:07:52 +00:00
Ken Wakasa
0ba6bcb16d Revert "Straighten the dead char implementation."
This reverts commit 5ef447aeea.

Reverting because this broke a bunch of unit tests -- https://sponge.corp.google.com/target?id=b6439742-099e-46cb-8f00-d0c602a4d9bb&target=com.google.android.inputmethod.latin.tests&searchFor=&show=FAILED&sortBy=STATUS

Change-Id: Ibbd9e11372993f62e630fd9da37158ffcf47c17a
2014-08-27 15:07:28 +00:00
Keisuke Kuroyanagi
d267764d5a Create DictionaryFacilitatorLruCache.
This class is separated from AndroidSpellCheckerService

Bug: 16547557

Change-Id: I3e58521207395588cecb2977234b89067d6da8c3
2014-08-27 22:00:48 +09:00
Jean Chalard
4204d59864 Merge "Straighten the dead char implementation." 2014-08-27 12:54:49 +00:00
Tadashi G. Takaoka
8b5788d72b am 68a2a69a: am 37beaf15: Simplify onComputeInsets of LatinIME
* commit '68a2a69ae35352650a4c6dfc0b0c69069c4a1e1d':
  Simplify onComputeInsets of LatinIME
2014-08-27 10:44:51 +00:00
Tadashi G. Takaoka
37beaf1529 Simplify onComputeInsets of LatinIME
This CL expands SoftInputWindow to the entire screen. Thus a key
review backing view is eliminated and onComputeInsets() gets
simplified too.

Bug: 17212702
Bug: 10841052
Bug: 10541453
Change-Id: I2d859f4e4698c64cabe399000821f13bab729996
2014-08-27 19:20:38 +09:00
Yohei Yukawa
00042cb453 am c925ca43: am 97681ebd: Set highlight color along with the commit indicator
* commit 'c925ca43a6e0b3175feb002ce6b5577ef7d66507':
  Set highlight color along with the commit indicator
2014-08-27 10:01:24 +00:00
Ken Wakasa
6da1c674fd resolved conflicts for merge of 8159336b to master
Change-Id: I9dd726593c6768b1db35305935ee69b0937358ef
2014-08-27 18:55:39 +09:00
Ken Wakasa
c1596086d3 resolved conflicts for merge of 0268f736 to master
Change-Id: Ib89ef55a8752f9b5e357eed3a05c79dd28d0ec0e
2014-08-27 18:41:31 +09:00
Jean Chalard
5ef447aeea Straighten the dead char implementation.
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed

Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
2014-08-27 17:59:39 +09:00
Yohei Yukawa
97681ebdf1 Set highlight color along with the commit indicator
With this CL, the text highlight color is applied
when the commit indicator is displayed.

Note that the underline is not rendered when the
background color is enabled. This is a known issue.

Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
2014-08-27 01:41:16 -07:00
Yohei Yukawa
29200b0abe Set the text bgcolor only when CursorAnchorInfo is available
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.

With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not.  This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.

Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
2014-08-27 01:30:45 -07:00
Yohei Yukawa
a475c85480 Introduce a mechanism to hide the indicator speculatively
This is an optional optimization to reduce the UI latency.

Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.

If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.

This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.

Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Yohei Yukawa
bea17c49ec Introduce commit/add-to-dictionary indicators
This CL introduces commit/add-to-dictionary indicators.

Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.

Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Ken Wakasa
4660ecaa44 Merge "Fix a bug where mic/emoji key wouldn't work." 2014-08-26 13:30:15 +00:00
Jean Chalard
e38043849e Fix a bug where mic/emoji key wouldn't work.
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
2014-08-26 22:06:21 +09:00
Jean Chalard
96522da9eb am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear.
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
  Fix a bug where the top prediction would disappear.
2014-08-26 12:37:17 +00:00
Jean Chalard
8380f921f7 Fix a bug where the top prediction would disappear.
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
David Faden
9cf69a45b2 Adds documentation for a few methods.
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi
bf6fc4953b Merge "Get dynamic dict stats via DictionaryFacilitator" 2014-08-25 11:24:54 +00:00
Yohei Yukawa
d8dfac6dcb am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
  Use more descriptive names for some internal fields
2014-08-25 10:16:11 +00:00
Jean Chalard
1a31d784cd Merge "Introduce onEvent() to improve testability" 2014-08-25 09:57:42 +00:00
Yohei Yukawa
fdfe73ff1f Merge "Use more descriptive names for some internal fields" into lmp-dev 2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka
d147db8763 am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
  Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:35:08 +00:00
Yohei Yukawa
a61b7245b0 Use more descriptive names for some internal fields
This CL clarifies that delay parameters are specified with
milliseconds.

Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Jean Chalard
ee8ebeecbf Merge "Fix unit tests" 2014-08-25 09:26:17 +00:00
Jean Chalard
dc110b2a6a Fix unit tests
Change-Id: I48bfa4e4dd80f36d2fe0a1e9d2a2706533cc722e
2014-08-25 18:19:00 +09:00
Tadashi G. Takaoka
7defe926ca am 4a782da3: am f145fff0: Merge "Fix NPE when pressing ALT key" into lmp-dev
* commit '4a782da382b83164ea5c23c771b771e73bbe31b3':
  Fix NPE when pressing ALT key
2014-08-25 08:25:42 +00:00
Yohei Yukawa
4587b135be am 2d508203: am 8681287c: Fix build due to an illegal character
* commit '2d508203c64f50ed47fb87c24ae5ebbfb0610a36':
  Fix build due to an illegal character
2014-08-25 08:25:35 +00:00
Yohei Yukawa
8c7daa829a am 02716083: am 5eebaddc: Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev
* commit '02716083158c3affbcfc719ff6471112d7397578':
  Dismiss "Add to dictionary" hint with non-special char event
2014-08-25 08:25:34 +00:00
Yohei Yukawa
a5687ee9f7 am b65a1e46: am 2c4cce8d: Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev
* commit 'b65a1e46ce06adc462dfc4cbde302ac27a79b695':
  Introduce #shouldShowAddToDictionaryHint
2014-08-25 08:25:33 +00:00