Commit graph

1305 commits

Author SHA1 Message Date
Dan Zivkovic
77fd5dbf3e Remove dead code, including tests.
Change-Id: Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c
2015-03-10 17:22:41 -07:00
Chieu Nguyen
21a28abc6a Handle empty previous ngram context correctly.
Fixes bug where empty previous ngram context not at the
beginning of a sentence incorrectly returned the
beginning-of-sentence marker.

Bug: 19612336
Change-Id: I5ddf3408e20dcedf70487b85c983cd3fc12550e7
2015-03-09 19:02:43 -07:00
Dan Zivkovic
f9e2d271ca Use a single background executor.
Bug 19625976.

Change-Id: Ia03f440a31b059b5af42d162e1145330bf7b5ddf
2015-03-09 13:22:56 -07:00
Dan Zivkovic
b86ca76cea Handle null InputMethodSubtype.
Bug 19627494.

Change-Id: I50dc77c59ced0f2e7c07a49ae0cb040197c2ab35
2015-03-06 14:34:57 -08:00
Dan Zivkovic
bc0384c7ec Combine InputLogicTests.
Change-Id: Ie322e7d7c7098031d112abad6c9991f56ebba0f2
2015-03-04 15:07:13 -08:00
Dan Zivkovic
1ae16dc3db Next-word suggestion bit in keyboard settings.
This feature works in supported languages.
We don't need a user setting.

Bug 19596067.

Change-Id: Icdded772745f9816da47f8a5e3b87b733083b121
2015-03-04 15:02:53 -08:00
Jatin Matani
a568e0acb4 Add util method in ngramcontext for context array
Change-Id: I2e3e2ac7706be50ed2055b0c69b30e25a516a879
2015-03-03 13:20:53 -08:00
Jatin Matani
c83352d527 Merge "Refresh pref settings for cloud sync" 2015-02-26 22:10:02 +00:00
Jatin Matani
8ec328fb2e Refresh pref settings for cloud sync
- Show the opt-in text
- Show the account picker if user presses 'enable sync'. Previously
  we disabled the sync pref which was confusing.
- Remove the debug tags from some prefs; and improve messaging overall

General rules;
- sync is turned ON : user checks 'enable sync' pref AND
  accepts the opt-in AND chooses an account
- sync is turned OFF: when user signs out

Demo link
https://drive.google.com/a/google.com/file/d/0B9tNQOWdRuiWSUdVVE5rVDJudlk/view?usp=sharing

Change-Id: I2e7933796b15e47005ba9970a8c1294416ef31a0
2015-02-26 11:43:42 -08:00
Dan Zivkovic
7d7f082075 Stop waking up to decay dynamic dictionaries.
Bug 19516048.

Change-Id: Ibc27a792b4fa80fa8c6af4721c47a617526e9584
2015-02-25 20:13:59 -08:00
Dan Zivkovic
5551302d27 Don't assume that correctable words are invalid
Currently, the Delight3DictionaryFacilitator sets a boolean flag when the top
suggestion score exceeds the auto-correction threshold. This flag is used to
trigger auto-correction of the typed word. Also, the existing logic assumes
that if allowsToBeAutoCorrected then the word is invalid, which is no longer
true after we stopped using whitelists.

Bug 19518376.

Change-Id: Ifa7f6a09c07d25ac68c6cf3aec91f358bd88689f
2015-02-25 17:59:58 -08:00
Dan Zivkovic
fe3c4ef940 Merge "Spell checker uses cache of size 1." 2015-02-20 19:06:48 +00:00
Dan Zivkovic
29aa3df3da Spell checker uses cache of size 1.
This is a step in the direction of removing the LRU cache completely.

Change-Id: I8886f7ef74e6b1b35135e68f169cb461682964e9
2015-02-20 11:05:44 -08:00
Jatin Matani
01b023730e Add tests for Contact* classes
Also add empty implementation for dictionary
facilitator iteration APIs
Change-Id: Ia847e3faa75075c819fcfda89193d1024d2d5aca
2015-02-20 09:14:27 -08:00
Dan Zivkovic
0b03f13cab Sanitize the usage of executors.
There should be 1 executor each for static and dynamic language models.
This prevents too many dynamic LM updates from running in parallel,
competing for resources.

Change-Id: I8ec439e0ea2d92fba275bc20a0b8c9193346a0c1
2015-02-19 11:40:57 -08:00
Dan Zivkovic
5254c01d4c Fix master build.
For some reason, we can't import android.os package in our Constants.

Change-Id: I357ed72d13c5039a83c6e2489cdf5ef74d0ffea8
2015-02-11 13:32:13 -08:00
Dan Zivkovic
12d80ebead Remove shortcut support from LatinIME.
Note this change does not affect the native decoder interface.

Change-Id: I73b7dc008a5acaf75a31a36a2d332b5afabd82d0
2015-02-11 13:02:41 -08:00
Mario Tanev
2979fad213 Merge "Add new class spellcheck.UserDictionaryLookup that can look up the system "Personal dictionary" in the event that the DictionaryFacilitator doesn't." 2015-02-10 23:25:50 +00:00
Mario Tanev
8aa310aa5a Add new class spellcheck.UserDictionaryLookup that can look up the
system "Personal dictionary" in the event that the DictionaryFacilitator
doesn't.

Change-Id: Ib4f15ec4d8f06ea43c2e063f5a13a2f699afbb8a
2015-02-10 10:56:35 -08:00
Dan Zivkovic
644a709a5f Remove distracter filter from client.
Bug 19296201.

Change-Id: Ic834e5956347cd86a96bd14024c42ad8ee258659
2015-02-09 11:52:12 -08:00
Mohammadinamul Sheik
aadfef6ffa Merge "Move decoder specific constants to DecoderSpecificConstants.java" 2015-02-06 22:46:08 +00:00
Dan Zivkovic
d6a8adcb04 Cleanup in preparation of distracter change.
Bug 19296201.

Change-Id: If016da2b7f4b3ecb9afd6d7aed9d19fbd4938758
2015-02-06 14:25:37 -08:00
Mohammadinamul Sheik
0f7d881dc7 Move decoder specific constants to DecoderSpecificConstants.java
Change-Id: Ie4d325b3152e1e7e424b8b436e222e194e4d9da0
2015-02-05 13:27:36 -08:00
Dan Zivkovic
7b2646dd58 Merge "Selections spans should not split surrogate pair." 2015-02-05 00:47:29 +00:00
Dan Zivkovic
f3c319fb8a Selections spans should not split surrogate pair.
When committing a span after a revert, the offset logic was such that it
split a surrogate unicode pair used to express an emoji.
Checking the last character of the span lets us avoid this problem.

Fix for bug 19255233.

Change-Id: I07d18d9002b5075f7925319dd05962011656c311
2015-02-04 16:35:18 -08:00
Mohammadinamul Sheik
b00c054125 AOSP changes to use KeyboardLayout to support the new DictionaryFacilitator
Change-Id: Ie0c9ce805d9ad009fc9bbaac37b715aff90cd844
2015-02-04 12:50:31 -08:00
Jatin Matani
48cc0d6420 Merge "Nuke Amanatto" 2015-02-03 19:20:40 +00:00
Jatin Matani
15acbdc905 Nuke Amanatto
Change-Id: Ieff2cd37f869dca69abf53ac32a576c2e45cc1e3
2015-02-02 17:10:38 -08:00
Mohammadinamul Sheik
d543984d2e Create a new KeyboardLayout class to represent the layout.
Change-Id: Ia08c8194f460271c831702675cfb687ab9f6678b
2015-01-30 17:24:09 -08:00
Dan Zivkovic
e1758feeff Disable the Burmese keyboard.
We'll resurrect this effort in the new code base.

Bug 16900511.

Change-Id: Iae4cd27cb29cb8f991e97cffd88ed59c30d66628
2015-01-29 10:17:33 -08:00
Mario Tanev
ab6f3b36d0 Change DictionaryFacilitator.java to an interface, create its
implementation DictionaryFacilitatorImpl.java and add a java-overridable
factory DictionaryFacilitatorProvider.java used to create a
DictionaryFacilitator.

Change-Id: Id4a58ae31feaa4d12a048a772c8d76ff82fdee45
2015-01-27 21:38:32 +00:00
Dan Zivkovic
bd254ca776 Merge "Re-enable new keyboard layouts in Fava." 2015-01-21 19:34:12 +00:00
Dan Zivkovic
9ea443e8c0 Re-enable new keyboard layouts in Fava.
This reverts commit da27faeb87.

Change-Id: I08e2b2510efcafd20743679de4a1ef7f09d9949a
2015-01-20 19:37:26 +00:00
Jean Chalard
9fe700ec4f Merge "Fix moving the cursor inside composition in lang w/o spaces" 2015-01-16 03:22:18 +00:00
Dan Zivkovic
da27faeb87 Revert "Enable preliminary subtypes for F-release"
Bug 17743363: Preliminary subtypes should be removed from F-release

This reverts commit 45c917e238.

Change-Id: I5e91a7fd0efdc16e140a91fab6300bd8ba9cd6c7
2015-01-12 16:35:54 -08:00
Jean Chalard
8e235191dd Fix moving the cursor inside composition in lang w/o spaces
Also introduce the cursor move event, which we needed to do
anyway

Bug: 18827118
Change-Id: I30e994764c095b4423b874dc05d1bbedc0de592f
2014-12-22 17:47:33 +09:00
Tadashi G. Takaoka
8bc644de64 Revert "Fix unit test failure due to translation glitch"
This reverts commit f8705dd2bd.

Change-Id: I7ddc1eced8109ff0bb50eb8a217db0d276848a1e
2014-12-17 06:14:49 +00:00
Jatin Matani
bc4ae6bdc0 Passing account info to dictionaryFacilitator
Attempt to use dictionary facilitor without invoking
preference manager. Instead use account from settings only when
things are being reset/changed. Discussion forked from ag/591663

Overall, the idea here is to maintain an account information
inside dictionary groups. Reset the dictionary groups if
account changes (the way we do for locale). Since only user
history dictionary is currently affected, the check to reset user
history dictionary also includes the check to verify the account.
For other things remain the same.

SettingsValues holds the current account (and is updated if prefs change
due to change in account settings). The updated settings are then
propagated to dictionary facilitator via LatinIME#loadSettings.

Bug:18104749,18469539
Change-Id: I553e776e7ea125d0fb7a1fe70a4c7eb0b2277fb8
2014-12-16 15:56:00 -08:00
Tadashi G. Takaoka
4934a88b61 Make LanguageOnSpacebarHelper as utility class
Change-Id: I546f3b1943999a41803222bd14f9ddd23aa87a51
2014-12-11 14:22:21 +09:00
Tadashi G. Takaoka
be819dbe2b Revert "Add keyboard margin options to place the keyboard dynamically."
This reverts commit 8584db1461.

Bug: 18675223
Bug: 18675476
Change-Id: I4e25d87ac261c44b1943df832115f8cca690103a
2014-12-09 17:53:24 +09:00
Jatin Matani
2bdd5290a9 Merge "Hook for fetching sync content from UserHistoryDict" 2014-12-08 20:00:10 +00:00
Tadashi G. Takaoka
3dca77ec07 Merge "Refactor KeysCache to UniqueKeysCache" 2014-12-08 08:33:38 +00:00
Andy Wang
8584db1461 Add keyboard margin options to place the keyboard dynamically.
Keyboard location and location can now be set in the debug options
section.

Change-Id: I87c5a1d679489e12dccf26632c399af28087629e
2014-12-05 16:21:20 +09:00
Adrian Velicu
11a3965f8c Fix a misspelled method name
Change-Id: I1151dc1d5db3986a97daf68c1e387dbc2e4610dc
2014-12-02 12:53:56 +09:00
Tadashi G. Takaoka
01d54002b3 Refactor KeysCache to UniqueKeysCache
Change-Id: I8e3c4705c705a1c6e05e9112211d7012912d7e41
2014-11-27 15:44:22 +09:00
Jatin Matani
12d63820d4 Hook for fetching sync content from UserHistoryDict
Add API to ExpandableBinaryDictionary to dump content
from a given dictionary. We use this for dumping data
for sync process.

Refactored UserHistoryDictionaryTests to scrap out the util
methods for testing. These utility methods would be used
for testing sync + user dictionary code in LatinIMEGoogleTests

Bug:18106539
Change-Id: I357f9192ea1bd69a526d0b620c25616a2e8e9d5b
2014-11-26 11:17:24 -08:00
Tadashi G. Takaoka
8a711f2a54 Remove unneeded Context argument
Change-Id: Ib34931836a617d0dc049fb3c9ae6686374ec8c12
2014-11-21 12:49:04 +09:00
Tadashi G. Takaoka
f8705dd2bd Fix unit test failure due to translation glitch
Once the translation strings are updated, the uni test starts
failing. Then this CL should be reverted.

Change-Id: I884663feaa53998a98dd0e488ae8e3e6d0ad4ffd
2014-11-20 17:05:21 +09:00
Jean Chalard
a2cb2f36a6 Make the typed word a SuggestedWordInfo
That allows to carry the language information in an
accurate manner.

Bug: 18063142
Change-Id: I0bca8981372ae10648274095b18b26a3686b762b
2014-11-20 13:57:01 +09:00
Tadashi G. Takaoka
cae324c561 Cleanup StringAndJsonUtilsTests
Change-Id: I7d35492c439c9419915251387b0c12e205740586
2014-11-19 19:08:13 +09:00