nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30458 commits 1 branch 0 tags 363 MiB
Commit graph

4514 commits

Author SHA1 Message Date
Jean Chalard
0de7a6d1a2 [CB15] Remove a redundant variable. 
This is a tiny bit slower, but probably unnoticeable.
Still, it gains some performance in other places,
saves memory, and more importantly makes for simpler
code, so it's certainly better.

Change-Id: Id1ab4f73f71acd73f5920bc729817abd22cf0d07
 2014-03-27 16:47:27 +09:00
Keisuke Kuroyanagi
3c38e1f269 Merge "Fix: NPE in isValidWord after dictionaries are closed." 2014-03-27 03:12:07 +00:00
Keisuke Kuroyanagi
7b516d496d Fix: NPE in isValidWord after dictionaries are closed. 
Bug: 13650542
Change-Id: I1bdc838fca48d6ef12db5e70d40273d1236128d1
 2014-03-27 12:03:58 +09:00
Jean Chalard
071b9c1a05 Merge "[CB14] Implement backspace in the combiner chain" 2014-03-25 10:46:32 +00:00
Jean Chalard
1079665c3c [CB14] Implement backspace in the combiner chain 
Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc
 2014-03-25 17:57:03 +09:00
Keisuke Kuroyanagi
adfb262797 Remove logic related to dictionary loading from LatinIME. 
Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.

Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
 2014-03-25 15:35:20 +09:00
Yohei Yukawa
f1f5ed542d Check null before passing to Integer.parseInt 
Just after user data is cleared, user preference associated with
PREF_KEYBOARD_LAYOUT is always empty. In such case, we might
want to return the default value immediately, rather than
calling Integer.parseInt(null) and catching NumberFormatException
unnecessarily.

BUG: 13472379
Change-Id: I8dca9a22780d057013c032bd1f56e730dcada3ce
 2014-03-24 20:54:03 +09:00
Jean Chalard
d36cbc44e4 [CB13] Remove an unused method. 
Change-Id: If4d2fa9c6499ce9b2427cea424abd497ec4a966b
 2014-03-24 17:44:36 +09:00
Jean Chalard
cbed462d19 [CB12] Reset the combining state when resetting the composer 
Bug: 13406701
Change-Id: I490574b7ca4b953f67dd2c0ef97401297fade0a4
 2014-03-24 17:44:31 +09:00
Jean Chalard
7f0e5fa66c Merge "[CB11] Get the result of the combination" 2014-03-24 05:33:34 +00:00
Jean Chalard
1dda9107ca Merge "Rework the logic that tells if the cursor touches words" 2014-03-20 14:35:19 +00:00
Jean Chalard
835965a75e [CB11] Get the result of the combination 
Change-Id: I165ec4a24f5b1334d55c14948e4d942ec40eb33b
 2014-03-20 23:33:12 +09:00
Jean Chalard
72b67f6541 Rework the logic that tells if the cursor touches words 
Bug: 13312942
Change-Id: I6be6a558bbc6c88508150f9c25cadbd0240ff88e
 2014-03-20 23:16:53 +09:00
Jean Chalard
4df6bc0853 Merge "[CB10] Add an event for string input" 2014-03-20 11:34:16 +00:00
Jean Chalard
058a38988b [CB10] Add an event for string input 
Change-Id: Ie5da6c73d4df4553067c58cd0dce9abb34534250
 2014-03-20 19:47:01 +09:00
Keisuke Kuroyanagi
7c20f140e0 Merge "Remove unused partial commit." 2014-03-20 09:54:15 +00:00
Keisuke Kuroyanagi
5a0381f7d0 Remove unused partial commit. 
Change-Id: Ia9341a5cb24947d93056810890d94c1f66481d8c
 2014-03-20 18:47:45 +09:00
Jean Chalard
437dbbcfee Merge "[IL127] Move the double space countdown to InputLogic" 2014-03-20 09:07:49 +00:00
Tadashi G. Takaoka
aacfa31c8e Merge "Remove reference of KeyboardTextsSet from SpacingAndPunctuations" 2014-03-20 08:46:11 +00:00
Tadashi G. Takaoka
44f144ab3a Remove reference of KeyboardTextsSet from SpacingAndPunctuations 
Change-Id: I76a8fcbd2466bcaf9cd85501af270db5aa913999
 2014-03-20 17:14:43 +09:00
Jean Chalard
f2bb15b0ab [CB09] Pass events through the combiner chain 
Bug: 13406701
Change-Id: I4696f145478afdd132314b7d3c148c3a9ca11c9c
 2014-03-20 16:59:29 +09:00
Jean Chalard
7ede642df4 [CB08] Create a combiner chain in the word composer. 
Bug: 13406701
Change-Id: I3b9f75de9283f76366d1bef7e14a8f22f2186669
 2014-03-20 14:27:55 +09:00
Tadashi G. Takaoka
f96bffa69e Suppress important notice when its title message is empty 
Bug: 13422608
Change-Id: Ied16e87381e82d8539269ddd90d737f80c2a94c0
 2014-03-20 11:48:28 +09:00
Tadashi G. Takaoka
14e908c348 Remove unused argument in SuggestionStripLayoutHelper 
Bug: 13461039
Change-Id: I3f6227bd56fb81021aaacf0e901eab8a9e91d4a1
 2014-03-20 11:06:55 +09:00
Jean Chalard
350d73932d [IL127] Move the double space countdown to InputLogic 
Bug: 8636060
Change-Id: Ie193b747bd9d0b5ba6a986b9a3c746c2182742ed
 2014-03-19 17:47:03 +09:00
Jean Chalard
554346e94c [IL126] Move a setting value to SettingsValues 
Bug: 8636060
Change-Id: I7cb082df13a10cf5a3aa5786e6a9599376652dee
 2014-03-19 17:47:03 +09:00
Jean Chalard
46e17983c6 [IL125] Remove arg to onPickSuggestionManually 
Bug: 8636060

Change-Id: I55332c22897e97148621cbd367acf5175b5b3d04
 2014-03-19 17:47:03 +09:00
Tadashi G. Takaoka
1325ddbae3 Merge "Guard possible NumberFormatException" 2014-03-18 07:26:18 +00:00
Tadashi G. Takaoka
d2c6151d4d Guard possible NumberFormatException 
Bug: 13472379
Change-Id: Ib7640b3d8816d8d7fb4747d2288eedd94bc49b06
 2014-03-18 15:40:43 +09:00
Jean Chalard
1110adad11 [CB07] Small refactoring 
Bug: 8689779
Change-Id: I2cf10c690c7e4a9c6bf27211d1fccc1f9d4a9249
 2014-03-17 21:26:36 +09:00
Jean Chalard
5eac728b4a [CB06] Fix a design error. 
The event interpreter should intervene later, after decoding.
Decoding should happen first, and then the Event should
be passed to the InputLogic.

For the time being, we will leave the (unused) EventInterpreter
class and its friends, because we'll use them again later.

Bug: 13406701
Change-Id: I7582d486724311e39e6692e606cca50c78800643
 2014-03-17 20:49:29 +09:00
Jean Chalard
5a1e351751 Merge "[CB04] Add an event array to WordComposer." 2014-03-14 04:29:59 +00:00
Jean Chalard
f8accd8839 [CB04] Add an event array to WordComposer. 
Bug: 13406701
Change-Id: I9ecd2709c8f1c678a85b0cfaf7c5ed4f78459821
 2014-03-14 12:44:49 +09:00
Tadashi G. Takaoka
a9c1a3da63 Fix clipped important notice message on tablet 
Bug: 13461039
Change-Id: I710bf10c9cbc202c7f6ee39ab4c8b9d699741a81
 2014-03-14 12:32:38 +09:00
Jean Chalard
750cd48981 [CB03] Pass whole events to the various input logic handlers. 
Bug: 13406701
Change-Id: I0a0e4e0b3357f116e1b915c548dee4575e300c92
 2014-03-13 19:35:54 +09:00
Jean Chalard
a79a3265db [CB02] Pass an Event to onCodeInput. 
Bug: 13406701
Change-Id: Id82e9aab6544ca308e6ac6dee2cfa018b9ce2d8f
 2014-03-13 18:41:02 +09:00
Jean Chalard
e93a7232d1 Don't reset the value needed before it's used 
Nice recipe for failure

Bug: 13387534
Change-Id: Ida1978449c1997587b2ec0955c5c94fcef336121
 2014-03-10 15:55:15 +09:00
Keisuke Kuroyanagi
32326a9d7a Merge "Move DictionaryOptions from FusionDictionary to FormatSpec." 2014-03-07 10:42:18 +00:00
Keisuke Kuroyanagi
e137ec0a91 Introduce SuggestionResults and use it for predictions. 
Bug: 8187060
Bug: 13333066
Change-Id: I1ead897024508b7e40fbd93af7d14bfe74b93826
 2014-03-07 19:36:19 +09:00
Keisuke Kuroyanagi
a103e29d00 Merge "Separate WeightedString from FusionDictionary." 2014-03-07 09:07:26 +00:00
Tadashi G. Takaoka
ff8405cdfb Add ActualKeyboardBuilder for testing keyboard layouts 
Bug: 13017434
Change-Id: I38b1f5c261ea1f3ff312c780d7d9b5fe3fba8aaf
 2014-03-07 17:29:58 +09:00
Keisuke Kuroyanagi
3ad4af2354 Move DictionaryOptions from FusionDictionary to FormatSpec. 
Bug: 8187060
Bug:13035567

Change-Id: Id4f45e589521ae98c926a4c0607be10ce1a983f2
 2014-03-06 18:53:09 +09:00
Keisuke Kuroyanagi
516f86815d Separate WeightedString from FusionDictionary. 
Bug: 8187060

Change-Id: I40c1dafca3eb52244c64fdb4c1db30a56385d678
 2014-03-06 18:53:06 +09:00
Jean Chalard
3892991b80 Merge "[IL124] Remove the KeyboardSwitcher arg to onCodeInput" 2014-03-06 09:15:26 +00:00
Jean Chalard
4da06b9a19 Merge "Correctly update the suggestion strip on non-resumable word" 2014-03-06 08:54:44 +00:00
Keisuke Kuroyanagi
d93eb680c4 Merge "Use BinaryDictionaryUtils to read dictionary header." 2014-03-06 07:32:07 +00:00
Jean Chalard
a1bf550294 [IL124] Remove the KeyboardSwitcher arg to onCodeInput 
Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
 2014-03-06 14:20:41 +09:00
Jean Chalard
db38d5cf63 [IL123] Put the settings values inside the transaction 
A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.

Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
 2014-03-06 14:20:37 +09:00
Jean Chalard
29881854bc [IL122] Put the code, x and y in the transaction 
Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
 2014-03-06 12:50:07 +09:00
Keisuke Kuroyanagi
de36b47d29 Use BinaryDictionaryUtils to read dictionary header. 
Bug: 8187060
Bug:13035567
Change-Id: I90a5e0665c367f5a1bd786f4babf0d03e79e68fa
 2014-03-05 19:42:53 +09:00