Commit graph

11745 commits

Author SHA1 Message Date
Ken Wakasa
09a6dd1f77 am 95c4d269: Merge "Revert "Straighten the dead char implementation.""
* commit '95c4d26994f944c8a3a4e0673a3156183ef0228b':
  Revert "Straighten the dead char implementation."
2014-08-27 15:16:19 +00:00
Ken Wakasa
95c4d26994 Merge "Revert "Straighten the dead char implementation."" 2014-08-27 15:07:52 +00:00
Ken Wakasa
0ba6bcb16d Revert "Straighten the dead char implementation."
This reverts commit 5ef447aeea.

Reverting because this broke a bunch of unit tests -- https://sponge.corp.google.com/target?id=b6439742-099e-46cb-8f00-d0c602a4d9bb&target=com.google.android.inputmethod.latin.tests&searchFor=&show=FAILED&sortBy=STATUS

Change-Id: Ibbd9e11372993f62e630fd9da37158ffcf47c17a
2014-08-27 15:07:28 +00:00
Jean Chalard
220ee286db am 4204d598: Merge "Straighten the dead char implementation."
* commit '4204d59864b8855dd7c926c309abc6afc8ae423f':
  Straighten the dead char implementation.
2014-08-27 13:02:18 +00:00
Jean Chalard
4204d59864 Merge "Straighten the dead char implementation." 2014-08-27 12:54:49 +00:00
Tadashi G. Takaoka
e509cc6960 am 8b5788d7: am 68a2a69a: am 37beaf15: Simplify onComputeInsets of LatinIME
* commit '8b5788d72b9025203582546255288dfb8a02dcf5':
  Simplify onComputeInsets of LatinIME
2014-08-27 10:48:54 +00:00
Tadashi G. Takaoka
8b5788d72b am 68a2a69a: am 37beaf15: Simplify onComputeInsets of LatinIME
* commit '68a2a69ae35352650a4c6dfc0b0c69069c4a1e1d':
  Simplify onComputeInsets of LatinIME
2014-08-27 10:44:51 +00:00
Tadashi G. Takaoka
37beaf1529 Simplify onComputeInsets of LatinIME
This CL expands SoftInputWindow to the entire screen. Thus a key
review backing view is eliminated and onComputeInsets() gets
simplified too.

Bug: 17212702
Bug: 10841052
Bug: 10541453
Change-Id: I2d859f4e4698c64cabe399000821f13bab729996
2014-08-27 19:20:38 +09:00
Yohei Yukawa
f33d28c9f7 am 00042cb4: am c925ca43: am 97681ebd: Set highlight color along with the commit indicator
* commit '00042cb453ae72d2f76661c6a712210e2ecd79b4':
  Set highlight color along with the commit indicator
2014-08-27 10:07:54 +00:00
Ken Wakasa
4db998d65a am d8380fdb: Merge "resolved conflicts for merge of 8159336b to master"
* commit 'd8380fdba04d82566c623f1efbcb86aa33d9e401':
  Set the text bgcolor only when CursorAnchorInfo is available
2014-08-27 10:07:53 +00:00
Yohei Yukawa
00042cb453 am c925ca43: am 97681ebd: Set highlight color along with the commit indicator
* commit 'c925ca43a6e0b3175feb002ce6b5577ef7d66507':
  Set highlight color along with the commit indicator
2014-08-27 10:01:24 +00:00
Ken Wakasa
6da1c674fd resolved conflicts for merge of 8159336b to master
Change-Id: I9dd726593c6768b1db35305935ee69b0937358ef
2014-08-27 18:55:39 +09:00
Yohei Yukawa
2b06811843 am 8a413a2a: am 00d140ca: am a475c854: Introduce a mechanism to hide the indicator speculatively
* commit '8a413a2a62788cef59e2cb0a4362392e036cd7be':
  Introduce a mechanism to hide the indicator speculatively
2014-08-27 09:53:00 +00:00
Ken Wakasa
1c356ebee6 am c1596086: resolved conflicts for merge of 0268f736 to master
* commit 'c1596086d3de32b66a382acf2c9b5fa00779008f':
  Introduce commit/add-to-dictionary indicators
2014-08-27 09:52:59 +00:00
Yohei Yukawa
8a413a2a62 am 00d140ca: am a475c854: Introduce a mechanism to hide the indicator speculatively
* commit '00d140caeb02e2e68f5b2cf7b71d349e1ad4cb5c':
  Introduce a mechanism to hide the indicator speculatively
2014-08-27 09:48:34 +00:00
Ken Wakasa
c1596086d3 resolved conflicts for merge of 0268f736 to master
Change-Id: Ib89ef55a8752f9b5e357eed3a05c79dd28d0ec0e
2014-08-27 18:41:31 +09:00
Jean Chalard
5ef447aeea Straighten the dead char implementation.
This now supports all cases, including cases not supported by
the framework.
Now rebased on top of the right change, and renamed

Change-Id: I7886f0dcbb86cdb4dccec09aa7c52ad339680e04
2014-08-27 17:59:39 +09:00
Yohei Yukawa
97681ebdf1 Set highlight color along with the commit indicator
With this CL, the text highlight color is applied
when the commit indicator is displayed.

Note that the underline is not rendered when the
background color is enabled. This is a known issue.

Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
2014-08-27 01:41:16 -07:00
Yohei Yukawa
29200b0abe Set the text bgcolor only when CursorAnchorInfo is available
When CursorAnchorInfo is unavailable, we shouldn't try to show
the commit indicator and set the text highlight color.

With this CL, RichInputConnection can be used to track if the
application responded that it does support CursorAnchorInfo or
not.  This result will be taken into consideration when
InputLogic needs to determine whether the commit indicator
should be displayed or not.

Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
2014-08-27 01:30:45 -07:00
Yohei Yukawa
a475c85480 Introduce a mechanism to hide the indicator speculatively
This is an optional optimization to reduce the UI latency.

Imagine that the commit indicator is now displayed and the
composing text is being updated, it is highly likely that
the commit indicator will disappear unless the application
rejects the setComposingText request.

If we assume that the application will accept the new
composing text without any modifications, we can hide the
indicator without waiting for the arrival of new
CursorAnchorInfo event.

This optimization isn't dangerous because we can show the
indicator again when we receive new CursorAnchorInfo event
and the assumption is turned out to be invalid.

Change-Id: Id59c6607a1029782410611e768791af9984f14ac
2014-08-26 23:42:53 -07:00
Yohei Yukawa
bea17c49ec Introduce commit/add-to-dictionary indicators
This CL introduces commit/add-to-dictionary indicators.

Note that the text is not yet highlighted when the commit
indicator is displayed. It will be addressed in subsequent
CLs.

Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
2014-08-26 21:20:27 -07:00
Ken Wakasa
090b72a11a am 4660ecaa: Merge "Fix a bug where mic/emoji key wouldn\'t work."
* commit '4660ecaa44d4ca141ba53552d9533ea60d3e8323':
  Fix a bug where mic/emoji key wouldn't work.
2014-08-26 13:35:45 +00:00
Ken Wakasa
4660ecaa44 Merge "Fix a bug where mic/emoji key wouldn't work." 2014-08-26 13:30:15 +00:00
Jean Chalard
e38043849e Fix a bug where mic/emoji key wouldn't work.
Bug: 17272902
Bug: 17269948
Change-Id: I561609fa84a6265f8148db7d2411bc1fd38dd163
2014-08-26 22:06:21 +09:00
Jean Chalard
ebf4a3e792 am 96522da9: am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear.
* commit '96522da9eb584c173083af677f47cdbc35d81436':
  Fix a bug where the top prediction would disappear.
2014-08-26 12:47:04 +00:00
Jean Chalard
96522da9eb am 2a2d324e: am 8380f921: Fix a bug where the top prediction would disappear.
* commit '2a2d324eb627807a9d09b491fbb4ac78ffb253fc':
  Fix a bug where the top prediction would disappear.
2014-08-26 12:37:17 +00:00
Jean Chalard
8380f921f7 Fix a bug where the top prediction would disappear.
This is because prediction can't be easily distinguished in
style. This fixes the bug by simulating the right members,
but some refactoring should be done to remove useless
booleans.

Bug: 17271923
Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
2014-08-26 20:35:59 +09:00
David Faden
e4fb843a7f am 9cf69a45: Adds documentation for a few methods.
* commit '9cf69a45b24646bdd4bf365afe4e8e9fb30f9a22':
  Adds documentation for a few methods.
2014-08-26 11:15:07 +00:00
David Faden
9cf69a45b2 Adds documentation for a few methods.
Change-Id: I6bdae25a8b81cdac931f2591f33570b01e34fb2c
2014-08-26 08:08:24 +00:00
Keisuke Kuroyanagi
893c1aab3e am bf6fc495: Merge "Get dynamic dict stats via DictionaryFacilitator"
* commit 'bf6fc4953b6529274f94ecfef967faece8a0003d':
  Get dynamic dict stats via DictionaryFacilitator
2014-08-25 11:32:57 +00:00
Keisuke Kuroyanagi
bf6fc4953b Merge "Get dynamic dict stats via DictionaryFacilitator" 2014-08-25 11:24:54 +00:00
Yohei Yukawa
029833d30e am d8dfac6d: am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
* commit 'd8dfac6dcb16f01bb20c7e1ed669b981835a2e1f':
  Use more descriptive names for some internal fields
2014-08-25 10:24:32 +00:00
Yohei Yukawa
d8dfac6dcb am abf05cc0: am fdfe73ff: Merge "Use more descriptive names for some internal fields" into lmp-dev
* commit 'abf05cc0da1ead7e270a7c99bf9f000dabf91f5b':
  Use more descriptive names for some internal fields
2014-08-25 10:16:11 +00:00
Jean Chalard
ec84eef165 am 1a31d784: Merge "Introduce onEvent() to improve testability"
* commit '1a31d784cdf6c651d1ee6001dcbd3660d93b4945':
  Introduce onEvent() to improve testability
2014-08-25 10:06:55 +00:00
Jean Chalard
1a31d784cd Merge "Introduce onEvent() to improve testability" 2014-08-25 09:57:42 +00:00
Yohei Yukawa
fdfe73ff1f Merge "Use more descriptive names for some internal fields" into lmp-dev 2014-08-25 09:50:59 +00:00
Tadashi G. Takaoka
54ca9dd998 am d147db87: am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard
* commit 'd147db876365066e8989764807f532c0865349e3':
  Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:43:38 +00:00
Tadashi G. Takaoka
d147db8763 am c500700f: am 19dd34a0: Show view even when IME is explicitly shown with physical keyboard
* commit 'c500700faec11b7a6d54a821009be4d657c43394':
  Show view even when IME is explicitly shown with physical keyboard
2014-08-25 09:35:08 +00:00
Jean Chalard
781d75126b am ee8ebeec: Merge "Fix unit tests"
* commit 'ee8ebeecbf80b9cccc5569570112634b49c45b53':
  Fix unit tests
2014-08-25 09:34:30 +00:00
Yohei Yukawa
a61b7245b0 Use more descriptive names for some internal fields
This CL clarifies that delay parameters are specified with
milliseconds.

Change-Id: I401a60b8c09c2a04201af5b74babcdb091c07f4a
2014-08-25 02:28:01 -07:00
Jean Chalard
ee8ebeecbf Merge "Fix unit tests" 2014-08-25 09:26:17 +00:00
Jean Chalard
dc110b2a6a Fix unit tests
Change-Id: I48bfa4e4dd80f36d2fe0a1e9d2a2706533cc722e
2014-08-25 18:19:00 +09:00
Tadashi G. Takaoka
ca9e970c7c am 7defe926: am 4a782da3: am f145fff0: Merge "Fix NPE when pressing ALT key" into lmp-dev
* commit '7defe926ca0eed2a18665cd0e4bf2ec305a03879':
  Fix NPE when pressing ALT key
2014-08-25 09:10:40 +00:00
Yohei Yukawa
8787d7f154 am 4587b135: am 2d508203: am 8681287c: Fix build due to an illegal character
* commit '4587b135be7f184bdf60f8e4113e81070ce2d825':
  Fix build due to an illegal character
2014-08-25 09:10:38 +00:00
Yohei Yukawa
34439d70e2 am 8c7daa82: am 02716083: am 5eebaddc: Merge "Dismiss "Add to dictionary" hint with non-special char event" into lmp-dev
* commit '8c7daa829a3a81b3a803048d7af82383a8b48aed':
  Dismiss "Add to dictionary" hint with non-special char event
2014-08-25 09:10:37 +00:00
Yohei Yukawa
aa19b7d304 am a5687ee9: am b65a1e46: am 2c4cce8d: Merge "Introduce #shouldShowAddToDictionaryHint" into lmp-dev
* commit 'a5687ee9f7c3eff7eb8b97ebfb12fc1d93b9e41c':
  Introduce #shouldShowAddToDictionaryHint
2014-08-25 09:10:35 +00:00
Tadashi G. Takaoka
4cc44f9f62 am ef7c701e: am 129af927: am 5e7a6fe0: Merge "Fix the bottom row of tablet keyboard layout" into lmp-dev
* commit 'ef7c701e72d9ccc735ce77829cb55cf46ed25339':
  Fix the bottom row of tablet keyboard layout
2014-08-25 09:10:34 +00:00
Yohei Yukawa
9a0b9aba64 am f6f55add: am e0d00803: am 4a71d2c4: Allow to add/remove background color to/from the committed text
* commit 'f6f55add175bcd37710764afd05052974167bd1d':
  Allow to add/remove background color to/from the committed text
2014-08-25 09:10:32 +00:00
Yohei Yukawa
3d057b402d am c06c6e42: am 7d146cdb: am cd6ef9a8: Indroduce SuggestedWords#getTypedWordInfoOrNull
* commit 'c06c6e42ad24e02a5433dcb44dba452d1cfb3f4f':
  Indroduce SuggestedWords#getTypedWordInfoOrNull
2014-08-25 09:10:31 +00:00
Tadashi G. Takaoka
7defe926ca am 4a782da3: am f145fff0: Merge "Fix NPE when pressing ALT key" into lmp-dev
* commit '4a782da382b83164ea5c23c771b771e73bbe31b3':
  Fix NPE when pressing ALT key
2014-08-25 08:25:42 +00:00