Commit graph

1220 commits

Author SHA1 Message Date
Tadashi G. Takaoka
7a3de4dca9 Add null analysis annotation to CollectionUtils
Change-Id: I3a610b037d6d1431cced3ea193171108bd5a040d
2014-10-27 18:30:29 +09:00
Keisuke Kuroyanagi
3844f74aff Fix: deleted PtNode handling in v403.
If a word is once deleted, the word never gets into the
personalized dictionaries due to this bug.

Change-Id: Ife4e3fe1ba0615b4135e6291d2151b0db7d3f940
2014-10-27 15:32:05 +09:00
Jean Chalard
9afac3319c Merge "Add tests for type through recorrection" 2014-10-24 06:43:20 +00:00
Ken Wakasa
88a92103bc Fix unit test failure due to IllegalAccessError
java.lang.IllegalAccessError: Class ref in pre-verified class resolved
to unexpected implementation because of latinime-common reference added
two times.

Change-Id: I4ce1185c10b9a217022e830b02aec4f1ea50f2eb
2014-10-24 15:24:30 +09:00
Ken Wakasa
9342484e8d Move Constants.java to the latin.common package
Our intention is to have classes of latinime-common under the common
package as much as we can.

Change-Id: I76efbbbe7bebf1a4aa943715cdff64f91675e20d
2014-10-23 20:27:37 +09:00
Tadashi G. Takaoka
92d073c2fd Remove unused import and method
Bug: 18003991
Change-Id: Id6b67bf66b397301e5186826dba2b60df9cb4c65
2014-10-23 16:37:07 +09:00
Keisuke Kuroyanagi
16cc3992d7 Use trigrams for personalization dict.
5Bug: 14425059
Change-Id: I73cf6904e569d60996a3b079f16ea6df0cb90f02
2014-10-23 14:32:45 +09:00
Tadashi G. Takaoka
d3a4c51324 Fix Javadoc and null analysis related warnings
This CL also adds @SuppressWarning("unused" to java-overridable package.

Bug: 18003991
Change-Id: If70527e30654384705d7a814f5efd181d9f539e1
2014-10-23 09:58:42 +09:00
Tadashi G. Takaoka
924b8fd0fa Merge "Enable preliminary subtypes for F-release" 2014-10-23 00:19:03 +00:00
Ken Wakasa
54a1b8ec54 Add latinime-common local lib
This is just a placeholder in this CL. It will be shared by LatinIME,
dicttool, and tests.

Change-Id: I6fb3516a5061555f6f24b29141c2871d2319b023
2014-10-22 19:26:21 +09:00
Tadashi G. Takaoka
45c917e238 Enable preliminary subtypes for F-release
Bug: 17743363
Change-Id: I098ae6e21a7f2a1ceed1d206740a2d12e1ef7d99
2014-10-22 18:52:53 +09:00
Jean Chalard
7e930bfb3a Add tests for type through recorrection
Also introduce some helper methods

Change-Id: I0f99733a4b7f0318b2b07217b614c19ea98859fc
2014-10-22 17:05:10 +09:00
Keisuke Kuroyanagi
1249395563 Merge "Support ngram entry migration." 2014-10-22 02:36:52 +00:00
Keisuke Kuroyanagi
c9865785f4 Support ngram entry migration.
Bug: 14425059
Change-Id: I98cb9fa303af2d93a0a3512e8732231c564e3c5d
2014-10-22 11:31:16 +09:00
Yohei Yukawa
66d30a4b22 Remove BuildCompatUtils.VERSION_CODES_LXX
Finally it is turned out to be a XXL-size Lollipop.

Change-Id: Icbd22506be9de514eba287cdd8d97fbfd070ac09
2014-10-22 01:29:58 +09:00
Tadashi G. Takaoka
5f00fe09e9 Fix some compiler warnings
This CL fixes the following compiler warnings.

- Indirect access to static member
- Access to a non-accessible member of an enclosing type
- Parameter assignment
- Method can be static
- Local variable declaration hides another field or variable
- Value of local variable is not used
- Unused import
- Unused private member
- Unnecessary 'else' statement
- Unnecessary declaration of throw exception
- Redundant type arguments
- Missing '@Override' annotation
- Unused '@SuppressWarning' annotations

Bug: 18003991
Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
2014-10-21 19:28:37 +09:00
Adrian Velicu
05172bf1a5 Renaming "blacklist" flag to "possibly offensive"
No behaviour changes.
Unified the overloaded FusionDictionary::add method to always take an
isPossiblyOffensive argument.

Bug: 11031090
Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
2014-10-21 11:51:47 +09:00
Keisuke Kuroyanagi
1085fef8d0 Change entry count limit.
Unigram 10K, Bigram 30K, Trigram 30K.

Change-Id: Ibd19c6a2b618499df1c70000bad7b47498187f0a
2014-10-20 15:01:49 +09:00
Tadashi G. Takaoka
a97bae4e8b Fix missing Telugu letters
This CL adds missing the following Telugu letters
- U+0C4A: TELUGU VOWEL SIGN O
- U+0C1E: TELUGU LETTER NYA
And also reorganizes some letter reasonably.

Bug: 10028759
Change-Id: If7fd3854ffab8484dbe6ced0ff2ed52be838e44d
2014-10-17 19:21:59 +09:00
Keisuke Kuroyanagi
f4928ad4dd Merge "Update useless n-gram entry detection logic during GC." 2014-10-15 21:44:45 +00:00
Keisuke Kuroyanagi
3601c214f8 Update useless n-gram entry detection logic during GC.
Bug: 14425059
Change-Id: Ib939deae5b60167751dee07965bb1ef1a43c4625
2014-10-15 20:43:27 +09:00
Jean Chalard
9ddbee8570 Add the first gesture unit tests.
At last I found a simple way to do it !

Bug: 8845843
Change-Id: I4dd3bf987b58e29a44cf0d7389d294657a33abe1
2014-10-15 19:04:06 +09:00
Sandeep Siddhartha
56ad6f35b3 Merge "Add label and icon to the test app" 2014-10-15 00:35:27 +00:00
Sandeep Siddhartha
b17a3bc4e8 Move sync policy related code out of account settings
Bug: 17981687
Bug: 17464069
Change-Id: I0ae3400564fd346cc84af74dfef65f01cc1ce6a8
2014-10-14 13:39:28 -07:00
Sandeep Siddhartha
29f0b0f578 Add label and icon to the test app
This helps us easilty distinguish between the different test targets visually.

Bug: 17946996
Change-Id: I822a29cfb9b5bc5df3d93a884ffdf7d050737e04
2014-10-14 10:17:35 -07:00
Keisuke Kuroyanagi
d1471ee053 Merge "Remove shouldBlockAutoCorrectionBySafetyNet" 2014-10-14 10:52:32 +00:00
Keisuke Kuroyanagi
29b4f7aa67 Remove shouldBlockAutoCorrectionBySafetyNet
Bug: 13756409

[Category diff]
+1      27
-1       0
+2       0
-2       0
+3       0
-3       1
+4      11
-4       0
+5      51
-5       0
+6       0
-6      38
+7       0
-7      50

[Weighted category diff]
+1      28
-1       0
+2       0
-2       0
+3       0
-3       1
+4      11
-4       0
+5      51
-5       0
+6       0
-6      39
+7       0
-7      50

show diff for ./en_user_log_phones_2011_08.csv
+1       4
+4       5
+5       7
-6       9
-7       7

The increase of false positives comes from the spaceless
typing test cases that are synthetic data.

Change-Id: I4ea77aa56ebfaa5518c71107169e1d2332de6327
2014-10-14 11:20:33 +09:00
Sandeep Siddhartha
19084d076a Cleanup LoginAccountUtils
Bug: 17464068
Change-Id: Icf994a7582491afebc5db522c127a30d079ce05c
2014-10-13 12:23:22 -07:00
Sandeep Siddhartha
d9015233f5 Set up a sync preference and policy for syncing [2]
- Adds a preference for enabling sync, which controls the sync behavior
- Make the ProductionFlags depend on appropriate flags to guarantee that
  we don't mess things when flipping some flags
- Preferences now control the "syncable" property of the provider
  thereby controlling the policy and when this entry shows up in
  system settings.

Bug: 17464069
Change-Id: I1d58351188518c1ae9f1f9e147b5ea15d32a3427
2014-10-10 16:03:54 -07:00
Sandeep Siddhartha
1e10d29bc8 Don't restore device specific preferences
There are two categories of preferences:
1. That are part of the default shared preference
   They were all getting backed up and restored.
   Added a blacklist to not restore some of these.
   e.g. current account

2. That are in a non-default shared preference file.
   These are not getting backed up currently, but added a specific
   local preference file for all such preferences.

Bug: 17288591
Change-Id: I2f748be971a2337543e5014434aa39313fd1e1d8
2014-10-10 10:49:32 -07:00
Tadashi G. Takaoka
4f17f3df46 Fixing keyboard theme selection
Bug: 17937287
Change-Id: I476045980843c5897820cd544daea06fa991acb5
2014-10-10 17:42:03 +09:00
Jatin Matani
eaf517ffea Merge "Changes related Sync Engine library that communicates to cloud server" 2014-10-09 18:06:32 +00:00
Jean Chalard
bc18005948 Always show the typed word in recorrections.
Bug: 11330140
Bug: 17875601
Bug: 17623275
Change-Id: Ie4620f36f312c54c7b01b5f6cbdb0bc9171b6179
2014-10-09 17:54:58 +09:00
Jatin Matani
db1b736446 Changes related Sync Engine library that communicates to cloud server
This change updates some of the code that the library uses
to communicate with the cloud server
Specifically :
- Update BlockingHttpClient to use template ResponseProcessor
- Update HttpUrlConnectionBuilder to setAuthToken for HttpUrlConnection

Bug: 17464069
Bug: 17464805

Change-Id: I7d7b58dff594b920162f799d102e8582ff9fe6a4
2014-10-09 00:01:32 -07:00
Jean Chalard
81a5a10476 [ML19] Actually switch the language when appropriate
That is, when auto-correcting or when manually picking.
This is not great, but it's a good starting point.

Bug: 11230254
Change-Id: I07627f48e2de1c28053d6572c7c72625808ec79c
2014-10-09 13:13:25 +09:00
Jean Chalard
38ec825ef8 [ML16] Remove DictionaryFacilitator.getLocale()
Bug: 11230254
Change-Id: Ife99df42bc145fbd2d5c3128330bc0f88b104de9
2014-10-07 16:44:26 +09:00
Adrian Velicu
639837f85d Merge "Postponing memory deallocation after onFinishInputView" 2014-10-06 23:45:40 +00:00
Yohei Yukawa
db6c32778e Merge "Add a utility method to SuggestionSpanUtils" 2014-10-06 15:03:20 +00:00
Tadashi G. Takaoka
162ca68051 Remove preliminary subtypes from E-MR1 release
Note that unit test for Sinhala (Sri Lanka) and Tamil (Sri Lanka) have
been unexpectedly @suppressed.

Bug: 17743363
Change-Id: I4076a61adbf2d4aee58417d0c354b8ef4a938668
2014-10-06 23:42:14 +09:00
Adrian Velicu
7b8f317050 Postponing memory deallocation after onFinishInputView
Bug: 17559789
Change-Id: I1d4b1524028164d27ec4eadd3960b567148f2b84
2014-10-06 23:14:48 +09:00
Jean Chalard
fcc4cbf6f1 Merge "[ML14] Forward the locale list to relevant places, again" 2014-10-06 13:32:32 +00:00
Ken Wakasa
8784b4366e Merge "Revert "Remove preliminary subtypes from E-MR1 release"" 2014-10-06 12:53:14 +00:00
Ken Wakasa
fe5132f783 Revert "Remove preliminary subtypes from E-MR1 release"
This reverts commit 704db5f003.

Bug: 17743363

Reverting due to unit test breakage..

Change-Id: Ie7c1e86e50af2a05b4b7877092122dc4f026aa54
2014-10-06 12:52:45 +00:00
Jean Chalard
bc051a561f [ML14] Forward the locale list to relevant places, again
Diff:
+++ b/java/src/com/android/inputmethod/keyboard/internal/KeyboardBuilder.java
@@ -735,7 +735,7 @@ public class KeyboardBuilder<KP extends KeyboardParams> {

     private boolean matchLocaleCodes(TypedArray caseAttr, final Locale[] locales) {
         // TODO: adujst this for multilingual input
-        return matchString(caseAttr, R.styleable.Keyboard_Case_languageCode, locales[0].toString());
+        return matchString(caseAttr, R.styleable.Keyboard_Case_localeCode, locales[0].toString());
     }

     private boolean matchLanguageCodes(TypedArray caseAttr, Locale[] locales) {

Change-Id: Icefac18dd6d5fea97f591177cf8df1ba6de7f4f0
2014-10-06 21:27:32 +09:00
Keisuke Kuroyanagi
552470c882 Merge "Make sure to suppress BoS prediction until input twice." 2014-10-06 10:46:31 +00:00
Tadashi G. Takaoka
3215338fa0 Merge "Remove preliminary subtypes from E-MR1 release" 2014-10-06 10:45:32 +00:00
Tadashi G. Takaoka
704db5f003 Remove preliminary subtypes from E-MR1 release
Note that unit test for Sinhala (Sri Lanka) and Tamil (Sri Lanka) have
been unexpectedly @suppressed.

Bug: 17743363
Change-Id: I5f4b6fd8cbb8fa4e31df9ac602847c681655fd02
2014-10-06 10:44:59 +00:00
Keisuke Kuroyanagi
1c2f00f6b5 Make sure to suppress BoS prediction until input twice.
Change-Id: I98d91f264d5d1d3f5bcda1fd9ec885779ba2f746
2014-10-06 19:36:04 +09:00
Keisuke Kuroyanagi
ca17ed7d9d Fix: BoS prediction is shown after inputting just once.
Change-Id: Ibba209f47cb5b1a4b08281689d607711b8dcfad4
2014-10-06 19:28:39 +09:00
Yohei Yukawa
03c1e7955a Add a utility method to SuggestionSpanUtils
This is a ground work for subsequent CLs.

BUG: 16995261
Change-Id: Icbb708a35412a635a0d625b520069840c0bb0904
2014-10-06 16:22:51 +09:00