Commit graph

5694 commits

Author SHA1 Message Date
Kurt Partridge
4e1f8be3e5 Extract method to reloadTextCache()
Change-Id: Ibdaa9553cafeded15f800077606378b06af755cb
2013-11-06 23:43:56 -08:00
Tadashi G. Takaoka
0ea72c8519 Separate action key labels to strings-action-keys.xml
Bug: 11562208
Change-Id: I70390f9eafe51f16ff47b2e39454d1948a259469
2013-11-07 15:12:55 +09:00
Tadashi G. Takaoka
aaf532e641 Fix possible RuntimeException in parsing saved addtional subtypes
Bug: 11488129
Change-Id: I91f333aee9f3ae8d4b1d5e67d47de30f361947f3
2013-11-06 17:16:24 +09:00
Tadashi G. Takaoka
463674f950 Merge "Remove unused vertical scrollable KeyboardView" 2013-11-05 10:26:14 +00:00
Tadashi G. Takaoka
78d2895c8d Remove unused vertical scrollable KeyboardView
Bug: 11517736
Change-Id: I9d71290112c2306336e136c94b628b533e386aaa
2013-11-05 19:15:20 +09:00
Keisuke Kuroyanagi
9b3e59d644 Implement ver4 bigram reading method.
Bug: 11073222
Change-Id: I7b3408938f304da361201892e0a1342fdf92e62e
2013-11-05 16:00:26 +09:00
Keisuke Kuroyanagi
67cff29fd4 Merge "Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting." 2013-10-29 04:48:05 +00:00
Keisuke Kuroyanagi
82c962f1e0 Fix UserHistoryDictIOUtilsTests by adding @UsedForTesting.
Change-Id: I1bfeeafa002496bb98a385b87437e7f4eb0f6e1d
2013-10-28 21:46:05 -07:00
Satoshi Kataoka
40a3712a4c Merge "Show version in dumped info" 2013-10-29 02:43:09 +00:00
Satoshi Kataoka
5982b1ea08 Show version in dumped info
Bug: 10315296
Change-Id: Icb8e271451f4f9c5b083bfb5eb408372479c2140
2013-10-28 19:22:20 -07:00
Keisuke Kuroyanagi
388c953613 Fix tests by adding @UsedForTesting.
Change-Id: I5b98db67a083bde65bb0f2fb714ae2e799fb1d45
2013-10-28 17:16:01 -07:00
Satoshi Kataoka
ba212e9d76 Add a facility to dump the dictionary contents while closing
Change-Id: I02e920e0512f2b46a778f0b23f7ca03f8d5dabe6
2013-10-28 11:25:38 -07:00
Keisuke Kuroyanagi
8e9df884aa Add a test for ver4 native binary dictionary.
Bug: 10197478
Bug: 11073222
Change-Id: I6daac6c4b048c65682c25afe6ca0fad83cc9720f
2013-10-25 12:32:30 -07:00
Jean Chalard
d4b5bc1695 Merge "Preliminary refactor" 2013-10-22 11:26:54 +00:00
Jean Chalard
b00ed46385 Preliminary refactor
Bug: 11328842
Change-Id: I7c22e951fef9bc4443c6b64625e25f632f876ab1
2013-10-22 20:16:17 +09:00
Jean Chalard
729abe6332 Stopgap solution for a crash.
This returns the wrong string, but since it's used for getting the
previous word for bigrams, it only results in slightly worse
suggestions quality.

Bug: 11273655
Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
2013-10-22 20:00:09 +09:00
Jean Chalard
926ebe849a Merge "Add a sequence number to SuggestedWords." 2013-10-22 04:02:11 +00:00
Jean Chalard
ac76463306 Add a sequence number to SuggestedWords.
This allows testing for suggestion freshness in an asynchronous
suggestions world.

Bug: 11301597
Change-Id: Ic76cd17568598d8534aec81e037f9e37f52eb6b4
2013-10-22 12:52:58 +09:00
Jean Chalard
c6a121805f Fix a bug where autocaps would jam auto-commit
Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259
2013-10-22 12:39:49 +09:00
Ken Wakasa
513b99dfa2 Cosmetic fixes
Change-Id: I44ac89edaba2e57bd1b7e091ff74b77a5e598f2f
2013-10-21 15:53:49 +09:00
Yuichiro Hanada
52f18d7f40 Change the block sizes for SparseTables.
This change saves about 240k bytes.

Bug: 10941472
Change-Id: Ieb00e4dd3391cdb0d42d705f8d0a7b1421f516f9
2013-10-18 20:28:07 +09:00
Keisuke Kuroyanagi
8e9af925b1 Merge "Fix: Suggested words from user history are invalid." 2013-10-18 11:05:03 +00:00
Keisuke Kuroyanagi
53686e0f5f Fix: Suggested words from user history are invalid.
- Suggestions form user history can contain invalid words.
- isValidWord always returns false.

Bug: 11139426
Change-Id: I6075b275603332ddb00f4a9284afcaa82d824270
2013-10-18 19:53:57 +09:00
Satoshi Kataoka
7fdb2c2956 Merge "Change the numbering order of terminal IDs." 2013-10-18 10:31:27 +00:00
Yuichiro Hanada
9ae7d37108 Change the numbering order of terminal IDs.
Change-Id: I85a6b6e948ee0de012eef2f9f841240cbca63947
2013-10-18 19:16:11 +09:00
Yuichiro Hanada
2b7110ff1f (2/2) Implement insertWord in Ver4DictUpdater.
Change-Id: I2328a9df0a009b564e8acaf4180f9b0c1ed0901a
2013-10-18 18:03:44 +09:00
Yuichiro Hanada
19b247e79d Fix the name of the argument of writeString.
Change-Id: I76916914f1402913daa56dd5387fe82e42287989
2013-10-18 17:33:10 +09:00
Yuichiro Hanada
520f612849 (1/2) Implement insertWord in Ver4DictUpdater.
Change-Id: Ia3079d5ef00ca7d831c91fb9220ad9c17038c5a3
2013-10-18 16:42:59 +09:00
Jean Chalard
0f45e1bfbc Fix a bug where autoshift would be ignored coming from emoji
Bug: 11123691
Change-Id: I36474e12e34af95051129840865015f85595411b
2013-10-17 22:58:34 +09:00
Jean Chalard
578e9b91c1 Merge "Remove useless code." 2013-10-17 06:56:12 +00:00
Jean Chalard
8447409c77 Merge "Remove mIsExpectingUpdateSelection." 2013-10-17 06:55:54 +00:00
Yuichiro Hanada
ad5b9bcec2 Add readVer4PtNodeInfo to Ver4DictDecoder.
Change-Id: Ibffaf64a9bda1fb0779a9b53558ca56ed31660d3
2013-10-17 14:37:04 +09:00
Yuichiro Hanada
36dd126ab4 Add ShortcutContentReader.
Change-Id: I7c2d0d86d85775065a9bcb2b4a8463bb4969579e
2013-10-17 11:11:29 +09:00
Jean Chalard
548716d6d9 Remove useless code.
The only use of mDeleteCount is to implement delete
acceleration. It's reset at each non-delete code point, and
is guarded by a timer.
Plus, ultimately we want to remove this completely :
acceleration should be implemented by actually deleting
stuff faster, not by deleting several code points at a time.

Change-Id: Ia3144860b3aa2499034f2a2a7c81f32087af9598
2013-10-16 18:43:15 +09:00
Jean Chalard
5731b86b88 Merge "Remove unneeded code." 2013-10-16 09:41:44 +00:00
Jean Chalard
1194b2b204 Remove mIsExpectingUpdateSelection.
Bug: 11226045
Change-Id: I043f90ba92989bd8307c978eb32630439f63a0b9
2013-10-16 18:39:20 +09:00
Jean Chalard
497976e09b Remove unneeded code.
We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
we have any plans to support it again in the future.

This also is a prelude to removing mIsExpectingUpdateSelection.

Bug: 11226045
Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
2013-10-16 18:36:16 +09:00
Yuichiro Hanada
098639d99f Add SparseContentTableReader.
Change-Id: I976afc5d320bc65835d659bae1d10d2cdc68262b
2013-10-16 17:24:59 +09:00
Yuichiro Hanada
7b5f2b71f5 Fix Ver4DictDecoder.readAndFollowForwardLink().
Change-Id: Ib527a376b693be21aebd4920ac804ee9b161eb96
2013-10-16 17:16:26 +09:00
Ken Wakasa
008d84ffa5 Merge "Fix readAndFollowForwardLink." 2013-10-16 07:48:30 +00:00
Ken Wakasa
6b7037fa68 Merge "Extract SparseTableContentWriter." 2013-10-16 07:34:03 +00:00
Yuichiro Hanada
ed831f38db Extract SparseTableContentWriter.
Change-Id: I9a58e53317654f8a09fbe79044214de3e9c59eb7
2013-10-16 09:53:30 +09:00
Yuichiro Hanada
1557de7aa4 Consolidate CharEncoding.writeString and BinaryDictIOUtils.writeString.
Change-Id: I6f990fd84e7f08fd1149198c33d8bbf1cac8e078
2013-10-16 00:30:45 +09:00
Yuichiro Hanada
522dc0d8ac Fix readAndFollowForwardLink.
Change-Id: Ifda44e6139a4a1bd065468a7f74cd9483b343644
2013-10-16 00:16:39 +09:00
Ken Wakasa
b067be0e5f Merge "Revert "Revert "Add Swiss French and German keyboard layouts.""" 2013-10-15 14:12:29 +00:00
Ken Wakasa
b044047227 mExpectingUpdateSelection was out of sync when nothing to delete.
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
Ken Wakasa
cf5dfd2464 am 3a3bbf4a: am eed74b81: am c8383eda: Fix wrong commitText parameter in sendKeyCodePoint()
* commit '3a3bbf4a38870ecc42b7f6fbd3a7cae20fe020a7':
  Fix wrong commitText parameter in sendKeyCodePoint()
2013-10-14 10:52:40 -07:00
Ken Wakasa
c8383eda8b Fix wrong commitText parameter in sendKeyCodePoint()
Small optimization on generating a String instance from a single code
point too.

bug: 11181913

Change-Id: I0f905e4dc6ec7841092bb4d3d940daf3b2303f5b
2013-10-13 10:56:10 +09:00
Ken Wakasa
fe97ff4083 am 60fb5865: am 06e1bdaa: am 3e35e072: Merge "Make emoji separators" into klp-dev
* commit '60fb58654e33448651fea191ba22cfdc87e37466':
  Make emoji separators
2013-10-11 05:10:21 -07:00
Satoshi Kataoka
eb7fa4dc6d am 40506273: am ac6d0c65: am 6d915037: Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev
* commit '405062733cfe066c4b9af719bfc36a9a516c9dd3':
  Fix a bug where emojis would remove the suggestion strip.
2013-10-11 05:10:19 -07:00
Ken Wakasa
3e35e0727c Merge "Make emoji separators" into klp-dev 2013-10-11 11:57:07 +00:00
Satoshi Kataoka
6d91503727 Merge "Fix a bug where emojis would remove the suggestion strip." into klp-dev 2013-10-11 11:53:07 +00:00
Jean Chalard
6fc15b9fc4 Fix a bug where emojis would remove the suggestion strip.
Bug: 11163495
Change-Id: I23d12c430125cc2a66a6e00715a4c609bb9e2bb1
2013-10-11 20:51:13 +09:00
Jean Chalard
401fb908f0 Make emoji separators
Bug: 11163495
Change-Id: I3247b8d1bbd3406b29a30a25aebd932c63431943
2013-10-11 20:00:38 +09:00
Ken Wakasa
7abdab1c6f Merge "Add a time stamp for unigrams." 2013-10-11 10:17:01 +00:00
Jean Chalard
3def959e4d am 3f1c95db: am 331c84d7: am 5fe9ab1c: Merge "Fix the suggestion size." into klp-dev
* commit '3f1c95dbdc18453dc0cd6f847b33e01db1f1d75b':
  Fix the suggestion size.
2013-10-11 01:49:51 -07:00
Jean Chalard
5fe9ab1cc6 Merge "Fix the suggestion size." into klp-dev 2013-10-11 08:38:31 +00:00
Ken Wakasa
be22a01df3 Merge "Add resolveBigramPositions." 2013-10-11 07:45:20 +00:00
Jean Chalard
c0bd0a244d Fix the suggestion size.
The available space was not computed correctly. This makes the
decision to ellipsize/expand the middle suggestion correct.

Also, the scale was not applied correctly in some cases.

Finally, for some reason ellipsize does not work as we expect.
I'm not sure how to get it to work like we want it to, but
this works around the problem in a simple manner.

Bug: 11158757
Change-Id: I083e7ac56e157f100923733e67b92a6368a526c9
2013-10-11 16:42:46 +09:00
Satoshi Kataoka
7611af753a Merge "Do not merge. Save / restore the last used emoji category" into klp-dev 2013-10-11 07:21:35 +00:00
Satoshi Kataoka
7d3f53a1cb Do not merge. Save / restore the last used emoji category
Bug: 11029983
Change-Id: I5547910c7b5dd7974292fc075af33568940f4e81
2013-10-11 16:05:38 +09:00
Satoshi Kataoka
6026a95816 Merge "Save / restore the last used emoji category" 2013-10-11 07:04:42 +00:00
Satoshi Kataoka
6dc99dc200 Save / restore the last used emoji category
Bug: 11029983
Change-Id: I1bec2c3c6b547de68562a818a8d6c9fef83787b7
2013-10-11 16:00:33 +09:00
Yuichiro Hanada
c32962b8f1 Add a time stamp for unigrams.
Bug: 10920255
Change-Id: I26d2cce3c322a4ff39a614f8615f43fb7bd3baed
2013-10-11 15:08:09 +09:00
Yuichiro Hanada
9514ed5c2a Add the new format of bigram entries.
In new format, each bigram entry has flags (1 byte), a terminal id (3 byte),
a time-stamp (4 byte), a counter (1 byte) and a level (1 byte).

Bug: 10920255
Bug: 10920165
Change-Id: I0f7fc125a6178e6d25a07e8462afc41a7f57e3e1
2013-10-11 14:50:41 +09:00
Jean Chalard
7e6ac9d727 Allow double-space-to-period after percent
Bug: 11158604
Change-Id: If8c94ef91ed58bb5028f51be7c8d9beb677436a4
2013-10-10 21:26:08 +09:00
Ken Wakasa
6dac27eeb4 Merge "Tweak vertical gap of Emoji palette. DO NOT MERGE" into klp-dev 2013-10-10 03:39:30 +00:00
Satoshi Kataoka
3a9ae65525 Tweak vertical gap of Emoji palette. DO NOT MERGE
cherrypick of I8163568a9d7f9d321148001e161c672f78796c96

Bug: 11140087
Change-Id: Ifd28f3017a8cf568a8c4a1045811564a129d85b7
2013-10-10 11:29:08 +09:00
Satoshi Kataoka
557a0935d4 Retry to tweak punctuations. DO NOT MERGE
cherrypick of I9ffc457ca44bccfa3eb3bdb0c26535d795215b26

Bug: 11130808
Change-Id: I1a65fd8acc4efe9b4e4786a3dc959498ae63c2f8
2013-10-10 11:14:37 +09:00
Ken Wakasa
856b06a3ac Revert "Revert "Add Swiss French and German keyboard layouts.""
This reverts commit 56402cf10a.

I'll submit this on 10/16 after the final cut for Bayo.

Change-Id: I0fe4ab64fd8dfa1e63e29adf00388743fca6a1ed
bug: 11144401
2013-10-10 02:07:04 +00:00
Ken Wakasa
56402cf10a Revert "Add Swiss French and German keyboard layouts."
This reverts commit 220ce8f269.

Sorry, but we are now in the week before the final cut for the next launch. We shouldn't be taking new features like this at this point. Let me revert this change for now. I'll re-revert this after the cut next week.

Change-Id: Ia8b00680c992ec526e6a858945f2380cbcdfdd55
2013-10-10 02:05:50 +00:00
Fredrik Roubert
220ce8f269 Add Swiss French and German keyboard layouts.
There used to be two "Swiss" keyboard layouts, labelled fr_CH and de_QY,
available in LatinIME. They were, however, not actually Swiss layouts
but instead work-arounds to be able to get French or German with qwertz
or qwerty (instead of azerty and qwertz) layouts, respectively. These
were thus removed by commit f6972561fc
replacing them with the generic fr-qwertz and de-qwerty layouts instead.

Here, now, is a proper Swiss keyboard layout, following Swiss standards
for people accustomed to typing on Swiss keyboards, with the expected
tailorings for French and German.

Change-Id: I9feed752053ecc694c84db713284f69bc1daf155
2013-10-09 17:42:17 +02:00
Satoshi Kataoka
a6a6abc816 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 02:59:32 -07:00
Satoshi Kataoka
6862b8192d Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 02:59:26 -07:00
Yuichiro Hanada
67c758f160 Add resolveBigramPositions.
Bug: 11073222
Change-Id: I680e4304c6ab701e9aa132e1e140d789097a53ae
2013-10-09 17:39:22 +09:00
Satoshi Kataoka
56997a80c2 Retry to tweak punctuations
Bug: 11130808
Change-Id: I9ffc457ca44bccfa3eb3bdb0c26535d795215b26
2013-10-09 15:39:23 +09:00
Satoshi Kataoka
30ef03d865 Tweak vertical gap of Emoji palette
Bug: 11140087
Change-Id: I8163568a9d7f9d321148001e161c672f78796c96
2013-10-09 14:56:39 +09:00
Satoshi Kataoka
83994ad66b Merge "Fix the security related API change for PreferenceActivity" 2013-10-09 05:46:15 +00:00
Satoshi Kataoka
64f64bdf58 Fix the security related API change for PreferenceActivity
Bug: 10118761
Change-Id: I63501d6c2b5f561d7ab8b7362498665d805d5e1e
2013-10-09 14:34:06 +09:00
Jean Chalard
dfaec34502 Merge "Always call finishComposingText before recapitalization" 2013-10-09 05:18:01 +00:00
Jean Chalard
e306d292eb Merge "Remove a useless IPC call." 2013-10-09 05:17:51 +00:00
Satoshi Kataoka
50f9ca4acd Fix crash in AdditionalSubtypeUtils
Bug: 11136982

Change-Id: I9d022a178c47bad3566be4c0bd8ffbce0b14896d
2013-10-09 12:50:50 +09:00
Jean Chalard
f178685c11 Always call finishComposingText before recapitalization
Workaround for framework bug:
Bug: 10792236

Change-Id: I3706b9eed5223889791840e30660f8d17625cb70
2013-10-09 12:15:21 +09:00
Jean Chalard
27d78643e8 Remove a useless IPC call.
This is not useful because we're going to call setSelection again
with different values on the connection right away.

Also a preliminary change for
Bug: 10792236

Change-Id: I46c6ef1fbb3624086099bf81afddb0ef5ae85661
2013-10-09 12:11:28 +09:00
Satoshi Kataoka
de65b7c0b3 Merge "Fix the position of emoji palette" 2013-10-08 12:04:03 +00:00
Satoshi Kataoka
f981fe7ed2 Fix the position of emoji palette
Change-Id: I07a3912cb9fef8e28f3605de4e73a201a900e95c
2013-10-08 21:00:43 +09:00
Ken Wakasa
c040d59def Merge "Add more_keys_for_* declarations for the Swedish keyboard." 2013-10-08 11:44:54 +00:00
Fredrik Roubert
a30884e0e0 Add more_keys_for_* declarations for the Swedish keyboard.
This adds all those popup keys that were included in commit
b1cb13292f when the Swedish keyboard was
first added. Many of these definitions were later removed by commit
79b965e04f but most likely by mistake, as
that commit log message doesn't mention anything about removing these.

To help making this file more maintainable, this commit also moves a few
definitions around so that all definitions now appear in alphabetical
order.

Change-Id: Iadef9e3dd1dc7b39fe87b2fc75210d0697b24361
2013-10-08 13:28:08 +02:00
Satoshi Kataoka
a701501cb6 Merge "Reduce memory of emoji palette" 2013-10-08 11:22:21 +00:00
Satoshi Kataoka
0e01df9baf Reduce memory of emoji palette
Bug: 10902556
Change-Id: I3c8da35a601de2bfb248292c7b59235fc1120988
2013-10-08 20:11:35 +09:00
Jean Chalard
92190d9a75 Merge "Show the keyboard earlier when rotating." 2013-10-08 10:14:41 +00:00
Satoshi Kataoka
2d3e121014 Fix memory leak in EmojiPaletteView
Bug: 10902556
Change-Id: I3a8c1e08d6f953b462d914acd1f411c36f9d80f2
2013-10-08 19:05:00 +09:00
Ken Wakasa
d900b90db7 Merge "Prep for RAM footprint optimization for Emoji palettes" 2013-10-08 08:11:53 +00:00
Ken Wakasa
8cf2a5e59f Prep for RAM footprint optimization for Emoji palettes
bug: 10902556
Change-Id: I313948c73b60cd33c437cf02e8d3fb61c288a240
2013-10-08 17:09:24 +09:00
Jean Chalard
482aa129e4 Show the keyboard earlier when rotating.
Bug: 11107229
Change-Id: I0b36341d60b634a860eb13fafd0dc69fe734bdeb
2013-10-08 16:33:27 +09:00
Jean Chalard
10581e68af Make the sentence separator a resource.
This will help handing correctly the armenian full stop.

Bug: 10082781
Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
2013-10-08 15:28:43 +09:00
Satoshi Kataoka
984aa60e11 Merge "Extend hitbox of emoji keys" 2013-10-07 23:27:07 +00:00
Satoshi Kataoka
5d27cb9397 Extend hitbox of emoji keys
Bug: 11105065
Change-Id: I5e90ba55cf708bf7be27d7d101cbc0719ac583c8
2013-10-07 23:22:12 +09:00
Jean Chalard
7712baa59b Merge "Fix a possible IOOB" 2013-10-07 14:21:00 +00:00
Jean Chalard
ca9c3c0613 Fix a possible IOOB
We want to use StringUtils here, but it's full of references to
stuff not accessible host-side like JsonReader and TextUtils
and SettingsValues :/

Bug: 11061476
Change-Id: I3c0194979833ede283b4f9190335dba5376fe6fc
2013-10-07 23:16:57 +09:00