42e83c7f06
Fix a race condition.
...
Don't use absolute cursor positions, this leads to race
conditions.
Bug: 12390573
Change-Id: I6f04f07a46babbc3d51cb94c7eaee21bed242396
2014-01-07 15:33:04 +09:00
6d5f9fd3d1
Merge "Fix possible NPE."
2014-01-06 09:53:15 +00:00
8214a8c2cf
Fix possible NPE.
...
Bug: 11933670
Change-Id: Ib0ce853e691bdadffb73874ea9f188cfbec8bc93
2014-01-06 17:56:49 +09:00
74b5291b84
Merge "Remove language switch key from symbols and symbols shift keyboard"
2014-01-06 06:19:27 +00:00
d561228f95
Remove language switch key from symbols and symbols shift keyboard
...
This change also fixes the background color of the left keys of the space key.
Bug: 12407208
Change-Id: Id869605146e9f72835f892c3c7ae14f118177394
2014-01-06 15:02:50 +09:00
3f8c6b8c54
Merge "Add description of disabled voice input key option"
2014-01-06 03:25:15 +00:00
12ba821bfb
Add description of disabled voice input key option
...
Bug: 12377179
Change-Id: I44d35c6fa82883710674ecca6f630d09076472fe
2014-01-06 12:11:55 +09:00
e91559a119
Merge "Update shortcut IME info before checking availability of it"
2014-01-06 03:07:23 +00:00
e9584a1612
Merge "Add DictionaryFacilitatorForSuggest constructor for testing"
2014-01-06 02:58:12 +00:00
b7c531b751
Update shortcut IME info before checking availability of it
...
Bug: 12377179
Change-Id: I4e2de78dc7e21f3f34eb56c790160b77cfc7584c
2014-01-06 11:54:46 +09:00
49b5fadae1
Add DictionaryFacilitatorForSuggest constructor for testing
...
This change must be checked in together with I00b6e79d6b.
Change-Id: Id5f87a8d0286eb44958381fefd428f16896dc0d4
2014-01-06 11:00:51 +09:00
1e50c681af
[IL52] Remove a useless method.
...
This old method doesn't even re-read the old suggestions. It used to
recompute them without the coordinates.
Re-using the recorrection code, which is much more advanced, is
the right thing to do here.
Also, refining the test. It's no use trying to resume suggestion
if we don't have a suggestion strip, since we aren't going to
auto-correct anything anyway.
Not the motivation for this change, but this also fixes
Bug: 11620256
Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
2013-12-27 22:40:19 +09:00
8ce921dd6b
[IL51] Make private what can be made private
...
Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
2013-12-27 21:09:47 +09:00
53c320e275
[IL50] Move the InputUpdater out of LatinIME.
...
...at last
Bug: 8636060
Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
2013-12-27 21:09:41 +09:00
81e0ca5fd3
[IL49] Move InputLogic-related init code to InputLogic.
...
Bug: 8636060
Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
2013-12-27 20:06:39 +09:00
4970eda286
Fix a failing test
...
How/when did this happen? How was it not noticed?
Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
2013-12-27 20:04:41 +09:00
d05ea8bd82
Merge "[IL48] Move onEndBatchInputAsyncInternal to InputLogic."
2013-12-27 08:06:48 +00:00
af26a44102
Merge "[IL47] Inline getSuggestedWordsGestureLocked"
2013-12-27 08:04:51 +00:00
51e79fb4b2
Merge "[IL46] Remove a useless message passing."
2013-12-27 07:56:56 +00:00
2fc1cc099f
Merge "[IL45] Remove lingering messages"
2013-12-27 07:56:44 +00:00
c654fe57b1
[IL48] Move onEndBatchInputAsyncInternal to InputLogic.
...
Bug: 8636060
Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
2013-12-27 16:50:08 +09:00
4a144b9b4d
[IL47] Inline getSuggestedWordsGestureLocked
...
This method is confusing with the *Locked convention, and
the two-step call creates a useless callback object. This is
better inlined both for readability and for performance.
Bug: 8636060
Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
2013-12-27 16:50:08 +09:00
71a3e96382
[IL46] Remove a useless message passing.
...
The only point of this message is to send the processing on another
thread. However, this will be accomplished later.
Here is the exact call graph:
0. onUpdateBatchInput
1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
2. -> updateBatchInputSync
3. -> getSuggestedWordsGestureLocked
4. -> MSG_GET_SUGGESTED_WORDS
5. -> LatinIME#getSuggestedWords
The point of both step 1. and step 4. is to make sure the processing
is happening on the InputUpdater thread. Thus, it's useless to do
it twice.
Bug: 11326092
Bug: 8636060
Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
2013-12-27 16:50:06 +09:00
0d21223521
Merge "[IL44] Some factorization"
2013-12-27 06:58:12 +00:00
31ff2a4335
[IL45] Remove lingering messages
...
Bug: 8636060
And possibly bug: 12085864
Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
2013-12-27 15:34:30 +09:00
69e7a0d24d
[IL44] Some factorization
...
This sheds some light on what's happening here. Some
comments were at least misleading, maybe indicating something
is not sequenced as intended.
Bug: 8636060
Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
2013-12-27 15:34:26 +09:00
c197b9ed90
Merge "Make setAdditionalDictionaries private."
2013-12-27 06:22:18 +00:00
86da47e8d7
Fix possible NPE in FileUtils.
...
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
2013-12-27 14:58:38 +09:00
abc3d0eb56
Make setAdditionalDictionaries private.
...
Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
2013-12-27 14:49:32 +09:00
6bca9ac43d
Fix a bug where predictions would not pop upon manual pick
...
Bug: 12295276
Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
2013-12-26 23:19:29 +09:00
33b2aaafc2
Merge "Fix a code path that looks ridiculous"
2013-12-26 13:39:21 +00:00
f294ed3308
Fix a code path that looks ridiculous
...
Bug: 12295276
Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
2013-12-26 22:28:16 +09:00
f441047fad
[IL43] Small cleanup
...
All calls are already passing this
Bug: 8636060
Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
2013-12-26 22:12:24 +09:00
c28f02880c
[IL42] Inline getSuggestedWordsOrOlderSuggestionsAsync
...
Bug: 8636060
Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
2013-12-26 22:12:22 +09:00
70433efc41
[IL41] Remove a useless call and trampoline.
...
No point in calling maybeRetrieveOlderSuggestions now that the
same work is done right here. The callback is also useless now.
Bug: 8636060
Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
2013-12-26 21:58:41 +09:00
be147f1fdc
Remove DictionaryFacilitatorForSuggest.getMainDictionary().
...
Bug: 8187060
Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
2013-12-26 20:48:19 +09:00
a374482719
Extract dict operations from Suggest to a new class.
...
Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
2013-12-26 20:48:19 +09:00
5c45ff1214
[IL39] Change a test.
...
I don't see why we would want to remove other suggestions just because
the only suggestion happens to be a dictionary word. That's just
inconsistent.
Bug: 8636060
Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
2013-12-26 18:44:17 +09:00
98140faac3
[IL38] Fix a wrong double call
...
This only gives bad results if a gesture results in only one suggestion.
Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
2013-12-26 18:43:47 +09:00
d77ad1902b
Fix NPE in a unit test.
...
Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
2013-12-26 17:01:48 +09:00
65e3ae6f15
Merge "Remove useless method call for spell checker."
2013-12-26 06:42:51 +00:00
7987afbea4
Remove useless method call for spell checker.
...
Bug: 8187060
Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
2013-12-26 14:51:05 +09:00
3fbcf48591
Merge "Add BatchInputArbiter"
2013-12-26 05:50:07 +00:00
4a4b6d42a7
Add BatchInputArbiter
...
Move the logic that determines how to handle gesture typing from
PointerTracker to BatchInputArbiter class.
This change must be checked in together with Ia7db8f4fb7.
Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
2013-12-26 14:09:57 +09:00
30a72da42c
[IL37] Small simplification
...
Bug: 8636060
Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
2013-12-26 13:51:09 +09:00
c08119e5c1
[IL36] Inline setAutoCorrection
...
There are far too many one-use methods.
Bug: 8636060
Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
2013-12-26 13:18:36 +09:00
52a2682b99
[IL35] Preparative cleanup
...
Bug: 8636060
Change-Id: Id6791085816891c78289b0223bf0807db2da6300
2013-12-25 22:25:49 +09:00
0154609a2e
Merge "[IL34] Introduce InputLogicHandler"
2013-12-25 13:21:54 +00:00
5c4bd20331
Remove "Boost personalization dictionary" from settings.
...
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
2013-12-25 19:02:49 +09:00
bb39518bd7
Use SettingsValues instead of Settings in Suggest.
...
Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
2013-12-25 18:53:04 +09:00
Jean Chalard
Keisuke Kuroyanagi
Tadashi G. Takaoka