From fb6eeeb35ad593926da9b7dc57335f0ba591570c Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Mon, 9 Jul 2012 15:14:19 +0900 Subject: [PATCH] Refactoring (A82) The user history dictionary should be the one knowing it does not suggest words beyond 2 characters, not Suggest. Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf --- java/src/com/android/inputmethod/latin/Suggest.java | 5 ++--- .../inputmethod/latin/UserHistoryDictionary.java | 11 +++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/java/src/com/android/inputmethod/latin/Suggest.java b/java/src/com/android/inputmethod/latin/Suggest.java index d7aa87dca..00ca5aff0 100644 --- a/java/src/com/android/inputmethod/latin/Suggest.java +++ b/java/src/com/android/inputmethod/latin/Suggest.java @@ -194,9 +194,8 @@ public class Suggest { } // At second character typed, search the unigrams (scores being affected by bigrams) for (final String key : mDictionaries.keySet()) { - // Skip UserUnigramDictionary and WhitelistDictionary to lookup - if (key.equals(Dictionary.TYPE_USER_HISTORY) - || key.equals(Dictionary.TYPE_WHITELIST)) + // Skip WhitelistDictionary to lookup + if (key.equals(Dictionary.TYPE_WHITELIST)) continue; final Dictionary dictionary = mDictionaries.get(key); suggestionsSet.addAll(dictionary.getWords( diff --git a/java/src/com/android/inputmethod/latin/UserHistoryDictionary.java b/java/src/com/android/inputmethod/latin/UserHistoryDictionary.java index 73fa83f9a..d742e2190 100644 --- a/java/src/com/android/inputmethod/latin/UserHistoryDictionary.java +++ b/java/src/com/android/inputmethod/latin/UserHistoryDictionary.java @@ -27,9 +27,12 @@ import android.os.AsyncTask; import android.provider.BaseColumns; import android.util.Log; +import com.android.inputmethod.keyboard.ProximityInfo; +import com.android.inputmethod.latin.SuggestedWords.SuggestedWordInfo; import com.android.inputmethod.latin.UserHistoryForgettingCurveUtils.ForgettingCurveParams; import java.lang.ref.SoftReference; +import java.util.ArrayList; import java.util.HashMap; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.locks.ReentrantLock; @@ -157,6 +160,14 @@ public class UserHistoryDictionary extends ExpandableDictionary { // super.close(); } + @Override + public ArrayList getWords(final WordComposer composer, + final CharSequence prevWord, final ProximityInfo proximityInfo) { + // User history unigrams are not used at this moment. Implement this method to make them + // useful. + return null; + } + /** * Return whether the passed charsequence is in the dictionary. */