Merge "Fix more keys keyboard display position"

This commit is contained in:
Tadashi G. Takaoka 2013-11-20 05:46:17 +00:00 committed by Android (Google) Code Review
commit e9ec4d1add
2 changed files with 6 additions and 4 deletions

View file

@ -223,7 +223,7 @@ public final class MoreKeysKeyboard extends Keyboard {
} }
public int getDefaultKeyCoordX() { public int getDefaultKeyCoordX() {
return mLeftKeys * mColumnWidth; return mLeftKeys * mColumnWidth + mLeftPadding;
} }
public int getX(final int n, final int row) { public int getX(final int n, final int row) {

View file

@ -81,11 +81,13 @@ public class MoreKeysKeyboardView extends KeyboardView implements MoreKeysPanel
mListener = listener; mListener = listener;
final View container = getContainerView(); final View container = getContainerView();
// The coordinates of panel's left-top corner in parentView's coordinate system. // The coordinates of panel's left-top corner in parentView's coordinate system.
final int x = pointX - getDefaultCoordX() - container.getPaddingLeft(); // We need to consider background drawable paddings.
final int y = pointY - container.getMeasuredHeight() + container.getPaddingBottom(); final int x = pointX - getDefaultCoordX() - container.getPaddingLeft() - getPaddingLeft();
final int y = pointY - container.getMeasuredHeight() + container.getPaddingBottom()
+ getPaddingBottom();
parentView.getLocationInWindow(mCoordinates); parentView.getLocationInWindow(mCoordinates);
// Ensure the horizontal position of the panel does not extend past the screen edges. // Ensure the horizontal position of the panel does not extend past the parentView edges.
final int maxX = parentView.getMeasuredWidth() - container.getMeasuredWidth(); final int maxX = parentView.getMeasuredWidth() - container.getMeasuredWidth();
final int panelX = Math.max(0, Math.min(maxX, x)) + CoordinateUtils.x(mCoordinates); final int panelX = Math.max(0, Math.min(maxX, x)) + CoordinateUtils.x(mCoordinates);
final int panelY = y + CoordinateUtils.y(mCoordinates); final int panelY = y + CoordinateUtils.y(mCoordinates);