nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[IL57] Don't require a main dict suggestion.

Browse source 
This is bad for recorrection (it will ignore recorrection suggestions).
But if you think about it well, if you didn't have a main dict, then you
probably will compute the same stuff anyway. It's not useful
to make this check at all.

Bug: 12297051
Change-Id: I6d6cf4d9353b7c668c5413c67701563b243e585c
This commit is contained in:
Jean Chalard 2014-01-09 19:51:15 +09:00
parent 4752b68f5a
commit e22e67e37a
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
java/src/com/android/inputmethod/compat/SuggestionSpanUtils.java
View file

@ -74,7 +74,6 @@ public final class SuggestionSpanUtils {
return pickedWord;
}
boolean hasSuggestionFromMainDictionary = false;
final ArrayList<String> suggestionsList = CollectionUtils.newArrayList();
for (int i = 0; i < suggestedWords.size(); ++i) {
if (suggestionsList.size() >= SuggestionSpan.SUGGESTIONS_MAX_SIZE) {
@ -84,22 +83,11 @@ public final class SuggestionSpanUtils {
if (info.mKind == SuggestedWordInfo.KIND_PREDICTION) {
continue;
}
if (info.mSourceDict.mDictType == Dictionary.TYPE_MAIN) {
hasSuggestionFromMainDictionary = true;
}
final String word = suggestedWords.getWord(i);
if (!TextUtils.equals(pickedWord, word)) {
suggestionsList.add(word.toString());
}
}
if (!hasSuggestionFromMainDictionary) {
// If we don't have any suggestions from the dictionary, it probably looks bad
// enough as it is already because suggestions come pretty much only from contacts.
// Let's not embed these bad suggestions in the text view so as to avoid using
// them with recorrection.
return pickedWord;
}
final SuggestionSpan suggestionSpan = new SuggestionSpan(context, null /* locale */,
suggestionsList.toArray(new String[suggestionsList.size()]), 0 /* flags */,
SuggestionSpanPickedNotificationReceiver.class);