nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix NPE due to the lack of null-check 

The case that was not coverted well is that
CursorAnchorInfoCompatWrapper could be instantiated
with null object. In such situations, we should
do nothing.

BUG: 17682582
Change-Id: I6625a2f0ed8c5580ed9edfe4728f342da77a8e40
main
Yohei Yukawa 2014-09-29 16:17:52 +09:00
parent be4e0d0e39
commit de12c1bf49
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
java/src/com/android/inputmethod/compat/CursorAnchorInfoCompatWrapper.java
View File

@ -84,8 +84,8 @@ public final class CursorAnchorInfoCompatWrapper {
} }
@UsedForTesting @UsedForTesting
public static boolean isAvailable() { public boolean isAvailable() {
return sCursorAnchorInfoClass.exists(); return sCursorAnchorInfoClass.exists() && mInstance != null;
} }
private Object mInstance; private Object mInstance;
@ -96,7 +96,7 @@ public final class CursorAnchorInfoCompatWrapper {
@UsedForTesting @UsedForTesting
public static CursorAnchorInfoCompatWrapper fromObject(final Object instance) { public static CursorAnchorInfoCompatWrapper fromObject(final Object instance) {
if (!isAvailable()) { if (!sCursorAnchorInfoClass.exists()) {
return new CursorAnchorInfoCompatWrapper(null); return new CursorAnchorInfoCompatWrapper(null);
} }
return new CursorAnchorInfoCompatWrapper(instance); return new CursorAnchorInfoCompatWrapper(instance);

2
java/src/com/android/inputmethod/keyboard/TextDecorator.java
View File

@ -182,7 +182,7 @@ public class TextDecorator {
private void layoutMain() { private void layoutMain() {
final CursorAnchorInfoCompatWrapper info = mCursorAnchorInfoWrapper; final CursorAnchorInfoCompatWrapper info = mCursorAnchorInfoWrapper;
if (info == null) { if (info == null || !info.isAvailable()) {
cancelLayoutInternalExpectedly("CursorAnchorInfo isn't available."); cancelLayoutInternalExpectedly("CursorAnchorInfo isn't available.");
return; return;
} }