From b063377e77ae9421664da1f021d49342d73b882d Mon Sep 17 00:00:00 2001 From: Keisuke Kuroyanagi Date: Thu, 20 Feb 2014 18:55:19 +0900 Subject: [PATCH] Add final and volatile for members of InputLogic. Bug: 13107471 Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e --- .../com/android/inputmethod/latin/inputlogic/InputLogic.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java b/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java index 3fc2cf8fd..52a6f5f08 100644 --- a/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java +++ b/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java @@ -77,9 +77,10 @@ public final class InputLogic { public int mSpaceState; // Never null public SuggestedWords mSuggestedWords = SuggestedWords.EMPTY; - public Suggest mSuggest; + // TODO: mSuggest should be touched by a single thread. + public volatile Suggest mSuggest; // The event interpreter should never be null. - public EventInterpreter mEventInterpreter; + public final EventInterpreter mEventInterpreter; public LastComposedWord mLastComposedWord = LastComposedWord.NOT_A_COMPOSED_WORD; public final WordComposer mWordComposer;