From d47dca429e74b47cfbf4200dd23c8f5a1e5791ec Mon Sep 17 00:00:00 2001 From: Ken Wakasa Date: Fri, 9 May 2014 11:28:19 +0000 Subject: [PATCH] Revert "Refactor KeyboardTheme" This reverts commit 19688b584bb903192559196a0e3836bc4c957696. Build breakage. Change-Id: I95d4be1578824eaee5a2fb08ec277250727ac668 --- java/res/values/config-common.xml | 3 + java/res/values/keyboard-themes.xml | 34 ----- java/res/xml/prefs.xml | 5 +- .../keyboard/KeyboardSwitcher.java | 7 +- .../inputmethod/keyboard/KeyboardTheme.java | 126 +++--------------- .../inputmethod/latin/settings/Settings.java | 2 +- .../latin/settings/SettingsFragment.java | 25 +--- .../keyboard/KeyboardLayoutSetTestsBase.java | 8 +- .../keyboard/KeyboardThemeTests.java | 93 ------------- 9 files changed, 34 insertions(+), 269 deletions(-) delete mode 100644 java/res/values/keyboard-themes.xml delete mode 100644 tests/src/com/android/inputmethod/keyboard/KeyboardThemeTests.java diff --git a/java/res/values/config-common.xml b/java/res/values/config-common.xml index 1962c0d45..3fe4b947c 100644 --- a/java/res/values/config-common.xml +++ b/java/res/values/config-common.xml @@ -24,6 +24,9 @@ at input history to suggest a hopefully helpful suggestions for the next word? --> true + + 2 + 100 1100 diff --git a/java/res/values/keyboard-themes.xml b/java/res/values/keyboard-themes.xml deleted file mode 100644 index 0325f5be0..000000000 --- a/java/res/values/keyboard-themes.xml +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - @string/keyboard_color_scheme_white - @string/keyboard_color_scheme_blue - - Quantum - - - - 2 - 0 - 3 - - diff --git a/java/res/xml/prefs.xml b/java/res/xml/prefs.xml index 61ebb6992..7d86dbd5d 100644 --- a/java/res/xml/prefs.xml +++ b/java/res/xml/prefs.xml @@ -158,11 +158,12 @@ android:persistent="true" android:defaultValue="false" /> + android:entries="@array/keyboard_theme_names" + android:defaultValue="@string/config_default_keyboard_theme_id" /> () { - @Override - public int compare(final KeyboardTheme lhs, final KeyboardTheme rhs) { - if (lhs.mMinApiVersion > rhs.mMinApiVersion) return -1; - if (lhs.mMinApiVersion < rhs.mMinApiVersion) return 1; - return 0; - } - }); - } public final int mThemeId; public final int mStyleId; - final int mMinApiVersion; // Note: The themeId should be aligned with "themeId" attribute of Keyboard style - // in values/themes-