Merge "Restart suggestions when restarting input"

main
Jean Chalard 2014-04-16 10:43:28 +00:00 committed by Android (Google) Code Review
commit ba635ad30d
3 changed files with 9 additions and 3 deletions

View File

@ -819,9 +819,7 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen
// When rotating, initialSelStart and initialSelEnd sometimes are lying. Make a best // When rotating, initialSelStart and initialSelEnd sometimes are lying. Make a best
// effort to work around this bug. // effort to work around this bug.
mInputLogic.mConnection.tryFixLyingCursorPosition(); mInputLogic.mConnection.tryFixLyingCursorPosition();
if (isDifferentTextField) { mHandler.postResumeSuggestions();
mHandler.postResumeSuggestions();
}
canReachInputConnection = true; canReachInputConnection = true;
} }

View File

@ -1284,6 +1284,10 @@ public final class InputLogic {
|| !settingsValues.mSpacingAndPunctuations.mCurrentLanguageHasSpaces || !settingsValues.mSpacingAndPunctuations.mCurrentLanguageHasSpaces
// If no suggestions are requested, don't try restarting suggestions. // If no suggestions are requested, don't try restarting suggestions.
|| !settingsValues.isSuggestionsRequested() || !settingsValues.isSuggestionsRequested()
// If we are currently in a batch input, we must not resume suggestions, or the result
// of the batch input will replace the new composition. This may happen in the corner case
// that the app moves the cursor on its own accord during a batch input.
|| mInputLogicHandler.isInBatchInput()
// If the cursor is not touching a word, or if there is a selection, return right away. // If the cursor is not touching a word, or if there is a selection, return right away.
|| mConnection.hasSelection() || mConnection.hasSelection()
// If we don't know the cursor location, return. // If we don't know the cursor location, return.

View File

@ -110,6 +110,10 @@ class InputLogicHandler implements Handler.Callback {
} }
} }
public boolean isInBatchInput() {
return mInBatchInput;
}
/** /**
* Fetch suggestions corresponding to an update of a batch input. * Fetch suggestions corresponding to an update of a batch input.
* @param batchPointers the updated pointers, including the part that was passed last time. * @param batchPointers the updated pointers, including the part that was passed last time.