From 59d271ee763efac79c07e8224490e3755284e603 Mon Sep 17 00:00:00 2001 From: Ken Wakasa Date: Thu, 1 Jul 2010 09:14:24 +0900 Subject: [PATCH] Add key debounce. bug: 2517112 Change-Id: I461e481226395ce8964003c2ad1f4af888c6f7f9 --- .../inputmethod/latin/LatinKeyboardBaseView.java | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/java/src/com/android/inputmethod/latin/LatinKeyboardBaseView.java b/java/src/com/android/inputmethod/latin/LatinKeyboardBaseView.java index 7f35ea98e..4205aadcf 100644 --- a/java/src/com/android/inputmethod/latin/LatinKeyboardBaseView.java +++ b/java/src/com/android/inputmethod/latin/LatinKeyboardBaseView.java @@ -182,6 +182,8 @@ public class LatinKeyboardBaseView extends View implements View.OnClickListener private int mVerticalCorrection; private int mProximityThreshold; + private int mKeyDebounceThreshold; + private static final int KEY_DEBOUNCE_FACTOR = 6; private boolean mPreviewCentered = false; private boolean mShowPreview = true; @@ -633,6 +635,9 @@ public class LatinKeyboardBaseView extends View implements View.OnClickListener if (dimensionSum < 0 || length == 0) return; mProximityThreshold = (int) (dimensionSum * 1.4f / length); mProximityThreshold *= mProximityThreshold; // Square it + + // 1/KEY_DEBOUNCE_FACTOR of distance between adjacent keys + mKeyDebounceThreshold = mProximityThreshold / KEY_DEBOUNCE_FACTOR; } @Override @@ -1158,6 +1163,13 @@ public class LatinKeyboardBaseView extends View implements View.OnClickListener return result; } + private boolean isMinorMoveForKeyDebounce(int x, int y) { + // TODO: Check the coordinate against each key border. The current + // logic is pretty simple. + return ((x - mLastCodeX) * (x - mLastCodeX) + + (y - mLastCodeY) * (y - mLastCodeY)) < mKeyDebounceThreshold; + } + private boolean onModifiedTouchEvent(MotionEvent me, boolean possiblePoly) { int touchX = (int) me.getX() - getPaddingLeft(); int touchY = (int) me.getY() + mVerticalCorrection - getPaddingTop(); @@ -1231,7 +1243,8 @@ public class LatinKeyboardBaseView extends View implements View.OnClickListener mCurrentKey = keyIndex; mCurrentKeyTime = eventTime - mDownTime; } else { - if (keyIndex == mCurrentKey) { + if (keyIndex == mCurrentKey + || isMinorMoveForKeyDebounce(touchX, touchY)) { mCurrentKeyTime += eventTime - mLastMoveTime; continueLongPress = true; } else if (mRepeatKeyIndex == NOT_A_KEY) {