Merge "Stop auto-correcting non-whitelisted one-char strings" into jb-mr1-dev

main
Jean Chalard 2012-09-11 01:34:51 -07:00 committed by Android (Google) Code Review
commit b0c693d005
2 changed files with 7 additions and 5 deletions

View File

@ -73,11 +73,11 @@ public class AutoCorrection {
return maxFreq;
}
// Returns true if this isn't in any dictionary.
public static boolean isNotAWord(
// Returns true if this is in any of the dictionaries.
public static boolean isInTheDictionary(
final ConcurrentHashMap<String, Dictionary> dictionaries,
final CharSequence word, final boolean ignoreCase) {
return !isValidWord(dictionaries, word, ignoreCase);
return isValidWord(dictionaries, word, ignoreCase);
}
public static boolean suggestionExceedsAutoCorrectionThreshold(SuggestedWordInfo suggestion,

View File

@ -214,10 +214,12 @@ public class Suggest {
whitelistedWord = suggestionsSet.first().mWord;
}
// The word can be auto-corrected if it has a whitelist entry that is not itself,
// or if it's a 2+ characters non-word (i.e. it's not in the dictionary).
final boolean allowsToBeAutoCorrected = (null != whitelistedWord
&& !whitelistedWord.equals(consideredWord))
|| AutoCorrection.isNotAWord(mDictionaries, consideredWord,
wordComposer.isFirstCharCapitalized());
|| (consideredWord.length() > 1 && !AutoCorrection.isInTheDictionary(mDictionaries,
consideredWord, wordComposer.isFirstCharCapitalized()));
final boolean hasAutoCorrection;
// TODO: using isCorrectionEnabled here is not very good. It's probably useless, because