Small cleanup

The method deleteWordAtCursor would call finishComposingText,
which is a very unexpected state change and would probably cause
surprising bugs to any parent that would call it.
As it happens, it's not used anywhere any more so let's just
remove it.

Change-Id: Iaa9200866e40b4e914f76baa987279948300679c
This commit is contained in:
Jean Chalard 2012-01-17 11:55:23 +09:00
parent 72d285f4d7
commit a8ba49c253
2 changed files with 1 additions and 18 deletions

View file

@ -86,23 +86,6 @@ public class EditingUtils {
return (r == null) ? null : r.mWord; return (r == null) ? null : r.mWord;
} }
/**
* Removes the word surrounding the cursor. Parameters are identical to
* getWordAtCursor.
*/
public static void deleteWordAtCursor(InputConnection connection, String separators) {
// getWordRangeAtCursor returns null if the connection is null
Range range = getWordRangeAtCursor(connection, separators);
if (range == null) return;
connection.finishComposingText();
// Move cursor to beginning of word, to avoid crash when cursor is outside
// of valid range after deleting text.
int newCursor = getCursorPosition(connection) - range.mCharsBefore;
connection.setSelection(newCursor, newCursor);
connection.deleteSurroundingText(0, range.mCharsBefore + range.mCharsAfter);
}
/** /**
* Represents a range of text, relative to the current cursor position. * Represents a range of text, relative to the current cursor position.
*/ */

View file

@ -1399,7 +1399,7 @@ public class LatinIME extends InputMethodServiceCompatWrapper implements Keyboar
if (mSuggestionsView != null && mSuggestionsView.dismissAddToDictionaryHint()) { if (mSuggestionsView != null && mSuggestionsView.dismissAddToDictionaryHint()) {
// Go back to the suggestion mode if the user canceled the // Go back to the suggestion mode if the user canceled the
// "Touch again to save". // "Touch again to save".
// NOTE: In gerenal, we don't revert the word when backspacing // NOTE: In general, we don't revert the word when backspacing
// from a manual suggestion pick. We deliberately chose a // from a manual suggestion pick. We deliberately chose a
// different behavior only in the case of picking the first // different behavior only in the case of picking the first
// suggestion (typed word). It's intentional to have made this // suggestion (typed word). It's intentional to have made this