nyancrimew/LatinIME
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Stop creating useless objects

Browse source 
Man that was bad, it's heavy, it's called quite often, and it's
totally useless

Change-Id: Ia7e23e0e60ff4a929b226f3f4ccabedbc3ea2c06
This commit is contained in:
Jean Chalard 2012-03-23 17:55:11 +09:00
parent 3d3ee645cc
commit a492790982
1 changed files with 3 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
java/src/com/android/inputmethod/latin/WordComposer.java
View file

@ -172,8 +172,7 @@ public class WordComposer {
/** /**
* Internal method to retrieve reasonable proximity info for a character. * Internal method to retrieve reasonable proximity info for a character.
*/ */
private void addKeyInfo(final int codePoint, final Keyboard keyboard, private void addKeyInfo(final int codePoint, final Keyboard keyboard) {
final KeyDetector keyDetector) {
for (final Key key : keyboard.mKeys) { for (final Key key : keyboard.mKeys) {
if (key.mCode == codePoint) { if (key.mCode == codePoint) {
final int x = key.mX + key.mWidth / 2; final int x = key.mX + key.mWidth / 2;
@ -191,26 +190,15 @@ public class WordComposer {
* Set the currently composing word to the one passed as an argument. * Set the currently composing word to the one passed as an argument.
* This will register NOT_A_COORDINATE for X and Ys, and use the passed keyboard for proximity. * This will register NOT_A_COORDINATE for X and Ys, and use the passed keyboard for proximity.
*/ */
private void setComposingWord(final CharSequence word, final Keyboard keyboard, public void setComposingWord(final CharSequence word, final Keyboard keyboard) {
final KeyDetector keyDetector) {
reset(); reset();
final int length = word.length(); final int length = word.length();
for (int i = 0; i < length; i = Character.offsetByCodePoints(word, i, 1)) { for (int i = 0; i < length; i = Character.offsetByCodePoints(word, i, 1)) {
int codePoint = Character.codePointAt(word, i); int codePoint = Character.codePointAt(word, i);
addKeyInfo(codePoint, keyboard, keyDetector); addKeyInfo(codePoint, keyboard);
} }
} }
/**
* Shortcut for the above method, this will create a new KeyDetector for the passed keyboard.
*/
public void setComposingWord(final CharSequence word, final Keyboard keyboard) {
final KeyDetector keyDetector = new KeyDetector(0);
keyDetector.setKeyboard(keyboard, 0, 0);
keyDetector.setProximityCorrectionEnabled(true);
setComposingWord(word, keyboard, keyDetector);
}
/** /**
* Delete the last keystroke as a result of hitting backspace. * Delete the last keystroke as a result of hitting backspace.
*/ */