Merge "Refactor show voice key preferece migration code"
This commit is contained in:
commit
a12d431c86
1 changed files with 8 additions and 8 deletions
|
@ -318,18 +318,18 @@ public final class SettingsValues {
|
||||||
|
|
||||||
private static boolean needsToShowVoiceInputKey(final SharedPreferences prefs,
|
private static boolean needsToShowVoiceInputKey(final SharedPreferences prefs,
|
||||||
final Resources res) {
|
final Resources res) {
|
||||||
if (!prefs.contains(Settings.PREF_VOICE_INPUT_KEY)) {
|
// Migrate preference from {@link Settings#PREF_VOICE_MODE_OBSOLETE} to
|
||||||
// Migrate preference from {@link Settings#PREF_VOICE_MODE_OBSOLETE} to
|
// {@link Settings#PREF_VOICE_INPUT_KEY}.
|
||||||
// {@link Settings#PREF_VOICE_INPUT_KEY}.
|
if (prefs.contains(Settings.PREF_VOICE_MODE_OBSOLETE)) {
|
||||||
final String voiceModeMain = res.getString(R.string.voice_mode_main);
|
final String voiceModeMain = res.getString(R.string.voice_mode_main);
|
||||||
final String voiceMode = prefs.getString(
|
final String voiceMode = prefs.getString(
|
||||||
Settings.PREF_VOICE_MODE_OBSOLETE, voiceModeMain);
|
Settings.PREF_VOICE_MODE_OBSOLETE, voiceModeMain);
|
||||||
final boolean shouldShowVoiceInputKey = voiceModeMain.equals(voiceMode);
|
final boolean shouldShowVoiceInputKey = voiceModeMain.equals(voiceMode);
|
||||||
prefs.edit().putBoolean(Settings.PREF_VOICE_INPUT_KEY, shouldShowVoiceInputKey).apply();
|
prefs.edit()
|
||||||
}
|
.putBoolean(Settings.PREF_VOICE_INPUT_KEY, shouldShowVoiceInputKey)
|
||||||
// Remove the obsolete preference if exists.
|
// Remove the obsolete preference if exists.
|
||||||
if (prefs.contains(Settings.PREF_VOICE_MODE_OBSOLETE)) {
|
.remove(Settings.PREF_VOICE_MODE_OBSOLETE)
|
||||||
prefs.edit().remove(Settings.PREF_VOICE_MODE_OBSOLETE).apply();
|
.apply();
|
||||||
}
|
}
|
||||||
return prefs.getBoolean(Settings.PREF_VOICE_INPUT_KEY, true);
|
return prefs.getBoolean(Settings.PREF_VOICE_INPUT_KEY, true);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue