nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge "Refactor show voice key preferece migration code"

main
Tadashi G. Takaoka 2014-06-05 09:33:03 +00:00 committed by Android (Google) Code Review
parent d6b89e17a6 fcaf47f007
commit a12d431c86
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
java/src/com/android/inputmethod/latin/settings/SettingsValues.java
View File

@ -318,18 +318,18 @@ public final class SettingsValues {
private static boolean needsToShowVoiceInputKey(final SharedPreferences prefs, private static boolean needsToShowVoiceInputKey(final SharedPreferences prefs,
final Resources res) { final Resources res) {
if (!prefs.contains(Settings.PREF_VOICE_INPUT_KEY)) { // Migrate preference from {@link Settings#PREF_VOICE_MODE_OBSOLETE} to
// Migrate preference from {@link Settings#PREF_VOICE_MODE_OBSOLETE} to // {@link Settings#PREF_VOICE_INPUT_KEY}.
// {@link Settings#PREF_VOICE_INPUT_KEY}. if (prefs.contains(Settings.PREF_VOICE_MODE_OBSOLETE)) {
final String voiceModeMain = res.getString(R.string.voice_mode_main); final String voiceModeMain = res.getString(R.string.voice_mode_main);
final String voiceMode = prefs.getString( final String voiceMode = prefs.getString(
Settings.PREF_VOICE_MODE_OBSOLETE, voiceModeMain); Settings.PREF_VOICE_MODE_OBSOLETE, voiceModeMain);
final boolean shouldShowVoiceInputKey = voiceModeMain.equals(voiceMode); final boolean shouldShowVoiceInputKey = voiceModeMain.equals(voiceMode);
prefs.edit().putBoolean(Settings.PREF_VOICE_INPUT_KEY, shouldShowVoiceInputKey).apply(); prefs.edit()
} .putBoolean(Settings.PREF_VOICE_INPUT_KEY, shouldShowVoiceInputKey)
// Remove the obsolete preference if exists. // Remove the obsolete preference if exists.
if (prefs.contains(Settings.PREF_VOICE_MODE_OBSOLETE)) { .remove(Settings.PREF_VOICE_MODE_OBSOLETE)
prefs.edit().remove(Settings.PREF_VOICE_MODE_OBSOLETE).apply(); .apply();
} }
return prefs.getBoolean(Settings.PREF_VOICE_INPUT_KEY, true); return prefs.getBoolean(Settings.PREF_VOICE_INPUT_KEY, true);
} }