Merge "[Rlog57a] include logUnit boundaries in output"

main
Kurt Partridge 2013-01-10 12:04:32 -08:00 committed by Android (Google) Code Review
commit a097004264
1 changed files with 58 additions and 16 deletions

View File

@ -114,24 +114,37 @@ import java.util.Map;
debugStringWriter = null; debugStringWriter = null;
debugJsonWriter = null; debugJsonWriter = null;
} }
final int size = mLogStatementList.size();
// Write out any logStatement that passes the privacy filter. // Write out any logStatement that passes the privacy filter.
for (int i = 0; i < size; i++) { final int size = mLogStatementList.size();
final LogStatement logStatement = mLogStatementList.get(i); if (size != 0) {
if (!isIncludingPrivateData && logStatement.mIsPotentiallyPrivate) { // Note that jsonWriter is only set to a non-null value if the logUnit start text is
continue; // output and at least one logStatement is output.
JsonWriter jsonWriter = null;
for (int i = 0; i < size; i++) {
final LogStatement logStatement = mLogStatementList.get(i);
if (!isIncludingPrivateData && logStatement.mIsPotentiallyPrivate) {
continue;
}
if (mIsPartOfMegaword && logStatement.mIsPotentiallyRevealing) {
continue;
}
// Only retrieve the jsonWriter if we need to. If we don't get this far, then
// researchLog.getValidJsonWriterLocked() will not ever be called, and the file
// will not have been opened for writing.
if (jsonWriter == null) {
jsonWriter = researchLog.getValidJsonWriterLocked();
outputLogUnitStart(jsonWriter);
}
outputLogStatementToLocked(jsonWriter, mLogStatementList.get(i), mValuesList.get(i),
mTimeList.get(i));
if (DEBUG) {
outputLogStatementToLocked(debugJsonWriter, mLogStatementList.get(i),
mValuesList.get(i), mTimeList.get(i));
}
} }
if (mIsPartOfMegaword && logStatement.mIsPotentiallyRevealing) { if (jsonWriter != null) {
continue; // We must have called logUnitStart earlier, so emit a logUnitStop.
} outputLogUnitStop(jsonWriter, isIncludingPrivateData);
// Only retrieve the jsonWriter if we need to. If we don't get this far, then
// researchLog.getValidJsonWriter() will not open the file for writing.
final JsonWriter jsonWriter = researchLog.getValidJsonWriterLocked();
outputLogStatementToLocked(jsonWriter, mLogStatementList.get(i), mValuesList.get(i),
mTimeList.get(i));
if (DEBUG) {
outputLogStatementToLocked(debugJsonWriter, mLogStatementList.get(i),
mValuesList.get(i), mTimeList.get(i));
} }
} }
if (DEBUG) { if (DEBUG) {
@ -152,6 +165,35 @@ import java.util.Map;
private static final String CURRENT_TIME_KEY = "_ct"; private static final String CURRENT_TIME_KEY = "_ct";
private static final String UPTIME_KEY = "_ut"; private static final String UPTIME_KEY = "_ut";
private static final String EVENT_TYPE_KEY = "_ty"; private static final String EVENT_TYPE_KEY = "_ty";
private static final String WORD_KEY = "_wo";
private static final String LOG_UNIT_BEGIN_KEY = "logUnitStart";
private static final String LOG_UNIT_END_KEY = "logUnitEnd";
private void outputLogUnitStart(final JsonWriter jsonWriter) {
try {
jsonWriter.beginObject();
jsonWriter.name(CURRENT_TIME_KEY).value(System.currentTimeMillis());
jsonWriter.name(WORD_KEY).value(getWord());
jsonWriter.name(EVENT_TYPE_KEY).value(LOG_UNIT_BEGIN_KEY);
jsonWriter.endObject();
} catch (IOException e) {
e.printStackTrace();
Log.w(TAG, "Error in JsonWriter; cannot write LogUnitStart");
}
}
private void outputLogUnitStop(final JsonWriter jsonWriter,
final boolean isIncludingPrivateData) {
try {
jsonWriter.beginObject();
jsonWriter.name(CURRENT_TIME_KEY).value(System.currentTimeMillis());
jsonWriter.name(EVENT_TYPE_KEY).value(LOG_UNIT_END_KEY);
jsonWriter.endObject();
} catch (IOException e) {
e.printStackTrace();
Log.w(TAG, "Error in JsonWriter; cannot write LogUnitStop");
}
}
/** /**
* Write the logStatement and its contents out through jsonWriter. * Write the logStatement and its contents out through jsonWriter.