nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix important notice strip text layout 

Bug: 10587358
Change-Id: I9cbdd3b450e05d6d0611a16b6b7fad945918dd5f
main
Tadashi G. Takaoka 2014-02-03 15:08:07 +09:00
parent 9221772ab7
commit 9706f9a2f4
3 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
java/res/layout/suggestions_strip.xml
View File

@ -52,9 +52,9 @@
android:layout_height="match_parent"> android:layout_height="match_parent">
<TextView <TextView
android:id="@+id/important_notice_title" android:id="@+id/important_notice_title"
android:layout_width="0dp" android:text="@string/important_notice_title"
android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
android:layout_weight="1.0"
android:textSize="14sp" android:textSize="14sp"
style="?attr/suggestionWordStyle" /> style="?attr/suggestionWordStyle" />
</LinearLayout> </LinearLayout>

12
java/src/com/android/inputmethod/latin/suggestions/SuggestionStripLayoutHelper.java
View File

@ -502,12 +502,18 @@ final class SuggestionStripLayoutHelper {
titleView.setTextColor(mColorAutoCorrect); titleView.setTextColor(mColorAutoCorrect);
TextViewCompatUtils.setCompoundDrawablesRelativeWithIntrinsicBounds( TextViewCompatUtils.setCompoundDrawablesRelativeWithIntrinsicBounds(
titleView, infoIcon, null, moreIcon, null); titleView, infoIcon, null, moreIcon, null);
final CharSequence importantNoticeTitle = res.getText(R.string.important_notice_title); final CharSequence importantNoticeTitle = titleView.getText();
titleView.setTextScaleX(1.0f); // Reset textScaleX. titleView.setTextScaleX(1.0f); // Reset textScaleX.
final float titleScaleX = getTextScaleX(importantNoticeTitle, width, titleView.getPaint()); // When the suggestions strip is displayed first time, stripWidth may be zero.
titleView.setText(importantNoticeTitle); // Then importantNoticeTitle will be displayed as is without auto text scaleX.
// TODO: Fix the logic to always have a correct value of stripWidth.
if (width > 0) {
// Auto text scaleX to show entire important notice title should be on the strip.
final float titleScaleX = getTextScaleX(
importantNoticeTitle, width, titleView.getPaint());
titleView.setTextScaleX(titleScaleX); titleView.setTextScaleX(titleScaleX);
} }
}
static void setLayoutWeight(final View v, final float weight, final int height) { static void setLayoutWeight(final View v, final float weight, final int height) {
final ViewGroup.LayoutParams lp = v.getLayoutParams(); final ViewGroup.LayoutParams lp = v.getLayoutParams();

1
java/src/com/android/inputmethod/latin/suggestions/SuggestionStripView.java
View File

@ -220,6 +220,7 @@ public final class SuggestionStripView extends RelativeLayout implements OnClick
return false; return false;
} }
// TODO: This method should be called after this View has been attached and displayed.
public void showImportantNoticeTitle() { public void showImportantNoticeTitle() {
mLayoutHelper.layoutImportantNotice(mImportantNoticeStrip, getWidth()); mLayoutHelper.layoutImportantNotice(mImportantNoticeStrip, getWidth());
mStripVisibilityGroup.showImportantNoticeStrip(); mStripVisibilityGroup.showImportantNoticeStrip();