nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[IL51] Make private what can be made private 

Bug: 8636060
Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
main
Jean Chalard 2013-12-25 21:32:44 +09:00
parent 53c320e275
commit 8ce921dd6b
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java
View File

@ -88,12 +88,12 @@ public final class InputLogic {
public int mLastSelectionStart = Constants.NOT_A_CURSOR_POSITION; public int mLastSelectionStart = Constants.NOT_A_CURSOR_POSITION;
public int mLastSelectionEnd = Constants.NOT_A_CURSOR_POSITION; public int mLastSelectionEnd = Constants.NOT_A_CURSOR_POSITION;
public int mDeleteCount; private int mDeleteCount;
private long mLastKeyTime; private long mLastKeyTime;
public final TreeSet<Long> mCurrentlyPressedHardwareKeys = CollectionUtils.newTreeSet(); public final TreeSet<Long> mCurrentlyPressedHardwareKeys = CollectionUtils.newTreeSet();
// Keeps track of most recently inserted text (multi-character key) for reverting // Keeps track of most recently inserted text (multi-character key) for reverting
public String mEnteredText; private String mEnteredText;
// TODO: This boolean is persistent state and causes large side effects at unexpected times. // TODO: This boolean is persistent state and causes large side effects at unexpected times.
// Find a way to remove it for readability. // Find a way to remove it for readability.
@ -1604,8 +1604,7 @@ public final class InputLogic {
* @param settingsValues the current value of the settings. * @param settingsValues the current value of the settings.
* @param separator the separator that's causing the commit to happen. * @param separator the separator that's causing the commit to happen.
*/ */
// TODO: Make this private private void commitCurrentAutoCorrection(final SettingsValues settingsValues,
public void commitCurrentAutoCorrection(final SettingsValues settingsValues,
final String separator, final String separator,
// TODO: Remove this argument. // TODO: Remove this argument.
final LatinIME.UIHandler handler) { final LatinIME.UIHandler handler) {
@ -1697,8 +1696,7 @@ public final class InputLogic {
* detect the most damaging cases: when the cursor position is declared to be much smaller * detect the most damaging cases: when the cursor position is declared to be much smaller
* than it really is. * than it really is.
*/ */
// TODO: make this private private void tryFixLyingCursorPosition() {
public void tryFixLyingCursorPosition() {
final CharSequence textBeforeCursor = mConnection.getTextBeforeCursor( final CharSequence textBeforeCursor = mConnection.getTextBeforeCursor(
Constants.EDITOR_CONTENTS_CACHE_SIZE, 0); Constants.EDITOR_CONTENTS_CACHE_SIZE, 0);
if (null == textBeforeCursor) { if (null == textBeforeCursor) {