nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge "Use isFirstCharUppercase instead of get first code point."

main
Keisuke Kuroyanagi 2014-03-10 11:42:22 +00:00 committed by Android (Google) Code Review
parent 5c2f55fe6e b43ea5c335
commit 89dbd056d1
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
native/jni/src/suggest/core/dicnode/dic_node.h
View File

@ -218,7 +218,7 @@ class DicNode {
} }
bool isFirstCharUppercase() const { bool isFirstCharUppercase() const {
const int c = getOutputWordBuf()[0]; const int c = mDicNodeState.mDicNodeStateOutput.getCodePointAt(0);
return CharUtils::isAsciiUpper(c); return CharUtils::isAsciiUpper(c);
} }

1
native/jni/src/suggest/core/dicnode/internal/dic_node_state_output.h
View File

@ -61,7 +61,6 @@ class DicNodeStateOutput {
} }
} }
// TODO: Remove
int getCodePointAt(const int index) const { int getCodePointAt(const int index) const {
return mCodePointsBuf[index]; return mCodePointsBuf[index];
} }

3
native/jni/src/suggest/policyimpl/typing/typing_traversal.h
View File

@ -162,9 +162,8 @@ class TypingTraversal : public Traversal {
if (probability < ScoringParams::THRESHOLD_NEXT_WORD_PROBABILITY) { if (probability < ScoringParams::THRESHOLD_NEXT_WORD_PROBABILITY) {
return false; return false;
} }
const int c = dicNode->getOutputWordBuf()[0];
const bool shortCappedWord = dicNode->getNodeCodePointCount() const bool shortCappedWord = dicNode->getNodeCodePointCount()
< ScoringParams::THRESHOLD_SHORT_WORD_LENGTH && CharUtils::isAsciiUpper(c); < ScoringParams::THRESHOLD_SHORT_WORD_LENGTH && dicNode->isFirstCharUppercase();
return !shortCappedWord return !shortCappedWord
|| probability >= ScoringParams::THRESHOLD_NEXT_WORD_PROBABILITY_FOR_CAPPED; || probability >= ScoringParams::THRESHOLD_NEXT_WORD_PROBABILITY_FOR_CAPPED;
} }