Fix performance-for-range-copy warnings
Bug: 30413223 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance* Change-Id: I06021a6597705515dc7a3cb81a7fbbac7ba344a1
This commit is contained in:
parent
55748c5936
commit
895bf97d22
3 changed files with 4 additions and 4 deletions
|
@ -93,7 +93,7 @@ const WordProperty *OffdeviceIntermediateDict::getWordProperty(
|
|||
const OffdeviceIntermediateDictPtNodeArray *ptNodeArray = &mRootPtNodeArray;
|
||||
for (size_t i = 0; i < codePoints.size();) {
|
||||
bool foundNext = false;
|
||||
for (const auto ptNode : ptNodeArray->getPtNodeList()) {
|
||||
for (const auto& ptNode : ptNodeArray->getPtNodeList()) {
|
||||
const CodePointArrayView ptNodeCodePoints = ptNode->getPtNodeCodePoints();
|
||||
if (codePoints[i] < ptNodeCodePoints[0]) {
|
||||
continue;
|
||||
|
|
|
@ -141,7 +141,7 @@ void Ver4PatriciaTriePolicy::iterateNgramEntries(const WordIdArrayView prevWordI
|
|||
}
|
||||
const auto languageModelDictContent = mBuffers->getLanguageModelDictContent();
|
||||
for (size_t i = 1; i <= prevWordIds.size(); ++i) {
|
||||
for (const auto entry : languageModelDictContent->getProbabilityEntries(
|
||||
for (const auto& entry : languageModelDictContent->getProbabilityEntries(
|
||||
prevWordIds.limit(i))) {
|
||||
const ProbabilityEntry &probabilityEntry = entry.getProbabilityEntry();
|
||||
if (!probabilityEntry.isValid()) {
|
||||
|
@ -516,7 +516,7 @@ const WordProperty Ver4PatriciaTriePolicy::getWordProperty(
|
|||
int ngramPrevWordsCodePoints[MAX_PREV_WORD_COUNT_FOR_N_GRAM][MAX_WORD_LENGTH];
|
||||
int ngramPrevWordsCodePointCount[MAX_PREV_WORD_COUNT_FOR_N_GRAM];
|
||||
bool ngramPrevWordIsBeginningOfSentense[MAX_PREV_WORD_COUNT_FOR_N_GRAM];
|
||||
for (const auto entry : languageModelDictContent->exportAllNgramEntriesRelatedToWord(
|
||||
for (const auto& entry : languageModelDictContent->exportAllNgramEntriesRelatedToWord(
|
||||
mHeaderPolicy, wordId)) {
|
||||
const int codePointCount = getCodePointsAndReturnCodePointCount(entry.getTargetWordId(),
|
||||
MAX_WORD_LENGTH, ngramTargetCodePoints);
|
||||
|
|
|
@ -80,7 +80,7 @@ TEST(LanguageModelDictContentTest, TestIterateProbabilityEntry) {
|
|||
languageModelDictContent.setProbabilityEntry(wordId, &originalEntry);
|
||||
}
|
||||
std::unordered_set<int> wordIdSet(std::begin(wordIds), std::end(wordIds));
|
||||
for (const auto entry : languageModelDictContent.getProbabilityEntries(WordIdArrayView())) {
|
||||
for (const auto& entry : languageModelDictContent.getProbabilityEntries(WordIdArrayView())) {
|
||||
EXPECT_EQ(originalEntry.getFlags(), entry.getProbabilityEntry().getFlags());
|
||||
EXPECT_EQ(originalEntry.getProbability(), entry.getProbabilityEntry().getProbability());
|
||||
wordIdSet.erase(entry.getWordId());
|
||||
|
|
Loading…
Reference in a new issue