From 8ce921dd6ba5c63a2dc44b7578a3587aa7dc75c7 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Wed, 25 Dec 2013 21:32:44 +0900 Subject: [PATCH] [IL51] Make private what can be made private Bug: 8636060 Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad --- .../inputmethod/latin/inputlogic/InputLogic.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java b/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java index 899341f1a..ced3f049b 100644 --- a/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java +++ b/java/src/com/android/inputmethod/latin/inputlogic/InputLogic.java @@ -88,12 +88,12 @@ public final class InputLogic { public int mLastSelectionStart = Constants.NOT_A_CURSOR_POSITION; public int mLastSelectionEnd = Constants.NOT_A_CURSOR_POSITION; - public int mDeleteCount; + private int mDeleteCount; private long mLastKeyTime; public final TreeSet mCurrentlyPressedHardwareKeys = CollectionUtils.newTreeSet(); // Keeps track of most recently inserted text (multi-character key) for reverting - public String mEnteredText; + private String mEnteredText; // TODO: This boolean is persistent state and causes large side effects at unexpected times. // Find a way to remove it for readability. @@ -1604,8 +1604,7 @@ public final class InputLogic { * @param settingsValues the current value of the settings. * @param separator the separator that's causing the commit to happen. */ - // TODO: Make this private - public void commitCurrentAutoCorrection(final SettingsValues settingsValues, + private void commitCurrentAutoCorrection(final SettingsValues settingsValues, final String separator, // TODO: Remove this argument. final LatinIME.UIHandler handler) { @@ -1697,8 +1696,7 @@ public final class InputLogic { * detect the most damaging cases: when the cursor position is declared to be much smaller * than it really is. */ - // TODO: make this private - public void tryFixLyingCursorPosition() { + private void tryFixLyingCursorPosition() { final CharSequence textBeforeCursor = mConnection.getTextBeforeCursor( Constants.EDITOR_CONTENTS_CACHE_SIZE, 0); if (null == textBeforeCursor) {