nyancrimew
/
LatinIME
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a bug when deleting the last char 

And unit test

Change-Id: Ic4fc3626f8b86e10156d770d41cd6deab5d31f39
main
Jean Chalard 2012-02-03 12:22:02 +09:00
parent 71915a3722
commit 825e2bbd91
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
java/src/com/android/inputmethod/latin/WordComposer.java
View File

@ -212,6 +212,7 @@ public class WordComposer {
final int lastPos = size - 1; final int lastPos = size - 1;
char lastChar = mTypedWord.charAt(lastPos); char lastChar = mTypedWord.charAt(lastPos);
mCodes.remove(lastPos); mCodes.remove(lastPos);
// TODO: This crashes and catches fire if the code point doesn't fit a char
mTypedWord.deleteCharAt(lastPos); mTypedWord.deleteCharAt(lastPos);
if (Character.isUpperCase(lastChar)) mCapsCount--; if (Character.isUpperCase(lastChar)) mCapsCount--;
} }
@ -221,8 +222,9 @@ public class WordComposer {
if (mTrailingSingleQuotesCount > 0) { if (mTrailingSingleQuotesCount > 0) {
--mTrailingSingleQuotesCount; --mTrailingSingleQuotesCount;
} else { } else {
for (int i = mTypedWord.offsetByCodePoints(mTypedWord.length(), -1); int i = mTypedWord.length();
i >= 0; i = mTypedWord.offsetByCodePoints(i, -1)) { while (i > 0) {
i = mTypedWord.offsetByCodePoints(i, -1);
if (Keyboard.CODE_SINGLE_QUOTE != mTypedWord.codePointAt(i)) break; if (Keyboard.CODE_SINGLE_QUOTE != mTypedWord.codePointAt(i)) break;
++mTrailingSingleQuotesCount; ++mTrailingSingleQuotesCount;
} }

9
tests/src/com/android/inputmethod/latin/InputLogicTests.java
View File

@ -291,4 +291,13 @@ public class InputLogicTests extends ServiceTestCase<LatinIME> {
assertEquals("manual pick then space then type", WORD1_TO_TYPE + WORD2_TO_TYPE, assertEquals("manual pick then space then type", WORD1_TO_TYPE + WORD2_TO_TYPE,
mTextView.getText().toString()); mTextView.getText().toString());
} }
public void testDeleteWholeComposingWord() {
final String WORD_TO_TYPE = "this";
type(WORD_TO_TYPE);
for (int i = 0; i < WORD_TO_TYPE.length(); ++i) {
type(Keyboard.CODE_DELETE);
}
assertEquals("delete whole composing word", "", mTextView.getText().toString());
}
} }