From ab334eb64669e909f0a401fddffa891962002602 Mon Sep 17 00:00:00 2001 From: "Tadashi G. Takaoka" Date: Mon, 21 Jan 2013 18:02:09 +0900 Subject: [PATCH] Add PointerTracker.isOldestPointerInQueue Change-Id: Ic6f38253c94067ec7aa7b5add4452fa144fd9352 --- .../inputmethod/keyboard/MainKeyboardView.java | 5 ++--- .../android/inputmethod/keyboard/PointerTracker.java | 12 ++++++------ .../keyboard/internal/PreviewPlacerView.java | 4 ++-- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java b/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java index ba9cb1f1e..1ce61fbcc 100644 --- a/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java +++ b/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java @@ -888,10 +888,9 @@ public final class MainKeyboardView extends KeyboardView implements PointerTrack mDrawingHandler.dismissGestureFloatingPreviewText(mGestureFloatingPreviewTextLingerTimeout); } - public void showGesturePreviewTrail(final PointerTracker tracker, - final boolean isOldestTracker) { + public void showGesturePreviewTrail(final PointerTracker tracker) { locatePreviewPlacerView(); - mPreviewPlacerView.invalidatePointer(tracker, isOldestTracker); + mPreviewPlacerView.invalidatePointer(tracker); } // Note that this method is called from a non-UI thread. diff --git a/java/src/com/android/inputmethod/keyboard/PointerTracker.java b/java/src/com/android/inputmethod/keyboard/PointerTracker.java index 036372c37..469076f59 100644 --- a/java/src/com/android/inputmethod/keyboard/PointerTracker.java +++ b/java/src/com/android/inputmethod/keyboard/PointerTracker.java @@ -83,7 +83,7 @@ public final class PointerTracker implements PointerTrackerQueue.Element { public void dismissKeyPreview(PointerTracker tracker); public void showSlidingKeyInputPreview(PointerTracker tracker); public void dismissSlidingKeyInputPreview(); - public void showGesturePreviewTrail(PointerTracker tracker, boolean isOldestTracker); + public void showGesturePreviewTrail(PointerTracker tracker); } public interface TimerProxy { @@ -709,8 +709,8 @@ public final class PointerTracker implements PointerTrackerQueue.Element { return sPointerTrackerQueue.size(); } - private static boolean isOldestTrackerInQueue(final PointerTracker tracker) { - return sPointerTrackerQueue.getOldestElement() == tracker; + public boolean isOldestTrackerInQueue() { + return sPointerTrackerQueue.getOldestElement() == this; } private void mayStartBatchInput(final Key key) { @@ -732,7 +732,7 @@ public final class PointerTracker implements PointerTrackerQueue.Element { dismissAllMoreKeysPanels(); } mTimerProxy.cancelLongPressTimer(); - mDrawingProxy.showGesturePreviewTrail(this, isOldestTrackerInQueue(this)); + mDrawingProxy.showGesturePreviewTrail(this); } public void updateBatchInputByTimer(final long eventTime) { @@ -748,7 +748,7 @@ public final class PointerTracker implements PointerTrackerQueue.Element { if (mIsTrackingCanceled) { return; } - mDrawingProxy.showGesturePreviewTrail(this, isOldestTrackerInQueue(this)); + mDrawingProxy.showGesturePreviewTrail(this); } private void updateBatchInput(final long eventTime) { @@ -789,7 +789,7 @@ public final class PointerTracker implements PointerTrackerQueue.Element { if (mIsTrackingCanceled) { return; } - mDrawingProxy.showGesturePreviewTrail(this, isOldestTrackerInQueue(this)); + mDrawingProxy.showGesturePreviewTrail(this); } private void cancelBatchInput() { diff --git a/java/src/com/android/inputmethod/keyboard/internal/PreviewPlacerView.java b/java/src/com/android/inputmethod/keyboard/internal/PreviewPlacerView.java index d34474227..3ffdfbaa5 100644 --- a/java/src/com/android/inputmethod/keyboard/internal/PreviewPlacerView.java +++ b/java/src/com/android/inputmethod/keyboard/internal/PreviewPlacerView.java @@ -133,9 +133,9 @@ public final class PreviewPlacerView extends RelativeLayout { mGestureFloatingPreviewText.setPreviewEnabled(drawsGestureFloatingPreviewText); } - public void invalidatePointer(final PointerTracker tracker, final boolean isOldestTracker) { + public void invalidatePointer(final PointerTracker tracker) { final boolean needsToUpdateLastPointer = - isOldestTracker && mGestureFloatingPreviewText.isPreviewEnabled(); + tracker.isOldestTrackerInQueue() && mGestureFloatingPreviewText.isPreviewEnabled(); if (needsToUpdateLastPointer) { mGestureFloatingPreviewText.setPreviewPosition(tracker); }